2019-05-19 16:51:43 +03:00
// SPDX-License-Identifier: GPL-2.0-or-later
2005-08-31 20:53:10 +04:00
/*
* ASIX AX8817X based USB 2.0 Ethernet Devices
2006-07-29 18:12:50 +04:00
* Copyright ( C ) 2003 - 2006 David Hollis < dhollis @ davehollis . com >
2005-08-31 20:53:10 +04:00
* Copyright ( C ) 2005 Phil Chang < pchang23 @ sbcglobal . net >
2006-07-29 18:12:50 +04:00
* Copyright ( C ) 2006 James Painter < jamie . painter @ iname . com >
2005-08-31 20:53:10 +04:00
* Copyright ( c ) 2002 - 2003 TiVo Inc .
*/
2012-07-13 09:26:30 +04:00
# include "asix.h"
2021-12-21 23:10:43 +03:00
# define AX_HOST_EN_RETRIES 30
2022-02-06 21:05:16 +03:00
int __must_check asix_read_cmd ( struct usbnet * dev , u8 cmd , u16 value , u16 index ,
u16 size , void * data , int in_pm )
2005-08-31 20:53:10 +04:00
{
2012-10-24 23:46:55 +04:00
int ret ;
2016-08-29 16:32:15 +03:00
int ( * fn ) ( struct usbnet * , u8 , u8 , u16 , u16 , void * , u16 ) ;
BUG_ON ( ! dev ) ;
if ( ! in_pm )
fn = usbnet_read_cmd ;
else
fn = usbnet_read_cmd_nopm ;
ret = fn ( dev , cmd , USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE ,
value , index , data , size ) ;
2022-02-06 21:05:16 +03:00
if ( unlikely ( ret < size ) ) {
ret = ret < 0 ? ret : - ENODATA ;
2016-08-29 16:32:15 +03:00
netdev_warn ( dev - > net , " Failed to read reg index 0x%04x: %d \n " ,
index , ret ) ;
2022-02-06 21:05:16 +03:00
}
2012-10-24 23:46:55 +04:00
return ret ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
int asix_write_cmd ( struct usbnet * dev , u8 cmd , u16 value , u16 index ,
2016-08-29 16:32:15 +03:00
u16 size , void * data , int in_pm )
2005-08-31 20:53:10 +04:00
{
2016-08-29 16:32:15 +03:00
int ret ;
int ( * fn ) ( struct usbnet * , u8 , u8 , u16 , u16 , const void * , u16 ) ;
BUG_ON ( ! dev ) ;
if ( ! in_pm )
fn = usbnet_write_cmd ;
else
fn = usbnet_write_cmd_nopm ;
ret = fn ( dev , cmd , USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE ,
value , index , data , size ) ;
if ( unlikely ( ret < 0 ) )
netdev_warn ( dev - > net , " Failed to write reg index 0x%04x: %d \n " ,
index , ret ) ;
return ret ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
void asix_write_cmd_async ( struct usbnet * dev , u8 cmd , u16 value , u16 index ,
u16 size , void * data )
2006-07-29 18:12:50 +04:00
{
2012-10-24 23:46:55 +04:00
usbnet_write_cmd_async ( dev , cmd ,
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE ,
value , index , data , size ) ;
2006-07-29 18:12:50 +04:00
}
2022-07-04 15:34:48 +03:00
static int asix_set_sw_mii ( struct usbnet * dev , int in_pm )
{
int ret ;
ret = asix_write_cmd ( dev , AX_CMD_SET_SW_MII , 0x0000 , 0 , 0 , NULL , in_pm ) ;
if ( ret < 0 )
netdev_err ( dev - > net , " Failed to enable software MII access \n " ) ;
return ret ;
}
static int asix_set_hw_mii ( struct usbnet * dev , int in_pm )
{
int ret ;
ret = asix_write_cmd ( dev , AX_CMD_SET_HW_MII , 0x0000 , 0 , 0 , NULL , in_pm ) ;
if ( ret < 0 )
netdev_err ( dev - > net , " Failed to enable hardware MII access \n " ) ;
return ret ;
}
2021-08-17 19:37:23 +03:00
static int asix_check_host_enable ( struct usbnet * dev , int in_pm )
{
int i , ret ;
u8 smsr ;
2021-12-21 23:10:43 +03:00
for ( i = 0 ; i < AX_HOST_EN_RETRIES ; + + i ) {
2021-08-17 19:37:23 +03:00
ret = asix_set_sw_mii ( dev , in_pm ) ;
if ( ret = = - ENODEV | | ret = = - ETIMEDOUT )
break ;
usleep_range ( 1000 , 1100 ) ;
ret = asix_read_cmd ( dev , AX_CMD_STATMNGSTS_REG ,
0 , 0 , 1 , & smsr , in_pm ) ;
if ( ret = = - ENODEV )
break ;
2022-02-06 21:05:16 +03:00
else if ( ret < 0 )
2021-08-17 19:37:23 +03:00
continue ;
else if ( smsr & AX_HOST_EN )
break ;
}
2021-12-21 23:10:43 +03:00
return i > = AX_HOST_EN_RETRIES ? - ETIMEDOUT : ret ;
2021-08-17 19:37:23 +03:00
}
2017-08-07 11:50:15 +03:00
static void reset_asix_rx_fixup_info ( struct asix_rx_fixup_info * rx )
{
/* Reset the variables that have a lifetime outside of
* asix_rx_fixup_internal ( ) so that future processing starts from a
* known set of initial conditions .
*/
if ( rx - > ax_skb ) {
/* Discard any incomplete Ethernet frame in the netdev buffer */
kfree_skb ( rx - > ax_skb ) ;
rx - > ax_skb = NULL ;
}
/* Assume the Data header 32-bit word is at the start of the current
* or next URB socket buffer so reset all the state variables .
*/
rx - > remaining = 0 ;
rx - > split_head = false ;
rx - > header = 0 ;
}
2013-01-16 08:24:07 +04:00
int asix_rx_fixup_internal ( struct usbnet * dev , struct sk_buff * skb ,
struct asix_rx_fixup_info * rx )
2006-07-29 18:12:50 +04:00
{
2012-03-15 00:18:32 +04:00
int offset = 0 ;
2015-10-02 16:29:04 +03:00
u16 size ;
2006-07-29 18:12:50 +04:00
2015-10-02 16:29:07 +03:00
/* When an Ethernet frame spans multiple URB socket buffers,
* do a sanity test for the Data header synchronisation .
* Attempt to detect the situation of the previous socket buffer having
* been truncated or a socket buffer was missing . These situations
* cause a discontinuity in the data stream and therefore need to avoid
* appending bad data to the end of the current netdev socket buffer .
* Also avoid unnecessarily discarding a good current netdev socket
* buffer .
*/
if ( rx - > remaining & & ( rx - > remaining + sizeof ( u32 ) < = skb - > len ) ) {
asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions
In testing with HiKey, we found that since
commit 3f30b158eba5 ("asix: On RX avoid creating bad Ethernet
frames"),
we're seeing lots of noise during network transfers:
[ 239.027993] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988
[ 239.037310] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0x54ebb5ec, offset 4
[ 239.045519] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0xcdffe7a2, offset 4
[ 239.275044] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988
[ 239.284355] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0x1d36f59d, offset 4
[ 239.292541] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0xaef3c1e9, offset 4
[ 239.518996] asix 1-1.1:1.0 eth0: asix_rx_fixup() Data Header synchronisation was lost, remaining 988
[ 239.528300] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0x2881912, offset 4
[ 239.536413] asix 1-1.1:1.0 eth0: asix_rx_fixup() Bad Header Length 0x5638f7e2, offset 4
And network throughput ends up being pretty bursty and slow with
a overall throughput of at best ~30kB/s (where as previously we
got 1.1MB/s with the slower USB1.1 "full speed" host).
We found the issue also was reproducible on a x86_64 system,
using a "high-speed" USB2.0 port but the throughput did not
measurably drop (possibly due to the scp transfer being cpu
bound on my slow test hardware).
After lots of debugging, I found the check added in the
problematic commit seems to be calculating the offset
incorrectly.
In the normal case, in the main loop of the function, we do:
(where offset is zero, or set to "offset += (copy_length + 1) &
0xfffe" in the previous loop)
rx->header = get_unaligned_le32(skb->data +
offset);
offset += sizeof(u32);
But the problematic patch calculates:
offset = ((rx->remaining + 1) & 0xfffe) + sizeof(u32);
rx->header = get_unaligned_le32(skb->data + offset);
Adding some debug logic to check those offset calculation used
to find rx->header, the one in problematic code is always too
large by sizeof(u32).
Thus, this patch removes the incorrect " + sizeof(u32)" addition
in the problematic calculation, and resolves the issue.
Cc: Dean Jenkins <Dean_Jenkins@mentor.com>
Cc: "David B. Robins" <linux@davidrobins.net>
Cc: Mark Craske <Mark_Craske@mentor.com>
Cc: Emil Goode <emilgoode@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: YongQin Liu <yongqin.liu@linaro.org>
Cc: Guodong Xu <guodong.xu@linaro.org>
Cc: Ivan Vecera <ivecera@redhat.com>
Cc: linux-usb@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: stable <stable@vger.kernel.org> #4.4+
Reported-by: Yongqin Liu <yongqin.liu@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-05-17 06:36:15 +03:00
offset = ( ( rx - > remaining + 1 ) & 0xfffe ) ;
2015-10-02 16:29:07 +03:00
rx - > header = get_unaligned_le32 ( skb - > data + offset ) ;
offset = 0 ;
size = ( u16 ) ( rx - > header & 0x7ff ) ;
if ( size ! = ( ( ~ rx - > header > > 16 ) & 0x7ff ) ) {
netdev_err ( dev - > net , " asix_rx_fixup() Data Header synchronisation was lost, remaining %d \n " ,
rx - > remaining ) ;
2017-08-07 11:50:15 +03:00
reset_asix_rx_fixup_info ( rx ) ;
2015-10-02 16:29:07 +03:00
}
}
2013-01-16 08:24:07 +04:00
while ( offset + sizeof ( u16 ) < = skb - > len ) {
2015-10-02 16:29:04 +03:00
u16 copy_length ;
2006-07-29 18:12:50 +04:00
2015-10-02 16:29:04 +03:00
if ( ! rx - > remaining ) {
2015-10-02 16:29:05 +03:00
if ( skb - > len - offset = = sizeof ( u16 ) ) {
rx - > header = get_unaligned_le16 (
skb - > data + offset ) ;
rx - > split_head = true ;
offset + = sizeof ( u16 ) ;
break ;
}
if ( rx - > split_head = = true ) {
rx - > header | = ( get_unaligned_le16 (
skb - > data + offset ) < < 16 ) ;
rx - > split_head = false ;
offset + = sizeof ( u16 ) ;
2013-01-16 08:24:07 +04:00
} else {
rx - > header = get_unaligned_le32 ( skb - > data +
offset ) ;
offset + = sizeof ( u32 ) ;
}
2011-07-26 20:44:46 +04:00
2015-10-02 16:29:04 +03:00
/* take frame length from Data header 32-bit word */
size = ( u16 ) ( rx - > header & 0x7ff ) ;
if ( size ! = ( ( ~ rx - > header > > 16 ) & 0x7ff ) ) {
2013-01-16 08:24:07 +04:00
netdev_err ( dev - > net , " asix_rx_fixup() Bad Header Length 0x%x, offset %d \n " ,
rx - > header , offset ) ;
2017-08-07 11:50:15 +03:00
reset_asix_rx_fixup_info ( rx ) ;
2013-01-16 08:24:07 +04:00
return 0 ;
}
2015-10-02 16:29:06 +03:00
if ( size > dev - > net - > mtu + ETH_HLEN + VLAN_HLEN ) {
2015-12-18 04:51:16 +03:00
netdev_dbg ( dev - > net , " asix_rx_fixup() Bad RX Length %d \n " ,
2015-10-02 16:29:06 +03:00
size ) ;
2017-08-07 11:50:15 +03:00
reset_asix_rx_fixup_info ( rx ) ;
2015-10-02 16:29:06 +03:00
return 0 ;
}
2015-10-02 16:29:08 +03:00
/* Sometimes may fail to get a netdev socket buffer but
* continue to process the URB socket buffer so that
* synchronisation of the Ethernet frame Data header
* word is maintained .
*/
2015-10-02 16:29:04 +03:00
rx - > ax_skb = netdev_alloc_skb_ip_align ( dev - > net , size ) ;
2010-05-18 04:18:28 +04:00
2015-10-02 16:29:06 +03:00
rx - > remaining = size ;
2006-07-29 18:12:50 +04:00
}
2015-10-02 16:29:04 +03:00
if ( rx - > remaining > skb - > len - offset ) {
copy_length = skb - > len - offset ;
rx - > remaining - = copy_length ;
} else {
copy_length = rx - > remaining ;
rx - > remaining = 0 ;
2013-01-16 08:24:07 +04:00
}
2006-07-29 18:12:50 +04:00
2015-10-02 16:29:08 +03:00
if ( rx - > ax_skb ) {
2017-06-18 17:52:04 +03:00
skb_put_data ( rx - > ax_skb , skb - > data + offset ,
copy_length ) ;
2017-08-07 11:50:14 +03:00
if ( ! rx - > remaining ) {
2015-10-02 16:29:08 +03:00
usbnet_skb_return ( dev , rx - > ax_skb ) ;
2017-08-07 11:50:14 +03:00
rx - > ax_skb = NULL ;
}
2015-10-02 16:29:08 +03:00
}
2013-01-16 08:24:07 +04:00
2015-10-02 16:29:04 +03:00
offset + = ( copy_length + 1 ) & 0xfffe ;
2006-07-29 18:12:50 +04:00
}
2012-03-15 00:18:32 +04:00
if ( skb - > len ! = offset ) {
2013-01-16 08:24:07 +04:00
netdev_err ( dev - > net , " asix_rx_fixup() Bad SKB Length %d, %d \n " ,
skb - > len , offset ) ;
2017-08-07 11:50:15 +03:00
reset_asix_rx_fixup_info ( rx ) ;
2006-07-29 18:12:50 +04:00
return 0 ;
}
2013-01-16 08:24:07 +04:00
2006-07-29 18:12:50 +04:00
return 1 ;
}
2013-01-16 08:24:07 +04:00
int asix_rx_fixup_common ( struct usbnet * dev , struct sk_buff * skb )
{
struct asix_common_private * dp = dev - > driver_priv ;
struct asix_rx_fixup_info * rx = & dp - > rx_fixup_info ;
return asix_rx_fixup_internal ( dev , skb , rx ) ;
}
2017-08-07 11:50:16 +03:00
void asix_rx_fixup_common_free ( struct asix_common_private * dp )
{
struct asix_rx_fixup_info * rx ;
if ( ! dp )
return ;
rx = & dp - > rx_fixup_info ;
if ( rx - > ax_skb ) {
kfree_skb ( rx - > ax_skb ) ;
rx - > ax_skb = NULL ;
}
}
2012-07-13 09:26:30 +04:00
struct sk_buff * asix_tx_fixup ( struct usbnet * dev , struct sk_buff * skb ,
gfp_t flags )
2006-07-29 18:12:50 +04:00
{
int padlen ;
int headroom = skb_headroom ( skb ) ;
int tailroom = skb_tailroom ( skb ) ;
u32 packet_len ;
u32 padbytes = 0xffff0000 ;
2019-07-22 10:41:34 +03:00
void * ptr ;
2006-07-29 18:12:50 +04:00
2012-04-24 02:05:38 +04:00
padlen = ( ( skb - > len + 4 ) & ( dev - > maxpacket - 1 ) ) ? 0 : 4 ;
2006-07-29 18:12:50 +04:00
2012-07-05 08:31:01 +04:00
/* We need to push 4 bytes in front of frame (packet_len)
* and maybe add 4 bytes after the end ( if padlen is 4 )
*
* Avoid skb_copy_expand ( ) expensive call , using following rules :
* - We are allowed to push 4 bytes in headroom if skb_header_cloned ( )
* is false ( and if we have 4 bytes of headroom )
* - We are allowed to put 4 bytes at tail if skb_cloned ( )
* is false ( and if we have 4 bytes of tailroom )
*
2017-09-22 05:25:22 +03:00
* TCP packets for example are cloned , but __skb_header_release ( )
2012-07-05 08:31:01 +04:00
* was called in tcp stack , allowing us to use headroom for our needs .
*/
if ( ! skb_header_cloned ( skb ) & &
! ( padlen & & skb_cloned ( skb ) ) & &
headroom + tailroom > = 4 + padlen ) {
/* following should not happen, but better be safe */
if ( headroom < 4 | |
tailroom < padlen ) {
2006-07-29 18:12:50 +04:00
skb - > data = memmove ( skb - > head + 4 , skb - > data , skb - > len ) ;
2007-04-20 07:29:13 +04:00
skb_set_tail_pointer ( skb , skb - > len ) ;
2006-07-29 18:12:50 +04:00
}
} else {
struct sk_buff * skb2 ;
2012-07-05 08:31:01 +04:00
2006-07-29 18:12:50 +04:00
skb2 = skb_copy_expand ( skb , 4 , padlen , flags ) ;
dev_kfree_skb_any ( skb ) ;
skb = skb2 ;
if ( ! skb )
return NULL ;
}
2012-07-05 08:31:01 +04:00
packet_len = ( ( skb - > len ^ 0x0000ffff ) < < 16 ) + skb - > len ;
2019-07-22 10:41:34 +03:00
ptr = skb_push ( skb , 4 ) ;
put_unaligned_le32 ( packet_len , ptr ) ;
2006-07-29 18:12:50 +04:00
2012-04-24 02:05:38 +04:00
if ( padlen ) {
2019-07-22 10:41:34 +03:00
put_unaligned_le32 ( padbytes , skb_tail_pointer ( skb ) ) ;
2006-07-29 18:12:50 +04:00
skb_put ( skb , sizeof ( padbytes ) ) ;
}
2015-02-26 22:34:37 +03:00
2015-03-25 23:41:33 +03:00
usbnet_set_skb_tx_stats ( skb , 1 , 0 ) ;
2006-07-29 18:12:50 +04:00
return skb ;
}
2021-06-07 11:27:21 +03:00
int asix_read_phy_addr ( struct usbnet * dev , bool internal )
2006-03-29 05:15:42 +04:00
{
2021-06-07 11:27:21 +03:00
int ret , offset ;
2007-12-22 20:42:36 +03:00
u8 buf [ 2 ] ;
2006-03-29 05:15:42 +04:00
2021-06-07 11:27:21 +03:00
ret = asix_read_cmd ( dev , AX_CMD_READ_PHY_ID , 0 , 0 , 2 , buf , 0 ) ;
if ( ret < 0 )
goto error ;
2006-07-29 18:12:50 +04:00
2020-08-27 09:53:55 +03:00
if ( ret < 2 ) {
2021-06-07 11:27:21 +03:00
ret = - EIO ;
goto error ;
2006-03-29 05:15:42 +04:00
}
2021-06-07 11:27:21 +03:00
offset = ( internal ? 1 : 0 ) ;
2012-07-13 09:26:31 +04:00
ret = buf [ offset ] ;
2007-12-22 20:42:36 +03:00
2021-06-07 11:27:21 +03:00
netdev_dbg ( dev - > net , " %s PHY address 0x%x \n " ,
internal ? " internal " : " external " , ret ) ;
2006-03-29 05:15:42 +04:00
return ret ;
2021-06-07 11:27:21 +03:00
error :
netdev_err ( dev - > net , " Error reading PHY_ID register: %02x \n " , ret ) ;
2012-07-13 09:26:31 +04:00
2021-06-07 11:27:21 +03:00
return ret ;
}
2012-07-13 09:26:31 +04:00
2016-08-29 16:32:15 +03:00
int asix_sw_reset ( struct usbnet * dev , u8 flags , int in_pm )
2006-03-29 05:15:42 +04:00
{
int ret ;
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_SW_RESET , flags , 0 , 0 , NULL , in_pm ) ;
2006-03-29 05:15:42 +04:00
if ( ret < 0 )
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Failed to send software reset: %02x \n " , ret ) ;
2006-07-29 18:12:50 +04:00
return ret ;
}
2006-03-29 05:15:42 +04:00
2016-08-29 16:32:15 +03:00
u16 asix_read_rx_ctl ( struct usbnet * dev , int in_pm )
2006-07-29 18:12:50 +04:00
{
2007-12-22 20:42:36 +03:00
__le16 v ;
2016-08-29 16:32:15 +03:00
int ret = asix_read_cmd ( dev , AX_CMD_READ_RX_CTL , 0 , 0 , 2 , & v , in_pm ) ;
2006-07-29 18:12:50 +04:00
2007-12-22 20:42:36 +03:00
if ( ret < 0 ) {
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Error reading RX_CTL register: %02x \n " , ret ) ;
2007-12-22 20:42:36 +03:00
goto out ;
2006-07-29 18:12:50 +04:00
}
2007-12-22 20:42:36 +03:00
ret = le16_to_cpu ( v ) ;
out :
2006-03-29 05:15:42 +04:00
return ret ;
}
2016-08-29 16:32:15 +03:00
int asix_write_rx_ctl ( struct usbnet * dev , u16 mode , int in_pm )
2006-03-29 05:15:42 +04:00
{
int ret ;
2010-02-17 13:30:23 +03:00
netdev_dbg ( dev - > net , " asix_write_rx_ctl() - mode = 0x%04x \n " , mode ) ;
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_WRITE_RX_CTL , mode , 0 , 0 , NULL , in_pm ) ;
2006-03-29 05:15:42 +04:00
if ( ret < 0 )
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Failed to write RX_CTL mode to 0x%04x: %02x \n " ,
mode , ret ) ;
2006-03-29 05:15:42 +04:00
return ret ;
}
2016-08-29 16:32:15 +03:00
u16 asix_read_medium_status ( struct usbnet * dev , int in_pm )
2005-08-31 20:53:10 +04:00
{
2007-12-22 20:42:36 +03:00
__le16 v ;
2016-08-29 16:32:15 +03:00
int ret = asix_read_cmd ( dev , AX_CMD_READ_MEDIUM_STATUS ,
0 , 0 , 2 , & v , in_pm ) ;
2005-08-31 20:53:10 +04:00
2007-12-22 20:42:36 +03:00
if ( ret < 0 ) {
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Error reading Medium Status register: %02x \n " ,
ret ) ;
2011-10-04 13:55:18 +04:00
return ret ; /* TODO: callers not checking for error ret */
2005-08-31 20:53:10 +04:00
}
2011-10-04 13:55:18 +04:00
return le16_to_cpu ( v ) ;
2005-08-31 20:53:10 +04:00
}
2016-08-29 16:32:15 +03:00
int asix_write_medium_mode ( struct usbnet * dev , u16 mode , int in_pm )
2005-08-31 20:53:10 +04:00
{
2006-07-29 18:12:50 +04:00
int ret ;
2005-08-31 20:53:10 +04:00
2010-02-17 13:30:23 +03:00
netdev_dbg ( dev - > net , " asix_write_medium_mode() - mode = 0x%04x \n " , mode ) ;
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_WRITE_MEDIUM_MODE ,
mode , 0 , 0 , NULL , in_pm ) ;
2006-07-29 18:12:50 +04:00
if ( ret < 0 )
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Failed to write Medium Mode mode to 0x%04x: %02x \n " ,
mode , ret ) ;
2005-08-31 20:53:10 +04:00
2006-07-29 18:12:50 +04:00
return ret ;
}
2005-08-31 20:53:10 +04:00
2021-06-07 11:27:23 +03:00
/* set MAC link settings according to information from phylib */
void asix_adjust_link ( struct net_device * netdev )
{
struct phy_device * phydev = netdev - > phydev ;
struct usbnet * dev = netdev_priv ( netdev ) ;
u16 mode = 0 ;
if ( phydev - > link ) {
mode = AX88772_MEDIUM_DEFAULT ;
if ( phydev - > duplex = = DUPLEX_HALF )
mode & = ~ AX_MEDIUM_FD ;
if ( phydev - > speed ! = SPEED_100 )
mode & = ~ AX_MEDIUM_PS ;
}
asix_write_medium_mode ( dev , mode , 0 ) ;
phy_print_status ( phydev ) ;
2022-06-24 10:51:38 +03:00
usbnet_link_change ( dev , phydev - > link , 0 ) ;
2021-06-07 11:27:23 +03:00
}
2016-08-29 16:32:15 +03:00
int asix_write_gpio ( struct usbnet * dev , u16 value , int sleep , int in_pm )
2006-07-29 18:12:50 +04:00
{
int ret ;
2005-08-31 20:53:10 +04:00
2010-02-17 13:30:23 +03:00
netdev_dbg ( dev - > net , " asix_write_gpio() - value = 0x%04x \n " , value ) ;
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_WRITE_GPIOS , value , 0 , 0 , NULL , in_pm ) ;
2006-07-29 18:12:50 +04:00
if ( ret < 0 )
2010-02-17 13:30:23 +03:00
netdev_err ( dev - > net , " Failed to write GPIO value 0x%04x: %02x \n " ,
value , ret ) ;
2005-08-31 20:53:10 +04:00
2006-07-29 18:12:50 +04:00
if ( sleep )
msleep ( sleep ) ;
return ret ;
2005-08-31 20:53:10 +04:00
}
2006-07-29 18:12:50 +04:00
/*
* AX88772 & AX88178 have a 16 - bit RX_CTL value
*/
2012-07-13 09:26:30 +04:00
void asix_set_multicast ( struct net_device * net )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( net ) ;
2006-03-29 05:15:42 +04:00
struct asix_data * data = ( struct asix_data * ) & dev - > data ;
2006-07-29 18:12:50 +04:00
u16 rx_ctl = AX_DEFAULT_RX_CTL ;
2005-08-31 20:53:10 +04:00
if ( net - > flags & IFF_PROMISC ) {
2006-07-29 18:12:50 +04:00
rx_ctl | = AX_RX_CTL_PRO ;
2009-12-03 10:58:21 +03:00
} else if ( net - > flags & IFF_ALLMULTI | |
2010-02-08 07:30:35 +03:00
netdev_mc_count ( net ) > AX_MAX_MCAST ) {
2006-07-29 18:12:50 +04:00
rx_ctl | = AX_RX_CTL_AMALL ;
2010-02-08 07:30:35 +03:00
} else if ( netdev_mc_empty ( net ) ) {
2005-08-31 20:53:10 +04:00
/* just broadcast and directed */
} else {
/* We use the 20 byte dev->data
* for our 8 byte filter buffer
* to avoid allocating memory that
* is tricky to free later */
2010-04-02 01:22:57 +04:00
struct netdev_hw_addr * ha ;
2005-08-31 20:53:10 +04:00
u32 crc_bits ;
memset ( data - > multi_filter , 0 , AX_MCAST_FILTER_SIZE ) ;
/* Build the multicast hash filter. */
2010-04-02 01:22:57 +04:00
netdev_for_each_mc_addr ( ha , net ) {
crc_bits = ether_crc ( ETH_ALEN , ha - > addr ) > > 26 ;
2005-08-31 20:53:10 +04:00
data - > multi_filter [ crc_bits > > 3 ] | =
1 < < ( crc_bits & 7 ) ;
}
2006-03-29 05:15:42 +04:00
asix_write_cmd_async ( dev , AX_CMD_WRITE_MULTI_FILTER , 0 , 0 ,
2005-08-31 20:53:10 +04:00
AX_MCAST_FILTER_SIZE , data - > multi_filter ) ;
2006-07-29 18:12:50 +04:00
rx_ctl | = AX_RX_CTL_AM ;
2005-08-31 20:53:10 +04:00
}
2006-03-29 05:15:42 +04:00
asix_write_cmd_async ( dev , AX_CMD_WRITE_RX_CTL , rx_ctl , 0 , 0 , NULL ) ;
2005-08-31 20:53:10 +04:00
}
2022-02-23 14:06:33 +03:00
static int __asix_mdio_read ( struct net_device * netdev , int phy_id , int loc ,
bool in_pm )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( netdev ) ;
2007-12-22 20:42:36 +03:00
__le16 res ;
2016-08-29 16:32:16 +03:00
int ret ;
2005-08-31 20:53:10 +04:00
2006-10-09 02:08:02 +04:00
mutex_lock ( & dev - > phy_mutex ) ;
2021-08-17 19:37:23 +03:00
2022-02-23 14:06:33 +03:00
ret = asix_check_host_enable ( dev , in_pm ) ;
2016-10-14 02:43:16 +03:00
if ( ret = = - ENODEV | | ret = = - ETIMEDOUT ) {
2016-08-29 16:32:16 +03:00
mutex_unlock ( & dev - > phy_mutex ) ;
return ret ;
}
2016-08-29 16:32:15 +03:00
2021-06-07 11:27:25 +03:00
ret = asix_read_cmd ( dev , AX_CMD_READ_MII_REG , phy_id , ( __u16 ) loc , 2 ,
2022-02-23 14:06:33 +03:00
& res , in_pm ) ;
2021-06-07 11:27:25 +03:00
if ( ret < 0 )
goto out ;
2022-02-23 14:06:33 +03:00
ret = asix_set_hw_mii ( dev , in_pm ) ;
2021-06-07 11:27:25 +03:00
out :
2006-10-09 02:08:02 +04:00
mutex_unlock ( & dev - > phy_mutex ) ;
2005-08-31 20:53:10 +04:00
2010-02-17 13:30:23 +03:00
netdev_dbg ( dev - > net , " asix_mdio_read() phy_id=0x%02x, loc=0x%02x, returns=0x%04x \n " ,
2016-08-29 16:32:15 +03:00
phy_id , loc , le16_to_cpu ( res ) ) ;
2005-08-31 20:53:10 +04:00
2021-06-07 11:27:25 +03:00
return ret < 0 ? ret : le16_to_cpu ( res ) ;
2005-08-31 20:53:10 +04:00
}
2022-02-23 14:06:33 +03:00
int asix_mdio_read ( struct net_device * netdev , int phy_id , int loc )
{
return __asix_mdio_read ( netdev , phy_id , loc , false ) ;
}
2021-06-07 11:27:25 +03:00
static int __asix_mdio_write ( struct net_device * netdev , int phy_id , int loc ,
2022-02-23 14:06:33 +03:00
int val , bool in_pm )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( netdev ) ;
2007-12-22 20:42:36 +03:00
__le16 res = cpu_to_le16 ( val ) ;
2016-08-29 16:32:16 +03:00
int ret ;
2005-08-31 20:53:10 +04:00
2010-02-17 13:30:23 +03:00
netdev_dbg ( dev - > net , " asix_mdio_write() phy_id=0x%02x, loc=0x%02x, val=0x%04x \n " ,
2016-08-29 16:32:15 +03:00
phy_id , loc , val ) ;
mutex_lock ( & dev - > phy_mutex ) ;
2022-02-23 14:06:33 +03:00
ret = asix_check_host_enable ( dev , in_pm ) ;
2021-06-07 11:27:25 +03:00
if ( ret = = - ENODEV )
goto out ;
ret = asix_write_cmd ( dev , AX_CMD_WRITE_MII_REG , phy_id , ( __u16 ) loc , 2 ,
2022-02-23 14:06:33 +03:00
& res , in_pm ) ;
2021-06-07 11:27:25 +03:00
if ( ret < 0 )
goto out ;
2022-02-23 14:06:33 +03:00
ret = asix_set_hw_mii ( dev , in_pm ) ;
2021-06-07 11:27:25 +03:00
out :
2016-08-29 16:32:15 +03:00
mutex_unlock ( & dev - > phy_mutex ) ;
2021-06-07 11:27:25 +03:00
return ret < 0 ? ret : 0 ;
}
void asix_mdio_write ( struct net_device * netdev , int phy_id , int loc , int val )
{
2022-02-23 14:06:33 +03:00
__asix_mdio_write ( netdev , phy_id , loc , val , false ) ;
2016-08-29 16:32:15 +03:00
}
2021-06-07 11:27:23 +03:00
/* MDIO read and write wrappers for phylib */
int asix_mdio_bus_read ( struct mii_bus * bus , int phy_id , int regnum )
{
struct usbnet * priv = bus - > priv ;
2022-02-23 14:06:33 +03:00
return __asix_mdio_read ( priv - > net , phy_id , regnum , false ) ;
2021-06-07 11:27:23 +03:00
}
int asix_mdio_bus_write ( struct mii_bus * bus , int phy_id , int regnum , u16 val )
{
struct usbnet * priv = bus - > priv ;
2022-02-23 14:06:33 +03:00
return __asix_mdio_write ( priv - > net , phy_id , regnum , val , false ) ;
2021-06-07 11:27:23 +03:00
}
2016-08-29 16:32:15 +03:00
int asix_mdio_read_nopm ( struct net_device * netdev , int phy_id , int loc )
{
2022-02-23 14:06:33 +03:00
return __asix_mdio_read ( netdev , phy_id , loc , true ) ;
2016-08-29 16:32:15 +03:00
}
void
asix_mdio_write_nopm ( struct net_device * netdev , int phy_id , int loc , int val )
{
2022-02-23 14:06:33 +03:00
__asix_mdio_write ( netdev , phy_id , loc , val , true ) ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
void asix_get_wol ( struct net_device * net , struct ethtool_wolinfo * wolinfo )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( net ) ;
u8 opt ;
2016-08-29 16:32:15 +03:00
if ( asix_read_cmd ( dev , AX_CMD_READ_MONITOR_MODE ,
0 , 0 , 1 , & opt , 0 ) < 0 ) {
2005-08-31 20:53:10 +04:00
wolinfo - > supported = 0 ;
wolinfo - > wolopts = 0 ;
return ;
}
wolinfo - > supported = WAKE_PHY | WAKE_MAGIC ;
wolinfo - > wolopts = 0 ;
2011-12-23 00:38:51 +04:00
if ( opt & AX_MONITOR_LINK )
wolinfo - > wolopts | = WAKE_PHY ;
if ( opt & AX_MONITOR_MAGIC )
wolinfo - > wolopts | = WAKE_MAGIC ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
int asix_set_wol ( struct net_device * net , struct ethtool_wolinfo * wolinfo )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( net ) ;
u8 opt = 0 ;
2018-09-29 02:18:50 +03:00
if ( wolinfo - > wolopts & ~ ( WAKE_PHY | WAKE_MAGIC ) )
return - EINVAL ;
2005-08-31 20:53:10 +04:00
if ( wolinfo - > wolopts & WAKE_PHY )
opt | = AX_MONITOR_LINK ;
if ( wolinfo - > wolopts & WAKE_MAGIC )
opt | = AX_MONITOR_MAGIC ;
2006-03-29 05:15:42 +04:00
if ( asix_write_cmd ( dev , AX_CMD_WRITE_MONITOR_MODE ,
2016-08-29 16:32:15 +03:00
opt , 0 , 0 , NULL , 0 ) < 0 )
2005-08-31 20:53:10 +04:00
return - EINVAL ;
return 0 ;
}
2012-07-13 09:26:30 +04:00
int asix_get_eeprom_len ( struct net_device * net )
2005-08-31 20:53:10 +04:00
{
2012-07-19 04:23:06 +04:00
return AX_EEPROM_LEN ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
int asix_get_eeprom ( struct net_device * net , struct ethtool_eeprom * eeprom ,
u8 * data )
2005-08-31 20:53:10 +04:00
{
struct usbnet * dev = netdev_priv ( net ) ;
2012-07-19 04:23:06 +04:00
u16 * eeprom_buff ;
int first_word , last_word ;
2005-08-31 20:53:10 +04:00
int i ;
2012-07-19 04:23:06 +04:00
if ( eeprom - > len = = 0 )
2005-08-31 20:53:10 +04:00
return - EINVAL ;
eeprom - > magic = AX_EEPROM_MAGIC ;
2012-07-19 04:23:06 +04:00
first_word = eeprom - > offset > > 1 ;
last_word = ( eeprom - > offset + eeprom - > len - 1 ) > > 1 ;
treewide: kmalloc() -> kmalloc_array()
The kmalloc() function has a 2-factor argument form, kmalloc_array(). This
patch replaces cases of:
kmalloc(a * b, gfp)
with:
kmalloc_array(a * b, gfp)
as well as handling cases of:
kmalloc(a * b * c, gfp)
with:
kmalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kmalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kmalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The tools/ directory was manually excluded, since it has its own
implementation of kmalloc().
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kmalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kmalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kmalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kmalloc
+ kmalloc_array
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kmalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kmalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kmalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kmalloc(sizeof(THING) * C2, ...)
|
kmalloc(sizeof(TYPE) * C2, ...)
|
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(C1 * C2, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * E2
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 23:55:00 +03:00
eeprom_buff = kmalloc_array ( last_word - first_word + 1 , sizeof ( u16 ) ,
GFP_KERNEL ) ;
2012-07-19 04:23:06 +04:00
if ( ! eeprom_buff )
return - ENOMEM ;
2005-08-31 20:53:10 +04:00
/* ax8817x returns 2 bytes from eeprom on read */
2012-07-19 04:23:06 +04:00
for ( i = first_word ; i < = last_word ; i + + ) {
if ( asix_read_cmd ( dev , AX_CMD_READ_EEPROM , i , 0 , 2 ,
2016-08-29 16:32:15 +03:00
& eeprom_buff [ i - first_word ] , 0 ) < 0 ) {
2012-07-19 04:23:06 +04:00
kfree ( eeprom_buff ) ;
return - EIO ;
}
2005-08-31 20:53:10 +04:00
}
2012-07-19 04:23:06 +04:00
memcpy ( data , ( u8 * ) eeprom_buff + ( eeprom - > offset & 1 ) , eeprom - > len ) ;
kfree ( eeprom_buff ) ;
2005-08-31 20:53:10 +04:00
return 0 ;
}
2012-07-19 04:23:07 +04:00
int asix_set_eeprom ( struct net_device * net , struct ethtool_eeprom * eeprom ,
u8 * data )
{
struct usbnet * dev = netdev_priv ( net ) ;
u16 * eeprom_buff ;
int first_word , last_word ;
int i ;
int ret ;
netdev_dbg ( net , " write EEPROM len %d, offset %d, magic 0x%x \n " ,
eeprom - > len , eeprom - > offset , eeprom - > magic ) ;
if ( eeprom - > len = = 0 )
return - EINVAL ;
if ( eeprom - > magic ! = AX_EEPROM_MAGIC )
return - EINVAL ;
first_word = eeprom - > offset > > 1 ;
last_word = ( eeprom - > offset + eeprom - > len - 1 ) > > 1 ;
treewide: kmalloc() -> kmalloc_array()
The kmalloc() function has a 2-factor argument form, kmalloc_array(). This
patch replaces cases of:
kmalloc(a * b, gfp)
with:
kmalloc_array(a * b, gfp)
as well as handling cases of:
kmalloc(a * b * c, gfp)
with:
kmalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kmalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kmalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The tools/ directory was manually excluded, since it has its own
implementation of kmalloc().
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kmalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kmalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kmalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kmalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kmalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kmalloc
+ kmalloc_array
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kmalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kmalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kmalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kmalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kmalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kmalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kmalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kmalloc(sizeof(THING) * C2, ...)
|
kmalloc(sizeof(TYPE) * C2, ...)
|
kmalloc(C1 * C2 * C3, ...)
|
kmalloc(C1 * C2, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * E2
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kmalloc
+ kmalloc_array
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 23:55:00 +03:00
eeprom_buff = kmalloc_array ( last_word - first_word + 1 , sizeof ( u16 ) ,
GFP_KERNEL ) ;
2012-07-19 04:23:07 +04:00
if ( ! eeprom_buff )
return - ENOMEM ;
/* align data to 16 bit boundaries, read the missing data from
the EEPROM */
if ( eeprom - > offset & 1 ) {
ret = asix_read_cmd ( dev , AX_CMD_READ_EEPROM , first_word , 0 , 2 ,
2016-08-29 16:32:15 +03:00
& eeprom_buff [ 0 ] , 0 ) ;
2012-07-19 04:23:07 +04:00
if ( ret < 0 ) {
netdev_err ( net , " Failed to read EEPROM at offset 0x%02x. \n " , first_word ) ;
goto free ;
}
}
if ( ( eeprom - > offset + eeprom - > len ) & 1 ) {
ret = asix_read_cmd ( dev , AX_CMD_READ_EEPROM , last_word , 0 , 2 ,
2016-08-29 16:32:15 +03:00
& eeprom_buff [ last_word - first_word ] , 0 ) ;
2012-07-19 04:23:07 +04:00
if ( ret < 0 ) {
netdev_err ( net , " Failed to read EEPROM at offset 0x%02x. \n " , last_word ) ;
goto free ;
}
}
memcpy ( ( u8 * ) eeprom_buff + ( eeprom - > offset & 1 ) , data , eeprom - > len ) ;
/* write data to EEPROM */
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_WRITE_ENABLE , 0x0000 , 0 , 0 , NULL , 0 ) ;
2012-07-19 04:23:07 +04:00
if ( ret < 0 ) {
netdev_err ( net , " Failed to enable EEPROM write \n " ) ;
goto free ;
}
msleep ( 20 ) ;
for ( i = first_word ; i < = last_word ; i + + ) {
netdev_dbg ( net , " write to EEPROM at offset 0x%02x, data 0x%04x \n " ,
i , eeprom_buff [ i - first_word ] ) ;
ret = asix_write_cmd ( dev , AX_CMD_WRITE_EEPROM , i ,
2016-08-29 16:32:15 +03:00
eeprom_buff [ i - first_word ] , 0 , NULL , 0 ) ;
2012-07-19 04:23:07 +04:00
if ( ret < 0 ) {
netdev_err ( net , " Failed to write EEPROM at offset 0x%02x. \n " ,
i ) ;
goto free ;
}
msleep ( 20 ) ;
}
2016-08-29 16:32:15 +03:00
ret = asix_write_cmd ( dev , AX_CMD_WRITE_DISABLE , 0x0000 , 0 , 0 , NULL , 0 ) ;
2012-07-19 04:23:07 +04:00
if ( ret < 0 ) {
netdev_err ( net , " Failed to disable EEPROM write \n " ) ;
goto free ;
}
ret = 0 ;
free :
kfree ( eeprom_buff ) ;
return ret ;
}
2012-07-13 09:26:30 +04:00
void asix_get_drvinfo ( struct net_device * net , struct ethtool_drvinfo * info )
2005-08-31 20:53:10 +04:00
{
/* Inherit standard device info */
usbnet_get_drvinfo ( net , info ) ;
2013-01-06 04:44:26 +04:00
strlcpy ( info - > driver , DRIVER_NAME , sizeof ( info - > driver ) ) ;
strlcpy ( info - > version , DRIVER_VERSION , sizeof ( info - > version ) ) ;
2005-08-31 20:53:10 +04:00
}
2012-07-13 09:26:30 +04:00
int asix_set_mac_address ( struct net_device * net , void * p )
2010-03-09 15:24:38 +03:00
{
struct usbnet * dev = netdev_priv ( net ) ;
struct asix_data * data = ( struct asix_data * ) & dev - > data ;
struct sockaddr * addr = p ;
if ( netif_running ( net ) )
return - EBUSY ;
if ( ! is_valid_ether_addr ( addr - > sa_data ) )
return - EADDRNOTAVAIL ;
2021-10-02 00:32:21 +03:00
eth_hw_addr_set ( net , addr - > sa_data ) ;
2010-03-09 15:24:38 +03:00
/* We use the 20 byte dev->data
* for our 6 byte mac buffer
* to avoid allocating memory that
* is tricky to free later */
memcpy ( data - > mac_addr , addr - > sa_data , ETH_ALEN ) ;
asix_write_cmd_async ( dev , AX_CMD_WRITE_NODE_ID , 0 , 0 , ETH_ALEN ,
data - > mac_addr ) ;
return 0 ;
}