2006-01-02 21:04:38 +03:00
/*
* net / tipc / msg . c : TIPC message header routines
2007-02-09 17:25:21 +03:00
*
2014-05-14 13:39:12 +04:00
* Copyright ( c ) 2000 - 2006 , 2014 , Ericsson AB
2011-01-25 21:33:31 +03:00
* Copyright ( c ) 2005 , 2010 - 2011 , Wind River Systems
2006-01-02 21:04:38 +03:00
* All rights reserved .
*
2006-01-11 15:30:43 +03:00
* Redistribution and use in source and binary forms , with or without
2006-01-02 21:04:38 +03:00
* modification , are permitted provided that the following conditions are met :
*
2006-01-11 15:30:43 +03:00
* 1. Redistributions of source code must retain the above copyright
* notice , this list of conditions and the following disclaimer .
* 2. Redistributions in binary form must reproduce the above copyright
* notice , this list of conditions and the following disclaimer in the
* documentation and / or other materials provided with the distribution .
* 3. Neither the names of the copyright holders nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission .
2006-01-02 21:04:38 +03:00
*
2006-01-11 15:30:43 +03:00
* Alternatively , this software may be distributed under the terms of the
* GNU General Public License ( " GPL " ) version 2 as published by the Free
* Software Foundation .
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS " AS IS "
* AND ANY EXPRESS OR IMPLIED WARRANTIES , INCLUDING , BUT NOT LIMITED TO , THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED . IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
* LIABLE FOR ANY DIRECT , INDIRECT , INCIDENTAL , SPECIAL , EXEMPLARY , OR
* CONSEQUENTIAL DAMAGES ( INCLUDING , BUT NOT LIMITED TO , PROCUREMENT OF
* SUBSTITUTE GOODS OR SERVICES ; LOSS OF USE , DATA , OR PROFITS ; OR BUSINESS
* INTERRUPTION ) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY , WHETHER IN
* CONTRACT , STRICT LIABILITY , OR TORT ( INCLUDING NEGLIGENCE OR OTHERWISE )
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE , EVEN IF ADVISED OF THE
2006-01-02 21:04:38 +03:00
* POSSIBILITY OF SUCH DAMAGE .
*/
# include "core.h"
# include "msg.h"
tipc: introduce message evaluation function
When a message arrives in a node and finds no destination
socket, we may need to drop it, reject it, or forward it after
a secondary destination lookup. The latter two cases currently
results in a code path that is perceived as complex, because it
follows a deep call chain via obscure functions such as
net_route_named_msg() and net_route_msg().
We now introduce a function, tipc_msg_eval(), that takes the
decision about whether such a message should be rejected or
forwarded, but leaves it to the caller to actually perform
the indicated action.
If the decision is 'reject', it is still the task of the recently
introduced function tipc_msg_reverse() to take the final decision
about whether the message is rejectable or not. In the latter case
it drops the message.
As a result of this change, we can finally eliminate the function
net_route_named_msg(), and hence become independent of net_route_msg().
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:36 +04:00
# include "addr.h"
# include "name_table.h"
2006-01-02 21:04:38 +03:00
2014-06-26 05:41:35 +04:00
# define MAX_FORWARD_SIZE 1024
tipc: introduce send functions for chained buffers in link
The current link implementation provides several different transmit
functions, depending on the characteristics of the message to be
sent: if it is an iovec or an sk_buff, if it needs fragmentation or
not, if the caller holds the node_lock or not. The permutation of
these options gives us an unwanted amount of unnecessarily complex
code.
As a first step towards simplifying the send path for all messages,
we introduce two new send functions at link level, tipc_link_xmit2()
and __tipc_link_xmit2(). The former looks up a link to the message
destination, and if one is found, it grabs the node lock and calls
the second function, which works exclusively inside the node lock
protection. If no link is found, and the destination is on the same
node, it delivers the message directly to the local destination
socket.
The new functions take a buffer chain where all packet headers are
already prepared, and the correct MTU has been used. These two
functions will later replace all other link-level transmit functions.
The functions are not backwards compatible, so we have added them
as new functions with temporary names. They are tested, but have no
users yet. Those will be added later in this series.
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:32 +04:00
static unsigned int align ( unsigned int i )
2010-05-11 18:30:18 +04:00
{
tipc: introduce send functions for chained buffers in link
The current link implementation provides several different transmit
functions, depending on the characteristics of the message to be
sent: if it is an iovec or an sk_buff, if it needs fragmentation or
not, if the caller holds the node_lock or not. The permutation of
these options gives us an unwanted amount of unnecessarily complex
code.
As a first step towards simplifying the send path for all messages,
we introduce two new send functions at link level, tipc_link_xmit2()
and __tipc_link_xmit2(). The former looks up a link to the message
destination, and if one is found, it grabs the node lock and calls
the second function, which works exclusively inside the node lock
protection. If no link is found, and the destination is on the same
node, it delivers the message directly to the local destination
socket.
The new functions take a buffer chain where all packet headers are
already prepared, and the correct MTU has been used. These two
functions will later replace all other link-level transmit functions.
The functions are not backwards compatible, so we have added them
as new functions with temporary names. They are tested, but have no
users yet. Those will be added later in this series.
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:32 +04:00
return ( i + 3 ) & ~ 3u ;
2010-05-11 18:30:18 +04:00
}
2013-06-17 18:54:47 +04:00
void tipc_msg_init ( struct tipc_msg * m , u32 user , u32 type , u32 hsize ,
u32 destnode )
2010-05-11 18:30:18 +04:00
{
memset ( m , 0 , hsize ) ;
msg_set_version ( m ) ;
msg_set_user ( m , user ) ;
msg_set_hdr_sz ( m , hsize ) ;
msg_set_size ( m , hsize ) ;
msg_set_prevnode ( m , tipc_own_addr ) ;
msg_set_type ( m , type ) ;
2011-05-31 22:35:18 +04:00
msg_set_orignode ( m , tipc_own_addr ) ;
msg_set_destnode ( m , destnode ) ;
2010-05-11 18:30:18 +04:00
}
/**
* tipc_msg_build - create message using specified header and data
*
* Note : Caller must not hold any locks in case copy_from_user ( ) is interrupted !
*
* Returns message data size or errno
*/
tipc: Avoid recomputation of outgoing message length
Rework TIPC's message sending routines to take advantage of the total
amount of data value passed to it by the kernel socket infrastructure.
This change eliminates the need for TIPC to compute the size of outgoing
messages itself, as well as the check for an oversize message in
tipc_msg_build(). In addition, this change warrants an explanation:
- res = send_packet(NULL, sock, &my_msg, 0);
+ res = send_packet(NULL, sock, &my_msg, bytes_to_send);
Previously, the final argument to send_packet() was ignored (since the
amount of data being sent was recalculated by a lower-level routine)
and we could just pass in a dummy value (0). Now that the
recalculation is being eliminated, the argument value being passed to
send_packet() is significant and we have to supply the actual amount
of data we want to send.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
2011-04-21 19:42:07 +04:00
int tipc_msg_build ( struct tipc_msg * hdr , struct iovec const * msg_sect ,
2013-10-18 09:23:15 +04:00
unsigned int len , int max_size , struct sk_buff * * buf )
2010-05-11 18:30:18 +04:00
{
2013-10-18 09:23:14 +04:00
int dsz , sz , hsz ;
unsigned char * to ;
2010-05-11 18:30:18 +04:00
2013-10-18 09:23:15 +04:00
dsz = len ;
2013-10-18 09:23:14 +04:00
hsz = msg_hdr_sz ( hdr ) ;
2010-05-11 18:30:18 +04:00
sz = hsz + dsz ;
msg_set_size ( hdr , sz ) ;
if ( unlikely ( sz > max_size ) ) {
* buf = NULL ;
return dsz ;
}
2010-10-13 17:20:35 +04:00
* buf = tipc_buf_acquire ( sz ) ;
2010-05-11 18:30:18 +04:00
if ( ! ( * buf ) )
return - ENOMEM ;
skb_copy_to_linear_data ( * buf , hdr , hsz ) ;
2013-10-18 09:23:14 +04:00
to = ( * buf ) - > data + hsz ;
2013-10-18 09:23:15 +04:00
if ( len & & memcpy_fromiovecend ( to , msg_sect , 0 , dsz ) ) {
2013-10-18 09:23:14 +04:00
kfree_skb ( * buf ) ;
* buf = NULL ;
return - EFAULT ;
2010-05-11 18:30:18 +04:00
}
2013-10-18 09:23:14 +04:00
return dsz ;
2010-05-11 18:30:18 +04:00
}
2014-05-14 13:39:12 +04:00
/* tipc_buf_append(): Append a buffer to the fragment list of another buffer
* Let first buffer become head buffer
* Returns 1 and sets * buf to headbuf if chain is complete , otherwise 0
* Leaves headbuf pointer at NULL if failure
*/
int tipc_buf_append ( struct sk_buff * * headbuf , struct sk_buff * * buf )
{
struct sk_buff * head = * headbuf ;
struct sk_buff * frag = * buf ;
struct sk_buff * tail ;
struct tipc_msg * msg = buf_msg ( frag ) ;
u32 fragid = msg_type ( msg ) ;
bool headstolen ;
int delta ;
skb_pull ( frag , msg_hdr_sz ( msg ) ) ;
if ( fragid = = FIRST_FRAGMENT ) {
if ( head | | skb_unclone ( frag , GFP_ATOMIC ) )
goto out_free ;
head = * headbuf = frag ;
skb_frag_list_init ( head ) ;
return 0 ;
}
if ( ! head )
goto out_free ;
tail = TIPC_SKB_CB ( head ) - > tail ;
if ( skb_try_coalesce ( head , frag , & headstolen , & delta ) ) {
kfree_skb_partial ( frag , headstolen ) ;
} else {
if ( ! skb_has_frag_list ( head ) )
skb_shinfo ( head ) - > frag_list = frag ;
else
tail - > next = frag ;
head - > truesize + = frag - > truesize ;
head - > data_len + = frag - > len ;
head - > len + = frag - > len ;
TIPC_SKB_CB ( head ) - > tail = frag ;
}
if ( fragid = = LAST_FRAGMENT ) {
* buf = head ;
TIPC_SKB_CB ( head ) - > tail = NULL ;
* headbuf = NULL ;
return 1 ;
}
* buf = NULL ;
return 0 ;
out_free :
pr_warn_ratelimited ( " Unable to build fragment list \n " ) ;
kfree_skb ( * buf ) ;
return 0 ;
}
tipc: introduce send functions for chained buffers in link
The current link implementation provides several different transmit
functions, depending on the characteristics of the message to be
sent: if it is an iovec or an sk_buff, if it needs fragmentation or
not, if the caller holds the node_lock or not. The permutation of
these options gives us an unwanted amount of unnecessarily complex
code.
As a first step towards simplifying the send path for all messages,
we introduce two new send functions at link level, tipc_link_xmit2()
and __tipc_link_xmit2(). The former looks up a link to the message
destination, and if one is found, it grabs the node lock and calls
the second function, which works exclusively inside the node lock
protection. If no link is found, and the destination is on the same
node, it delivers the message directly to the local destination
socket.
The new functions take a buffer chain where all packet headers are
already prepared, and the correct MTU has been used. These two
functions will later replace all other link-level transmit functions.
The functions are not backwards compatible, so we have added them
as new functions with temporary names. They are tested, but have no
users yet. Those will be added later in this series.
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:32 +04:00
tipc: introduce direct iovec to buffer chain fragmentation function
Fragmentation at message sending is currently performed in two
places in link.c, depending on whether data to be transmitted
is delivered in the form of an iovec or as a big sk_buff. Those
functions are also tightly entangled with the send functions
that are using them.
We now introduce a re-entrant, standalone function, tipc_msg_build2(),
that builds a packet chain directly from an iovec. Each fragment is
sized according to the MTU value given by the caller, and is prepended
with a correctly built fragment header, when needed. The function is
independent from who is calling and where the chain will be delivered,
as long as the caller is able to indicate a correct MTU.
The function is tested, but not called by anybody yet. Since it is
incompatible with the existing tipc_msg_build(), and we cannot yet
remove that function, we have given it a temporary name.
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:34 +04:00
/**
* tipc_msg_build2 - create buffer chain containing specified header and data
* @ mhdr : Message header , to be prepended to data
* @ iov : User data
* @ offset : Posision in iov to start copying from
* @ dsz : Total length of user data
* @ pktmax : Max packet size that can be used
* @ chain : Buffer or chain of buffers to be returned to caller
* Returns message data size or errno : - ENOMEM , - EFAULT
*/
int tipc_msg_build2 ( struct tipc_msg * mhdr , struct iovec const * iov ,
int offset , int dsz , int pktmax , struct sk_buff * * chain )
{
int mhsz = msg_hdr_sz ( mhdr ) ;
int msz = mhsz + dsz ;
int pktno = 1 ;
int pktsz ;
int pktrem = pktmax ;
int drem = dsz ;
struct tipc_msg pkthdr ;
struct sk_buff * buf , * prev ;
char * pktpos ;
int rc ;
msg_set_size ( mhdr , msz ) ;
/* No fragmentation needed? */
if ( likely ( msz < = pktmax ) ) {
buf = tipc_buf_acquire ( msz ) ;
* chain = buf ;
if ( unlikely ( ! buf ) )
return - ENOMEM ;
skb_copy_to_linear_data ( buf , mhdr , mhsz ) ;
pktpos = buf - > data + mhsz ;
if ( ! dsz | | ! memcpy_fromiovecend ( pktpos , iov , offset , dsz ) )
return dsz ;
rc = - EFAULT ;
goto error ;
}
/* Prepare reusable fragment header */
tipc_msg_init ( & pkthdr , MSG_FRAGMENTER , FIRST_FRAGMENT ,
INT_H_SIZE , msg_destnode ( mhdr ) ) ;
msg_set_size ( & pkthdr , pktmax ) ;
msg_set_fragm_no ( & pkthdr , pktno ) ;
/* Prepare first fragment */
* chain = buf = tipc_buf_acquire ( pktmax ) ;
if ( ! buf )
return - ENOMEM ;
pktpos = buf - > data ;
skb_copy_to_linear_data ( buf , & pkthdr , INT_H_SIZE ) ;
pktpos + = INT_H_SIZE ;
pktrem - = INT_H_SIZE ;
skb_copy_to_linear_data_offset ( buf , INT_H_SIZE , mhdr , mhsz ) ;
pktpos + = mhsz ;
pktrem - = mhsz ;
do {
if ( drem < pktrem )
pktrem = drem ;
if ( memcpy_fromiovecend ( pktpos , iov , offset , pktrem ) ) {
rc = - EFAULT ;
goto error ;
}
drem - = pktrem ;
offset + = pktrem ;
if ( ! drem )
break ;
/* Prepare new fragment: */
if ( drem < ( pktmax - INT_H_SIZE ) )
pktsz = drem + INT_H_SIZE ;
else
pktsz = pktmax ;
prev = buf ;
buf = tipc_buf_acquire ( pktsz ) ;
if ( ! buf ) {
rc = - ENOMEM ;
goto error ;
}
prev - > next = buf ;
msg_set_type ( & pkthdr , FRAGMENT ) ;
msg_set_size ( & pkthdr , pktsz ) ;
msg_set_fragm_no ( & pkthdr , + + pktno ) ;
skb_copy_to_linear_data ( buf , & pkthdr , INT_H_SIZE ) ;
pktpos = buf - > data + INT_H_SIZE ;
pktrem = pktsz - INT_H_SIZE ;
} while ( 1 ) ;
msg_set_type ( buf_msg ( buf ) , LAST_FRAGMENT ) ;
return dsz ;
error :
kfree_skb_list ( * chain ) ;
* chain = NULL ;
return rc ;
}
tipc: introduce send functions for chained buffers in link
The current link implementation provides several different transmit
functions, depending on the characteristics of the message to be
sent: if it is an iovec or an sk_buff, if it needs fragmentation or
not, if the caller holds the node_lock or not. The permutation of
these options gives us an unwanted amount of unnecessarily complex
code.
As a first step towards simplifying the send path for all messages,
we introduce two new send functions at link level, tipc_link_xmit2()
and __tipc_link_xmit2(). The former looks up a link to the message
destination, and if one is found, it grabs the node lock and calls
the second function, which works exclusively inside the node lock
protection. If no link is found, and the destination is on the same
node, it delivers the message directly to the local destination
socket.
The new functions take a buffer chain where all packet headers are
already prepared, and the correct MTU has been used. These two
functions will later replace all other link-level transmit functions.
The functions are not backwards compatible, so we have added them
as new functions with temporary names. They are tested, but have no
users yet. Those will be added later in this series.
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:32 +04:00
/**
* tipc_msg_bundle ( ) : Append contents of a buffer to tail of an existing one
* @ bbuf : the existing buffer ( " bundle " )
* @ buf : buffer to be appended
* @ mtu : max allowable size for the bundle buffer
* Consumes buffer if successful
* Returns true if bundling could be performed , otherwise false
*/
bool tipc_msg_bundle ( struct sk_buff * bbuf , struct sk_buff * buf , u32 mtu )
{
struct tipc_msg * bmsg = buf_msg ( bbuf ) ;
struct tipc_msg * msg = buf_msg ( buf ) ;
unsigned int bsz = msg_size ( bmsg ) ;
unsigned int msz = msg_size ( msg ) ;
u32 start = align ( bsz ) ;
u32 max = mtu - INT_H_SIZE ;
u32 pad = start - bsz ;
if ( likely ( msg_user ( msg ) = = MSG_FRAGMENTER ) )
return false ;
if ( unlikely ( msg_user ( msg ) = = CHANGEOVER_PROTOCOL ) )
return false ;
if ( unlikely ( msg_user ( msg ) = = BCAST_PROTOCOL ) )
return false ;
if ( likely ( msg_user ( bmsg ) ! = MSG_BUNDLER ) )
return false ;
if ( likely ( msg_type ( bmsg ) ! = BUNDLE_OPEN ) )
return false ;
if ( unlikely ( skb_tailroom ( bbuf ) < ( pad + msz ) ) )
return false ;
if ( unlikely ( max < ( start + msz ) ) )
return false ;
skb_put ( bbuf , pad + msz ) ;
skb_copy_to_linear_data_offset ( bbuf , start , buf - > data , msz ) ;
msg_set_size ( bmsg , start + msz ) ;
msg_set_msgcnt ( bmsg , msg_msgcnt ( bmsg ) + 1 ) ;
bbuf - > next = buf - > next ;
kfree_skb ( buf ) ;
return true ;
}
/**
* tipc_msg_make_bundle ( ) : Create bundle buf and append message to its tail
* @ buf : buffer to be appended and replaced
* @ mtu : max allowable size for the bundle buffer , inclusive header
* @ dnode : destination node for message . ( Not always present in header )
* Replaces buffer if successful
* Returns true if sucess , otherwise false
*/
bool tipc_msg_make_bundle ( struct sk_buff * * buf , u32 mtu , u32 dnode )
{
struct sk_buff * bbuf ;
struct tipc_msg * bmsg ;
struct tipc_msg * msg = buf_msg ( * buf ) ;
u32 msz = msg_size ( msg ) ;
u32 max = mtu - INT_H_SIZE ;
if ( msg_user ( msg ) = = MSG_FRAGMENTER )
return false ;
if ( msg_user ( msg ) = = CHANGEOVER_PROTOCOL )
return false ;
if ( msg_user ( msg ) = = BCAST_PROTOCOL )
return false ;
if ( msz > ( max / 2 ) )
return false ;
bbuf = tipc_buf_acquire ( max ) ;
if ( ! bbuf )
return false ;
skb_trim ( bbuf , INT_H_SIZE ) ;
bmsg = buf_msg ( bbuf ) ;
tipc_msg_init ( bmsg , MSG_BUNDLER , BUNDLE_OPEN , INT_H_SIZE , dnode ) ;
msg_set_seqno ( bmsg , msg_seqno ( msg ) ) ;
msg_set_ack ( bmsg , msg_ack ( msg ) ) ;
msg_set_bcast_ack ( bmsg , msg_bcast_ack ( msg ) ) ;
bbuf - > next = ( * buf ) - > next ;
tipc_msg_bundle ( bbuf , * buf , mtu ) ;
* buf = bbuf ;
return true ;
}
2014-06-26 05:41:35 +04:00
/**
* tipc_msg_reverse ( ) : swap source and destination addresses and add error code
* @ buf : buffer containing message to be reversed
* @ dnode : return value : node where to send message after reversal
* @ err : error code to be set in message
* Consumes buffer if failure
* Returns true if success , otherwise false
*/
bool tipc_msg_reverse ( struct sk_buff * buf , u32 * dnode , int err )
{
struct tipc_msg * msg = buf_msg ( buf ) ;
uint imp = msg_importance ( msg ) ;
struct tipc_msg ohdr ;
uint rdsz = min_t ( uint , msg_data_sz ( msg ) , MAX_FORWARD_SIZE ) ;
2014-06-26 05:41:41 +04:00
if ( skb_linearize ( buf ) )
2014-06-26 05:41:35 +04:00
goto exit ;
2014-06-26 05:41:41 +04:00
if ( msg_dest_droppable ( msg ) )
goto exit ;
if ( msg_errcode ( msg ) )
2014-06-26 05:41:35 +04:00
goto exit ;
memcpy ( & ohdr , msg , msg_hdr_sz ( msg ) ) ;
2014-06-26 05:41:41 +04:00
imp = min_t ( uint , imp + 1 , TIPC_CRITICAL_IMPORTANCE ) ;
if ( msg_isdata ( msg ) )
msg_set_importance ( msg , imp ) ;
2014-06-26 05:41:35 +04:00
msg_set_errcode ( msg , err ) ;
msg_set_origport ( msg , msg_destport ( & ohdr ) ) ;
msg_set_destport ( msg , msg_origport ( & ohdr ) ) ;
msg_set_prevnode ( msg , tipc_own_addr ) ;
if ( ! msg_short ( msg ) ) {
msg_set_orignode ( msg , msg_destnode ( & ohdr ) ) ;
msg_set_destnode ( msg , msg_orignode ( & ohdr ) ) ;
}
msg_set_size ( msg , msg_hdr_sz ( msg ) + rdsz ) ;
skb_trim ( buf , msg_size ( msg ) ) ;
skb_orphan ( buf ) ;
* dnode = msg_orignode ( & ohdr ) ;
return true ;
exit :
kfree_skb ( buf ) ;
return false ;
}
tipc: introduce message evaluation function
When a message arrives in a node and finds no destination
socket, we may need to drop it, reject it, or forward it after
a secondary destination lookup. The latter two cases currently
results in a code path that is perceived as complex, because it
follows a deep call chain via obscure functions such as
net_route_named_msg() and net_route_msg().
We now introduce a function, tipc_msg_eval(), that takes the
decision about whether such a message should be rejected or
forwarded, but leaves it to the caller to actually perform
the indicated action.
If the decision is 'reject', it is still the task of the recently
introduced function tipc_msg_reverse() to take the final decision
about whether the message is rejectable or not. In the latter case
it drops the message.
As a result of this change, we can finally eliminate the function
net_route_named_msg(), and hence become independent of net_route_msg().
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-06-26 05:41:36 +04:00
/**
* tipc_msg_eval : determine fate of message that found no destination
* @ buf : the buffer containing the message .
* @ dnode : return value : next - hop node , if message to be forwarded
* @ err : error code to use , if message to be rejected
*
* Does not consume buffer
* Returns 0 ( TIPC_OK ) if message ok and we can try again , - TIPC error
* code if message to be rejected
*/
int tipc_msg_eval ( struct sk_buff * buf , u32 * dnode )
{
struct tipc_msg * msg = buf_msg ( buf ) ;
u32 dport ;
if ( msg_type ( msg ) ! = TIPC_NAMED_MSG )
return - TIPC_ERR_NO_PORT ;
if ( skb_linearize ( buf ) )
return - TIPC_ERR_NO_NAME ;
if ( msg_data_sz ( msg ) > MAX_FORWARD_SIZE )
return - TIPC_ERR_NO_NAME ;
if ( msg_reroute_cnt ( msg ) > 0 )
return - TIPC_ERR_NO_NAME ;
* dnode = addr_domain ( msg_lookup_scope ( msg ) ) ;
dport = tipc_nametbl_translate ( msg_nametype ( msg ) ,
msg_nameinst ( msg ) ,
dnode ) ;
if ( ! dport )
return - TIPC_ERR_NO_NAME ;
msg_incr_reroute_cnt ( msg ) ;
msg_set_destnode ( msg , * dnode ) ;
msg_set_destport ( msg , dport ) ;
return TIPC_OK ;
}