2005-04-17 02:20:36 +04:00
/*
2005-11-02 06:59:41 +03:00
* Copyright ( c ) 2000 - 2003 Silicon Graphics , Inc .
* All Rights Reserved .
2005-04-17 02:20:36 +04:00
*
2005-11-02 06:59:41 +03:00
* This program is free software ; you can redistribute it and / or
* modify it under the terms of the GNU General Public License as
2005-04-17 02:20:36 +04:00
* published by the Free Software Foundation .
*
2005-11-02 06:59:41 +03:00
* This program is distributed in the hope that it would be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
* GNU General Public License for more details .
2005-04-17 02:20:36 +04:00
*
2005-11-02 06:59:41 +03:00
* You should have received a copy of the GNU General Public License
* along with this program ; if not , write the Free Software Foundation ,
* Inc . , 51 Franklin St , Fifth Floor , Boston , MA 02110 - 1301 USA
2005-04-17 02:20:36 +04:00
*/
# include "xfs.h"
# include "xfs_fs.h"
2013-08-12 14:49:26 +04:00
# include "xfs_format.h"
2013-10-23 03:50:10 +04:00
# include "xfs_log_format.h"
2013-10-23 03:36:05 +04:00
# include "xfs_shared.h"
2013-10-23 03:50:10 +04:00
# include "xfs_trans_resv.h"
2005-11-02 06:38:42 +03:00
# include "xfs_bit.h"
2005-04-17 02:20:36 +04:00
# include "xfs_mount.h"
2016-08-03 04:15:38 +03:00
# include "xfs_defer.h"
2005-04-17 02:20:36 +04:00
# include "xfs_inode.h"
# include "xfs_bmap.h"
2013-08-12 14:49:42 +04:00
# include "xfs_bmap_util.h"
2013-10-23 03:50:10 +04:00
# include "xfs_alloc.h"
# include "xfs_quota.h"
2005-04-17 02:20:36 +04:00
# include "xfs_error.h"
2013-10-23 03:50:10 +04:00
# include "xfs_trans.h"
2005-04-17 02:20:36 +04:00
# include "xfs_buf_item.h"
# include "xfs_trans_space.h"
# include "xfs_trans_priv.h"
# include "xfs_qm.h"
2013-04-03 09:11:16 +04:00
# include "xfs_cksum.h"
2009-12-15 02:14:59 +03:00
# include "xfs_trace.h"
2013-10-23 03:50:10 +04:00
# include "xfs_log.h"
2013-10-23 03:51:50 +04:00
# include "xfs_bmap_btree.h"
2005-04-17 02:20:36 +04:00
/*
2011-12-07 01:58:19 +04:00
* Lock order :
*
* ip - > i_lock
2012-03-13 12:52:35 +04:00
* qi - > qi_tree_lock
2012-03-14 20:53:34 +04:00
* dquot - > q_qlock ( xfs_dqlock ( ) and friends )
* dquot - > q_flush ( xfs_dqflock ( ) and friends )
* qi - > qi_lru_lock
2011-12-07 01:58:19 +04:00
*
* If two dquots need to be locked the order is user before group / project ,
* otherwise by the lowest id first , see xfs_dqlock2 .
*/
2005-04-17 02:20:36 +04:00
# ifdef DEBUG
xfs_buftarg_t * xfs_dqerror_target ;
int xfs_do_dqerror ;
int xfs_dqreq_num ;
int xfs_dqerror_mod = 33 ;
# endif
2012-03-13 12:52:37 +04:00
struct kmem_zone * xfs_qm_dqtrxzone ;
static struct kmem_zone * xfs_qm_dqzone ;
xfs: lockdep needs to know about 3 dquot-deep nesting
Michael Semon reported that xfs/299 generated this lockdep warning:
=============================================
[ INFO: possible recursive locking detected ]
3.12.0-rc2+ #2 Not tainted
---------------------------------------------
touch/21072 is trying to acquire lock:
(&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
but task is already holding lock:
(&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(&xfs_dquot_other_class);
lock(&xfs_dquot_other_class);
*** DEADLOCK ***
May be due to missing lock nesting notation
7 locks held by touch/21072:
#0: (sb_writers#10){++++.+}, at: [<c11185b6>] mnt_want_write+0x1e/0x3e
#1: (&type->i_mutex_dir_key#4){+.+.+.}, at: [<c11078ee>] do_last+0x245/0xe40
#2: (sb_internal#2){++++.+}, at: [<c122c9e0>] xfs_trans_alloc+0x1f/0x35
#3: (&(&ip->i_lock)->mr_lock/1){+.+...}, at: [<c126cd1b>] xfs_ilock+0x100/0x1f1
#4: (&(&ip->i_lock)->mr_lock){++++-.}, at: [<c126cf52>] xfs_ilock_nowait+0x105/0x22f
#5: (&dqp->q_qlock){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
#6: (&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
The lockdep annotation for dquot lock nesting only understands
locking for user and "other" dquots, not user, group and quota
dquots. Fix the annotations to match the locking heirarchy we now
have.
Reported-by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-09-30 03:37:03 +04:00
static struct lock_class_key xfs_dquot_group_class ;
static struct lock_class_key xfs_dquot_project_class ;
2009-01-19 04:03:25 +03:00
2005-04-17 02:20:36 +04:00
/*
* This is called to free all the memory associated with a dquot
*/
void
xfs_qm_dqdestroy (
xfs_dquot_t * dqp )
{
2012-03-13 12:52:34 +04:00
ASSERT ( list_empty ( & dqp - > q_lru ) ) ;
2005-04-17 02:20:36 +04:00
xfs: allocate log vector buffers outside CIL context lock
One of the problems we currently have with delayed logging is that
under serious memory pressure we can deadlock memory reclaim. THis
occurs when memory reclaim (such as run by kswapd) is reclaiming XFS
inodes and issues a log force to unpin inodes that are dirty in the
CIL.
The CIL is pushed, but this will only occur once it gets the CIL
context lock to ensure that all committing transactions are complete
and no new transactions start being committed to the CIL while the
push switches to a new context.
The deadlock occurs when the CIL context lock is held by a
committing process that is doing memory allocation for log vector
buffers, and that allocation is then blocked on memory reclaim
making progress. Memory reclaim, however, is blocked waiting for
a log force to make progress, and so we effectively deadlock at this
point.
To solve this problem, we have to move the CIL log vector buffer
allocation outside of the context lock so that memory reclaim can
always make progress when it needs to force the log. The problem
with doing this is that a CIL push can take place while we are
determining if we need to allocate a new log vector buffer for
an item and hence the current log vector may go away without
warning. That means we canot rely on the existing log vector being
present when we finally grab the context lock and so we must have a
replacement buffer ready to go at all times.
To ensure this, introduce a "shadow log vector" buffer that is
always guaranteed to be present when we gain the CIL context lock
and format the item. This shadow buffer may or may not be used
during the formatting, but if the log item does not have an existing
log vector buffer or that buffer is too small for the new
modifications, we swap it for the new shadow buffer and format
the modifications into that new log vector buffer.
The result of this is that for any object we modify more than once
in a given CIL checkpoint, we double the memory required
to track dirty regions in the log. For single modifications then
we consume the shadow log vectorwe allocate on commit, and that gets
consumed by the checkpoint. However, if we make multiple
modifications, then the second transaction commit will allocate a
shadow log vector and hence we will end up with double the memory
usage as only one of the log vectors is consumed by the CIL
checkpoint. The remaining shadow vector will be freed when th elog
item is freed.
This can probably be optimised in future - access to the shadow log
vector is serialised by the object lock (as opposited to the active
log vector, which is controlled by the CIL context lock) and so we
can probably free shadow log vector from some objects when the log
item is marked clean on removal from the AIL.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-07-22 02:52:35 +03:00
kmem_free ( dqp - > q_logitem . qli_item . li_lv_shadow ) ;
2005-04-17 02:20:36 +04:00
mutex_destroy ( & dqp - > q_qlock ) ;
2009-12-15 02:14:59 +03:00
2015-10-12 10:21:22 +03:00
XFS_STATS_DEC ( dqp - > q_mount , xs_qm_dquot ) ;
kmem_zone_free ( xfs_qm_dqzone , dqp ) ;
2005-04-17 02:20:36 +04:00
}
/*
* If default limits are in force , push them into the dquot now .
* We overwrite the dquot limits only if they are zero and this
* is not the root dquot .
*/
void
xfs_qm_adjust_dqlimits (
2013-03-18 18:51:45 +04:00
struct xfs_mount * mp ,
struct xfs_dquot * dq )
2005-04-17 02:20:36 +04:00
{
2013-03-18 18:51:45 +04:00
struct xfs_quotainfo * q = mp - > m_quotainfo ;
struct xfs_disk_dquot * d = & dq - > q_core ;
2016-02-08 03:27:55 +03:00
struct xfs_def_quota * defq ;
2013-03-18 18:51:46 +04:00
int prealloc = 0 ;
2005-04-17 02:20:36 +04:00
ASSERT ( d - > d_id ) ;
2016-02-08 03:27:55 +03:00
defq = xfs_get_defquota ( dq , q ) ;
2005-04-17 02:20:36 +04:00
2016-02-08 03:27:55 +03:00
if ( defq - > bsoftlimit & & ! d - > d_blk_softlimit ) {
d - > d_blk_softlimit = cpu_to_be64 ( defq - > bsoftlimit ) ;
2013-03-18 18:51:46 +04:00
prealloc = 1 ;
}
2016-02-08 03:27:55 +03:00
if ( defq - > bhardlimit & & ! d - > d_blk_hardlimit ) {
d - > d_blk_hardlimit = cpu_to_be64 ( defq - > bhardlimit ) ;
2013-03-18 18:51:46 +04:00
prealloc = 1 ;
}
2016-02-08 03:27:55 +03:00
if ( defq - > isoftlimit & & ! d - > d_ino_softlimit )
d - > d_ino_softlimit = cpu_to_be64 ( defq - > isoftlimit ) ;
if ( defq - > ihardlimit & & ! d - > d_ino_hardlimit )
d - > d_ino_hardlimit = cpu_to_be64 ( defq - > ihardlimit ) ;
if ( defq - > rtbsoftlimit & & ! d - > d_rtb_softlimit )
d - > d_rtb_softlimit = cpu_to_be64 ( defq - > rtbsoftlimit ) ;
if ( defq - > rtbhardlimit & & ! d - > d_rtb_hardlimit )
d - > d_rtb_hardlimit = cpu_to_be64 ( defq - > rtbhardlimit ) ;
2013-03-18 18:51:46 +04:00
if ( prealloc )
xfs_dquot_set_prealloc_limits ( dq ) ;
2005-04-17 02:20:36 +04:00
}
/*
* Check the limits and timers of a dquot and start or reset timers
* if necessary .
* This gets called even when quota enforcement is OFF , which makes our
* life a little less complicated . ( We just don ' t reject any quota
* reservations in that case , when enforcement is off ) .
* We also return 0 as the values of the timers in Q_GETQUOTA calls , when
* enforcement ' s off .
* In contrast , warnings are a little different in that they don ' t
2005-06-21 09:49:06 +04:00
* ' automatically ' get started when limits get exceeded . They do
* get reset to zero , however , when we find the count to be under
* the soft limit ( they are only ever set non - zero via userspace ) .
2005-04-17 02:20:36 +04:00
*/
void
xfs_qm_adjust_dqtimers (
xfs_mount_t * mp ,
xfs_disk_dquot_t * d )
{
ASSERT ( d - > d_id ) ;
2011-07-13 15:43:50 +04:00
# ifdef DEBUG
2005-11-02 07:01:12 +03:00
if ( d - > d_blk_hardlimit )
ASSERT ( be64_to_cpu ( d - > d_blk_softlimit ) < =
be64_to_cpu ( d - > d_blk_hardlimit ) ) ;
if ( d - > d_ino_hardlimit )
ASSERT ( be64_to_cpu ( d - > d_ino_softlimit ) < =
be64_to_cpu ( d - > d_ino_hardlimit ) ) ;
if ( d - > d_rtb_hardlimit )
ASSERT ( be64_to_cpu ( d - > d_rtb_softlimit ) < =
be64_to_cpu ( d - > d_rtb_hardlimit ) ) ;
2005-04-17 02:20:36 +04:00
# endif
2011-07-13 15:43:50 +04:00
2005-04-17 02:20:36 +04:00
if ( ! d - > d_btimer ) {
2005-11-02 07:01:12 +03:00
if ( ( d - > d_blk_softlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_bcount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_blk_softlimit ) ) ) | |
( d - > d_blk_hardlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_bcount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_blk_hardlimit ) ) ) ) {
d - > d_btimer = cpu_to_be32 ( get_seconds ( ) +
2010-04-20 11:01:30 +04:00
mp - > m_quotainfo - > qi_btimelimit ) ;
2005-06-21 09:49:06 +04:00
} else {
d - > d_bwarns = 0 ;
2005-04-17 02:20:36 +04:00
}
} else {
if ( ( ! d - > d_blk_softlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_bcount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_blk_softlimit ) ) ) & &
2005-04-17 02:20:36 +04:00
( ! d - > d_blk_hardlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_bcount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_blk_hardlimit ) ) ) ) {
2005-04-17 02:20:36 +04:00
d - > d_btimer = 0 ;
}
}
if ( ! d - > d_itimer ) {
2005-11-02 07:01:12 +03:00
if ( ( d - > d_ino_softlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_icount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_ino_softlimit ) ) ) | |
( d - > d_ino_hardlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_icount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_ino_hardlimit ) ) ) ) {
d - > d_itimer = cpu_to_be32 ( get_seconds ( ) +
2010-04-20 11:01:30 +04:00
mp - > m_quotainfo - > qi_itimelimit ) ;
2005-06-21 09:49:06 +04:00
} else {
d - > d_iwarns = 0 ;
2005-04-17 02:20:36 +04:00
}
} else {
if ( ( ! d - > d_ino_softlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_icount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_ino_softlimit ) ) ) & &
2005-04-17 02:20:36 +04:00
( ! d - > d_ino_hardlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_icount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_ino_hardlimit ) ) ) ) {
2005-04-17 02:20:36 +04:00
d - > d_itimer = 0 ;
}
}
if ( ! d - > d_rtbtimer ) {
2005-11-02 07:01:12 +03:00
if ( ( d - > d_rtb_softlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_rtbcount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_rtb_softlimit ) ) ) | |
( d - > d_rtb_hardlimit & &
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_rtbcount ) >
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_rtb_hardlimit ) ) ) ) {
d - > d_rtbtimer = cpu_to_be32 ( get_seconds ( ) +
2010-04-20 11:01:30 +04:00
mp - > m_quotainfo - > qi_rtbtimelimit ) ;
2005-06-21 09:49:06 +04:00
} else {
d - > d_rtbwarns = 0 ;
2005-04-17 02:20:36 +04:00
}
} else {
if ( ( ! d - > d_rtb_softlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_rtbcount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_rtb_softlimit ) ) ) & &
2005-04-17 02:20:36 +04:00
( ! d - > d_rtb_hardlimit | |
2012-02-06 16:50:07 +04:00
( be64_to_cpu ( d - > d_rtbcount ) < =
2005-11-02 07:01:12 +03:00
be64_to_cpu ( d - > d_rtb_hardlimit ) ) ) ) {
2005-04-17 02:20:36 +04:00
d - > d_rtbtimer = 0 ;
}
}
}
/*
* initialize a buffer full of dquots and log the whole thing
*/
STATIC void
xfs_qm_init_dquot_blk (
xfs_trans_t * tp ,
xfs_mount_t * mp ,
xfs_dqid_t id ,
uint type ,
xfs_buf_t * bp )
{
2010-04-20 11:01:30 +04:00
struct xfs_quotainfo * q = mp - > m_quotainfo ;
2005-04-17 02:20:36 +04:00
xfs_dqblk_t * d ;
2016-02-08 03:22:58 +03:00
xfs_dqid_t curid ;
int i ;
2005-04-17 02:20:36 +04:00
ASSERT ( tp ) ;
2011-07-08 16:36:19 +04:00
ASSERT ( xfs_buf_islocked ( bp ) ) ;
2005-04-17 02:20:36 +04:00
2011-07-23 03:40:15 +04:00
d = bp - > b_addr ;
2005-04-17 02:20:36 +04:00
/*
* ID of the first dquot in the block - id ' s are zero based .
*/
2010-04-20 11:01:30 +04:00
curid = id - ( id % q - > qi_dqperchunk ) ;
memset ( d , 0 , BBTOB ( q - > qi_dqchunklen ) ) ;
2011-12-07 01:58:23 +04:00
for ( i = 0 ; i < q - > qi_dqperchunk ; i + + , d + + , curid + + ) {
d - > dd_diskdq . d_magic = cpu_to_be16 ( XFS_DQUOT_MAGIC ) ;
d - > dd_diskdq . d_version = XFS_DQUOT_VERSION ;
d - > dd_diskdq . d_id = cpu_to_be32 ( curid ) ;
d - > dd_diskdq . d_flags = type ;
xfs: rework dquot CRCs
Calculating dquot CRCs when the backing buffer is written back just
doesn't work reliably. There are several places which manipulate
dquots directly in the buffers, and they don't calculate CRCs
appropriately, nor do they always set the buffer up to calculate
CRCs appropriately.
Firstly, if we log a dquot buffer (e.g. during allocation) it gets
logged without valid CRC, and so on recovery we end up with a dquot
that is not valid.
Secondly, if we recover/repair a dquot, we don't have a verifier
attached to the buffer and hence CRCs are not calculated on the way
down to disk.
Thirdly, calculating the CRC after we've changed the contents means
that if we re-read the dquot from the buffer, we cannot verify the
contents of the dquot are valid, as the CRC is invalid.
So, to avoid all the dquot CRC errors that are being detected by the
read verifier, change to using the same model as for inodes. That
is, dquot CRCs are calculated and written to the backing buffer at
the time the dquot is flushed to the backing buffer. If we modify
the dquot directly in the backing buffer, calculate the CRC
immediately after the modification is complete. Hence the dquot in
the on-disk buffer should always have a valid CRC.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-06-03 09:28:46 +04:00
if ( xfs_sb_version_hascrc ( & mp - > m_sb ) ) {
2015-08-19 03:32:01 +03:00
uuid_copy ( & d - > dd_uuid , & mp - > m_sb . sb_meta_uuid ) ;
xfs: rework dquot CRCs
Calculating dquot CRCs when the backing buffer is written back just
doesn't work reliably. There are several places which manipulate
dquots directly in the buffers, and they don't calculate CRCs
appropriately, nor do they always set the buffer up to calculate
CRCs appropriately.
Firstly, if we log a dquot buffer (e.g. during allocation) it gets
logged without valid CRC, and so on recovery we end up with a dquot
that is not valid.
Secondly, if we recover/repair a dquot, we don't have a verifier
attached to the buffer and hence CRCs are not calculated on the way
down to disk.
Thirdly, calculating the CRC after we've changed the contents means
that if we re-read the dquot from the buffer, we cannot verify the
contents of the dquot are valid, as the CRC is invalid.
So, to avoid all the dquot CRC errors that are being detected by the
read verifier, change to using the same model as for inodes. That
is, dquot CRCs are calculated and written to the backing buffer at
the time the dquot is flushed to the backing buffer. If we modify
the dquot directly in the backing buffer, calculate the CRC
immediately after the modification is complete. Hence the dquot in
the on-disk buffer should always have a valid CRC.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-06-03 09:28:46 +04:00
xfs_update_cksum ( ( char * ) d , sizeof ( struct xfs_dqblk ) ,
XFS_DQUOT_CRC_OFF ) ;
}
2011-12-07 01:58:23 +04:00
}
2005-04-17 02:20:36 +04:00
xfs_trans_dquot_buf ( tp , bp ,
2010-05-07 05:05:19 +04:00
( type & XFS_DQ_USER ? XFS_BLF_UDQUOT_BUF :
( ( type & XFS_DQ_PROJ ) ? XFS_BLF_PDQUOT_BUF :
XFS_BLF_GDQUOT_BUF ) ) ) ;
2010-04-20 11:01:30 +04:00
xfs_trans_log_buf ( tp , bp , 0 , BBTOB ( q - > qi_dqchunklen ) - 1 ) ;
2005-04-17 02:20:36 +04:00
}
2013-03-18 18:51:46 +04:00
/*
* Initialize the dynamic speculative preallocation thresholds . The lo / hi
* watermarks correspond to the soft and hard limits by default . If a soft limit
* is not specified , we use 95 % of the hard limit .
*/
void
xfs_dquot_set_prealloc_limits ( struct xfs_dquot * dqp )
{
__uint64_t space ;
dqp - > q_prealloc_hi_wmark = be64_to_cpu ( dqp - > q_core . d_blk_hardlimit ) ;
dqp - > q_prealloc_lo_wmark = be64_to_cpu ( dqp - > q_core . d_blk_softlimit ) ;
if ( ! dqp - > q_prealloc_lo_wmark ) {
dqp - > q_prealloc_lo_wmark = dqp - > q_prealloc_hi_wmark ;
do_div ( dqp - > q_prealloc_lo_wmark , 100 ) ;
dqp - > q_prealloc_lo_wmark * = 95 ;
}
space = dqp - > q_prealloc_hi_wmark ;
do_div ( space , 100 ) ;
dqp - > q_low_space [ XFS_QLOWSP_1_PCNT ] = space ;
dqp - > q_low_space [ XFS_QLOWSP_3_PCNT ] = space * 3 ;
dqp - > q_low_space [ XFS_QLOWSP_5_PCNT ] = space * 5 ;
}
2005-04-17 02:20:36 +04:00
/*
* Allocate a block and fill it with dquots .
* This is called when the bmapi finds a hole .
*/
STATIC int
xfs_qm_dqalloc (
2005-09-05 02:29:01 +04:00
xfs_trans_t * * tpp ,
2005-04-17 02:20:36 +04:00
xfs_mount_t * mp ,
xfs_dquot_t * dqp ,
xfs_inode_t * quotip ,
xfs_fileoff_t offset_fsb ,
xfs_buf_t * * O_bpp )
{
xfs_fsblock_t firstblock ;
2016-08-03 04:19:29 +03:00
struct xfs_defer_ops dfops ;
2005-04-17 02:20:36 +04:00
xfs_bmbt_irec_t map ;
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
int nmaps , error ;
2005-04-17 02:20:36 +04:00
xfs_buf_t * bp ;
2005-09-05 02:29:01 +04:00
xfs_trans_t * tp = * tpp ;
2005-04-17 02:20:36 +04:00
ASSERT ( tp ! = NULL ) ;
2009-12-15 02:14:59 +03:00
trace_xfs_dqalloc ( dqp ) ;
2005-04-17 02:20:36 +04:00
/*
* Initialize the bmap freelist prior to calling bmapi code .
*/
2016-08-03 04:19:29 +03:00
xfs_defer_init ( & dfops , & firstblock ) ;
2005-04-17 02:20:36 +04:00
xfs_ilock ( quotip , XFS_ILOCK_EXCL ) ;
/*
* Return if this type of quotas is turned off while we didn ' t
* have an inode lock
*/
2012-01-23 21:31:25 +04:00
if ( ! xfs_this_quota_on ( dqp - > q_mount , dqp - > dq_flags ) ) {
2005-04-17 02:20:36 +04:00
xfs_iunlock ( quotip , XFS_ILOCK_EXCL ) ;
2014-06-25 08:58:08 +04:00
return - ESRCH ;
2005-04-17 02:20:36 +04:00
}
2011-09-19 19:00:54 +04:00
xfs_trans_ijoin ( tp , quotip , XFS_ILOCK_EXCL ) ;
2005-04-17 02:20:36 +04:00
nmaps = 1 ;
2011-09-19 00:40:52 +04:00
error = xfs_bmapi_write ( tp , quotip , offset_fsb ,
XFS_DQUOT_CLUSTER_SIZE_FSB , XFS_BMAPI_METADATA ,
& firstblock , XFS_QM_DQALLOC_SPACE_RES ( mp ) ,
2016-08-03 04:19:29 +03:00
& map , & nmaps , & dfops ) ;
2011-09-19 00:40:52 +04:00
if ( error )
2005-04-17 02:20:36 +04:00
goto error0 ;
ASSERT ( map . br_blockcount = = XFS_DQUOT_CLUSTER_SIZE_FSB ) ;
ASSERT ( nmaps = = 1 ) ;
ASSERT ( ( map . br_startblock ! = DELAYSTARTBLOCK ) & &
( map . br_startblock ! = HOLESTARTBLOCK ) ) ;
/*
* Keep track of the blkno to save a lookup later
*/
dqp - > q_blkno = XFS_FSB_TO_DADDR ( mp , map . br_startblock ) ;
/* now we can just get the buffer (there's nothing to read yet) */
bp = xfs_trans_get_buf ( tp , mp - > m_ddev_targp ,
dqp - > q_blkno ,
2010-04-20 11:01:30 +04:00
mp - > m_quotainfo - > qi_dqchunklen ,
2005-04-17 02:20:36 +04:00
0 ) ;
2014-06-06 10:02:12 +04:00
if ( ! bp ) {
2014-06-25 08:58:08 +04:00
error = - ENOMEM ;
2005-04-17 02:20:36 +04:00
goto error1 ;
2014-06-06 10:02:12 +04:00
}
2012-11-14 10:54:40 +04:00
bp - > b_ops = & xfs_dquot_buf_ops ;
2011-09-20 17:56:55 +04:00
2005-04-17 02:20:36 +04:00
/*
* Make a chunk of dquots out of this buffer and log
* the entire thing .
*/
2005-11-02 07:01:12 +03:00
xfs_qm_init_dquot_blk ( tp , mp , be32_to_cpu ( dqp - > q_core . d_id ) ,
2005-06-21 09:38:48 +04:00
dqp - > dq_flags & XFS_DQ_ALLTYPES , bp ) ;
2005-04-17 02:20:36 +04:00
2005-09-05 02:29:01 +04:00
/*
2016-08-03 04:18:10 +03:00
* xfs_defer_finish ( ) may commit the current transaction and
2005-09-05 02:29:01 +04:00
* start a second transaction if the freelist is not empty .
*
* Since we still want to modify this buffer , we need to
* ensure that the buffer is not released on commit of
* the first transaction and ensure the buffer is added to the
* second transaction .
*
* If there is only one transaction then don ' t stop the buffer
* from being released when it commits later on .
*/
xfs_trans_bhold ( tp , bp ) ;
2016-08-03 04:19:29 +03:00
error = xfs_defer_finish ( tpp , & dfops , NULL ) ;
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
if ( error )
2005-04-17 02:20:36 +04:00
goto error1 ;
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
/* Transaction was committed? */
if ( * tpp ! = tp ) {
2005-09-05 02:29:01 +04:00
tp = * tpp ;
xfs_trans_bjoin ( tp , bp ) ;
} else {
xfs_trans_bhold_release ( tp , bp ) ;
}
2005-04-17 02:20:36 +04:00
* O_bpp = bp ;
return 0 ;
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
error1 :
2016-08-03 04:19:29 +03:00
xfs_defer_cancel ( & dfops ) ;
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
error0 :
2005-04-17 02:20:36 +04:00
xfs_iunlock ( quotip , XFS_ILOCK_EXCL ) ;
2014-06-22 09:03:54 +04:00
return error ;
2005-04-17 02:20:36 +04:00
}
2013-10-15 02:17:52 +04:00
2012-11-14 10:50:13 +04:00
STATIC int
xfs_qm_dqrepair (
struct xfs_mount * mp ,
struct xfs_trans * tp ,
struct xfs_dquot * dqp ,
xfs_dqid_t firstid ,
struct xfs_buf * * bpp )
{
int error ;
struct xfs_disk_dquot * ddq ;
struct xfs_dqblk * d ;
int i ;
/*
* Read the buffer without verification so we get the corrupted
2012-11-14 10:52:32 +04:00
* buffer returned to us . make sure we verify it on write , though .
2012-11-14 10:50:13 +04:00
*/
error = xfs_trans_read_buf ( mp , tp , mp - > m_ddev_targp , dqp - > q_blkno ,
mp - > m_quotainfo - > qi_dqchunklen ,
0 , bpp , NULL ) ;
if ( error ) {
ASSERT ( * bpp = = NULL ) ;
2014-06-22 09:04:54 +04:00
return error ;
2012-11-14 10:50:13 +04:00
}
2012-11-14 10:54:40 +04:00
( * bpp ) - > b_ops = & xfs_dquot_buf_ops ;
2012-11-14 10:50:13 +04:00
ASSERT ( xfs_buf_islocked ( * bpp ) ) ;
d = ( struct xfs_dqblk * ) ( * bpp ) - > b_addr ;
/* Do the actual repair of dquots in this buffer */
for ( i = 0 ; i < mp - > m_quotainfo - > qi_dqperchunk ; i + + ) {
ddq = & d [ i ] . dd_diskdq ;
2013-10-15 02:17:52 +04:00
error = xfs_dqcheck ( mp , ddq , firstid + i ,
2012-11-14 10:50:13 +04:00
dqp - > dq_flags & XFS_DQ_ALLTYPES ,
XFS_QMOPT_DQREPAIR , " xfs_qm_dqrepair " ) ;
if ( error ) {
/* repair failed, we're screwed */
xfs_trans_brelse ( tp , * bpp ) ;
2014-06-25 08:58:08 +04:00
return - EIO ;
2012-11-14 10:50:13 +04:00
}
}
return 0 ;
}
2005-04-17 02:20:36 +04:00
/*
* Maps a dquot to the buffer containing its on - disk version .
* This returns a ptr to the buffer containing the on - disk dquot
* in the bpp param , and a ptr to the on - disk dquot within that buffer
*/
STATIC int
xfs_qm_dqtobp (
2005-09-05 02:29:01 +04:00
xfs_trans_t * * tpp ,
2005-04-17 02:20:36 +04:00
xfs_dquot_t * dqp ,
xfs_disk_dquot_t * * O_ddpp ,
xfs_buf_t * * O_bpp ,
uint flags )
{
2013-06-28 02:25:07 +04:00
struct xfs_bmbt_irec map ;
int nmaps = 1 , error ;
struct xfs_buf * bp ;
2016-02-08 03:23:23 +03:00
struct xfs_inode * quotip ;
2013-06-28 02:25:07 +04:00
struct xfs_mount * mp = dqp - > q_mount ;
xfs_dqid_t id = be32_to_cpu ( dqp - > q_core . d_id ) ;
struct xfs_trans * tp = ( tpp ? * tpp : NULL ) ;
2013-12-07 00:30:13 +04:00
uint lock_mode ;
2005-04-17 02:20:36 +04:00
2016-02-08 03:23:23 +03:00
quotip = xfs_quota_inode ( dqp - > q_mount , dqp - > dq_flags ) ;
2010-09-06 05:44:45 +04:00
dqp - > q_fileoffset = ( xfs_fileoff_t ) id / mp - > m_quotainfo - > qi_dqperchunk ;
2005-04-17 02:20:36 +04:00
2013-12-07 00:30:13 +04:00
lock_mode = xfs_ilock_data_map_shared ( quotip ) ;
2012-01-23 21:31:25 +04:00
if ( ! xfs_this_quota_on ( dqp - > q_mount , dqp - > dq_flags ) ) {
2005-04-17 02:20:36 +04:00
/*
2010-09-06 05:44:45 +04:00
* Return if this type of quotas is turned off while we
* didn ' t have the quota inode lock .
2005-04-17 02:20:36 +04:00
*/
2013-12-07 00:30:13 +04:00
xfs_iunlock ( quotip , lock_mode ) ;
2014-06-25 08:58:08 +04:00
return - ESRCH ;
2010-09-06 05:44:45 +04:00
}
/*
* Find the block map ; no allocations yet
*/
2011-09-19 00:40:45 +04:00
error = xfs_bmapi_read ( quotip , dqp - > q_fileoffset ,
XFS_DQUOT_CLUSTER_SIZE_FSB , & map , & nmaps , 0 ) ;
2010-09-06 05:44:45 +04:00
2013-12-07 00:30:13 +04:00
xfs_iunlock ( quotip , lock_mode ) ;
2010-09-06 05:44:45 +04:00
if ( error )
return error ;
ASSERT ( nmaps = = 1 ) ;
ASSERT ( map . br_blockcount = = 1 ) ;
/*
* Offset of dquot in the ( fixed sized ) dquot chunk .
*/
dqp - > q_bufoffset = ( id % mp - > m_quotainfo - > qi_dqperchunk ) *
sizeof ( xfs_dqblk_t ) ;
ASSERT ( map . br_startblock ! = DELAYSTARTBLOCK ) ;
if ( map . br_startblock = = HOLESTARTBLOCK ) {
2005-04-17 02:20:36 +04:00
/*
2010-09-06 05:44:45 +04:00
* We don ' t allocate unless we ' re asked to
2005-04-17 02:20:36 +04:00
*/
2010-09-06 05:44:45 +04:00
if ( ! ( flags & XFS_QMOPT_DQALLOC ) )
2014-06-25 08:58:08 +04:00
return - ENOENT ;
2005-04-17 02:20:36 +04:00
2010-09-06 05:44:45 +04:00
ASSERT ( tp ) ;
error = xfs_qm_dqalloc ( tpp , mp , dqp , quotip ,
dqp - > q_fileoffset , & bp ) ;
2005-04-17 02:20:36 +04:00
if ( error )
2010-09-06 05:44:45 +04:00
return error ;
tp = * tpp ;
} else {
trace_xfs_dqtobp_read ( dqp ) ;
2005-04-17 02:20:36 +04:00
/*
2010-09-06 05:44:45 +04:00
* store the blkno etc so that we don ' t have to do the
* mapping all the time
2005-04-17 02:20:36 +04:00
*/
2010-09-06 05:44:45 +04:00
dqp - > q_blkno = XFS_FSB_TO_DADDR ( mp , map . br_startblock ) ;
2009-12-15 02:14:59 +03:00
2010-04-20 11:01:30 +04:00
error = xfs_trans_read_buf ( mp , tp , mp - > m_ddev_targp ,
dqp - > q_blkno ,
mp - > m_quotainfo - > qi_dqchunklen ,
2012-11-14 10:54:40 +04:00
0 , & bp , & xfs_dquot_buf_ops ) ;
2010-09-06 05:44:45 +04:00
2014-06-25 08:58:08 +04:00
if ( error = = - EFSCORRUPTED & & ( flags & XFS_QMOPT_DQREPAIR ) ) {
2012-11-14 10:50:13 +04:00
xfs_dqid_t firstid = ( xfs_dqid_t ) map . br_startoff *
mp - > m_quotainfo - > qi_dqperchunk ;
ASSERT ( bp = = NULL ) ;
error = xfs_qm_dqrepair ( mp , tp , dqp , firstid , & bp ) ;
}
2005-04-17 02:20:36 +04:00
2012-11-14 10:50:13 +04:00
if ( error ) {
ASSERT ( bp = = NULL ) ;
2014-06-22 09:04:54 +04:00
return error ;
2005-04-17 02:20:36 +04:00
}
}
2012-11-14 10:50:13 +04:00
ASSERT ( xfs_buf_islocked ( bp ) ) ;
2005-04-17 02:20:36 +04:00
* O_bpp = bp ;
2012-11-14 10:50:13 +04:00
* O_ddpp = bp - > b_addr + dqp - > q_bufoffset ;
2005-04-17 02:20:36 +04:00
2014-06-22 09:03:54 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
/*
* Read in the ondisk dquot using dqtobp ( ) then copy it to an incore version ,
* and release the buffer immediately .
*
2011-12-07 01:58:24 +04:00
* If XFS_QMOPT_DQALLOC is set , allocate a dquot on disk if it needed .
2005-04-17 02:20:36 +04:00
*/
2011-12-07 01:58:25 +04:00
int
2005-04-17 02:20:36 +04:00
xfs_qm_dqread (
2011-12-07 01:58:24 +04:00
struct xfs_mount * mp ,
xfs_dqid_t id ,
uint type ,
uint flags ,
struct xfs_dquot * * O_dqpp )
2005-04-17 02:20:36 +04:00
{
2011-12-07 01:58:24 +04:00
struct xfs_dquot * dqp ;
struct xfs_disk_dquot * ddqp ;
struct xfs_buf * bp ;
struct xfs_trans * tp = NULL ;
int error ;
2012-02-01 17:57:20 +04:00
2012-03-13 12:52:37 +04:00
dqp = kmem_zone_zalloc ( xfs_qm_dqzone , KM_SLEEP ) ;
2012-02-01 17:57:20 +04:00
dqp - > dq_flags = type ;
dqp - > q_core . d_id = cpu_to_be32 ( id ) ;
dqp - > q_mount = mp ;
2012-03-13 12:52:34 +04:00
INIT_LIST_HEAD ( & dqp - > q_lru ) ;
2012-02-01 17:57:20 +04:00
mutex_init ( & dqp - > q_qlock ) ;
init_waitqueue_head ( & dqp - > q_pinwait ) ;
/*
* Because we want to use a counting completion , complete
* the flush completion once to allow a single access to
* the flush completion without blocking .
*/
init_completion ( & dqp - > q_flush ) ;
complete ( & dqp - > q_flush ) ;
/*
* Make sure group quotas have a different lock class than user
* quotas .
*/
xfs: lockdep needs to know about 3 dquot-deep nesting
Michael Semon reported that xfs/299 generated this lockdep warning:
=============================================
[ INFO: possible recursive locking detected ]
3.12.0-rc2+ #2 Not tainted
---------------------------------------------
touch/21072 is trying to acquire lock:
(&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
but task is already holding lock:
(&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
----
lock(&xfs_dquot_other_class);
lock(&xfs_dquot_other_class);
*** DEADLOCK ***
May be due to missing lock nesting notation
7 locks held by touch/21072:
#0: (sb_writers#10){++++.+}, at: [<c11185b6>] mnt_want_write+0x1e/0x3e
#1: (&type->i_mutex_dir_key#4){+.+.+.}, at: [<c11078ee>] do_last+0x245/0xe40
#2: (sb_internal#2){++++.+}, at: [<c122c9e0>] xfs_trans_alloc+0x1f/0x35
#3: (&(&ip->i_lock)->mr_lock/1){+.+...}, at: [<c126cd1b>] xfs_ilock+0x100/0x1f1
#4: (&(&ip->i_lock)->mr_lock){++++-.}, at: [<c126cf52>] xfs_ilock_nowait+0x105/0x22f
#5: (&dqp->q_qlock){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
#6: (&xfs_dquot_other_class){+.+...}, at: [<c12902fb>] xfs_trans_dqlockedjoin+0x57/0x64
The lockdep annotation for dquot lock nesting only understands
locking for user and "other" dquots, not user, group and quota
dquots. Fix the annotations to match the locking heirarchy we now
have.
Reported-by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-09-30 03:37:03 +04:00
switch ( type ) {
case XFS_DQ_USER :
/* uses the default lock class */
break ;
case XFS_DQ_GROUP :
lockdep_set_class ( & dqp - > q_qlock , & xfs_dquot_group_class ) ;
break ;
case XFS_DQ_PROJ :
lockdep_set_class ( & dqp - > q_qlock , & xfs_dquot_project_class ) ;
break ;
default :
ASSERT ( 0 ) ;
break ;
}
2012-02-01 17:57:20 +04:00
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_qm_dquot ) ;
2005-04-17 02:20:36 +04:00
2009-12-15 02:14:59 +03:00
trace_xfs_dqread ( dqp ) ;
2011-12-07 01:58:24 +04:00
if ( flags & XFS_QMOPT_DQALLOC ) {
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_qm_dqalloc ,
XFS_QM_DQALLOC_SPACE_RES ( mp ) , 0 , 0 , & tp ) ;
2011-12-07 01:58:24 +04:00
if ( error )
2016-04-06 02:19:55 +03:00
goto error0 ;
2011-12-07 01:58:24 +04:00
}
2005-04-17 02:20:36 +04:00
/*
* get a pointer to the on - disk dquot and the buffer containing it
* dqp already knows its own type ( GROUP / USER ) .
*/
2011-12-07 01:58:24 +04:00
error = xfs_qm_dqtobp ( & tp , dqp , & ddqp , & bp , flags ) ;
if ( error ) {
/*
* This can happen if quotas got turned off ( ESRCH ) ,
* or if the dquot didn ' t exist on disk and we ask to
* allocate ( ENOENT ) .
*/
trace_xfs_dqread_fail ( dqp ) ;
goto error1 ;
2005-04-17 02:20:36 +04:00
}
/* copy everything from disk dquot to the incore dquot */
memcpy ( & dqp - > q_core , ddqp , sizeof ( xfs_disk_dquot_t ) ) ;
xfs_qm_dquot_logitem_init ( dqp ) ;
/*
* Reservation counters are defined as reservation plus current usage
2011-03-31 05:57:33 +04:00
* to avoid having to add every time .
2005-04-17 02:20:36 +04:00
*/
2005-11-02 07:01:12 +03:00
dqp - > q_res_bcount = be64_to_cpu ( ddqp - > d_bcount ) ;
dqp - > q_res_icount = be64_to_cpu ( ddqp - > d_icount ) ;
dqp - > q_res_rtbcount = be64_to_cpu ( ddqp - > d_rtbcount ) ;
2005-04-17 02:20:36 +04:00
2013-03-18 18:51:46 +04:00
/* initialize the dquot speculative prealloc thresholds */
xfs_dquot_set_prealloc_limits ( dqp ) ;
2005-04-17 02:20:36 +04:00
/* Mark the buf so that this will stay incore a little longer */
2011-10-10 20:52:45 +04:00
xfs_buf_set_ref ( bp , XFS_DQUOT_REF ) ;
2005-04-17 02:20:36 +04:00
/*
* We got the buffer with a xfs_trans_read_buf ( ) ( in dqtobp ( ) )
* So we need to release with xfs_trans_brelse ( ) .
* The strategy here is identical to that of inodes ; we lock
* the dquot in xfs_qm_dqget ( ) before making it accessible to
* others . This is because dquots , like inodes , need a good level of
* concurrency , and we don ' t want to take locks on the entire buffers
* for dquot accesses .
* Note also that the dquot buffer may even be dirty at this point , if
* this particular dquot was repaired . We still aren ' t afraid to
* brelse it because we have the changes incore .
*/
2011-07-08 16:36:19 +04:00
ASSERT ( xfs_buf_islocked ( bp ) ) ;
2005-04-17 02:20:36 +04:00
xfs_trans_brelse ( tp , bp ) ;
if ( tp ) {
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2011-12-07 01:58:24 +04:00
if ( error )
goto error0 ;
2005-04-17 02:20:36 +04:00
}
* O_dqpp = dqp ;
2011-12-07 01:58:24 +04:00
return error ;
2005-04-17 02:20:36 +04:00
2011-12-07 01:58:24 +04:00
error1 :
2005-04-17 02:20:36 +04:00
if ( tp )
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2011-12-07 01:58:24 +04:00
error0 :
2005-04-17 02:20:36 +04:00
xfs_qm_dqdestroy ( dqp ) ;
* O_dqpp = NULL ;
2011-12-07 01:58:24 +04:00
return error ;
2005-04-17 02:20:36 +04:00
}
2016-02-08 03:27:38 +03:00
/*
* Advance to the next id in the current chunk , or if at the
* end of the chunk , skip ahead to first id in next allocated chunk
* using the SEEK_DATA interface .
*/
2016-04-06 02:47:21 +03:00
static int
2016-02-08 03:27:38 +03:00
xfs_dq_get_next_id (
xfs_mount_t * mp ,
uint type ,
xfs_dqid_t * id ,
loff_t eof )
{
struct xfs_inode * quotip ;
xfs_fsblock_t start ;
loff_t offset ;
uint lock ;
xfs_dqid_t next_id ;
int error = 0 ;
/* Simple advance */
next_id = * id + 1 ;
2017-01-17 22:43:38 +03:00
/* If we'd wrap past the max ID, stop */
if ( next_id < * id )
return - ENOENT ;
2016-02-08 03:27:38 +03:00
/* If new ID is within the current chunk, advancing it sufficed */
if ( next_id % mp - > m_quotainfo - > qi_dqperchunk ) {
* id = next_id ;
return 0 ;
}
/* Nope, next_id is now past the current chunk, so find the next one */
start = ( xfs_fsblock_t ) next_id / mp - > m_quotainfo - > qi_dqperchunk ;
quotip = xfs_quota_inode ( mp , type ) ;
lock = xfs_ilock_data_map_shared ( quotip ) ;
offset = __xfs_seek_hole_data ( VFS_I ( quotip ) , XFS_FSB_TO_B ( mp , start ) ,
eof , SEEK_DATA ) ;
if ( offset < 0 )
error = offset ;
xfs_iunlock ( quotip , lock ) ;
/* -ENXIO is essentially "no more data" */
if ( error )
return ( error = = - ENXIO ? - ENOENT : error ) ;
/* Convert next data offset back to a quota id */
* id = XFS_B_TO_FSB ( mp , offset ) * mp - > m_quotainfo - > qi_dqperchunk ;
return 0 ;
}
2005-04-17 02:20:36 +04:00
/*
* Given the file system , inode OR id , and type ( UDQUOT / GDQUOT ) , return a
* a locked dquot , doing an allocation ( if requested ) as needed .
* When both an inode and an id are given , the inode ' s id takes precedence .
* That is , if the id changes while we don ' t hold the ilock inside this
* function , the new dquot is returned , not necessarily the one requested
* in the id argument .
*/
int
xfs_qm_dqget (
xfs_mount_t * mp ,
xfs_inode_t * ip , /* locked inode (optional) */
2005-06-21 09:38:48 +04:00
xfs_dqid_t id , /* uid/projid/gid depending on type */
uint type , /* XFS_DQ_USER/XFS_DQ_PROJ/XFS_DQ_GROUP */
2005-04-17 02:20:36 +04:00
uint flags , /* DQALLOC, DQSUSER, DQREPAIR, DOWARN */
xfs_dquot_t * * O_dqpp ) /* OUT : locked incore dquot */
{
2012-03-13 12:52:35 +04:00
struct xfs_quotainfo * qi = mp - > m_quotainfo ;
2013-06-28 02:25:05 +04:00
struct radix_tree_root * tree = xfs_dquot_tree ( qi , type ) ;
2012-03-13 12:52:35 +04:00
struct xfs_dquot * dqp ;
2016-02-08 03:27:38 +03:00
loff_t eof = 0 ;
2012-03-13 12:52:35 +04:00
int error ;
2005-04-17 02:20:36 +04:00
ASSERT ( XFS_IS_QUOTA_RUNNING ( mp ) ) ;
if ( ( ! XFS_IS_UQUOTA_ON ( mp ) & & type = = XFS_DQ_USER ) | |
2005-06-21 09:38:48 +04:00
( ! XFS_IS_PQUOTA_ON ( mp ) & & type = = XFS_DQ_PROJ ) | |
2005-04-17 02:20:36 +04:00
( ! XFS_IS_GQUOTA_ON ( mp ) & & type = = XFS_DQ_GROUP ) ) {
2014-06-25 08:58:08 +04:00
return - ESRCH ;
2005-04-17 02:20:36 +04:00
}
# ifdef DEBUG
if ( xfs_do_dqerror ) {
if ( ( xfs_dqerror_target = = mp - > m_ddev_targp ) & &
( xfs_dqreq_num + + % xfs_dqerror_mod ) = = 0 ) {
2011-03-07 02:08:35 +03:00
xfs_debug ( mp , " Returning error in dqget " ) ;
2014-06-25 08:58:08 +04:00
return - EIO ;
2005-04-17 02:20:36 +04:00
}
}
2005-06-21 09:38:48 +04:00
ASSERT ( type = = XFS_DQ_USER | |
type = = XFS_DQ_PROJ | |
type = = XFS_DQ_GROUP ) ;
2005-04-17 02:20:36 +04:00
if ( ip ) {
2008-04-22 11:34:00 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL ) ) ;
2012-01-23 21:31:30 +04:00
ASSERT ( xfs_inode_dquot ( ip , type ) = = NULL ) ;
2005-04-17 02:20:36 +04:00
}
# endif
2011-12-07 01:58:18 +04:00
2016-02-08 03:27:38 +03:00
/* Get the end of the quota file if we need it */
if ( flags & XFS_QMOPT_DQNEXT ) {
struct xfs_inode * quotip ;
xfs_fileoff_t last ;
uint lock_mode ;
quotip = xfs_quota_inode ( mp , type ) ;
lock_mode = xfs_ilock_data_map_shared ( quotip ) ;
error = xfs_bmap_last_offset ( quotip , & last , XFS_DATA_FORK ) ;
xfs_iunlock ( quotip , lock_mode ) ;
if ( error )
return error ;
eof = XFS_FSB_TO_B ( mp , last ) ;
}
2011-12-07 01:58:18 +04:00
restart :
2012-03-13 12:52:35 +04:00
mutex_lock ( & qi - > qi_tree_lock ) ;
dqp = radix_tree_lookup ( tree , id ) ;
if ( dqp ) {
xfs_dqlock ( dqp ) ;
if ( dqp - > dq_flags & XFS_DQ_FREEING ) {
xfs_dqunlock ( dqp ) ;
mutex_unlock ( & qi - > qi_tree_lock ) ;
trace_xfs_dqget_freeing ( dqp ) ;
delay ( 1 ) ;
goto restart ;
}
2005-04-17 02:20:36 +04:00
2016-02-08 03:27:38 +03:00
/* uninit / unused quota found in radix tree, keep looking */
if ( flags & XFS_QMOPT_DQNEXT ) {
if ( XFS_IS_DQUOT_UNINITIALIZED ( dqp ) ) {
xfs_dqunlock ( dqp ) ;
mutex_unlock ( & qi - > qi_tree_lock ) ;
error = xfs_dq_get_next_id ( mp , type , & id , eof ) ;
if ( error )
return error ;
goto restart ;
}
}
2012-03-13 12:52:35 +04:00
dqp - > q_nrefs + + ;
mutex_unlock ( & qi - > qi_tree_lock ) ;
trace_xfs_dqget_hit ( dqp ) ;
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_qm_dqcachehits ) ;
2012-03-13 12:52:35 +04:00
* O_dqpp = dqp ;
return 0 ;
2005-04-17 02:20:36 +04:00
}
2012-03-13 12:52:35 +04:00
mutex_unlock ( & qi - > qi_tree_lock ) ;
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_qm_dqcachemisses ) ;
2005-04-17 02:20:36 +04:00
/*
* Dquot cache miss . We don ' t want to keep the inode lock across
* a ( potential ) disk read . Also we don ' t want to deal with the lock
* ordering between quotainode and this inode . OTOH , dropping the inode
* lock here means dealing with a chown that can happen before
* we re - acquire the lock .
*/
if ( ip )
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
2011-12-07 01:58:24 +04:00
error = xfs_qm_dqread ( mp , id , type , flags , & dqp ) ;
2005-04-17 02:20:36 +04:00
2011-12-07 01:58:25 +04:00
if ( ip )
xfs_ilock ( ip , XFS_ILOCK_EXCL ) ;
2016-02-08 03:27:38 +03:00
/* If we are asked to find next active id, keep looking */
if ( error = = - ENOENT & & ( flags & XFS_QMOPT_DQNEXT ) ) {
error = xfs_dq_get_next_id ( mp , type , & id , eof ) ;
if ( ! error )
goto restart ;
}
2011-12-07 01:58:25 +04:00
if ( error )
return error ;
2005-04-17 02:20:36 +04:00
if ( ip ) {
/*
* A dquot could be attached to this inode by now , since
* we had dropped the ilock .
*/
2012-01-23 21:31:30 +04:00
if ( xfs_this_quota_on ( mp , type ) ) {
2012-03-13 12:52:35 +04:00
struct xfs_dquot * dqp1 ;
2012-01-23 21:31:30 +04:00
dqp1 = xfs_inode_dquot ( ip , type ) ;
if ( dqp1 ) {
2005-04-17 02:20:36 +04:00
xfs_qm_dqdestroy ( dqp ) ;
2012-01-23 21:31:30 +04:00
dqp = dqp1 ;
2005-04-17 02:20:36 +04:00
xfs_dqlock ( dqp ) ;
goto dqret ;
}
} else {
2012-01-23 21:31:30 +04:00
/* inode stays locked on return */
xfs_qm_dqdestroy ( dqp ) ;
2014-06-25 08:58:08 +04:00
return - ESRCH ;
2005-04-17 02:20:36 +04:00
}
}
2012-03-13 12:52:35 +04:00
mutex_lock ( & qi - > qi_tree_lock ) ;
2014-06-25 08:58:08 +04:00
error = radix_tree_insert ( tree , id , dqp ) ;
2012-03-13 12:52:35 +04:00
if ( unlikely ( error ) ) {
2014-06-25 08:58:08 +04:00
WARN_ON ( error ! = - EEXIST ) ;
2012-03-13 12:52:35 +04:00
2005-04-17 02:20:36 +04:00
/*
2012-03-13 12:52:35 +04:00
* Duplicate found . Just throw away the new dquot and start
* over .
2005-04-17 02:20:36 +04:00
*/
2012-03-13 12:52:35 +04:00
mutex_unlock ( & qi - > qi_tree_lock ) ;
trace_xfs_dqget_dup ( dqp ) ;
xfs_qm_dqdestroy ( dqp ) ;
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_qm_dquot_dups ) ;
2012-03-13 12:52:35 +04:00
goto restart ;
2005-04-17 02:20:36 +04:00
}
/*
* We return a locked dquot to the caller , with a reference taken
*/
xfs_dqlock ( dqp ) ;
dqp - > q_nrefs = 1 ;
2012-03-13 12:52:35 +04:00
qi - > qi_dquots + + ;
mutex_unlock ( & qi - > qi_tree_lock ) ;
2016-02-08 03:27:38 +03:00
/* If we are asked to find next active id, keep looking */
if ( flags & XFS_QMOPT_DQNEXT ) {
if ( XFS_IS_DQUOT_UNINITIALIZED ( dqp ) ) {
xfs_qm_dqput ( dqp ) ;
error = xfs_dq_get_next_id ( mp , type , & id , eof ) ;
if ( error )
return error ;
goto restart ;
}
}
2005-04-17 02:20:36 +04:00
dqret :
2008-04-22 11:34:00 +04:00
ASSERT ( ( ip = = NULL ) | | xfs_isilocked ( ip , XFS_ILOCK_EXCL ) ) ;
2009-12-15 02:14:59 +03:00
trace_xfs_dqget_miss ( dqp ) ;
2005-04-17 02:20:36 +04:00
* O_dqpp = dqp ;
2014-06-22 09:03:54 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
2012-03-13 12:52:34 +04:00
/*
* Release a reference to the dquot ( decrement ref - count ) and unlock it .
*
* If there is a group quota attached to this dquot , carefully release that
* too without tripping over deadlocks ' n ' stuff .
*/
void
xfs_qm_dqput (
struct xfs_dquot * dqp )
{
ASSERT ( dqp - > q_nrefs > 0 ) ;
ASSERT ( XFS_DQ_IS_LOCKED ( dqp ) ) ;
trace_xfs_dqput ( dqp ) ;
xfs: remove dquot hints
group and project quota hints are currently stored on the user
dquot. If we are attaching quotas to the inode, then the group and
project dquots are stored as hints on the user dquot to save having
to look them up again later.
The thing is, the hints are not used for that inode for the rest of
the life of the inode - the dquots are attached directly to the
inode itself - so the only time the hints are used is when an inode
first has dquots attached.
When the hints on the user dquot don't match the dquots being
attache dto the inode, they are then removed and replaced with the
new hints. If a user is concurrently modifying files in different
group and/or project contexts, then this leads to thrashing of the
hints attached to user dquot.
If user quotas are not enabled, then hints are never even used.
So, if the hints are used to avoid the cost of the lookup, is the
cost of the lookup significant enough to justify the hint
infrstructure? Maybe it was once, when there was a global quota
manager shared between all XFS filesystems and was hash table based.
However, lookups are now much simpler, requiring only a single lock and
radix tree lookup local to the filesystem and no hash or LRU
manipulations to be made. Hence the cost of lookup is much lower
than when hints were implemented. Turns out that benchmarks show
that, too, with thir being no differnce in performance when doing
file creation workloads as a single user with user, group and
project quotas enabled - the hints do not make the code go any
faster. In fact, removing the hints shows a 2-3% reduction in the
time it takes to create 50 million inodes....
So, let's just get rid of the hints and the complexity around them.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 11:30:15 +04:00
if ( - - dqp - > q_nrefs = = 0 ) {
struct xfs_quotainfo * qi = dqp - > q_mount - > m_quotainfo ;
trace_xfs_dqput_free ( dqp ) ;
if ( list_lru_add ( & qi - > qi_lru , & dqp - > q_lru ) )
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( dqp - > q_mount , xs_qm_dquot_unused ) ;
xfs: remove dquot hints
group and project quota hints are currently stored on the user
dquot. If we are attaching quotas to the inode, then the group and
project dquots are stored as hints on the user dquot to save having
to look them up again later.
The thing is, the hints are not used for that inode for the rest of
the life of the inode - the dquots are attached directly to the
inode itself - so the only time the hints are used is when an inode
first has dquots attached.
When the hints on the user dquot don't match the dquots being
attache dto the inode, they are then removed and replaced with the
new hints. If a user is concurrently modifying files in different
group and/or project contexts, then this leads to thrashing of the
hints attached to user dquot.
If user quotas are not enabled, then hints are never even used.
So, if the hints are used to avoid the cost of the lookup, is the
cost of the lookup significant enough to justify the hint
infrstructure? Maybe it was once, when there was a global quota
manager shared between all XFS filesystems and was hash table based.
However, lookups are now much simpler, requiring only a single lock and
radix tree lookup local to the filesystem and no hash or LRU
manipulations to be made. Hence the cost of lookup is much lower
than when hints were implemented. Turns out that benchmarks show
that, too, with thir being no differnce in performance when doing
file creation workloads as a single user with user, group and
project quotas enabled - the hints do not make the code go any
faster. In fact, removing the hints shows a 2-3% reduction in the
time it takes to create 50 million inodes....
So, let's just get rid of the hints and the complexity around them.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 11:30:15 +04:00
}
xfs_dqunlock ( dqp ) ;
2005-04-17 02:20:36 +04:00
}
/*
* Release a dquot . Flush it if dirty , then dqput ( ) it .
* dquot must not be locked .
*/
void
xfs_qm_dqrele (
xfs_dquot_t * dqp )
{
2009-06-08 17:33:32 +04:00
if ( ! dqp )
return ;
2009-12-15 02:14:59 +03:00
trace_xfs_dqrele ( dqp ) ;
2005-04-17 02:20:36 +04:00
xfs_dqlock ( dqp ) ;
/*
* We don ' t care to flush it if the dquot is dirty here .
* That will create stutters that we want to avoid .
* Instead we do a delayed write when we try to reclaim
* a dirty dquot . Also xfs_sync will take part of the burden . . .
*/
xfs_qm_dqput ( dqp ) ;
}
2010-06-23 12:11:15 +04:00
/*
* This is the dquot flushing I / O completion routine . It is called
* from interrupt level when the buffer containing the dquot is
* flushed to disk . It is responsible for removing the dquot logitem
* from the AIL if it has not been re - logged , and unlocking the dquot ' s
* flush lock . This behavior is very similar to that of inodes . .
*/
STATIC void
xfs_qm_dqflush_done (
struct xfs_buf * bp ,
struct xfs_log_item * lip )
{
xfs_dq_logitem_t * qip = ( struct xfs_dq_logitem * ) lip ;
xfs_dquot_t * dqp = qip - > qli_dquot ;
struct xfs_ail * ailp = lip - > li_ailp ;
/*
* We only want to pull the item from the AIL if its
* location in the log has not changed since we started the flush .
* Thus , we only bother if the dquot ' s lsn has
* not changed . First we check the lsn outside the lock
* since it ' s cheaper , and then we recheck while
* holding the lock before removing the dquot from the AIL .
*/
if ( ( lip - > li_flags & XFS_LI_IN_AIL ) & &
lip - > li_lsn = = qip - > qli_flush_lsn ) {
/* xfs_trans_ail_delete() drops the AIL lock. */
spin_lock ( & ailp - > xa_lock ) ;
if ( lip - > li_lsn = = qip - > qli_flush_lsn )
2012-04-23 09:58:41 +04:00
xfs_trans_ail_delete ( ailp , lip , SHUTDOWN_CORRUPT_INCORE ) ;
2010-06-23 12:11:15 +04:00
else
spin_unlock ( & ailp - > xa_lock ) ;
}
/*
* Release the dq ' s flush lock since we ' re done with it .
*/
xfs_dqfunlock ( dqp ) ;
}
2005-04-17 02:20:36 +04:00
/*
* Write a modified dquot to disk .
* The dquot must be locked and the flush lock too taken by caller .
* The flush lock will not be unlocked until the dquot reaches the disk ,
* but the dquot is free to be unlocked and modified by the caller
* in the interim . Dquot is still locked on return . This behavior is
* identical to that of inodes .
*/
int
xfs_qm_dqflush (
2012-04-23 09:58:37 +04:00
struct xfs_dquot * dqp ,
struct xfs_buf * * bpp )
2005-04-17 02:20:36 +04:00
{
2010-09-06 05:44:45 +04:00
struct xfs_mount * mp = dqp - > q_mount ;
struct xfs_buf * bp ;
struct xfs_disk_dquot * ddqp ;
2005-04-17 02:20:36 +04:00
int error ;
ASSERT ( XFS_DQ_IS_LOCKED ( dqp ) ) ;
2008-08-13 10:41:43 +04:00
ASSERT ( ! completion_done ( & dqp - > q_flush ) ) ;
2010-09-06 05:44:45 +04:00
2009-12-15 02:14:59 +03:00
trace_xfs_dqflush ( dqp ) ;
2005-04-17 02:20:36 +04:00
2012-04-23 09:58:37 +04:00
* bpp = NULL ;
2005-04-17 02:20:36 +04:00
xfs_qm_dqunpin_wait ( dqp ) ;
/*
* This may have been unpinned because the filesystem is shutting
* down forcibly . If that ' s the case we must not write this dquot
2012-04-23 09:58:31 +04:00
* to disk , because the log record didn ' t make it to disk .
*
* We also have to remove the log item from the AIL in this case ,
* as we wait for an emptry AIL as part of the unmount process .
2005-04-17 02:20:36 +04:00
*/
2010-09-06 05:44:45 +04:00
if ( XFS_FORCED_SHUTDOWN ( mp ) ) {
2012-04-23 09:58:31 +04:00
struct xfs_log_item * lip = & dqp - > q_logitem . qli_item ;
2010-09-06 05:44:45 +04:00
dqp - > dq_flags & = ~ XFS_DQ_DIRTY ;
2012-04-23 09:58:31 +04:00
2015-08-19 03:01:08 +03:00
xfs_trans_ail_remove ( lip , SHUTDOWN_CORRUPT_INCORE ) ;
2014-06-25 08:58:08 +04:00
error = - EIO ;
2012-04-23 09:58:37 +04:00
goto out_unlock ;
2005-04-17 02:20:36 +04:00
}
/*
* Get the buffer containing the on - disk dquot
*/
2010-09-06 05:44:45 +04:00
error = xfs_trans_read_buf ( mp , NULL , mp - > m_ddev_targp , dqp - > q_blkno ,
2014-08-04 06:43:26 +04:00
mp - > m_quotainfo - > qi_dqchunklen , 0 , & bp ,
& xfs_dquot_buf_ops ) ;
2012-04-23 09:58:37 +04:00
if ( error )
goto out_unlock ;
2005-04-17 02:20:36 +04:00
2010-09-06 05:44:45 +04:00
/*
* Calculate the location of the dquot inside the buffer .
*/
2011-07-23 03:40:15 +04:00
ddqp = bp - > b_addr + dqp - > q_bufoffset ;
2010-09-06 05:44:45 +04:00
/*
* A simple sanity check in case we got a corrupted dquot . .
*/
2013-10-15 02:17:52 +04:00
error = xfs_dqcheck ( mp , & dqp - > q_core , be32_to_cpu ( ddqp - > d_id ) , 0 ,
2011-03-07 02:01:35 +03:00
XFS_QMOPT_DOWARN , " dqflush (incore copy) " ) ;
if ( error ) {
2010-09-06 05:44:45 +04:00
xfs_buf_relse ( bp ) ;
xfs_dqfunlock ( dqp ) ;
xfs_force_shutdown ( mp , SHUTDOWN_CORRUPT_INCORE ) ;
2014-06-25 08:58:08 +04:00
return - EIO ;
2005-04-17 02:20:36 +04:00
}
/* This is the only portion of data that needs to persist */
2010-09-06 05:44:45 +04:00
memcpy ( ddqp , & dqp - > q_core , sizeof ( xfs_disk_dquot_t ) ) ;
2005-04-17 02:20:36 +04:00
/*
* Clear the dirty field and remember the flush lsn for later use .
*/
2010-09-06 05:44:45 +04:00
dqp - > dq_flags & = ~ XFS_DQ_DIRTY ;
2005-04-17 02:20:36 +04:00
2008-10-30 09:39:12 +03:00
xfs_trans_ail_copy_lsn ( mp - > m_ail , & dqp - > q_logitem . qli_flush_lsn ,
& dqp - > q_logitem . qli_item . li_lsn ) ;
2005-04-17 02:20:36 +04:00
2013-04-03 09:11:16 +04:00
/*
* copy the lsn into the on - disk dquot now while we have the in memory
* dquot here . This can ' t be done later in the write verifier as we
* can ' t get access to the log item at that point in time .
xfs: rework dquot CRCs
Calculating dquot CRCs when the backing buffer is written back just
doesn't work reliably. There are several places which manipulate
dquots directly in the buffers, and they don't calculate CRCs
appropriately, nor do they always set the buffer up to calculate
CRCs appropriately.
Firstly, if we log a dquot buffer (e.g. during allocation) it gets
logged without valid CRC, and so on recovery we end up with a dquot
that is not valid.
Secondly, if we recover/repair a dquot, we don't have a verifier
attached to the buffer and hence CRCs are not calculated on the way
down to disk.
Thirdly, calculating the CRC after we've changed the contents means
that if we re-read the dquot from the buffer, we cannot verify the
contents of the dquot are valid, as the CRC is invalid.
So, to avoid all the dquot CRC errors that are being detected by the
read verifier, change to using the same model as for inodes. That
is, dquot CRCs are calculated and written to the backing buffer at
the time the dquot is flushed to the backing buffer. If we modify
the dquot directly in the backing buffer, calculate the CRC
immediately after the modification is complete. Hence the dquot in
the on-disk buffer should always have a valid CRC.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-06-03 09:28:46 +04:00
*
* We also calculate the CRC here so that the on - disk dquot in the
* buffer always has a valid CRC . This ensures there is no possibility
* of a dquot without an up - to - date CRC getting to disk .
2013-04-03 09:11:16 +04:00
*/
if ( xfs_sb_version_hascrc ( & mp - > m_sb ) ) {
struct xfs_dqblk * dqb = ( struct xfs_dqblk * ) ddqp ;
dqb - > dd_lsn = cpu_to_be64 ( dqp - > q_logitem . qli_item . li_lsn ) ;
xfs: rework dquot CRCs
Calculating dquot CRCs when the backing buffer is written back just
doesn't work reliably. There are several places which manipulate
dquots directly in the buffers, and they don't calculate CRCs
appropriately, nor do they always set the buffer up to calculate
CRCs appropriately.
Firstly, if we log a dquot buffer (e.g. during allocation) it gets
logged without valid CRC, and so on recovery we end up with a dquot
that is not valid.
Secondly, if we recover/repair a dquot, we don't have a verifier
attached to the buffer and hence CRCs are not calculated on the way
down to disk.
Thirdly, calculating the CRC after we've changed the contents means
that if we re-read the dquot from the buffer, we cannot verify the
contents of the dquot are valid, as the CRC is invalid.
So, to avoid all the dquot CRC errors that are being detected by the
read verifier, change to using the same model as for inodes. That
is, dquot CRCs are calculated and written to the backing buffer at
the time the dquot is flushed to the backing buffer. If we modify
the dquot directly in the backing buffer, calculate the CRC
immediately after the modification is complete. Hence the dquot in
the on-disk buffer should always have a valid CRC.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-06-03 09:28:46 +04:00
xfs_update_cksum ( ( char * ) dqb , sizeof ( struct xfs_dqblk ) ,
XFS_DQUOT_CRC_OFF ) ;
2013-04-03 09:11:16 +04:00
}
2005-04-17 02:20:36 +04:00
/*
* Attach an iodone routine so that we can remove this dquot from the
* AIL and release the flush lock once the dquot is synced to disk .
*/
2010-06-23 12:11:15 +04:00
xfs_buf_attach_iodone ( bp , xfs_qm_dqflush_done ,
& dqp - > q_logitem . qli_item ) ;
2005-04-17 02:20:36 +04:00
/*
* If the buffer is pinned then push on the log so we won ' t
* get stuck waiting in the write for too long .
*/
2011-07-23 03:40:27 +04:00
if ( xfs_buf_ispinned ( bp ) ) {
2009-12-15 02:14:59 +03:00
trace_xfs_dqflush_force ( dqp ) ;
2010-01-19 12:56:46 +03:00
xfs_log_force ( mp , 0 ) ;
2005-04-17 02:20:36 +04:00
}
2009-12-15 02:14:59 +03:00
trace_xfs_dqflush_done ( dqp ) ;
2012-04-23 09:58:37 +04:00
* bpp = bp ;
return 0 ;
2009-12-15 02:14:59 +03:00
2012-04-23 09:58:37 +04:00
out_unlock :
xfs_dqfunlock ( dqp ) ;
2014-06-25 08:58:08 +04:00
return - EIO ;
2005-04-17 02:20:36 +04:00
}
2009-01-19 04:03:19 +03:00
/*
* Lock two xfs_dquot structures .
*
* To avoid deadlocks we always lock the quota structure with
* the lowerd id first .
*/
2005-04-17 02:20:36 +04:00
void
xfs_dqlock2 (
xfs_dquot_t * d1 ,
xfs_dquot_t * d2 )
{
if ( d1 & & d2 ) {
ASSERT ( d1 ! = d2 ) ;
2005-11-02 07:01:12 +03:00
if ( be32_to_cpu ( d1 - > q_core . d_id ) >
be32_to_cpu ( d2 - > q_core . d_id ) ) {
2009-01-19 04:03:19 +03:00
mutex_lock ( & d2 - > q_qlock ) ;
mutex_lock_nested ( & d1 - > q_qlock , XFS_QLOCK_NESTED ) ;
2005-04-17 02:20:36 +04:00
} else {
2009-01-19 04:03:19 +03:00
mutex_lock ( & d1 - > q_qlock ) ;
mutex_lock_nested ( & d2 - > q_qlock , XFS_QLOCK_NESTED ) ;
2005-04-17 02:20:36 +04:00
}
2009-01-19 04:03:19 +03:00
} else if ( d1 ) {
mutex_lock ( & d1 - > q_qlock ) ;
} else if ( d2 ) {
mutex_lock ( & d2 - > q_qlock ) ;
2005-04-17 02:20:36 +04:00
}
}
2012-03-13 12:52:37 +04:00
int __init
xfs_qm_init ( void )
{
xfs_qm_dqzone =
kmem_zone_init ( sizeof ( struct xfs_dquot ) , " xfs_dquot " ) ;
if ( ! xfs_qm_dqzone )
goto out ;
xfs_qm_dqtrxzone =
kmem_zone_init ( sizeof ( struct xfs_dquot_acct ) , " xfs_dqtrx " ) ;
if ( ! xfs_qm_dqtrxzone )
goto out_free_dqzone ;
return 0 ;
out_free_dqzone :
kmem_zone_destroy ( xfs_qm_dqzone ) ;
out :
return - ENOMEM ;
}
2012-03-16 22:36:18 +04:00
void
2012-03-13 12:52:37 +04:00
xfs_qm_exit ( void )
{
kmem_zone_destroy ( xfs_qm_dqtrxzone ) ;
kmem_zone_destroy ( xfs_qm_dqzone ) ;
}