2006-02-01 14:06:42 +03:00
Reference-count design for elements of lists/arrays protected by RCU.
2005-09-10 00:04:09 +04:00
2006-02-01 14:06:42 +03:00
Reference counting on elements of lists which are protected by traditional
reader/writer spinlocks or semaphores are straightforward:
2005-09-10 00:04:09 +04:00
2006-01-08 12:02:19 +03:00
1. 2.
add() search_and_reference()
{ {
alloc_object read_lock(&list_lock);
... search_for_element
atomic_set(&el->rc, 1); atomic_inc(&el->rc);
write_lock(&list_lock); ...
add_element read_unlock(&list_lock);
... ...
write_unlock(&list_lock); }
2005-09-10 00:04:09 +04:00
}
3. 4.
release_referenced() delete()
{ {
2006-01-08 12:02:19 +03:00
... write_lock(&list_lock);
atomic_dec(&el->rc, relfunc) ...
... delete_element
} write_unlock(&list_lock);
...
if (atomic_dec_and_test(&el->rc))
kfree(el);
...
2005-09-10 00:04:09 +04:00
}
2006-02-01 14:06:42 +03:00
If this list/array is made lock free using RCU as in changing the
2008-09-10 07:01:07 +04:00
write_lock() in add() and delete() to spin_lock() and changing read_lock()
in search_and_reference() to rcu_read_lock(), the atomic_inc() in
search_and_reference() could potentially hold reference to an element which
2006-02-01 14:06:42 +03:00
has already been deleted from the list/array. Use atomic_inc_not_zero()
in this scenario as follows:
2005-09-10 00:04:09 +04:00
1. 2.
add() search_and_reference()
{ {
2006-01-08 12:02:19 +03:00
alloc_object rcu_read_lock();
... search_for_element
2008-09-10 07:01:07 +04:00
atomic_set(&el->rc, 1); if (!atomic_inc_not_zero(&el->rc)) {
spin_lock(&list_lock); rcu_read_unlock();
2006-01-08 12:02:19 +03:00
return FAIL;
add_element }
... ...
2008-09-10 07:01:07 +04:00
spin_unlock(&list_lock); rcu_read_unlock();
2005-09-10 00:04:09 +04:00
} }
3. 4.
release_referenced() delete()
{ {
2008-09-10 07:01:07 +04:00
... spin_lock(&list_lock);
2006-02-01 14:06:42 +03:00
if (atomic_dec_and_test(&el->rc)) ...
call_rcu(&el->head, el_free); delete_element
2008-09-10 07:01:07 +04:00
... spin_unlock(&list_lock);
2006-02-01 14:06:42 +03:00
} ...
2006-01-08 12:02:19 +03:00
if (atomic_dec_and_test(&el->rc))
call_rcu(&el->head, el_free);
...
2005-09-10 00:04:09 +04:00
}
2006-02-01 14:06:42 +03:00
Sometimes, a reference to the element needs to be obtained in the
update (write) stream. In such cases, atomic_inc_not_zero() might be
overkill, since we hold the update-side spinlock. One might instead
use atomic_inc() in such cases.