2014-12-23 10:41:52 -08:00
/*
* Copyright © 2014 Intel Corporation
*
* Permission is hereby granted , free of charge , to any person obtaining a
* copy of this software and associated documentation files ( the " Software " ) ,
* to deal in the Software without restriction , including without limitation
* the rights to use , copy , modify , merge , publish , distribute , sublicense ,
* and / or sell copies of the Software , and to permit persons to whom the
* Software is furnished to do so , subject to the following conditions :
*
* The above copyright notice and this permission notice ( including the next
* paragraph ) shall be included in all copies or substantial portions of the
* Software .
*
* THE SOFTWARE IS PROVIDED " AS IS " , WITHOUT WARRANTY OF ANY KIND , EXPRESS OR
* IMPLIED , INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY ,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT . IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM , DAMAGES OR OTHER
* LIABILITY , WHETHER IN AN ACTION OF CONTRACT , TORT OR OTHERWISE , ARISING
* FROM , OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE .
*/
/**
2015-01-13 08:55:00 -08:00
* DOC : atomic plane helpers
2014-12-23 10:41:52 -08:00
*
* The functions here are used by the atomic plane helper functions to
* implement legacy plane updates ( i . e . , drm_plane - > update_plane ( ) and
* drm_plane - > disable_plane ( ) ) . This allows plane updates to use the
* atomic state infrastructure and perform plane updates as separate
* prepare / check / commit / cleanup steps .
*/
# include <drm/drm_atomic_helper.h>
2019-01-26 13:25:24 +01:00
# include <drm/drm_fourcc.h>
2014-12-23 10:41:52 -08:00
# include <drm/drm_plane_helper.h>
2019-01-26 13:25:24 +01:00
2019-08-06 13:07:28 +03:00
# include "i915_trace.h"
2019-04-05 14:00:19 +03:00
# include "intel_atomic_plane.h"
2019-08-06 14:39:33 +03:00
# include "intel_display_types.h"
2019-04-05 14:00:15 +03:00
# include "intel_pm.h"
2019-04-05 14:00:24 +03:00
# include "intel_sprite.h"
2014-12-23 10:41:52 -08:00
2018-11-13 10:28:04 +01:00
struct intel_plane * intel_plane_alloc ( void )
2015-01-21 16:35:41 -08:00
{
2018-11-13 10:28:04 +01:00
struct intel_plane_state * plane_state ;
struct intel_plane * plane ;
2015-01-21 16:35:41 -08:00
2018-11-13 10:28:04 +01:00
plane = kzalloc ( sizeof ( * plane ) , GFP_KERNEL ) ;
if ( ! plane )
return ERR_PTR ( - ENOMEM ) ;
2015-01-21 16:35:41 -08:00
2018-11-13 10:28:04 +01:00
plane_state = kzalloc ( sizeof ( * plane_state ) , GFP_KERNEL ) ;
if ( ! plane_state ) {
kfree ( plane ) ;
return ERR_PTR ( - ENOMEM ) ;
}
2015-01-21 16:35:41 -08:00
2019-10-31 12:26:08 +01:00
__drm_atomic_helper_plane_reset ( & plane - > base , & plane_state - > uapi ) ;
2018-11-13 10:28:04 +01:00
plane_state - > scaler_id = - 1 ;
return plane ;
}
void intel_plane_free ( struct intel_plane * plane )
{
intel_plane_destroy_state ( & plane - > base , plane - > base . state ) ;
kfree ( plane ) ;
2015-01-21 16:35:41 -08:00
}
2014-12-23 10:41:52 -08:00
/**
* intel_plane_duplicate_state - duplicate plane state
* @ plane : drm plane
*
* Allocates and returns a copy of the plane state ( both common and
* Intel - specific ) for the specified plane .
*
2015-01-21 16:35:41 -08:00
* Returns : The newly allocated plane state , or NULL on failure .
2014-12-23 10:41:52 -08:00
*/
struct drm_plane_state *
intel_plane_duplicate_state ( struct drm_plane * plane )
{
2015-01-21 16:35:41 -08:00
struct intel_plane_state * intel_state ;
2014-12-23 10:41:52 -08:00
2019-10-31 12:26:05 +01:00
intel_state = to_intel_plane_state ( plane - > state ) ;
intel_state = kmemdup ( intel_state , sizeof ( * intel_state ) , GFP_KERNEL ) ;
2014-12-23 10:41:52 -08:00
2015-01-21 16:35:41 -08:00
if ( ! intel_state )
2014-12-23 10:41:52 -08:00
return NULL ;
2019-10-31 12:26:08 +01:00
__drm_atomic_helper_plane_duplicate_state ( plane , & intel_state - > uapi ) ;
2014-12-23 10:41:52 -08:00
2017-01-16 15:21:27 +00:00
intel_state - > vma = NULL ;
2018-02-20 13:42:06 +00:00
intel_state - > flags = 0 ;
2017-01-16 15:21:27 +00:00
2019-10-31 12:26:09 +01:00
/* add reference to fb */
if ( intel_state - > hw . fb )
drm_framebuffer_get ( intel_state - > hw . fb ) ;
2019-10-31 12:26:08 +01:00
return & intel_state - > uapi ;
2014-12-23 10:41:52 -08:00
}
/**
* intel_plane_destroy_state - destroy plane state
* @ plane : drm plane
2015-01-13 08:55:00 -08:00
* @ state : state object to destroy
2014-12-23 10:41:52 -08:00
*
* Destroys the plane state ( both common and Intel - specific ) for the
* specified plane .
*/
void
intel_plane_destroy_state ( struct drm_plane * plane ,
struct drm_plane_state * state )
{
2019-10-31 12:26:05 +01:00
struct intel_plane_state * plane_state = to_intel_plane_state ( state ) ;
WARN_ON ( plane_state - > vma ) ;
2017-01-16 15:21:27 +00:00
2019-10-31 12:26:08 +01:00
__drm_atomic_helper_plane_destroy_state ( & plane_state - > uapi ) ;
2019-10-31 12:26:09 +01:00
if ( plane_state - > hw . fb )
drm_framebuffer_put ( plane_state - > hw . fb ) ;
2019-10-31 12:26:05 +01:00
kfree ( plane_state ) ;
2014-12-23 10:41:52 -08:00
}
2019-05-24 18:36:14 +03:00
unsigned int intel_plane_data_rate ( const struct intel_crtc_state * crtc_state ,
const struct intel_plane_state * plane_state )
{
2019-10-31 12:26:07 +01:00
const struct drm_framebuffer * fb = plane_state - > hw . fb ;
2019-05-24 18:36:14 +03:00
unsigned int cpp ;
2019-10-31 12:26:08 +01:00
if ( ! plane_state - > uapi . visible )
2019-05-24 18:36:14 +03:00
return 0 ;
cpp = fb - > format - > cpp [ 0 ] ;
/*
* Based on HSD # : 1408715493
* NV12 cpp = = 4 , P010 cpp = = 8
*
* FIXME what is the logic behind this ?
*/
if ( fb - > format - > is_yuv & & fb - > format - > num_planes > 1 )
cpp * = 4 ;
return cpp * crtc_state - > pixel_rate ;
}
2019-10-15 22:30:26 +03:00
bool intel_plane_calc_min_cdclk ( struct intel_atomic_state * state ,
struct intel_plane * plane )
{
struct drm_i915_private * dev_priv = to_i915 ( plane - > base . dev ) ;
const struct intel_plane_state * plane_state =
intel_atomic_get_new_plane_state ( state , plane ) ;
2019-10-31 12:26:07 +01:00
struct intel_crtc * crtc = to_intel_crtc ( plane_state - > hw . crtc ) ;
2019-10-15 22:30:26 +03:00
struct intel_crtc_state * crtc_state ;
2019-10-31 12:26:08 +01:00
if ( ! plane_state - > uapi . visible | | ! plane - > min_cdclk )
2019-10-15 22:30:26 +03:00
return false ;
crtc_state = intel_atomic_get_new_crtc_state ( state , crtc ) ;
crtc_state - > min_cdclk [ plane - > id ] =
plane - > min_cdclk ( crtc_state , plane_state ) ;
/*
* Does the cdclk need to be bumbed up ?
*
* Note : we obviously need to be called before the new
* cdclk frequency is calculated so state - > cdclk . logical
* hasn ' t been populated yet . Hence we look at the old
* cdclk state under dev_priv - > cdclk . logical . This is
* safe as long we hold at least one crtc mutex ( which
* must be true since we have crtc_state ) .
*/
if ( crtc_state - > min_cdclk [ plane - > id ] > dev_priv - > cdclk . logical . cdclk ) {
DRM_DEBUG_KMS ( " [PLANE:%d:%s] min_cdclk (%d kHz) > logical cdclk (%d kHz) \n " ,
plane - > base . base . id , plane - > base . name ,
crtc_state - > min_cdclk [ plane - > id ] ,
dev_priv - > cdclk . logical . cdclk ) ;
return true ;
}
return false ;
}
2019-10-31 12:26:09 +01:00
static void intel_plane_clear_hw_state ( struct intel_plane_state * plane_state )
{
if ( plane_state - > hw . fb )
drm_framebuffer_put ( plane_state - > hw . fb ) ;
memset ( & plane_state - > hw , 0 , sizeof ( plane_state - > hw ) ) ;
}
void intel_plane_copy_uapi_to_hw_state ( struct intel_plane_state * plane_state ,
const struct intel_plane_state * from_plane_state )
{
intel_plane_clear_hw_state ( plane_state ) ;
plane_state - > hw . crtc = from_plane_state - > uapi . crtc ;
plane_state - > hw . fb = from_plane_state - > uapi . fb ;
if ( plane_state - > hw . fb )
drm_framebuffer_get ( plane_state - > hw . fb ) ;
plane_state - > hw . alpha = from_plane_state - > uapi . alpha ;
plane_state - > hw . pixel_blend_mode =
from_plane_state - > uapi . pixel_blend_mode ;
plane_state - > hw . rotation = from_plane_state - > uapi . rotation ;
plane_state - > hw . color_encoding = from_plane_state - > uapi . color_encoding ;
plane_state - > hw . color_range = from_plane_state - > uapi . color_range ;
}
2017-08-23 18:22:23 +03:00
int intel_plane_atomic_check_with_state ( const struct intel_crtc_state * old_crtc_state ,
2019-01-11 19:08:11 +02:00
struct intel_crtc_state * new_crtc_state ,
2017-08-23 18:22:23 +03:00
const struct intel_plane_state * old_plane_state ,
2019-01-11 19:08:11 +02:00
struct intel_plane_state * new_plane_state )
2014-12-23 10:41:52 -08:00
{
2019-10-31 12:26:08 +01:00
struct intel_plane * plane = to_intel_plane ( new_plane_state - > uapi . plane ) ;
2019-10-31 12:26:09 +01:00
const struct drm_framebuffer * fb ;
2015-06-15 12:33:44 +02:00
int ret ;
2014-12-23 10:41:52 -08:00
2019-10-31 12:26:09 +01:00
intel_plane_copy_uapi_to_hw_state ( new_plane_state , new_plane_state ) ;
fb = new_plane_state - > hw . fb ;
2019-01-11 19:08:11 +02:00
new_crtc_state - > active_planes & = ~ BIT ( plane - > id ) ;
new_crtc_state - > nv12_planes & = ~ BIT ( plane - > id ) ;
2019-02-07 22:21:45 +02:00
new_crtc_state - > c8_planes & = ~ BIT ( plane - > id ) ;
2019-05-24 18:36:14 +03:00
new_crtc_state - > data_rate [ plane - > id ] = 0 ;
2019-10-15 22:30:26 +03:00
new_crtc_state - > min_cdclk [ plane - > id ] = 0 ;
2019-10-31 12:26:08 +01:00
new_plane_state - > uapi . visible = false ;
2018-09-20 12:27:06 +02:00
2019-10-31 12:26:07 +01:00
if ( ! new_plane_state - > hw . crtc & & ! old_plane_state - > hw . crtc )
2015-01-21 16:35:48 -08:00
return 0 ;
2019-01-11 19:08:11 +02:00
ret = plane - > check_plane ( new_crtc_state , new_plane_state ) ;
2015-06-15 12:33:55 +02:00
if ( ret )
2015-06-15 12:33:44 +02:00
return ret ;
2017-03-02 19:14:51 +02:00
/* FIXME pre-g4x don't work like this */
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible )
2019-01-11 19:08:11 +02:00
new_crtc_state - > active_planes | = BIT ( plane - > id ) ;
2017-03-02 19:14:51 +02:00
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible & &
2019-09-13 22:31:54 +03:00
drm_format_info_is_yuv_semiplanar ( fb - > format ) )
2019-01-11 19:08:11 +02:00
new_crtc_state - > nv12_planes | = BIT ( plane - > id ) ;
2018-05-12 03:03:12 +05:30
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible & &
2019-09-13 22:31:54 +03:00
fb - > format - > format = = DRM_FORMAT_C8 )
2019-02-07 22:21:45 +02:00
new_crtc_state - > c8_planes | = BIT ( plane - > id ) ;
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible | | old_plane_state - > uapi . visible )
2019-01-11 19:08:11 +02:00
new_crtc_state - > update_planes | = BIT ( plane - > id ) ;
2018-11-27 18:37:42 +02:00
2019-05-24 18:36:14 +03:00
new_crtc_state - > data_rate [ plane - > id ] =
intel_plane_data_rate ( new_crtc_state , new_plane_state ) ;
2019-06-28 10:55:16 +02:00
return intel_plane_atomic_calc_changes ( old_crtc_state , new_crtc_state ,
old_plane_state , new_plane_state ) ;
2014-12-23 10:41:52 -08:00
}
2019-06-28 10:55:16 +02:00
static struct intel_crtc *
get_crtc_from_states ( const struct intel_plane_state * old_plane_state ,
const struct intel_plane_state * new_plane_state )
2016-12-12 11:34:55 +01:00
{
2019-10-31 12:26:06 +01:00
if ( new_plane_state - > uapi . crtc )
return to_intel_crtc ( new_plane_state - > uapi . crtc ) ;
2019-06-28 10:55:16 +02:00
2019-10-31 12:26:06 +01:00
if ( old_plane_state - > uapi . crtc )
return to_intel_crtc ( old_plane_state - > uapi . crtc ) ;
2019-06-28 10:55:16 +02:00
return NULL ;
}
2019-07-08 15:53:14 +03:00
int intel_plane_atomic_check ( struct intel_atomic_state * state ,
struct intel_plane * plane )
2019-06-28 10:55:16 +02:00
{
struct intel_plane_state * new_plane_state =
2019-07-08 15:53:14 +03:00
intel_atomic_get_new_plane_state ( state , plane ) ;
2019-06-28 10:55:16 +02:00
const struct intel_plane_state * old_plane_state =
intel_atomic_get_old_plane_state ( state , plane ) ;
struct intel_crtc * crtc =
get_crtc_from_states ( old_plane_state , new_plane_state ) ;
const struct intel_crtc_state * old_crtc_state ;
struct intel_crtc_state * new_crtc_state ;
2019-10-31 12:26:08 +01:00
new_plane_state - > uapi . visible = false ;
2016-12-12 11:34:55 +01:00
if ( ! crtc )
return 0 ;
2019-06-28 10:55:16 +02:00
old_crtc_state = intel_atomic_get_old_crtc_state ( state , crtc ) ;
new_crtc_state = intel_atomic_get_new_crtc_state ( state , crtc ) ;
2016-12-12 11:34:55 +01:00
2019-06-28 10:55:16 +02:00
return intel_plane_atomic_check_with_state ( old_crtc_state ,
new_crtc_state ,
old_plane_state ,
new_plane_state ) ;
2016-12-12 11:34:55 +01:00
}
2018-11-14 23:07:27 +02:00
static struct intel_plane *
skl_next_plane_to_commit ( struct intel_atomic_state * state ,
struct intel_crtc * crtc ,
struct skl_ddb_entry entries_y [ I915_MAX_PLANES ] ,
struct skl_ddb_entry entries_uv [ I915_MAX_PLANES ] ,
unsigned int * update_mask )
2014-12-23 10:41:52 -08:00
{
2018-11-14 23:07:27 +02:00
struct intel_crtc_state * crtc_state =
intel_atomic_get_new_crtc_state ( state , crtc ) ;
struct intel_plane_state * plane_state ;
2018-09-20 12:27:08 +02:00
struct intel_plane * plane ;
int i ;
2018-11-14 23:07:27 +02:00
if ( * update_mask = = 0 )
return NULL ;
for_each_new_intel_plane_in_state ( state , plane , plane_state , i ) {
enum plane_id plane_id = plane - > id ;
2018-09-20 12:27:08 +02:00
if ( crtc - > pipe ! = plane - > pipe | |
2018-11-14 23:07:27 +02:00
! ( * update_mask & BIT ( plane_id ) ) )
continue ;
if ( skl_ddb_allocation_overlaps ( & crtc_state - > wm . skl . plane_ddb_y [ plane_id ] ,
entries_y ,
I915_MAX_PLANES , plane_id ) | |
skl_ddb_allocation_overlaps ( & crtc_state - > wm . skl . plane_ddb_uv [ plane_id ] ,
entries_uv ,
I915_MAX_PLANES , plane_id ) )
2018-09-20 12:27:08 +02:00
continue ;
2016-01-07 11:54:07 +01:00
2018-11-14 23:07:27 +02:00
* update_mask & = ~ BIT ( plane_id ) ;
entries_y [ plane_id ] = crtc_state - > wm . skl . plane_ddb_y [ plane_id ] ;
entries_uv [ plane_id ] = crtc_state - > wm . skl . plane_ddb_uv [ plane_id ] ;
return plane ;
}
/* should never happen */
WARN_ON ( 1 ) ;
return NULL ;
}
2019-02-06 22:49:10 +02:00
void intel_update_plane ( struct intel_plane * plane ,
const struct intel_crtc_state * crtc_state ,
const struct intel_plane_state * plane_state )
{
2019-10-31 12:26:03 +01:00
struct intel_crtc * crtc = to_intel_crtc ( crtc_state - > uapi . crtc ) ;
2019-02-06 22:49:10 +02:00
trace_intel_update_plane ( & plane - > base , crtc ) ;
plane - > update_plane ( plane , crtc_state , plane_state ) ;
}
void intel_update_slave ( struct intel_plane * plane ,
const struct intel_crtc_state * crtc_state ,
const struct intel_plane_state * plane_state )
{
2019-10-31 12:26:03 +01:00
struct intel_crtc * crtc = to_intel_crtc ( crtc_state - > uapi . crtc ) ;
2019-02-06 22:49:10 +02:00
trace_intel_update_plane ( & plane - > base , crtc ) ;
plane - > update_slave ( plane , crtc_state , plane_state ) ;
}
void intel_disable_plane ( struct intel_plane * plane ,
const struct intel_crtc_state * crtc_state )
{
2019-10-31 12:26:03 +01:00
struct intel_crtc * crtc = to_intel_crtc ( crtc_state - > uapi . crtc ) ;
2019-02-06 22:49:10 +02:00
trace_intel_disable_plane ( & plane - > base , crtc ) ;
plane - > disable_plane ( plane , crtc_state ) ;
}
2018-11-14 23:07:27 +02:00
void skl_update_planes_on_crtc ( struct intel_atomic_state * state ,
struct intel_crtc * crtc )
{
struct intel_crtc_state * old_crtc_state =
intel_atomic_get_old_crtc_state ( state , crtc ) ;
struct intel_crtc_state * new_crtc_state =
intel_atomic_get_new_crtc_state ( state , crtc ) ;
struct skl_ddb_entry entries_y [ I915_MAX_PLANES ] ;
struct skl_ddb_entry entries_uv [ I915_MAX_PLANES ] ;
u32 update_mask = new_crtc_state - > update_planes ;
struct intel_plane * plane ;
memcpy ( entries_y , old_crtc_state - > wm . skl . plane_ddb_y ,
sizeof ( old_crtc_state - > wm . skl . plane_ddb_y ) ) ;
memcpy ( entries_uv , old_crtc_state - > wm . skl . plane_ddb_uv ,
sizeof ( old_crtc_state - > wm . skl . plane_ddb_uv ) ) ;
while ( ( plane = skl_next_plane_to_commit ( state , crtc ,
entries_y , entries_uv ,
& update_mask ) ) ) {
struct intel_plane_state * new_plane_state =
intel_atomic_get_new_plane_state ( state , plane ) ;
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible ) {
2019-02-06 22:49:10 +02:00
intel_update_plane ( plane , new_crtc_state , new_plane_state ) ;
2019-09-20 13:42:20 +02:00
} else if ( new_plane_state - > planar_slave ) {
drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v5.
To make NV12 working on icl, we need to update 2 planes simultaneously.
I've chosen to do this in the CRTC step after plane validation is done,
so we know what planes are (in)visible. The linked Y plane will get
updated in intel_plane_update_planes_on_crtc(), by the call to
update_slave, which gets the master's plane_state as argument.
The link requires both planes for atomic_update to work,
so make sure skl_ddb_add_affected_planes() adds both states.
Changes since v1:
- Introduce icl_is_nv12_y_plane(), instead of hardcoding sprite numbers.
- Put all the state updating login in intel_plane_atomic_check_with_state().
- Clean up changes in intel_plane_atomic_check().
Changes since v2:
- Fix intel_atomic_get_old_plane_state() to actually return old state.
- Move visibility changes to preparation patch.
- Only try to find a Y plane on gen11, earlier platforms only require
a single plane.
Changes since v3:
- Fix checkpatch warning about to_intel_crtc() usage.
- Add affected planes from icl_add_linked_planes() before check_planes(),
it's a cleaner way to do this. (Ville)
Changes since v4:
- Clear plane links in icl_check_nv12_planes() for clarity.
- Only pass crtc_state to icl_check_nv12_planes().
- Use for_each_new_intel_plane_in_state() in icl_check_nv12_planes.
- Rename aux to linked. (Ville)
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181022135152.15324-1-maarten.lankhorst@linux.intel.com
[mlankhorst: Change bool slave to u32, to satisfy checkpatch]
[mlankhorst: Add WARN_ON's based on Ville's suggestion]
2018-10-22 15:51:52 +02:00
struct intel_plane * master =
2019-09-20 13:42:20 +02:00
new_plane_state - > planar_linked_plane ;
drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v5.
To make NV12 working on icl, we need to update 2 planes simultaneously.
I've chosen to do this in the CRTC step after plane validation is done,
so we know what planes are (in)visible. The linked Y plane will get
updated in intel_plane_update_planes_on_crtc(), by the call to
update_slave, which gets the master's plane_state as argument.
The link requires both planes for atomic_update to work,
so make sure skl_ddb_add_affected_planes() adds both states.
Changes since v1:
- Introduce icl_is_nv12_y_plane(), instead of hardcoding sprite numbers.
- Put all the state updating login in intel_plane_atomic_check_with_state().
- Clean up changes in intel_plane_atomic_check().
Changes since v2:
- Fix intel_atomic_get_old_plane_state() to actually return old state.
- Move visibility changes to preparation patch.
- Only try to find a Y plane on gen11, earlier platforms only require
a single plane.
Changes since v3:
- Fix checkpatch warning about to_intel_crtc() usage.
- Add affected planes from icl_add_linked_planes() before check_planes(),
it's a cleaner way to do this. (Ville)
Changes since v4:
- Clear plane links in icl_check_nv12_planes() for clarity.
- Only pass crtc_state to icl_check_nv12_planes().
- Use for_each_new_intel_plane_in_state() in icl_check_nv12_planes.
- Rename aux to linked. (Ville)
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181022135152.15324-1-maarten.lankhorst@linux.intel.com
[mlankhorst: Change bool slave to u32, to satisfy checkpatch]
[mlankhorst: Add WARN_ON's based on Ville's suggestion]
2018-10-22 15:51:52 +02:00
/*
* We update the slave plane from this function because
* programming it from the master plane ' s update_plane
* callback runs into issues when the Y plane is
* reassigned , disabled or used by a different plane .
*
* The slave plane is updated with the master plane ' s
* plane_state .
*/
new_plane_state =
2018-11-14 23:07:27 +02:00
intel_atomic_get_new_plane_state ( state , master ) ;
drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v5.
To make NV12 working on icl, we need to update 2 planes simultaneously.
I've chosen to do this in the CRTC step after plane validation is done,
so we know what planes are (in)visible. The linked Y plane will get
updated in intel_plane_update_planes_on_crtc(), by the call to
update_slave, which gets the master's plane_state as argument.
The link requires both planes for atomic_update to work,
so make sure skl_ddb_add_affected_planes() adds both states.
Changes since v1:
- Introduce icl_is_nv12_y_plane(), instead of hardcoding sprite numbers.
- Put all the state updating login in intel_plane_atomic_check_with_state().
- Clean up changes in intel_plane_atomic_check().
Changes since v2:
- Fix intel_atomic_get_old_plane_state() to actually return old state.
- Move visibility changes to preparation patch.
- Only try to find a Y plane on gen11, earlier platforms only require
a single plane.
Changes since v3:
- Fix checkpatch warning about to_intel_crtc() usage.
- Add affected planes from icl_add_linked_planes() before check_planes(),
it's a cleaner way to do this. (Ville)
Changes since v4:
- Clear plane links in icl_check_nv12_planes() for clarity.
- Only pass crtc_state to icl_check_nv12_planes().
- Use for_each_new_intel_plane_in_state() in icl_check_nv12_planes.
- Rename aux to linked. (Ville)
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181022135152.15324-1-maarten.lankhorst@linux.intel.com
[mlankhorst: Change bool slave to u32, to satisfy checkpatch]
[mlankhorst: Add WARN_ON's based on Ville's suggestion]
2018-10-22 15:51:52 +02:00
2019-02-06 22:49:10 +02:00
intel_update_slave ( plane , new_crtc_state , new_plane_state ) ;
2018-09-20 12:27:08 +02:00
} else {
2019-02-06 22:49:10 +02:00
intel_disable_plane ( plane , new_crtc_state ) ;
2018-11-14 23:07:27 +02:00
}
}
}
2017-03-02 19:15:05 +02:00
2018-11-14 23:07:27 +02:00
void i9xx_update_planes_on_crtc ( struct intel_atomic_state * state ,
struct intel_crtc * crtc )
{
struct intel_crtc_state * new_crtc_state =
intel_atomic_get_new_crtc_state ( state , crtc ) ;
u32 update_mask = new_crtc_state - > update_planes ;
struct intel_plane_state * new_plane_state ;
struct intel_plane * plane ;
int i ;
for_each_new_intel_plane_in_state ( state , plane , new_plane_state , i ) {
if ( crtc - > pipe ! = plane - > pipe | |
! ( update_mask & BIT ( plane - > id ) ) )
continue ;
2019-10-31 12:26:08 +01:00
if ( new_plane_state - > uapi . visible )
2019-02-06 22:49:10 +02:00
intel_update_plane ( plane , new_crtc_state , new_plane_state ) ;
else
intel_disable_plane ( plane , new_crtc_state ) ;
2017-03-02 19:15:05 +02:00
}
2014-12-23 10:41:52 -08:00
}
const struct drm_plane_helper_funcs intel_plane_helper_funcs = {
. prepare_fb = intel_prepare_plane_fb ,
. cleanup_fb = intel_cleanup_plane_fb ,
} ;