2010-08-24 19:38:58 +04:00
/// Find functions that refer to GFP_KERNEL but are called with locks held.
2012-01-15 02:41:54 +04:00
//# The proposed change of converting the GFP_KERNEL is not necessarily the
//# correct one. It may be desired to unlock the lock, or to not call the
//# function under the lock in the first place.
2010-08-24 19:38:58 +04:00
///
// Confidence: Moderate
2012-01-15 02:41:54 +04:00
// Copyright: (C) 2012 Nicolas Palix. GPLv2.
// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2.
// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2.
2010-08-24 19:38:58 +04:00
// URL: http://coccinelle.lip6.fr/
// Comments:
2013-06-20 15:10:56 +04:00
// Options: --no-includes --include-headers
2010-08-24 19:38:58 +04:00
virtual patch
2012-01-15 02:41:54 +04:00
virtual context
virtual org
virtual report
2010-08-24 19:38:58 +04:00
@gfp exists@
identifier fn;
position p;
@@
fn(...) {
... when != read_unlock_irq(...)
when != write_unlock_irq(...)
when != read_unlock_irqrestore(...)
when != write_unlock_irqrestore(...)
when != spin_unlock(...)
when != spin_unlock_irq(...)
when != spin_unlock_irqrestore(...)
when != local_irq_enable(...)
when any
GFP_KERNEL@p
... when any
}
2012-01-15 02:41:54 +04:00
@locked exists@
2010-08-24 19:38:58 +04:00
identifier gfp.fn;
2012-01-15 02:41:54 +04:00
position p1,p2;
2010-08-24 19:38:58 +04:00
@@
(
2012-01-15 02:41:54 +04:00
read_lock_irq@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
write_lock_irq@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
read_lock_irqsave@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
write_lock_irqsave@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
spin_lock@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
spin_trylock@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
spin_lock_irq@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
spin_lock_irqsave@p1
2010-08-24 19:38:58 +04:00
|
2012-01-15 02:41:54 +04:00
local_irq_disable@p1
2010-08-24 19:38:58 +04:00
)
(...)
... when != read_unlock_irq(...)
when != write_unlock_irq(...)
when != read_unlock_irqrestore(...)
when != write_unlock_irqrestore(...)
when != spin_unlock(...)
when != spin_unlock_irq(...)
when != spin_unlock_irqrestore(...)
when != local_irq_enable(...)
2012-01-15 02:41:54 +04:00
fn@p2(...)
2010-08-24 19:38:58 +04:00
2012-01-15 02:41:54 +04:00
@depends on locked && patch@
2010-08-24 19:38:58 +04:00
position gfp.p;
@@
- GFP_KERNEL@p
+ GFP_ATOMIC
2012-01-15 02:41:54 +04:00
@depends on locked && !patch@
position gfp.p;
@@
* GFP_KERNEL@p
@script:python depends on !patch && org@
p << gfp.p;
fn << gfp.fn;
p1 << locked.p1;
p2 << locked.p2;
@@
cocci.print_main("lock",p1)
cocci.print_secs("call",p2)
cocci.print_secs("GFP_KERNEL",p)
@script:python depends on !patch && report@
p << gfp.p;
fn << gfp.fn;
p1 << locked.p1;
p2 << locked.p2;
@@
msg = "ERROR: function %s called on line %s inside lock on line %s but uses GFP_KERNEL" % (fn,p2[0].line,p1[0].line)
coccilib.report.print_report(p[0], msg)