2019-05-19 15:08:20 +03:00
// SPDX-License-Identifier: GPL-2.0-only
2007-09-06 20:34:25 +04:00
/*
* Common code for control of lockd and nfsv4 grace periods .
2014-09-13 00:40:20 +04:00
*
* Transplanted from lockd code
2007-09-06 20:34:25 +04:00
*/
# include <linux/module.h>
2012-07-25 16:57:13 +04:00
# include <net/net_namespace.h>
2014-09-13 00:40:20 +04:00
# include <net/netns/generic.h>
# include <linux/fs.h>
2012-07-25 16:57:13 +04:00
netns: make struct pernet_operations::id unsigned int
Make struct pernet_operations::id unsigned.
There are 2 reasons to do so:
1)
This field is really an index into an zero based array and
thus is unsigned entity. Using negative value is out-of-bound
access by definition.
2)
On x86_64 unsigned 32-bit data which are mixed with pointers
via array indexing or offsets added or subtracted to pointers
are preffered to signed 32-bit data.
"int" being used as an array index needs to be sign-extended
to 64-bit before being used.
void f(long *p, int i)
{
g(p[i]);
}
roughly translates to
movsx rsi, esi
mov rdi, [rsi+...]
call g
MOVSX is 3 byte instruction which isn't necessary if the variable is
unsigned because x86_64 is zero extending by default.
Now, there is net_generic() function which, you guessed it right, uses
"int" as an array index:
static inline void *net_generic(const struct net *net, int id)
{
...
ptr = ng->ptr[id - 1];
...
}
And this function is used a lot, so those sign extensions add up.
Patch snipes ~1730 bytes on allyesconfig kernel (without all junk
messing with code generation):
add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
Unfortunately some functions actually grow bigger.
This is a semmingly random artefact of code generation with register
allocator being used differently. gcc decides that some variable
needs to live in new r8+ registers and every access now requires REX
prefix. Or it is shifted into r12, so [r12+0] addressing mode has to be
used which is longer than [r8]
However, overall balance is in negative direction:
add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
function old new delta
nfsd4_lock 3886 3959 +73
tipc_link_build_proto_msg 1096 1140 +44
mac80211_hwsim_new_radio 2776 2808 +32
tipc_mon_rcv 1032 1058 +26
svcauth_gss_legacy_init 1413 1429 +16
tipc_bcbase_select_primary 379 392 +13
nfsd4_exchange_id 1247 1260 +13
nfsd4_setclientid_confirm 782 793 +11
...
put_client_renew_locked 494 480 -14
ip_set_sockfn_get 730 716 -14
geneve_sock_add 829 813 -16
nfsd4_sequence_done 721 703 -18
nlmclnt_lookup_host 708 686 -22
nfsd4_lockt 1085 1063 -22
nfs_get_client 1077 1050 -27
tcf_bpf_init 1106 1076 -30
nfsd4_encode_fattr 5997 5930 -67
Total: Before=154856051, After=154854321, chg -0.00%
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-11-17 04:58:21 +03:00
static unsigned int grace_net_id ;
2007-09-06 20:34:25 +04:00
static DEFINE_SPINLOCK ( grace_lock ) ;
/**
* locks_start_grace
2014-09-13 00:40:20 +04:00
* @ net : net namespace that this lock manager belongs to
2007-09-06 20:34:25 +04:00
* @ lm : who this grace period is for
*
* A grace period is a period during which locks should not be given
* out . Currently grace periods are only enforced by the two lock
* managers ( lockd and nfsd ) , using the locks_in_grace ( ) function to
* check when they are in a grace period .
*
* This function is called to start a grace period .
*/
2014-09-13 00:40:20 +04:00
void
locks_start_grace ( struct net * net , struct lock_manager * lm )
2007-09-06 20:34:25 +04:00
{
2014-09-13 00:40:20 +04:00
struct list_head * grace_list = net_generic ( net , grace_net_id ) ;
2012-07-25 16:57:13 +04:00
2007-09-06 20:34:25 +04:00
spin_lock ( & grace_lock ) ;
2017-11-13 07:25:40 +03:00
if ( list_empty ( & lm - > list ) )
list_add ( & lm - > list , grace_list ) ;
else
WARN ( 1 , " double list_add attempt detected in net %x %s \n " ,
net - > ns . inum , ( net = = & init_net ) ? " (init_net) " : " " ) ;
2007-09-06 20:34:25 +04:00
spin_unlock ( & grace_lock ) ;
}
EXPORT_SYMBOL_GPL ( locks_start_grace ) ;
/**
* locks_end_grace
* @ lm : who this grace period is for
*
* Call this function to state that the given lock manager is ready to
* resume regular locking . The grace period will not end until all lock
* managers that called locks_start_grace ( ) also call locks_end_grace ( ) .
* Note that callers count on it being safe to call this more than once ,
* and the second call should be a no - op .
*/
2014-09-13 00:40:20 +04:00
void
locks_end_grace ( struct lock_manager * lm )
2007-09-06 20:34:25 +04:00
{
spin_lock ( & grace_lock ) ;
list_del_init ( & lm - > list ) ;
spin_unlock ( & grace_lock ) ;
}
EXPORT_SYMBOL_GPL ( locks_end_grace ) ;
2017-09-26 10:14:07 +03:00
static bool
2015-08-06 19:47:02 +03:00
__state_in_grace ( struct net * net , bool open )
2007-09-06 20:34:25 +04:00
{
2014-09-13 00:40:20 +04:00
struct list_head * grace_list = net_generic ( net , grace_net_id ) ;
2015-08-06 19:47:02 +03:00
struct lock_manager * lm ;
2012-07-25 16:57:13 +04:00
2015-08-06 19:47:02 +03:00
if ( ! open )
return ! list_empty ( grace_list ) ;
2020-12-01 15:06:35 +03:00
spin_lock ( & grace_lock ) ;
2015-08-06 19:47:02 +03:00
list_for_each_entry ( lm , grace_list , list ) {
2020-12-01 15:06:35 +03:00
if ( lm - > block_opens ) {
spin_unlock ( & grace_lock ) ;
2015-08-06 19:47:02 +03:00
return true ;
2020-12-01 15:06:35 +03:00
}
2015-08-06 19:47:02 +03:00
}
2020-12-01 15:06:35 +03:00
spin_unlock ( & grace_lock ) ;
2015-08-06 19:47:02 +03:00
return false ;
}
2017-09-26 10:14:06 +03:00
/**
* locks_in_grace
2021-06-07 09:28:23 +03:00
* @ net : network namespace
2017-09-26 10:14:06 +03:00
*
* Lock managers call this function to determine when it is OK for them
* to answer ordinary lock requests , and when they should accept only
* lock reclaims .
*/
2017-09-26 10:14:07 +03:00
bool locks_in_grace ( struct net * net )
2015-08-06 19:47:02 +03:00
{
2017-09-26 10:14:07 +03:00
return __state_in_grace ( net , false ) ;
2007-09-06 20:34:25 +04:00
}
EXPORT_SYMBOL_GPL ( locks_in_grace ) ;
2014-09-13 00:40:20 +04:00
2017-09-26 10:14:07 +03:00
bool opens_in_grace ( struct net * net )
2015-08-06 19:47:02 +03:00
{
2017-09-26 10:14:07 +03:00
return __state_in_grace ( net , true ) ;
2015-08-06 19:47:02 +03:00
}
EXPORT_SYMBOL_GPL ( opens_in_grace ) ;
2014-09-13 00:40:20 +04:00
static int __net_init
grace_init_net ( struct net * net )
{
struct list_head * grace_list = net_generic ( net , grace_net_id ) ;
INIT_LIST_HEAD ( grace_list ) ;
return 0 ;
}
static void __net_exit
grace_exit_net ( struct net * net )
{
struct list_head * grace_list = net_generic ( net , grace_net_id ) ;
2017-11-06 16:22:48 +03:00
WARN_ONCE ( ! list_empty ( grace_list ) ,
" net %x %s: grace_list is not empty \n " ,
net - > ns . inum , __func__ ) ;
2014-09-13 00:40:20 +04:00
}
static struct pernet_operations grace_net_ops = {
. init = grace_init_net ,
. exit = grace_exit_net ,
. id = & grace_net_id ,
. size = sizeof ( struct list_head ) ,
} ;
static int __init
init_grace ( void )
{
return register_pernet_subsys ( & grace_net_ops ) ;
}
static void __exit
exit_grace ( void )
{
unregister_pernet_subsys ( & grace_net_ops ) ;
}
MODULE_AUTHOR ( " Jeff Layton <jlayton@primarydata.com> " ) ;
MODULE_LICENSE ( " GPL " ) ;
module_init ( init_grace )
module_exit ( exit_grace )