License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 17:07:57 +03:00
/* SPDX-License-Identifier: GPL-2.0 */
2009-08-21 16:28:31 +04:00
# ifndef _RDS_TCP_H
# define _RDS_TCP_H
# define RDS_TCP_PORT 16385
struct rds_tcp_incoming {
struct rds_incoming ti_inc ;
struct sk_buff_head ti_skb_list ;
} ;
struct rds_tcp_connection {
struct list_head t_tcp_node ;
2017-11-30 22:11:29 +03:00
bool t_tcp_node_detached ;
2016-07-01 02:11:12 +03:00
struct rds_conn_path * t_cpath ;
/* t_conn_path_lock synchronizes the connection establishment between
2016-07-01 02:11:16 +03:00
* rds_tcp_accept_one and rds_tcp_conn_path_connect
2016-05-02 21:24:52 +03:00
*/
2016-07-01 02:11:12 +03:00
struct mutex t_conn_path_lock ;
2009-08-21 16:28:31 +04:00
struct socket * t_sock ;
void * t_orig_write_space ;
void * t_orig_data_ready ;
void * t_orig_state_change ;
struct rds_tcp_incoming * t_tinc ;
size_t t_tinc_hdr_rem ;
size_t t_tinc_data_rem ;
/* XXX error report? */
struct work_struct t_conn_w ;
struct work_struct t_send_w ;
struct work_struct t_down_w ;
struct work_struct t_recv_w ;
/* for info exporting only */
struct list_head t_list_item ;
u32 t_last_sent_nxt ;
u32 t_last_expected_una ;
u32 t_last_seen_una ;
} ;
struct rds_tcp_statistics {
uint64_t s_tcp_data_ready_calls ;
uint64_t s_tcp_write_space_calls ;
uint64_t s_tcp_sndbuf_full ;
uint64_t s_tcp_connect_raced ;
uint64_t s_tcp_listen_closed_stale ;
} ;
/* tcp.c */
void rds_tcp_tune ( struct socket * sock ) ;
void rds_tcp_nonagle ( struct socket * sock ) ;
2016-07-01 02:11:14 +03:00
void rds_tcp_set_callbacks ( struct socket * sock , struct rds_conn_path * cp ) ;
void rds_tcp_reset_callbacks ( struct socket * sock , struct rds_conn_path * cp ) ;
2009-08-21 16:28:31 +04:00
void rds_tcp_restore_callbacks ( struct socket * sock ,
struct rds_tcp_connection * tc ) ;
2018-01-19 00:11:07 +03:00
u32 rds_tcp_write_seq ( struct rds_tcp_connection * tc ) ;
2009-08-21 16:28:31 +04:00
u32 rds_tcp_snd_una ( struct rds_tcp_connection * tc ) ;
u64 rds_tcp_map_seq ( struct rds_tcp_connection * tc , u32 seq ) ;
extern struct rds_transport rds_tcp_transport ;
2015-08-05 08:43:26 +03:00
void rds_tcp_accept_work ( struct sock * sk ) ;
2009-08-21 16:28:31 +04:00
/* tcp_connect.c */
2016-07-01 02:11:16 +03:00
int rds_tcp_conn_path_connect ( struct rds_conn_path * cp ) ;
2016-07-01 02:11:10 +03:00
void rds_tcp_conn_path_shutdown ( struct rds_conn_path * conn ) ;
2009-08-21 16:28:31 +04:00
void rds_tcp_state_change ( struct sock * sk ) ;
/* tcp_listen.c */
2018-07-24 06:51:22 +03:00
struct socket * rds_tcp_listen_init ( struct net * net , bool isv6 ) ;
2017-03-04 19:57:35 +03:00
void rds_tcp_listen_stop ( struct socket * sock , struct work_struct * acceptor ) ;
2014-04-12 00:15:36 +04:00
void rds_tcp_listen_data_ready ( struct sock * sk ) ;
2015-08-05 08:43:26 +03:00
int rds_tcp_accept_one ( struct socket * sock ) ;
int rds_tcp_keepalive ( struct socket * sock ) ;
2016-07-14 13:51:01 +03:00
void * rds_tcp_listen_sock_def_readable ( struct net * net ) ;
2017-06-21 23:40:13 +03:00
void rds_tcp_set_linger ( struct socket * sock ) ;
2009-08-21 16:28:31 +04:00
/* tcp_recv.c */
2010-07-09 23:26:20 +04:00
int rds_tcp_recv_init ( void ) ;
2009-08-21 16:28:31 +04:00
void rds_tcp_recv_exit ( void ) ;
2014-04-12 00:15:36 +04:00
void rds_tcp_data_ready ( struct sock * sk ) ;
2016-07-01 02:11:15 +03:00
int rds_tcp_recv_path ( struct rds_conn_path * cp ) ;
2009-08-21 16:28:31 +04:00
void rds_tcp_inc_free ( struct rds_incoming * inc ) ;
2014-11-20 17:21:14 +03:00
int rds_tcp_inc_copy_to_user ( struct rds_incoming * inc , struct iov_iter * to ) ;
2009-08-21 16:28:31 +04:00
/* tcp_send.c */
2016-07-01 02:11:10 +03:00
void rds_tcp_xmit_path_prepare ( struct rds_conn_path * cp ) ;
void rds_tcp_xmit_path_complete ( struct rds_conn_path * cp ) ;
2009-08-21 16:28:31 +04:00
int rds_tcp_xmit ( struct rds_connection * conn , struct rds_message * rm ,
2016-06-18 18:46:31 +03:00
unsigned int hdr_off , unsigned int sg , unsigned int off ) ;
2009-08-21 16:28:31 +04:00
void rds_tcp_write_space ( struct sock * sk ) ;
/* tcp_stats.c */
DECLARE_PER_CPU ( struct rds_tcp_statistics , rds_tcp_stats ) ;
# define rds_tcp_stats_inc(member) rds_stats_inc_which(rds_tcp_stats, member)
unsigned int rds_tcp_stats_info_copy ( struct rds_info_iterator * iter ,
unsigned int avail ) ;
# endif
