2007-05-08 11:27:59 +04:00
/*
* linux / kernel / time / timekeeping . c
*
* Kernel timekeeping code and accessor functions
*
* This code was moved from linux / kernel / timer . c .
* Please see that file for copyright and history logs .
*
*/
# include <linux/module.h>
# include <linux/interrupt.h>
# include <linux/percpu.h>
# include <linux/init.h>
# include <linux/mm.h>
2009-10-07 17:09:06 +04:00
# include <linux/sched.h>
2011-03-24 00:16:04 +03:00
# include <linux/syscore_ops.h>
2007-05-08 11:27:59 +04:00
# include <linux/clocksource.h>
# include <linux/jiffies.h>
# include <linux/time.h>
# include <linux/tick.h>
2009-08-14 17:47:30 +04:00
# include <linux/stop_machine.h>
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:26 +04:00
/* Structure holding internal timekeeping values. */
struct timekeeper {
/* Current clocksource used for timekeeping. */
2012-07-13 09:21:51 +04:00
struct clocksource * clock ;
2011-11-14 03:19:48 +04:00
/* NTP adjusted clock multiplier */
2012-07-13 09:21:51 +04:00
u32 mult ;
2009-08-14 17:47:27 +04:00
/* The shift value of the current clocksource. */
2012-07-13 09:21:52 +04:00
u32 shift ;
2009-08-14 17:47:26 +04:00
/* Number of clock cycles in one NTP interval. */
2012-07-13 09:21:51 +04:00
cycle_t cycle_interval ;
2009-08-14 17:47:26 +04:00
/* Number of clock shifted nano seconds in one NTP interval. */
2012-07-13 09:21:51 +04:00
u64 xtime_interval ;
2010-10-21 02:55:15 +04:00
/* shifted nano seconds left over when rounding cycle_interval */
2012-07-13 09:21:51 +04:00
s64 xtime_remainder ;
2009-08-14 17:47:26 +04:00
/* Raw nano seconds accumulated per NTP interval. */
2012-07-13 09:21:51 +04:00
u32 raw_interval ;
2009-08-14 17:47:26 +04:00
2012-07-13 09:21:53 +04:00
/* Current CLOCK_REALTIME time in seconds */
u64 xtime_sec ;
/* Clock shifted nano seconds */
2012-07-13 09:21:51 +04:00
u64 xtime_nsec ;
2012-07-13 09:21:53 +04:00
2009-08-14 17:47:26 +04:00
/* Difference between accumulated time and NTP time in ntp
* shifted nano seconds . */
2012-07-13 09:21:51 +04:00
s64 ntp_error ;
2009-08-14 17:47:27 +04:00
/* Shift conversion between clock shifted nano seconds and
* ntp shifted nano seconds . */
2012-07-13 09:21:52 +04:00
u32 ntp_error_shift ;
2011-11-14 23:23:15 +04:00
2011-11-14 23:29:32 +04:00
/*
* wall_to_monotonic is what we need to add to xtime ( or xtime corrected
* for sub jiffie times ) to get to monotonic time . Monotonic is pegged
* at zero at system boot time , so wall_to_monotonic will be negative ,
* however , we will ALWAYS keep the tv_nsec part positive so we can use
* the usual normalization .
*
* wall_to_monotonic is moved after resume from suspend for the
* monotonic time not to jump . We need to add total_sleep_time to
* wall_to_monotonic to get the real boot based time offset .
*
* - wall_to_monotonic is no longer the boot time , getboottime must be
* used instead .
*/
2012-07-13 09:21:51 +04:00
struct timespec wall_to_monotonic ;
2012-07-11 02:43:21 +04:00
/* Offset clock monotonic -> clock realtime */
2012-07-13 09:21:51 +04:00
ktime_t offs_real ;
2012-07-27 22:48:12 +04:00
/* time spent in suspend */
struct timespec total_sleep_time ;
2012-07-11 02:43:21 +04:00
/* Offset clock monotonic -> clock boottime */
2012-07-13 09:21:51 +04:00
ktime_t offs_boot ;
2012-07-27 22:48:12 +04:00
/* The raw monotonic time for the CLOCK_MONOTONIC_RAW posix clock. */
struct timespec raw_time ;
2011-11-15 00:48:10 +04:00
/* Seqlock for all timekeeper values */
2012-07-13 09:21:51 +04:00
seqlock_t lock ;
2009-08-14 17:47:26 +04:00
} ;
2011-01-12 02:59:38 +03:00
static struct timekeeper timekeeper ;
2009-08-14 17:47:26 +04:00
2011-11-14 23:46:39 +04:00
/*
* This read - write spinlock protects us from races in SMP while
* playing with xtime .
*/
__cacheline_aligned_in_smp DEFINE_SEQLOCK ( xtime_lock ) ;
/* flag for if timekeeping is suspended */
int __read_mostly timekeeping_suspended ;
2012-07-13 09:21:53 +04:00
static inline void tk_normalize_xtime ( struct timekeeper * tk )
{
while ( tk - > xtime_nsec > = ( ( u64 ) NSEC_PER_SEC < < tk - > shift ) ) {
tk - > xtime_nsec - = ( u64 ) NSEC_PER_SEC < < tk - > shift ;
tk - > xtime_sec + + ;
}
}
static struct timespec tk_xtime ( struct timekeeper * tk )
{
struct timespec ts ;
ts . tv_sec = tk - > xtime_sec ;
ts . tv_nsec = ( long ) ( tk - > xtime_nsec > > tk - > shift ) ;
return ts ;
}
2011-11-14 23:46:39 +04:00
2012-07-13 09:21:53 +04:00
static void tk_set_xtime ( struct timekeeper * tk , const struct timespec * ts )
{
tk - > xtime_sec = ts - > tv_sec ;
2012-07-24 00:22:37 +04:00
tk - > xtime_nsec = ( u64 ) ts - > tv_nsec < < tk - > shift ;
2012-07-13 09:21:53 +04:00
}
static void tk_xtime_add ( struct timekeeper * tk , const struct timespec * ts )
{
tk - > xtime_sec + = ts - > tv_sec ;
2012-07-24 00:22:37 +04:00
tk - > xtime_nsec + = ( u64 ) ts - > tv_nsec < < tk - > shift ;
2012-07-13 09:21:53 +04:00
}
2011-11-14 23:46:39 +04:00
2012-07-27 22:48:12 +04:00
static void tk_set_wall_to_mono ( struct timekeeper * tk , struct timespec wtm )
{
struct timespec tmp ;
/*
* Verify consistency of : offset_real = - wall_to_monotonic
* before modifying anything
*/
set_normalized_timespec ( & tmp , - tk - > wall_to_monotonic . tv_sec ,
- tk - > wall_to_monotonic . tv_nsec ) ;
WARN_ON_ONCE ( tk - > offs_real . tv64 ! = timespec_to_ktime ( tmp ) . tv64 ) ;
tk - > wall_to_monotonic = wtm ;
set_normalized_timespec ( & tmp , - wtm . tv_sec , - wtm . tv_nsec ) ;
tk - > offs_real = timespec_to_ktime ( tmp ) ;
}
static void tk_set_sleep_time ( struct timekeeper * tk , struct timespec t )
{
/* Verify consistency before modifying */
WARN_ON_ONCE ( tk - > offs_boot . tv64 ! = timespec_to_ktime ( tk - > total_sleep_time ) . tv64 ) ;
tk - > total_sleep_time = t ;
tk - > offs_boot = timespec_to_ktime ( t ) ;
}
2009-08-14 17:47:26 +04:00
/**
* timekeeper_setup_internals - Set up internals to use clocksource clock .
*
* @ clock : Pointer to clocksource .
*
* Calculates a fixed cycle / nsec interval for a given clocksource / adjustment
* pair and interval request .
*
* Unless you ' re the timekeeping code , you should not be using this !
*/
2012-07-13 09:21:57 +04:00
static void tk_setup_internals ( struct timekeeper * tk , struct clocksource * clock )
2009-08-14 17:47:26 +04:00
{
cycle_t interval ;
2010-10-21 02:55:15 +04:00
u64 tmp , ntpinterval ;
2012-07-13 09:21:53 +04:00
struct clocksource * old_clock ;
2009-08-14 17:47:26 +04:00
2012-07-13 09:21:57 +04:00
old_clock = tk - > clock ;
tk - > clock = clock ;
2009-08-14 17:47:26 +04:00
clock - > cycle_last = clock - > read ( clock ) ;
/* Do the ns -> cycle conversion first, using original mult */
tmp = NTP_INTERVAL_LENGTH ;
tmp < < = clock - > shift ;
2010-10-21 02:55:15 +04:00
ntpinterval = tmp ;
2009-08-14 17:47:28 +04:00
tmp + = clock - > mult / 2 ;
do_div ( tmp , clock - > mult ) ;
2009-08-14 17:47:26 +04:00
if ( tmp = = 0 )
tmp = 1 ;
interval = ( cycle_t ) tmp ;
2012-07-13 09:21:57 +04:00
tk - > cycle_interval = interval ;
2009-08-14 17:47:26 +04:00
/* Go back from cycles -> shifted ns */
2012-07-13 09:21:57 +04:00
tk - > xtime_interval = ( u64 ) interval * clock - > mult ;
tk - > xtime_remainder = ntpinterval - tk - > xtime_interval ;
tk - > raw_interval =
2009-08-14 17:47:28 +04:00
( ( u64 ) interval * clock - > mult ) > > clock - > shift ;
2009-08-14 17:47:26 +04:00
2012-07-13 09:21:53 +04:00
/* if changing clocks, convert xtime_nsec shift units */
if ( old_clock ) {
int shift_change = clock - > shift - old_clock - > shift ;
if ( shift_change < 0 )
2012-07-13 09:21:57 +04:00
tk - > xtime_nsec > > = - shift_change ;
2012-07-13 09:21:53 +04:00
else
2012-07-13 09:21:57 +04:00
tk - > xtime_nsec < < = shift_change ;
2012-07-13 09:21:53 +04:00
}
2012-07-13 09:21:57 +04:00
tk - > shift = clock - > shift ;
2009-08-14 17:47:26 +04:00
2012-07-13 09:21:57 +04:00
tk - > ntp_error = 0 ;
tk - > ntp_error_shift = NTP_SCALE_SHIFT - clock - > shift ;
2009-08-14 17:47:28 +04:00
/*
* The timekeeper keeps its own mult values for the currently
* active clocksource . These value will be adjusted via NTP
* to counteract clock drifting .
*/
2012-07-13 09:21:57 +04:00
tk - > mult = clock - > mult ;
2009-08-14 17:47:26 +04:00
}
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:29 +04:00
/* Timekeeper helper functions. */
2012-07-13 09:21:57 +04:00
static inline s64 timekeeping_get_ns ( struct timekeeper * tk )
2009-08-14 17:47:29 +04:00
{
cycle_t cycle_now , cycle_delta ;
struct clocksource * clock ;
2012-07-13 09:21:53 +04:00
s64 nsec ;
2009-08-14 17:47:29 +04:00
/* read clocksource: */
2012-07-13 09:21:57 +04:00
clock = tk - > clock ;
2009-08-14 17:47:29 +04:00
cycle_now = clock - > read ( clock ) ;
/* calculate the delta since the last update_wall_time: */
cycle_delta = ( cycle_now - clock - > cycle_last ) & clock - > mask ;
2012-07-13 09:21:57 +04:00
nsec = cycle_delta * tk - > mult + tk - > xtime_nsec ;
nsec > > = tk - > shift ;
2012-07-13 09:21:55 +04:00
/* If arch requires, add in gettimeoffset() */
return nsec + arch_gettimeoffset ( ) ;
2009-08-14 17:47:29 +04:00
}
2012-07-13 09:21:57 +04:00
static inline s64 timekeeping_get_ns_raw ( struct timekeeper * tk )
2009-08-14 17:47:29 +04:00
{
cycle_t cycle_now , cycle_delta ;
struct clocksource * clock ;
2012-07-13 09:21:55 +04:00
s64 nsec ;
2009-08-14 17:47:29 +04:00
/* read clocksource: */
2012-07-13 09:21:57 +04:00
clock = tk - > clock ;
2009-08-14 17:47:29 +04:00
cycle_now = clock - > read ( clock ) ;
/* calculate the delta since the last update_wall_time: */
cycle_delta = ( cycle_now - clock - > cycle_last ) & clock - > mask ;
2012-07-13 09:21:55 +04:00
/* convert delta to nanoseconds. */
nsec = clocksource_cyc2ns ( cycle_delta , clock - > mult , clock - > shift ) ;
/* If arch requires, add in gettimeoffset() */
return nsec + arch_gettimeoffset ( ) ;
2009-08-14 17:47:29 +04:00
}
2011-11-14 03:19:49 +04:00
/* must hold write on timekeeper.lock */
2012-07-13 09:21:57 +04:00
static void timekeeping_update ( struct timekeeper * tk , bool clearntp )
2011-11-14 03:19:49 +04:00
{
2012-07-13 09:21:53 +04:00
struct timespec xt ;
2011-11-14 03:19:49 +04:00
if ( clearntp ) {
2012-07-13 09:21:57 +04:00
tk - > ntp_error = 0 ;
2011-11-14 03:19:49 +04:00
ntp_clear ( ) ;
}
2012-07-13 09:21:57 +04:00
xt = tk_xtime ( tk ) ;
update_vsyscall ( & xt , & tk - > wall_to_monotonic , tk - > clock , tk - > mult ) ;
2011-11-14 03:19:49 +04:00
}
2007-05-08 11:27:59 +04:00
/**
2009-08-14 17:47:26 +04:00
* timekeeping_forward_now - update clock to the current time
2007-05-08 11:27:59 +04:00
*
2008-08-21 03:37:28 +04:00
* Forward the current clock to update its state since the last call to
* update_wall_time ( ) . This is useful before significant clock changes ,
* as it avoids having to deal with this time offset explicitly .
2007-05-08 11:27:59 +04:00
*/
2012-07-13 09:21:57 +04:00
static void timekeeping_forward_now ( struct timekeeper * tk )
2007-05-08 11:27:59 +04:00
{
cycle_t cycle_now , cycle_delta ;
2009-08-14 17:47:26 +04:00
struct clocksource * clock ;
2008-08-21 03:37:28 +04:00
s64 nsec ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:57 +04:00
clock = tk - > clock ;
2009-08-14 17:47:19 +04:00
cycle_now = clock - > read ( clock ) ;
2007-05-08 11:27:59 +04:00
cycle_delta = ( cycle_now - clock - > cycle_last ) & clock - > mask ;
2008-08-21 03:37:28 +04:00
clock - > cycle_last = cycle_now ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:57 +04:00
tk - > xtime_nsec + = cycle_delta * tk - > mult ;
2009-05-02 00:10:26 +04:00
/* If arch requires, add in gettimeoffset() */
2012-07-13 09:21:57 +04:00
tk - > xtime_nsec + = arch_gettimeoffset ( ) < < tk - > shift ;
2009-05-02 00:10:26 +04:00
2012-07-13 09:21:57 +04:00
tk_normalize_xtime ( tk ) ;
2008-08-21 03:37:30 +04:00
2009-08-14 17:47:28 +04:00
nsec = clocksource_cyc2ns ( cycle_delta , clock - > mult , clock - > shift ) ;
2012-07-13 09:21:57 +04:00
timespec_add_ns ( & tk - > raw_time , nsec ) ;
2007-05-08 11:27:59 +04:00
}
/**
2008-01-30 15:30:01 +03:00
* getnstimeofday - Returns the time of day in a timespec
2007-05-08 11:27:59 +04:00
* @ ts : pointer to the timespec to be set
*
2008-01-30 15:30:01 +03:00
* Returns the time of day in a timespec .
2007-05-08 11:27:59 +04:00
*/
2008-01-30 15:30:01 +03:00
void getnstimeofday ( struct timespec * ts )
2007-05-08 11:27:59 +04:00
{
unsigned long seq ;
2012-07-13 09:21:53 +04:00
s64 nsecs = 0 ;
2007-05-08 11:27:59 +04:00
2008-12-23 01:05:28 +03:00
WARN_ON ( timekeeping_suspended ) ;
2007-05-08 11:27:59 +04:00
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:53 +04:00
ts - > tv_sec = timekeeper . xtime_sec ;
2012-07-13 09:21:57 +04:00
ts - > tv_nsec = timekeeping_get_ns ( & timekeeper ) ;
2007-05-08 11:27:59 +04:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2007-05-08 11:27:59 +04:00
timespec_add_ns ( ts , nsecs ) ;
}
EXPORT_SYMBOL ( getnstimeofday ) ;
2009-07-07 13:27:28 +04:00
ktime_t ktime_get ( void )
{
unsigned int seq ;
s64 secs , nsecs ;
WARN_ON ( timekeeping_suspended ) ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:53 +04:00
secs = timekeeper . xtime_sec +
2011-11-14 23:40:54 +04:00
timekeeper . wall_to_monotonic . tv_sec ;
2012-07-13 09:21:57 +04:00
nsecs = timekeeping_get_ns ( & timekeeper ) +
2011-11-14 23:40:54 +04:00
timekeeper . wall_to_monotonic . tv_nsec ;
2009-07-07 13:27:28 +04:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2009-07-07 13:27:28 +04:00
/*
* Use ktime_set / ktime_add_ns to create a proper ktime on
* 32 - bit architectures without CONFIG_KTIME_SCALAR .
*/
return ktime_add_ns ( ktime_set ( secs , 0 ) , nsecs ) ;
}
EXPORT_SYMBOL_GPL ( ktime_get ) ;
/**
* ktime_get_ts - get the monotonic clock in timespec format
* @ ts : pointer to timespec variable
*
* The function calculates the monotonic clock from the realtime
* clock and the wall_to_monotonic offset and stores the result
* in normalized timespec format in the variable pointed to by @ ts .
*/
void ktime_get_ts ( struct timespec * ts )
{
struct timespec tomono ;
unsigned int seq ;
WARN_ON ( timekeeping_suspended ) ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:53 +04:00
ts - > tv_sec = timekeeper . xtime_sec ;
2012-07-13 09:21:57 +04:00
ts - > tv_nsec = timekeeping_get_ns ( & timekeeper ) ;
2011-11-14 23:29:32 +04:00
tomono = timekeeper . wall_to_monotonic ;
2009-07-07 13:27:28 +04:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2009-07-07 13:27:28 +04:00
set_normalized_timespec ( ts , ts - > tv_sec + tomono . tv_sec ,
2012-07-13 09:21:53 +04:00
ts - > tv_nsec + tomono . tv_nsec ) ;
2009-07-07 13:27:28 +04:00
}
EXPORT_SYMBOL_GPL ( ktime_get_ts ) ;
2011-01-13 04:00:57 +03:00
# ifdef CONFIG_NTP_PPS
/**
* getnstime_raw_and_real - get day and raw monotonic time in timespec format
* @ ts_raw : pointer to the timespec to be set to raw monotonic time
* @ ts_real : pointer to the timespec to be set to the time of day
*
* This function reads both the time of day and raw monotonic time at the
* same time atomically and stores the resulting timestamps in timespec
* format .
*/
void getnstime_raw_and_real ( struct timespec * ts_raw , struct timespec * ts_real )
{
unsigned long seq ;
s64 nsecs_raw , nsecs_real ;
WARN_ON_ONCE ( timekeeping_suspended ) ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2011-01-13 04:00:57 +03:00
2011-11-14 23:43:49 +04:00
* ts_raw = timekeeper . raw_time ;
2012-07-13 09:21:53 +04:00
ts_real - > tv_sec = timekeeper . xtime_sec ;
ts_real - > tv_nsec = 0 ;
2011-01-13 04:00:57 +03:00
2012-07-13 09:21:57 +04:00
nsecs_raw = timekeeping_get_ns_raw ( & timekeeper ) ;
nsecs_real = timekeeping_get_ns ( & timekeeper ) ;
2011-01-13 04:00:57 +03:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2011-01-13 04:00:57 +03:00
timespec_add_ns ( ts_raw , nsecs_raw ) ;
timespec_add_ns ( ts_real , nsecs_real ) ;
}
EXPORT_SYMBOL ( getnstime_raw_and_real ) ;
# endif /* CONFIG_NTP_PPS */
2007-05-08 11:27:59 +04:00
/**
* do_gettimeofday - Returns the time of day in a timeval
* @ tv : pointer to the timeval to be set
*
2008-01-30 15:30:01 +03:00
* NOTE : Users should be converted to using getnstimeofday ( )
2007-05-08 11:27:59 +04:00
*/
void do_gettimeofday ( struct timeval * tv )
{
struct timespec now ;
2008-01-30 15:30:01 +03:00
getnstimeofday ( & now ) ;
2007-05-08 11:27:59 +04:00
tv - > tv_sec = now . tv_sec ;
tv - > tv_usec = now . tv_nsec / 1000 ;
}
EXPORT_SYMBOL ( do_gettimeofday ) ;
2012-04-27 12:12:42 +04:00
2007-05-08 11:27:59 +04:00
/**
* do_settimeofday - Sets the time of day
* @ tv : pointer to the timespec variable containing the new time
*
* Sets the time of day to the new time and update NTP and notify hrtimers
*/
2011-02-01 16:50:58 +03:00
int do_settimeofday ( const struct timespec * tv )
2007-05-08 11:27:59 +04:00
{
2012-07-13 09:21:53 +04:00
struct timespec ts_delta , xt ;
2011-11-15 02:05:44 +04:00
unsigned long flags ;
2007-05-08 11:27:59 +04:00
if ( ( unsigned long ) tv - > tv_nsec > = NSEC_PER_SEC )
return - EINVAL ;
2011-11-15 02:05:44 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:57 +04:00
timekeeping_forward_now ( & timekeeper ) ;
2008-08-21 03:37:28 +04:00
2012-07-13 09:21:53 +04:00
xt = tk_xtime ( & timekeeper ) ;
ts_delta . tv_sec = tv - > tv_sec - xt . tv_sec ;
ts_delta . tv_nsec = tv - > tv_nsec - xt . tv_nsec ;
2012-07-27 22:48:12 +04:00
tk_set_wall_to_mono ( & timekeeper ,
timespec_sub ( timekeeper . wall_to_monotonic , ts_delta ) ) ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:53 +04:00
tk_set_xtime ( & timekeeper , tv ) ;
2012-07-13 09:21:57 +04:00
timekeeping_update ( & timekeeper , true ) ;
2007-05-08 11:27:59 +04:00
2011-11-15 02:05:44 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
/* signal hrtimers about time change */
clock_was_set ( ) ;
return 0 ;
}
EXPORT_SYMBOL ( do_settimeofday ) ;
2011-02-01 16:52:17 +03:00
/**
* timekeeping_inject_offset - Adds or subtracts from the current time .
* @ tv : pointer to the timespec variable containing the offset
*
* Adds or subtracts an offset value from the current time .
*/
int timekeeping_inject_offset ( struct timespec * ts )
{
2011-11-15 02:05:44 +04:00
unsigned long flags ;
2011-02-01 16:52:17 +03:00
if ( ( unsigned long ) ts - > tv_nsec > = NSEC_PER_SEC )
return - EINVAL ;
2011-11-15 02:05:44 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2011-02-01 16:52:17 +03:00
2012-07-13 09:21:57 +04:00
timekeeping_forward_now ( & timekeeper ) ;
2011-02-01 16:52:17 +03:00
2012-07-13 09:21:53 +04:00
tk_xtime_add ( & timekeeper , ts ) ;
2012-07-27 22:48:12 +04:00
tk_set_wall_to_mono ( & timekeeper ,
timespec_sub ( timekeeper . wall_to_monotonic , * ts ) ) ;
2011-02-01 16:52:17 +03:00
2012-07-13 09:21:57 +04:00
timekeeping_update ( & timekeeper , true ) ;
2011-02-01 16:52:17 +03:00
2011-11-15 02:05:44 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2011-02-01 16:52:17 +03:00
/* signal hrtimers about time change */
clock_was_set ( ) ;
return 0 ;
}
EXPORT_SYMBOL ( timekeeping_inject_offset ) ;
2007-05-08 11:27:59 +04:00
/**
* change_clocksource - Swaps clocksources if a new one is available
*
* Accumulates current time interval and initializes new clocksource
*/
2009-08-14 17:47:30 +04:00
static int change_clocksource ( void * data )
2007-05-08 11:27:59 +04:00
{
2009-04-21 23:24:02 +04:00
struct clocksource * new , * old ;
2012-03-15 03:38:15 +04:00
unsigned long flags ;
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:30 +04:00
new = ( struct clocksource * ) data ;
2007-05-08 11:27:59 +04:00
2012-03-15 03:38:15 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2012-07-13 09:21:57 +04:00
timekeeping_forward_now ( & timekeeper ) ;
2009-08-14 17:47:30 +04:00
if ( ! new - > enable | | new - > enable ( new ) = = 0 ) {
old = timekeeper . clock ;
2012-07-13 09:21:57 +04:00
tk_setup_internals ( & timekeeper , new ) ;
2009-08-14 17:47:30 +04:00
if ( old - > disable )
old - > disable ( old ) ;
}
2012-07-13 09:21:57 +04:00
timekeeping_update ( & timekeeper , true ) ;
2012-03-15 03:38:15 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2009-08-14 17:47:30 +04:00
return 0 ;
}
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:30 +04:00
/**
* timekeeping_notify - Install a new clock source
* @ clock : pointer to the clock source
*
* This function is called from clocksource . c after a new , better clock
* source has been registered . The caller holds the clocksource_mutex .
*/
void timekeeping_notify ( struct clocksource * clock )
{
if ( timekeeper . clock = = clock )
2009-04-21 23:24:02 +04:00
return ;
2009-08-14 17:47:30 +04:00
stop_machine ( change_clocksource , clock , NULL ) ;
2007-05-08 11:27:59 +04:00
tick_clock_notify ( ) ;
}
2009-08-14 17:47:30 +04:00
2009-07-07 15:00:31 +04:00
/**
* ktime_get_real - get the real ( wall - ) time in ktime_t format
*
* returns the time in ktime_t format
*/
ktime_t ktime_get_real ( void )
{
struct timespec now ;
getnstimeofday ( & now ) ;
return timespec_to_ktime ( now ) ;
}
EXPORT_SYMBOL_GPL ( ktime_get_real ) ;
2007-05-08 11:27:59 +04:00
2008-08-21 03:37:30 +04:00
/**
* getrawmonotonic - Returns the raw monotonic time in a timespec
* @ ts : pointer to the timespec to be set
*
* Returns the raw monotonic time ( completely un - modified by ntp )
*/
void getrawmonotonic ( struct timespec * ts )
{
unsigned long seq ;
s64 nsecs ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:57 +04:00
nsecs = timekeeping_get_ns_raw ( & timekeeper ) ;
2011-11-14 23:43:49 +04:00
* ts = timekeeper . raw_time ;
2008-08-21 03:37:30 +04:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2008-08-21 03:37:30 +04:00
timespec_add_ns ( ts , nsecs ) ;
}
EXPORT_SYMBOL ( getrawmonotonic ) ;
2007-05-08 11:27:59 +04:00
/**
2008-02-08 15:19:24 +03:00
* timekeeping_valid_for_hres - Check if timekeeping is suitable for hres
2007-05-08 11:27:59 +04:00
*/
2008-02-08 15:19:24 +03:00
int timekeeping_valid_for_hres ( void )
2007-05-08 11:27:59 +04:00
{
unsigned long seq ;
int ret ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:26 +04:00
ret = timekeeper . clock - > flags & CLOCK_SOURCE_VALID_FOR_HRES ;
2007-05-08 11:27:59 +04:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2007-05-08 11:27:59 +04:00
return ret ;
}
2009-08-18 21:45:10 +04:00
/**
* timekeeping_max_deferment - Returns max time the clocksource can be deferred
*/
u64 timekeeping_max_deferment ( void )
{
2011-11-15 00:48:10 +04:00
unsigned long seq ;
u64 ret ;
2012-07-13 09:21:51 +04:00
2011-11-15 00:48:10 +04:00
do {
seq = read_seqbegin ( & timekeeper . lock ) ;
ret = timekeeper . clock - > max_idle_ns ;
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
return ret ;
2009-08-18 21:45:10 +04:00
}
2007-05-08 11:27:59 +04:00
/**
2009-08-14 17:47:31 +04:00
* read_persistent_clock - Return time from the persistent clock .
2007-05-08 11:27:59 +04:00
*
* Weak dummy function for arches that do not yet support it .
2009-08-14 17:47:31 +04:00
* Reads the time from the battery backed persistent clock .
* Returns a timespec with tv_sec = 0 and tv_nsec = 0 if unsupported .
2007-05-08 11:27:59 +04:00
*
* XXX - Do be sure to remove it once all arches implement it .
*/
2009-08-14 17:47:31 +04:00
void __attribute__ ( ( weak ) ) read_persistent_clock ( struct timespec * ts )
2007-05-08 11:27:59 +04:00
{
2009-08-14 17:47:31 +04:00
ts - > tv_sec = 0 ;
ts - > tv_nsec = 0 ;
2007-05-08 11:27:59 +04:00
}
2009-08-14 17:47:32 +04:00
/**
* read_boot_clock - Return time of the system start .
*
* Weak dummy function for arches that do not yet support it .
* Function to read the exact time the system has been started .
* Returns a timespec with tv_sec = 0 and tv_nsec = 0 if unsupported .
*
* XXX - Do be sure to remove it once all arches implement it .
*/
void __attribute__ ( ( weak ) ) read_boot_clock ( struct timespec * ts )
{
ts - > tv_sec = 0 ;
ts - > tv_nsec = 0 ;
}
2007-05-08 11:27:59 +04:00
/*
* timekeeping_init - Initializes the clocksource and common timekeeping values
*/
void __init timekeeping_init ( void )
{
2009-08-14 17:47:26 +04:00
struct clocksource * clock ;
2007-05-08 11:27:59 +04:00
unsigned long flags ;
2012-07-27 22:48:12 +04:00
struct timespec now , boot , tmp ;
2009-08-14 17:47:31 +04:00
read_persistent_clock ( & now ) ;
2009-08-14 17:47:32 +04:00
read_boot_clock ( & boot ) ;
2007-05-08 11:27:59 +04:00
2011-11-15 00:48:10 +04:00
seqlock_init ( & timekeeper . lock ) ;
2007-05-08 11:27:59 +04:00
2008-05-01 15:34:41 +04:00
ntp_init ( ) ;
2007-05-08 11:27:59 +04:00
2011-11-15 00:48:10 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2009-08-14 17:47:21 +04:00
clock = clocksource_default_clock ( ) ;
2009-08-14 17:47:19 +04:00
if ( clock - > enable )
clock - > enable ( clock ) ;
2012-07-13 09:21:57 +04:00
tk_setup_internals ( & timekeeper , clock ) ;
2007-05-08 11:27:59 +04:00
2012-07-13 09:21:53 +04:00
tk_set_xtime ( & timekeeper , & now ) ;
2011-11-14 23:43:49 +04:00
timekeeper . raw_time . tv_sec = 0 ;
timekeeper . raw_time . tv_nsec = 0 ;
2012-07-13 09:21:53 +04:00
if ( boot . tv_sec = = 0 & & boot . tv_nsec = = 0 )
boot = tk_xtime ( & timekeeper ) ;
2012-07-27 22:48:12 +04:00
set_normalized_timespec ( & tmp , - boot . tv_sec , - boot . tv_nsec ) ;
tk_set_wall_to_mono ( & timekeeper , tmp ) ;
tmp . tv_sec = 0 ;
tmp . tv_nsec = 0 ;
tk_set_sleep_time ( & timekeeper , tmp ) ;
2011-11-15 00:48:10 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
}
/* time in seconds when suspend began */
2009-08-14 17:47:31 +04:00
static struct timespec timekeeping_suspend_time ;
2007-05-08 11:27:59 +04:00
2011-04-02 01:32:09 +04:00
/**
* __timekeeping_inject_sleeptime - Internal function to add sleep interval
* @ delta : pointer to a timespec delta value
*
* Takes a timespec offset measuring a suspend interval and properly
* adds the sleep offset to the timekeeping variables .
*/
2012-07-13 09:21:57 +04:00
static void __timekeeping_inject_sleeptime ( struct timekeeper * tk ,
struct timespec * delta )
2011-04-02 01:32:09 +04:00
{
2011-06-02 05:18:09 +04:00
if ( ! timespec_valid ( delta ) ) {
2011-07-21 02:42:55 +04:00
printk ( KERN_WARNING " __timekeeping_inject_sleeptime: Invalid "
2011-06-02 05:18:09 +04:00
" sleep delta value! \n " ) ;
return ;
}
2012-07-13 09:21:57 +04:00
tk_xtime_add ( tk , delta ) ;
2012-07-27 22:48:12 +04:00
tk_set_wall_to_mono ( tk , timespec_sub ( tk - > wall_to_monotonic , * delta ) ) ;
tk_set_sleep_time ( tk , timespec_add ( tk - > total_sleep_time , * delta ) ) ;
2011-04-02 01:32:09 +04:00
}
/**
* timekeeping_inject_sleeptime - Adds suspend interval to timeekeeping values
* @ delta : pointer to a timespec delta value
*
* This hook is for architectures that cannot support read_persistent_clock
* because their RTC / persistent clock is only accessible when irqs are enabled .
*
* This function should only be called by rtc_resume ( ) , and allows
* a suspend offset to be injected into the timekeeping values .
*/
void timekeeping_inject_sleeptime ( struct timespec * delta )
{
2011-11-15 02:05:44 +04:00
unsigned long flags ;
2011-04-02 01:32:09 +04:00
struct timespec ts ;
/* Make sure we don't set the clock twice */
read_persistent_clock ( & ts ) ;
if ( ! ( ts . tv_sec = = 0 & & ts . tv_nsec = = 0 ) )
return ;
2011-11-15 02:05:44 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2011-11-15 00:48:10 +04:00
2012-07-13 09:21:57 +04:00
timekeeping_forward_now ( & timekeeper ) ;
2011-04-02 01:32:09 +04:00
2012-07-13 09:21:57 +04:00
__timekeeping_inject_sleeptime ( & timekeeper , delta ) ;
2011-04-02 01:32:09 +04:00
2012-07-13 09:21:57 +04:00
timekeeping_update ( & timekeeper , true ) ;
2011-04-02 01:32:09 +04:00
2011-11-15 02:05:44 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2011-04-02 01:32:09 +04:00
/* signal hrtimers about time change */
clock_was_set ( ) ;
}
2007-05-08 11:27:59 +04:00
/**
* timekeeping_resume - Resumes the generic timekeeping subsystem .
*
* This is for the generic clocksource timekeeping .
* xtime / wall_to_monotonic / jiffies / etc are
* still managed by arch specific suspend / resume code .
*/
2011-03-24 00:16:04 +03:00
static void timekeeping_resume ( void )
2007-05-08 11:27:59 +04:00
{
2011-11-15 02:05:44 +04:00
unsigned long flags ;
2009-08-14 17:47:31 +04:00
struct timespec ts ;
read_persistent_clock ( & ts ) ;
2007-05-08 11:27:59 +04:00
2007-05-14 13:10:02 +04:00
clocksource_resume ( ) ;
2011-11-15 02:05:44 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:31 +04:00
if ( timespec_compare ( & ts , & timekeeping_suspend_time ) > 0 ) {
ts = timespec_sub ( ts , timekeeping_suspend_time ) ;
2012-07-13 09:21:57 +04:00
__timekeeping_inject_sleeptime ( & timekeeper , & ts ) ;
2007-05-08 11:27:59 +04:00
}
/* re-base the last cycle value */
2009-08-14 17:47:26 +04:00
timekeeper . clock - > cycle_last = timekeeper . clock - > read ( timekeeper . clock ) ;
timekeeper . ntp_error = 0 ;
2007-05-08 11:27:59 +04:00
timekeeping_suspended = 0 ;
2012-07-18 13:24:41 +04:00
timekeeping_update ( & timekeeper , false ) ;
2011-11-15 02:05:44 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
touch_softlockup_watchdog ( ) ;
clockevents_notify ( CLOCK_EVT_NOTIFY_RESUME , NULL ) ;
/* Resume hrtimers */
2011-05-02 18:48:57 +04:00
hrtimers_resume ( ) ;
2007-05-08 11:27:59 +04:00
}
2011-03-24 00:16:04 +03:00
static int timekeeping_suspend ( void )
2007-05-08 11:27:59 +04:00
{
2011-11-15 02:05:44 +04:00
unsigned long flags ;
time: Avoid accumulating time drift in suspend/resume
Because the read_persistent_clock interface is usually backed by
only a second granular interface, each time we read from the persistent
clock for suspend/resume, we introduce a half second (on average) of error.
In order to avoid this error accumulating as the system is suspended
over and over, this patch measures the time delta between the persistent
clock and the system CLOCK_REALTIME.
If the delta is less then 2 seconds from the last suspend, we compensate
by using the previous time delta (keeping it close). If it is larger
then 2 seconds, we assume the clock was set or has been changed, so we
do no correction and update the delta.
Note: If NTP is running, ths could seem to "fight" with the NTP corrected
time, where as if the system time was off by 1 second, and NTP slewed the
value in, a suspend/resume cycle could undo this correction, by trying to
restore the previous offset from the persistent clock. However, without
this patch, since each read could cause almost a full second worth of
error, its possible to get almost 2 seconds of error just from the
suspend/resume cycle alone, so this about equal to any offset added by
the compensation.
Further on systems that suspend/resume frequently, this should keep time
closer then NTP could compensate for if the errors were allowed to
accumulate.
Credits to Arve Hjønnevåg for suggesting this solution.
CC: Arve Hjønnevåg <arve@android.com>
CC: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
2011-06-01 09:53:23 +04:00
struct timespec delta , delta_delta ;
static struct timespec old_delta ;
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:31 +04:00
read_persistent_clock ( & timekeeping_suspend_time ) ;
2007-09-16 17:36:43 +04:00
2011-11-15 02:05:44 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2012-07-13 09:21:57 +04:00
timekeeping_forward_now ( & timekeeper ) ;
2007-05-08 11:27:59 +04:00
timekeeping_suspended = 1 ;
time: Avoid accumulating time drift in suspend/resume
Because the read_persistent_clock interface is usually backed by
only a second granular interface, each time we read from the persistent
clock for suspend/resume, we introduce a half second (on average) of error.
In order to avoid this error accumulating as the system is suspended
over and over, this patch measures the time delta between the persistent
clock and the system CLOCK_REALTIME.
If the delta is less then 2 seconds from the last suspend, we compensate
by using the previous time delta (keeping it close). If it is larger
then 2 seconds, we assume the clock was set or has been changed, so we
do no correction and update the delta.
Note: If NTP is running, ths could seem to "fight" with the NTP corrected
time, where as if the system time was off by 1 second, and NTP slewed the
value in, a suspend/resume cycle could undo this correction, by trying to
restore the previous offset from the persistent clock. However, without
this patch, since each read could cause almost a full second worth of
error, its possible to get almost 2 seconds of error just from the
suspend/resume cycle alone, so this about equal to any offset added by
the compensation.
Further on systems that suspend/resume frequently, this should keep time
closer then NTP could compensate for if the errors were allowed to
accumulate.
Credits to Arve Hjønnevåg for suggesting this solution.
CC: Arve Hjønnevåg <arve@android.com>
CC: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
2011-06-01 09:53:23 +04:00
/*
* To avoid drift caused by repeated suspend / resumes ,
* which each can add ~ 1 second drift error ,
* try to compensate so the difference in system time
* and persistent_clock time stays close to constant .
*/
2012-07-13 09:21:53 +04:00
delta = timespec_sub ( tk_xtime ( & timekeeper ) , timekeeping_suspend_time ) ;
time: Avoid accumulating time drift in suspend/resume
Because the read_persistent_clock interface is usually backed by
only a second granular interface, each time we read from the persistent
clock for suspend/resume, we introduce a half second (on average) of error.
In order to avoid this error accumulating as the system is suspended
over and over, this patch measures the time delta between the persistent
clock and the system CLOCK_REALTIME.
If the delta is less then 2 seconds from the last suspend, we compensate
by using the previous time delta (keeping it close). If it is larger
then 2 seconds, we assume the clock was set or has been changed, so we
do no correction and update the delta.
Note: If NTP is running, ths could seem to "fight" with the NTP corrected
time, where as if the system time was off by 1 second, and NTP slewed the
value in, a suspend/resume cycle could undo this correction, by trying to
restore the previous offset from the persistent clock. However, without
this patch, since each read could cause almost a full second worth of
error, its possible to get almost 2 seconds of error just from the
suspend/resume cycle alone, so this about equal to any offset added by
the compensation.
Further on systems that suspend/resume frequently, this should keep time
closer then NTP could compensate for if the errors were allowed to
accumulate.
Credits to Arve Hjønnevåg for suggesting this solution.
CC: Arve Hjønnevåg <arve@android.com>
CC: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
2011-06-01 09:53:23 +04:00
delta_delta = timespec_sub ( delta , old_delta ) ;
if ( abs ( delta_delta . tv_sec ) > = 2 ) {
/*
* if delta_delta is too large , assume time correction
* has occured and set old_delta to the current delta .
*/
old_delta = delta ;
} else {
/* Otherwise try to adjust old_system to compensate */
timekeeping_suspend_time =
timespec_add ( timekeeping_suspend_time , delta_delta ) ;
}
2011-11-15 02:05:44 +04:00
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
clockevents_notify ( CLOCK_EVT_NOTIFY_SUSPEND , NULL ) ;
2010-02-03 01:41:41 +03:00
clocksource_suspend ( ) ;
2007-05-08 11:27:59 +04:00
return 0 ;
}
/* sysfs resume/suspend bits for timekeeping */
2011-03-24 00:16:04 +03:00
static struct syscore_ops timekeeping_syscore_ops = {
2007-05-08 11:27:59 +04:00
. resume = timekeeping_resume ,
. suspend = timekeeping_suspend ,
} ;
2011-03-24 00:16:04 +03:00
static int __init timekeeping_init_ops ( void )
2007-05-08 11:27:59 +04:00
{
2011-03-24 00:16:04 +03:00
register_syscore_ops ( & timekeeping_syscore_ops ) ;
return 0 ;
2007-05-08 11:27:59 +04:00
}
2011-03-24 00:16:04 +03:00
device_initcall ( timekeeping_init_ops ) ;
2007-05-08 11:27:59 +04:00
/*
* If the error is already larger , we look ahead even further
* to compensate for late or lost adjustments .
*/
2012-07-13 09:21:57 +04:00
static __always_inline int timekeeping_bigadjust ( struct timekeeper * tk ,
s64 error , s64 * interval ,
2007-05-08 11:27:59 +04:00
s64 * offset )
{
s64 tick_error , i ;
u32 look_ahead , adj ;
s32 error2 , mult ;
/*
* Use the current error value to determine how much to look ahead .
* The larger the error the slower we adjust for it to avoid problems
* with losing too many ticks , otherwise we would overadjust and
* produce an even larger error . The smaller the adjustment the
* faster we try to adjust for it , as lost ticks can do less harm
2008-02-08 15:19:25 +03:00
* here . This is tuned so that an error of about 1 msec is adjusted
2007-05-08 11:27:59 +04:00
* within about 1 sec ( or 2 ^ 20 nsec in 2 ^ SHIFT_HZ ticks ) .
*/
2012-07-13 09:21:57 +04:00
error2 = tk - > ntp_error > > ( NTP_SCALE_SHIFT + 22 - 2 * SHIFT_HZ ) ;
2007-05-08 11:27:59 +04:00
error2 = abs ( error2 ) ;
for ( look_ahead = 0 ; error2 > 0 ; look_ahead + + )
error2 > > = 2 ;
/*
* Now calculate the error in ( 1 < < look_ahead ) ticks , but first
* remove the single look ahead already included in the error .
*/
2012-07-13 09:21:57 +04:00
tick_error = ntp_tick_length ( ) > > ( tk - > ntp_error_shift + 1 ) ;
tick_error - = tk - > xtime_interval > > 1 ;
2007-05-08 11:27:59 +04:00
error = ( ( error - tick_error ) > > look_ahead ) + tick_error ;
/* Finally calculate the adjustment shift value. */
i = * interval ;
mult = 1 ;
if ( error < 0 ) {
error = - error ;
* interval = - * interval ;
* offset = - * offset ;
mult = - 1 ;
}
for ( adj = 0 ; error > i ; adj + + )
error > > = 1 ;
* interval < < = adj ;
* offset < < = adj ;
return mult < < adj ;
}
/*
* Adjust the multiplier to reduce the error value ,
* this is optimized for the most common adjustments of - 1 , 0 , 1 ,
* for other values we can do a bit more work .
*/
2012-07-13 09:21:57 +04:00
static void timekeeping_adjust ( struct timekeeper * tk , s64 offset )
2007-05-08 11:27:59 +04:00
{
2012-07-13 09:21:57 +04:00
s64 error , interval = tk - > cycle_interval ;
2007-05-08 11:27:59 +04:00
int adj ;
2011-10-28 05:12:42 +04:00
/*
2012-03-15 07:28:56 +04:00
* The point of this is to check if the error is greater than half
2011-10-28 05:12:42 +04:00
* an interval .
*
* First we shift it down from NTP_SHIFT to clocksource - > shifted nsecs .
*
* Note we subtract one in the shift , so that error is really error * 2.
2011-10-28 04:41:17 +04:00
* This " saves " dividing ( shifting ) interval twice , but keeps the
* ( error > interval ) comparison as still measuring if error is
2012-03-15 07:28:56 +04:00
* larger than half an interval .
2011-10-28 05:12:42 +04:00
*
2011-10-28 04:41:17 +04:00
* Note : It does not " save " on aggravation when reading the code .
2011-10-28 05:12:42 +04:00
*/
2012-07-13 09:21:57 +04:00
error = tk - > ntp_error > > ( tk - > ntp_error_shift - 1 ) ;
2007-05-08 11:27:59 +04:00
if ( error > interval ) {
2011-10-28 05:12:42 +04:00
/*
* We now divide error by 4 ( via shift ) , which checks if
2012-03-15 07:28:56 +04:00
* the error is greater than twice the interval .
2011-10-28 05:12:42 +04:00
* If it is greater , we need a bigadjust , if its smaller ,
* we can adjust by 1.
*/
2007-05-08 11:27:59 +04:00
error > > = 2 ;
2011-10-28 05:12:42 +04:00
/*
* XXX - In update_wall_time , we round up to the next
* nanosecond , and store the amount rounded up into
* the error . This causes the likely below to be unlikely .
*
2011-10-28 04:41:17 +04:00
* The proper fix is to avoid rounding up by using
2011-10-28 05:12:42 +04:00
* the high precision timekeeper . xtime_nsec instead of
* xtime . tv_nsec everywhere . Fixing this will take some
* time .
*/
2007-05-08 11:27:59 +04:00
if ( likely ( error < = interval ) )
adj = 1 ;
else
2012-07-13 09:21:57 +04:00
adj = timekeeping_bigadjust ( tk , error , & interval ,
& offset ) ;
2007-05-08 11:27:59 +04:00
} else if ( error < - interval ) {
2011-10-28 05:12:42 +04:00
/* See comment above, this is just switched for the negative */
2007-05-08 11:27:59 +04:00
error > > = 2 ;
if ( likely ( error > = - interval ) ) {
adj = - 1 ;
interval = - interval ;
offset = - offset ;
} else
2012-07-13 09:21:57 +04:00
adj = timekeeping_bigadjust ( tk , error , & interval ,
& offset ) ;
} else
2007-05-08 11:27:59 +04:00
return ;
2012-07-13 09:21:57 +04:00
if ( unlikely ( tk - > clock - > maxadj & &
( tk - > mult + adj > tk - > clock - > mult + tk - > clock - > maxadj ) ) ) {
2012-03-23 06:14:46 +04:00
printk_once ( KERN_WARNING
" Adjusting %s more than 11%% (%ld vs %ld) \n " ,
2012-07-13 09:21:57 +04:00
tk - > clock - > name , ( long ) tk - > mult + adj ,
( long ) tk - > clock - > mult + tk - > clock - > maxadj ) ;
2012-03-23 06:14:46 +04:00
}
2011-10-28 05:12:42 +04:00
/*
* So the following can be confusing .
*
* To keep things simple , lets assume adj = = 1 for now .
*
* When adj ! = 1 , remember that the interval and offset values
* have been appropriately scaled so the math is the same .
*
* The basic idea here is that we ' re increasing the multiplier
* by one , this causes the xtime_interval to be incremented by
* one cycle_interval . This is because :
* xtime_interval = cycle_interval * mult
* So if mult is being incremented by one :
* xtime_interval = cycle_interval * ( mult + 1 )
* Its the same as :
* xtime_interval = ( cycle_interval * mult ) + cycle_interval
* Which can be shortened to :
* xtime_interval + = cycle_interval
*
* So offset stores the non - accumulated cycles . Thus the current
* time ( in shifted nanoseconds ) is :
* now = ( offset * adj ) + xtime_nsec
* Now , even though we ' re adjusting the clock frequency , we have
* to keep time consistent . In other words , we can ' t jump back
* in time , and we also want to avoid jumping forward in time .
*
* So given the same offset value , we need the time to be the same
* both before and after the freq adjustment .
* now = ( offset * adj_1 ) + xtime_nsec_1
* now = ( offset * adj_2 ) + xtime_nsec_2
* So :
* ( offset * adj_1 ) + xtime_nsec_1 =
* ( offset * adj_2 ) + xtime_nsec_2
* And we know :
* adj_2 = adj_1 + 1
* So :
* ( offset * adj_1 ) + xtime_nsec_1 =
* ( offset * ( adj_1 + 1 ) ) + xtime_nsec_2
* ( offset * adj_1 ) + xtime_nsec_1 =
* ( offset * adj_1 ) + offset + xtime_nsec_2
* Canceling the sides :
* xtime_nsec_1 = offset + xtime_nsec_2
* Which gives us :
* xtime_nsec_2 = xtime_nsec_1 - offset
* Which simplfies to :
* xtime_nsec - = offset
*
* XXX - TODO : Doc ntp_error calculation .
*/
2012-07-13 09:21:57 +04:00
tk - > mult + = adj ;
tk - > xtime_interval + = interval ;
tk - > xtime_nsec - = offset ;
tk - > ntp_error - = ( interval - offset ) < < tk - > ntp_error_shift ;
2012-07-13 09:21:56 +04:00
/*
* It may be possible that when we entered this function , xtime_nsec
* was very small . Further , if we ' re slightly speeding the clocksource
* in the code above , its possible the required corrective factor to
* xtime_nsec could cause it to underflow .
*
* Now , since we already accumulated the second , cannot simply roll
* the accumulated second back , since the NTP subsystem has been
* notified via second_overflow . So instead we push xtime_nsec forward
* by the amount we underflowed , and add that amount into the error .
*
* We ' ll correct this error next time through this function , when
* xtime_nsec is not as small .
*/
2012-07-13 09:21:57 +04:00
if ( unlikely ( ( s64 ) tk - > xtime_nsec < 0 ) ) {
s64 neg = - ( s64 ) tk - > xtime_nsec ;
tk - > xtime_nsec = 0 ;
tk - > ntp_error + = neg < < tk - > ntp_error_shift ;
2012-07-13 09:21:56 +04:00
}
2007-05-08 11:27:59 +04:00
}
2012-07-13 09:21:54 +04:00
/**
* accumulate_nsecs_to_secs - Accumulates nsecs into secs
*
* Helper function that accumulates a the nsecs greater then a second
* from the xtime_nsec field to the xtime_secs field .
* It also calls into the NTP code to handle leapsecond processing .
*
*/
static inline void accumulate_nsecs_to_secs ( struct timekeeper * tk )
{
u64 nsecps = ( u64 ) NSEC_PER_SEC < < tk - > shift ;
while ( tk - > xtime_nsec > = nsecps ) {
int leap ;
tk - > xtime_nsec - = nsecps ;
tk - > xtime_sec + + ;
/* Figure out if its a leap sec and apply if needed */
leap = second_overflow ( tk - > xtime_sec ) ;
2012-07-27 22:48:12 +04:00
if ( unlikely ( leap ) ) {
struct timespec ts ;
tk - > xtime_sec + = leap ;
2012-07-13 09:21:54 +04:00
2012-07-27 22:48:12 +04:00
ts . tv_sec = leap ;
ts . tv_nsec = 0 ;
tk_set_wall_to_mono ( tk ,
timespec_sub ( tk - > wall_to_monotonic , ts ) ) ;
clock_was_set_delayed ( ) ;
}
2012-07-13 09:21:54 +04:00
}
}
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
/**
* logarithmic_accumulation - shifted accumulation of cycles
*
* This functions accumulates a shifted interval of cycles into
* into a shifted interval nanoseconds . Allows for O ( log ) accumulation
* loop .
*
* Returns the unconsumed cycles .
*/
2012-07-13 09:21:57 +04:00
static cycle_t logarithmic_accumulation ( struct timekeeper * tk , cycle_t offset ,
u32 shift )
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
{
2010-08-10 01:20:09 +04:00
u64 raw_nsecs ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
2012-07-13 09:21:57 +04:00
/* If the offset is smaller then a shifted interval, do nothing */
if ( offset < tk - > cycle_interval < < shift )
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
return offset ;
/* Accumulate one shifted interval */
2012-07-13 09:21:57 +04:00
offset - = tk - > cycle_interval < < shift ;
tk - > clock - > cycle_last + = tk - > cycle_interval < < shift ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
2012-07-13 09:21:57 +04:00
tk - > xtime_nsec + = tk - > xtime_interval < < shift ;
accumulate_nsecs_to_secs ( tk ) ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
2010-08-10 01:20:09 +04:00
/* Accumulate raw time */
2012-07-13 09:21:57 +04:00
raw_nsecs = tk - > raw_interval < < shift ;
raw_nsecs + = tk - > raw_time . tv_nsec ;
2010-08-13 22:30:58 +04:00
if ( raw_nsecs > = NSEC_PER_SEC ) {
u64 raw_secs = raw_nsecs ;
raw_nsecs = do_div ( raw_secs , NSEC_PER_SEC ) ;
2012-07-13 09:21:57 +04:00
tk - > raw_time . tv_sec + = raw_secs ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
}
2012-07-13 09:21:57 +04:00
tk - > raw_time . tv_nsec = raw_nsecs ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
/* Accumulate error between NTP and clock interval */
2012-07-13 09:21:57 +04:00
tk - > ntp_error + = ntp_tick_length ( ) < < shift ;
tk - > ntp_error - = ( tk - > xtime_interval + tk - > xtime_remainder ) < <
( tk - > ntp_error_shift + shift ) ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
return offset ;
}
2007-05-08 11:27:59 +04:00
/**
* update_wall_time - Uses the current clocksource to increment the wall time
*
*/
2011-01-27 17:58:55 +03:00
static void update_wall_time ( void )
2007-05-08 11:27:59 +04:00
{
2009-08-14 17:47:26 +04:00
struct clocksource * clock ;
2007-05-08 11:27:59 +04:00
cycle_t offset ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
int shift = 0 , maxshift ;
2011-11-15 00:48:10 +04:00
unsigned long flags ;
2012-07-13 09:21:53 +04:00
s64 remainder ;
2011-11-15 00:48:10 +04:00
write_seqlock_irqsave ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
/* Make sure we're fully resumed: */
if ( unlikely ( timekeeping_suspended ) )
2011-11-15 00:48:10 +04:00
goto out ;
2007-05-08 11:27:59 +04:00
2009-08-14 17:47:26 +04:00
clock = timekeeper . clock ;
2010-07-14 04:56:20 +04:00
# ifdef CONFIG_ARCH_USES_GETTIMEOFFSET
2009-08-14 17:47:26 +04:00
offset = timekeeper . cycle_interval ;
2010-07-14 04:56:20 +04:00
# else
offset = ( clock - > read ( clock ) - clock - > cycle_last ) & clock - > mask ;
2007-05-08 11:27:59 +04:00
# endif
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
/*
* With NO_HZ we may have to accumulate many cycle_intervals
* ( think " ticks " ) worth of time at once . To do this efficiently ,
* we calculate the largest doubling multiple of cycle_intervals
2012-03-15 07:28:56 +04:00
* that is smaller than the offset . We then accumulate that
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
* chunk in one go , and then try to consume the next smaller
* doubled multiple .
2007-05-08 11:27:59 +04:00
*/
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
shift = ilog2 ( offset ) - ilog2 ( timekeeper . cycle_interval ) ;
shift = max ( 0 , shift ) ;
2012-03-15 07:28:56 +04:00
/* Bound shift to one less than what overflows tick_length */
2011-11-15 01:18:07 +04:00
maxshift = ( 64 - ( ilog2 ( ntp_tick_length ( ) ) + 1 ) ) - 1 ;
time: Implement logarithmic time accumulation
Accumulating one tick at a time works well unless we're using NOHZ.
Then it can be an issue, since we may have to run through the loop
a few thousand times, which can increase timer interrupt caused
latency.
The current solution was to accumulate in half-second intervals
with NOHZ. This kept the number of loops down, however it did
slightly change how we make NTP adjustments. While not an issue
with NTPd users, as NTPd makes adjustments over a longer period of
time, other adjtimex() users have noticed the half-second
granularity with which we can apply frequency changes to the clock.
For instance, if a application tries to apply a 100ppm frequency
correction for 20ms to correct a 2us offset, with NOHZ they either
get no correction, or a 50us correction.
Now, there will always be some granularity error for applying
frequency corrections. However with users sensitive to this error
have seen a 50-500x increase with NOHZ compared to running without
NOHZ.
So I figured I'd try another approach then just simply increasing
the interval. My approach is to consume the time interval
logarithmically. This reduces the number of times through the loop
needed keeping latency down, while still preserving the original
granularity error for adjtimex() changes.
Further, this change allows us to remove the xtime_cache code
(patch to follow), as xtime is always within one tick of the
current time, instead of the half-second updates it saw before.
An earlier version of this patch has been shipping to x86 users in
the RedHat MRG releases for awhile without issue, but I've reworked
this version to be even more careful about avoiding possible
overflows if the shift value gets too large.
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1254525473.7741.88.camel@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-10-03 03:17:53 +04:00
shift = min ( shift , maxshift ) ;
2009-08-14 17:47:26 +04:00
while ( offset > = timekeeper . cycle_interval ) {
2012-07-13 09:21:57 +04:00
offset = logarithmic_accumulation ( & timekeeper , offset , shift ) ;
2010-03-19 00:47:30 +03:00
if ( offset < timekeeper . cycle_interval < < shift )
shift - - ;
2007-05-08 11:27:59 +04:00
}
/* correct the clock when NTP error is too big */
2012-07-13 09:21:57 +04:00
timekeeping_adjust ( & timekeeper , offset ) ;
2007-05-08 11:27:59 +04:00
time: catch xtime_nsec underflows and fix them
Impact: fix time warp bug
Alex Shi, along with Yanmin Zhang have been noticing occasional time
inconsistencies recently. Through their great diagnosis, they found that
the xtime_nsec value used in update_wall_time was occasionally going
negative. After looking through the code for awhile, I realized we have
the possibility for an underflow when three conditions are met in
update_wall_time():
1) We have accumulated a second's worth of nanoseconds, so we
incremented xtime.tv_sec and appropriately decrement xtime_nsec.
(This doesn't cause xtime_nsec to go negative, but it can cause it
to be small).
2) The remaining offset value is large, but just slightly less then
cycle_interval.
3) clocksource_adjust() is speeding up the clock, causing a
corrective amount (compensating for the increase in the multiplier
being multiplied against the unaccumulated offset value) to be
subtracted from xtime_nsec.
This can cause xtime_nsec to underflow.
Unfortunately, since we notify the NTP subsystem via second_overflow()
whenever we accumulate a full second, and this effects the error
accumulation that has already occured, we cannot simply revert the
accumulated second from xtime nor move the second accumulation to after
the clocksource_adjust call without a change in behavior.
This leaves us with (at least) two options:
1) Simply return from clocksource_adjust() without making a change if we
notice the adjustment would cause xtime_nsec to go negative.
This would work, but I'm concerned that if a large adjustment was needed
(due to the error being large), it may be possible to get stuck with an
ever increasing error that becomes too large to correct (since it may
always force xtime_nsec negative). This may just be paranoia on my part.
2) Catch xtime_nsec if it is negative, then add back the amount its
negative to both xtime_nsec and the error.
This second method is consistent with how we've handled earlier rounding
issues, and also has the benefit that the error being added is always in
the oposite direction also always equal or smaller then the correction
being applied. So the risk of a corner case where things get out of
control is lessened.
This patch fixes bug 11970, as tested by Yanmin Zhang
http://bugzilla.kernel.org/show_bug.cgi?id=11970
Reported-by: alex.shi@intel.com
Signed-off-by: John Stultz <johnstul@us.ibm.com>
Acked-by: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Tested-by: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-12-02 05:34:41 +03:00
2010-04-07 01:30:51 +04:00
/*
2012-07-13 09:21:53 +04:00
* Store only full nanoseconds into xtime_nsec after rounding
* it up and add the remainder to the error difference .
* XXX - This is necessary to avoid small 1 ns inconsistnecies caused
* by truncating the remainder in vsyscalls . However , it causes
* additional work to be done in timekeeping_adjust ( ) . Once
* the vsyscall implementations are converted to use xtime_nsec
* ( shifted nanoseconds ) , this can be killed .
*/
remainder = timekeeper . xtime_nsec & ( ( 1 < < timekeeper . shift ) - 1 ) ;
timekeeper . xtime_nsec - = remainder ;
timekeeper . xtime_nsec + = 1 < < timekeeper . shift ;
timekeeper . ntp_error + = remainder < < timekeeper . ntp_error_shift ;
2007-05-08 11:27:59 +04:00
2010-04-07 01:30:51 +04:00
/*
* Finally , make sure that after the rounding
2012-07-13 09:21:53 +04:00
* xtime_nsec isn ' t larger than NSEC_PER_SEC
2010-04-07 01:30:51 +04:00
*/
2012-07-13 09:21:54 +04:00
accumulate_nsecs_to_secs ( & timekeeper ) ;
Revert "time: Remove xtime_cache"
This reverts commit 7bc7d637452383d56ba4368d4336b0dde1bb476d, as
requested by John Stultz. Quoting John:
"Petr Titěra reported an issue where he saw odd atime regressions with
2.6.33 where there were a full second worth of nanoseconds in the
nanoseconds field.
He also reviewed the time code and narrowed down the problem: unhandled
overflow of the nanosecond field caused by rounding up the
sub-nanosecond accumulated time.
Details:
* At the end of update_wall_time(), we currently round up the
sub-nanosecond portion of accumulated time when storing it into xtime.
This was added to avoid time inconsistencies caused when the
sub-nanosecond portion was truncated when storing into xtime.
Unfortunately we don't handle the possible second overflow caused by
that rounding.
* Previously the xtime_cache code hid this overflow by normalizing the
xtime value when storing into the xtime_cache.
* We could try to handle the second overflow after the rounding up, but
since this affects the timekeeping's internal state, this would further
complicate the next accumulation cycle, causing small errors in ntp
steering. As much as I'd like to get rid of it, the xtime_cache code is
known to work.
* The correct fix is really to include the sub-nanosecond portion in the
timekeeping accessor function, so we don't need to round up at during
accumulation. This would greatly simplify the accumulation code.
Unfortunately, we can't do this safely until the last three
non-GENERIC_TIME arches (sparc32, arm, cris) are converted (those
patches are in -mm) and we kill off the spots where arches set xtime
directly. This is all 2.6.34 material, so I think reverting the
xtime_cache change is the best approach for now.
Many thanks to Petr for both reporting and finding the issue!"
Reported-by: Petr Titěra <P.Titera@century.cz>
Requested-by: john stultz <johnstul@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-23 01:10:37 +03:00
2012-07-13 09:21:57 +04:00
timekeeping_update ( & timekeeper , false ) ;
2011-11-15 00:48:10 +04:00
out :
write_sequnlock_irqrestore ( & timekeeper . lock , flags ) ;
2007-05-08 11:27:59 +04:00
}
2007-07-16 10:39:41 +04:00
/**
* getboottime - Return the real time of system boot .
* @ ts : pointer to the timespec to be set
*
2011-02-15 04:52:09 +03:00
* Returns the wall - time of boot in a timespec .
2007-07-16 10:39:41 +04:00
*
* This is based on the wall_to_monotonic offset and the total suspend
* time . Calls to settimeofday will affect the value returned ( which
* basically means that however wrong your real time clock is at boot time ,
* you get the right time here ) .
*/
void getboottime ( struct timespec * ts )
{
2009-08-25 10:08:30 +04:00
struct timespec boottime = {
2011-11-14 23:29:32 +04:00
. tv_sec = timekeeper . wall_to_monotonic . tv_sec +
2011-11-14 23:23:15 +04:00
timekeeper . total_sleep_time . tv_sec ,
2011-11-14 23:29:32 +04:00
. tv_nsec = timekeeper . wall_to_monotonic . tv_nsec +
2011-11-14 23:23:15 +04:00
timekeeper . total_sleep_time . tv_nsec
2009-08-25 10:08:30 +04:00
} ;
2009-08-14 17:47:31 +04:00
set_normalized_timespec ( ts , - boottime . tv_sec , - boottime . tv_nsec ) ;
2007-07-16 10:39:41 +04:00
}
2010-01-27 14:13:40 +03:00
EXPORT_SYMBOL_GPL ( getboottime ) ;
2007-07-16 10:39:41 +04:00
2011-02-15 04:52:09 +03:00
/**
* get_monotonic_boottime - Returns monotonic time since boot
* @ ts : pointer to the timespec to be set
*
* Returns the monotonic time since boot in a timespec .
*
* This is similar to CLOCK_MONTONIC / ktime_get_ts , but also
* includes the time spent in suspend .
*/
void get_monotonic_boottime ( struct timespec * ts )
{
struct timespec tomono , sleep ;
unsigned int seq ;
WARN_ON ( timekeeping_suspended ) ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:53 +04:00
ts - > tv_sec = timekeeper . xtime_sec ;
2012-07-13 09:21:57 +04:00
ts - > tv_nsec = timekeeping_get_ns ( & timekeeper ) ;
2011-11-14 23:29:32 +04:00
tomono = timekeeper . wall_to_monotonic ;
2011-11-14 23:23:15 +04:00
sleep = timekeeper . total_sleep_time ;
2011-02-15 04:52:09 +03:00
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2011-02-15 04:52:09 +03:00
set_normalized_timespec ( ts , ts - > tv_sec + tomono . tv_sec + sleep . tv_sec ,
2012-07-13 09:21:53 +04:00
ts - > tv_nsec + tomono . tv_nsec + sleep . tv_nsec ) ;
2011-02-15 04:52:09 +03:00
}
EXPORT_SYMBOL_GPL ( get_monotonic_boottime ) ;
/**
* ktime_get_boottime - Returns monotonic time since boot in a ktime
*
* Returns the monotonic time since boot in a ktime
*
* This is similar to CLOCK_MONTONIC / ktime_get , but also
* includes the time spent in suspend .
*/
ktime_t ktime_get_boottime ( void )
{
struct timespec ts ;
get_monotonic_boottime ( & ts ) ;
return timespec_to_ktime ( ts ) ;
}
EXPORT_SYMBOL_GPL ( ktime_get_boottime ) ;
2007-07-16 10:39:41 +04:00
/**
* monotonic_to_bootbased - Convert the monotonic time to boot based .
* @ ts : pointer to the timespec to be converted
*/
void monotonic_to_bootbased ( struct timespec * ts )
{
2011-11-14 23:23:15 +04:00
* ts = timespec_add ( * ts , timekeeper . total_sleep_time ) ;
2007-07-16 10:39:41 +04:00
}
2010-01-27 14:13:40 +03:00
EXPORT_SYMBOL_GPL ( monotonic_to_bootbased ) ;
2007-07-25 04:47:43 +04:00
2007-07-25 05:38:34 +04:00
unsigned long get_seconds ( void )
{
2012-07-13 09:21:53 +04:00
return timekeeper . xtime_sec ;
2007-07-25 05:38:34 +04:00
}
EXPORT_SYMBOL ( get_seconds ) ;
2009-08-20 06:13:34 +04:00
struct timespec __current_kernel_time ( void )
{
2012-07-13 09:21:53 +04:00
return tk_xtime ( & timekeeper ) ;
2009-08-20 06:13:34 +04:00
}
2007-07-25 05:38:34 +04:00
2007-07-25 04:47:43 +04:00
struct timespec current_kernel_time ( void )
{
struct timespec now ;
unsigned long seq ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
Revert "time: Remove xtime_cache"
This reverts commit 7bc7d637452383d56ba4368d4336b0dde1bb476d, as
requested by John Stultz. Quoting John:
"Petr Titěra reported an issue where he saw odd atime regressions with
2.6.33 where there were a full second worth of nanoseconds in the
nanoseconds field.
He also reviewed the time code and narrowed down the problem: unhandled
overflow of the nanosecond field caused by rounding up the
sub-nanosecond accumulated time.
Details:
* At the end of update_wall_time(), we currently round up the
sub-nanosecond portion of accumulated time when storing it into xtime.
This was added to avoid time inconsistencies caused when the
sub-nanosecond portion was truncated when storing into xtime.
Unfortunately we don't handle the possible second overflow caused by
that rounding.
* Previously the xtime_cache code hid this overflow by normalizing the
xtime value when storing into the xtime_cache.
* We could try to handle the second overflow after the rounding up, but
since this affects the timekeeping's internal state, this would further
complicate the next accumulation cycle, causing small errors in ntp
steering. As much as I'd like to get rid of it, the xtime_cache code is
known to work.
* The correct fix is really to include the sub-nanosecond portion in the
timekeeping accessor function, so we don't need to round up at during
accumulation. This would greatly simplify the accumulation code.
Unfortunately, we can't do this safely until the last three
non-GENERIC_TIME arches (sparc32, arm, cris) are converted (those
patches are in -mm) and we kill off the spots where arches set xtime
directly. This is all 2.6.34 material, so I think reverting the
xtime_cache change is the best approach for now.
Many thanks to Petr for both reporting and finding the issue!"
Reported-by: Petr Titěra <P.Titera@century.cz>
Requested-by: john stultz <johnstul@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-23 01:10:37 +03:00
2012-07-13 09:21:53 +04:00
now = tk_xtime ( & timekeeper ) ;
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2007-07-25 04:47:43 +04:00
return now ;
}
EXPORT_SYMBOL ( current_kernel_time ) ;
2009-08-20 06:13:34 +04:00
struct timespec get_monotonic_coarse ( void )
{
struct timespec now , mono ;
unsigned long seq ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
Revert "time: Remove xtime_cache"
This reverts commit 7bc7d637452383d56ba4368d4336b0dde1bb476d, as
requested by John Stultz. Quoting John:
"Petr Titěra reported an issue where he saw odd atime regressions with
2.6.33 where there were a full second worth of nanoseconds in the
nanoseconds field.
He also reviewed the time code and narrowed down the problem: unhandled
overflow of the nanosecond field caused by rounding up the
sub-nanosecond accumulated time.
Details:
* At the end of update_wall_time(), we currently round up the
sub-nanosecond portion of accumulated time when storing it into xtime.
This was added to avoid time inconsistencies caused when the
sub-nanosecond portion was truncated when storing into xtime.
Unfortunately we don't handle the possible second overflow caused by
that rounding.
* Previously the xtime_cache code hid this overflow by normalizing the
xtime value when storing into the xtime_cache.
* We could try to handle the second overflow after the rounding up, but
since this affects the timekeeping's internal state, this would further
complicate the next accumulation cycle, causing small errors in ntp
steering. As much as I'd like to get rid of it, the xtime_cache code is
known to work.
* The correct fix is really to include the sub-nanosecond portion in the
timekeeping accessor function, so we don't need to round up at during
accumulation. This would greatly simplify the accumulation code.
Unfortunately, we can't do this safely until the last three
non-GENERIC_TIME arches (sparc32, arm, cris) are converted (those
patches are in -mm) and we kill off the spots where arches set xtime
directly. This is all 2.6.34 material, so I think reverting the
xtime_cache change is the best approach for now.
Many thanks to Petr for both reporting and finding the issue!"
Reported-by: Petr Titěra <P.Titera@century.cz>
Requested-by: john stultz <johnstul@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-23 01:10:37 +03:00
2012-07-13 09:21:53 +04:00
now = tk_xtime ( & timekeeper ) ;
2011-11-14 23:29:32 +04:00
mono = timekeeper . wall_to_monotonic ;
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2009-08-20 06:13:34 +04:00
set_normalized_timespec ( & now , now . tv_sec + mono . tv_sec ,
now . tv_nsec + mono . tv_nsec ) ;
return now ;
}
2011-01-27 17:58:55 +03:00
/*
* The 64 - bit jiffies value is not atomic - you MUST NOT read it
* without sampling the sequence number in xtime_lock .
* jiffies is defined in the linker script . . .
*/
void do_timer ( unsigned long ticks )
{
jiffies_64 + = ticks ;
update_wall_time ( ) ;
calc_global_load ( ticks ) ;
}
2011-01-27 17:59:05 +03:00
/**
2011-02-15 05:43:08 +03:00
* get_xtime_and_monotonic_and_sleep_offset ( ) - get xtime , wall_to_monotonic ,
* and sleep offsets .
2011-01-27 17:59:05 +03:00
* @ xtim : pointer to timespec to be set with xtime
* @ wtom : pointer to timespec to be set with wall_to_monotonic
2011-02-15 05:43:08 +03:00
* @ sleep : pointer to timespec to be set with time in suspend
2011-01-27 17:59:05 +03:00
*/
2011-02-15 05:43:08 +03:00
void get_xtime_and_monotonic_and_sleep_offset ( struct timespec * xtim ,
struct timespec * wtom , struct timespec * sleep )
2011-01-27 17:59:05 +03:00
{
unsigned long seq ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:53 +04:00
* xtim = tk_xtime ( & timekeeper ) ;
2011-11-14 23:29:32 +04:00
* wtom = timekeeper . wall_to_monotonic ;
2011-11-14 23:23:15 +04:00
* sleep = timekeeper . total_sleep_time ;
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2011-01-27 17:59:05 +03:00
}
2011-01-27 17:59:10 +03:00
2012-07-11 02:43:24 +04:00
# ifdef CONFIG_HIGH_RES_TIMERS
/**
* ktime_get_update_offsets - hrtimer helper
* @ offs_real : pointer to storage for monotonic - > realtime offset
* @ offs_boot : pointer to storage for monotonic - > boottime offset
*
* Returns current monotonic time and updates the offsets
* Called from hrtimer_interupt ( ) or retrigger_next_event ( )
*/
ktime_t ktime_get_update_offsets ( ktime_t * offs_real , ktime_t * offs_boot )
{
ktime_t now ;
unsigned int seq ;
u64 secs , nsecs ;
do {
seq = read_seqbegin ( & timekeeper . lock ) ;
2012-07-13 09:21:53 +04:00
secs = timekeeper . xtime_sec ;
2012-07-13 09:21:57 +04:00
nsecs = timekeeping_get_ns ( & timekeeper ) ;
2012-07-11 02:43:24 +04:00
* offs_real = timekeeper . offs_real ;
* offs_boot = timekeeper . offs_boot ;
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
now = ktime_add_ns ( ktime_set ( secs , 0 ) , nsecs ) ;
now = ktime_sub ( now , * offs_real ) ;
return now ;
}
# endif
2011-04-27 16:16:42 +04:00
/**
* ktime_get_monotonic_offset ( ) - get wall_to_monotonic in ktime_t format
*/
ktime_t ktime_get_monotonic_offset ( void )
{
unsigned long seq ;
struct timespec wtom ;
do {
2011-11-15 00:48:10 +04:00
seq = read_seqbegin ( & timekeeper . lock ) ;
2011-11-14 23:29:32 +04:00
wtom = timekeeper . wall_to_monotonic ;
2011-11-15 00:48:10 +04:00
} while ( read_seqretry ( & timekeeper . lock , seq ) ) ;
2011-04-27 16:16:42 +04:00
return timespec_to_ktime ( wtom ) ;
}
2012-02-03 12:19:07 +04:00
EXPORT_SYMBOL_GPL ( ktime_get_monotonic_offset ) ;
2011-01-27 17:59:10 +03:00
/**
* xtime_update ( ) - advances the timekeeping infrastructure
* @ ticks : number of ticks , that have elapsed since the last call .
*
* Must be called with interrupts disabled .
*/
void xtime_update ( unsigned long ticks )
{
write_seqlock ( & xtime_lock ) ;
do_timer ( ticks ) ;
write_sequnlock ( & xtime_lock ) ;
}