2005-04-17 02:20:36 +04:00
/*
* linux / ipc / util . c
* Copyright ( C ) 1992 Krishna Balasubramanian
*
* Sep 1997 - Call suser ( ) last after " normal " permission checks so we
* get BSD style process accounting right .
* Occurs in several places in the IPC code .
* Chris Evans , < chris @ ferret . lmh . ox . ac . uk >
* Nov 1999 - ipc helper functions , unified SMP locking
2006-01-15 04:43:54 +03:00
* Manfred Spraul < manfred @ colorfullife . com >
2005-04-17 02:20:36 +04:00
* Oct 2002 - One lock per IPC id . RCU ipc_free for lock - free grow_ary ( ) .
* Mingming Cao < cmm @ us . ibm . com >
2006-04-03 01:07:33 +04:00
* Mar 2006 - support for audit of ipc object properties
* Dustin Kirkland < dustin . kirkland @ us . ibm . com >
2006-10-02 13:18:20 +04:00
* Jun 2006 - namespaces ssupport
* OpenVZ , SWsoft Inc .
* Pavel Emelianov < xemul @ openvz . org >
2013-09-12 01:26:26 +04:00
*
* General sysv ipc locking scheme :
2013-10-17 00:46:45 +04:00
* rcu_read_lock ( )
* obtain the ipc object ( kern_ipc_perm ) by looking up the id in an idr
* tree .
* - perform initial checks ( capabilities , auditing and permission ,
* etc ) .
* - perform read - only operations , such as STAT , INFO commands .
* acquire the ipc lock ( kern_ipc_perm . lock ) through
* ipc_lock_object ( )
* - perform data updates , such as SET , RMID commands and
* mechanism - specific operations ( semop / semtimedop ,
* msgsnd / msgrcv , shmat / shmdt ) .
* drop the ipc lock , through ipc_unlock_object ( ) .
* rcu_read_unlock ( )
*
* The ids - > rwsem must be taken when :
* - creating , removing and iterating the existing entries in ipc
* identifier sets .
* - iterating through files under / proc / sysvipc /
*
* Note that sems have a special fast path that avoids kern_ipc_perm . lock -
* see sem_lock ( ) .
2005-04-17 02:20:36 +04:00
*/
# include <linux/mm.h>
# include <linux/shm.h>
# include <linux/init.h>
# include <linux/msg.h>
# include <linux/vmalloc.h>
# include <linux/slab.h>
2013-04-30 02:08:05 +04:00
# include <linux/notifier.h>
2006-01-11 23:17:46 +03:00
# include <linux/capability.h>
2005-04-17 02:20:36 +04:00
# include <linux/highuid.h>
# include <linux/security.h>
# include <linux/rcupdate.h>
# include <linux/workqueue.h>
2005-09-07 02:17:09 +04:00
# include <linux/seq_file.h>
# include <linux/proc_fs.h>
2006-04-03 01:07:33 +04:00
# include <linux/audit.h>
2006-10-02 13:18:20 +04:00
# include <linux/nsproxy.h>
2007-10-19 10:40:54 +04:00
# include <linux/rwsem.h>
2008-04-29 12:00:42 +04:00
# include <linux/memory.h>
2008-02-08 15:18:22 +03:00
# include <linux/ipc_namespace.h>
2005-04-17 02:20:36 +04:00
# include <asm/unistd.h>
# include "util.h"
2005-09-07 02:17:09 +04:00
struct ipc_proc_iface {
const char * path ;
const char * header ;
2006-10-02 13:18:20 +04:00
int ids ;
2005-09-07 02:17:09 +04:00
int ( * show ) ( struct seq_file * , void * ) ;
} ;
2005-04-17 02:20:36 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_init - initialise ipc subsystem
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* The various sysv ipc resources ( semaphores , messages and shared
* memory ) are initialised .
*
* A callback routine is registered into the memory hotplug notifier
* chain : since msgmni scales to lowmem this callback routine will be
* called upon successful memory add / remove to recompute msmgni .
2005-04-17 02:20:36 +04:00
*/
static int __init ipc_init ( void )
{
sem_init ( ) ;
msg_init ( ) ;
shm_init ( ) ;
return 0 ;
}
2014-04-08 02:39:18 +04:00
device_initcall ( ipc_init ) ;
2005-04-17 02:20:36 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_init_ids - initialise ipc identifiers
* @ ids : ipc identifier set
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Set up the sequence range to use for the ipc identifier range ( limited
* below IPCMNI ) then initialise the ids idr .
2005-04-17 02:20:36 +04:00
*/
2007-10-19 10:40:48 +04:00
void ipc_init_ids ( struct ipc_ids * ids )
2005-04-17 02:20:36 +04:00
{
ids - > in_use = 0 ;
ids - > seq = 0 ;
2013-01-05 03:34:50 +04:00
ids - > next_id = - 1 ;
2014-01-28 05:07:09 +04:00
init_rwsem ( & ids - > rwsem ) ;
2007-10-19 10:40:48 +04:00
idr_init ( & ids - > ipcs_idr ) ;
2005-04-17 02:20:36 +04:00
}
2005-09-07 02:17:09 +04:00
# ifdef CONFIG_PROC_FS
2007-02-12 11:55:35 +03:00
static const struct file_operations sysvipc_proc_fops ;
2005-09-07 02:17:09 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_init_proc_interface - create a proc interface for sysipc types using a seq_file interface .
* @ path : Path in procfs
* @ header : Banner to be printed at the beginning of the file .
* @ ids : ipc id table to iterate .
* @ show : show routine .
2005-09-07 02:17:09 +04:00
*/
void __init ipc_init_proc_interface ( const char * path , const char * header ,
2006-10-02 13:18:20 +04:00
int ids , int ( * show ) ( struct seq_file * , void * ) )
2005-09-07 02:17:09 +04:00
{
struct proc_dir_entry * pde ;
struct ipc_proc_iface * iface ;
iface = kmalloc ( sizeof ( * iface ) , GFP_KERNEL ) ;
if ( ! iface )
return ;
iface - > path = path ;
iface - > header = header ;
iface - > ids = ids ;
iface - > show = show ;
2008-04-29 12:02:12 +04:00
pde = proc_create_data ( path ,
S_IRUGO , /* world readable */
NULL , /* parent dir */
& sysvipc_proc_fops ,
iface ) ;
2014-01-28 05:07:06 +04:00
if ( ! pde )
2005-09-07 02:17:09 +04:00
kfree ( iface ) ;
}
# endif
2005-04-17 02:20:36 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_findkey - find a key in an ipc identifier set
* @ ids : ipc identifier set
* @ key : key to find
2014-06-07 01:37:37 +04:00
*
2014-01-28 05:07:05 +04:00
* Returns the locked pointer to the ipc structure if found or NULL
* otherwise . If key is found ipc points to the owning ipc structure
*
* Called with ipc_ids . rwsem held .
2005-04-17 02:20:36 +04:00
*/
2007-10-19 10:40:49 +04:00
static struct kern_ipc_perm * ipc_findkey ( struct ipc_ids * ids , key_t key )
2005-04-17 02:20:36 +04:00
{
2007-10-19 10:40:48 +04:00
struct kern_ipc_perm * ipc ;
int next_id ;
int total ;
2005-04-17 02:20:36 +04:00
2007-10-19 10:40:48 +04:00
for ( total = 0 , next_id = 0 ; total < ids - > in_use ; next_id + + ) {
ipc = idr_find ( & ids - > ipcs_idr , next_id ) ;
if ( ipc = = NULL )
2005-04-17 02:20:36 +04:00
continue ;
2007-10-19 10:40:48 +04:00
if ( ipc - > key ! = key ) {
total + + ;
continue ;
}
2013-09-12 01:26:29 +04:00
rcu_read_lock ( ) ;
ipc_lock_object ( ipc ) ;
2007-10-19 10:40:48 +04:00
return ipc ;
2005-04-17 02:20:36 +04:00
}
2007-10-19 10:40:48 +04:00
return NULL ;
2005-04-17 02:20:36 +04:00
}
2007-10-19 10:40:48 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_get_maxid - get the last assigned id
* @ ids : ipc identifier set
2007-10-19 10:40:48 +04:00
*
2014-01-28 05:07:05 +04:00
* Called with ipc_ids . rwsem held .
2005-04-17 02:20:36 +04:00
*/
2007-10-19 10:40:48 +04:00
int ipc_get_maxid ( struct ipc_ids * ids )
{
struct kern_ipc_perm * ipc ;
int max_id = - 1 ;
int total , id ;
if ( ids - > in_use = = 0 )
return - 1 ;
2005-04-17 02:20:36 +04:00
2007-10-19 10:40:48 +04:00
if ( ids - > in_use = = IPCMNI )
return IPCMNI - 1 ;
/* Look for the last assigned id */
total = 0 ;
for ( id = 0 ; id < IPCMNI & & total < ids - > in_use ; id + + ) {
ipc = idr_find ( & ids - > ipcs_idr , id ) ;
if ( ipc ! = NULL ) {
max_id = id ;
total + + ;
}
}
return max_id ;
2005-04-17 02:20:36 +04:00
}
/**
2014-01-28 05:07:05 +04:00
* ipc_addid - add an ipc identifier
* @ ids : ipc identifier set
* @ new : new ipc permission set
* @ size : limit for the number of used ids
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Add an entry ' new ' to the ipc ids idr . The permissions object is
* initialised and the first free entry is set up and the id assigned
* is returned . The ' new ' entry is returned in a locked state on success .
* On failure the entry is not locked and a negative err - code is returned .
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Called with writer ipc_ids . rwsem held .
2005-04-17 02:20:36 +04:00
*/
2014-01-28 05:07:04 +04:00
int ipc_addid ( struct ipc_ids * ids , struct kern_ipc_perm * new , int size )
2005-04-17 02:20:36 +04:00
{
2012-02-08 04:54:11 +04:00
kuid_t euid ;
kgid_t egid ;
2013-02-28 05:04:53 +04:00
int id ;
2013-01-05 03:34:50 +04:00
int next_id = ids - > next_id ;
2005-04-17 02:20:36 +04:00
2007-10-19 10:40:48 +04:00
if ( size > IPCMNI )
size = IPCMNI ;
if ( ids - > in_use > = size )
2007-10-19 10:40:57 +04:00
return - ENOSPC ;
2007-10-19 10:40:48 +04:00
2013-02-28 05:04:53 +04:00
idr_preload ( GFP_KERNEL ) ;
2008-11-20 02:36:08 +03:00
spin_lock_init ( & new - > lock ) ;
2014-01-28 05:07:02 +04:00
new - > deleted = false ;
2008-11-20 02:36:08 +03:00
rcu_read_lock ( ) ;
spin_lock ( & new - > lock ) ;
2013-02-28 05:04:53 +04:00
id = idr_alloc ( & ids - > ipcs_idr , new ,
( next_id < 0 ) ? 0 : ipcid_to_idx ( next_id ) , 0 ,
GFP_NOWAIT ) ;
idr_preload_end ( ) ;
if ( id < 0 ) {
2008-11-20 02:36:08 +03:00
spin_unlock ( & new - > lock ) ;
rcu_read_unlock ( ) ;
2013-02-28 05:04:53 +04:00
return id ;
2008-11-20 02:36:08 +03:00
}
2007-10-19 10:40:48 +04:00
2005-04-17 02:20:36 +04:00
ids - > in_use + + ;
2008-11-14 02:39:06 +03:00
current_euid_egid ( & euid , & egid ) ;
new - > cuid = new - > uid = euid ;
new - > gid = new - > cgid = egid ;
2005-04-17 02:20:36 +04:00
2013-01-05 03:34:50 +04:00
if ( next_id < 0 ) {
new - > seq = ids - > seq + + ;
2014-01-28 05:07:09 +04:00
if ( ids - > seq > IPCID_SEQ_MAX )
2013-01-05 03:34:50 +04:00
ids - > seq = 0 ;
} else {
new - > seq = ipcid_to_seqx ( next_id ) ;
ids - > next_id = - 1 ;
}
2005-04-17 02:20:36 +04:00
2008-04-29 12:00:35 +04:00
new - > id = ipc_buildid ( id , new - > seq ) ;
2005-04-17 02:20:36 +04:00
return id ;
}
2007-10-19 10:40:49 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipcget_new - create a new ipc object
* @ ns : ipc namespace
2014-09-08 20:27:23 +04:00
* @ ids : ipc identifier set
2014-01-28 05:07:05 +04:00
* @ ops : the actual creation routine to call
* @ params : its parameters
*
* This routine is called by sys_msgget , sys_semget ( ) and sys_shmget ( )
* when the key is IPC_PRIVATE .
2007-10-19 10:40:49 +04:00
*/
2008-02-08 15:18:54 +03:00
static int ipcget_new ( struct ipc_namespace * ns , struct ipc_ids * ids ,
2014-06-07 01:37:36 +04:00
const struct ipc_ops * ops , struct ipc_params * params )
2007-10-19 10:40:49 +04:00
{
int err ;
2013-09-12 01:26:24 +04:00
down_write ( & ids - > rwsem ) ;
2007-10-19 10:40:49 +04:00
err = ops - > getnew ( ns , params ) ;
2013-09-12 01:26:24 +04:00
up_write ( & ids - > rwsem ) ;
2007-10-19 10:40:49 +04:00
return err ;
}
/**
2014-01-28 05:07:05 +04:00
* ipc_check_perms - check security and permissions for an ipc object
* @ ns : ipc namespace
* @ ipcp : ipc permission set
* @ ops : the actual security routine to call
* @ params : its parameters
2007-10-19 10:40:53 +04:00
*
2014-01-28 05:07:05 +04:00
* This routine is called by sys_msgget ( ) , sys_semget ( ) and sys_shmget ( )
* when the key is not IPC_PRIVATE and that key already exists in the
* ds IDR .
2007-10-19 10:40:53 +04:00
*
2014-01-28 05:07:05 +04:00
* On success , the ipc id is returned .
2007-10-19 10:40:53 +04:00
*
2014-01-28 05:07:05 +04:00
* It is called with ipc_ids . rwsem and ipcp - > lock held .
2007-10-19 10:40:49 +04:00
*/
2011-03-24 02:43:24 +03:00
static int ipc_check_perms ( struct ipc_namespace * ns ,
struct kern_ipc_perm * ipcp ,
2014-06-07 01:37:36 +04:00
const struct ipc_ops * ops ,
2011-03-24 02:43:24 +03:00
struct ipc_params * params )
2007-10-19 10:40:49 +04:00
{
int err ;
2011-03-24 02:43:24 +03:00
if ( ipcperms ( ns , ipcp , params - > flg ) )
2007-10-19 10:40:49 +04:00
err = - EACCES ;
else {
err = ops - > associate ( ipcp , params - > flg ) ;
if ( ! err )
err = ipcp - > id ;
}
return err ;
}
/**
2014-01-28 05:07:05 +04:00
* ipcget_public - get an ipc object or create a new one
* @ ns : ipc namespace
2014-09-08 20:27:23 +04:00
* @ ids : ipc identifier set
2014-01-28 05:07:05 +04:00
* @ ops : the actual creation routine to call
* @ params : its parameters
*
* This routine is called by sys_msgget , sys_semget ( ) and sys_shmget ( )
* when the key is not IPC_PRIVATE .
* It adds a new entry if the key is not found and does some permission
* / security checkings if the key is found .
*
* On success , the ipc id is returned .
2007-10-19 10:40:49 +04:00
*/
2008-02-08 15:18:54 +03:00
static int ipcget_public ( struct ipc_namespace * ns , struct ipc_ids * ids ,
2014-06-07 01:37:36 +04:00
const struct ipc_ops * ops , struct ipc_params * params )
2007-10-19 10:40:49 +04:00
{
struct kern_ipc_perm * ipcp ;
int flg = params - > flg ;
int err ;
2007-10-19 10:40:54 +04:00
/*
* Take the lock as a writer since we are potentially going to add
* a new entry + read locks are not " upgradable "
*/
2013-09-12 01:26:24 +04:00
down_write ( & ids - > rwsem ) ;
2007-10-19 10:40:49 +04:00
ipcp = ipc_findkey ( ids , params - > key ) ;
if ( ipcp = = NULL ) {
/* key not used */
if ( ! ( flg & IPC_CREAT ) )
err = - ENOENT ;
else
err = ops - > getnew ( ns , params ) ;
} else {
/* ipc object has been locked by ipc_findkey() */
if ( flg & IPC_CREAT & & flg & IPC_EXCL )
err = - EEXIST ;
else {
err = 0 ;
if ( ops - > more_checks )
err = ops - > more_checks ( ipcp , params ) ;
if ( ! err )
2007-10-19 10:40:53 +04:00
/*
* ipc_check_perms returns the IPC id on
* success
*/
2011-03-24 02:43:24 +03:00
err = ipc_check_perms ( ns , ipcp , ops , params ) ;
2007-10-19 10:40:49 +04:00
}
ipc_unlock ( ipcp ) ;
}
2013-09-12 01:26:24 +04:00
up_write ( & ids - > rwsem ) ;
2007-10-19 10:40:49 +04:00
return err ;
}
2005-04-17 02:20:36 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_rmid - remove an ipc identifier
* @ ids : ipc identifier set
* @ ipcp : ipc perm structure containing the identifier to remove
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* ipc_ids . rwsem ( as a writer ) and the spinlock for this ID are held
* before this function is called , and remain locked on the exit .
2005-04-17 02:20:36 +04:00
*/
2007-10-19 10:40:48 +04:00
void ipc_rmid ( struct ipc_ids * ids , struct kern_ipc_perm * ipcp )
2005-04-17 02:20:36 +04:00
{
2007-10-19 10:40:52 +04:00
int lid = ipcid_to_idx ( ipcp - > id ) ;
2007-10-19 10:40:48 +04:00
idr_remove ( & ids - > ipcs_idr , lid ) ;
2005-04-17 02:20:36 +04:00
ids - > in_use - - ;
2014-01-28 05:07:02 +04:00
ipcp - > deleted = true ;
2005-04-17 02:20:36 +04:00
}
/**
2014-01-28 05:07:05 +04:00
* ipc_alloc - allocate ipc space
* @ size : size desired
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Allocate memory from the appropriate pools and return a pointer to it .
* NULL is returned if the allocation fails
2005-04-17 02:20:36 +04:00
*/
2013-05-01 06:15:44 +04:00
void * ipc_alloc ( int size )
2005-04-17 02:20:36 +04:00
{
2013-05-01 06:15:44 +04:00
void * out ;
2014-01-28 05:07:04 +04:00
if ( size > PAGE_SIZE )
2005-04-17 02:20:36 +04:00
out = vmalloc ( size ) ;
else
out = kmalloc ( size , GFP_KERNEL ) ;
return out ;
}
/**
2014-01-28 05:07:05 +04:00
* ipc_free - free ipc space
* @ ptr : pointer returned by ipc_alloc
* @ size : size of block
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Free a block created with ipc_alloc ( ) . The caller must know the size
* used in the allocation call .
2005-04-17 02:20:36 +04:00
*/
2014-01-28 05:07:04 +04:00
void ipc_free ( void * ptr , int size )
2005-04-17 02:20:36 +04:00
{
2014-01-28 05:07:04 +04:00
if ( size > PAGE_SIZE )
2005-04-17 02:20:36 +04:00
vfree ( ptr ) ;
else
kfree ( ptr ) ;
}
/**
2014-01-28 05:07:05 +04:00
* ipc_rcu_alloc - allocate ipc and rcu space
* @ size : size desired
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Allocate memory for the rcu header structure + the object .
* Returns the pointer to the object or NULL upon failure .
2005-04-17 02:20:36 +04:00
*/
2013-05-01 06:15:44 +04:00
void * ipc_rcu_alloc ( int size )
2005-04-17 02:20:36 +04:00
{
2013-05-01 06:15:44 +04:00
/*
2013-04-29 20:42:09 +04:00
* We prepend the allocation with the rcu struct
2005-04-17 02:20:36 +04:00
*/
2013-04-29 20:42:09 +04:00
struct ipc_rcu * out = ipc_alloc ( sizeof ( struct ipc_rcu ) + size ) ;
if ( unlikely ( ! out ) )
return NULL ;
atomic_set ( & out - > refcount , 1 ) ;
2013-07-09 03:01:20 +04:00
return out + 1 ;
2005-04-17 02:20:36 +04:00
}
2013-05-01 06:15:44 +04:00
int ipc_rcu_getref ( void * ptr )
2005-04-17 02:20:36 +04:00
{
2013-07-09 03:01:20 +04:00
struct ipc_rcu * p = ( ( struct ipc_rcu * ) ptr ) - 1 ;
return atomic_inc_not_zero ( & p - > refcount ) ;
2006-11-22 17:55:48 +03:00
}
ipc: fix race with LSMs
Currently, IPC mechanisms do security and auditing related checks under
RCU. However, since security modules can free the security structure,
for example, through selinux_[sem,msg_queue,shm]_free_security(), we can
race if the structure is freed before other tasks are done with it,
creating a use-after-free condition. Manfred illustrates this nicely,
for instance with shared mem and selinux:
-> do_shmat calls rcu_read_lock()
-> do_shmat calls shm_object_check().
Checks that the object is still valid - but doesn't acquire any locks.
Then it returns.
-> do_shmat calls security_shm_shmat (e.g. selinux_shm_shmat)
-> selinux_shm_shmat calls ipc_has_perm()
-> ipc_has_perm accesses ipc_perms->security
shm_close()
-> shm_close acquires rw_mutex & shm_lock
-> shm_close calls shm_destroy
-> shm_destroy calls security_shm_free (e.g. selinux_shm_free_security)
-> selinux_shm_free_security calls ipc_free_security(&shp->shm_perm)
-> ipc_free_security calls kfree(ipc_perms->security)
This patch delays the freeing of the security structures after all RCU
readers are done. Furthermore it aligns the security life cycle with
that of the rest of IPC - freeing them based on the reference counter.
For situations where we need not free security, the current behavior is
kept. Linus states:
"... the old behavior was suspect for another reason too: having the
security blob go away from under a user sounds like it could cause
various other problems anyway, so I think the old code was at least
_prone_ to bugs even if it didn't have catastrophic behavior."
I have tested this patch with IPC testcases from LTP on both my
quad-core laptop and on a 64 core NUMA server. In both cases selinux is
enabled, and tests pass for both voluntary and forced preemption models.
While the mentioned races are theoretical (at least no one as reported
them), I wanted to make sure that this new logic doesn't break anything
we weren't aware of.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Acked-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-09-24 04:04:45 +04:00
void ipc_rcu_putref ( void * ptr , void ( * func ) ( struct rcu_head * head ) )
2005-04-17 02:20:36 +04:00
{
2013-07-09 03:01:20 +04:00
struct ipc_rcu * p = ( ( struct ipc_rcu * ) ptr ) - 1 ;
2013-04-29 20:42:09 +04:00
if ( ! atomic_dec_and_test ( & p - > refcount ) )
2005-04-17 02:20:36 +04:00
return ;
ipc: fix race with LSMs
Currently, IPC mechanisms do security and auditing related checks under
RCU. However, since security modules can free the security structure,
for example, through selinux_[sem,msg_queue,shm]_free_security(), we can
race if the structure is freed before other tasks are done with it,
creating a use-after-free condition. Manfred illustrates this nicely,
for instance with shared mem and selinux:
-> do_shmat calls rcu_read_lock()
-> do_shmat calls shm_object_check().
Checks that the object is still valid - but doesn't acquire any locks.
Then it returns.
-> do_shmat calls security_shm_shmat (e.g. selinux_shm_shmat)
-> selinux_shm_shmat calls ipc_has_perm()
-> ipc_has_perm accesses ipc_perms->security
shm_close()
-> shm_close acquires rw_mutex & shm_lock
-> shm_close calls shm_destroy
-> shm_destroy calls security_shm_free (e.g. selinux_shm_free_security)
-> selinux_shm_free_security calls ipc_free_security(&shp->shm_perm)
-> ipc_free_security calls kfree(ipc_perms->security)
This patch delays the freeing of the security structures after all RCU
readers are done. Furthermore it aligns the security life cycle with
that of the rest of IPC - freeing them based on the reference counter.
For situations where we need not free security, the current behavior is
kept. Linus states:
"... the old behavior was suspect for another reason too: having the
security blob go away from under a user sounds like it could cause
various other problems anyway, so I think the old code was at least
_prone_ to bugs even if it didn't have catastrophic behavior."
I have tested this patch with IPC testcases from LTP on both my
quad-core laptop and on a 64 core NUMA server. In both cases selinux is
enabled, and tests pass for both voluntary and forced preemption models.
While the mentioned races are theoretical (at least no one as reported
them), I wanted to make sure that this new logic doesn't break anything
we weren't aware of.
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Acked-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-09-24 04:04:45 +04:00
call_rcu ( & p - > rcu , func ) ;
}
void ipc_rcu_free ( struct rcu_head * head )
{
struct ipc_rcu * p = container_of ( head , struct ipc_rcu , rcu ) ;
if ( is_vmalloc_addr ( p ) )
vfree ( p ) ;
else
kfree ( p ) ;
2005-04-17 02:20:36 +04:00
}
/**
2014-01-28 05:07:05 +04:00
* ipcperms - check ipc permissions
* @ ns : ipc namespace
* @ ipcp : ipc permission set
* @ flag : desired permission set
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Check user , group , other permissions for access
* to ipc resources . return 0 if allowed
2011-03-24 02:43:24 +03:00
*
2014-01-28 05:07:05 +04:00
* @ flag will most probably be 0 or S_ . . . UGO from < linux / stat . h >
2005-04-17 02:20:36 +04:00
*/
2011-03-24 02:43:24 +03:00
int ipcperms ( struct ipc_namespace * ns , struct kern_ipc_perm * ipcp , short flag )
{
2012-02-08 04:54:11 +04:00
kuid_t euid = current_euid ( ) ;
2008-12-10 11:40:06 +03:00
int requested_mode , granted_mode ;
2005-04-17 02:20:36 +04:00
2008-12-10 11:40:06 +03:00
audit_ipc_obj ( ipcp ) ;
2005-04-17 02:20:36 +04:00
requested_mode = ( flag > > 6 ) | ( flag > > 3 ) | flag ;
granted_mode = ipcp - > mode ;
2012-02-08 04:54:11 +04:00
if ( uid_eq ( euid , ipcp - > cuid ) | |
uid_eq ( euid , ipcp - > uid ) )
2005-04-17 02:20:36 +04:00
granted_mode > > = 6 ;
else if ( in_group_p ( ipcp - > cgid ) | | in_group_p ( ipcp - > gid ) )
granted_mode > > = 3 ;
/* is there some bit set in requested_mode but not in granted_mode? */
2014-06-07 01:37:37 +04:00
if ( ( requested_mode & ~ granted_mode & 0007 ) & &
2011-03-24 02:43:24 +03:00
! ns_capable ( ns - > user_ns , CAP_IPC_OWNER ) )
2005-04-17 02:20:36 +04:00
return - 1 ;
return security_ipc_permission ( ipcp , flag ) ;
}
/*
* Functions to convert between the kern_ipc_perm structure and the
* old / new ipc_perm structures
*/
/**
2014-01-28 05:07:05 +04:00
* kernel_to_ipc64_perm - convert kernel ipc permissions to user
* @ in : kernel permissions
* @ out : new style ipc permissions
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Turn the kernel object @ in into a set of permissions descriptions
* for returning to userspace ( @ out ) .
2005-04-17 02:20:36 +04:00
*/
2014-01-28 05:07:04 +04:00
void kernel_to_ipc64_perm ( struct kern_ipc_perm * in , struct ipc64_perm * out )
2005-04-17 02:20:36 +04:00
{
out - > key = in - > key ;
2012-02-08 04:54:11 +04:00
out - > uid = from_kuid_munged ( current_user_ns ( ) , in - > uid ) ;
out - > gid = from_kgid_munged ( current_user_ns ( ) , in - > gid ) ;
out - > cuid = from_kuid_munged ( current_user_ns ( ) , in - > cuid ) ;
out - > cgid = from_kgid_munged ( current_user_ns ( ) , in - > cgid ) ;
2005-04-17 02:20:36 +04:00
out - > mode = in - > mode ;
out - > seq = in - > seq ;
}
/**
2014-01-28 05:07:05 +04:00
* ipc64_perm_to_ipc_perm - convert new ipc permissions to old
* @ in : new style ipc permissions
* @ out : old style ipc permissions
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Turn the new style permissions object @ in into a compatibility
* object and store it into the @ out pointer .
2005-04-17 02:20:36 +04:00
*/
2014-01-28 05:07:04 +04:00
void ipc64_perm_to_ipc_perm ( struct ipc64_perm * in , struct ipc_perm * out )
2005-04-17 02:20:36 +04:00
{
out - > key = in - > key ;
SET_UID ( out - > uid , in - > uid ) ;
SET_GID ( out - > gid , in - > gid ) ;
SET_UID ( out - > cuid , in - > cuid ) ;
SET_GID ( out - > cgid , in - > cgid ) ;
out - > mode = in - > mode ;
out - > seq = in - > seq ;
}
2013-05-01 06:15:19 +04:00
/**
* ipc_obtain_object
* @ ids : ipc identifier set
* @ id : ipc id to look for
*
* Look for an id in the ipc ids idr and return associated ipc object .
*
* Call inside the RCU critical section .
* The ipc object is * not * locked on exit .
*/
struct kern_ipc_perm * ipc_obtain_object ( struct ipc_ids * ids , int id )
{
struct kern_ipc_perm * out ;
int lid = ipcid_to_idx ( id ) ;
out = idr_find ( & ids - > ipcs_idr , lid ) ;
if ( ! out )
return ERR_PTR ( - EINVAL ) ;
return out ;
}
2007-10-19 10:40:53 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_lock - lock an ipc structure without rwsem held
* @ ids : ipc identifier set
2007-10-19 10:40:53 +04:00
* @ id : ipc id to look for
*
* Look for an id in the ipc ids idr and lock the associated ipc object .
*
2013-05-01 06:15:19 +04:00
* The ipc object is locked on successful exit .
2007-10-19 10:40:53 +04:00
*/
2007-10-19 10:40:48 +04:00
struct kern_ipc_perm * ipc_lock ( struct ipc_ids * ids , int id )
2005-04-17 02:20:36 +04:00
{
2007-10-19 10:40:48 +04:00
struct kern_ipc_perm * out ;
2005-04-17 02:20:36 +04:00
rcu_read_lock ( ) ;
2013-05-01 06:15:19 +04:00
out = ipc_obtain_object ( ids , id ) ;
if ( IS_ERR ( out ) )
goto err1 ;
2007-10-19 10:40:48 +04:00
2005-04-17 02:20:36 +04:00
spin_lock ( & out - > lock ) ;
2013-05-01 06:15:19 +04:00
2005-04-17 02:20:36 +04:00
/* ipc_rmid() may have already freed the ID while ipc_lock
* was spinning : here verify that the structure is still valid
*/
2014-01-28 05:07:02 +04:00
if ( ipc_valid_object ( out ) )
2013-05-01 06:15:19 +04:00
return out ;
spin_unlock ( & out - > lock ) ;
out = ERR_PTR ( - EINVAL ) ;
err1 :
rcu_read_unlock ( ) ;
return out ;
}
2007-10-19 10:40:48 +04:00
2013-05-01 06:15:19 +04:00
/**
* ipc_obtain_object_check
* @ ids : ipc identifier set
* @ id : ipc id to look for
*
* Similar to ipc_obtain_object ( ) but also checks
* the ipc object reference counter .
*
* Call inside the RCU critical section .
* The ipc object is * not * locked on exit .
*/
struct kern_ipc_perm * ipc_obtain_object_check ( struct ipc_ids * ids , int id )
{
struct kern_ipc_perm * out = ipc_obtain_object ( ids , id ) ;
if ( IS_ERR ( out ) )
goto out ;
if ( ipc_checkid ( out , id ) )
return ERR_PTR ( - EIDRM ) ;
out :
2005-04-17 02:20:36 +04:00
return out ;
}
2008-02-08 15:18:54 +03:00
/**
* ipcget - Common sys_ * get ( ) code
2014-09-08 20:27:23 +04:00
* @ ns : namespace
2014-01-28 05:07:05 +04:00
* @ ids : ipc identifier set
* @ ops : operations to be called on ipc object creation , permission checks
* and further checks
* @ params : the parameters needed by the previous operations .
2008-02-08 15:18:54 +03:00
*
* Common routine called by sys_msgget ( ) , sys_semget ( ) and sys_shmget ( ) .
*/
int ipcget ( struct ipc_namespace * ns , struct ipc_ids * ids ,
2014-06-07 01:37:36 +04:00
const struct ipc_ops * ops , struct ipc_params * params )
2008-02-08 15:18:54 +03:00
{
if ( params - > key = = IPC_PRIVATE )
return ipcget_new ( ns , ids , ops , params ) ;
else
return ipcget_public ( ns , ids , ops , params ) ;
}
2008-04-29 12:00:51 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_update_perm - update the permissions of an ipc object
2008-04-29 12:00:51 +04:00
* @ in : the permission given as input .
* @ out : the permission of the ipc to set .
*/
2012-02-08 04:54:11 +04:00
int ipc_update_perm ( struct ipc64_perm * in , struct kern_ipc_perm * out )
2008-04-29 12:00:51 +04:00
{
2012-02-08 04:54:11 +04:00
kuid_t uid = make_kuid ( current_user_ns ( ) , in - > uid ) ;
kgid_t gid = make_kgid ( current_user_ns ( ) , in - > gid ) ;
if ( ! uid_valid ( uid ) | | ! gid_valid ( gid ) )
return - EINVAL ;
out - > uid = uid ;
out - > gid = gid ;
2008-04-29 12:00:51 +04:00
out - > mode = ( out - > mode & ~ S_IRWXUGO )
| ( in - > mode & S_IRWXUGO ) ;
2012-02-08 04:54:11 +04:00
return 0 ;
2008-04-29 12:00:51 +04:00
}
2008-04-29 12:00:54 +04:00
/**
2013-09-12 01:26:17 +04:00
* ipcctl_pre_down_nolock - retrieve an ipc and check permissions for some IPC_XXX cmd
2014-01-28 05:07:05 +04:00
* @ ns : ipc namespace
2008-04-29 12:00:54 +04:00
* @ ids : the table of ids where to look for the ipc
* @ id : the id of the ipc to retrieve
* @ cmd : the cmd to check
* @ perm : the permission to set
* @ extra_perm : one extra permission parameter used by msq
*
* This function does some common audit and permissions check for some IPC_XXX
* cmd and is called from semctl_down , shmctl_down and msgctl_down .
* It must be called without any lock held and
* - retrieves the ipc with the given id in the given table .
* - performs some audit and permission check , depending on the given cmd
2013-09-12 01:26:17 +04:00
* - returns a pointer to the ipc object or otherwise , the corresponding error .
2013-07-09 03:01:12 +04:00
*
2013-09-12 01:26:24 +04:00
* Call holding the both the rwsem and the rcu read lock .
2008-04-29 12:00:54 +04:00
*/
2013-05-01 06:15:24 +04:00
struct kern_ipc_perm * ipcctl_pre_down_nolock ( struct ipc_namespace * ns ,
2013-09-12 01:26:17 +04:00
struct ipc_ids * ids , int id , int cmd ,
struct ipc64_perm * perm , int extra_perm )
2013-05-01 06:15:24 +04:00
{
2012-02-08 04:54:11 +04:00
kuid_t euid ;
2013-05-01 06:15:24 +04:00
int err = - EPERM ;
struct kern_ipc_perm * ipcp ;
2008-04-29 12:00:54 +04:00
2013-05-01 06:15:24 +04:00
ipcp = ipc_obtain_object_check ( ids , id ) ;
2008-04-29 12:00:54 +04:00
if ( IS_ERR ( ipcp ) ) {
err = PTR_ERR ( ipcp ) ;
2013-07-09 03:01:12 +04:00
goto err ;
2008-04-29 12:00:54 +04:00
}
2008-12-10 11:40:06 +03:00
audit_ipc_obj ( ipcp ) ;
2008-12-10 11:47:15 +03:00
if ( cmd = = IPC_SET )
audit_ipc_set_perm ( extra_perm , perm - > uid ,
2013-05-01 06:15:24 +04:00
perm - > gid , perm - > mode ) ;
2008-11-14 02:39:06 +03:00
euid = current_euid ( ) ;
2012-02-08 04:54:11 +04:00
if ( uid_eq ( euid , ipcp - > cuid ) | | uid_eq ( euid , ipcp - > uid ) | |
2011-03-24 02:43:24 +03:00
ns_capable ( ns - > user_ns , CAP_SYS_ADMIN ) )
2013-07-09 03:01:12 +04:00
return ipcp ; /* successful lookup */
err :
2008-04-29 12:00:54 +04:00
return ERR_PTR ( err ) ;
}
2012-07-31 01:42:46 +04:00
# ifdef CONFIG_ARCH_WANT_IPC_PARSE_VERSION
2005-04-17 02:20:36 +04:00
/**
2014-01-28 05:07:05 +04:00
* ipc_parse_version - ipc call version
* @ cmd : pointer to command
2005-04-17 02:20:36 +04:00
*
2014-01-28 05:07:05 +04:00
* Return IPC_64 for new style IPC and IPC_OLD for old style IPC .
* The @ cmd value is turned from an encoding command and version into
* just the command code .
2005-04-17 02:20:36 +04:00
*/
2014-01-28 05:07:04 +04:00
int ipc_parse_version ( int * cmd )
2005-04-17 02:20:36 +04:00
{
if ( * cmd & IPC_64 ) {
* cmd ^ = IPC_64 ;
return IPC_64 ;
} else {
return IPC_OLD ;
}
}
2012-07-31 01:42:46 +04:00
# endif /* CONFIG_ARCH_WANT_IPC_PARSE_VERSION */
2005-09-07 02:17:09 +04:00
# ifdef CONFIG_PROC_FS
2007-02-12 11:52:10 +03:00
struct ipc_proc_iter {
struct ipc_namespace * ns ;
struct ipc_proc_iface * iface ;
} ;
2007-10-19 10:40:48 +04:00
/*
* This routine locks the ipc structure found at least at position pos .
*/
2008-02-06 12:36:28 +03:00
static struct kern_ipc_perm * sysvipc_find_ipc ( struct ipc_ids * ids , loff_t pos ,
loff_t * new_pos )
2005-09-07 02:17:09 +04:00
{
2007-10-19 10:40:48 +04:00
struct kern_ipc_perm * ipc ;
int total , id ;
2006-10-02 13:18:20 +04:00
2007-10-19 10:40:48 +04:00
total = 0 ;
for ( id = 0 ; id < pos & & total < ids - > in_use ; id + + ) {
ipc = idr_find ( & ids - > ipcs_idr , id ) ;
if ( ipc ! = NULL )
total + + ;
}
2005-09-07 02:17:09 +04:00
2007-10-19 10:40:48 +04:00
if ( total > = ids - > in_use )
return NULL ;
2005-09-07 02:17:09 +04:00
2014-01-28 05:07:04 +04:00
for ( ; pos < IPCMNI ; pos + + ) {
2007-10-19 10:40:48 +04:00
ipc = idr_find ( & ids - > ipcs_idr , pos ) ;
if ( ipc ! = NULL ) {
* new_pos = pos + 1 ;
2013-09-12 01:26:29 +04:00
rcu_read_lock ( ) ;
ipc_lock_object ( ipc ) ;
2005-09-07 02:17:09 +04:00
return ipc ;
}
}
/* Out of range - return NULL to terminate iteration */
return NULL ;
}
2007-10-19 10:40:48 +04:00
static void * sysvipc_proc_next ( struct seq_file * s , void * it , loff_t * pos )
{
struct ipc_proc_iter * iter = s - > private ;
struct ipc_proc_iface * iface = iter - > iface ;
struct kern_ipc_perm * ipc = it ;
/* If we had an ipc id locked before, unlock it */
if ( ipc & & ipc ! = SEQ_START_TOKEN )
ipc_unlock ( ipc ) ;
2008-02-08 15:18:57 +03:00
return sysvipc_find_ipc ( & iter - > ns - > ids [ iface - > ids ] , * pos , pos ) ;
2007-10-19 10:40:48 +04:00
}
2005-09-07 02:17:09 +04:00
/*
2007-10-19 10:40:53 +04:00
* File positions : pos 0 - > header , pos n - > ipc id = n - 1.
* SeqFile iterator : iterator value locked ipc pointer or SEQ_TOKEN_START .
2005-09-07 02:17:09 +04:00
*/
static void * sysvipc_proc_start ( struct seq_file * s , loff_t * pos )
{
2007-02-12 11:52:10 +03:00
struct ipc_proc_iter * iter = s - > private ;
struct ipc_proc_iface * iface = iter - > iface ;
2006-10-02 13:18:20 +04:00
struct ipc_ids * ids ;
2008-02-08 15:18:57 +03:00
ids = & iter - > ns - > ids [ iface - > ids ] ;
2005-09-07 02:17:09 +04:00
/*
* Take the lock - this will be released by the corresponding
* call to stop ( ) .
*/
2013-09-12 01:26:24 +04:00
down_read ( & ids - > rwsem ) ;
2005-09-07 02:17:09 +04:00
/* pos < 0 is invalid */
if ( * pos < 0 )
return NULL ;
/* pos == 0 means header */
if ( * pos = = 0 )
return SEQ_START_TOKEN ;
/* Find the (pos-1)th ipc */
2007-10-19 10:40:48 +04:00
return sysvipc_find_ipc ( ids , * pos - 1 , pos ) ;
2005-09-07 02:17:09 +04:00
}
static void sysvipc_proc_stop ( struct seq_file * s , void * it )
{
struct kern_ipc_perm * ipc = it ;
2007-02-12 11:52:10 +03:00
struct ipc_proc_iter * iter = s - > private ;
struct ipc_proc_iface * iface = iter - > iface ;
2006-10-02 13:18:20 +04:00
struct ipc_ids * ids ;
2005-09-07 02:17:09 +04:00
2007-10-19 10:40:53 +04:00
/* If we had a locked structure, release it */
2005-09-07 02:17:09 +04:00
if ( ipc & & ipc ! = SEQ_START_TOKEN )
ipc_unlock ( ipc ) ;
2008-02-08 15:18:57 +03:00
ids = & iter - > ns - > ids [ iface - > ids ] ;
2005-09-07 02:17:09 +04:00
/* Release the lock we took in start() */
2013-09-12 01:26:24 +04:00
up_read ( & ids - > rwsem ) ;
2005-09-07 02:17:09 +04:00
}
static int sysvipc_proc_show ( struct seq_file * s , void * it )
{
2007-02-12 11:52:10 +03:00
struct ipc_proc_iter * iter = s - > private ;
struct ipc_proc_iface * iface = iter - > iface ;
2005-09-07 02:17:09 +04:00
2015-04-16 02:17:54 +03:00
if ( it = = SEQ_START_TOKEN ) {
seq_puts ( s , iface - > header ) ;
return 0 ;
}
2005-09-07 02:17:09 +04:00
return iface - > show ( s , it ) ;
}
2009-09-23 03:43:43 +04:00
static const struct seq_operations sysvipc_proc_seqops = {
2005-09-07 02:17:09 +04:00
. start = sysvipc_proc_start ,
. stop = sysvipc_proc_stop ,
. next = sysvipc_proc_next ,
. show = sysvipc_proc_show ,
} ;
2007-02-12 11:52:10 +03:00
static int sysvipc_proc_open ( struct inode * inode , struct file * file )
{
struct ipc_proc_iter * iter ;
2014-10-14 02:54:14 +04:00
iter = __seq_open_private ( file , & sysvipc_proc_seqops , sizeof ( * iter ) ) ;
2007-02-12 11:52:10 +03:00
if ( ! iter )
2014-10-14 02:54:14 +04:00
return - ENOMEM ;
2007-02-12 11:52:10 +03:00
2013-04-01 02:16:14 +04:00
iter - > iface = PDE_DATA ( inode ) ;
2007-02-12 11:52:10 +03:00
iter - > ns = get_ipc_ns ( current - > nsproxy - > ipc_ns ) ;
2014-10-14 02:54:14 +04:00
return 0 ;
2007-02-12 11:52:10 +03:00
}
static int sysvipc_proc_release ( struct inode * inode , struct file * file )
{
struct seq_file * seq = file - > private_data ;
struct ipc_proc_iter * iter = seq - > private ;
put_ipc_ns ( iter - > ns ) ;
return seq_release_private ( inode , file ) ;
2005-09-07 02:17:09 +04:00
}
2007-02-12 11:55:35 +03:00
static const struct file_operations sysvipc_proc_fops = {
2005-09-07 02:17:09 +04:00
. open = sysvipc_proc_open ,
. read = seq_read ,
. llseek = seq_lseek ,
2007-02-12 11:52:10 +03:00
. release = sysvipc_proc_release ,
2005-09-07 02:17:09 +04:00
} ;
# endif /* CONFIG_PROC_FS */