2021-12-06 12:26:12 -05:00
/* SPDX-License-Identifier: GPL-2.0 OR MIT */
/*
2023-01-30 22:35:37 -05:00
* Copyright 2021 - 2023 VMware , Inc .
2021-12-06 12:26:12 -05:00
*
* Permission is hereby granted , free of charge , to any person
* obtaining a copy of this software and associated documentation
* files ( the " Software " ) , to deal in the Software without
* restriction , including without limitation the rights to use , copy ,
* modify , merge , publish , distribute , sublicense , and / or sell copies
* of the Software , and to permit persons to whom the Software is
* furnished to do so , subject to the following conditions :
*
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software .
*
* THE SOFTWARE IS PROVIDED " AS IS " , WITHOUT WARRANTY OF ANY KIND ,
* EXPRESS OR IMPLIED , INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY , FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT . IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
* BE LIABLE FOR ANY CLAIM , DAMAGES OR OTHER LIABILITY , WHETHER IN AN
* ACTION OF CONTRACT , TORT OR OTHERWISE , ARISING FROM , OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE .
*
*/
2023-01-30 22:35:37 -05:00
# include "vmwgfx_bo.h"
2021-12-06 12:26:12 -05:00
# include "vmwgfx_drv.h"
# include "drm/drm_prime.h"
# include "drm/drm_gem_ttm_helper.h"
static void vmw_gem_object_free ( struct drm_gem_object * gobj )
{
struct ttm_buffer_object * bo = drm_gem_ttm_of_gem ( gobj ) ;
2023-01-30 22:35:42 -05:00
if ( bo )
2021-12-06 12:26:12 -05:00
ttm_bo_put ( bo ) ;
}
static int vmw_gem_object_open ( struct drm_gem_object * obj ,
struct drm_file * file_priv )
{
return 0 ;
}
static void vmw_gem_object_close ( struct drm_gem_object * obj ,
struct drm_file * file_priv )
{
}
static int vmw_gem_pin_private ( struct drm_gem_object * obj , bool do_pin )
{
struct ttm_buffer_object * bo = drm_gem_ttm_of_gem ( obj ) ;
2023-01-30 22:35:37 -05:00
struct vmw_bo * vbo = to_vmw_bo ( obj ) ;
2021-12-06 12:26:12 -05:00
int ret ;
ret = ttm_bo_reserve ( bo , false , false , NULL ) ;
if ( unlikely ( ret ! = 0 ) )
goto err ;
vmw_bo_pin_reserved ( vbo , do_pin ) ;
ttm_bo_unreserve ( bo ) ;
err :
return ret ;
}
static int vmw_gem_object_pin ( struct drm_gem_object * obj )
{
return vmw_gem_pin_private ( obj , true ) ;
}
static void vmw_gem_object_unpin ( struct drm_gem_object * obj )
{
vmw_gem_pin_private ( obj , false ) ;
}
static struct sg_table * vmw_gem_object_get_sg_table ( struct drm_gem_object * obj )
{
struct ttm_buffer_object * bo = drm_gem_ttm_of_gem ( obj ) ;
struct vmw_ttm_tt * vmw_tt =
container_of ( bo - > ttm , struct vmw_ttm_tt , dma_ttm ) ;
if ( vmw_tt - > vsgt . sgt )
return vmw_tt - > vsgt . sgt ;
return drm_prime_pages_to_sg ( obj - > dev , vmw_tt - > dma_ttm . pages , vmw_tt - > dma_ttm . num_pages ) ;
}
2023-01-30 22:35:35 -05:00
static const struct vm_operations_struct vmw_vm_ops = {
. pfn_mkwrite = vmw_bo_vm_mkwrite ,
. page_mkwrite = vmw_bo_vm_mkwrite ,
. fault = vmw_bo_vm_fault ,
. open = ttm_bo_vm_open ,
. close = ttm_bo_vm_close ,
} ;
2021-12-06 12:26:12 -05:00
static const struct drm_gem_object_funcs vmw_gem_object_funcs = {
. free = vmw_gem_object_free ,
. open = vmw_gem_object_open ,
. close = vmw_gem_object_close ,
. print_info = drm_gem_ttm_print_info ,
. pin = vmw_gem_object_pin ,
. unpin = vmw_gem_object_unpin ,
. get_sg_table = vmw_gem_object_get_sg_table ,
. vmap = drm_gem_ttm_vmap ,
. vunmap = drm_gem_ttm_vunmap ,
. mmap = drm_gem_ttm_mmap ,
2023-01-30 22:35:35 -05:00
. vm_ops = & vmw_vm_ops ,
2021-12-06 12:26:12 -05:00
} ;
2023-09-28 00:13:55 -04:00
int vmw_gem_object_create ( struct vmw_private * vmw ,
struct vmw_bo_params * params ,
struct vmw_bo * * p_vbo )
{
int ret = vmw_bo_create ( vmw , params , p_vbo ) ;
if ( ret ! = 0 )
goto out_no_bo ;
( * p_vbo ) - > tbo . base . funcs = & vmw_gem_object_funcs ;
out_no_bo :
return ret ;
}
2021-12-06 12:26:12 -05:00
int vmw_gem_object_create_with_handle ( struct vmw_private * dev_priv ,
struct drm_file * filp ,
uint32_t size ,
uint32_t * handle ,
2023-01-30 22:35:37 -05:00
struct vmw_bo * * p_vbo )
2021-12-06 12:26:12 -05:00
{
int ret ;
2023-01-30 22:35:42 -05:00
struct vmw_bo_params params = {
. domain = ( dev_priv - > has_mob ) ? VMW_BO_DOMAIN_SYS : VMW_BO_DOMAIN_VRAM ,
. busy_domain = VMW_BO_DOMAIN_SYS ,
. bo_type = ttm_bo_type_device ,
. size = size ,
. pin = false
} ;
2021-12-06 12:26:12 -05:00
2023-09-28 00:13:55 -04:00
ret = vmw_gem_object_create ( dev_priv , & params , p_vbo ) ;
2021-12-06 12:26:12 -05:00
if ( ret ! = 0 )
goto out_no_bo ;
2023-01-30 22:35:42 -05:00
ret = drm_gem_handle_create ( filp , & ( * p_vbo ) - > tbo . base , handle ) ;
2021-12-06 12:26:12 -05:00
out_no_bo :
return ret ;
}
int vmw_gem_object_create_ioctl ( struct drm_device * dev , void * data ,
struct drm_file * filp )
{
struct vmw_private * dev_priv = vmw_priv ( dev ) ;
union drm_vmw_alloc_dmabuf_arg * arg =
( union drm_vmw_alloc_dmabuf_arg * ) data ;
struct drm_vmw_alloc_dmabuf_req * req = & arg - > req ;
struct drm_vmw_dmabuf_rep * rep = & arg - > rep ;
2023-01-30 22:35:37 -05:00
struct vmw_bo * vbo ;
2021-12-06 12:26:12 -05:00
uint32_t handle ;
int ret ;
ret = vmw_gem_object_create_with_handle ( dev_priv , filp ,
req - > size , & handle , & vbo ) ;
if ( ret )
goto out_no_bo ;
rep - > handle = handle ;
2023-01-30 22:35:42 -05:00
rep - > map_handle = drm_vma_node_offset_addr ( & vbo - > tbo . base . vma_node ) ;
2021-12-06 12:26:12 -05:00
rep - > cur_gmr_id = handle ;
rep - > cur_gmr_offset = 0 ;
2023-02-11 00:05:14 -05:00
/* drop reference from allocate - handle holds it now */
drm_gem_object_put ( & vbo - > tbo . base ) ;
2021-12-06 12:26:12 -05:00
out_no_bo :
return ret ;
}
# if defined(CONFIG_DEBUG_FS)
2023-01-30 22:35:37 -05:00
static void vmw_bo_print_info ( int id , struct vmw_bo * bo , struct seq_file * m )
2021-12-06 12:26:12 -05:00
{
const char * placement ;
const char * type ;
2023-01-30 22:35:42 -05:00
switch ( bo - > tbo . resource - > mem_type ) {
2021-12-06 12:26:12 -05:00
case TTM_PL_SYSTEM :
placement = " CPU " ;
break ;
case VMW_PL_GMR :
placement = " GMR " ;
break ;
case VMW_PL_MOB :
placement = " MOB " ;
break ;
case VMW_PL_SYSTEM :
placement = " VCPU " ;
break ;
case TTM_PL_VRAM :
placement = " VRAM " ;
break ;
default :
placement = " None " ;
break ;
}
2023-01-30 22:35:42 -05:00
switch ( bo - > tbo . type ) {
2021-12-06 12:26:12 -05:00
case ttm_bo_type_device :
type = " device " ;
break ;
case ttm_bo_type_kernel :
type = " kernel " ;
break ;
case ttm_bo_type_sg :
type = " sg " ;
break ;
default :
type = " none " ;
break ;
}
2021-12-15 13:41:45 -05:00
seq_printf ( m , " \t \t 0x%08x: %12zu bytes %s, type = %s " ,
2023-01-30 22:35:42 -05:00
id , bo - > tbo . base . size , placement , type ) ;
2021-12-06 12:26:12 -05:00
seq_printf ( m , " , priority = %u, pin_count = %u, GEM refs = %d, TTM refs = %d " ,
2023-01-30 22:35:42 -05:00
bo - > tbo . priority ,
bo - > tbo . pin_count ,
kref_read ( & bo - > tbo . base . refcount ) ,
kref_read ( & bo - > tbo . kref ) ) ;
2021-12-06 12:26:12 -05:00
seq_puts ( m , " \n " ) ;
}
static int vmw_debugfs_gem_info_show ( struct seq_file * m , void * unused )
{
struct vmw_private * vdev = ( struct vmw_private * ) m - > private ;
struct drm_device * dev = & vdev - > drm ;
struct drm_file * file ;
int r ;
r = mutex_lock_interruptible ( & dev - > filelist_mutex ) ;
if ( r )
return r ;
list_for_each_entry ( file , & dev - > filelist , lhead ) {
struct task_struct * task ;
struct drm_gem_object * gobj ;
drm: Update file owner during use
With the typical model where the display server opens the file descriptor
and then hands it over to the client(*), we were showing stale data in
debugfs.
Fix it by updating the drm_file->pid on ioctl access from a different
process.
The field is also made RCU protected to allow for lockless readers. Update
side is protected with dev->filelist_mutex.
Before:
$ cat /sys/kernel/debug/dri/0/clients
command pid dev master a uid magic
Xorg 2344 0 y y 0 0
Xorg 2344 0 n y 0 2
Xorg 2344 0 n y 0 3
Xorg 2344 0 n y 0 4
After:
$ cat /sys/kernel/debug/dri/0/clients
command tgid dev master a uid magic
Xorg 830 0 y y 0 0
xfce4-session 880 0 n y 0 1
xfwm4 943 0 n y 0 2
neverball 1095 0 n y 0 3
*)
More detailed and historically accurate description of various handover
implementation kindly provided by Emil Velikov:
"""
The traditional model, the server was the orchestrator managing the
primary device node. From the fd, to the master status and
authentication. But looking at the fd alone, this has varied across
the years.
IIRC in the DRI1 days, Xorg (libdrm really) would have a list of open
fd(s) and reuse those whenever needed, DRI2 the client was responsible
for open() themselves and with DRI3 the fd was passed to the client.
Around the inception of DRI3 and systemd-logind, the latter became
another possible orchestrator. Whereby Xorg and Wayland compositors
could ask it for the fd. For various reasons (hysterical and genuine
ones) Xorg has a fallback path going the open(), whereas Wayland
compositors are moving to solely relying on logind... some never had
fallback even.
Over the past few years, more projects have emerged which provide
functionality similar (be that on API level, Dbus, or otherwise) to
systemd-logind.
"""
v2:
* Fixed typo in commit text and added a fine historical explanation
from Emil.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Tested-by: Rob Clark <robdclark@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230621094824.2348732-1-tvrtko.ursulin@linux.intel.com
Signed-off-by: Christian König <christian.koenig@amd.com>
2023-06-21 10:48:24 +01:00
struct pid * pid ;
2021-12-06 12:26:12 -05:00
int id ;
/*
* Although we have a valid reference on file - > pid , that does
* not guarantee that the task_struct who called get_pid ( ) is
* still alive ( e . g . get_pid ( current ) = > fork ( ) = > exit ( ) ) .
* Therefore , we need to protect this - > comm access using RCU .
*/
rcu_read_lock ( ) ;
drm: Update file owner during use
With the typical model where the display server opens the file descriptor
and then hands it over to the client(*), we were showing stale data in
debugfs.
Fix it by updating the drm_file->pid on ioctl access from a different
process.
The field is also made RCU protected to allow for lockless readers. Update
side is protected with dev->filelist_mutex.
Before:
$ cat /sys/kernel/debug/dri/0/clients
command pid dev master a uid magic
Xorg 2344 0 y y 0 0
Xorg 2344 0 n y 0 2
Xorg 2344 0 n y 0 3
Xorg 2344 0 n y 0 4
After:
$ cat /sys/kernel/debug/dri/0/clients
command tgid dev master a uid magic
Xorg 830 0 y y 0 0
xfce4-session 880 0 n y 0 1
xfwm4 943 0 n y 0 2
neverball 1095 0 n y 0 3
*)
More detailed and historically accurate description of various handover
implementation kindly provided by Emil Velikov:
"""
The traditional model, the server was the orchestrator managing the
primary device node. From the fd, to the master status and
authentication. But looking at the fd alone, this has varied across
the years.
IIRC in the DRI1 days, Xorg (libdrm really) would have a list of open
fd(s) and reuse those whenever needed, DRI2 the client was responsible
for open() themselves and with DRI3 the fd was passed to the client.
Around the inception of DRI3 and systemd-logind, the latter became
another possible orchestrator. Whereby Xorg and Wayland compositors
could ask it for the fd. For various reasons (hysterical and genuine
ones) Xorg has a fallback path going the open(), whereas Wayland
compositors are moving to solely relying on logind... some never had
fallback even.
Over the past few years, more projects have emerged which provide
functionality similar (be that on API level, Dbus, or otherwise) to
systemd-logind.
"""
v2:
* Fixed typo in commit text and added a fine historical explanation
from Emil.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Tested-by: Rob Clark <robdclark@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230621094824.2348732-1-tvrtko.ursulin@linux.intel.com
Signed-off-by: Christian König <christian.koenig@amd.com>
2023-06-21 10:48:24 +01:00
pid = rcu_dereference ( file - > pid ) ;
task = pid_task ( pid , PIDTYPE_TGID ) ;
seq_printf ( m , " pid %8d command %s: \n " , pid_nr ( pid ) ,
2021-12-06 12:26:12 -05:00
task ? task - > comm : " <unknown> " ) ;
rcu_read_unlock ( ) ;
spin_lock ( & file - > table_lock ) ;
idr_for_each_entry ( & file - > object_idr , gobj , id ) {
2023-01-30 22:35:37 -05:00
struct vmw_bo * bo = to_vmw_bo ( gobj ) ;
2021-12-06 12:26:12 -05:00
vmw_bo_print_info ( id , bo , m ) ;
}
spin_unlock ( & file - > table_lock ) ;
}
mutex_unlock ( & dev - > filelist_mutex ) ;
return 0 ;
}
DEFINE_SHOW_ATTRIBUTE ( vmw_debugfs_gem_info ) ;
# endif
void vmw_debugfs_gem_init ( struct vmw_private * vdev )
{
# if defined(CONFIG_DEBUG_FS)
struct drm_minor * minor = vdev - > drm . primary ;
struct dentry * root = minor - > debugfs_root ;
debugfs_create_file ( " vmwgfx_gem_info " , 0444 , root , vdev ,
& vmw_debugfs_gem_info_fops ) ;
# endif
}