2005-11-09 21:36:41 +03:00
/*
* Copyright ( c ) 2004 - 2005 Intel Corporation . All rights reserved .
*
* This program is free software ; you can redistribute it and / or modify it
* under the terms of the GNU General Public License as published by the
* Free Software Foundation ; either version 2 of the License , or
* ( at your option ) any later version .
*
* This program is distributed in the hope that it will be useful , but
* WITHOUT ANY WARRANTY ; without even the implied warranty of MERCHANTABILITY
* or FITNESS FOR A PARTICULAR PURPOSE . See the GNU General Public License
* for more details .
*
* You should have received a copy of the GNU General Public License along
* with this program ; if not , write to the Free Software Foundation , Inc . ,
* 59 Temple Place - Suite 330 , Boston , MA 02111 - 1307 , USA .
*
* The full GNU General Public License is included in this distribution in the
* file called LICENSE .
*
*/
# include <linux/kernel.h>
# include <linux/module.h>
# include <linux/device.h>
# include <linux/sysdev.h>
# include <linux/fs.h>
# include <linux/types.h>
# include <linux/string.h>
# include <linux/netdevice.h>
# include <linux/inetdevice.h>
# include <linux/in.h>
# include <linux/sysfs.h>
# include <linux/ctype.h>
# include <linux/inet.h>
# include <linux/rtnetlink.h>
2007-09-17 22:56:21 +04:00
# include <net/net_namespace.h>
2005-11-09 21:36:41 +03:00
# include "bonding.h"
2008-12-10 10:09:22 +03:00
2002-04-09 23:14:34 +04:00
# define to_dev(obj) container_of(obj,struct device,kobj)
2008-11-13 10:37:49 +03:00
# define to_bond(cd) ((struct bonding *)(netdev_priv(to_net_dev(cd))))
2005-11-09 21:36:41 +03:00
/*---------------------------- Declarations -------------------------------*/
static int expected_refcount = - 1 ;
/*--------------------------- Data Structures -----------------------------*/
2007-10-20 01:10:43 +04:00
/* Bonding sysfs lock. Why can't we just use the subsystem lock?
2005-11-09 21:36:41 +03:00
* Because kobject_register tries to acquire the subsystem lock . If
* we already hold the lock ( which we would if the user was creating
* a new bond through the sysfs interface ) , we deadlock .
* This lock is only needed when deleting a bond - we need to make sure
* that we don ' t collide with an ongoing ioctl .
*/
struct rw_semaphore bonding_rwsem ;
/*------------------------------ Functions --------------------------------*/
/*
* " show " function for the bond_masters attribute .
* The class parameter is ignored .
*/
2007-12-07 10:40:30 +03:00
static ssize_t bonding_show_bonds ( struct class * cls , char * buf )
2005-11-09 21:36:41 +03:00
{
int res = 0 ;
struct bonding * bond ;
down_read ( & ( bonding_rwsem ) ) ;
list_for_each_entry ( bond , & bond_dev_list , bond_list ) {
if ( res > ( PAGE_SIZE - IFNAMSIZ ) ) {
/* not enough space for another interface name */
if ( ( PAGE_SIZE - res ) > 10 )
res = PAGE_SIZE - 10 ;
2007-12-07 10:40:30 +03:00
res + = sprintf ( buf + res , " ++more++ " ) ;
2005-11-09 21:36:41 +03:00
break ;
}
2007-12-07 10:40:30 +03:00
res + = sprintf ( buf + res , " %s " , bond - > dev - > name ) ;
2005-11-09 21:36:41 +03:00
}
2007-12-07 10:40:31 +03:00
if ( res )
buf [ res - 1 ] = ' \n ' ; /* eat the leftover space */
2005-11-09 21:36:41 +03:00
up_read ( & ( bonding_rwsem ) ) ;
return res ;
}
/*
* " store " function for the bond_masters attribute . This is what
* creates and deletes entire bonds .
*
* The class parameter is ignored .
*
*/
static ssize_t bonding_store_bonds ( struct class * cls , const char * buffer , size_t count )
{
char command [ IFNAMSIZ + 1 ] = { 0 , } ;
char * ifname ;
2008-01-18 03:25:02 +03:00
int rv , res = count ;
2005-11-09 21:36:41 +03:00
struct bonding * bond ;
sscanf ( buffer , " %16s " , command ) ; /* IFNAMSIZ*/
ifname = command + 1 ;
if ( ( strlen ( command ) < = 1 ) | |
! dev_valid_name ( ifname ) )
goto err_no_cmd ;
if ( command [ 0 ] = = ' + ' ) {
printk ( KERN_INFO DRV_NAME
" : %s is being created... \n " , ifname ) ;
2008-05-18 08:10:09 +04:00
rv = bond_create ( ifname , & bonding_defaults ) ;
2008-01-18 03:25:02 +03:00
if ( rv ) {
printk ( KERN_INFO DRV_NAME " : Bond creation failed. \n " ) ;
res = rv ;
2005-11-09 21:36:41 +03:00
}
goto out ;
}
if ( command [ 0 ] = = ' - ' ) {
2008-01-18 03:25:02 +03:00
rtnl_lock ( ) ;
down_write ( & bonding_rwsem ) ;
2008-05-18 08:10:10 +04:00
list_for_each_entry ( bond , & bond_dev_list , bond_list )
2005-11-09 21:36:41 +03:00
if ( strnicmp ( bond - > dev - > name , ifname , IFNAMSIZ ) = = 0 ) {
/* check the ref count on the bond's kobject.
* If it ' s > expected , then there ' s a file open ,
* and we have to fail .
*/
2002-04-09 23:14:34 +04:00
if ( atomic_read ( & bond - > dev - > dev . kobj . kref . refcount )
2005-11-09 21:36:41 +03:00
> expected_refcount ) {
printk ( KERN_INFO DRV_NAME
" : Unable remove bond %s due to open references. \n " ,
ifname ) ;
res = - EPERM ;
2008-05-03 04:49:38 +04:00
goto out_unlock ;
2005-11-09 21:36:41 +03:00
}
printk ( KERN_INFO DRV_NAME
" : %s is being deleted... \n " ,
bond - > dev - > name ) ;
2007-10-10 06:43:43 +04:00
bond_destroy ( bond ) ;
2008-05-03 04:49:38 +04:00
goto out_unlock ;
2005-11-09 21:36:41 +03:00
}
printk ( KERN_ERR DRV_NAME
" : unable to delete non-existent bond %s \n " , ifname ) ;
res = - ENODEV ;
2008-05-03 04:49:38 +04:00
goto out_unlock ;
2005-11-09 21:36:41 +03:00
}
err_no_cmd :
printk ( KERN_ERR DRV_NAME
" : no command found in bonding_masters. Use +ifname or -ifname. \n " ) ;
2008-05-03 04:49:38 +04:00
return - EPERM ;
out_unlock :
up_write ( & bonding_rwsem ) ;
rtnl_unlock ( ) ;
2005-11-09 21:36:41 +03:00
/* Always return either count or an error. If you return 0, you'll
* get called forever , which is bad .
*/
out :
return res ;
}
/* class attribute for bond_masters file. This ends up in /sys/class/net */
static CLASS_ATTR ( bonding_masters , S_IWUSR | S_IRUGO ,
bonding_show_bonds , bonding_store_bonds ) ;
int bond_create_slave_symlinks ( struct net_device * master , struct net_device * slave )
{
char linkname [ IFNAMSIZ + 7 ] ;
int ret = 0 ;
/* first, create a link from the slave back to the master */
2002-04-09 23:14:34 +04:00
ret = sysfs_create_link ( & ( slave - > dev . kobj ) , & ( master - > dev . kobj ) ,
2005-11-09 21:36:41 +03:00
" master " ) ;
if ( ret )
return ret ;
/* next, create a link from the master to the slave */
sprintf ( linkname , " slave_%s " , slave - > name ) ;
2002-04-09 23:14:34 +04:00
ret = sysfs_create_link ( & ( master - > dev . kobj ) , & ( slave - > dev . kobj ) ,
2005-11-09 21:36:41 +03:00
linkname ) ;
return ret ;
}
void bond_destroy_slave_symlinks ( struct net_device * master , struct net_device * slave )
{
char linkname [ IFNAMSIZ + 7 ] ;
2002-04-09 23:14:34 +04:00
sysfs_remove_link ( & ( slave - > dev . kobj ) , " master " ) ;
2005-11-09 21:36:41 +03:00
sprintf ( linkname , " slave_%s " , slave - > name ) ;
2002-04-09 23:14:34 +04:00
sysfs_remove_link ( & ( master - > dev . kobj ) , linkname ) ;
2005-11-09 21:36:41 +03:00
}
/*
* Show the slaves in the current bond .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_slaves ( struct device * d ,
struct device_attribute * attr , char * buf )
2005-11-09 21:36:41 +03:00
{
struct slave * slave ;
int i , res = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-10-18 04:37:50 +04:00
read_lock ( & bond - > lock ) ;
2005-11-09 21:36:41 +03:00
bond_for_each_slave ( bond , slave , i ) {
if ( res > ( PAGE_SIZE - IFNAMSIZ ) ) {
/* not enough space for another interface name */
if ( ( PAGE_SIZE - res ) > 10 )
res = PAGE_SIZE - 10 ;
2007-12-07 10:40:28 +03:00
res + = sprintf ( buf + res , " ++more++ " ) ;
2005-11-09 21:36:41 +03:00
break ;
}
res + = sprintf ( buf + res , " %s " , slave - > dev - > name ) ;
}
2007-10-18 04:37:50 +04:00
read_unlock ( & bond - > lock ) ;
2007-12-07 10:40:31 +03:00
if ( res )
buf [ res - 1 ] = ' \n ' ; /* eat the leftover space */
2005-11-09 21:36:41 +03:00
return res ;
}
/*
* Set the slaves in the current bond . The bond interface must be
* up for this to succeed .
* This function is largely the same flow as bonding_update_bonds ( ) .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_slaves ( struct device * d ,
struct device_attribute * attr ,
const char * buffer , size_t count )
2005-11-09 21:36:41 +03:00
{
char command [ IFNAMSIZ + 1 ] = { 0 , } ;
char * ifname ;
int i , res , found , ret = count ;
2007-10-10 06:43:41 +04:00
u32 original_mtu ;
2005-11-09 21:36:41 +03:00
struct slave * slave ;
2006-02-01 11:54:34 +03:00
struct net_device * dev = NULL ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
/* Quick sanity check -- is the bond interface up? */
if ( ! ( bond - > dev - > flags & IFF_UP ) ) {
2007-10-10 06:43:40 +04:00
printk ( KERN_WARNING DRV_NAME
" : %s: doing slave updates when interface is down. \n " ,
2005-11-09 21:36:41 +03:00
bond - > dev - > name ) ;
}
/* Note: We can't hold bond->lock here, as bond_create grabs it. */
2008-01-18 03:25:02 +03:00
rtnl_lock ( ) ;
down_write ( & ( bonding_rwsem ) ) ;
2005-11-09 21:36:41 +03:00
sscanf ( buffer , " %16s " , command ) ; /* IFNAMSIZ*/
ifname = command + 1 ;
if ( ( strlen ( command ) < = 1 ) | |
! dev_valid_name ( ifname ) )
goto err_no_cmd ;
if ( command [ 0 ] = = ' + ' ) {
/* Got a slave name in ifname. Is it already in the list? */
found = 0 ;
2007-10-18 04:37:50 +04:00
read_lock ( & bond - > lock ) ;
2005-11-09 21:36:41 +03:00
bond_for_each_slave ( bond , slave , i )
if ( strnicmp ( slave - > dev - > name , ifname , IFNAMSIZ ) = = 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Interface %s is already enslaved! \n " ,
bond - > dev - > name , ifname ) ;
ret = - EPERM ;
2007-10-18 04:37:50 +04:00
read_unlock ( & bond - > lock ) ;
2005-11-09 21:36:41 +03:00
goto out ;
}
2007-10-18 04:37:50 +04:00
read_unlock ( & bond - > lock ) ;
2005-11-09 21:36:41 +03:00
printk ( KERN_INFO DRV_NAME " : %s: Adding slave %s. \n " ,
bond - > dev - > name , ifname ) ;
2007-09-17 22:56:21 +04:00
dev = dev_get_by_name ( & init_net , ifname ) ;
2005-11-09 21:36:41 +03:00
if ( ! dev ) {
printk ( KERN_INFO DRV_NAME
" : %s: Interface %s does not exist! \n " ,
bond - > dev - > name , ifname ) ;
ret = - EPERM ;
goto out ;
}
else
dev_put ( dev ) ;
if ( dev - > flags & IFF_UP ) {
printk ( KERN_ERR DRV_NAME
" : %s: Error: Unable to enslave %s "
" because it is already up. \n " ,
bond - > dev - > name , dev - > name ) ;
ret = - EPERM ;
goto out ;
}
/* If this is the first slave, then we need to set
the master ' s hardware address to be the same as the
slave ' s . */
if ( ! ( * ( ( u32 * ) & ( bond - > dev - > dev_addr [ 0 ] ) ) ) ) {
memcpy ( bond - > dev - > dev_addr , dev - > dev_addr ,
dev - > addr_len ) ;
}
/* Set the slave's MTU to match the bond */
2007-10-10 06:43:41 +04:00
original_mtu = dev - > mtu ;
2008-11-20 08:56:05 +03:00
res = dev_set_mtu ( dev , bond - > dev - > mtu ) ;
if ( res ) {
ret = res ;
goto out ;
2005-11-09 21:36:41 +03:00
}
2008-11-20 08:56:05 +03:00
2005-11-09 21:36:41 +03:00
res = bond_enslave ( bond - > dev , dev ) ;
2007-10-10 06:43:41 +04:00
bond_for_each_slave ( bond , slave , i )
if ( strnicmp ( slave - > dev - > name , ifname , IFNAMSIZ ) = = 0 )
slave - > original_mtu = original_mtu ;
2005-11-09 21:36:41 +03:00
if ( res ) {
ret = res ;
}
goto out ;
}
if ( command [ 0 ] = = ' - ' ) {
dev = NULL ;
2008-03-29 02:15:38 +03:00
original_mtu = 0 ;
2005-11-09 21:36:41 +03:00
bond_for_each_slave ( bond , slave , i )
if ( strnicmp ( slave - > dev - > name , ifname , IFNAMSIZ ) = = 0 ) {
dev = slave - > dev ;
2007-10-10 06:43:41 +04:00
original_mtu = slave - > original_mtu ;
2005-11-09 21:36:41 +03:00
break ;
}
if ( dev ) {
printk ( KERN_INFO DRV_NAME " : %s: Removing slave %s \n " ,
bond - > dev - > name , dev - > name ) ;
2007-10-10 06:43:43 +04:00
res = bond_release ( bond - > dev , dev ) ;
2005-11-09 21:36:41 +03:00
if ( res ) {
ret = res ;
goto out ;
}
/* set the slave MTU to the default */
2008-11-20 08:56:05 +03:00
dev_set_mtu ( dev , original_mtu ) ;
2005-11-09 21:36:41 +03:00
}
else {
printk ( KERN_ERR DRV_NAME " : unable to remove non-existent slave %s for bond %s. \n " ,
ifname , bond - > dev - > name ) ;
ret = - ENODEV ;
}
goto out ;
}
err_no_cmd :
printk ( KERN_ERR DRV_NAME " : no command found in slaves file for bond %s. Use +ifname or -ifname. \n " , bond - > dev - > name ) ;
ret = - EPERM ;
out :
2008-01-18 03:25:02 +03:00
up_write ( & ( bonding_rwsem ) ) ;
rtnl_unlock ( ) ;
2005-11-09 21:36:41 +03:00
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( slaves , S_IRUGO | S_IWUSR , bonding_show_slaves , bonding_store_slaves ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the bonding mode . The bond interface must be down to
* change the mode .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_mode ( struct device * d ,
struct device_attribute * attr , char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
return sprintf ( buf , " %s %d \n " ,
bond_mode_tbl [ bond - > params . mode ] . modename ,
2007-12-07 10:40:28 +03:00
bond - > params . mode ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_mode ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > dev - > flags & IFF_UP ) {
printk ( KERN_ERR DRV_NAME
" : unable to update mode of %s because interface is up. \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
2008-01-18 03:25:01 +03:00
new_value = bond_parse_parm ( buf , bond_mode_tbl ) ;
2005-11-09 21:36:41 +03:00
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Ignoring invalid mode value %.*s. \n " ,
bond - > dev - > name ,
( int ) strlen ( buf ) - 1 , buf ) ;
ret = - EINVAL ;
goto out ;
} else {
2006-02-22 03:36:44 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD )
bond_unset_master_3ad_flags ( bond ) ;
if ( bond - > params . mode = = BOND_MODE_ALB )
bond_unset_master_alb_flags ( bond ) ;
2005-11-09 21:36:41 +03:00
bond - > params . mode = new_value ;
bond_set_mode_ops ( bond , bond - > params . mode ) ;
printk ( KERN_INFO DRV_NAME " : %s: setting mode to %s (%d). \n " ,
bond - > dev - > name , bond_mode_tbl [ new_value ] . modename , new_value ) ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( mode , S_IRUGO | S_IWUSR , bonding_show_mode , bonding_store_mode ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the bonding transmit hash method . The bond interface must be down to
* change the xmit hash policy .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_xmit_hash ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:32 +03:00
return sprintf ( buf , " %s %d \n " ,
xmit_hashtype_tbl [ bond - > params . xmit_policy ] . modename ,
bond - > params . xmit_policy ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_xmit_hash ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > dev - > flags & IFF_UP ) {
printk ( KERN_ERR DRV_NAME
" %s: Interface is up. Unable to update xmit policy. \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
2008-01-18 03:25:01 +03:00
new_value = bond_parse_parm ( buf , xmit_hashtype_tbl ) ;
2005-11-09 21:36:41 +03:00
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Ignoring invalid xmit hash policy value %.*s. \n " ,
bond - > dev - > name ,
( int ) strlen ( buf ) - 1 , buf ) ;
ret = - EINVAL ;
goto out ;
} else {
bond - > params . xmit_policy = new_value ;
bond_set_mode_ops ( bond , bond - > params . mode ) ;
printk ( KERN_INFO DRV_NAME " : %s: setting xmit hash policy to %s (%d). \n " ,
bond - > dev - > name , xmit_hashtype_tbl [ new_value ] . modename , new_value ) ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( xmit_hash_policy , S_IRUGO | S_IWUSR , bonding_show_xmit_hash , bonding_store_xmit_hash ) ;
2005-11-09 21:36:41 +03:00
2006-09-23 08:54:53 +04:00
/*
* Show and set arp_validate .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_arp_validate ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2006-09-23 08:54:53 +04:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2006-09-23 08:54:53 +04:00
return sprintf ( buf , " %s %d \n " ,
arp_validate_tbl [ bond - > params . arp_validate ] . modename ,
2007-12-07 10:40:28 +03:00
bond - > params . arp_validate ) ;
2006-09-23 08:54:53 +04:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_arp_validate ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2006-09-23 08:54:53 +04:00
{
int new_value ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2006-09-23 08:54:53 +04:00
2008-01-18 03:25:01 +03:00
new_value = bond_parse_parm ( buf , arp_validate_tbl ) ;
2006-09-23 08:54:53 +04:00
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Ignoring invalid arp_validate value %s \n " ,
bond - > dev - > name , buf ) ;
return - EINVAL ;
}
if ( new_value & & ( bond - > params . mode ! = BOND_MODE_ACTIVEBACKUP ) ) {
printk ( KERN_ERR DRV_NAME
" : %s: arp_validate only supported in active-backup mode. \n " ,
bond - > dev - > name ) ;
return - EINVAL ;
}
printk ( KERN_INFO DRV_NAME " : %s: setting arp_validate to %s (%d). \n " ,
bond - > dev - > name , arp_validate_tbl [ new_value ] . modename ,
new_value ) ;
if ( ! bond - > params . arp_validate & & new_value ) {
bond_register_arp ( bond ) ;
} else if ( bond - > params . arp_validate & & ! new_value ) {
bond_unregister_arp ( bond ) ;
}
bond - > params . arp_validate = new_value ;
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( arp_validate , S_IRUGO | S_IWUSR , bonding_show_arp_validate , bonding_store_arp_validate ) ;
2006-09-23 08:54:53 +04:00
2007-10-10 06:57:24 +04:00
/*
* Show and store fail_over_mac . User only allowed to change the
* value when there are no slaves .
*/
static ssize_t bonding_show_fail_over_mac ( struct device * d , struct device_attribute * attr , char * buf )
{
struct bonding * bond = to_bond ( d ) ;
2008-05-18 08:10:14 +04:00
return sprintf ( buf , " %s %d \n " ,
fail_over_mac_tbl [ bond - > params . fail_over_mac ] . modename ,
bond - > params . fail_over_mac ) ;
2007-10-10 06:57:24 +04:00
}
static ssize_t bonding_store_fail_over_mac ( struct device * d , struct device_attribute * attr , const char * buf , size_t count )
{
int new_value ;
struct bonding * bond = to_bond ( d ) ;
if ( bond - > slave_cnt ! = 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Can't alter fail_over_mac with slaves in bond. \n " ,
bond - > dev - > name ) ;
2008-05-18 08:10:14 +04:00
return - EPERM ;
2007-10-10 06:57:24 +04:00
}
2008-05-18 08:10:14 +04:00
new_value = bond_parse_parm ( buf , fail_over_mac_tbl ) ;
if ( new_value < 0 ) {
2007-10-10 06:57:24 +04:00
printk ( KERN_ERR DRV_NAME
2008-05-18 08:10:14 +04:00
" : %s: Ignoring invalid fail_over_mac value %s. \n " ,
bond - > dev - > name , buf ) ;
return - EINVAL ;
2007-10-10 06:57:24 +04:00
}
2008-05-18 08:10:14 +04:00
bond - > params . fail_over_mac = new_value ;
printk ( KERN_INFO DRV_NAME " : %s: Setting fail_over_mac to %s (%d). \n " ,
bond - > dev - > name , fail_over_mac_tbl [ new_value ] . modename ,
new_value ) ;
return count ;
2007-10-10 06:57:24 +04:00
}
static DEVICE_ATTR ( fail_over_mac , S_IRUGO | S_IWUSR , bonding_show_fail_over_mac , bonding_store_fail_over_mac ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the arp timer interval . There are two tricky bits
* here . First , if ARP monitoring is activated , then we must disable
* MII monitoring . Second , if the ARP timer isn ' t running , we must
* start it .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_arp_interval ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %d \n " , bond - > params . arp_interval ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_arp_interval ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no arp_interval value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid arp_interval value %d not in range 1-%d; rejected. \n " ,
bond - > dev - > name , new_value , INT_MAX ) ;
ret = - EINVAL ;
goto out ;
}
printk ( KERN_INFO DRV_NAME
" : %s: Setting ARP monitoring interval to %d. \n " ,
bond - > dev - > name , new_value ) ;
bond - > params . arp_interval = new_value ;
2008-11-04 05:16:50 +03:00
if ( bond - > params . arp_interval )
bond - > dev - > priv_flags | = IFF_MASTER_ARPMON ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . miimon ) {
printk ( KERN_INFO DRV_NAME
" : %s: ARP monitoring cannot be used with MII monitoring. "
" %s Disabling MII monitoring. \n " ,
bond - > dev - > name , bond - > dev - > name ) ;
bond - > params . miimon = 0 ;
2007-10-18 04:37:45 +04:00
if ( delayed_work_pending ( & bond - > mii_work ) ) {
cancel_delayed_work ( & bond - > mii_work ) ;
flush_workqueue ( bond - > wq ) ;
2005-11-09 21:36:41 +03:00
}
}
if ( ! bond - > params . arp_targets [ 0 ] ) {
printk ( KERN_INFO DRV_NAME
" : %s: ARP monitoring has been set up, "
" but no ARP targets have been specified. \n " ,
bond - > dev - > name ) ;
}
if ( bond - > dev - > flags & IFF_UP ) {
/* If the interface is up, we may need to fire off
* the ARP timer . If the interface is down , the
* timer will get fired off when the open function
* is called .
*/
2007-10-18 04:37:45 +04:00
if ( ! delayed_work_pending ( & bond - > arp_work ) ) {
if ( bond - > params . mode = = BOND_MODE_ACTIVEBACKUP )
INIT_DELAYED_WORK ( & bond - > arp_work ,
bond_activebackup_arp_mon ) ;
else
INIT_DELAYED_WORK ( & bond - > arp_work ,
bond_loadbalance_arp_mon ) ;
queue_delayed_work ( bond - > wq , & bond - > arp_work , 0 ) ;
2005-11-09 21:36:41 +03:00
}
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( arp_interval , S_IRUGO | S_IWUSR , bonding_show_arp_interval , bonding_store_arp_interval ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the arp targets .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_arp_targets ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int i , res = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
for ( i = 0 ; i < BOND_MAX_ARP_TARGETS ; i + + ) {
if ( bond - > params . arp_targets [ i ] )
2008-10-31 10:56:00 +03:00
res + = sprintf ( buf + res , " %pI4 " ,
& bond - > params . arp_targets [ i ] ) ;
2005-11-09 21:36:41 +03:00
}
2007-12-07 10:40:31 +03:00
if ( res )
buf [ res - 1 ] = ' \n ' ; /* eat the leftover space */
2005-11-09 21:36:41 +03:00
return res ;
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_arp_targets ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
2007-08-23 04:06:58 +04:00
__be32 newtarget ;
2005-11-09 21:36:41 +03:00
int i = 0 , done = 0 , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2007-08-23 04:06:58 +04:00
__be32 * targets ;
2005-11-09 21:36:41 +03:00
targets = bond - > params . arp_targets ;
newtarget = in_aton ( buf + 1 ) ;
/* look for adds */
if ( buf [ 0 ] = = ' + ' ) {
2007-08-23 04:06:58 +04:00
if ( ( newtarget = = 0 ) | | ( newtarget = = htonl ( INADDR_BROADCAST ) ) ) {
2005-11-09 21:36:41 +03:00
printk ( KERN_ERR DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: invalid ARP target %pI4 specified for addition \n " ,
bond - > dev - > name , & newtarget ) ;
2005-11-09 21:36:41 +03:00
ret = - EINVAL ;
goto out ;
}
/* look for an empty slot to put the target in, and check for dupes */
2009-04-13 11:11:30 +04:00
for ( i = 0 ; ( i < BOND_MAX_ARP_TARGETS ) & & ! done ; i + + ) {
2005-11-09 21:36:41 +03:00
if ( targets [ i ] = = newtarget ) { /* duplicate */
printk ( KERN_ERR DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: ARP target %pI4 is already present \n " ,
bond - > dev - > name , & newtarget ) ;
2005-11-09 21:36:41 +03:00
ret = - EINVAL ;
goto out ;
}
2009-04-13 11:11:30 +04:00
if ( targets [ i ] = = 0 ) {
2005-11-09 21:36:41 +03:00
printk ( KERN_INFO DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: adding ARP target %pI4. \n " ,
bond - > dev - > name , & newtarget ) ;
2005-11-09 21:36:41 +03:00
done = 1 ;
targets [ i ] = newtarget ;
}
}
if ( ! done ) {
printk ( KERN_ERR DRV_NAME
" : %s: ARP target table is full! \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
}
else if ( buf [ 0 ] = = ' - ' ) {
2007-08-23 04:06:58 +04:00
if ( ( newtarget = = 0 ) | | ( newtarget = = htonl ( INADDR_BROADCAST ) ) ) {
2005-11-09 21:36:41 +03:00
printk ( KERN_ERR DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: invalid ARP target %pI4 specified for removal \n " ,
bond - > dev - > name , & newtarget ) ;
2005-11-09 21:36:41 +03:00
ret = - EINVAL ;
goto out ;
}
2009-04-13 11:11:30 +04:00
for ( i = 0 ; ( i < BOND_MAX_ARP_TARGETS ) & & ! done ; i + + ) {
2005-11-09 21:36:41 +03:00
if ( targets [ i ] = = newtarget ) {
2009-04-13 11:11:30 +04:00
int j ;
2005-11-09 21:36:41 +03:00
printk ( KERN_INFO DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: removing ARP target %pI4. \n " ,
bond - > dev - > name , & newtarget ) ;
2009-04-13 11:11:30 +04:00
for ( j = i ; ( j < ( BOND_MAX_ARP_TARGETS - 1 ) ) & & targets [ j + 1 ] ; j + + )
targets [ j ] = targets [ j + 1 ] ;
targets [ j ] = 0 ;
2005-11-09 21:36:41 +03:00
done = 1 ;
}
}
if ( ! done ) {
printk ( KERN_INFO DRV_NAME
2008-10-31 10:56:00 +03:00
" : %s: unable to remove nonexistent ARP target %pI4. \n " ,
bond - > dev - > name , & newtarget ) ;
2005-11-09 21:36:41 +03:00
ret = - EINVAL ;
goto out ;
}
}
else {
printk ( KERN_ERR DRV_NAME " : no command found in arp_ip_targets file for bond %s. Use +<addr> or -<addr>. \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( arp_ip_target , S_IRUGO | S_IWUSR , bonding_show_arp_targets , bonding_store_arp_targets ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the up and down delays . These must be multiples of the
* MII monitoring value , and are stored internally as the multiplier .
* Thus , we must translate to MS for the real world .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_downdelay ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %d \n " , bond - > params . downdelay * bond - > params . miimon ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_downdelay ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( ! ( bond - > params . miimon ) ) {
printk ( KERN_ERR DRV_NAME
" : %s: Unable to set down delay as MII monitoring is disabled \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no down delay value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid down delay value %d not in range %d-%d; rejected. \n " ,
bond - > dev - > name , new_value , 1 , INT_MAX ) ;
ret = - EINVAL ;
goto out ;
} else {
if ( ( new_value % bond - > params . miimon ) ! = 0 ) {
printk ( KERN_WARNING DRV_NAME
" : %s: Warning: down delay (%d) is not a multiple "
" of miimon (%d), delay rounded to %d ms \n " ,
bond - > dev - > name , new_value , bond - > params . miimon ,
( new_value / bond - > params . miimon ) *
bond - > params . miimon ) ;
}
bond - > params . downdelay = new_value / bond - > params . miimon ;
printk ( KERN_INFO DRV_NAME " : %s: Setting down delay to %d. \n " ,
bond - > dev - > name , bond - > params . downdelay * bond - > params . miimon ) ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( downdelay , S_IRUGO | S_IWUSR , bonding_show_downdelay , bonding_store_downdelay ) ;
2005-11-09 21:36:41 +03:00
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_updelay ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %d \n " , bond - > params . updelay * bond - > params . miimon ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_updelay ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( ! ( bond - > params . miimon ) ) {
printk ( KERN_ERR DRV_NAME
" : %s: Unable to set up delay as MII monitoring is disabled \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no up delay value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid down delay value %d not in range %d-%d; rejected. \n " ,
bond - > dev - > name , new_value , 1 , INT_MAX ) ;
ret = - EINVAL ;
goto out ;
} else {
if ( ( new_value % bond - > params . miimon ) ! = 0 ) {
printk ( KERN_WARNING DRV_NAME
" : %s: Warning: up delay (%d) is not a multiple "
" of miimon (%d), updelay rounded to %d ms \n " ,
bond - > dev - > name , new_value , bond - > params . miimon ,
( new_value / bond - > params . miimon ) *
bond - > params . miimon ) ;
}
bond - > params . updelay = new_value / bond - > params . miimon ;
printk ( KERN_INFO DRV_NAME " : %s: Setting up delay to %d. \n " ,
bond - > dev - > name , bond - > params . updelay * bond - > params . miimon ) ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( updelay , S_IRUGO | S_IWUSR , bonding_show_updelay , bonding_store_updelay ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the LACP interval . Interface must be down , and the mode
* must be set to 802.3 ad mode .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_lacp ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
return sprintf ( buf , " %s %d \n " ,
bond_lacp_tbl [ bond - > params . lacp_fast ] . modename ,
2007-12-07 10:40:28 +03:00
bond - > params . lacp_fast ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_lacp ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > dev - > flags & IFF_UP ) {
printk ( KERN_ERR DRV_NAME
" : %s: Unable to update LACP rate because interface is up. \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
if ( bond - > params . mode ! = BOND_MODE_8023AD ) {
printk ( KERN_ERR DRV_NAME
" : %s: Unable to update LACP rate because bond is not in 802.3ad mode. \n " ,
bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
2008-01-18 03:25:01 +03:00
new_value = bond_parse_parm ( buf , bond_lacp_tbl ) ;
2005-11-09 21:36:41 +03:00
if ( ( new_value = = 1 ) | | ( new_value = = 0 ) ) {
bond - > params . lacp_fast = new_value ;
printk ( KERN_INFO DRV_NAME
" : %s: Setting LACP rate to %s (%d). \n " ,
bond - > dev - > name , bond_lacp_tbl [ new_value ] . modename , new_value ) ;
} else {
printk ( KERN_ERR DRV_NAME
" : %s: Ignoring invalid LACP rate value %.*s. \n " ,
bond - > dev - > name , ( int ) strlen ( buf ) - 1 , buf ) ;
ret = - EINVAL ;
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( lacp_rate , S_IRUGO | S_IWUSR , bonding_show_lacp , bonding_store_lacp ) ;
2005-11-09 21:36:41 +03:00
2008-11-05 04:51:16 +03:00
static ssize_t bonding_show_ad_select ( struct device * d ,
struct device_attribute * attr ,
char * buf )
{
struct bonding * bond = to_bond ( d ) ;
return sprintf ( buf , " %s %d \n " ,
ad_select_tbl [ bond - > params . ad_select ] . modename ,
bond - > params . ad_select ) ;
}
static ssize_t bonding_store_ad_select ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
{
int new_value , ret = count ;
struct bonding * bond = to_bond ( d ) ;
if ( bond - > dev - > flags & IFF_UP ) {
printk ( KERN_ERR DRV_NAME
" : %s: Unable to update ad_select because interface "
" is up. \n " , bond - > dev - > name ) ;
ret = - EPERM ;
goto out ;
}
new_value = bond_parse_parm ( buf , ad_select_tbl ) ;
if ( new_value ! = - 1 ) {
bond - > params . ad_select = new_value ;
printk ( KERN_INFO DRV_NAME
" : %s: Setting ad_select to %s (%d). \n " ,
bond - > dev - > name , ad_select_tbl [ new_value ] . modename ,
new_value ) ;
} else {
printk ( KERN_ERR DRV_NAME
" : %s: Ignoring invalid ad_select value %.*s. \n " ,
bond - > dev - > name , ( int ) strlen ( buf ) - 1 , buf ) ;
ret = - EINVAL ;
}
out :
return ret ;
}
static DEVICE_ATTR ( ad_select , S_IRUGO | S_IWUSR , bonding_show_ad_select , bonding_store_ad_select ) ;
2008-05-18 08:10:12 +04:00
/*
* Show and set the number of grat ARP to send after a failover event .
*/
static ssize_t bonding_show_n_grat_arp ( struct device * d ,
struct device_attribute * attr ,
char * buf )
{
struct bonding * bond = to_bond ( d ) ;
return sprintf ( buf , " %d \n " , bond - > params . num_grat_arp ) ;
}
static ssize_t bonding_store_n_grat_arp ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
{
int new_value , ret = count ;
struct bonding * bond = to_bond ( d ) ;
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no num_grat_arp value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 | | new_value > 255 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid num_grat_arp value %d not in range 0-255; rejected. \n " ,
bond - > dev - > name , new_value ) ;
ret = - EINVAL ;
goto out ;
} else {
bond - > params . num_grat_arp = new_value ;
}
out :
return ret ;
}
static DEVICE_ATTR ( num_grat_arp , S_IRUGO | S_IWUSR , bonding_show_n_grat_arp , bonding_store_n_grat_arp ) ;
bonding: send IPv6 neighbor advertisement on failover
This patch adds better IPv6 failover support for bonding devices,
especially when in active-backup mode and there are only IPv6 addresses
configured, as reported by Alex Sidorenko.
- Creates a new file, net/drivers/bonding/bond_ipv6.c, for the
IPv6-specific routines. Both regular bonds and VLANs over bonds
are supported.
- Adds a new tunable, num_unsol_na, to limit the number of unsolicited
IPv6 Neighbor Advertisements that are sent on a failover event.
Default is 1.
- Creates two new IPv6 neighbor discovery functions:
ndisc_build_skb()
ndisc_send_skb()
These were required to support VLANs since we have to be able to
add the VLAN id to the skb since ndisc_send_na() and friends
shouldn't be asked to do this. These two routines are basically
__ndisc_send() split into two pieces, in a slightly different order.
- Updates Documentation/networking/bonding.txt and bumps the rev of bond
support to 3.4.0.
On failover, this new code will generate one packet:
- An unsolicited IPv6 Neighbor Advertisement, which helps the switch
learn that the address has moved to the new slave.
Testing has shown that sending just the NA results in pretty good
behavior when in active-back mode, I saw no lost ping packets for example.
Signed-off-by: Brian Haley <brian.haley@hp.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
2008-11-05 04:51:14 +03:00
/*
* Show and set the number of unsolicted NA ' s to send after a failover event .
*/
static ssize_t bonding_show_n_unsol_na ( struct device * d ,
struct device_attribute * attr ,
char * buf )
{
struct bonding * bond = to_bond ( d ) ;
return sprintf ( buf , " %d \n " , bond - > params . num_unsol_na ) ;
}
static ssize_t bonding_store_n_unsol_na ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
{
int new_value , ret = count ;
struct bonding * bond = to_bond ( d ) ;
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no num_unsol_na value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 | | new_value > 255 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid num_unsol_na value %d not in range 0-255; rejected. \n " ,
bond - > dev - > name , new_value ) ;
ret = - EINVAL ;
goto out ;
} else {
bond - > params . num_unsol_na = new_value ;
}
out :
return ret ;
}
static DEVICE_ATTR ( num_unsol_na , S_IRUGO | S_IWUSR , bonding_show_n_unsol_na , bonding_store_n_unsol_na ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the MII monitor interval . There are two tricky bits
* here . First , if MII monitoring is activated , then we must disable
* ARP monitoring . Second , if the timer isn ' t running , we must
* start it .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_miimon ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %d \n " , bond - > params . miimon ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_miimon ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no miimon value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( new_value < 0 ) {
printk ( KERN_ERR DRV_NAME
" : %s: Invalid miimon value %d not in range %d-%d; rejected. \n " ,
bond - > dev - > name , new_value , 1 , INT_MAX ) ;
ret = - EINVAL ;
goto out ;
} else {
printk ( KERN_INFO DRV_NAME
" : %s: Setting MII monitoring interval to %d. \n " ,
bond - > dev - > name , new_value ) ;
bond - > params . miimon = new_value ;
if ( bond - > params . updelay )
printk ( KERN_INFO DRV_NAME
" : %s: Note: Updating updelay (to %d) "
" since it is a multiple of the miimon value. \n " ,
bond - > dev - > name ,
bond - > params . updelay * bond - > params . miimon ) ;
if ( bond - > params . downdelay )
printk ( KERN_INFO DRV_NAME
" : %s: Note: Updating downdelay (to %d) "
" since it is a multiple of the miimon value. \n " ,
bond - > dev - > name ,
bond - > params . downdelay * bond - > params . miimon ) ;
if ( bond - > params . arp_interval ) {
printk ( KERN_INFO DRV_NAME
" : %s: MII monitoring cannot be used with "
" ARP monitoring. Disabling ARP monitoring... \n " ,
bond - > dev - > name ) ;
bond - > params . arp_interval = 0 ;
2008-11-04 05:16:50 +03:00
bond - > dev - > priv_flags & = ~ IFF_MASTER_ARPMON ;
2006-09-23 08:54:53 +04:00
if ( bond - > params . arp_validate ) {
bond_unregister_arp ( bond ) ;
bond - > params . arp_validate =
BOND_ARP_VALIDATE_NONE ;
}
2007-10-18 04:37:45 +04:00
if ( delayed_work_pending ( & bond - > arp_work ) ) {
cancel_delayed_work ( & bond - > arp_work ) ;
flush_workqueue ( bond - > wq ) ;
2005-11-09 21:36:41 +03:00
}
}
if ( bond - > dev - > flags & IFF_UP ) {
/* If the interface is up, we may need to fire off
* the MII timer . If the interface is down , the
* timer will get fired off when the open function
* is called .
*/
2007-10-18 04:37:45 +04:00
if ( ! delayed_work_pending ( & bond - > mii_work ) ) {
INIT_DELAYED_WORK ( & bond - > mii_work ,
bond_mii_monitor ) ;
queue_delayed_work ( bond - > wq ,
& bond - > mii_work , 0 ) ;
2005-11-09 21:36:41 +03:00
}
}
}
out :
return ret ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( miimon , S_IRUGO | S_IWUSR , bonding_show_miimon , bonding_store_miimon ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the primary slave . The store function is much
* simpler than bonding_store_slaves function because it only needs to
* handle one interface name .
* The bond must be a mode that supports a primary for this be
* set .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_primary ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > primary_slave )
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %s \n " , bond - > primary_slave - > dev - > name ) ;
2005-11-09 21:36:41 +03:00
return count ;
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_primary ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int i ;
struct slave * slave ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2008-01-18 03:24:57 +03:00
rtnl_lock ( ) ;
read_lock ( & bond - > lock ) ;
write_lock_bh ( & bond - > curr_slave_lock ) ;
2005-11-09 21:36:41 +03:00
if ( ! USES_PRIMARY ( bond - > params . mode ) ) {
printk ( KERN_INFO DRV_NAME
" : %s: Unable to set primary slave; %s is in mode %d \n " ,
bond - > dev - > name , bond - > dev - > name , bond - > params . mode ) ;
} else {
bond_for_each_slave ( bond , slave , i ) {
if ( strnicmp
( slave - > dev - > name , buf ,
strlen ( slave - > dev - > name ) ) = = 0 ) {
printk ( KERN_INFO DRV_NAME
" : %s: Setting %s as primary slave. \n " ,
bond - > dev - > name , slave - > dev - > name ) ;
bond - > primary_slave = slave ;
bond_select_active_slave ( bond ) ;
goto out ;
}
}
/* if we got here, then we didn't match the name of any slave */
if ( strlen ( buf ) = = 0 | | buf [ 0 ] = = ' \n ' ) {
printk ( KERN_INFO DRV_NAME
" : %s: Setting primary slave to None. \n " ,
bond - > dev - > name ) ;
2006-02-01 11:54:34 +03:00
bond - > primary_slave = NULL ;
2005-11-09 21:36:41 +03:00
bond_select_active_slave ( bond ) ;
} else {
printk ( KERN_INFO DRV_NAME
" : %s: Unable to set %.*s as primary slave as it is not a slave. \n " ,
bond - > dev - > name , ( int ) strlen ( buf ) - 1 , buf ) ;
}
}
out :
2008-01-18 03:24:57 +03:00
write_unlock_bh ( & bond - > curr_slave_lock ) ;
read_unlock ( & bond - > lock ) ;
2007-10-18 04:37:50 +04:00
rtnl_unlock ( ) ;
2005-11-09 21:36:41 +03:00
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( primary , S_IRUGO | S_IWUSR , bonding_show_primary , bonding_store_primary ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set the use_carrier flag .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_carrier ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %d \n " , bond - > params . use_carrier ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_carrier ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int new_value , ret = count ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( sscanf ( buf , " %d " , & new_value ) ! = 1 ) {
printk ( KERN_ERR DRV_NAME
" : %s: no use_carrier value specified. \n " ,
bond - > dev - > name ) ;
ret = - EINVAL ;
goto out ;
}
if ( ( new_value = = 0 ) | | ( new_value = = 1 ) ) {
bond - > params . use_carrier = new_value ;
printk ( KERN_INFO DRV_NAME " : %s: Setting use_carrier to %d. \n " ,
bond - > dev - > name , new_value ) ;
} else {
printk ( KERN_INFO DRV_NAME
" : %s: Ignoring invalid use_carrier value %d. \n " ,
bond - > dev - > name , new_value ) ;
}
out :
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( use_carrier , S_IRUGO | S_IWUSR , bonding_show_carrier , bonding_store_carrier ) ;
2005-11-09 21:36:41 +03:00
/*
* Show and set currently active_slave .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_active_slave ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
struct slave * curr ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2007-12-07 10:40:29 +03:00
int count = 0 ;
2005-11-09 21:36:41 +03:00
read_lock ( & bond - > curr_slave_lock ) ;
curr = bond - > curr_active_slave ;
read_unlock ( & bond - > curr_slave_lock ) ;
if ( USES_PRIMARY ( bond - > params . mode ) & & curr )
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %s \n " , curr - > dev - > name ) ;
2005-11-09 21:36:41 +03:00
return count ;
}
2002-04-09 23:14:34 +04:00
static ssize_t bonding_store_active_slave ( struct device * d ,
struct device_attribute * attr ,
const char * buf , size_t count )
2005-11-09 21:36:41 +03:00
{
int i ;
struct slave * slave ;
struct slave * old_active = NULL ;
struct slave * new_active = NULL ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
2007-11-07 00:33:28 +03:00
rtnl_lock ( ) ;
2008-01-18 03:24:57 +03:00
read_lock ( & bond - > lock ) ;
write_lock_bh ( & bond - > curr_slave_lock ) ;
2007-11-07 00:33:28 +03:00
2005-11-09 21:36:41 +03:00
if ( ! USES_PRIMARY ( bond - > params . mode ) ) {
printk ( KERN_INFO DRV_NAME
" : %s: Unable to change active slave; %s is in mode %d \n " ,
bond - > dev - > name , bond - > dev - > name , bond - > params . mode ) ;
} else {
bond_for_each_slave ( bond , slave , i ) {
if ( strnicmp
( slave - > dev - > name , buf ,
strlen ( slave - > dev - > name ) ) = = 0 ) {
old_active = bond - > curr_active_slave ;
new_active = slave ;
2006-09-23 08:53:25 +04:00
if ( new_active = = old_active ) {
2005-11-09 21:36:41 +03:00
/* do nothing */
printk ( KERN_INFO DRV_NAME
" : %s: %s is already the current active slave. \n " ,
bond - > dev - > name , slave - > dev - > name ) ;
goto out ;
}
else {
if ( ( new_active ) & &
( old_active ) & &
( new_active - > link = = BOND_LINK_UP ) & &
IS_UP ( new_active - > dev ) ) {
printk ( KERN_INFO DRV_NAME
" : %s: Setting %s as active slave. \n " ,
bond - > dev - > name , slave - > dev - > name ) ;
bond_change_active_slave ( bond , new_active ) ;
}
else {
printk ( KERN_INFO DRV_NAME
" : %s: Could not set %s as active slave; "
" either %s is down or the link is down. \n " ,
bond - > dev - > name , slave - > dev - > name ,
slave - > dev - > name ) ;
}
goto out ;
}
}
}
/* if we got here, then we didn't match the name of any slave */
if ( strlen ( buf ) = = 0 | | buf [ 0 ] = = ' \n ' ) {
printk ( KERN_INFO DRV_NAME
" : %s: Setting active slave to None. \n " ,
bond - > dev - > name ) ;
2006-02-01 11:54:34 +03:00
bond - > primary_slave = NULL ;
2005-11-09 21:36:41 +03:00
bond_select_active_slave ( bond ) ;
} else {
printk ( KERN_INFO DRV_NAME
" : %s: Unable to set %.*s as active slave as it is not a slave. \n " ,
bond - > dev - > name , ( int ) strlen ( buf ) - 1 , buf ) ;
}
}
out :
2008-01-18 03:24:57 +03:00
write_unlock_bh ( & bond - > curr_slave_lock ) ;
read_unlock ( & bond - > lock ) ;
2007-10-18 04:37:50 +04:00
rtnl_unlock ( ) ;
2005-11-09 21:36:41 +03:00
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( active_slave , S_IRUGO | S_IWUSR , bonding_show_active_slave , bonding_store_active_slave ) ;
2005-11-09 21:36:41 +03:00
/*
* Show link status of the bond interface .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_mii_status ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
struct slave * curr ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
read_lock ( & bond - > curr_slave_lock ) ;
curr = bond - > curr_active_slave ;
read_unlock ( & bond - > curr_slave_lock ) ;
2007-12-07 10:40:28 +03:00
return sprintf ( buf , " %s \n " , ( curr ) ? " up " : " down " ) ;
2005-11-09 21:36:41 +03:00
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( mii_status , S_IRUGO , bonding_show_mii_status , NULL ) ;
2005-11-09 21:36:41 +03:00
/*
* Show current 802.3 ad aggregator ID .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_ad_aggregator ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD ) {
struct ad_info ad_info ;
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %d \n " , ( bond_3ad_get_active_agg_info ( bond , & ad_info ) ) ? 0 : ad_info . aggregator_id ) ;
2005-11-09 21:36:41 +03:00
}
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( ad_aggregator , S_IRUGO , bonding_show_ad_aggregator , NULL ) ;
2005-11-09 21:36:41 +03:00
/*
* Show number of active 802.3 ad ports .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_ad_num_ports ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD ) {
struct ad_info ad_info ;
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %d \n " , ( bond_3ad_get_active_agg_info ( bond , & ad_info ) ) ? 0 : ad_info . ports ) ;
2005-11-09 21:36:41 +03:00
}
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( ad_num_ports , S_IRUGO , bonding_show_ad_num_ports , NULL ) ;
2005-11-09 21:36:41 +03:00
/*
* Show current 802.3 ad actor key .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_ad_actor_key ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD ) {
struct ad_info ad_info ;
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %d \n " , ( bond_3ad_get_active_agg_info ( bond , & ad_info ) ) ? 0 : ad_info . actor_key ) ;
2005-11-09 21:36:41 +03:00
}
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( ad_actor_key , S_IRUGO , bonding_show_ad_actor_key , NULL ) ;
2005-11-09 21:36:41 +03:00
/*
* Show current 802.3 ad partner key .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_ad_partner_key ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD ) {
struct ad_info ad_info ;
2007-12-07 10:40:28 +03:00
count = sprintf ( buf , " %d \n " , ( bond_3ad_get_active_agg_info ( bond , & ad_info ) ) ? 0 : ad_info . partner_key ) ;
2005-11-09 21:36:41 +03:00
}
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( ad_partner_key , S_IRUGO , bonding_show_ad_partner_key , NULL ) ;
2005-11-09 21:36:41 +03:00
/*
* Show current 802.3 ad partner mac .
*/
2002-04-09 23:14:34 +04:00
static ssize_t bonding_show_ad_partner_mac ( struct device * d ,
struct device_attribute * attr ,
char * buf )
2005-11-09 21:36:41 +03:00
{
int count = 0 ;
2002-04-09 23:14:34 +04:00
struct bonding * bond = to_bond ( d ) ;
2005-11-09 21:36:41 +03:00
if ( bond - > params . mode = = BOND_MODE_8023AD ) {
struct ad_info ad_info ;
if ( ! bond_3ad_get_active_agg_info ( bond , & ad_info ) ) {
2008-10-28 01:59:26 +03:00
count = sprintf ( buf , " %pM \n " , ad_info . partner_system ) ;
2005-11-09 21:36:41 +03:00
}
}
return count ;
}
2002-04-09 23:14:34 +04:00
static DEVICE_ATTR ( ad_partner_mac , S_IRUGO , bonding_show_ad_partner_mac , NULL ) ;
2005-11-09 21:36:41 +03:00
static struct attribute * per_bond_attrs [ ] = {
2002-04-09 23:14:34 +04:00
& dev_attr_slaves . attr ,
& dev_attr_mode . attr ,
2007-10-10 06:57:24 +04:00
& dev_attr_fail_over_mac . attr ,
2002-04-09 23:14:34 +04:00
& dev_attr_arp_validate . attr ,
& dev_attr_arp_interval . attr ,
& dev_attr_arp_ip_target . attr ,
& dev_attr_downdelay . attr ,
& dev_attr_updelay . attr ,
& dev_attr_lacp_rate . attr ,
2008-11-05 04:51:16 +03:00
& dev_attr_ad_select . attr ,
2002-04-09 23:14:34 +04:00
& dev_attr_xmit_hash_policy . attr ,
2008-05-18 08:10:12 +04:00
& dev_attr_num_grat_arp . attr ,
bonding: send IPv6 neighbor advertisement on failover
This patch adds better IPv6 failover support for bonding devices,
especially when in active-backup mode and there are only IPv6 addresses
configured, as reported by Alex Sidorenko.
- Creates a new file, net/drivers/bonding/bond_ipv6.c, for the
IPv6-specific routines. Both regular bonds and VLANs over bonds
are supported.
- Adds a new tunable, num_unsol_na, to limit the number of unsolicited
IPv6 Neighbor Advertisements that are sent on a failover event.
Default is 1.
- Creates two new IPv6 neighbor discovery functions:
ndisc_build_skb()
ndisc_send_skb()
These were required to support VLANs since we have to be able to
add the VLAN id to the skb since ndisc_send_na() and friends
shouldn't be asked to do this. These two routines are basically
__ndisc_send() split into two pieces, in a slightly different order.
- Updates Documentation/networking/bonding.txt and bumps the rev of bond
support to 3.4.0.
On failover, this new code will generate one packet:
- An unsolicited IPv6 Neighbor Advertisement, which helps the switch
learn that the address has moved to the new slave.
Testing has shown that sending just the NA results in pretty good
behavior when in active-back mode, I saw no lost ping packets for example.
Signed-off-by: Brian Haley <brian.haley@hp.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
2008-11-05 04:51:14 +03:00
& dev_attr_num_unsol_na . attr ,
2002-04-09 23:14:34 +04:00
& dev_attr_miimon . attr ,
& dev_attr_primary . attr ,
& dev_attr_use_carrier . attr ,
& dev_attr_active_slave . attr ,
& dev_attr_mii_status . attr ,
& dev_attr_ad_aggregator . attr ,
& dev_attr_ad_num_ports . attr ,
& dev_attr_ad_actor_key . attr ,
& dev_attr_ad_partner_key . attr ,
& dev_attr_ad_partner_mac . attr ,
2005-11-09 21:36:41 +03:00
NULL ,
} ;
static struct attribute_group bonding_group = {
. name = " bonding " ,
. attrs = per_bond_attrs ,
} ;
/*
* Initialize sysfs . This sets up the bonding_masters file in
* / sys / class / net .
*/
int bond_create_sysfs ( void )
{
2008-06-14 05:12:04 +04:00
int ret ;
2005-11-09 21:36:41 +03:00
2008-06-14 05:12:04 +04:00
ret = netdev_class_create_file ( & class_attr_bonding_masters ) ;
bonding: modify sysfs support to permit multiple loads
The existing code would blindly attempt to create the
bonding_masters file (in /sys/class/net) every time the module was
loaded. When the module is loaded multiple times (which is the
historical method used by initscripts and sysconfig to create multiple
bonding interfaces), this caused load failure of the second module load
attempt, as the creation request would fail.
This changes the code to note the failure, arrange to not remove
the bonding_masters file upon module exit, and then return success.
Bonding interfaces created by the second or subsequent loads of
the module will not exist in bonding_masters. This is not a significant
change, as previously only the interfaces from the most recent load of
the module would be listed. Both situations are less than optimal, but
this case permits compatibility with existing distro configuration
scripts, and is consistent.
Note that previously, the sysfs create request would overwrite
the exsting bonding_masters file and succeed, allowing multiple loads of
the module. The sysfs code has recently changed to return an error if
the file being created already exists.
Patrick McHardy <kaber@trash.net>, who reported this problem,
observed crashes on the old kernel (before sysfs checked for
duplicates). I did not experience such crashes, but this change should
resolve them.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-01-20 05:15:47 +03:00
/*
* Permit multiple loads of the module by ignoring failures to
* create the bonding_masters sysfs file . Bonding devices
* created by second or subsequent loads of the module will
* not be listed in , or controllable by , bonding_masters , but
* will have the usual " bonding " sysfs directory .
*
* This is done to preserve backwards compatibility for
* initscripts / sysconfig , which load bonding multiple times to
* configure multiple bonding devices .
*/
if ( ret = = - EEXIST ) {
2008-05-15 09:35:04 +04:00
/* Is someone being kinky and naming a device bonding_master? */
if ( __dev_get_by_name ( & init_net ,
class_attr_bonding_masters . attr . name ) )
printk ( KERN_ERR
" network device named %s already exists in sysfs " ,
class_attr_bonding_masters . attr . name ) ;
bonding: modify sysfs support to permit multiple loads
The existing code would blindly attempt to create the
bonding_masters file (in /sys/class/net) every time the module was
loaded. When the module is loaded multiple times (which is the
historical method used by initscripts and sysconfig to create multiple
bonding interfaces), this caused load failure of the second module load
attempt, as the creation request would fail.
This changes the code to note the failure, arrange to not remove
the bonding_masters file upon module exit, and then return success.
Bonding interfaces created by the second or subsequent loads of
the module will not exist in bonding_masters. This is not a significant
change, as previously only the interfaces from the most recent load of
the module would be listed. Both situations are less than optimal, but
this case permits compatibility with existing distro configuration
scripts, and is consistent.
Note that previously, the sysfs create request would overwrite
the exsting bonding_masters file and succeed, allowing multiple loads of
the module. The sysfs code has recently changed to return an error if
the file being created already exists.
Patrick McHardy <kaber@trash.net>, who reported this problem,
observed crashes on the old kernel (before sysfs checked for
duplicates). I did not experience such crashes, but this change should
resolve them.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
2007-01-20 05:15:47 +03:00
}
2005-11-09 21:36:41 +03:00
return ret ;
}
/*
* Remove / sys / class / net / bonding_masters .
*/
void bond_destroy_sysfs ( void )
{
2008-06-14 05:12:04 +04:00
netdev_class_remove_file ( & class_attr_bonding_masters ) ;
2005-11-09 21:36:41 +03:00
}
/*
* Initialize sysfs for each bond . This sets up and registers
* the ' bondctl ' directory for each individual bond under / sys / class / net .
*/
int bond_create_sysfs_entry ( struct bonding * bond )
{
struct net_device * dev = bond - > dev ;
int err ;
2002-04-09 23:14:34 +04:00
err = sysfs_create_group ( & ( dev - > dev . kobj ) , & bonding_group ) ;
2005-11-09 21:36:41 +03:00
if ( err ) {
printk ( KERN_EMERG " eek! didn't create group! \n " ) ;
}
if ( expected_refcount < 1 )
2002-04-09 23:14:34 +04:00
expected_refcount = atomic_read ( & bond - > dev - > dev . kobj . kref . refcount ) ;
2005-11-09 21:36:41 +03:00
return err ;
}
/*
* Remove sysfs entries for each bond .
*/
void bond_destroy_sysfs_entry ( struct bonding * bond )
{
struct net_device * dev = bond - > dev ;
2002-04-09 23:14:34 +04:00
sysfs_remove_group ( & ( dev - > dev . kobj ) , & bonding_group ) ;
2005-11-09 21:36:41 +03:00
}