2017-11-30 11:45:00 +03:00
// SPDX-License-Identifier: GPL-2.0
2016-09-20 19:00:57 +03:00
/*
* Copyright ( C ) Maxime Coquelin 2015
2017-11-30 11:45:00 +03:00
* Copyright ( C ) STMicroelectronics 2017
2016-09-20 19:00:57 +03:00
* Author : Maxime Coquelin < mcoquelin . stm32 @ gmail . com >
*/
# include <linux/bitops.h>
2018-12-17 17:22:14 +03:00
# include <linux/delay.h>
# include <linux/hwspinlock.h>
2016-09-20 19:00:57 +03:00
# include <linux/interrupt.h>
# include <linux/io.h>
# include <linux/irq.h>
# include <linux/irqchip.h>
# include <linux/irqchip/chained_irq.h>
# include <linux/irqdomain.h>
2019-04-17 16:02:56 +03:00
# include <linux/module.h>
2016-09-20 19:00:57 +03:00
# include <linux/of_address.h>
# include <linux/of_irq.h>
2019-04-17 16:02:56 +03:00
# include <linux/of_platform.h>
2018-04-26 19:18:31 +03:00
# include <linux/syscore_ops.h>
2016-09-20 19:00:57 +03:00
2018-04-26 19:18:30 +03:00
# include <dt-bindings/interrupt-controller/arm-gic.h>
2017-11-06 20:03:32 +03:00
# define IRQS_PER_BANK 32
2018-12-17 17:22:14 +03:00
# define HWSPNLCK_TIMEOUT 1000 /* usec */
2017-11-06 20:03:32 +03:00
struct stm32_exti_bank {
u32 imr_ofst ;
u32 emr_ofst ;
u32 rtsr_ofst ;
u32 ftsr_ofst ;
u32 swier_ofst ;
2018-04-26 19:18:26 +03:00
u32 rpr_ofst ;
u32 fpr_ofst ;
2017-11-06 20:03:32 +03:00
} ;
2018-04-26 19:18:26 +03:00
# define UNDEF_REG ~0
2018-04-26 19:18:30 +03:00
struct stm32_desc_irq {
u32 exti ;
u32 irq_parent ;
2020-07-17 17:07:17 +03:00
struct irq_chip * chip ;
2018-04-26 19:18:30 +03:00
} ;
2018-04-26 19:18:28 +03:00
struct stm32_exti_drv_data {
const struct stm32_exti_bank * * exti_banks ;
2018-04-26 19:18:30 +03:00
const struct stm32_desc_irq * desc_irqs ;
2018-04-26 19:18:28 +03:00
u32 bank_nr ;
2018-04-26 19:18:30 +03:00
u32 irq_nr ;
2018-04-26 19:18:28 +03:00
} ;
2018-04-26 19:18:27 +03:00
struct stm32_exti_chip_data {
2018-04-26 19:18:28 +03:00
struct stm32_exti_host_data * host_data ;
2018-04-26 19:18:27 +03:00
const struct stm32_exti_bank * reg_bank ;
2018-04-26 19:18:30 +03:00
struct raw_spinlock rlock ;
u32 wake_active ;
u32 mask_cache ;
2018-04-26 19:18:27 +03:00
u32 rtsr_cache ;
u32 ftsr_cache ;
} ;
2018-04-26 19:18:28 +03:00
struct stm32_exti_host_data {
void __iomem * base ;
struct stm32_exti_chip_data * chips_data ;
const struct stm32_exti_drv_data * drv_data ;
2018-12-17 17:22:14 +03:00
struct hwspinlock * hwlock ;
2018-04-26 19:18:28 +03:00
} ;
2018-04-26 19:18:27 +03:00
2018-04-26 19:18:31 +03:00
static struct stm32_exti_host_data * stm32_host_data ;
2017-11-06 20:03:32 +03:00
static const struct stm32_exti_bank stm32f4xx_exti_b1 = {
. imr_ofst = 0x00 ,
. emr_ofst = 0x04 ,
. rtsr_ofst = 0x08 ,
. ftsr_ofst = 0x0C ,
. swier_ofst = 0x10 ,
2018-04-26 19:18:26 +03:00
. rpr_ofst = 0x14 ,
. fpr_ofst = UNDEF_REG ,
2017-11-06 20:03:32 +03:00
} ;
static const struct stm32_exti_bank * stm32f4xx_exti_banks [ ] = {
& stm32f4xx_exti_b1 ,
} ;
2018-04-26 19:18:28 +03:00
static const struct stm32_exti_drv_data stm32f4xx_drv_data = {
. exti_banks = stm32f4xx_exti_banks ,
. bank_nr = ARRAY_SIZE ( stm32f4xx_exti_banks ) ,
} ;
2017-11-06 20:03:34 +03:00
static const struct stm32_exti_bank stm32h7xx_exti_b1 = {
. imr_ofst = 0x80 ,
. emr_ofst = 0x84 ,
. rtsr_ofst = 0x00 ,
. ftsr_ofst = 0x04 ,
. swier_ofst = 0x08 ,
2018-04-26 19:18:26 +03:00
. rpr_ofst = 0x88 ,
. fpr_ofst = UNDEF_REG ,
2017-11-06 20:03:34 +03:00
} ;
static const struct stm32_exti_bank stm32h7xx_exti_b2 = {
. imr_ofst = 0x90 ,
. emr_ofst = 0x94 ,
. rtsr_ofst = 0x20 ,
. ftsr_ofst = 0x24 ,
. swier_ofst = 0x28 ,
2018-04-26 19:18:26 +03:00
. rpr_ofst = 0x98 ,
. fpr_ofst = UNDEF_REG ,
2017-11-06 20:03:34 +03:00
} ;
static const struct stm32_exti_bank stm32h7xx_exti_b3 = {
. imr_ofst = 0xA0 ,
. emr_ofst = 0xA4 ,
. rtsr_ofst = 0x40 ,
. ftsr_ofst = 0x44 ,
. swier_ofst = 0x48 ,
2018-04-26 19:18:26 +03:00
. rpr_ofst = 0xA8 ,
. fpr_ofst = UNDEF_REG ,
2017-11-06 20:03:34 +03:00
} ;
static const struct stm32_exti_bank * stm32h7xx_exti_banks [ ] = {
& stm32h7xx_exti_b1 ,
& stm32h7xx_exti_b2 ,
& stm32h7xx_exti_b3 ,
} ;
2018-04-26 19:18:28 +03:00
static const struct stm32_exti_drv_data stm32h7xx_drv_data = {
. exti_banks = stm32h7xx_exti_banks ,
. bank_nr = ARRAY_SIZE ( stm32h7xx_exti_banks ) ,
} ;
2018-04-26 19:18:30 +03:00
static const struct stm32_exti_bank stm32mp1_exti_b1 = {
. imr_ofst = 0x80 ,
. emr_ofst = 0x84 ,
. rtsr_ofst = 0x00 ,
. ftsr_ofst = 0x04 ,
. swier_ofst = 0x08 ,
. rpr_ofst = 0x0C ,
. fpr_ofst = 0x10 ,
} ;
static const struct stm32_exti_bank stm32mp1_exti_b2 = {
. imr_ofst = 0x90 ,
. emr_ofst = 0x94 ,
. rtsr_ofst = 0x20 ,
. ftsr_ofst = 0x24 ,
. swier_ofst = 0x28 ,
. rpr_ofst = 0x2C ,
. fpr_ofst = 0x30 ,
} ;
static const struct stm32_exti_bank stm32mp1_exti_b3 = {
. imr_ofst = 0xA0 ,
. emr_ofst = 0xA4 ,
. rtsr_ofst = 0x40 ,
. ftsr_ofst = 0x44 ,
. swier_ofst = 0x48 ,
. rpr_ofst = 0x4C ,
. fpr_ofst = 0x50 ,
} ;
static const struct stm32_exti_bank * stm32mp1_exti_banks [ ] = {
& stm32mp1_exti_b1 ,
& stm32mp1_exti_b2 ,
& stm32mp1_exti_b3 ,
} ;
2020-07-17 17:07:17 +03:00
static struct irq_chip stm32_exti_h_chip ;
static struct irq_chip stm32_exti_h_chip_direct ;
2018-04-26 19:18:30 +03:00
static const struct stm32_desc_irq stm32mp1_desc_irq [ ] = {
2020-07-17 17:07:17 +03:00
{ . exti = 0 , . irq_parent = 6 , . chip = & stm32_exti_h_chip } ,
{ . exti = 1 , . irq_parent = 7 , . chip = & stm32_exti_h_chip } ,
{ . exti = 2 , . irq_parent = 8 , . chip = & stm32_exti_h_chip } ,
{ . exti = 3 , . irq_parent = 9 , . chip = & stm32_exti_h_chip } ,
{ . exti = 4 , . irq_parent = 10 , . chip = & stm32_exti_h_chip } ,
{ . exti = 5 , . irq_parent = 23 , . chip = & stm32_exti_h_chip } ,
{ . exti = 6 , . irq_parent = 64 , . chip = & stm32_exti_h_chip } ,
{ . exti = 7 , . irq_parent = 65 , . chip = & stm32_exti_h_chip } ,
{ . exti = 8 , . irq_parent = 66 , . chip = & stm32_exti_h_chip } ,
{ . exti = 9 , . irq_parent = 67 , . chip = & stm32_exti_h_chip } ,
{ . exti = 10 , . irq_parent = 40 , . chip = & stm32_exti_h_chip } ,
{ . exti = 11 , . irq_parent = 42 , . chip = & stm32_exti_h_chip } ,
{ . exti = 12 , . irq_parent = 76 , . chip = & stm32_exti_h_chip } ,
{ . exti = 13 , . irq_parent = 77 , . chip = & stm32_exti_h_chip } ,
{ . exti = 14 , . irq_parent = 121 , . chip = & stm32_exti_h_chip } ,
{ . exti = 15 , . irq_parent = 127 , . chip = & stm32_exti_h_chip } ,
{ . exti = 16 , . irq_parent = 1 , . chip = & stm32_exti_h_chip } ,
{ . exti = 19 , . irq_parent = 3 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 21 , . irq_parent = 31 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 22 , . irq_parent = 33 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 23 , . irq_parent = 72 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 24 , . irq_parent = 95 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 25 , . irq_parent = 107 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 30 , . irq_parent = 52 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 47 , . irq_parent = 93 , . chip = & stm32_exti_h_chip_direct } ,
2020-10-16 17:40:17 +03:00
{ . exti = 48 , . irq_parent = 138 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 50 , . irq_parent = 139 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 52 , . irq_parent = 140 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 53 , . irq_parent = 141 , . chip = & stm32_exti_h_chip_direct } ,
2020-07-17 17:07:17 +03:00
{ . exti = 54 , . irq_parent = 135 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 61 , . irq_parent = 100 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 65 , . irq_parent = 144 , . chip = & stm32_exti_h_chip } ,
{ . exti = 68 , . irq_parent = 143 , . chip = & stm32_exti_h_chip } ,
{ . exti = 70 , . irq_parent = 62 , . chip = & stm32_exti_h_chip_direct } ,
{ . exti = 73 , . irq_parent = 129 , . chip = & stm32_exti_h_chip } ,
2018-04-26 19:18:30 +03:00
} ;
static const struct stm32_exti_drv_data stm32mp1_drv_data = {
. exti_banks = stm32mp1_exti_banks ,
. bank_nr = ARRAY_SIZE ( stm32mp1_exti_banks ) ,
. desc_irqs = stm32mp1_desc_irq ,
. irq_nr = ARRAY_SIZE ( stm32mp1_desc_irq ) ,
} ;
2020-07-17 17:07:17 +03:00
static const struct
stm32_desc_irq * stm32_exti_get_desc ( const struct stm32_exti_drv_data * drv_data ,
irq_hw_number_t hwirq )
2018-04-26 19:18:30 +03:00
{
2020-07-17 17:07:17 +03:00
const struct stm32_desc_irq * desc = NULL ;
2018-04-26 19:18:30 +03:00
int i ;
if ( ! drv_data - > desc_irqs )
2020-07-17 17:07:17 +03:00
return NULL ;
2018-04-26 19:18:30 +03:00
for ( i = 0 ; i < drv_data - > irq_nr ; i + + ) {
2020-07-17 17:07:17 +03:00
desc = & drv_data - > desc_irqs [ i ] ;
if ( desc - > exti = = hwirq )
break ;
2018-04-26 19:18:30 +03:00
}
2020-07-17 17:07:17 +03:00
return desc ;
2018-04-26 19:18:30 +03:00
}
2017-11-06 20:03:32 +03:00
static unsigned long stm32_exti_pending ( struct irq_chip_generic * gc )
{
2018-04-26 19:18:27 +03:00
struct stm32_exti_chip_data * chip_data = gc - > private ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
2018-04-26 19:18:26 +03:00
unsigned long pending ;
pending = irq_reg_readl ( gc , stm32_bank - > rpr_ofst ) ;
if ( stm32_bank - > fpr_ofst ! = UNDEF_REG )
pending | = irq_reg_readl ( gc , stm32_bank - > fpr_ofst ) ;
2017-11-06 20:03:32 +03:00
2018-04-26 19:18:26 +03:00
return pending ;
2017-11-06 20:03:32 +03:00
}
2016-09-20 19:00:57 +03:00
static void stm32_irq_handler ( struct irq_desc * desc )
{
struct irq_domain * domain = irq_desc_get_handler_data ( desc ) ;
struct irq_chip * chip = irq_desc_get_chip ( desc ) ;
2017-11-06 20:03:32 +03:00
unsigned int virq , nbanks = domain - > gc - > num_chips ;
struct irq_chip_generic * gc ;
2016-09-20 19:00:57 +03:00
unsigned long pending ;
2017-11-06 20:03:32 +03:00
int n , i , irq_base = 0 ;
2016-09-20 19:00:57 +03:00
chained_irq_enter ( chip , desc ) ;
2017-11-06 20:03:32 +03:00
for ( i = 0 ; i < nbanks ; i + + , irq_base + = IRQS_PER_BANK ) {
gc = irq_get_domain_generic_chip ( domain , irq_base ) ;
while ( ( pending = stm32_exti_pending ( gc ) ) ) {
for_each_set_bit ( n , & pending , IRQS_PER_BANK ) {
virq = irq_find_mapping ( domain , irq_base + n ) ;
generic_handle_irq ( virq ) ;
}
2016-09-20 19:00:57 +03:00
}
}
chained_irq_exit ( chip , desc ) ;
}
2018-04-26 19:18:29 +03:00
static int stm32_exti_set_type ( struct irq_data * d ,
unsigned int type , u32 * rtsr , u32 * ftsr )
2016-09-20 19:00:57 +03:00
{
2018-04-26 19:18:29 +03:00
u32 mask = BIT ( d - > hwirq % IRQS_PER_BANK ) ;
2016-09-20 19:00:57 +03:00
switch ( type ) {
case IRQ_TYPE_EDGE_RISING :
2018-04-26 19:18:29 +03:00
* rtsr | = mask ;
* ftsr & = ~ mask ;
2016-09-20 19:00:57 +03:00
break ;
case IRQ_TYPE_EDGE_FALLING :
2018-04-26 19:18:29 +03:00
* rtsr & = ~ mask ;
* ftsr | = mask ;
2016-09-20 19:00:57 +03:00
break ;
case IRQ_TYPE_EDGE_BOTH :
2018-04-26 19:18:29 +03:00
* rtsr | = mask ;
* ftsr | = mask ;
2016-09-20 19:00:57 +03:00
break ;
default :
return - EINVAL ;
}
2018-04-26 19:18:29 +03:00
return 0 ;
}
static int stm32_irq_set_type ( struct irq_data * d , unsigned int type )
{
struct irq_chip_generic * gc = irq_data_get_irq_chip_data ( d ) ;
struct stm32_exti_chip_data * chip_data = gc - > private ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
2020-07-06 11:11:15 +03:00
struct hwspinlock * hwlock = chip_data - > host_data - > hwlock ;
2018-04-26 19:18:29 +03:00
u32 rtsr , ftsr ;
int err ;
irq_gc_lock ( gc ) ;
2020-07-06 11:11:15 +03:00
if ( hwlock ) {
err = hwspin_lock_timeout_in_atomic ( hwlock , HWSPNLCK_TIMEOUT ) ;
if ( err ) {
pr_err ( " %s can't get hwspinlock (%d) \n " , __func__ , err ) ;
goto unlock ;
}
}
2018-12-17 17:22:14 +03:00
2018-04-26 19:18:29 +03:00
rtsr = irq_reg_readl ( gc , stm32_bank - > rtsr_ofst ) ;
ftsr = irq_reg_readl ( gc , stm32_bank - > ftsr_ofst ) ;
err = stm32_exti_set_type ( d , type , & rtsr , & ftsr ) ;
2018-12-17 17:22:14 +03:00
if ( err )
goto unspinlock ;
2018-04-26 19:18:29 +03:00
2017-11-06 20:03:32 +03:00
irq_reg_writel ( gc , rtsr , stm32_bank - > rtsr_ofst ) ;
irq_reg_writel ( gc , ftsr , stm32_bank - > ftsr_ofst ) ;
2016-09-20 19:00:57 +03:00
2018-12-17 17:22:14 +03:00
unspinlock :
2020-07-06 11:11:15 +03:00
if ( hwlock )
hwspin_unlock_in_atomic ( hwlock ) ;
2018-12-17 17:22:14 +03:00
unlock :
2016-09-20 19:00:57 +03:00
irq_gc_unlock ( gc ) ;
2018-12-17 17:22:14 +03:00
return err ;
2016-09-20 19:00:57 +03:00
}
2018-04-26 19:18:29 +03:00
static void stm32_chip_suspend ( struct stm32_exti_chip_data * chip_data ,
u32 wake_active )
2016-09-20 19:00:57 +03:00
{
2018-04-26 19:18:27 +03:00
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
2018-04-26 19:18:29 +03:00
void __iomem * base = chip_data - > host_data - > base ;
2016-09-20 19:00:57 +03:00
2018-04-26 19:18:27 +03:00
/* save rtsr, ftsr registers */
2018-04-26 19:18:29 +03:00
chip_data - > rtsr_cache = readl_relaxed ( base + stm32_bank - > rtsr_ofst ) ;
chip_data - > ftsr_cache = readl_relaxed ( base + stm32_bank - > ftsr_ofst ) ;
2018-04-26 19:18:27 +03:00
2018-04-26 19:18:29 +03:00
writel_relaxed ( wake_active , base + stm32_bank - > imr_ofst ) ;
}
2016-09-20 19:00:57 +03:00
2018-04-26 19:18:29 +03:00
static void stm32_chip_resume ( struct stm32_exti_chip_data * chip_data ,
u32 mask_cache )
{
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
void __iomem * base = chip_data - > host_data - > base ;
/* restore rtsr, ftsr, registers */
writel_relaxed ( chip_data - > rtsr_cache , base + stm32_bank - > rtsr_ofst ) ;
writel_relaxed ( chip_data - > ftsr_cache , base + stm32_bank - > ftsr_ofst ) ;
writel_relaxed ( mask_cache , base + stm32_bank - > imr_ofst ) ;
2018-04-26 19:18:27 +03:00
}
2016-09-20 19:00:57 +03:00
2018-04-26 19:18:29 +03:00
static void stm32_irq_suspend ( struct irq_chip_generic * gc )
2018-04-26 19:18:27 +03:00
{
struct stm32_exti_chip_data * chip_data = gc - > private ;
irq_gc_lock ( gc ) ;
2018-04-26 19:18:29 +03:00
stm32_chip_suspend ( chip_data , gc - > wake_active ) ;
irq_gc_unlock ( gc ) ;
}
2018-04-26 19:18:27 +03:00
2018-04-26 19:18:29 +03:00
static void stm32_irq_resume ( struct irq_chip_generic * gc )
{
struct stm32_exti_chip_data * chip_data = gc - > private ;
2018-04-26 19:18:27 +03:00
2018-04-26 19:18:29 +03:00
irq_gc_lock ( gc ) ;
stm32_chip_resume ( chip_data , gc - > mask_cache ) ;
2018-04-26 19:18:27 +03:00
irq_gc_unlock ( gc ) ;
2016-09-20 19:00:57 +03:00
}
static int stm32_exti_alloc ( struct irq_domain * d , unsigned int virq ,
unsigned int nr_irqs , void * data )
{
struct irq_fwspec * fwspec = data ;
irq_hw_number_t hwirq ;
hwirq = fwspec - > param [ 0 ] ;
irq_map_generic_chip ( d , virq , hwirq ) ;
return 0 ;
}
static void stm32_exti_free ( struct irq_domain * d , unsigned int virq ,
unsigned int nr_irqs )
{
struct irq_data * data = irq_domain_get_irq_data ( d , virq ) ;
irq_domain_reset_irq_data ( data ) ;
}
2018-04-26 19:18:25 +03:00
static const struct irq_domain_ops irq_exti_domain_ops = {
2016-09-20 19:00:57 +03:00
. map = irq_map_generic_chip ,
. alloc = stm32_exti_alloc ,
. free = stm32_exti_free ,
} ;
2018-04-26 19:18:26 +03:00
static void stm32_irq_ack ( struct irq_data * d )
{
struct irq_chip_generic * gc = irq_data_get_irq_chip_data ( d ) ;
2018-04-26 19:18:27 +03:00
struct stm32_exti_chip_data * chip_data = gc - > private ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
2018-04-26 19:18:26 +03:00
irq_gc_lock ( gc ) ;
irq_reg_writel ( gc , d - > mask , stm32_bank - > rpr_ofst ) ;
if ( stm32_bank - > fpr_ofst ! = UNDEF_REG )
irq_reg_writel ( gc , d - > mask , stm32_bank - > fpr_ofst ) ;
irq_gc_unlock ( gc ) ;
}
2018-04-26 19:18:30 +03:00
irqchip/stm32-exti: Avoid losing interrupts due to clearing pending bits by mistake
In the current code, when the eoi callback of the exti clears the pending
bit of the current interrupt, it will first read the values of fpr and
rpr, then logically OR the corresponding bit of the interrupt number,
and finally write back to fpr and rpr.
We found through experiments that if two exti interrupts,
we call them int1/int2, arrive almost at the same time. in our scenario,
the time difference is 30 microseconds, assuming int1 is triggered first.
there will be an extreme scenario: both int's pending bit are set to 1,
the irq handle of int1 is executed first, and eoi handle is then executed,
at this moment, all pending bits are cleared, but the int 2 has not
finally been reported to the cpu yet, which eventually lost int2.
According to stm32's TRM description about rpr and fpr: Writing a 1 to this
bit will trigger a rising edge event on event x, Writing 0 has no
effect.
Therefore, when clearing the pending bit, we only need to clear the
pending bit of the irq.
Fixes: 927abfc4461e7 ("irqchip/stm32: Add stm32mp1 support with hierarchy domain")
Signed-off-by: qiuguorui1 <qiuguorui1@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org # v4.18+
Link: https://lore.kernel.org/r/20200820031629.15582-1-qiuguorui1@huawei.com
2020-08-20 06:16:29 +03:00
/* directly set the target bit without reading first. */
static inline void stm32_exti_write_bit ( struct irq_data * d , u32 reg )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
void __iomem * base = chip_data - > host_data - > base ;
u32 val = BIT ( d - > hwirq % IRQS_PER_BANK ) ;
writel_relaxed ( val , base + reg ) ;
}
2018-04-26 19:18:30 +03:00
static inline u32 stm32_exti_set_bit ( struct irq_data * d , u32 reg )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
void __iomem * base = chip_data - > host_data - > base ;
u32 val ;
val = readl_relaxed ( base + reg ) ;
val | = BIT ( d - > hwirq % IRQS_PER_BANK ) ;
writel_relaxed ( val , base + reg ) ;
return val ;
}
static inline u32 stm32_exti_clr_bit ( struct irq_data * d , u32 reg )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
void __iomem * base = chip_data - > host_data - > base ;
u32 val ;
val = readl_relaxed ( base + reg ) ;
val & = ~ BIT ( d - > hwirq % IRQS_PER_BANK ) ;
writel_relaxed ( val , base + reg ) ;
return val ;
}
static void stm32_exti_h_eoi ( struct irq_data * d )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
raw_spin_lock ( & chip_data - > rlock ) ;
irqchip/stm32-exti: Avoid losing interrupts due to clearing pending bits by mistake
In the current code, when the eoi callback of the exti clears the pending
bit of the current interrupt, it will first read the values of fpr and
rpr, then logically OR the corresponding bit of the interrupt number,
and finally write back to fpr and rpr.
We found through experiments that if two exti interrupts,
we call them int1/int2, arrive almost at the same time. in our scenario,
the time difference is 30 microseconds, assuming int1 is triggered first.
there will be an extreme scenario: both int's pending bit are set to 1,
the irq handle of int1 is executed first, and eoi handle is then executed,
at this moment, all pending bits are cleared, but the int 2 has not
finally been reported to the cpu yet, which eventually lost int2.
According to stm32's TRM description about rpr and fpr: Writing a 1 to this
bit will trigger a rising edge event on event x, Writing 0 has no
effect.
Therefore, when clearing the pending bit, we only need to clear the
pending bit of the irq.
Fixes: 927abfc4461e7 ("irqchip/stm32: Add stm32mp1 support with hierarchy domain")
Signed-off-by: qiuguorui1 <qiuguorui1@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org # v4.18+
Link: https://lore.kernel.org/r/20200820031629.15582-1-qiuguorui1@huawei.com
2020-08-20 06:16:29 +03:00
stm32_exti_write_bit ( d , stm32_bank - > rpr_ofst ) ;
2018-04-26 19:18:30 +03:00
if ( stm32_bank - > fpr_ofst ! = UNDEF_REG )
irqchip/stm32-exti: Avoid losing interrupts due to clearing pending bits by mistake
In the current code, when the eoi callback of the exti clears the pending
bit of the current interrupt, it will first read the values of fpr and
rpr, then logically OR the corresponding bit of the interrupt number,
and finally write back to fpr and rpr.
We found through experiments that if two exti interrupts,
we call them int1/int2, arrive almost at the same time. in our scenario,
the time difference is 30 microseconds, assuming int1 is triggered first.
there will be an extreme scenario: both int's pending bit are set to 1,
the irq handle of int1 is executed first, and eoi handle is then executed,
at this moment, all pending bits are cleared, but the int 2 has not
finally been reported to the cpu yet, which eventually lost int2.
According to stm32's TRM description about rpr and fpr: Writing a 1 to this
bit will trigger a rising edge event on event x, Writing 0 has no
effect.
Therefore, when clearing the pending bit, we only need to clear the
pending bit of the irq.
Fixes: 927abfc4461e7 ("irqchip/stm32: Add stm32mp1 support with hierarchy domain")
Signed-off-by: qiuguorui1 <qiuguorui1@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org # v4.18+
Link: https://lore.kernel.org/r/20200820031629.15582-1-qiuguorui1@huawei.com
2020-08-20 06:16:29 +03:00
stm32_exti_write_bit ( d , stm32_bank - > fpr_ofst ) ;
2018-04-26 19:18:30 +03:00
raw_spin_unlock ( & chip_data - > rlock ) ;
if ( d - > parent_data - > chip )
irq_chip_eoi_parent ( d ) ;
}
static void stm32_exti_h_mask ( struct irq_data * d )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
raw_spin_lock ( & chip_data - > rlock ) ;
chip_data - > mask_cache = stm32_exti_clr_bit ( d , stm32_bank - > imr_ofst ) ;
raw_spin_unlock ( & chip_data - > rlock ) ;
if ( d - > parent_data - > chip )
irq_chip_mask_parent ( d ) ;
}
static void stm32_exti_h_unmask ( struct irq_data * d )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
raw_spin_lock ( & chip_data - > rlock ) ;
chip_data - > mask_cache = stm32_exti_set_bit ( d , stm32_bank - > imr_ofst ) ;
raw_spin_unlock ( & chip_data - > rlock ) ;
if ( d - > parent_data - > chip )
irq_chip_unmask_parent ( d ) ;
}
static int stm32_exti_h_set_type ( struct irq_data * d , unsigned int type )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
2020-07-06 11:11:15 +03:00
struct hwspinlock * hwlock = chip_data - > host_data - > hwlock ;
2018-04-26 19:18:30 +03:00
void __iomem * base = chip_data - > host_data - > base ;
u32 rtsr , ftsr ;
int err ;
raw_spin_lock ( & chip_data - > rlock ) ;
2018-12-17 17:22:14 +03:00
2020-07-06 11:11:15 +03:00
if ( hwlock ) {
err = hwspin_lock_timeout_in_atomic ( hwlock , HWSPNLCK_TIMEOUT ) ;
if ( err ) {
pr_err ( " %s can't get hwspinlock (%d) \n " , __func__ , err ) ;
goto unlock ;
}
}
2018-12-17 17:22:14 +03:00
2018-04-26 19:18:30 +03:00
rtsr = readl_relaxed ( base + stm32_bank - > rtsr_ofst ) ;
ftsr = readl_relaxed ( base + stm32_bank - > ftsr_ofst ) ;
err = stm32_exti_set_type ( d , type , & rtsr , & ftsr ) ;
2018-12-17 17:22:14 +03:00
if ( err )
goto unspinlock ;
2018-04-26 19:18:30 +03:00
writel_relaxed ( rtsr , base + stm32_bank - > rtsr_ofst ) ;
writel_relaxed ( ftsr , base + stm32_bank - > ftsr_ofst ) ;
2018-12-17 17:22:14 +03:00
unspinlock :
2020-07-06 11:11:15 +03:00
if ( hwlock )
hwspin_unlock_in_atomic ( hwlock ) ;
2018-12-17 17:22:14 +03:00
unlock :
2018-04-26 19:18:30 +03:00
raw_spin_unlock ( & chip_data - > rlock ) ;
2018-12-17 17:22:14 +03:00
return err ;
2018-04-26 19:18:30 +03:00
}
static int stm32_exti_h_set_wake ( struct irq_data * d , unsigned int on )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
u32 mask = BIT ( d - > hwirq % IRQS_PER_BANK ) ;
raw_spin_lock ( & chip_data - > rlock ) ;
if ( on )
chip_data - > wake_active | = mask ;
else
chip_data - > wake_active & = ~ mask ;
raw_spin_unlock ( & chip_data - > rlock ) ;
return 0 ;
}
static int stm32_exti_h_set_affinity ( struct irq_data * d ,
const struct cpumask * dest , bool force )
{
if ( d - > parent_data - > chip )
return irq_chip_set_affinity_parent ( d , dest , force ) ;
return - EINVAL ;
}
2019-04-17 16:02:56 +03:00
static int __maybe_unused stm32_exti_h_suspend ( void )
2018-04-26 19:18:31 +03:00
{
struct stm32_exti_chip_data * chip_data ;
int i ;
for ( i = 0 ; i < stm32_host_data - > drv_data - > bank_nr ; i + + ) {
chip_data = & stm32_host_data - > chips_data [ i ] ;
raw_spin_lock ( & chip_data - > rlock ) ;
stm32_chip_suspend ( chip_data , chip_data - > wake_active ) ;
raw_spin_unlock ( & chip_data - > rlock ) ;
}
return 0 ;
}
2019-04-17 16:02:56 +03:00
static void __maybe_unused stm32_exti_h_resume ( void )
2018-04-26 19:18:31 +03:00
{
struct stm32_exti_chip_data * chip_data ;
int i ;
for ( i = 0 ; i < stm32_host_data - > drv_data - > bank_nr ; i + + ) {
chip_data = & stm32_host_data - > chips_data [ i ] ;
raw_spin_lock ( & chip_data - > rlock ) ;
stm32_chip_resume ( chip_data , chip_data - > mask_cache ) ;
raw_spin_unlock ( & chip_data - > rlock ) ;
}
}
static struct syscore_ops stm32_exti_h_syscore_ops = {
2019-04-17 16:02:56 +03:00
# ifdef CONFIG_PM_SLEEP
2018-04-26 19:18:31 +03:00
. suspend = stm32_exti_h_suspend ,
. resume = stm32_exti_h_resume ,
2019-04-17 16:02:56 +03:00
# endif
2018-04-26 19:18:31 +03:00
} ;
2019-04-17 16:02:56 +03:00
static void stm32_exti_h_syscore_init ( struct stm32_exti_host_data * host_data )
2018-04-26 19:18:31 +03:00
{
2019-04-17 16:02:56 +03:00
stm32_host_data = host_data ;
2018-04-26 19:18:31 +03:00
register_syscore_ops ( & stm32_exti_h_syscore_ops ) ;
}
2019-04-17 16:02:56 +03:00
static void stm32_exti_h_syscore_deinit ( void )
{
unregister_syscore_ops ( & stm32_exti_h_syscore_ops ) ;
}
2018-04-26 19:18:31 +03:00
2020-02-19 17:32:28 +03:00
static int stm32_exti_h_retrigger ( struct irq_data * d )
{
struct stm32_exti_chip_data * chip_data = irq_data_get_irq_chip_data ( d ) ;
const struct stm32_exti_bank * stm32_bank = chip_data - > reg_bank ;
void __iomem * base = chip_data - > host_data - > base ;
u32 mask = BIT ( d - > hwirq % IRQS_PER_BANK ) ;
writel_relaxed ( mask , base + stm32_bank - > swier_ofst ) ;
return 0 ;
}
2018-04-26 19:18:30 +03:00
static struct irq_chip stm32_exti_h_chip = {
. name = " stm32-exti-h " ,
. irq_eoi = stm32_exti_h_eoi ,
. irq_mask = stm32_exti_h_mask ,
. irq_unmask = stm32_exti_h_unmask ,
2020-02-19 17:32:28 +03:00
. irq_retrigger = stm32_exti_h_retrigger ,
2018-04-26 19:18:30 +03:00
. irq_set_type = stm32_exti_h_set_type ,
. irq_set_wake = stm32_exti_h_set_wake ,
. flags = IRQCHIP_MASK_ON_SUSPEND ,
2018-06-05 14:43:34 +03:00
. irq_set_affinity = IS_ENABLED ( CONFIG_SMP ) ? stm32_exti_h_set_affinity : NULL ,
2018-04-26 19:18:30 +03:00
} ;
2020-07-17 17:07:17 +03:00
static struct irq_chip stm32_exti_h_chip_direct = {
. name = " stm32-exti-h-direct " ,
. irq_eoi = irq_chip_eoi_parent ,
. irq_ack = irq_chip_ack_parent ,
. irq_mask = irq_chip_mask_parent ,
. irq_unmask = irq_chip_unmask_parent ,
. irq_retrigger = irq_chip_retrigger_hierarchy ,
. irq_set_type = irq_chip_set_type_parent ,
. irq_set_wake = stm32_exti_h_set_wake ,
. flags = IRQCHIP_MASK_ON_SUSPEND ,
. irq_set_affinity = IS_ENABLED ( CONFIG_SMP ) ? irq_chip_set_affinity_parent : NULL ,
} ;
2018-04-26 19:18:30 +03:00
static int stm32_exti_h_domain_alloc ( struct irq_domain * dm ,
unsigned int virq ,
unsigned int nr_irqs , void * data )
{
struct stm32_exti_host_data * host_data = dm - > host_data ;
struct stm32_exti_chip_data * chip_data ;
2020-07-17 17:07:17 +03:00
const struct stm32_desc_irq * desc ;
2018-04-26 19:18:30 +03:00
struct irq_fwspec * fwspec = data ;
struct irq_fwspec p_fwspec ;
irq_hw_number_t hwirq ;
2020-07-17 17:07:17 +03:00
int bank ;
2018-04-26 19:18:30 +03:00
hwirq = fwspec - > param [ 0 ] ;
bank = hwirq / IRQS_PER_BANK ;
chip_data = & host_data - > chips_data [ bank ] ;
2020-07-17 17:07:17 +03:00
desc = stm32_exti_get_desc ( host_data - > drv_data , hwirq ) ;
if ( ! desc )
return - EINVAL ;
irq_domain_set_hwirq_and_chip ( dm , virq , hwirq , desc - > chip ,
chip_data ) ;
if ( desc - > irq_parent ) {
2018-04-26 19:18:30 +03:00
p_fwspec . fwnode = dm - > parent - > fwnode ;
p_fwspec . param_count = 3 ;
p_fwspec . param [ 0 ] = GIC_SPI ;
2020-07-17 17:07:17 +03:00
p_fwspec . param [ 1 ] = desc - > irq_parent ;
2018-04-26 19:18:30 +03:00
p_fwspec . param [ 2 ] = IRQ_TYPE_LEVEL_HIGH ;
return irq_domain_alloc_irqs_parent ( dm , virq , 1 , & p_fwspec ) ;
}
return 0 ;
}
2018-04-26 19:18:28 +03:00
static struct
stm32_exti_host_data * stm32_exti_host_init ( const struct stm32_exti_drv_data * dd ,
struct device_node * node )
{
struct stm32_exti_host_data * host_data ;
host_data = kzalloc ( sizeof ( * host_data ) , GFP_KERNEL ) ;
if ( ! host_data )
return NULL ;
host_data - > drv_data = dd ;
host_data - > chips_data = kcalloc ( dd - > bank_nr ,
sizeof ( struct stm32_exti_chip_data ) ,
GFP_KERNEL ) ;
if ( ! host_data - > chips_data )
2018-08-08 15:03:19 +03:00
goto free_host_data ;
2018-04-26 19:18:28 +03:00
host_data - > base = of_iomap ( node , 0 ) ;
if ( ! host_data - > base ) {
pr_err ( " %pOF: Unable to map registers \n " , node ) ;
2018-08-08 15:03:19 +03:00
goto free_chips_data ;
2018-04-26 19:18:28 +03:00
}
2018-04-26 19:18:26 +03:00
2018-04-26 19:18:31 +03:00
stm32_host_data = host_data ;
2018-04-26 19:18:28 +03:00
return host_data ;
2018-08-08 15:03:19 +03:00
free_chips_data :
kfree ( host_data - > chips_data ) ;
free_host_data :
kfree ( host_data ) ;
return NULL ;
2018-04-26 19:18:28 +03:00
}
static struct
stm32_exti_chip_data * stm32_exti_chip_init ( struct stm32_exti_host_data * h_data ,
2019-04-17 16:02:56 +03:00
u32 bank_idx ,
struct device_node * node )
2018-04-26 19:18:28 +03:00
{
const struct stm32_exti_bank * stm32_bank ;
struct stm32_exti_chip_data * chip_data ;
void __iomem * base = h_data - > base ;
stm32_bank = h_data - > drv_data - > exti_banks [ bank_idx ] ;
chip_data = & h_data - > chips_data [ bank_idx ] ;
chip_data - > host_data = h_data ;
chip_data - > reg_bank = stm32_bank ;
2018-04-26 19:18:30 +03:00
raw_spin_lock_init ( & chip_data - > rlock ) ;
2018-04-26 19:18:28 +03:00
/*
* This IP has no reset , so after hot reboot we should
* clear registers to avoid residue
*/
writel_relaxed ( 0 , base + stm32_bank - > imr_ofst ) ;
writel_relaxed ( 0 , base + stm32_bank - > emr_ofst ) ;
2019-04-17 16:02:56 +03:00
pr_info ( " %pOF: bank%d \n " , node , bank_idx ) ;
2018-04-26 19:18:28 +03:00
return chip_data ;
}
static int __init stm32_exti_init ( const struct stm32_exti_drv_data * drv_data ,
struct device_node * node )
2016-09-20 19:00:57 +03:00
{
2018-04-26 19:18:28 +03:00
struct stm32_exti_host_data * host_data ;
2016-09-20 19:00:57 +03:00
unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN ;
2018-04-26 19:18:28 +03:00
int nr_irqs , ret , i ;
2016-09-20 19:00:57 +03:00
struct irq_chip_generic * gc ;
struct irq_domain * domain ;
2018-04-26 19:18:28 +03:00
host_data = stm32_exti_host_init ( drv_data , node ) ;
2018-08-08 15:03:19 +03:00
if ( ! host_data )
return - ENOMEM ;
2016-09-20 19:00:57 +03:00
2018-04-26 19:18:28 +03:00
domain = irq_domain_add_linear ( node , drv_data - > bank_nr * IRQS_PER_BANK ,
2016-09-20 19:00:57 +03:00
& irq_exti_domain_ops , NULL ) ;
if ( ! domain ) {
2018-11-23 19:54:18 +03:00
pr_err ( " %pOFn: Could not register interrupt domain. \n " ,
node ) ;
2016-09-20 19:00:57 +03:00
ret = - ENOMEM ;
goto out_unmap ;
}
2017-11-06 20:03:32 +03:00
ret = irq_alloc_domain_generic_chips ( domain , IRQS_PER_BANK , 1 , " exti " ,
2016-09-20 19:00:57 +03:00
handle_edge_irq , clr , 0 , 0 ) ;
if ( ret ) {
2017-07-19 00:43:10 +03:00
pr_err ( " %pOF: Could not allocate generic interrupt chip. \n " ,
2018-04-26 19:18:25 +03:00
node ) ;
2016-09-20 19:00:57 +03:00
goto out_free_domain ;
}
2018-04-26 19:18:28 +03:00
for ( i = 0 ; i < drv_data - > bank_nr ; i + + ) {
const struct stm32_exti_bank * stm32_bank ;
struct stm32_exti_chip_data * chip_data ;
2017-11-06 20:03:32 +03:00
2018-04-26 19:18:28 +03:00
stm32_bank = drv_data - > exti_banks [ i ] ;
2019-04-17 16:02:56 +03:00
chip_data = stm32_exti_chip_init ( host_data , i , node ) ;
2018-04-26 19:18:27 +03:00
2017-11-06 20:03:32 +03:00
gc = irq_get_domain_generic_chip ( domain , i * IRQS_PER_BANK ) ;
2018-04-26 19:18:28 +03:00
gc - > reg_base = host_data - > base ;
2017-11-06 20:03:32 +03:00
gc - > chip_types - > type = IRQ_TYPE_EDGE_BOTH ;
2018-04-26 19:18:26 +03:00
gc - > chip_types - > chip . irq_ack = stm32_irq_ack ;
2017-11-06 20:03:32 +03:00
gc - > chip_types - > chip . irq_mask = irq_gc_mask_clr_bit ;
gc - > chip_types - > chip . irq_unmask = irq_gc_mask_set_bit ;
gc - > chip_types - > chip . irq_set_type = stm32_irq_set_type ;
2018-04-26 19:18:27 +03:00
gc - > chip_types - > chip . irq_set_wake = irq_gc_set_wake ;
gc - > suspend = stm32_irq_suspend ;
gc - > resume = stm32_irq_resume ;
gc - > wake_enabled = IRQ_MSK ( IRQS_PER_BANK ) ;
2017-11-06 20:03:32 +03:00
gc - > chip_types - > regs . mask = stm32_bank - > imr_ofst ;
2018-04-26 19:18:27 +03:00
gc - > private = ( void * ) chip_data ;
2017-11-06 20:03:32 +03:00
}
2016-09-20 19:00:57 +03:00
nr_irqs = of_irq_count ( node ) ;
for ( i = 0 ; i < nr_irqs ; i + + ) {
unsigned int irq = irq_of_parse_and_map ( node , i ) ;
irq_set_handler_data ( irq , domain ) ;
irq_set_chained_handler ( irq , stm32_irq_handler ) ;
}
return 0 ;
out_free_domain :
irq_domain_remove ( domain ) ;
out_unmap :
2018-04-26 19:18:28 +03:00
iounmap ( host_data - > base ) ;
kfree ( host_data - > chips_data ) ;
kfree ( host_data ) ;
2016-09-20 19:00:57 +03:00
return ret ;
}
2018-04-26 19:18:30 +03:00
static const struct irq_domain_ops stm32_exti_h_domain_ops = {
. alloc = stm32_exti_h_domain_alloc ,
. free = irq_domain_free_irqs_common ,
2019-01-11 20:54:31 +03:00
. xlate = irq_domain_xlate_twocell ,
2018-04-26 19:18:30 +03:00
} ;
2019-04-17 16:02:56 +03:00
static void stm32_exti_remove_irq ( void * data )
{
struct irq_domain * domain = data ;
irq_domain_remove ( domain ) ;
}
static int stm32_exti_remove ( struct platform_device * pdev )
{
stm32_exti_h_syscore_deinit ( ) ;
return 0 ;
}
static int stm32_exti_probe ( struct platform_device * pdev )
2018-04-26 19:18:30 +03:00
{
2019-04-17 16:02:56 +03:00
int ret , i ;
struct device * dev = & pdev - > dev ;
struct device_node * np = dev - > of_node ;
2018-04-26 19:18:30 +03:00
struct irq_domain * parent_domain , * domain ;
struct stm32_exti_host_data * host_data ;
2019-04-17 16:02:56 +03:00
const struct stm32_exti_drv_data * drv_data ;
struct resource * res ;
2018-04-26 19:18:30 +03:00
2019-04-17 16:02:56 +03:00
host_data = devm_kzalloc ( dev , sizeof ( * host_data ) , GFP_KERNEL ) ;
if ( ! host_data )
return - ENOMEM ;
/* check for optional hwspinlock which may be not available yet */
ret = of_hwspin_lock_get_id ( np , 0 ) ;
if ( ret = = - EPROBE_DEFER )
/* hwspinlock framework not yet ready */
return ret ;
if ( ret > = 0 ) {
host_data - > hwlock = devm_hwspin_lock_request_specific ( dev , ret ) ;
if ( ! host_data - > hwlock ) {
dev_err ( dev , " Failed to request hwspinlock \n " ) ;
return - EINVAL ;
}
} else if ( ret ! = - ENOENT ) {
/* note: ENOENT is a valid case (means 'no hwspinlock') */
dev_err ( dev , " Failed to get hwspinlock \n " ) ;
return ret ;
2018-04-26 19:18:30 +03:00
}
2019-04-17 16:02:56 +03:00
/* initialize host_data */
drv_data = of_device_get_match_data ( dev ) ;
if ( ! drv_data ) {
dev_err ( dev , " no of match data \n " ) ;
return - ENODEV ;
}
host_data - > drv_data = drv_data ;
host_data - > chips_data = devm_kcalloc ( dev , drv_data - > bank_nr ,
sizeof ( * host_data - > chips_data ) ,
GFP_KERNEL ) ;
if ( ! host_data - > chips_data )
2018-08-08 15:03:19 +03:00
return - ENOMEM ;
2018-04-26 19:18:30 +03:00
2019-04-17 16:02:56 +03:00
res = platform_get_resource ( pdev , IORESOURCE_MEM , 0 ) ;
host_data - > base = devm_ioremap_resource ( dev , res ) ;
if ( IS_ERR ( host_data - > base ) ) {
dev_err ( dev , " Unable to map registers \n " ) ;
return PTR_ERR ( host_data - > base ) ;
}
2018-04-26 19:18:30 +03:00
for ( i = 0 ; i < drv_data - > bank_nr ; i + + )
2019-04-17 16:02:56 +03:00
stm32_exti_chip_init ( host_data , i , np ) ;
parent_domain = irq_find_host ( of_irq_find_parent ( np ) ) ;
if ( ! parent_domain ) {
dev_err ( dev , " GIC interrupt-parent not found \n " ) ;
return - EINVAL ;
}
2018-04-26 19:18:30 +03:00
domain = irq_domain_add_hierarchy ( parent_domain , 0 ,
drv_data - > bank_nr * IRQS_PER_BANK ,
2019-04-17 16:02:56 +03:00
np , & stm32_exti_h_domain_ops ,
2018-04-26 19:18:30 +03:00
host_data ) ;
if ( ! domain ) {
2019-04-17 16:02:56 +03:00
dev_err ( dev , " Could not register exti domain \n " ) ;
return - ENOMEM ;
2018-04-26 19:18:30 +03:00
}
2019-04-17 16:02:56 +03:00
ret = devm_add_action_or_reset ( dev , stm32_exti_remove_irq , domain ) ;
if ( ret )
return ret ;
stm32_exti_h_syscore_init ( host_data ) ;
2018-04-26 19:18:31 +03:00
2018-04-26 19:18:30 +03:00
return 0 ;
2019-04-17 16:02:56 +03:00
}
2018-04-26 19:18:30 +03:00
2019-04-17 16:02:56 +03:00
/* platform driver only for MP1 */
static const struct of_device_id stm32_exti_ids [ ] = {
{ . compatible = " st,stm32mp1-exti " , . data = & stm32mp1_drv_data } ,
{ } ,
} ;
MODULE_DEVICE_TABLE ( of , stm32_exti_ids ) ;
static struct platform_driver stm32_exti_driver = {
. probe = stm32_exti_probe ,
. remove = stm32_exti_remove ,
. driver = {
. name = " stm32_exti " ,
. of_match_table = stm32_exti_ids ,
} ,
} ;
static int __init stm32_exti_arch_init ( void )
{
return platform_driver_register ( & stm32_exti_driver ) ;
2018-04-26 19:18:30 +03:00
}
2019-04-17 16:02:56 +03:00
static void __exit stm32_exti_arch_exit ( void )
{
return platform_driver_unregister ( & stm32_exti_driver ) ;
}
arch_initcall ( stm32_exti_arch_init ) ;
module_exit ( stm32_exti_arch_exit ) ;
/* no platform driver for F4 and H7 */
2017-11-06 20:03:32 +03:00
static int __init stm32f4_exti_of_init ( struct device_node * np ,
struct device_node * parent )
{
2018-04-26 19:18:28 +03:00
return stm32_exti_init ( & stm32f4xx_drv_data , np ) ;
2017-11-06 20:03:32 +03:00
}
IRQCHIP_DECLARE ( stm32f4_exti , " st,stm32-exti " , stm32f4_exti_of_init ) ;
2017-11-06 20:03:34 +03:00
static int __init stm32h7_exti_of_init ( struct device_node * np ,
struct device_node * parent )
{
2018-04-26 19:18:28 +03:00
return stm32_exti_init ( & stm32h7xx_drv_data , np ) ;
2017-11-06 20:03:34 +03:00
}
IRQCHIP_DECLARE ( stm32h7_exti , " st,stm32h7-exti " , stm32h7_exti_of_init ) ;