2014-06-10 09:06:10 -05:00
menuconfig ARCH_U8500
ARM: use "depends on" for SoC configs instead of "if" after prompt
Many ARM sub-architectures use prompts followed by "if" conditional,
but it is wrong.
Please notice the difference between
config ARCH_FOO
bool "Foo SoCs" if ARCH_MULTI_V7
and
config ARCH_FOO
bool "Foo SoCs"
depends on ARCH_MULTI_V7
These two are *not* equivalent!
In the former statement, it is not ARCH_FOO, but its prompt that
depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
not unmet dependency, Kconfig never warns. This is probably not what
you want.
The former should be used only when you need to do so, and you really
understand what you are doing. (In most cases, it should be wrong!)
For enabling/disabling sub-architectures, the latter is always correct.
As a good side effect, this commit fixes some entries over 80 columns
(mach-imx, mach-integrator, mach-mbevu).
[Arnd: I note that there is not really a bug here, according to
the discussion that followed, but I can see value in being consistent
and in making the lines shorter]
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jun Nie <jun.nie@linaro.org>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Krzysztof Halasa <khc@piap.pl>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
2015-11-16 12:06:10 +09:00
bool "ST-Ericsson U8500 Series"
depends on ARCH_MULTI_V7 && MMU
2013-10-01 11:08:56 +02:00
select AB8500_CORE
select ABX500_CORE
2013-03-21 22:51:13 +01:00
select ARCH_REQUIRE_GPIOLIB
select ARM_AMBA
2013-10-01 11:08:56 +02:00
select ARM_ERRATA_754322
select ARM_ERRATA_764369 if SMP
select ARM_GIC
select CACHE_L2X0
select CLKSRC_NOMADIK_MTU
2013-02-27 15:28:14 -08:00
select HAVE_ARM_SCU if SMP
2013-02-15 16:02:20 -08:00
select HAVE_ARM_TWD if SMP
2013-10-01 11:08:56 +02:00
select PINCTRL
select PINCTRL_ABX500
select PINCTRL_NOMADIK
2014-06-19 10:19:10 +01:00
select PL310_ERRATA_753970 if CACHE_L2X0
2013-03-21 22:51:13 +01:00
help
Support for ST-Ericsson's Ux500 architecture
2010-05-03 07:27:31 +01:00
if ARCH_U8500
2010-12-08 11:08:01 +05:30
config UX500_SOC_DB8500
2012-02-25 12:48:50 -07:00
bool
2011-05-15 22:53:56 +02:00
select MFD_DB8500_PRCMU
ARM: config: sort select statements alphanumerically
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2012-10-06 17:12:25 +01:00
select PINCTRL_DB8500
2013-01-28 14:43:55 +01:00
select PINCTRL_DB8540
2013-01-08 10:59:53 +01:00
select PINCTRL_AB8500
2013-01-28 14:23:45 +01:00
select PINCTRL_AB8505
2013-01-28 14:29:35 +01:00
select PINCTRL_AB9540
2013-01-28 14:35:19 +01:00
select PINCTRL_AB8540
2012-04-13 15:08:01 +02:00
select REGULATOR
2011-04-01 14:43:33 +02:00
select REGULATOR_DB8500_PRCMU
2015-11-01 21:16:01 +01:00
select CLKSRC_DBX500_PRCMU
2014-10-14 11:12:57 +02:00
select PM_GENERIC_DOMAINS if PM
2010-12-08 11:08:01 +05:30
2012-02-29 18:15:20 +01:00
config MACH_MOP500
bool "U8500 Development platform, MOP500 versions"
select I2C
select I2C_NOMADIK
2013-05-15 09:36:41 -03:00
select REGULATOR
2012-09-03 14:33:39 +01:00
select REGULATOR_FIXED_VOLTAGE
ARM: config: sort select statements alphanumerically
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2012-10-06 17:12:25 +01:00
select SOC_BUS
select UX500_SOC_DB8500
2009-11-28 08:17:18 +01:00
help
2012-02-29 18:15:20 +01:00
Include support for the MOP500 development platform.
2010-05-03 08:46:51 +01:00
2011-03-31 09:07:20 +02:00
config MACH_HREFV60
2012-02-29 18:15:20 +01:00
bool "U8500 Development platform, HREFv60 version"
select MACH_MOP500
help
Include support for the HREFv60 new development platform.
Includes HREFv70, v71 etc.
2011-03-31 09:07:20 +02:00
2011-03-25 09:29:01 -06:00
config MACH_SNOWBALL
bool "U8500 Snowball platform"
2012-02-29 18:15:20 +01:00
select MACH_MOP500
2011-03-25 09:29:01 -06:00
help
Include support for the snowball development platform.
2012-02-25 12:48:50 -07:00
config UX500_AUTO_PLATFORM
def_bool y
2012-02-29 18:15:20 +01:00
select MACH_MOP500
2012-02-25 12:48:50 -07:00
help
At least one platform needs to be selected in order to build
a working kernel. If everything else is disabled, this
2012-02-29 18:15:20 +01:00
automatically enables MACH_MOP500.
2012-03-28 12:34:33 -07:00
2010-05-03 07:38:06 +01:00
config UX500_DEBUG_UART
int "Ux500 UART to use for low-level debug"
default 2
help
Choose the UART on which kernel low-level debug messages should be
output.
2010-05-03 07:27:31 +01:00
endif