2008-04-24 00:37:04 +02:00
/*
* Glue code for the ISP1760 driver and bus
* Currently there is support for
* - OpenFirmware
* - PCI
*
* ( c ) 2007 Sebastian Siewior < bigeasy @ linutronix . de >
*
*/
# include <linux/usb.h>
# include <linux/io.h>
2009-02-10 16:55:51 +00:00
# include <linux/platform_device.h>
2008-04-24 00:37:04 +02:00
# include "../core/hcd.h"
# include "isp1760-hcd.h"
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PPC_OF
2008-04-24 00:37:04 +02:00
# include <linux/of.h>
# include <linux/of_platform.h>
# endif
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PCI
2008-04-24 00:37:04 +02:00
# include <linux/pci.h>
# endif
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PPC_OF
2008-04-24 00:37:04 +02:00
static int of_isp1760_probe ( struct of_device * dev ,
const struct of_device_id * match )
{
struct usb_hcd * hcd ;
struct device_node * dp = dev - > node ;
struct resource * res ;
struct resource memory ;
struct of_irq oirq ;
int virq ;
u64 res_len ;
int ret ;
2008-06-17 11:11:38 -05:00
const unsigned int * prop ;
unsigned int devflags = 0 ;
2008-04-24 00:37:04 +02:00
ret = of_address_to_resource ( dp , 0 , & memory ) ;
if ( ret )
return - ENXIO ;
res = request_mem_region ( memory . start , memory . end - memory . start + 1 ,
2008-05-02 06:02:41 +02:00
dev_name ( & dev - > dev ) ) ;
2008-04-24 00:37:04 +02:00
if ( ! res )
return - EBUSY ;
res_len = memory . end - memory . start + 1 ;
if ( of_irq_map_one ( dp , 0 , & oirq ) ) {
ret = - ENODEV ;
goto release_reg ;
}
virq = irq_create_of_mapping ( oirq . controller , oirq . specifier ,
oirq . size ) ;
2008-06-17 11:11:38 -05:00
if ( of_device_is_compatible ( dp , " nxp,usb-isp1761 " ) )
devflags | = ISP1760_FLAG_ISP1761 ;
/* Some systems wire up only 16 of the 32 data lines */
prop = of_get_property ( dp , " bus-width " , NULL ) ;
if ( prop & & * prop = = 16 )
devflags | = ISP1760_FLAG_BUS_WIDTH_16 ;
if ( of_get_property ( dp , " port1-otg " , NULL ) ! = NULL )
devflags | = ISP1760_FLAG_OTG_EN ;
if ( of_get_property ( dp , " analog-oc " , NULL ) ! = NULL )
devflags | = ISP1760_FLAG_ANALOG_OC ;
if ( of_get_property ( dp , " dack-polarity " , NULL ) ! = NULL )
devflags | = ISP1760_FLAG_DACK_POL_HIGH ;
if ( of_get_property ( dp , " dreq-polarity " , NULL ) ! = NULL )
devflags | = ISP1760_FLAG_DREQ_POL_HIGH ;
2008-04-24 00:37:04 +02:00
hcd = isp1760_register ( memory . start , res_len , virq ,
2008-06-17 11:11:38 -05:00
IRQF_SHARED | IRQF_DISABLED , & dev - > dev , dev_name ( & dev - > dev ) ,
devflags ) ;
2008-04-24 00:37:04 +02:00
if ( IS_ERR ( hcd ) ) {
ret = PTR_ERR ( hcd ) ;
goto release_reg ;
}
dev_set_drvdata ( & dev - > dev , hcd ) ;
return ret ;
release_reg :
release_mem_region ( memory . start , memory . end - memory . start + 1 ) ;
return ret ;
}
static int of_isp1760_remove ( struct of_device * dev )
{
struct usb_hcd * hcd = dev_get_drvdata ( & dev - > dev ) ;
dev_set_drvdata ( & dev - > dev , NULL ) ;
usb_remove_hcd ( hcd ) ;
iounmap ( hcd - > regs ) ;
release_mem_region ( hcd - > rsrc_start , hcd - > rsrc_len ) ;
usb_put_hcd ( hcd ) ;
return 0 ;
}
static struct of_device_id of_isp1760_match [ ] = {
{
. compatible = " nxp,usb-isp1760 " ,
} ,
2008-06-17 11:11:38 -05:00
{
. compatible = " nxp,usb-isp1761 " ,
} ,
2008-04-24 00:37:04 +02:00
{ } ,
} ;
MODULE_DEVICE_TABLE ( of , of_isp1760_match ) ;
static struct of_platform_driver isp1760_of_driver = {
. name = " nxp-isp1760 " ,
. match_table = of_isp1760_match ,
. probe = of_isp1760_probe ,
. remove = of_isp1760_remove ,
} ;
# endif
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PCI
2008-04-24 00:37:04 +02:00
static int __devinit isp1761_pci_probe ( struct pci_dev * dev ,
const struct pci_device_id * id )
{
u8 latency , limit ;
__u32 reg_data ;
int retry_count ;
struct usb_hcd * hcd ;
2008-06-17 11:11:38 -05:00
unsigned int devflags = 0 ;
2008-12-01 11:47:40 +01:00
int ret_status = 0 ;
resource_size_t pci_mem_phy0 ;
resource_size_t memlength ;
u8 __iomem * chip_addr ;
u8 __iomem * iobase ;
resource_size_t nxp_pci_io_base ;
resource_size_t iolength ;
2008-04-24 00:37:04 +02:00
if ( usb_disabled ( ) )
return - ENODEV ;
if ( pci_enable_device ( dev ) < 0 )
return - ENODEV ;
if ( ! dev - > irq )
return - ENODEV ;
/* Grab the PLX PCI mem maped port start address we need */
nxp_pci_io_base = pci_resource_start ( dev , 0 ) ;
iolength = pci_resource_len ( dev , 0 ) ;
if ( ! request_mem_region ( nxp_pci_io_base , iolength , " ISP1761 IO MEM " ) ) {
printk ( KERN_ERR " request region #1 \n " ) ;
return - EBUSY ;
}
iobase = ioremap_nocache ( nxp_pci_io_base , iolength ) ;
if ( ! iobase ) {
printk ( KERN_ERR " ioremap #1 \n " ) ;
2008-12-01 11:47:40 +01:00
ret_status = - ENOMEM ;
goto cleanup1 ;
2008-04-24 00:37:04 +02:00
}
/* Grab the PLX PCI shared memory of the ISP 1761 we need */
pci_mem_phy0 = pci_resource_start ( dev , 3 ) ;
2008-12-01 11:47:40 +01:00
memlength = pci_resource_len ( dev , 3 ) ;
if ( memlength < 0xffff ) {
printk ( KERN_ERR " memory length for this resource is wrong \n " ) ;
ret_status = - ENOMEM ;
goto cleanup2 ;
2008-04-24 00:37:04 +02:00
}
2008-12-01 11:47:40 +01:00
if ( ! request_mem_region ( pci_mem_phy0 , memlength , " ISP-PCI " ) ) {
2008-04-24 00:37:04 +02:00
printk ( KERN_ERR " host controller already in use \n " ) ;
2008-12-01 11:47:40 +01:00
ret_status = - EBUSY ;
goto cleanup2 ;
}
/* map available memory */
chip_addr = ioremap_nocache ( pci_mem_phy0 , memlength ) ;
if ( ! chip_addr ) {
printk ( KERN_ERR " Error ioremap failed \n " ) ;
ret_status = - ENOMEM ;
goto cleanup3 ;
2008-04-24 00:37:04 +02:00
}
/* bad pci latencies can contribute to overruns */
pci_read_config_byte ( dev , PCI_LATENCY_TIMER , & latency ) ;
if ( latency ) {
pci_read_config_byte ( dev , PCI_MAX_LAT , & limit ) ;
if ( limit & & limit < latency )
pci_write_config_byte ( dev , PCI_LATENCY_TIMER , limit ) ;
}
/* Try to check whether we can access Scratch Register of
* Host Controller or not . The initial PCI access is retried until
* local init for the PCI bridge is completed
*/
retry_count = 20 ;
reg_data = 0 ;
while ( ( reg_data ! = 0xFACE ) & & retry_count ) {
/*by default host is in 16bit mode, so
* io operations at this stage must be 16 bit
* */
writel ( 0xface , chip_addr + HC_SCRATCH_REG ) ;
udelay ( 100 ) ;
2008-12-01 11:47:40 +01:00
reg_data = readl ( chip_addr + HC_SCRATCH_REG ) & 0x0000ffff ;
2008-04-24 00:37:04 +02:00
retry_count - - ;
}
2008-12-01 11:47:40 +01:00
iounmap ( chip_addr ) ;
2008-04-24 00:37:04 +02:00
/* Host Controller presence is detected by writing to scratch register
* and reading back and checking the contents are same or not
*/
if ( reg_data ! = 0xFACE ) {
2008-08-14 09:37:34 -07:00
dev_err ( & dev - > dev , " scratch register mismatch %x \n " , reg_data ) ;
2008-12-01 11:47:40 +01:00
ret_status = - ENOMEM ;
goto cleanup3 ;
2008-04-24 00:37:04 +02:00
}
pci_set_master ( dev ) ;
2008-12-01 11:47:40 +01:00
/* configure PLX PCI chip to pass interrupts */
# define PLX_INT_CSR_REG 0x68
reg_data = readl ( iobase + PLX_INT_CSR_REG ) ;
reg_data | = 0x900 ;
writel ( reg_data , iobase + PLX_INT_CSR_REG ) ;
2008-04-24 00:37:04 +02:00
dev - > dev . dma_mask = NULL ;
2008-12-01 11:47:40 +01:00
hcd = isp1760_register ( pci_mem_phy0 , memlength , dev - > irq ,
2008-06-17 11:11:38 -05:00
IRQF_SHARED | IRQF_DISABLED , & dev - > dev , dev_name ( & dev - > dev ) ,
devflags ) ;
2008-12-01 11:47:40 +01:00
if ( IS_ERR ( hcd ) ) {
ret_status = - ENODEV ;
goto cleanup3 ;
USB: isp1760: Use an IS_ERR test rather than a NULL test
In case of error, the function isp1760_register returns an ERR
pointer, but never returns a NULL pointer. So after a call to this
function, a NULL test should be replaced by an IS_ERR test. Moreover,
we have noticed that:
(1) the result of isp1760_register is assigned through the function
pci_set_drvdata without an error test,
(2) if the call to isp1760_register fails, the current function
(isp1761_pci_probe) returns 0, and if it succeeds, it returns -ENOMEM,
which seems odd.
Thus, we suggest to move the test before the call to pci_set_drvdata
to correct (1), and to turn it into a non IS_ERR test to correct (2).
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@bad_null_test@
expression x,E;
statement S1, S2;
@@
x = isp1760_register(...)
... when != x = E
* if (x == NULL)
S1 else S2
// </smpl>
Signed-off-by: Julien Brunel <brunel@diku.dk>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-09-24 18:00:36 +02:00
}
2008-12-01 11:47:40 +01:00
/* done with PLX IO access */
2008-04-24 00:37:04 +02:00
iounmap ( iobase ) ;
release_mem_region ( nxp_pci_io_base , iolength ) ;
2008-12-01 11:47:40 +01:00
pci_set_drvdata ( dev , hcd ) ;
return 0 ;
cleanup3 :
release_mem_region ( pci_mem_phy0 , memlength ) ;
cleanup2 :
iounmap ( iobase ) ;
cleanup1 :
release_mem_region ( nxp_pci_io_base , iolength ) ;
return ret_status ;
2008-04-24 00:37:04 +02:00
}
2008-12-01 11:47:40 +01:00
2008-04-24 00:37:04 +02:00
static void isp1761_pci_remove ( struct pci_dev * dev )
{
struct usb_hcd * hcd ;
hcd = pci_get_drvdata ( dev ) ;
usb_remove_hcd ( hcd ) ;
iounmap ( hcd - > regs ) ;
release_mem_region ( hcd - > rsrc_start , hcd - > rsrc_len ) ;
usb_put_hcd ( hcd ) ;
pci_disable_device ( dev ) ;
}
static void isp1761_pci_shutdown ( struct pci_dev * dev )
{
printk ( KERN_ERR " ips1761_pci_shutdown \n " ) ;
}
2008-11-30 16:50:04 +01:00
static const struct pci_device_id isp1760_plx [ ] = {
{
. class = PCI_CLASS_BRIDGE_OTHER < < 8 ,
. class_mask = ~ 0 ,
. vendor = PCI_VENDOR_ID_PLX ,
. device = 0x5406 ,
. subvendor = PCI_VENDOR_ID_PLX ,
. subdevice = 0x9054 ,
} ,
{ }
2008-04-24 00:37:04 +02:00
} ;
MODULE_DEVICE_TABLE ( pci , isp1760_plx ) ;
static struct pci_driver isp1761_pci_driver = {
. name = " isp1760 " ,
. id_table = isp1760_plx ,
. probe = isp1761_pci_probe ,
. remove = isp1761_pci_remove ,
. shutdown = isp1761_pci_shutdown ,
} ;
# endif
2009-02-10 16:55:51 +00:00
static int __devinit isp1760_plat_probe ( struct platform_device * pdev )
{
int ret = 0 ;
struct usb_hcd * hcd ;
struct resource * mem_res ;
struct resource * irq_res ;
resource_size_t mem_size ;
unsigned long irqflags = IRQF_SHARED | IRQF_DISABLED ;
mem_res = platform_get_resource ( pdev , IORESOURCE_MEM , 0 ) ;
if ( ! mem_res ) {
pr_warning ( " isp1760: Memory resource not available \n " ) ;
ret = - ENODEV ;
goto out ;
}
mem_size = resource_size ( mem_res ) ;
if ( ! request_mem_region ( mem_res - > start , mem_size , " isp1760 " ) ) {
pr_warning ( " isp1760: Cannot reserve the memory resource \n " ) ;
ret = - EBUSY ;
goto out ;
}
irq_res = platform_get_resource ( pdev , IORESOURCE_IRQ , 0 ) ;
if ( ! irq_res ) {
pr_warning ( " isp1760: IRQ resource not available \n " ) ;
return - ENODEV ;
}
irqflags | = irq_res - > flags & IRQF_TRIGGER_MASK ;
hcd = isp1760_register ( mem_res - > start , mem_size , irq_res - > start ,
irqflags , & pdev - > dev , dev_name ( & pdev - > dev ) , 0 ) ;
if ( IS_ERR ( hcd ) ) {
pr_warning ( " isp1760: Failed to register the HCD device \n " ) ;
ret = - ENODEV ;
goto cleanup ;
}
pr_info ( " ISP1760 USB device initialised \n " ) ;
return ret ;
cleanup :
release_mem_region ( mem_res - > start , mem_size ) ;
out :
return ret ;
}
static int __devexit isp1760_plat_remove ( struct platform_device * pdev )
{
struct resource * mem_res ;
resource_size_t mem_size ;
mem_res = platform_get_resource ( pdev , IORESOURCE_MEM , 0 ) ;
mem_size = resource_size ( mem_res ) ;
release_mem_region ( mem_res - > start , mem_size ) ;
return 0 ;
}
static struct platform_driver isp1760_plat_driver = {
. probe = isp1760_plat_probe ,
. remove = isp1760_plat_remove ,
. driver = {
. name = " isp1760 " ,
} ,
} ;
2008-04-24 00:37:04 +02:00
static int __init isp1760_init ( void )
{
2009-02-10 16:55:51 +00:00
int ret , any_ret = - ENODEV ;
2008-04-24 00:37:04 +02:00
init_kmem_once ( ) ;
2009-02-10 16:55:51 +00:00
ret = platform_driver_register ( & isp1760_plat_driver ) ;
if ( ! ret )
any_ret = 0 ;
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PPC_OF
2008-04-24 00:37:04 +02:00
ret = of_register_platform_driver ( & isp1760_of_driver ) ;
2009-02-10 16:55:51 +00:00
if ( ! ret )
any_ret = 0 ;
2008-04-24 00:37:04 +02:00
# endif
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PCI
2008-04-24 00:37:04 +02:00
ret = pci_register_driver ( & isp1761_pci_driver ) ;
2009-02-10 16:55:51 +00:00
if ( ! ret )
any_ret = 0 ;
2008-04-24 00:37:04 +02:00
# endif
2009-02-10 16:55:51 +00:00
if ( any_ret )
deinit_kmem_cache ( ) ;
return any_ret ;
2008-04-24 00:37:04 +02:00
}
module_init ( isp1760_init ) ;
static void __exit isp1760_exit ( void )
{
2009-02-10 16:55:51 +00:00
platform_driver_unregister ( & isp1760_plat_driver ) ;
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PPC_OF
2008-04-24 00:37:04 +02:00
of_unregister_platform_driver ( & isp1760_of_driver ) ;
# endif
2008-11-02 15:25:42 +01:00
# ifdef CONFIG_PCI
2008-04-24 00:37:04 +02:00
pci_unregister_driver ( & isp1761_pci_driver ) ;
# endif
deinit_kmem_cache ( ) ;
}
module_exit ( isp1760_exit ) ;