2019-06-04 11:11:33 +03:00
// SPDX-License-Identifier: GPL-2.0-only
2005-04-17 02:20:36 +04:00
/*
* Implementation of the kernel access vector cache ( AVC ) .
*
2023-07-19 18:12:50 +03:00
* Authors : Stephen Smalley , < stephen . smalley . work @ gmail . com >
2008-04-17 22:42:10 +04:00
* James Morris < jmorris @ redhat . com >
2005-04-17 02:20:36 +04:00
*
* Update : KaiGai , Kohei < kaigai @ ak . jp . nec . com >
2008-04-17 22:42:10 +04:00
* Replaced the avc_lock spinlock by RCU .
2005-04-17 02:20:36 +04:00
*
* Copyright ( C ) 2003 Red Hat , Inc . , James Morris < jmorris @ redhat . com >
*/
# include <linux/types.h>
# include <linux/stddef.h>
# include <linux/kernel.h>
# include <linux/slab.h>
# include <linux/fs.h>
# include <linux/dcache.h>
# include <linux/init.h>
# include <linux/skbuff.h>
# include <linux/percpu.h>
2015-07-11 00:19:56 +03:00
# include <linux/list.h>
2005-04-17 02:20:36 +04:00
# include <net/sock.h>
# include <linux/un.h>
# include <net/af_unix.h>
# include <linux/ip.h>
# include <linux/audit.h>
# include <linux/ipv6.h>
# include <net/ipv6.h>
# include "avc.h"
# include "avc_ss.h"
selinux: dynamic class/perm discovery
Modify SELinux to dynamically discover class and permission values
upon policy load, based on the dynamic object class/perm discovery
logic from libselinux. A mapping is created between kernel-private
class and permission indices used outside the security server and the
policy values used within the security server.
The mappings are only applied upon kernel-internal computations;
similar mappings for the private indices of userspace object managers
is handled on a per-object manager basis by the userspace AVC. The
interfaces for compute_av and transition_sid are split for kernel
vs. userspace; the userspace functions are distinguished by a _user
suffix.
The kernel-private class indices are no longer tied to the policy
values and thus do not need to skip indices for userspace classes;
thus the kernel class index values are compressed. The flask.h
definitions were regenerated by deleting the userspace classes from
refpolicy's definitions and then regenerating the headers. Going
forward, we can just maintain the flask.h, av_permissions.h, and
classmap.h definitions separately from policy as they are no longer
tied to the policy values. The next patch introduces a utility to
automate generation of flask.h and av_permissions.h from the
classmap.h definitions.
The older kernel class and permission string tables are removed and
replaced by a single security class mapping table that is walked at
policy load to generate the mapping. The old kernel class validation
logic is completely replaced by the mapping logic.
The handle unknown logic is reworked. reject_unknown=1 is handled
when the mappings are computed at policy load time, similar to the old
handling by the class validation logic. allow_unknown=1 is handled
when computing and mapping decisions - if the permission was not able
to be mapped (i.e. undefined, mapped to zero), then it is
automatically added to the allowed vector. If the class was not able
to be mapped (i.e. undefined, mapped to zero), then all permissions
are allowed for it if allow_unknown=1.
avc_audit leverages the new security class mapping table to lookup the
class and permission names from the kernel-private indices.
The mdp program is updated to use the new table when generating the
class definitions and allow rules for a minimal boot policy for the
kernel. It should be noted that this policy will not include any
userspace classes, nor will its policy index values for the kernel
classes correspond with the ones in refpolicy (they will instead match
the kernel-private indices).
Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: James Morris <jmorris@namei.org>
2009-09-30 21:37:50 +04:00
# include "classmap.h"
2006-11-06 20:38:16 +03:00
2020-08-21 17:08:21 +03:00
# define CREATE_TRACE_POINTS
# include <trace/events/avc.h>
2005-04-17 02:20:36 +04:00
# define AVC_CACHE_SLOTS 512
# define AVC_DEF_CACHE_THRESHOLD 512
# define AVC_CACHE_RECLAIM 16
# ifdef CONFIG_SECURITY_SELINUX_AVC_STATS
2011-05-20 05:59:47 +04:00
# define avc_cache_stats_incr(field) this_cpu_inc(avc_cache_stats.field)
2005-04-17 02:20:36 +04:00
# else
# define avc_cache_stats_incr(field) do {} while (0)
# endif
struct avc_entry {
u32 ssid ;
u32 tsid ;
u16 tclass ;
struct av_decision avd ;
2015-07-11 00:19:56 +03:00
struct avc_xperms_node * xp_node ;
2005-04-17 02:20:36 +04:00
} ;
struct avc_node {
struct avc_entry ae ;
2009-02-12 22:51:04 +03:00
struct hlist_node list ; /* anchored in avc_cache->slots[i] */
2008-04-17 22:42:10 +04:00
struct rcu_head rhead ;
2005-04-17 02:20:36 +04:00
} ;
2015-07-11 00:19:56 +03:00
struct avc_xperms_decision_node {
struct extended_perms_decision xpd ;
struct list_head xpd_list ; /* list of extended_perms_decision */
} ;
struct avc_xperms_node {
struct extended_perms xp ;
struct list_head xpd_head ; /* list head of extended_perms_decision */
} ;
2005-04-17 02:20:36 +04:00
struct avc_cache {
2009-02-12 22:51:04 +03:00
struct hlist_head slots [ AVC_CACHE_SLOTS ] ; /* head for avc_node->list */
2005-04-17 02:20:36 +04:00
spinlock_t slots_lock [ AVC_CACHE_SLOTS ] ; /* lock for writes */
atomic_t lru_hint ; /* LRU hint for reclaim scan */
atomic_t active_nodes ;
u32 latest_notif ; /* latest revocation notification */
} ;
struct avc_callback_node {
2012-03-07 18:17:14 +04:00
int ( * callback ) ( u32 event ) ;
2005-04-17 02:20:36 +04:00
u32 events ;
struct avc_callback_node * next ;
} ;
# ifdef CONFIG_SECURITY_SELINUX_AVC_STATS
DEFINE_PER_CPU ( struct avc_cache_stats , avc_cache_stats ) = { 0 } ;
# endif
2018-03-05 19:47:56 +03:00
struct selinux_avc {
unsigned int avc_cache_threshold ;
struct avc_cache avc_cache ;
} ;
static struct selinux_avc selinux_avc ;
2023-03-09 21:30:37 +03:00
void selinux_avc_init ( void )
2018-03-05 19:47:56 +03:00
{
int i ;
selinux_avc . avc_cache_threshold = AVC_DEF_CACHE_THRESHOLD ;
for ( i = 0 ; i < AVC_CACHE_SLOTS ; i + + ) {
INIT_HLIST_HEAD ( & selinux_avc . avc_cache . slots [ i ] ) ;
spin_lock_init ( & selinux_avc . avc_cache . slots_lock [ i ] ) ;
}
atomic_set ( & selinux_avc . avc_cache . active_nodes , 0 ) ;
atomic_set ( & selinux_avc . avc_cache . lru_hint , 0 ) ;
}
2023-03-09 21:30:37 +03:00
unsigned int avc_get_cache_threshold ( void )
2018-03-05 19:47:56 +03:00
{
2023-03-09 21:30:37 +03:00
return selinux_avc . avc_cache_threshold ;
2018-03-05 19:47:56 +03:00
}
2023-03-09 21:30:37 +03:00
void avc_set_cache_threshold ( unsigned int cache_threshold )
2018-03-05 19:47:56 +03:00
{
2023-03-09 21:30:37 +03:00
selinux_avc . avc_cache_threshold = cache_threshold ;
2018-03-05 19:47:56 +03:00
}
2021-01-06 16:26:21 +03:00
static struct avc_callback_node * avc_callbacks __ro_after_init ;
static struct kmem_cache * avc_node_cachep __ro_after_init ;
static struct kmem_cache * avc_xperms_data_cachep __ro_after_init ;
static struct kmem_cache * avc_xperms_decision_cachep __ro_after_init ;
static struct kmem_cache * avc_xperms_cachep __ro_after_init ;
2005-04-17 02:20:36 +04:00
2023-07-06 16:23:26 +03:00
static inline u32 avc_hash ( u32 ssid , u32 tsid , u16 tclass )
2005-04-17 02:20:36 +04:00
{
return ( ssid ^ ( tsid < < 2 ) ^ ( tclass < < 4 ) ) & ( AVC_CACHE_SLOTS - 1 ) ;
}
/**
* avc_init - Initialize the AVC .
*
* Initialize the access vector cache .
*/
void __init avc_init ( void )
{
avc_node_cachep = kmem_cache_create ( " avc_node " , sizeof ( struct avc_node ) ,
2015-07-11 00:19:56 +03:00
0 , SLAB_PANIC , NULL ) ;
avc_xperms_cachep = kmem_cache_create ( " avc_xperms_node " ,
sizeof ( struct avc_xperms_node ) ,
0 , SLAB_PANIC , NULL ) ;
avc_xperms_decision_cachep = kmem_cache_create (
" avc_xperms_decision_node " ,
sizeof ( struct avc_xperms_decision_node ) ,
0 , SLAB_PANIC , NULL ) ;
avc_xperms_data_cachep = kmem_cache_create ( " avc_xperms_data " ,
sizeof ( struct extended_perms_data ) ,
0 , SLAB_PANIC , NULL ) ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
int avc_get_hash_stats ( char * page )
2005-04-17 02:20:36 +04:00
{
int i , chain_len , max_chain_len , slots_used ;
struct avc_node * node ;
2009-02-12 22:51:04 +03:00
struct hlist_head * head ;
2005-04-17 02:20:36 +04:00
rcu_read_lock ( ) ;
slots_used = 0 ;
max_chain_len = 0 ;
for ( i = 0 ; i < AVC_CACHE_SLOTS ; i + + ) {
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ i ] ;
2009-02-12 22:51:04 +03:00
if ( ! hlist_empty ( head ) ) {
2005-04-17 02:20:36 +04:00
slots_used + + ;
chain_len = 0 ;
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 05:06:00 +04:00
hlist_for_each_entry_rcu ( node , head , list )
2005-04-17 02:20:36 +04:00
chain_len + + ;
if ( chain_len > max_chain_len )
max_chain_len = chain_len ;
}
}
rcu_read_unlock ( ) ;
return scnprintf ( page , PAGE_SIZE , " entries: %d \n buckets used: %d/%d \n "
" longest chain: %d \n " ,
2023-03-09 21:30:37 +03:00
atomic_read ( & selinux_avc . avc_cache . active_nodes ) ,
2005-04-17 02:20:36 +04:00
slots_used , AVC_CACHE_SLOTS , max_chain_len ) ;
}
2015-07-11 00:19:56 +03:00
/*
* using a linked list for extended_perms_decision lookup because the list is
* always small . i . e . less than 5 , typically 1
*/
static struct extended_perms_decision * avc_xperms_decision_lookup ( u8 driver ,
struct avc_xperms_node * xp_node )
{
struct avc_xperms_decision_node * xpd_node ;
list_for_each_entry ( xpd_node , & xp_node - > xpd_head , xpd_list ) {
if ( xpd_node - > xpd . driver = = driver )
return & xpd_node - > xpd ;
}
return NULL ;
}
static inline unsigned int
avc_xperms_has_perm ( struct extended_perms_decision * xpd ,
u8 perm , u8 which )
{
unsigned int rc = 0 ;
if ( ( which = = XPERMS_ALLOWED ) & &
( xpd - > used & XPERMS_ALLOWED ) )
rc = security_xperm_test ( xpd - > allowed - > p , perm ) ;
else if ( ( which = = XPERMS_AUDITALLOW ) & &
( xpd - > used & XPERMS_AUDITALLOW ) )
rc = security_xperm_test ( xpd - > auditallow - > p , perm ) ;
else if ( ( which = = XPERMS_DONTAUDIT ) & &
( xpd - > used & XPERMS_DONTAUDIT ) )
rc = security_xperm_test ( xpd - > dontaudit - > p , perm ) ;
return rc ;
}
static void avc_xperms_allow_perm ( struct avc_xperms_node * xp_node ,
u8 driver , u8 perm )
{
struct extended_perms_decision * xpd ;
security_xperm_set ( xp_node - > xp . drivers . p , driver ) ;
xpd = avc_xperms_decision_lookup ( driver , xp_node ) ;
if ( xpd & & xpd - > allowed )
security_xperm_set ( xpd - > allowed - > p , perm ) ;
}
static void avc_xperms_decision_free ( struct avc_xperms_decision_node * xpd_node )
{
struct extended_perms_decision * xpd ;
xpd = & xpd_node - > xpd ;
if ( xpd - > allowed )
kmem_cache_free ( avc_xperms_data_cachep , xpd - > allowed ) ;
if ( xpd - > auditallow )
kmem_cache_free ( avc_xperms_data_cachep , xpd - > auditallow ) ;
if ( xpd - > dontaudit )
kmem_cache_free ( avc_xperms_data_cachep , xpd - > dontaudit ) ;
kmem_cache_free ( avc_xperms_decision_cachep , xpd_node ) ;
}
static void avc_xperms_free ( struct avc_xperms_node * xp_node )
{
struct avc_xperms_decision_node * xpd_node , * tmp ;
if ( ! xp_node )
return ;
list_for_each_entry_safe ( xpd_node , tmp , & xp_node - > xpd_head , xpd_list ) {
list_del ( & xpd_node - > xpd_list ) ;
avc_xperms_decision_free ( xpd_node ) ;
}
kmem_cache_free ( avc_xperms_cachep , xp_node ) ;
}
static void avc_copy_xperms_decision ( struct extended_perms_decision * dest ,
struct extended_perms_decision * src )
{
dest - > driver = src - > driver ;
dest - > used = src - > used ;
if ( dest - > used & XPERMS_ALLOWED )
memcpy ( dest - > allowed - > p , src - > allowed - > p ,
sizeof ( src - > allowed - > p ) ) ;
if ( dest - > used & XPERMS_AUDITALLOW )
memcpy ( dest - > auditallow - > p , src - > auditallow - > p ,
sizeof ( src - > auditallow - > p ) ) ;
if ( dest - > used & XPERMS_DONTAUDIT )
memcpy ( dest - > dontaudit - > p , src - > dontaudit - > p ,
sizeof ( src - > dontaudit - > p ) ) ;
}
/*
* similar to avc_copy_xperms_decision , but only copy decision
* information relevant to this perm
*/
static inline void avc_quick_copy_xperms_decision ( u8 perm ,
struct extended_perms_decision * dest ,
struct extended_perms_decision * src )
{
/*
* compute index of the u32 of the 256 bits ( 8 u32s ) that contain this
* command permission
*/
u8 i = perm > > 5 ;
dest - > used = src - > used ;
if ( dest - > used & XPERMS_ALLOWED )
dest - > allowed - > p [ i ] = src - > allowed - > p [ i ] ;
if ( dest - > used & XPERMS_AUDITALLOW )
dest - > auditallow - > p [ i ] = src - > auditallow - > p [ i ] ;
if ( dest - > used & XPERMS_DONTAUDIT )
dest - > dontaudit - > p [ i ] = src - > dontaudit - > p [ i ] ;
}
static struct avc_xperms_decision_node
* avc_xperms_decision_alloc ( u8 which )
{
struct avc_xperms_decision_node * xpd_node ;
struct extended_perms_decision * xpd ;
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
xpd_node = kmem_cache_zalloc ( avc_xperms_decision_cachep ,
GFP_NOWAIT | __GFP_NOWARN ) ;
2015-07-11 00:19:56 +03:00
if ( ! xpd_node )
return NULL ;
xpd = & xpd_node - > xpd ;
if ( which & XPERMS_ALLOWED ) {
xpd - > allowed = kmem_cache_zalloc ( avc_xperms_data_cachep ,
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
GFP_NOWAIT | __GFP_NOWARN ) ;
2015-07-11 00:19:56 +03:00
if ( ! xpd - > allowed )
goto error ;
}
if ( which & XPERMS_AUDITALLOW ) {
xpd - > auditallow = kmem_cache_zalloc ( avc_xperms_data_cachep ,
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
GFP_NOWAIT | __GFP_NOWARN ) ;
2015-07-11 00:19:56 +03:00
if ( ! xpd - > auditallow )
goto error ;
}
if ( which & XPERMS_DONTAUDIT ) {
xpd - > dontaudit = kmem_cache_zalloc ( avc_xperms_data_cachep ,
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
GFP_NOWAIT | __GFP_NOWARN ) ;
2015-07-11 00:19:56 +03:00
if ( ! xpd - > dontaudit )
goto error ;
}
return xpd_node ;
error :
avc_xperms_decision_free ( xpd_node ) ;
return NULL ;
}
static int avc_add_xperms_decision ( struct avc_node * node ,
struct extended_perms_decision * src )
{
struct avc_xperms_decision_node * dest_xpd ;
node - > ae . xp_node - > xp . len + + ;
dest_xpd = avc_xperms_decision_alloc ( src - > used ) ;
if ( ! dest_xpd )
return - ENOMEM ;
avc_copy_xperms_decision ( & dest_xpd - > xpd , src ) ;
list_add ( & dest_xpd - > xpd_list , & node - > ae . xp_node - > xpd_head ) ;
return 0 ;
}
static struct avc_xperms_node * avc_xperms_alloc ( void )
{
struct avc_xperms_node * xp_node ;
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
xp_node = kmem_cache_zalloc ( avc_xperms_cachep , GFP_NOWAIT | __GFP_NOWARN ) ;
2015-07-11 00:19:56 +03:00
if ( ! xp_node )
return xp_node ;
INIT_LIST_HEAD ( & xp_node - > xpd_head ) ;
return xp_node ;
}
static int avc_xperms_populate ( struct avc_node * node ,
struct avc_xperms_node * src )
{
struct avc_xperms_node * dest ;
struct avc_xperms_decision_node * dest_xpd ;
struct avc_xperms_decision_node * src_xpd ;
if ( src - > xp . len = = 0 )
return 0 ;
dest = avc_xperms_alloc ( ) ;
if ( ! dest )
return - ENOMEM ;
memcpy ( dest - > xp . drivers . p , src - > xp . drivers . p , sizeof ( dest - > xp . drivers . p ) ) ;
dest - > xp . len = src - > xp . len ;
/* for each source xpd allocate a destination xpd and copy */
list_for_each_entry ( src_xpd , & src - > xpd_head , xpd_list ) {
dest_xpd = avc_xperms_decision_alloc ( src_xpd - > xpd . used ) ;
if ( ! dest_xpd )
goto error ;
avc_copy_xperms_decision ( & dest_xpd - > xpd , & src_xpd - > xpd ) ;
list_add ( & dest_xpd - > xpd_list , & dest - > xpd_head ) ;
}
node - > ae . xp_node = dest ;
return 0 ;
error :
avc_xperms_free ( dest ) ;
return - ENOMEM ;
}
static inline u32 avc_xperms_audit_required ( u32 requested ,
struct av_decision * avd ,
struct extended_perms_decision * xpd ,
u8 perm ,
int result ,
u32 * deniedp )
{
u32 denied , audited ;
denied = requested & ~ avd - > allowed ;
if ( unlikely ( denied ) ) {
audited = denied & avd - > auditdeny ;
if ( audited & & xpd ) {
if ( avc_xperms_has_perm ( xpd , perm , XPERMS_DONTAUDIT ) )
audited & = ~ requested ;
}
} else if ( result ) {
audited = denied = requested ;
} else {
audited = requested & avd - > auditallow ;
if ( audited & & xpd ) {
if ( ! avc_xperms_has_perm ( xpd , perm , XPERMS_AUDITALLOW ) )
audited & = ~ requested ;
}
}
* deniedp = denied ;
return audited ;
}
2023-03-09 21:30:37 +03:00
static inline int avc_xperms_audit ( u32 ssid , u32 tsid , u16 tclass ,
2018-03-05 19:47:56 +03:00
u32 requested , struct av_decision * avd ,
struct extended_perms_decision * xpd ,
u8 perm , int result ,
struct common_audit_data * ad )
2015-07-11 00:19:56 +03:00
{
u32 audited , denied ;
audited = avc_xperms_audit_required (
requested , avd , xpd , perm , result , & denied ) ;
if ( likely ( ! audited ) )
return 0 ;
2023-03-09 21:30:37 +03:00
return slow_avc_audit ( ssid , tsid , tclass , requested ,
2019-11-22 20:22:45 +03:00
audited , denied , result , ad ) ;
2015-07-11 00:19:56 +03:00
}
2005-04-17 02:20:36 +04:00
static void avc_node_free ( struct rcu_head * rhead )
{
struct avc_node * node = container_of ( rhead , struct avc_node , rhead ) ;
2015-07-11 00:19:56 +03:00
avc_xperms_free ( node - > ae . xp_node ) ;
2005-04-17 02:20:36 +04:00
kmem_cache_free ( avc_node_cachep , node ) ;
avc_cache_stats_incr ( frees ) ;
}
2023-03-09 21:30:37 +03:00
static void avc_node_delete ( struct avc_node * node )
2005-04-17 02:20:36 +04:00
{
2009-02-12 22:51:04 +03:00
hlist_del_rcu ( & node - > list ) ;
2005-04-17 02:20:36 +04:00
call_rcu ( & node - > rhead , avc_node_free ) ;
2023-03-09 21:30:37 +03:00
atomic_dec ( & selinux_avc . avc_cache . active_nodes ) ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
static void avc_node_kill ( struct avc_node * node )
2005-04-17 02:20:36 +04:00
{
2015-07-11 00:19:56 +03:00
avc_xperms_free ( node - > ae . xp_node ) ;
2005-04-17 02:20:36 +04:00
kmem_cache_free ( avc_node_cachep , node ) ;
avc_cache_stats_incr ( frees ) ;
2023-03-09 21:30:37 +03:00
atomic_dec ( & selinux_avc . avc_cache . active_nodes ) ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
static void avc_node_replace ( struct avc_node * new , struct avc_node * old )
2005-04-17 02:20:36 +04:00
{
2009-02-12 22:51:04 +03:00
hlist_replace_rcu ( & old - > list , & new - > list ) ;
2005-04-17 02:20:36 +04:00
call_rcu ( & old - > rhead , avc_node_free ) ;
2023-03-09 21:30:37 +03:00
atomic_dec ( & selinux_avc . avc_cache . active_nodes ) ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
static inline int avc_reclaim_node ( void )
2005-04-17 02:20:36 +04:00
{
struct avc_node * node ;
int hvalue , try , ecx ;
unsigned long flags ;
2009-02-12 22:51:04 +03:00
struct hlist_head * head ;
2009-02-12 22:50:59 +03:00
spinlock_t * lock ;
2005-04-17 02:20:36 +04:00
2008-04-17 22:42:10 +04:00
for ( try = 0 , ecx = 0 ; try < AVC_CACHE_SLOTS ; try + + ) {
2023-03-09 21:30:37 +03:00
hvalue = atomic_inc_return ( & selinux_avc . avc_cache . lru_hint ) &
2018-03-05 19:47:56 +03:00
( AVC_CACHE_SLOTS - 1 ) ;
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ hvalue ] ;
lock = & selinux_avc . avc_cache . slots_lock [ hvalue ] ;
2005-04-17 02:20:36 +04:00
2009-02-12 22:50:59 +03:00
if ( ! spin_trylock_irqsave ( lock , flags ) )
2005-04-17 02:20:36 +04:00
continue ;
2008-04-22 05:12:33 +04:00
rcu_read_lock ( ) ;
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 05:06:00 +04:00
hlist_for_each_entry ( node , head , list ) {
2023-03-09 21:30:37 +03:00
avc_node_delete ( node ) ;
2009-02-12 22:50:43 +03:00
avc_cache_stats_incr ( reclaims ) ;
ecx + + ;
if ( ecx > = AVC_CACHE_RECLAIM ) {
rcu_read_unlock ( ) ;
2009-02-12 22:50:59 +03:00
spin_unlock_irqrestore ( lock , flags ) ;
2009-02-12 22:50:43 +03:00
goto out ;
2005-04-17 02:20:36 +04:00
}
}
2008-04-22 05:12:33 +04:00
rcu_read_unlock ( ) ;
2009-02-12 22:50:59 +03:00
spin_unlock_irqrestore ( lock , flags ) ;
2005-04-17 02:20:36 +04:00
}
out :
return ecx ;
}
2023-03-09 21:30:37 +03:00
static struct avc_node * avc_alloc_node ( void )
2005-04-17 02:20:36 +04:00
{
struct avc_node * node ;
selinux: use __GFP_NOWARN with GFP_NOWAIT in the AVC
In the field, we have seen lots of allocation failure from the call
path below.
06-03 13:29:12.999 1010315 31557 31557 W Binder : 31542_2: page allocation failure: order:0, mode:0x800(GFP_NOWAIT), nodemask=(null),cpuset=background,mems_allowed=0
...
...
06-03 13:29:12.999 1010315 31557 31557 W Call trace:
06-03 13:29:12.999 1010315 31557 31557 W : dump_backtrace.cfi_jt+0x0/0x8
06-03 13:29:12.999 1010315 31557 31557 W : dump_stack+0xc8/0x14c
06-03 13:29:12.999 1010315 31557 31557 W : warn_alloc+0x158/0x1c8
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_slowpath+0x9d8/0xb80
06-03 13:29:12.999 1010315 31557 31557 W : __alloc_pages_nodemask+0x1c4/0x430
06-03 13:29:12.999 1010315 31557 31557 W : allocate_slab+0xb4/0x390
06-03 13:29:12.999 1010315 31557 31557 W : ___slab_alloc+0x12c/0x3a4
06-03 13:29:12.999 1010315 31557 31557 W : kmem_cache_alloc+0x358/0x5e4
06-03 13:29:12.999 1010315 31557 31557 W : avc_alloc_node+0x30/0x184
06-03 13:29:12.999 1010315 31557 31557 W : avc_update_node+0x54/0x4f0
06-03 13:29:12.999 1010315 31557 31557 W : avc_has_extended_perms+0x1a4/0x460
06-03 13:29:12.999 1010315 31557 31557 W : selinux_file_ioctl+0x320/0x3d0
06-03 13:29:12.999 1010315 31557 31557 W : __arm64_sys_ioctl+0xec/0x1fc
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc_common+0xc0/0x24c
06-03 13:29:12.999 1010315 31557 31557 W : el0_svc+0x28/0x88
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync_handler+0x8c/0xf0
06-03 13:29:12.999 1010315 31557 31557 W : el0_sync+0x1a4/0x1c0
..
..
06-03 13:29:12.999 1010315 31557 31557 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010315 31557 31557 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010315 31557 31557 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:12.999 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:12.999 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:12.999 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 1010161 10686 10686 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 1010161 10686 10686 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 1010161 10686 10686 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
06-03 13:29:13.000 10230 30892 30892 W node 0 : slabs: 57, objs: 2907, free: 0
06-03 13:29:13.000 10230 30892 30892 W SLUB : Unable to allocate memory on node -1, gfp=0x900(GFP_NOWAIT|__GFP_ZERO)
06-03 13:29:13.000 10230 30892 30892 W cache : avc_node, object size: 72, buffer size: 80, default order: 0, min order: 0
Based on [1], selinux is tolerate for failure of memory allocation.
Then, use __GFP_NOWARN together.
[1] 476accbe2f6e ("selinux: use GFP_NOWAIT in the AVC kmem_caches")
Signed-off-by: Minchan Kim <minchan@kernel.org>
[PM: subj fix, line wraps, normalized commit refs]
Signed-off-by: Paul Moore <paul@paul-moore.com>
2021-06-09 19:37:17 +03:00
node = kmem_cache_zalloc ( avc_node_cachep , GFP_NOWAIT | __GFP_NOWARN ) ;
2005-04-17 02:20:36 +04:00
if ( ! node )
goto out ;
2009-02-12 22:51:04 +03:00
INIT_HLIST_NODE ( & node - > list ) ;
2005-04-17 02:20:36 +04:00
avc_cache_stats_incr ( allocations ) ;
2023-03-09 21:30:37 +03:00
if ( atomic_inc_return ( & selinux_avc . avc_cache . active_nodes ) >
selinux_avc . avc_cache_threshold )
avc_reclaim_node ( ) ;
2005-04-17 02:20:36 +04:00
out :
return node ;
}
2009-02-12 22:50:49 +03:00
static void avc_node_populate ( struct avc_node * node , u32 ssid , u32 tsid , u16 tclass , struct av_decision * avd )
2005-04-17 02:20:36 +04:00
{
node - > ae . ssid = ssid ;
node - > ae . tsid = tsid ;
node - > ae . tclass = tclass ;
2009-02-12 22:50:49 +03:00
memcpy ( & node - > ae . avd , avd , sizeof ( node - > ae . avd ) ) ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
static inline struct avc_node * avc_search_node ( u32 ssid , u32 tsid , u16 tclass )
2005-04-17 02:20:36 +04:00
{
struct avc_node * node , * ret = NULL ;
2023-07-06 16:23:26 +03:00
u32 hvalue ;
2009-02-12 22:51:04 +03:00
struct hlist_head * head ;
2005-04-17 02:20:36 +04:00
hvalue = avc_hash ( ssid , tsid , tclass ) ;
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ hvalue ] ;
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 05:06:00 +04:00
hlist_for_each_entry_rcu ( node , head , list ) {
2005-04-17 02:20:36 +04:00
if ( ssid = = node - > ae . ssid & &
tclass = = node - > ae . tclass & &
tsid = = node - > ae . tsid ) {
ret = node ;
break ;
}
}
return ret ;
}
/**
* avc_lookup - Look up an AVC entry .
* @ ssid : source security identifier
* @ tsid : target security identifier
* @ tclass : target security class
*
* Look up an AVC entry that is valid for the
* ( @ ssid , @ tsid ) , interpreting the permissions
* based on @ tclass . If a valid AVC entry exists ,
2010-01-15 10:03:18 +03:00
* then this function returns the avc_node .
2005-04-17 02:20:36 +04:00
* Otherwise , this function returns NULL .
*/
2023-03-09 21:30:37 +03:00
static struct avc_node * avc_lookup ( u32 ssid , u32 tsid , u16 tclass )
2005-04-17 02:20:36 +04:00
{
struct avc_node * node ;
avc_cache_stats_incr ( lookups ) ;
2023-03-09 21:30:37 +03:00
node = avc_search_node ( ssid , tsid , tclass ) ;
2005-04-17 02:20:36 +04:00
2009-02-12 22:50:54 +03:00
if ( node )
2011-05-20 08:22:53 +04:00
return node ;
2005-04-17 02:20:36 +04:00
2011-05-20 08:22:53 +04:00
avc_cache_stats_incr ( misses ) ;
return NULL ;
2005-04-17 02:20:36 +04:00
}
2023-07-06 16:23:26 +03:00
static int avc_latest_notif_update ( u32 seqno , int is_insert )
2005-04-17 02:20:36 +04:00
{
int ret = 0 ;
static DEFINE_SPINLOCK ( notif_lock ) ;
unsigned long flag ;
spin_lock_irqsave ( & notif_lock , flag ) ;
if ( is_insert ) {
2023-03-09 21:30:37 +03:00
if ( seqno < selinux_avc . avc_cache . latest_notif ) {
2018-06-12 11:09:11 +03:00
pr_warn ( " SELinux: avc: seqno %d < latest_notif %d \n " ,
2023-03-09 21:30:37 +03:00
seqno , selinux_avc . avc_cache . latest_notif ) ;
2005-04-17 02:20:36 +04:00
ret = - EAGAIN ;
}
} else {
2023-03-09 21:30:37 +03:00
if ( seqno > selinux_avc . avc_cache . latest_notif )
selinux_avc . avc_cache . latest_notif = seqno ;
2005-04-17 02:20:36 +04:00
}
spin_unlock_irqrestore ( & notif_lock , flag ) ;
return ret ;
}
/**
* avc_insert - Insert an AVC entry .
* @ ssid : source security identifier
* @ tsid : target security identifier
* @ tclass : target security class
2009-02-12 22:50:49 +03:00
* @ avd : resulting av decision
2015-07-11 00:19:56 +03:00
* @ xp_node : resulting extended permissions
2005-04-17 02:20:36 +04:00
*
* Insert an AVC entry for the SID pair
* ( @ ssid , @ tsid ) and class @ tclass .
* The access vectors and the sequence number are
* normally provided by the security server in
* response to a security_compute_av ( ) call . If the
2009-02-12 22:50:49 +03:00
* sequence number @ avd - > seqno is not less than the latest
2005-04-17 02:20:36 +04:00
* revocation notification , then the function copies
2023-04-03 19:37:53 +03:00
* the access vectors into a cache entry .
2005-04-17 02:20:36 +04:00
*/
2023-04-03 19:37:53 +03:00
static void avc_insert ( u32 ssid , u32 tsid , u16 tclass ,
struct av_decision * avd , struct avc_xperms_node * xp_node )
2005-04-17 02:20:36 +04:00
{
struct avc_node * pos , * node = NULL ;
2023-07-06 16:23:26 +03:00
u32 hvalue ;
2005-04-17 02:20:36 +04:00
unsigned long flag ;
2019-12-10 04:39:46 +03:00
spinlock_t * lock ;
struct hlist_head * head ;
2005-04-17 02:20:36 +04:00
2023-03-09 21:30:37 +03:00
if ( avc_latest_notif_update ( avd - > seqno , 1 ) )
2023-04-03 19:37:53 +03:00
return ;
2005-04-17 02:20:36 +04:00
2023-03-09 21:30:37 +03:00
node = avc_alloc_node ( ) ;
2019-12-10 04:39:46 +03:00
if ( ! node )
2023-04-03 19:37:53 +03:00
return ;
2009-02-12 22:50:59 +03:00
2019-12-10 04:39:46 +03:00
avc_node_populate ( node , ssid , tsid , tclass , avd ) ;
if ( avc_xperms_populate ( node , xp_node ) ) {
2023-03-09 21:30:37 +03:00
avc_node_kill ( node ) ;
2023-04-03 19:37:53 +03:00
return ;
2019-12-10 04:39:46 +03:00
}
hvalue = avc_hash ( ssid , tsid , tclass ) ;
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ hvalue ] ;
lock = & selinux_avc . avc_cache . slots_lock [ hvalue ] ;
2019-12-10 04:39:46 +03:00
spin_lock_irqsave ( lock , flag ) ;
hlist_for_each_entry ( pos , head , list ) {
if ( pos - > ae . ssid = = ssid & &
pos - > ae . tsid = = tsid & &
pos - > ae . tclass = = tclass ) {
2023-03-09 21:30:37 +03:00
avc_node_replace ( node , pos ) ;
2019-12-10 04:39:46 +03:00
goto found ;
2005-04-17 02:20:36 +04:00
}
}
2019-12-10 04:39:46 +03:00
hlist_add_head_rcu ( & node - > list , head ) ;
found :
spin_unlock_irqrestore ( lock , flag ) ;
2005-04-17 02:20:36 +04:00
}
2009-07-14 20:14:09 +04:00
/**
* avc_audit_pre_callback - SELinux specific information
* will be called by generic audit code
* @ ab : the audit buffer
* @ a : audit_data
*/
static void avc_audit_pre_callback ( struct audit_buffer * ab , void * a )
2005-04-17 02:20:36 +04:00
{
2009-07-14 20:14:09 +04:00
struct common_audit_data * ad = a ;
2019-01-25 13:06:48 +03:00
struct selinux_audit_data * sad = ad - > selinux_audit_data ;
2023-07-06 16:23:26 +03:00
u32 av = sad - > audited , perm ;
2022-05-02 17:43:38 +03:00
const char * const * perms ;
2023-07-06 16:23:26 +03:00
u32 i ;
2019-01-25 13:06:48 +03:00
audit_log_format ( ab , " avc: %s " , sad - > denied ? " denied " : " granted " ) ;
if ( av = = 0 ) {
2019-02-05 19:49:32 +03:00
audit_log_format ( ab , " null " ) ;
2019-01-25 13:06:48 +03:00
return ;
}
perms = secclass_map [ sad - > tclass - 1 ] . perms ;
2019-02-05 19:49:32 +03:00
audit_log_format ( ab , " { " ) ;
2019-01-25 13:06:48 +03:00
i = 0 ;
perm = 1 ;
while ( i < ( sizeof ( av ) * 8 ) ) {
if ( ( perm & av ) & & perms [ i ] ) {
audit_log_format ( ab , " %s " , perms [ i ] ) ;
av & = ~ perm ;
}
i + + ;
perm < < = 1 ;
}
if ( av )
audit_log_format ( ab , " 0x%x " , av ) ;
2019-02-05 19:49:32 +03:00
audit_log_format ( ab , " } for " ) ;
2005-04-17 02:20:36 +04:00
}
2009-07-14 20:14:09 +04:00
/**
* avc_audit_post_callback - SELinux specific information
* will be called by generic audit code
* @ ab : the audit buffer
* @ a : audit_data
*/
static void avc_audit_post_callback ( struct audit_buffer * ab , void * a )
2005-04-17 02:20:36 +04:00
{
2009-07-14 20:14:09 +04:00
struct common_audit_data * ad = a ;
2019-01-25 13:06:48 +03:00
struct selinux_audit_data * sad = ad - > selinux_audit_data ;
2020-08-21 17:08:22 +03:00
char * scontext = NULL ;
char * tcontext = NULL ;
const char * tclass = NULL ;
2019-01-25 13:06:48 +03:00
u32 scontext_len ;
2020-08-21 17:08:22 +03:00
u32 tcontext_len ;
2019-01-25 13:06:48 +03:00
int rc ;
2023-03-09 21:30:37 +03:00
rc = security_sid_to_context ( sad - > ssid , & scontext ,
2019-01-25 13:06:48 +03:00
& scontext_len ) ;
if ( rc )
audit_log_format ( ab , " ssid=%d " , sad - > ssid ) ;
2020-08-21 17:08:22 +03:00
else
2019-01-25 13:06:48 +03:00
audit_log_format ( ab , " scontext=%s " , scontext ) ;
2023-03-09 21:30:37 +03:00
rc = security_sid_to_context ( sad - > tsid , & tcontext ,
2020-08-21 17:08:22 +03:00
& tcontext_len ) ;
2019-01-25 13:06:48 +03:00
if ( rc )
audit_log_format ( ab , " tsid=%d " , sad - > tsid ) ;
2020-08-21 17:08:22 +03:00
else
audit_log_format ( ab , " tcontext=%s " , tcontext ) ;
2019-01-25 13:06:48 +03:00
2020-08-21 17:08:22 +03:00
tclass = secclass_map [ sad - > tclass - 1 ] . name ;
audit_log_format ( ab , " tclass=%s " , tclass ) ;
2019-01-25 13:06:48 +03:00
if ( sad - > denied )
audit_log_format ( ab , " permissive=%u " , sad - > result ? 0 : 1 ) ;
2019-01-25 13:06:51 +03:00
2020-08-21 17:08:22 +03:00
trace_selinux_audited ( sad , scontext , tcontext , tclass ) ;
kfree ( tcontext ) ;
kfree ( scontext ) ;
2019-01-25 13:06:51 +03:00
/* in case of invalid context report also the actual context string */
2023-03-09 21:30:37 +03:00
rc = security_sid_to_context_inval ( sad - > ssid , & scontext ,
2019-01-25 13:06:51 +03:00
& scontext_len ) ;
if ( ! rc & & scontext ) {
2019-06-11 11:07:19 +03:00
if ( scontext_len & & scontext [ scontext_len - 1 ] = = ' \0 ' )
scontext_len - - ;
audit_log_format ( ab , " srawcon= " ) ;
audit_log_n_untrustedstring ( ab , scontext , scontext_len ) ;
2019-01-25 13:06:51 +03:00
kfree ( scontext ) ;
}
2023-03-09 21:30:37 +03:00
rc = security_sid_to_context_inval ( sad - > tsid , & scontext ,
2019-01-25 13:06:51 +03:00
& scontext_len ) ;
if ( ! rc & & scontext ) {
2019-06-11 11:07:19 +03:00
if ( scontext_len & & scontext [ scontext_len - 1 ] = = ' \0 ' )
scontext_len - - ;
audit_log_format ( ab , " trawcon= " ) ;
audit_log_n_untrustedstring ( ab , scontext , scontext_len ) ;
2019-01-25 13:06:51 +03:00
kfree ( scontext ) ;
}
2005-04-17 02:20:36 +04:00
}
2021-01-16 23:40:54 +03:00
/*
* This is the slow part of avc audit with big stack footprint .
* Note that it is non - blocking and can be called from under
* rcu_read_lock ( ) .
*/
2023-03-09 21:30:37 +03:00
noinline int slow_avc_audit ( u32 ssid , u32 tsid , u16 tclass ,
2018-03-05 19:47:56 +03:00
u32 requested , u32 audited , u32 denied , int result ,
2019-11-22 20:22:45 +03:00
struct common_audit_data * a )
2012-03-23 04:01:41 +04:00
{
struct common_audit_data stack_data ;
2012-04-04 23:01:43 +04:00
struct selinux_audit_data sad ;
2012-03-23 04:01:41 +04:00
2019-01-25 13:06:49 +03:00
if ( WARN_ON ( ! tclass | | tclass > = ARRAY_SIZE ( secclass_map ) ) )
return - EINVAL ;
2012-03-23 04:01:41 +04:00
if ( ! a ) {
a = & stack_data ;
2012-04-04 23:01:43 +04:00
a - > type = LSM_AUDIT_DATA_NONE ;
2012-03-23 04:01:41 +04:00
}
2012-04-04 23:01:43 +04:00
sad . tclass = tclass ;
sad . requested = requested ;
sad . ssid = ssid ;
sad . tsid = tsid ;
sad . audited = audited ;
sad . denied = denied ;
2014-04-29 22:29:04 +04:00
sad . result = result ;
2012-04-04 23:01:43 +04:00
a - > selinux_audit_data = & sad ;
2012-04-03 20:38:00 +04:00
2012-04-03 02:48:12 +04:00
common_lsm_audit ( a , avc_audit_pre_callback , avc_audit_post_callback ) ;
2012-03-23 04:01:41 +04:00
return 0 ;
}
2005-04-17 02:20:36 +04:00
/**
* avc_add_callback - Register a callback for security events .
* @ callback : callback function
* @ events : security events
*
2012-03-07 18:17:14 +04:00
* Register a callback function for events in the set @ events .
* Returns % 0 on success or - % ENOMEM if insufficient memory
* exists to add the callback .
2005-04-17 02:20:36 +04:00
*/
2012-03-07 18:17:14 +04:00
int __init avc_add_callback ( int ( * callback ) ( u32 event ) , u32 events )
2005-04-17 02:20:36 +04:00
{
struct avc_callback_node * c ;
int rc = 0 ;
2012-03-07 18:17:13 +04:00
c = kmalloc ( sizeof ( * c ) , GFP_KERNEL ) ;
2005-04-17 02:20:36 +04:00
if ( ! c ) {
rc = - ENOMEM ;
goto out ;
}
c - > callback = callback ;
c - > events = events ;
c - > next = avc_callbacks ;
avc_callbacks = c ;
out :
return rc ;
}
/**
2021-04-25 11:35:37 +03:00
* avc_update_node - Update an AVC entry
2005-04-17 02:20:36 +04:00
* @ event : Updating event
* @ perms : Permission mask bits
2020-11-19 05:15:08 +03:00
* @ driver : xperm driver information
* @ xperm : xperm permissions
* @ ssid : AVC entry source sid
* @ tsid : AVC entry target sid
* @ tclass : AVC entry target object class
2009-02-12 22:50:11 +03:00
* @ seqno : sequence number when decision was made
2015-07-11 00:19:56 +03:00
* @ xpd : extended_perms_decision to be added to the node
2021-01-16 23:40:54 +03:00
* @ flags : the AVC_ * flags , e . g . AVC_EXTENDED_PERMS , or 0.
2005-04-17 02:20:36 +04:00
*
* if a valid AVC entry doesn ' t exist , this function returns - ENOENT .
* if kmalloc ( ) called internal returns NULL , this function returns - ENOMEM .
2010-01-15 10:03:18 +03:00
* otherwise , this function updates the AVC entry . The original AVC - entry object
2005-04-17 02:20:36 +04:00
* will release later by RCU .
*/
2023-03-09 21:30:37 +03:00
static int avc_update_node ( u32 event , u32 perms , u8 driver , u8 xperm , u32 ssid ,
2018-03-05 19:47:56 +03:00
u32 tsid , u16 tclass , u32 seqno ,
struct extended_perms_decision * xpd ,
u32 flags )
2005-04-17 02:20:36 +04:00
{
2023-07-06 16:23:26 +03:00
u32 hvalue ;
int rc = 0 ;
2005-04-17 02:20:36 +04:00
unsigned long flag ;
struct avc_node * pos , * node , * orig = NULL ;
2009-02-12 22:51:04 +03:00
struct hlist_head * head ;
2009-02-12 22:50:59 +03:00
spinlock_t * lock ;
2005-04-17 02:20:36 +04:00
2023-03-09 21:30:37 +03:00
node = avc_alloc_node ( ) ;
2005-04-17 02:20:36 +04:00
if ( ! node ) {
rc = - ENOMEM ;
goto out ;
}
/* Lock the target slot */
hvalue = avc_hash ( ssid , tsid , tclass ) ;
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ hvalue ] ;
lock = & selinux_avc . avc_cache . slots_lock [ hvalue ] ;
2009-02-12 22:50:59 +03:00
spin_lock_irqsave ( lock , flag ) ;
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 05:06:00 +04:00
hlist_for_each_entry ( pos , head , list ) {
2008-04-17 22:42:10 +04:00
if ( ssid = = pos - > ae . ssid & &
tsid = = pos - > ae . tsid & &
2009-02-12 22:50:11 +03:00
tclass = = pos - > ae . tclass & &
seqno = = pos - > ae . avd . seqno ) {
2005-04-17 02:20:36 +04:00
orig = pos ;
break ;
}
}
if ( ! orig ) {
rc = - ENOENT ;
2023-03-09 21:30:37 +03:00
avc_node_kill ( node ) ;
2005-04-17 02:20:36 +04:00
goto out_unlock ;
}
/*
* Copy and replace original node .
*/
2009-02-12 22:50:49 +03:00
avc_node_populate ( node , ssid , tsid , tclass , & orig - > ae . avd ) ;
2005-04-17 02:20:36 +04:00
2015-07-11 00:19:56 +03:00
if ( orig - > ae . xp_node ) {
rc = avc_xperms_populate ( node , orig - > ae . xp_node ) ;
if ( rc ) {
2023-03-09 21:30:37 +03:00
avc_node_kill ( node ) ;
2015-07-11 00:19:56 +03:00
goto out_unlock ;
}
}
2005-04-17 02:20:36 +04:00
switch ( event ) {
case AVC_CALLBACK_GRANT :
node - > ae . avd . allowed | = perms ;
2015-07-11 00:19:56 +03:00
if ( node - > ae . xp_node & & ( flags & AVC_EXTENDED_PERMS ) )
avc_xperms_allow_perm ( node - > ae . xp_node , driver , xperm ) ;
2005-04-17 02:20:36 +04:00
break ;
case AVC_CALLBACK_TRY_REVOKE :
case AVC_CALLBACK_REVOKE :
node - > ae . avd . allowed & = ~ perms ;
break ;
case AVC_CALLBACK_AUDITALLOW_ENABLE :
node - > ae . avd . auditallow | = perms ;
break ;
case AVC_CALLBACK_AUDITALLOW_DISABLE :
node - > ae . avd . auditallow & = ~ perms ;
break ;
case AVC_CALLBACK_AUDITDENY_ENABLE :
node - > ae . avd . auditdeny | = perms ;
break ;
case AVC_CALLBACK_AUDITDENY_DISABLE :
node - > ae . avd . auditdeny & = ~ perms ;
break ;
2015-07-11 00:19:56 +03:00
case AVC_CALLBACK_ADD_XPERMS :
avc_add_xperms_decision ( node , xpd ) ;
break ;
2005-04-17 02:20:36 +04:00
}
2023-03-09 21:30:37 +03:00
avc_node_replace ( node , orig ) ;
2005-04-17 02:20:36 +04:00
out_unlock :
2009-02-12 22:50:59 +03:00
spin_unlock_irqrestore ( lock , flag ) ;
2005-04-17 02:20:36 +04:00
out :
return rc ;
}
/**
2009-09-13 06:54:17 +04:00
* avc_flush - Flush the cache
2005-04-17 02:20:36 +04:00
*/
2023-03-09 21:30:37 +03:00
static void avc_flush ( void )
2005-04-17 02:20:36 +04:00
{
2009-02-12 22:51:04 +03:00
struct hlist_head * head ;
2009-09-13 06:54:17 +04:00
struct avc_node * node ;
2009-02-12 22:50:59 +03:00
spinlock_t * lock ;
2009-09-13 06:54:17 +04:00
unsigned long flag ;
int i ;
2005-04-17 02:20:36 +04:00
for ( i = 0 ; i < AVC_CACHE_SLOTS ; i + + ) {
2023-03-09 21:30:37 +03:00
head = & selinux_avc . avc_cache . slots [ i ] ;
lock = & selinux_avc . avc_cache . slots_lock [ i ] ;
2009-02-12 22:50:59 +03:00
spin_lock_irqsave ( lock , flag ) ;
2008-04-22 05:12:33 +04:00
/*
* With preemptable RCU , the outer spinlock does not
* prevent RCU grace periods from ending .
*/
rcu_read_lock ( ) ;
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 05:06:00 +04:00
hlist_for_each_entry ( node , head , list )
2023-03-09 21:30:37 +03:00
avc_node_delete ( node ) ;
2008-04-22 05:12:33 +04:00
rcu_read_unlock ( ) ;
2009-02-12 22:50:59 +03:00
spin_unlock_irqrestore ( lock , flag ) ;
2005-04-17 02:20:36 +04:00
}
2009-09-13 06:54:17 +04:00
}
/**
* avc_ss_reset - Flush the cache and revalidate migrated permissions .
* @ seqno : policy sequence number
*/
2023-03-09 21:30:37 +03:00
int avc_ss_reset ( u32 seqno )
2009-09-13 06:54:17 +04:00
{
struct avc_callback_node * c ;
int rc = 0 , tmprc ;
2023-03-09 21:30:37 +03:00
avc_flush ( ) ;
2005-04-17 02:20:36 +04:00
for ( c = avc_callbacks ; c ; c = c - > next ) {
if ( c - > events & AVC_CALLBACK_RESET ) {
2012-03-07 18:17:14 +04:00
tmprc = c - > callback ( AVC_CALLBACK_RESET ) ;
2006-02-25 00:44:05 +03:00
/* save the first error encountered for the return
value and continue processing the callbacks */
if ( ! rc )
rc = tmprc ;
2005-04-17 02:20:36 +04:00
}
}
2023-03-09 21:30:37 +03:00
avc_latest_notif_update ( seqno , 0 ) ;
2005-04-17 02:20:36 +04:00
return rc ;
}
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
/**
* avc_compute_av - Add an entry to the AVC based on the security policy
* @ ssid : subject
* @ tsid : object / target
* @ tclass : object class
* @ avd : access vector decision
* @ xp_node : AVC extended permissions node
2012-03-31 21:58:08 +04:00
*
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
* Slow - path helper function for avc_has_perm_noaudit , when the avc_node lookup
* fails . Don ' t inline this , since it ' s the slow - path and just results in a
* bigger stack frame .
2012-03-31 21:58:08 +04:00
*/
2023-04-03 19:37:53 +03:00
static noinline void avc_compute_av ( u32 ssid , u32 tsid , u16 tclass ,
struct av_decision * avd ,
struct avc_xperms_node * xp_node )
2012-03-31 21:58:08 +04:00
{
2015-07-11 00:19:56 +03:00
INIT_LIST_HEAD ( & xp_node - > xpd_head ) ;
2023-03-09 21:30:37 +03:00
security_compute_av ( ssid , tsid , tclass , avd , & xp_node - > xp ) ;
2023-04-03 19:37:53 +03:00
avc_insert ( ssid , tsid , tclass , avd , xp_node ) ;
2012-03-31 21:58:08 +04:00
}
2023-03-09 21:30:37 +03:00
static noinline int avc_denied ( u32 ssid , u32 tsid ,
2018-03-05 19:47:56 +03:00
u16 tclass , u32 requested ,
u8 driver , u8 xperm , unsigned int flags ,
struct av_decision * avd )
2012-03-31 21:58:08 +04:00
{
if ( flags & AVC_STRICT )
return - EACCES ;
2023-03-09 21:30:37 +03:00
if ( enforcing_enabled ( ) & &
2018-03-02 02:48:02 +03:00
! ( avd - > flags & AVD_FLAGS_PERMISSIVE ) )
2012-03-31 21:58:08 +04:00
return - EACCES ;
2023-03-09 21:30:37 +03:00
avc_update_node ( AVC_CALLBACK_GRANT , requested , driver ,
2018-03-05 19:47:56 +03:00
xperm , ssid , tsid , tclass , avd - > seqno , NULL , flags ) ;
2012-03-31 21:58:08 +04:00
return 0 ;
}
2015-07-11 00:19:56 +03:00
/*
* The avc extended permissions logic adds an additional 256 bits of
* permissions to an avc node when extended permissions for that node are
* specified in the avtab . If the additional 256 permissions is not adequate ,
* as - is the case with ioctls , then multiple may be chained together and the
* driver field is used to specify which set contains the permission .
*/
2023-03-09 21:30:37 +03:00
int avc_has_extended_perms ( u32 ssid , u32 tsid , u16 tclass , u32 requested ,
2018-03-05 19:47:56 +03:00
u8 driver , u8 xperm , struct common_audit_data * ad )
2015-07-11 00:19:56 +03:00
{
struct avc_node * node ;
struct av_decision avd ;
u32 denied ;
struct extended_perms_decision local_xpd ;
struct extended_perms_decision * xpd = NULL ;
struct extended_perms_data allowed ;
struct extended_perms_data auditallow ;
struct extended_perms_data dontaudit ;
struct avc_xperms_node local_xp_node ;
struct avc_xperms_node * xp_node ;
int rc = 0 , rc2 ;
xp_node = & local_xp_node ;
2019-01-28 18:43:33 +03:00
if ( WARN_ON ( ! requested ) )
return - EACCES ;
2015-07-11 00:19:56 +03:00
rcu_read_lock ( ) ;
2023-03-09 21:30:37 +03:00
node = avc_lookup ( ssid , tsid , tclass ) ;
2015-07-11 00:19:56 +03:00
if ( unlikely ( ! node ) ) {
2023-03-09 21:30:37 +03:00
avc_compute_av ( ssid , tsid , tclass , & avd , xp_node ) ;
2015-07-11 00:19:56 +03:00
} else {
memcpy ( & avd , & node - > ae . avd , sizeof ( avd ) ) ;
xp_node = node - > ae . xp_node ;
}
/* if extended permissions are not defined, only consider av_decision */
if ( ! xp_node | | ! xp_node - > xp . len )
goto decision ;
local_xpd . allowed = & allowed ;
local_xpd . auditallow = & auditallow ;
local_xpd . dontaudit = & dontaudit ;
xpd = avc_xperms_decision_lookup ( driver , xp_node ) ;
if ( unlikely ( ! xpd ) ) {
/*
* Compute the extended_perms_decision only if the driver
* is flagged
*/
if ( ! security_xperm_test ( xp_node - > xp . drivers . p , driver ) ) {
avd . allowed & = ~ requested ;
goto decision ;
}
rcu_read_unlock ( ) ;
2023-03-09 21:30:37 +03:00
security_compute_xperms_decision ( ssid , tsid , tclass ,
2018-03-05 19:47:56 +03:00
driver , & local_xpd ) ;
2015-07-11 00:19:56 +03:00
rcu_read_lock ( ) ;
2023-03-09 21:30:37 +03:00
avc_update_node ( AVC_CALLBACK_ADD_XPERMS , requested ,
2018-03-05 19:47:56 +03:00
driver , xperm , ssid , tsid , tclass , avd . seqno ,
& local_xpd , 0 ) ;
2015-07-11 00:19:56 +03:00
} else {
avc_quick_copy_xperms_decision ( xperm , & local_xpd , xpd ) ;
}
xpd = & local_xpd ;
if ( ! avc_xperms_has_perm ( xpd , xperm , XPERMS_ALLOWED ) )
avd . allowed & = ~ requested ;
decision :
denied = requested & ~ ( avd . allowed ) ;
if ( unlikely ( denied ) )
2023-03-09 21:30:37 +03:00
rc = avc_denied ( ssid , tsid , tclass , requested ,
2018-03-05 19:47:56 +03:00
driver , xperm , AVC_EXTENDED_PERMS , & avd ) ;
2015-07-11 00:19:56 +03:00
rcu_read_unlock ( ) ;
2023-03-09 21:30:37 +03:00
rc2 = avc_xperms_audit ( ssid , tsid , tclass , requested ,
2015-07-11 00:19:56 +03:00
& avd , xpd , xperm , rc , ad ) ;
if ( rc2 )
return rc2 ;
return rc ;
}
2012-03-31 21:58:08 +04:00
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
/**
* avc_perm_nonode - Add an entry to the AVC
* @ ssid : subject
* @ tsid : object / target
* @ tclass : object class
* @ requested : requested permissions
* @ flags : AVC flags
* @ avd : access vector decision
*
* This is the " we have no node " part of avc_has_perm_noaudit ( ) , which is
* unlikely and needs extra stack space for the new node that we generate , so
* don ' t inline it .
*/
2023-03-09 21:30:37 +03:00
static noinline int avc_perm_nonode ( u32 ssid , u32 tsid , u16 tclass ,
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
u32 requested , unsigned int flags ,
struct av_decision * avd )
{
u32 denied ;
struct avc_xperms_node xp_node ;
2023-03-09 21:30:37 +03:00
avc_compute_av ( ssid , tsid , tclass , avd , & xp_node ) ;
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
denied = requested & ~ ( avd - > allowed ) ;
if ( unlikely ( denied ) )
2023-03-09 21:30:37 +03:00
return avc_denied ( ssid , tsid , tclass , requested , 0 , 0 ,
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
flags , avd ) ;
return 0 ;
}
2005-04-17 02:20:36 +04:00
/**
* avc_has_perm_noaudit - Check permissions but perform no auditing .
* @ ssid : source security identifier
* @ tsid : target security identifier
* @ tclass : target security class
* @ requested : requested permissions , interpreted based on @ tclass
2021-01-16 23:40:54 +03:00
* @ flags : AVC_STRICT or 0
2005-04-17 02:20:36 +04:00
* @ avd : access vector decisions
*
* Check the AVC to determine whether the @ requested permissions are granted
* for the SID pair ( @ ssid , @ tsid ) , interpreting the permissions
* based on @ tclass , and call the security server on a cache miss to obtain
* a new decision and add it to the cache . Return a copy of the decisions
* in @ avd . Return % 0 if all @ requested permissions are granted ,
* - % EACCES if any permissions are denied , or another - errno upon
* other errors . This function is typically called by avc_has_perm ( ) ,
* but may also be called directly to separate permission checking from
* auditing , e . g . in cases where a lock must be held for the check but
* should be released for the auditing .
*/
2023-03-09 21:30:37 +03:00
inline int avc_has_perm_noaudit ( u32 ssid , u32 tsid ,
2018-03-05 19:47:56 +03:00
u16 tclass , u32 requested ,
unsigned int flags ,
struct av_decision * avd )
2005-04-17 02:20:36 +04:00
{
u32 denied ;
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
struct avc_node * node ;
2005-04-17 02:20:36 +04:00
2019-01-28 18:43:33 +03:00
if ( WARN_ON ( ! requested ) )
return - EACCES ;
2008-03-11 21:19:34 +03:00
2005-04-17 02:20:36 +04:00
rcu_read_lock ( ) ;
2023-03-09 21:30:37 +03:00
node = avc_lookup ( ssid , tsid , tclass ) ;
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
if ( unlikely ( ! node ) ) {
rcu_read_unlock ( ) ;
2023-03-09 21:30:37 +03:00
return avc_perm_nonode ( ssid , tsid , tclass , requested ,
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
flags , avd ) ;
}
denied = requested & ~ node - > ae . avd . allowed ;
memcpy ( avd , & node - > ae . avd , sizeof ( * avd ) ) ;
rcu_read_unlock ( ) ;
2005-04-17 02:20:36 +04:00
2012-03-31 21:58:08 +04:00
if ( unlikely ( denied ) )
2023-03-09 21:30:37 +03:00
return avc_denied ( ssid , tsid , tclass , requested , 0 , 0 ,
selinux: uninline unlikely parts of avc_has_perm_noaudit()
This is based on earlier patch posted to the list by Linus, his
commit description read:
"avc_has_perm_noaudit()is one of those hot functions that end up
being used by almost all filesystem operations (through
"avc_has_perm()") and it's intended to be cheap enough to inline.
However, it turns out that the unlikely parts of it (where it
doesn't find an existing avc node) need a fair amount of stack
space for the automatic replacement node, so if it were to be
inlined (at least clang does not) it would just use stack space
unnecessarily.
So split the unlikely part out of it, and mark that part noinline.
That improves the actual likely part."
The basic idea behind the patch was reasonable, but there were minor
nits (double indenting, etc.) and the RCU read lock unlock/re-lock in
avc_compute_av() began to look even more ugly. This patch builds on
Linus' first effort by cleaning things up a bit and removing the RCU
unlock/lock dance in avc_compute_av().
Removing the RCU lock dance in avc_compute_av() is safe as there are
currently two callers of avc_compute_av(): avc_has_perm_noaudit() and
avc_has_extended_perms(). The first caller in avc_has_perm_noaudit()
does not require a RCU lock as there is no avc_node to protect so the
RCU lock can be dropped before calling avc_compute_av(). The second
caller, avc_has_extended_perms(), is similar in that there is no
avc_node that requires RCU protection, but the code is simplified by
holding the RCU look around the avc_compute_av() call, and given that
we enter a RCU critical section in security_compute_av() (called from
av_compute_av()) the impact will likely be unnoticeable. It is also
worth noting that avc_has_extended_perms() is only called from the
SELinux ioctl() access control hook at the moment.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
2023-03-07 22:55:01 +03:00
flags , avd ) ;
return 0 ;
2005-04-17 02:20:36 +04:00
}
/**
* avc_has_perm - Check permissions and perform any appropriate auditing .
* @ ssid : source security identifier
* @ tsid : target security identifier
* @ tclass : target security class
* @ requested : requested permissions , interpreted based on @ tclass
* @ auditdata : auxiliary audit data
*
* Check the AVC to determine whether the @ requested permissions are granted
* for the SID pair ( @ ssid , @ tsid ) , interpreting the permissions
* based on @ tclass , and call the security server on a cache miss to obtain
* a new decision and add it to the cache . Audit the granting or denial of
* permissions in accordance with the policy . Return % 0 if all @ requested
* permissions are granted , - % EACCES if any permissions are denied , or
* another - errno upon other errors .
*/
2023-03-09 21:30:37 +03:00
int avc_has_perm ( u32 ssid , u32 tsid , u16 tclass ,
2013-10-04 23:57:22 +04:00
u32 requested , struct common_audit_data * auditdata )
2005-04-17 02:20:36 +04:00
{
struct av_decision avd ;
2011-04-26 00:26:29 +04:00
int rc , rc2 ;
2005-04-17 02:20:36 +04:00
2023-03-09 21:30:37 +03:00
rc = avc_has_perm_noaudit ( ssid , tsid , tclass , requested , 0 ,
2018-03-05 19:47:56 +03:00
& avd ) ;
2011-04-26 00:26:29 +04:00
2023-03-09 21:30:37 +03:00
rc2 = avc_audit ( ssid , tsid , tclass , requested , & avd , rc ,
2021-01-16 23:57:49 +03:00
auditdata ) ;
2019-11-22 20:22:44 +03:00
if ( rc2 )
return rc2 ;
return rc ;
}
2023-03-09 21:30:37 +03:00
u32 avc_policy_seqno ( void )
2007-09-14 04:27:07 +04:00
{
2023-03-09 21:30:37 +03:00
return selinux_avc . avc_cache . latest_notif ;
2007-09-14 04:27:07 +04:00
}