2019-11-14 21:02:54 +03:00
// SPDX-License-Identifier: GPL-2.0
2020-01-10 21:48:34 +03:00
# include <linux/jiffies.h>
2019-11-14 21:02:54 +03:00
# include <linux/kernel.h>
2020-01-15 19:25:12 +03:00
# include <linux/lockdep.h>
2019-11-14 21:02:54 +03:00
# include <linux/preempt.h>
# include <linux/printk.h>
# include <linux/sched.h>
# include <linux/spinlock.h>
# include <linux/stacktrace.h>
# include "kcsan.h"
# include "encoding.h"
/*
* Max . number of stack entries to show in the report .
*/
# define NUM_STACK_ENTRIES 64
/*
* Other thread info : communicated from other racing thread to thread that set
* up the watchpoint , which then prints the complete report atomically . Only
* need one struct , as all threads should to be serialized regardless to print
* the reports , with reporting being in the slow - path .
*/
static struct {
2019-11-20 12:41:43 +03:00
const volatile void * ptr ;
size_t size ;
2020-01-10 21:48:33 +03:00
int access_type ;
2019-11-20 12:41:43 +03:00
int task_pid ;
int cpu_id ;
unsigned long stack_entries [ NUM_STACK_ENTRIES ] ;
int num_stack_entries ;
2019-11-14 21:02:54 +03:00
} other_info = { . ptr = NULL } ;
2020-01-10 21:48:34 +03:00
/*
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* Information about reported races ; used to rate limit reporting .
2020-01-10 21:48:34 +03:00
*/
struct report_time {
/*
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* The last time the race was reported .
2020-01-10 21:48:34 +03:00
*/
unsigned long time ;
/*
* The frames of the 2 threads ; if only 1 thread is known , one frame
* will be 0.
*/
unsigned long frame1 ;
unsigned long frame2 ;
} ;
/*
* Since we also want to be able to debug allocators with KCSAN , to avoid
* deadlock , report_times cannot be dynamically resized with krealloc in
* rate_limit_report .
*
* Therefore , we use a fixed - size array , which at most will occupy a page . This
* still adequately rate limits reports , assuming that a ) number of unique data
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* races is not excessive , and b ) occurrence of unique races within the
2020-01-10 21:48:34 +03:00
* same time window is limited .
*/
# define REPORT_TIMES_MAX (PAGE_SIZE / sizeof(struct report_time))
# define REPORT_TIMES_SIZE \
( CONFIG_KCSAN_REPORT_ONCE_IN_MS > REPORT_TIMES_MAX ? \
REPORT_TIMES_MAX : \
CONFIG_KCSAN_REPORT_ONCE_IN_MS )
static struct report_time report_times [ REPORT_TIMES_SIZE ] ;
2019-11-14 21:02:54 +03:00
/*
* This spinlock protects reporting and other_info , since other_info is usually
* required when reporting .
*/
static DEFINE_SPINLOCK ( report_lock ) ;
2020-01-10 21:48:34 +03:00
/*
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* Checks if the race identified by thread frames frame1 and frame2 has
2020-01-10 21:48:34 +03:00
* been reported since ( now - KCSAN_REPORT_ONCE_IN_MS ) .
*/
static bool rate_limit_report ( unsigned long frame1 , unsigned long frame2 )
{
struct report_time * use_entry = & report_times [ 0 ] ;
unsigned long invalid_before ;
int i ;
BUILD_BUG_ON ( CONFIG_KCSAN_REPORT_ONCE_IN_MS ! = 0 & & REPORT_TIMES_SIZE = = 0 ) ;
if ( CONFIG_KCSAN_REPORT_ONCE_IN_MS = = 0 )
return false ;
invalid_before = jiffies - msecs_to_jiffies ( CONFIG_KCSAN_REPORT_ONCE_IN_MS ) ;
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
/* Check if a matching race report exists. */
2020-01-10 21:48:34 +03:00
for ( i = 0 ; i < REPORT_TIMES_SIZE ; + + i ) {
struct report_time * rt = & report_times [ i ] ;
/*
* Must always select an entry for use to store info as we
* cannot resize report_times ; at the end of the scan , use_entry
* will be the oldest entry , which ideally also happened before
* KCSAN_REPORT_ONCE_IN_MS ago .
*/
if ( time_before ( rt - > time , use_entry - > time ) )
use_entry = rt ;
/*
* Initially , no need to check any further as this entry as well
* as following entries have never been used .
*/
if ( rt - > time = = 0 )
break ;
/* Check if entry expired. */
if ( time_before ( rt - > time , invalid_before ) )
continue ; /* before KCSAN_REPORT_ONCE_IN_MS ago */
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
/* Reported recently, check if race matches. */
2020-01-10 21:48:34 +03:00
if ( ( rt - > frame1 = = frame1 & & rt - > frame2 = = frame2 ) | |
( rt - > frame1 = = frame2 & & rt - > frame2 = = frame1 ) )
return true ;
}
use_entry - > time = jiffies ;
use_entry - > frame1 = frame1 ;
use_entry - > frame2 = frame2 ;
return false ;
}
2019-11-14 21:02:54 +03:00
/*
* Special rules to skip reporting .
*/
2019-11-20 12:41:43 +03:00
static bool
2020-01-29 18:01:02 +03:00
skip_report ( bool value_change , unsigned long top_frame )
2019-11-14 21:02:54 +03:00
{
2020-01-29 18:01:02 +03:00
/*
* The first call to skip_report always has value_change = = true , since we
* cannot know the value written of an instrumented access . For the 2 nd
* call there are 6 cases with CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY :
*
* 1. read watchpoint , conflicting write ( value_change = = true ) : report ;
* 2. read watchpoint , conflicting write ( value_change = = false ) : skip ;
* 3. write watchpoint , conflicting write ( value_change = = true ) : report ;
* 4. write watchpoint , conflicting write ( value_change = = false ) : skip ;
* 5. write watchpoint , conflicting read ( value_change = = false ) : skip ;
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* 6. write watchpoint , conflicting read ( value_change = = true ) : report ;
2020-01-29 18:01:02 +03:00
*
* Cases 1 - 4 are intuitive and expected ; case 5 ensures we do not report
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* data races where the write may have rewritten the same value ; case 6
* is possible either if the size is larger than what we check value
* changes for or the access type is KCSAN_ACCESS_ASSERT .
2020-01-29 18:01:02 +03:00
*/
if ( IS_ENABLED ( CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY ) & & ! value_change ) {
2019-11-14 21:02:54 +03:00
/*
* The access is a write , but the data value did not change .
*
* We opt - out of this filter for certain functions at request of
* maintainers .
*/
char buf [ 64 ] ;
snprintf ( buf , sizeof ( buf ) , " %ps " , ( void * ) top_frame ) ;
if ( ! strnstr ( buf , " rcu_ " , sizeof ( buf ) ) & &
! strnstr ( buf , " _rcu " , sizeof ( buf ) ) & &
! strnstr ( buf , " _srcu " , sizeof ( buf ) ) )
return true ;
}
return kcsan_skip_report_debugfs ( top_frame ) ;
}
2020-01-10 21:48:33 +03:00
static const char * get_access_type ( int type )
2019-11-14 21:02:54 +03:00
{
2020-01-10 21:48:33 +03:00
switch ( type ) {
case 0 :
return " read " ;
case KCSAN_ACCESS_ATOMIC :
return " read (marked) " ;
case KCSAN_ACCESS_WRITE :
return " write " ;
case KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC :
return " write (marked) " ;
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
/*
* ASSERT variants :
*/
case KCSAN_ACCESS_ASSERT :
case KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_ATOMIC :
return " assert no writes " ;
case KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE :
case KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC :
return " assert no accesses " ;
2020-01-10 21:48:33 +03:00
default :
BUG ( ) ;
}
2019-11-14 21:02:54 +03:00
}
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
static const char * get_bug_type ( int type )
{
return ( type & KCSAN_ACCESS_ASSERT ) ! = 0 ? " assert: race " : " data-race " ;
}
2019-11-14 21:02:54 +03:00
/* Return thread description: in task or interrupt. */
static const char * get_thread_desc ( int task_id )
{
if ( task_id ! = - 1 ) {
static char buf [ 32 ] ; /* safe: protected by report_lock */
snprintf ( buf , sizeof ( buf ) , " task %i " , task_id ) ;
return buf ;
}
return " interrupt " ;
}
/* Helper to skip KCSAN-related functions in stack-trace. */
static int get_stack_skipnr ( unsigned long stack_entries [ ] , int num_entries )
{
char buf [ 64 ] ;
int skip = 0 ;
for ( ; skip < num_entries ; + + skip ) {
snprintf ( buf , sizeof ( buf ) , " %ps " , ( void * ) stack_entries [ skip ] ) ;
if ( ! strnstr ( buf , " csan_ " , sizeof ( buf ) ) & &
! strnstr ( buf , " tsan_ " , sizeof ( buf ) ) & &
! strnstr ( buf , " _once_size " , sizeof ( buf ) ) ) {
break ;
}
}
return skip ;
}
/* Compares symbolized strings of addr1 and addr2. */
static int sym_strcmp ( void * addr1 , void * addr2 )
{
char buf1 [ 64 ] ;
char buf2 [ 64 ] ;
snprintf ( buf1 , sizeof ( buf1 ) , " %pS " , addr1 ) ;
snprintf ( buf2 , sizeof ( buf2 ) , " %pS " , addr2 ) ;
2019-11-20 12:41:43 +03:00
2019-11-14 21:02:54 +03:00
return strncmp ( buf1 , buf2 , sizeof ( buf1 ) ) ;
}
/*
* Returns true if a report was generated , false otherwise .
*/
2020-01-10 21:48:33 +03:00
static bool print_report ( const volatile void * ptr , size_t size , int access_type ,
2019-11-14 21:02:54 +03:00
bool value_change , int cpu_id ,
enum kcsan_report_type type )
{
unsigned long stack_entries [ NUM_STACK_ENTRIES ] = { 0 } ;
2019-11-20 12:41:43 +03:00
int num_stack_entries = stack_trace_save ( stack_entries , NUM_STACK_ENTRIES , 1 ) ;
2019-11-14 21:02:54 +03:00
int skipnr = get_stack_skipnr ( stack_entries , num_stack_entries ) ;
2020-01-10 21:48:34 +03:00
unsigned long this_frame = stack_entries [ skipnr ] ;
unsigned long other_frame = 0 ;
int other_skipnr = 0 ; /* silence uninit warnings */
2019-11-14 21:02:54 +03:00
/*
* Must check report filter rules before starting to print .
*/
2020-01-29 18:01:02 +03:00
if ( skip_report ( true , stack_entries [ skipnr ] ) )
2019-11-14 21:02:54 +03:00
return false ;
if ( type = = KCSAN_REPORT_RACE_SIGNAL ) {
other_skipnr = get_stack_skipnr ( other_info . stack_entries ,
other_info . num_stack_entries ) ;
2020-01-10 21:48:34 +03:00
other_frame = other_info . stack_entries [ other_skipnr ] ;
2019-11-14 21:02:54 +03:00
2019-11-20 12:41:43 +03:00
/* @value_change is only known for the other thread */
2020-01-29 18:01:02 +03:00
if ( skip_report ( value_change , other_frame ) )
2019-11-14 21:02:54 +03:00
return false ;
}
2020-01-10 21:48:34 +03:00
if ( rate_limit_report ( this_frame , other_frame ) )
return false ;
2019-11-14 21:02:54 +03:00
/* Print report header. */
pr_err ( " ================================================================== \n " ) ;
switch ( type ) {
case KCSAN_REPORT_RACE_SIGNAL : {
int cmp ;
/*
* Order functions lexographically for consistent bug titles .
* Do not print offset of functions to keep title short .
*/
2020-01-10 21:48:34 +03:00
cmp = sym_strcmp ( ( void * ) other_frame , ( void * ) this_frame ) ;
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
pr_err ( " BUG: KCSAN: %s in %ps / %ps \n " ,
get_bug_type ( access_type | other_info . access_type ) ,
2020-01-10 21:48:34 +03:00
( void * ) ( cmp < 0 ? other_frame : this_frame ) ,
( void * ) ( cmp < 0 ? this_frame : other_frame ) ) ;
2019-11-14 21:02:54 +03:00
} break ;
case KCSAN_REPORT_RACE_UNKNOWN_ORIGIN :
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
pr_err ( " BUG: KCSAN: %s in %pS \n " , get_bug_type ( access_type ) ,
( void * ) this_frame ) ;
2019-11-14 21:02:54 +03:00
break ;
default :
BUG ( ) ;
}
pr_err ( " \n " ) ;
/* Print information about the racing accesses. */
switch ( type ) {
case KCSAN_REPORT_RACE_SIGNAL :
pr_err ( " %s to 0x%px of %zu bytes by %s on cpu %i: \n " ,
2020-01-10 21:48:33 +03:00
get_access_type ( other_info . access_type ) , other_info . ptr ,
2019-11-14 21:02:54 +03:00
other_info . size , get_thread_desc ( other_info . task_pid ) ,
other_info . cpu_id ) ;
/* Print the other thread's stack trace. */
stack_trace_print ( other_info . stack_entries + other_skipnr ,
other_info . num_stack_entries - other_skipnr ,
0 ) ;
pr_err ( " \n " ) ;
pr_err ( " %s to 0x%px of %zu bytes by %s on cpu %i: \n " ,
2020-01-10 21:48:33 +03:00
get_access_type ( access_type ) , ptr , size ,
2019-11-14 21:02:54 +03:00
get_thread_desc ( in_task ( ) ? task_pid_nr ( current ) : - 1 ) ,
cpu_id ) ;
break ;
case KCSAN_REPORT_RACE_UNKNOWN_ORIGIN :
pr_err ( " race at unknown origin, with %s to 0x%px of %zu bytes by %s on cpu %i: \n " ,
2020-01-10 21:48:33 +03:00
get_access_type ( access_type ) , ptr , size ,
2019-11-14 21:02:54 +03:00
get_thread_desc ( in_task ( ) ? task_pid_nr ( current ) : - 1 ) ,
cpu_id ) ;
break ;
default :
BUG ( ) ;
}
/* Print stack trace of this thread. */
stack_trace_print ( stack_entries + skipnr , num_stack_entries - skipnr ,
0 ) ;
/* Print report footer. */
pr_err ( " \n " ) ;
pr_err ( " Reported by Kernel Concurrency Sanitizer on: \n " ) ;
dump_stack_print_info ( KERN_DEFAULT ) ;
pr_err ( " ================================================================== \n " ) ;
return true ;
}
static void release_report ( unsigned long * flags , enum kcsan_report_type type )
{
if ( type = = KCSAN_REPORT_RACE_SIGNAL )
other_info . ptr = NULL ; /* mark for reuse */
spin_unlock_irqrestore ( & report_lock , * flags ) ;
}
/*
* Depending on the report type either sets other_info and returns false , or
* acquires the matching other_info and returns true . If other_info is not
* required for the report type , simply acquires report_lock and returns true .
*/
static bool prepare_report ( unsigned long * flags , const volatile void * ptr ,
2020-01-10 21:48:33 +03:00
size_t size , int access_type , int cpu_id ,
2019-11-14 21:02:54 +03:00
enum kcsan_report_type type )
{
if ( type ! = KCSAN_REPORT_CONSUMED_WATCHPOINT & &
type ! = KCSAN_REPORT_RACE_SIGNAL ) {
/* other_info not required; just acquire report_lock */
spin_lock_irqsave ( & report_lock , * flags ) ;
return true ;
}
retry :
spin_lock_irqsave ( & report_lock , * flags ) ;
switch ( type ) {
case KCSAN_REPORT_CONSUMED_WATCHPOINT :
if ( other_info . ptr ! = NULL )
break ; /* still in use, retry */
2019-11-20 12:41:43 +03:00
other_info . ptr = ptr ;
other_info . size = size ;
2020-01-10 21:48:33 +03:00
other_info . access_type = access_type ;
2019-11-20 12:41:43 +03:00
other_info . task_pid = in_task ( ) ? task_pid_nr ( current ) : - 1 ;
other_info . cpu_id = cpu_id ;
other_info . num_stack_entries = stack_trace_save ( other_info . stack_entries , NUM_STACK_ENTRIES , 1 ) ;
2019-11-14 21:02:54 +03:00
spin_unlock_irqrestore ( & report_lock , * flags ) ;
/*
* The other thread will print the summary ; other_info may now
* be consumed .
*/
return false ;
case KCSAN_REPORT_RACE_SIGNAL :
if ( other_info . ptr = = NULL )
break ; /* no data available yet, retry */
/*
* First check if this is the other_info we are expecting , i . e .
* matches based on how watchpoint was encoded .
*/
if ( ! matching_access ( ( unsigned long ) other_info . ptr &
WATCHPOINT_ADDR_MASK ,
other_info . size ,
( unsigned long ) ptr & WATCHPOINT_ADDR_MASK ,
size ) )
break ; /* mismatching watchpoint, retry */
if ( ! matching_access ( ( unsigned long ) other_info . ptr ,
other_info . size , ( unsigned long ) ptr ,
size ) ) {
/*
* If the actual accesses to not match , this was a false
* positive due to watchpoint encoding .
*/
kcsan_counter_inc (
KCSAN_COUNTER_ENCODING_FALSE_POSITIVES ) ;
/* discard this other_info */
release_report ( flags , KCSAN_REPORT_RACE_SIGNAL ) ;
2020-02-10 17:56:39 +03:00
return false ;
}
access_type | = other_info . access_type ;
if ( ( access_type & KCSAN_ACCESS_WRITE ) = = 0 ) {
/*
* While the address matches , this is not the other_info
* from the thread that consumed our watchpoint , since
* neither this nor the access in other_info is a write .
* It is invalid to continue with the report , since we
* only have information about reads .
*
* This can happen due to concurrent races on the same
* address , with at least 4 threads . To avoid locking up
* other_info and all other threads , we have to consume
* it regardless .
*
* A concrete case to illustrate why we might lock up if
* we do not consume other_info :
*
* We have 4 threads , all accessing the same address
* ( or matching address ranges ) . Assume the following
* watcher and watchpoint consumer pairs :
* write1 - read1 , read2 - write2 . The first to populate
* other_info is write2 , however , write1 consumes it ,
* resulting in a report of write1 - write2 . This report
* is valid , however , now read1 populates other_info ;
* read2 - read1 is an invalid conflict , yet , no other
* conflicting access is left . Therefore , we must
* consume read1 ' s other_info .
*
* Since this case is assumed to be rare , it is
* reasonable to omit this report : one of the other
* reports includes information about the same shared
* data , and at this point the likelihood that we
* re - report the same race again is high .
*/
release_report ( flags , KCSAN_REPORT_RACE_SIGNAL ) ;
2019-11-14 21:02:54 +03:00
return false ;
}
/*
* Matching & usable access in other_info : keep other_info_lock
* locked , as this thread consumes it to print the full report ;
* unlocked in release_report .
*/
return true ;
default :
BUG ( ) ;
}
spin_unlock_irqrestore ( & report_lock , * flags ) ;
2019-11-20 12:41:43 +03:00
2019-11-14 21:02:54 +03:00
goto retry ;
}
2020-01-10 21:48:33 +03:00
void kcsan_report ( const volatile void * ptr , size_t size , int access_type ,
2019-11-14 21:02:54 +03:00
bool value_change , int cpu_id , enum kcsan_report_type type )
{
unsigned long flags = 0 ;
2020-01-15 19:25:12 +03:00
/*
* With TRACE_IRQFLAGS , lockdep ' s IRQ trace state becomes corrupted if
* we do not turn off lockdep here ; this could happen due to recursion
kcsan: Introduce KCSAN_ACCESS_ASSERT access type
The KCSAN_ACCESS_ASSERT access type may be used to introduce dummy reads
and writes to assert certain properties of concurrent code, where bugs
could not be detected as normal data races.
For example, a variable that is only meant to be written by a single
CPU, but may be read (without locking) by other CPUs must still be
marked properly to avoid data races. However, concurrent writes,
regardless if WRITE_ONCE() or not, would be a bug. Using
kcsan_check_access(&x, sizeof(x), KCSAN_ACCESS_ASSERT) would allow
catching such bugs.
To support KCSAN_ACCESS_ASSERT the following notable changes were made:
* If an access is of type KCSAN_ASSERT_ACCESS, disable various filters
that only apply to data races, so that all races that KCSAN observes are
reported.
* Bug reports that involve an ASSERT access type will be reported as
"KCSAN: assert: race in ..." instead of "data-race"; this will help
more easily distinguish them.
* Update a few comments to just mention 'races' where we do not always
mean pure data races.
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2020-02-06 18:46:24 +03:00
* into lockdep via KCSAN if we detect a race in utilities used by
2020-01-15 19:25:12 +03:00
* lockdep .
*/
lockdep_off ( ) ;
2019-11-14 21:02:54 +03:00
kcsan_disable_current ( ) ;
2020-01-10 21:48:33 +03:00
if ( prepare_report ( & flags , ptr , size , access_type , cpu_id , type ) ) {
if ( print_report ( ptr , size , access_type , value_change , cpu_id , type ) & & panic_on_warn )
2019-11-14 21:02:54 +03:00
panic ( " panic_on_warn set ... \n " ) ;
release_report ( & flags , type ) ;
}
kcsan_enable_current ( ) ;
2020-01-15 19:25:12 +03:00
lockdep_on ( ) ;
2019-11-14 21:02:54 +03:00
}