License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 15:07:57 +01:00
// SPDX-License-Identifier: GPL-2.0
2022-12-09 14:41:27 -06:00
# define pr_fmt(fmt) "PCI: " fmt
2005-04-16 15:20:36 -07:00
# include <linux/pci.h>
# include <linux/acpi.h>
# include <linux/init.h>
2005-10-01 02:34:42 +10:00
# include <linux/irq.h>
2007-10-03 15:56:14 -07:00
# include <linux/dmi.h>
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 17:04:11 +09:00
# include <linux/slab.h>
2015-10-14 14:29:41 +08:00
# include <linux/pci-acpi.h>
2005-09-12 18:49:24 +02:00
# include <asm/numa.h>
2008-12-27 18:32:28 +05:30
# include <asm/pci_x86.h>
2005-04-16 15:20:36 -07:00
2007-10-03 15:56:51 -07:00
struct pci_root_info {
2015-10-14 14:29:41 +08:00
struct acpi_pci_root_info common ;
2012-04-02 18:31:53 -07:00
struct pci_sysdata sd ;
2012-06-22 14:55:17 +08:00
# ifdef CONFIG_PCI_MMCONFIG
bool mcfg_added ;
u8 start_bus ;
u8 end_bus ;
# endif
2007-10-03 15:56:51 -07:00
} ;
x86/PCI: Revert "x86/PCI: Clip only host bridge windows for E820 regions"
This reverts commit 4c5e242d3e93.
Prior to 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820
regions"), E820 regions did not affect PCI host bridge windows. We only
looked at E820 regions and avoided them when allocating new MMIO space.
If firmware PCI bridge window and BAR assignments used E820 regions, we
left them alone.
After 4c5e242d3e93, we removed E820 regions from the PCI host bridge
windows before looking at BARs, so firmware assignments in E820 regions
looked like errors, and we moved things around to fit in the space left
(if any) after removing the E820 regions. This unnecessary BAR
reassignment broke several machines.
Guilherme reported that Steam Deck fails to boot after 4c5e242d3e93. We
clipped the window that contained most 32-bit BARs:
BIOS-e820: [mem 0x00000000a0000000-0x00000000a00fffff] reserved
acpi PNP0A08:00: clipped [mem 0x80000000-0xf7ffffff window] to [mem 0xa0100000-0xf7ffffff window] for e820 entry [mem 0xa0000000-0xa00fffff]
which forced us to reassign all those BARs, for example, this NVMe BAR:
pci 0000:00:01.2: PCI bridge to [bus 01]
pci 0000:00:01.2: bridge window [mem 0x80600000-0x806fffff]
pci 0000:01:00.0: BAR 0: [mem 0x80600000-0x80603fff 64bit]
pci 0000:00:01.2: can't claim window [mem 0x80600000-0x806fffff]: no compatible bridge window
pci 0000:01:00.0: can't claim BAR 0 [mem 0x80600000-0x80603fff 64bit]: no compatible bridge window
pci 0000:00:01.2: bridge window: assigned [mem 0xa0100000-0xa01fffff]
pci 0000:01:00.0: BAR 0: assigned [mem 0xa0100000-0xa0103fff 64bit]
All the reassignments were successful, so the devices should have been
functional at the new addresses, but some were not.
Andy reported a similar failure on an Intel MID platform. Benjamin
reported a similar failure on a VMWare Fusion VM.
Note: this is not a clean revert; this revert keeps the later change to
make the clipping dependent on a new pci_use_e820 bool, moving the checking
of this bool to arch_remove_reservations().
[bhelgaas: commit log, add more reporters and testers]
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=216109
Reported-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reported-by: Benjamin Coddington <bcodding@redhat.com>
Reported-by: Jongman Heo <jongman.heo@gmail.com>
Fixes: 4c5e242d3e93 ("x86/PCI: Clip only host bridge windows for E820 regions")
Link: https://lore.kernel.org/r/20220612144325.85366-1-hdegoede@redhat.com
Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
2022-06-12 16:43:25 +02:00
bool pci_use_e820 = true ;
2010-02-23 10:24:41 -07:00
static bool pci_use_crs = true ;
2021-12-03 16:07:58 +08:00
static bool pci_ignore_seg ;
2010-02-23 10:24:41 -07:00
static int __init set_use_crs ( const struct dmi_system_id * id )
{
pci_use_crs = true ;
return 0 ;
}
2011-12-30 14:37:05 -05:00
static int __init set_nouse_crs ( const struct dmi_system_id * id )
{
pci_use_crs = false ;
return 0 ;
}
2012-10-29 17:26:54 -06:00
static int __init set_ignore_seg ( const struct dmi_system_id * id )
{
2022-12-09 14:41:27 -06:00
pr_info ( " %s detected: ignoring ACPI _SEG \n " , id - > ident ) ;
2012-10-29 17:26:54 -06:00
pci_ignore_seg = true ;
return 0 ;
}
2022-05-19 17:21:49 +02:00
static int __init set_no_e820 ( const struct dmi_system_id * id )
{
2022-12-09 14:41:27 -06:00
pr_info ( " %s detected: not clipping E820 regions from _CRS \n " ,
id - > ident ) ;
2022-05-19 17:21:49 +02:00
pci_use_e820 = false ;
return 0 ;
}
2012-10-29 17:26:54 -06:00
static const struct dmi_system_id pci_crs_quirks [ ] __initconst = {
2010-02-23 10:24:41 -07:00
/* http://bugzilla.kernel.org/show_bug.cgi?id=14183 */
{
. callback = set_use_crs ,
. ident = " IBM System x3800 " ,
. matches = {
DMI_MATCH ( DMI_SYS_VENDOR , " IBM " ) ,
DMI_MATCH ( DMI_PRODUCT_NAME , " x3800 " ) ,
} ,
} ,
x86/PCI: use host bridge _CRS info on ASRock ALiveSATA2-GLAN
This DMI quirk turns on "pci=use_crs" for the ALiveSATA2-GLAN because
amd_bus.c doesn't handle this system correctly.
The system has a single HyperTransport I/O chain, but has two PCI host
bridges to buses 00 and 80. amd_bus.c learns the MMIO range associated
with buses 00-ff and that this range is routed to the HT chain hosted at
node 0, link 0:
bus: [00, ff] on node 0 link 0
bus: 00 index 1 [mem 0x80000000-0xfcffffffff]
This includes the address space for both bus 00 and bus 80, and amd_bus.c
assumes it's all routed to bus 00.
We find device 80:01.0, which BIOS left in the middle of that space, but
we don't find a bridge from bus 00 to bus 80, so we conclude that 80:01.0
is unreachable from bus 00, and we move it from the original, working,
address to something outside the bus 00 aperture, which does not work:
pci 0000:80:01.0: reg 10: [mem 0xfebfc000-0xfebfffff 64bit]
pci 0000:80:01.0: BAR 0: assigned [mem 0xfd00000000-0xfd00003fff 64bit]
The BIOS told us everything we need to know to handle this correctly,
so we're better off if we just pay attention, which lets us leave the
80:01.0 device at the original, working, address:
ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-7f])
pci_root PNP0A03:00: host bridge window [mem 0x80000000-0xff37ffff]
ACPI: PCI Root Bridge [PCI1] (domain 0000 [bus 80-ff])
pci_root PNP0A08:00: host bridge window [mem 0xfebfc000-0xfebfffff]
This was a regression between 2.6.33 and 2.6.34. In 2.6.33, amd_bus.c
was used only when we found multiple HT chains. 3e3da00c01d050, which
enabled amd_bus.c even on systems with a single HT chain, caused this
failure.
This quirk was written by Graham. If we ever enable "pci=use_crs" for
machines from 2006 or earlir, this quirk should be removed.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16007
Cc: stable@kernel.org
Reported-by: Graham Ramsey <ramsey.graham@ntlworld.com>
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
2010-07-23 12:53:27 -06:00
/* https://bugzilla.kernel.org/show_bug.cgi?id=16007 */
/* 2006 AMD HT/VIA system with two host bridges */
{
. callback = set_use_crs ,
. ident = " ASRock ALiveSATA2-GLAN " ,
. matches = {
DMI_MATCH ( DMI_PRODUCT_NAME , " ALiveSATA2-GLAN " ) ,
} ,
} ,
2011-08-31 17:07:10 +02:00
/* https://bugzilla.kernel.org/show_bug.cgi?id=30552 */
/* 2006 AMD HT/VIA system with two host bridges */
{
. callback = set_use_crs ,
. ident = " ASUS M2V-MX SE " ,
. matches = {
DMI_MATCH ( DMI_BOARD_VENDOR , " ASUSTeK Computer INC. " ) ,
DMI_MATCH ( DMI_BOARD_NAME , " M2V-MX SE " ) ,
DMI_MATCH ( DMI_BIOS_VENDOR , " American Megatrends Inc. " ) ,
} ,
} ,
2012-02-28 11:51:10 -07:00
/* https://bugzilla.kernel.org/show_bug.cgi?id=42619 */
{
. callback = set_use_crs ,
. ident = " MSI MS-7253 " ,
. matches = {
DMI_MATCH ( DMI_BOARD_VENDOR , " MICRO-STAR INTERNATIONAL CO., LTD " ) ,
DMI_MATCH ( DMI_BOARD_NAME , " MS-7253 " ) ,
DMI_MATCH ( DMI_BIOS_VENDOR , " Phoenix Technologies, LTD " ) ,
} ,
} ,
2015-06-09 18:54:07 -05:00
/* https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/931368 */
/* https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1033299 */
{
. callback = set_use_crs ,
. ident = " Foxconn K8M890-8237A " ,
. matches = {
DMI_MATCH ( DMI_BOARD_VENDOR , " Foxconn " ) ,
DMI_MATCH ( DMI_BOARD_NAME , " K8M890-8237A " ) ,
DMI_MATCH ( DMI_BIOS_VENDOR , " Phoenix Technologies, LTD " ) ,
} ,
} ,
2011-12-30 14:37:05 -05:00
2012-01-04 11:33:12 -05:00
/* Now for the blacklist.. */
/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
{
. callback = set_nouse_crs ,
. ident = " Dell Studio 1557 " ,
. matches = {
DMI_MATCH ( DMI_BOARD_VENDOR , " Dell Inc. " ) ,
DMI_MATCH ( DMI_PRODUCT_NAME , " Studio 1557 " ) ,
DMI_MATCH ( DMI_BIOS_VERSION , " A09 " ) ,
} ,
} ,
2012-01-04 11:30:52 -05:00
/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
{
. callback = set_nouse_crs ,
. ident = " Thinkpad SL510 " ,
. matches = {
DMI_MATCH ( DMI_BOARD_VENDOR , " LENOVO " ) ,
DMI_MATCH ( DMI_BOARD_NAME , " 2847DFG " ) ,
DMI_MATCH ( DMI_BIOS_VERSION , " 6JET85WW (1.43 ) " ) ,
} ,
} ,
2016-12-28 14:55:16 -06:00
/* https://bugzilla.kernel.org/show_bug.cgi?id=42606 */
{
. callback = set_nouse_crs ,
. ident = " Supermicro X8DTH " ,
. matches = {
DMI_MATCH ( DMI_SYS_VENDOR , " Supermicro " ) ,
DMI_MATCH ( DMI_PRODUCT_NAME , " X8DTH-i/6/iF/6F " ) ,
DMI_MATCH ( DMI_BIOS_VERSION , " 2.0a " ) ,
} ,
} ,
2012-10-29 17:26:54 -06:00
/* https://bugzilla.kernel.org/show_bug.cgi?id=15362 */
{
. callback = set_ignore_seg ,
. ident = " HP xw9300 " ,
. matches = {
DMI_MATCH ( DMI_SYS_VENDOR , " Hewlett-Packard " ) ,
DMI_MATCH ( DMI_PRODUCT_NAME , " HP xw9300 Workstation " ) ,
} ,
} ,
2022-05-19 17:21:49 +02:00
/*
* Many Lenovo models with " IIL " in their DMI_PRODUCT_VERSION have
* an E820 reserved region that covers the entire 32 - bit host
* bridge memory window from _CRS . Using the E820 region to clip
* _CRS means no space is available for hot - added or uninitialized
* PCI devices . This typically breaks I2C controllers for touchpads
* and hot - added Thunderbolt devices . See the commit log for
* models known to require this quirk and related bug reports .
*/
{
. callback = set_no_e820 ,
. ident = " Lenovo *IIL* product version " ,
. matches = {
DMI_MATCH ( DMI_SYS_VENDOR , " LENOVO " ) ,
DMI_MATCH ( DMI_PRODUCT_VERSION , " IIL " ) ,
} ,
} ,
/*
* The Acer Spin 5 ( SP513 - 54 N ) has the same E820 reservation covering
* the entire _CRS 32 - bit window issue as the Lenovo * IIL * models .
* See https : //bugs.launchpad.net/bugs/1884232
*/
{
. callback = set_no_e820 ,
. ident = " Acer Spin 5 (SP513-54N) " ,
. matches = {
DMI_MATCH ( DMI_SYS_VENDOR , " Acer " ) ,
DMI_MATCH ( DMI_PRODUCT_NAME , " Spin SP513-54N " ) ,
} ,
} ,
/*
* Clevo X170KM - G barebones have the same E820 reservation covering
* the entire _CRS 32 - bit window issue as the Lenovo * IIL * models .
* See https : //bugzilla.kernel.org/show_bug.cgi?id=214259
*/
{
. callback = set_no_e820 ,
. ident = " Clevo X170KM-G Barebone " ,
. matches = {
DMI_MATCH ( DMI_BOARD_NAME , " X170KM-G " ) ,
} ,
} ,
2010-02-23 10:24:41 -07:00
{ }
} ;
void __init pci_acpi_crs_quirks ( void )
{
2018-03-20 20:08:00 +02:00
int year = dmi_get_bios_year ( ) ;
if ( year > = 0 & & year < 2008 & & iomem_resource . end < = 0xffffffff )
2018-02-22 14:59:21 +02:00
pci_use_crs = false ;
2010-02-23 10:24:41 -07:00
x86/PCI: Disable E820 reserved region clipping starting in 2023
Some firmware includes unusable space (host bridge registers, hidden PCI
device BARs, etc) in PCI host bridge _CRS. As far as we know, there's
nothing in the ACPI, UEFI, or PCI Firmware spec that requires the OS to
remove E820 reserved regions from _CRS, so this seems like a firmware
defect.
As a workaround, 4dc2287c1805 ("x86: avoid E820 regions when allocating
address space") has clipped out the unusable space in the past. This is
required for machines like the following:
- Dell Precision T3500 (the original motivator for 4dc2287c1805); see
https://bugzilla.kernel.org/show_bug.cgi?id=16228
- Asus C523NA (Coral) Chromebook; see
https://lore.kernel.org/all/4e9fca2f-0af1-3684-6c97-4c35befd5019@redhat.com/
- Lenovo ThinkPad X1 Gen 2; see:
https://bugzilla.redhat.com/show_bug.cgi?id=2029207
But other firmware supplies E820 reserved regions that cover entire _CRS
windows, and clipping throws away the entire window, leaving none for
hot-added or uninitialized devices. This clipping breaks a whole range of
Lenovo IdeaPads, Yogas, Yoga Slims, and notebooks, as well as Acer Spin 5
and Clevo X170KM-G Barebone machines.
E820 reserved entries that cover a memory-mapped PCI host bridge, including
its registers and memory/IO windows, are probably *not* a firmware defect.
Per ACPI v5.4, sec 15.2, the E820 memory map may include:
Address ranges defined for baseboard memory-mapped I/O devices, such as
APICs, are returned as reserved.
Disable the E820 clipping by default for all post-2022 machines. We
already have quirks to disable clipping for pre-2023 machines, and we'll
likely need quirks to *enable* clipping for post-2022 machines that
incorrectly include unusable space in _CRS, including Chromebooks and
Lenovo ThinkPads.
Here's the rationale for doing this. If we do nothing, and continue
clipping by default:
- Future systems like the Lenovo IdeaPads, Yogas, etc, Acer Spin, and
Clevo Barebones will require new quirks to disable clipping.
- The problem here is E820 entries that cover entire _CRS windows that
should not be clipped out.
- I think these E820 entries are legal per spec, and it would be hard to
get BIOS vendors to change them.
- We will discover new systems that need clipping disabled piecemeal as
they are released.
- Future systems like Lenovo X1 Carbon and the Chromebooks (probably
anything using coreboot) will just work, even though their _CRS is
incorrect, so we will not notice new ones that rely on the clipping.
- BIOS updates will not require new quirks unless they change the DMI
model string.
If we add the date check in this commit that disables clipping, e.g., "no
clipping when date >= 2023":
- Future systems like Lenovo *IIL*, Acer Spin, and Clevo Barebones will
just work without new quirks.
- Future systems like Lenovo X1 Carbon and the Chromebooks will require
new quirks to *enable* clipping.
- The problem here is that _CRS contains regions that are not usable by
PCI devices, and we rely on the E820 kludge to clip them out.
- I think this use of E820 is clearly a firmware bug, so we have a
fighting chance of getting it changed eventually.
- BIOS updates after the cutoff date *will* require quirks, but only for
systems like Lenovo X1 Carbon and Chromebooks that we already think
have broken firmware.
It seems to me like it's better to add quirks for firmware that we think is
broken than for firmware that seems unusual but correct.
[bhelgaas: comment and commit log]
Link: https://lore.kernel.org/linux-pci/20220518220754.GA7911@bhelgaas/
Link: https://lore.kernel.org/r/20220519152150.6135-4-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Benoit Grégoire <benoitg@coeus.ca>
Cc: Hui Wang <hui.wang@canonical.com>
2022-05-19 17:21:50 +02:00
/*
* Some firmware includes unusable space ( host bridge registers ,
* hidden PCI device BARs , etc ) in PCI host bridge _CRS . This is a
* firmware defect , and 4 dc2287c1805 ( " x86: avoid E820 regions when
* allocating address space " ) has clipped out the unusable space in
* the past .
*
* But other firmware supplies E820 reserved regions that cover
* entire _CRS windows , so clipping throws away the entire window ,
* leaving none for hot - added or uninitialized devices . These E820
* entries are probably * not * a firmware defect , so disable the
* clipping by default for post - 2022 machines .
*
* We already have quirks to disable clipping for pre - 2023
* machines , and we ' ll likely need quirks to * enable * clipping for
* post - 2022 machines that incorrectly include unusable space in
* _CRS .
*/
if ( year > = 2023 )
pci_use_e820 = false ;
2012-10-29 17:26:54 -06:00
dmi_check_system ( pci_crs_quirks ) ;
2010-02-23 10:24:41 -07:00
/*
* If the user specifies " pci=use_crs " or " pci=nocrs " explicitly , that
* takes precedence over anything we figured out above .
*/
if ( pci_probe & PCI_ROOT_NO_CRS )
pci_use_crs = false ;
else if ( pci_probe & PCI_USE__CRS )
pci_use_crs = true ;
2022-12-09 14:41:27 -06:00
pr_info ( " %s host bridge windows from ACPI; if necessary, use \" pci=%s \" and report a bug \n " ,
pci_use_crs ? " Using " : " Ignoring " ,
pci_use_crs ? " nocrs " : " use_crs " ) ;
x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions
Some firmware supplies PCI host bridge _CRS that includes address space
unusable by PCI devices, e.g., space occupied by host bridge registers or
used by hidden PCI devices.
To avoid this unusable space, Linux currently excludes E820 reserved
regions from _CRS windows; see 4dc2287c1805 ("x86: avoid E820 regions when
allocating address space").
However, this use of E820 reserved regions to clip things out of _CRS is
not supported by ACPI, UEFI, or PCI Firmware specs, and some systems have
E820 reserved regions that cover the entire memory window from _CRS.
4dc2287c1805 clips the entire window, leaving no space for hot-added or
uninitialized PCI devices.
For example, from a Lenovo IdeaPad 3 15IIL 81WE:
BIOS-e820: [mem 0x4bc50000-0xcfffffff] reserved
pci_bus 0000:00: root bus resource [mem 0x65400000-0xbfffffff window]
pci 0000:00:15.0: BAR 0: [mem 0x00000000-0x00000fff 64bit]
pci 0000:00:15.0: BAR 0: no space for [mem size 0x00001000 64bit]
Future patches will add quirks to enable/disable E820 clipping
automatically.
Add a "pci=no_e820" kernel command line option to disable clipping with
E820 reserved regions. Also add a matching "pci=use_e820" option to enable
clipping with E820 reserved regions if that has been disabled by default by
further patches in this patch-set.
Both options taint the kernel because they are intended for debugging and
workaround purposes until a quirk can set them automatically.
[bhelgaas: commit log, add printk]
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868899 Lenovo IdeaPad 3
Link: https://lore.kernel.org/r/20220519152150.6135-2-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Benoit Grégoire <benoitg@coeus.ca>
Cc: Hui Wang <hui.wang@canonical.com>
2022-05-19 17:21:48 +02:00
/* "pci=use_e820"/"pci=no_e820" on the kernel cmdline takes precedence */
if ( pci_probe & PCI_NO_E820 )
pci_use_e820 = false ;
else if ( pci_probe & PCI_USE_E820 )
pci_use_e820 = true ;
2022-12-09 14:41:27 -06:00
pr_info ( " %s E820 reservations for host bridge windows \n " ,
pci_use_e820 ? " Using " : " Ignoring " ) ;
x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions
Some firmware supplies PCI host bridge _CRS that includes address space
unusable by PCI devices, e.g., space occupied by host bridge registers or
used by hidden PCI devices.
To avoid this unusable space, Linux currently excludes E820 reserved
regions from _CRS windows; see 4dc2287c1805 ("x86: avoid E820 regions when
allocating address space").
However, this use of E820 reserved regions to clip things out of _CRS is
not supported by ACPI, UEFI, or PCI Firmware specs, and some systems have
E820 reserved regions that cover the entire memory window from _CRS.
4dc2287c1805 clips the entire window, leaving no space for hot-added or
uninitialized PCI devices.
For example, from a Lenovo IdeaPad 3 15IIL 81WE:
BIOS-e820: [mem 0x4bc50000-0xcfffffff] reserved
pci_bus 0000:00: root bus resource [mem 0x65400000-0xbfffffff window]
pci 0000:00:15.0: BAR 0: [mem 0x00000000-0x00000fff 64bit]
pci 0000:00:15.0: BAR 0: no space for [mem size 0x00001000 64bit]
Future patches will add quirks to enable/disable E820 clipping
automatically.
Add a "pci=no_e820" kernel command line option to disable clipping with
E820 reserved regions. Also add a matching "pci=use_e820" option to enable
clipping with E820 reserved regions if that has been disabled by default by
further patches in this patch-set.
Both options taint the kernel because they are intended for debugging and
workaround purposes until a quirk can set them automatically.
[bhelgaas: commit log, add printk]
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1868899 Lenovo IdeaPad 3
Link: https://lore.kernel.org/r/20220519152150.6135-2-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Benoit Grégoire <benoitg@coeus.ca>
Cc: Hui Wang <hui.wang@canonical.com>
2022-05-19 17:21:48 +02:00
if ( pci_probe & ( PCI_NO_E820 | PCI_USE_E820 ) )
2022-12-09 14:41:27 -06:00
pr_info ( " Please notify linux-pci@vger.kernel.org so future kernels can do this automatically \n " ) ;
2010-02-23 10:24:41 -07:00
}
2012-06-22 14:55:17 +08:00
# ifdef CONFIG_PCI_MMCONFIG
2012-12-21 14:02:53 -08:00
static int check_segment ( u16 seg , struct device * dev , char * estr )
2012-06-22 14:55:17 +08:00
{
if ( seg ) {
2022-12-09 14:41:27 -06:00
dev_err ( dev , " %s can't access configuration space under this host bridge \n " ,
2012-06-22 14:55:17 +08:00
estr ) ;
return - EIO ;
}
/*
* Failure in adding MMCFG information is not fatal ,
* just can ' t access extended configuration space of
* devices under this host bridge .
*/
2022-12-09 14:41:27 -06:00
dev_warn ( dev , " %s can't access extended configuration space under this bridge \n " ,
2012-06-22 14:55:17 +08:00
estr ) ;
return 0 ;
}
2015-10-14 14:29:41 +08:00
static int setup_mcfg_map ( struct acpi_pci_root_info * ci )
2012-06-22 14:55:17 +08:00
{
2015-10-14 14:29:41 +08:00
int result , seg ;
struct pci_root_info * info ;
struct acpi_pci_root * root = ci - > root ;
struct device * dev = & ci - > bridge - > dev ;
2012-06-22 14:55:17 +08:00
2015-10-14 14:29:41 +08:00
info = container_of ( ci , struct pci_root_info , common ) ;
info - > start_bus = ( u8 ) root - > secondary . start ;
info - > end_bus = ( u8 ) root - > secondary . end ;
2012-06-22 14:55:17 +08:00
info - > mcfg_added = false ;
2015-10-14 14:29:41 +08:00
seg = info - > sd . domain ;
2012-06-22 14:55:17 +08:00
/* return success if MMCFG is not in use */
if ( raw_pci_ext_ops & & raw_pci_ext_ops ! = & pci_mmcfg )
return 0 ;
if ( ! ( pci_probe & PCI_PROBE_MMCONF ) )
return check_segment ( seg , dev , " MMCONFIG is disabled, " ) ;
2015-10-14 14:29:41 +08:00
result = pci_mmconfig_insert ( dev , seg , info - > start_bus , info - > end_bus ,
root - > mcfg_addr ) ;
2012-06-22 14:55:17 +08:00
if ( result = = 0 ) {
/* enable MMCFG if it hasn't been enabled yet */
if ( raw_pci_ext_ops = = NULL )
raw_pci_ext_ops = & pci_mmcfg ;
info - > mcfg_added = true ;
} else if ( result ! = - EEXIST )
return check_segment ( seg , dev ,
" fail to add MMCONFIG information, " ) ;
return 0 ;
}
2015-10-14 14:29:41 +08:00
static void teardown_mcfg_map ( struct acpi_pci_root_info * ci )
2012-06-22 14:55:17 +08:00
{
2015-10-14 14:29:41 +08:00
struct pci_root_info * info ;
info = container_of ( ci , struct pci_root_info , common ) ;
2012-06-22 14:55:17 +08:00
if ( info - > mcfg_added ) {
2015-10-14 14:29:41 +08:00
pci_mmconfig_delete ( info - > sd . domain ,
info - > start_bus , info - > end_bus ) ;
2012-06-22 14:55:17 +08:00
info - > mcfg_added = false ;
}
}
# else
2015-10-14 14:29:41 +08:00
static int setup_mcfg_map ( struct acpi_pci_root_info * ci )
2012-06-22 14:55:17 +08:00
{
return 0 ;
}
2015-10-14 14:29:41 +08:00
static void teardown_mcfg_map ( struct acpi_pci_root_info * ci )
2012-06-22 14:55:17 +08:00
{
}
# endif
2015-10-14 14:29:41 +08:00
static int pci_acpi_root_get_node ( struct acpi_pci_root * root )
2007-10-03 15:56:51 -07:00
{
2015-10-14 14:29:41 +08:00
int busnum = root - > secondary . start ;
struct acpi_device * device = root - > device ;
int node = acpi_get_node ( device - > handle ) ;
2015-02-05 13:44:46 +08:00
2015-10-14 14:29:41 +08:00
if ( node = = NUMA_NO_NODE ) {
node = x86_pci_root_bus_node ( busnum ) ;
if ( node ! = 0 & & node ! = NUMA_NO_NODE )
dev_info ( & device - > dev , FW_BUG " no _PXM; falling back to node %d from hardware (may be inconsistent with ACPI node numbers) \n " ,
node ) ;
2010-09-22 11:09:19 -06:00
}
2015-10-14 14:29:41 +08:00
if ( node ! = NUMA_NO_NODE & & ! node_online ( node ) )
node = NUMA_NO_NODE ;
return node ;
2010-09-22 11:09:19 -06:00
}
2015-10-14 14:29:41 +08:00
static int pci_acpi_root_init_info ( struct acpi_pci_root_info * ci )
2010-09-22 11:09:19 -06:00
{
2015-10-14 14:29:41 +08:00
return setup_mcfg_map ( ci ) ;
2012-04-02 18:31:53 -07:00
}
2015-10-14 14:29:41 +08:00
static void pci_acpi_root_release_info ( struct acpi_pci_root_info * ci )
2012-04-02 18:31:53 -07:00
{
2015-10-14 14:29:41 +08:00
teardown_mcfg_map ( ci ) ;
kfree ( container_of ( ci , struct pci_root_info , common ) ) ;
2012-04-02 18:31:53 -07:00
}
2012-06-22 14:55:17 +08:00
2015-04-30 12:41:28 +08:00
/*
* An IO port or MMIO resource assigned to a PCI host bridge may be
* consumed by the host bridge itself or available to its child
* bus / devices . The ACPI specification defines a bit ( Producer / Consumer )
* to tell whether the resource is consumed by the host bridge itself ,
* but firmware hasn ' t used that bit consistently , so we can ' t rely on it .
*
* On x86 and IA64 platforms , all IO port and MMIO resources are assumed
* to be available to child bus / devices except one special case :
* IO port [ 0xCF8 - 0xCFF ] is consumed by the host bridge itself
* to access PCI configuration space .
*
* So explicitly filter out PCI CFG IO ports [ 0xCF8 - 0xCFF ] .
*/
static bool resource_is_pcicfg_ioport ( struct resource * res )
{
return ( res - > flags & IORESOURCE_IO ) & &
res - > start = = 0xCF8 & & res - > end = = 0xCFF ;
}
2015-10-14 14:29:41 +08:00
static int pci_acpi_root_prepare_resources ( struct acpi_pci_root_info * ci )
2007-10-03 15:56:51 -07:00
{
2015-10-14 14:29:41 +08:00
struct acpi_device * device = ci - > bridge ;
int busnum = ci - > root - > secondary . start ;
2015-03-04 16:47:11 +08:00
struct resource_entry * entry , * tmp ;
2015-10-14 14:29:41 +08:00
int status ;
2007-10-03 15:56:51 -07:00
2015-10-14 14:29:41 +08:00
status = acpi_pci_probe_root_resources ( ci ) ;
2022-03-03 16:00:39 -06:00
2015-10-14 14:29:41 +08:00
if ( pci_use_crs ) {
resource_list_for_each_entry_safe ( entry , tmp , & ci - > resources )
if ( resource_is_pcicfg_ioport ( entry - > res ) )
2015-03-04 16:47:11 +08:00
resource_list_destroy_entry ( entry ) ;
2015-10-14 14:29:41 +08:00
return status ;
}
resource_list_for_each_entry_safe ( entry , tmp , & ci - > resources ) {
dev_printk ( KERN_DEBUG , & device - > dev ,
" host bridge window %pR (ignored) \n " , entry - > res ) ;
resource_list_destroy_entry ( entry ) ;
}
x86_pci_root_bus_resources ( busnum , & ci - > resources ) ;
return 0 ;
2007-10-03 15:56:51 -07:00
}
2015-10-14 14:29:41 +08:00
static struct acpi_pci_root_ops acpi_pci_root_ops = {
. pci_ops = & pci_root_ops ,
. init_info = pci_acpi_root_init_info ,
. release_info = pci_acpi_root_release_info ,
. prepare_resources = pci_acpi_root_prepare_resources ,
} ;
2012-12-21 14:02:53 -08:00
struct pci_bus * pci_acpi_scan_root ( struct acpi_pci_root * root )
2005-04-16 15:20:36 -07:00
{
2010-03-11 12:20:11 -07:00
int domain = root - > segment ;
int busnum = root - > secondary . start ;
2015-10-14 14:29:41 +08:00
int node = pci_acpi_root_get_node ( root ) ;
2014-01-24 10:41:11 -07:00
struct pci_bus * bus ;
2007-07-22 00:23:39 +03:00
2012-10-29 17:26:54 -06:00
if ( pci_ignore_seg )
2015-10-14 14:29:40 +08:00
root - > segment = domain = 0 ;
2012-10-29 17:26:54 -06:00
2007-10-11 16:58:30 -04:00
if ( domain & & ! pci_domains_supported ) {
2022-12-09 14:41:27 -06:00
pr_warn ( " pci_bus %04x:%02x: ignored (multiple domains not supported) \n " ,
domain , busnum ) ;
2007-10-11 16:58:30 -04:00
return NULL ;
}
2008-04-15 14:34:49 -07:00
bus = pci_find_bus ( domain , busnum ) ;
if ( bus ) {
/*
2014-01-24 10:38:40 -07:00
* If the desired bus has been scanned already , replace
* its bus - > sysdata .
2008-04-15 14:34:49 -07:00
*/
2015-10-14 14:29:41 +08:00
struct pci_sysdata sd = {
. domain = domain ,
. node = node ,
. companion = root - > device
} ;
2015-02-05 13:44:46 +08:00
2015-10-14 14:29:41 +08:00
memcpy ( bus - > sysdata , & sd , sizeof ( sd ) ) ;
} else {
struct pci_root_info * info ;
2018-08-28 16:05:13 +01:00
info = kzalloc ( sizeof ( * info ) , GFP_KERNEL ) ;
2015-10-14 14:29:41 +08:00
if ( ! info )
dev_err ( & root - > device - > dev ,
" pci_bus %04x:%02x: ignored (out of memory) \n " ,
domain , busnum ) ;
else {
info - > sd . domain = domain ;
info - > sd . node = node ;
info - > sd . companion = root - > device ;
bus = acpi_pci_root_create ( root , & acpi_pci_root_ops ,
& info - > common , & info - > sd ) ;
2012-04-02 18:31:53 -07:00
}
2009-06-24 20:00:12 -07:00
}
2007-07-22 00:23:39 +03:00
PCI: Set PCI-E Max Payload Size on fabric
On a given PCI-E fabric, each device, bridge, and root port can have a
different PCI-E maximum payload size. There is a sizable performance
boost for having the largest possible maximum payload size on each PCI-E
device. However, if improperly configured, fatal bus errors can occur.
Thus, it is important to ensure that PCI-E payloads sends by a device
are never larger than the MPS setting of all devices on the way to the
destination.
This can be achieved two ways:
- A conservative approach is to use the smallest common denominator of
the entire tree below a root complex for every device on that fabric.
This means for example that having a 128 bytes MPS USB controller on one
leg of a switch will dramatically reduce performances of a video card or
10GE adapter on another leg of that same switch.
It also means that any hierarchy supporting hotplug slots (including
expresscard or thunderbolt I suppose, dbl check that) will have to be
entirely clamped to 128 bytes since we cannot predict what will be
plugged into those slots, and we cannot change the MPS on a "live"
system.
- A more optimal way is possible, if it falls within a couple of
constraints:
* The top-level host bridge will never generate packets larger than the
smallest TLP (or if it can be controlled independently from its MPS at
least)
* The device will never generate packets larger than MPS (which can be
configured via MRRS)
* No support of direct PCI-E <-> PCI-E transfers between devices without
some additional code to specifically deal with that case
Then we can use an approach that basically ignores downstream requests
and focuses exclusively on upstream requests. In that case, all we need
to care about is that a device MPS is no larger than its parent MPS,
which allows us to keep all switches/bridges to the max MPS supported by
their parent and eventually the PHB.
In this case, your USB controller would no longer "starve" your 10GE
Ethernet and your hotplug slots won't affect your global MPS.
Additionally, the hotplugged devices themselves can be configured to a
larger MPS up to the value configured in the hotplug bridge.
To choose between the two available options, two PCI kernel boot args
have been added to the PCI calls. "pcie_bus_safe" will provide the
former behavior, while "pcie_bus_perf" will perform the latter behavior.
By default, the latter behavior is used.
NOTE: due to the location of the enablement, each arch will need to add
calls to this function. This patch only enables x86.
This patch includes a number of changes recommended by Benjamin
Herrenschmidt.
Tested-by: Jordan_Hargrave@dell.com
Signed-off-by: Jon Mason <mason@myri.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
2011-07-20 15:20:54 -05:00
/* After the PCI-E bus has been walked and all devices discovered,
* configure any settings of the fabric that might be necessary .
*/
if ( bus ) {
struct pci_bus * child ;
2013-08-22 11:24:44 +08:00
list_for_each_entry ( child , & bus - > children , node )
pcie_bus_configure_settings ( child ) ;
PCI: Set PCI-E Max Payload Size on fabric
On a given PCI-E fabric, each device, bridge, and root port can have a
different PCI-E maximum payload size. There is a sizable performance
boost for having the largest possible maximum payload size on each PCI-E
device. However, if improperly configured, fatal bus errors can occur.
Thus, it is important to ensure that PCI-E payloads sends by a device
are never larger than the MPS setting of all devices on the way to the
destination.
This can be achieved two ways:
- A conservative approach is to use the smallest common denominator of
the entire tree below a root complex for every device on that fabric.
This means for example that having a 128 bytes MPS USB controller on one
leg of a switch will dramatically reduce performances of a video card or
10GE adapter on another leg of that same switch.
It also means that any hierarchy supporting hotplug slots (including
expresscard or thunderbolt I suppose, dbl check that) will have to be
entirely clamped to 128 bytes since we cannot predict what will be
plugged into those slots, and we cannot change the MPS on a "live"
system.
- A more optimal way is possible, if it falls within a couple of
constraints:
* The top-level host bridge will never generate packets larger than the
smallest TLP (or if it can be controlled independently from its MPS at
least)
* The device will never generate packets larger than MPS (which can be
configured via MRRS)
* No support of direct PCI-E <-> PCI-E transfers between devices without
some additional code to specifically deal with that case
Then we can use an approach that basically ignores downstream requests
and focuses exclusively on upstream requests. In that case, all we need
to care about is that a device MPS is no larger than its parent MPS,
which allows us to keep all switches/bridges to the max MPS supported by
their parent and eventually the PHB.
In this case, your USB controller would no longer "starve" your 10GE
Ethernet and your hotplug slots won't affect your global MPS.
Additionally, the hotplugged devices themselves can be configured to a
larger MPS up to the value configured in the hotplug bridge.
To choose between the two available options, two PCI kernel boot args
have been added to the PCI calls. "pcie_bus_safe" will provide the
former behavior, while "pcie_bus_perf" will perform the latter behavior.
By default, the latter behavior is used.
NOTE: due to the location of the enablement, each arch will need to add
calls to this function. This patch only enables x86.
This patch includes a number of changes recommended by Benjamin
Herrenschmidt.
Tested-by: Jordan_Hargrave@dell.com
Signed-off-by: Jon Mason <mason@myri.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
2011-07-20 15:20:54 -05:00
}
2005-09-12 18:49:24 +02:00
return bus ;
2005-04-16 15:20:36 -07:00
}
ACPI / PCI: Set root bridge ACPI handle in advance
The ACPI handles of PCI root bridges need to be known to
acpi_bind_one(), so that it can create the appropriate
"firmware_node" and "physical_node" files for them, but currently
the way it gets to know those handles is not exactly straightforward
(to put it lightly).
This is how it works, roughly:
1. acpi_bus_scan() finds the handle of a PCI root bridge,
creates a struct acpi_device object for it and passes that
object to acpi_pci_root_add().
2. acpi_pci_root_add() creates a struct acpi_pci_root object,
populates its "device" field with its argument's address
(device->handle is the ACPI handle found in step 1).
3. The struct acpi_pci_root object created in step 2 is passed
to pci_acpi_scan_root() and used to get resources that are
passed to pci_create_root_bus().
4. pci_create_root_bus() creates a struct pci_host_bridge object
and passes its "dev" member to device_register().
5. platform_notify(), which for systems with ACPI is set to
acpi_platform_notify(), is called.
So far, so good. Now it starts to be "interesting".
6. acpi_find_bridge_device() is used to find the ACPI handle of
the given device (which is the PCI root bridge) and executes
acpi_pci_find_root_bridge(), among other things, for the
given device object.
7. acpi_pci_find_root_bridge() uses the name (sic!) of the given
device object to extract the segment and bus numbers of the PCI
root bridge and passes them to acpi_get_pci_rootbridge_handle().
8. acpi_get_pci_rootbridge_handle() browses the list of ACPI PCI
root bridges and finds the one that matches the given segment
and bus numbers. Its handle is then used to initialize the
ACPI handle of the PCI root bridge's device object by
acpi_bind_one(). However, this is *exactly* the ACPI handle we
started with in step 1.
Needless to say, this is quite embarassing, but it may be avoided
thanks to commit f3fd0c8 (ACPI: Allow ACPI handles of devices to be
initialized in advance), which makes it possible to initialize the
ACPI handle of a device before passing it to device_register().
Accordingly, add a new __weak routine, pcibios_root_bridge_prepare(),
defaulting to an empty implementation that can be replaced by the
interested architecutres (x86 and ia64 at the moment) with functions
that will set the root bridge's ACPI handle before its dev member is
passed to device_register(). Make both x86 and ia64 provide such
implementations of pcibios_root_bridge_prepare() and remove
acpi_pci_find_root_bridge() and acpi_get_pci_rootbridge_handle() that
aren't necessary any more.
Included is a fix for breakage on systems with non-ACPI PCI host
bridges from Bjorn Helgaas.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
2013-01-09 22:33:37 +01:00
int pcibios_root_bridge_prepare ( struct pci_host_bridge * bridge )
{
2015-05-28 01:39:53 +02:00
/*
* We pass NULL as parent to pci_create_root_bus ( ) , so if it is not NULL
* here , pci_create_root_bus ( ) has been called by someone else and
* sysdata is likely to be different from what we expect . Let it go in
* that case .
*/
if ( ! bridge - > dev . parent ) {
struct pci_sysdata * sd = bridge - > bus - > sysdata ;
ACPI_COMPANION_SET ( & bridge - > dev , sd - > companion ) ;
}
ACPI / PCI: Set root bridge ACPI handle in advance
The ACPI handles of PCI root bridges need to be known to
acpi_bind_one(), so that it can create the appropriate
"firmware_node" and "physical_node" files for them, but currently
the way it gets to know those handles is not exactly straightforward
(to put it lightly).
This is how it works, roughly:
1. acpi_bus_scan() finds the handle of a PCI root bridge,
creates a struct acpi_device object for it and passes that
object to acpi_pci_root_add().
2. acpi_pci_root_add() creates a struct acpi_pci_root object,
populates its "device" field with its argument's address
(device->handle is the ACPI handle found in step 1).
3. The struct acpi_pci_root object created in step 2 is passed
to pci_acpi_scan_root() and used to get resources that are
passed to pci_create_root_bus().
4. pci_create_root_bus() creates a struct pci_host_bridge object
and passes its "dev" member to device_register().
5. platform_notify(), which for systems with ACPI is set to
acpi_platform_notify(), is called.
So far, so good. Now it starts to be "interesting".
6. acpi_find_bridge_device() is used to find the ACPI handle of
the given device (which is the PCI root bridge) and executes
acpi_pci_find_root_bridge(), among other things, for the
given device object.
7. acpi_pci_find_root_bridge() uses the name (sic!) of the given
device object to extract the segment and bus numbers of the PCI
root bridge and passes them to acpi_get_pci_rootbridge_handle().
8. acpi_get_pci_rootbridge_handle() browses the list of ACPI PCI
root bridges and finds the one that matches the given segment
and bus numbers. Its handle is then used to initialize the
ACPI handle of the PCI root bridge's device object by
acpi_bind_one(). However, this is *exactly* the ACPI handle we
started with in step 1.
Needless to say, this is quite embarassing, but it may be avoided
thanks to commit f3fd0c8 (ACPI: Allow ACPI handles of devices to be
initialized in advance), which makes it possible to initialize the
ACPI handle of a device before passing it to device_register().
Accordingly, add a new __weak routine, pcibios_root_bridge_prepare(),
defaulting to an empty implementation that can be replaced by the
interested architecutres (x86 and ia64 at the moment) with functions
that will set the root bridge's ACPI handle before its dev member is
passed to device_register(). Make both x86 and ia64 provide such
implementations of pcibios_root_bridge_prepare() and remove
acpi_pci_find_root_bridge() and acpi_get_pci_rootbridge_handle() that
aren't necessary any more.
Included is a fix for breakage on systems with non-ACPI PCI host
bridges from Bjorn Helgaas.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
2013-01-09 22:33:37 +01:00
return 0 ;
}
2008-07-02 22:50:29 +02:00
int __init pci_acpi_init ( void )
2005-04-16 15:20:36 -07:00
{
struct pci_dev * dev = NULL ;
if ( acpi_noirq )
2009-08-29 16:24:51 +02:00
return - ENODEV ;
2005-04-16 15:20:36 -07:00
2022-12-09 14:41:27 -06:00
pr_info ( " Using ACPI for IRQ routing \n " ) ;
2005-04-16 15:20:36 -07:00
acpi_irq_penalty_init ( ) ;
pcibios_enable_irq = acpi_pci_irq_enable ;
2005-07-27 23:02:00 -04:00
pcibios_disable_irq = acpi_pci_irq_disable ;
2009-08-29 17:47:33 +02:00
x86_init . pci . init_irq = x86_init_noop ;
2005-04-16 15:20:36 -07:00
if ( pci_routeirq ) {
/*
* PCI IRQ routing is set up by pci_enable_device ( ) , but we
* also do it here in case there are still broken drivers that
* don ' t use pci_enable_device ( ) .
*/
2022-12-09 14:41:27 -06:00
pr_info ( " Routing PCI interrupts for all devices because \" pci=routeirq \" specified \n " ) ;
2005-11-06 23:39:36 -08:00
for_each_pci_dev ( dev )
2005-04-16 15:20:36 -07:00
acpi_pci_irq_enable ( dev ) ;
2008-02-18 09:44:13 -07:00
}
2005-04-16 15:20:36 -07:00
return 0 ;
}