2018-06-06 05:42:14 +03:00
// SPDX-License-Identifier: GPL-2.0
2005-04-17 02:20:36 +04:00
/*
2006-06-09 08:48:12 +04:00
* Copyright ( c ) 2000 - 2006 Silicon Graphics , Inc .
2005-11-02 06:58:39 +03:00
* All Rights Reserved .
2005-04-17 02:20:36 +04:00
*/
2017-12-11 14:35:19 +03:00
# include <linux/iversion.h>
2007-11-23 08:30:51 +03:00
2005-04-17 02:20:36 +04:00
# include "xfs.h"
2005-11-02 06:38:42 +03:00
# include "xfs_fs.h"
2013-10-23 03:36:05 +04:00
# include "xfs_shared.h"
2013-10-23 03:50:10 +04:00
# include "xfs_format.h"
# include "xfs_log_format.h"
# include "xfs_trans_resv.h"
2005-04-17 02:20:36 +04:00
# include "xfs_sb.h"
# include "xfs_mount.h"
2016-08-03 04:15:38 +03:00
# include "xfs_defer.h"
2013-10-23 03:51:50 +04:00
# include "xfs_inode.h"
2013-08-12 14:49:45 +04:00
# include "xfs_dir2.h"
# include "xfs_attr.h"
2013-10-23 03:50:10 +04:00
# include "xfs_trans_space.h"
# include "xfs_trans.h"
2005-04-17 02:20:36 +04:00
# include "xfs_buf_item.h"
2005-11-02 06:38:42 +03:00
# include "xfs_inode_item.h"
# include "xfs_ialloc.h"
# include "xfs_bmap.h"
2013-08-12 14:49:42 +04:00
# include "xfs_bmap_util.h"
2017-10-31 22:04:49 +03:00
# include "xfs_errortag.h"
2005-04-17 02:20:36 +04:00
# include "xfs_error.h"
# include "xfs_quota.h"
2007-07-11 05:09:12 +04:00
# include "xfs_filestream.h"
2009-12-15 02:14:59 +03:00
# include "xfs_trace.h"
2012-10-08 14:56:11 +04:00
# include "xfs_icache.h"
2013-08-12 14:49:45 +04:00
# include "xfs_symlink.h"
2013-10-23 03:50:10 +04:00
# include "xfs_trans_priv.h"
# include "xfs_log.h"
2013-10-23 03:51:50 +04:00
# include "xfs_bmap_btree.h"
2016-10-03 19:11:38 +03:00
# include "xfs_reflink.h"
2005-04-17 02:20:36 +04:00
kmem_zone_t * xfs_inode_zone ;
/*
2011-07-08 16:34:34 +04:00
* Used in xfs_itruncate_extents ( ) . This is the maximum number of extents
2005-04-17 02:20:36 +04:00
* freed from a file in a single transaction .
*/
# define XFS_ITRUNC_MAX_EXTENTS 2
2016-02-09 08:54:58 +03:00
STATIC int xfs_iflush_int ( struct xfs_inode * , struct xfs_buf * ) ;
STATIC int xfs_iunlink ( struct xfs_trans * , struct xfs_inode * ) ;
STATIC int xfs_iunlink_remove ( struct xfs_trans * , struct xfs_inode * ) ;
2013-12-18 04:22:41 +04:00
2012-04-23 09:59:02 +04:00
/*
* helper function to extract extent size hint from inode
*/
xfs_extlen_t
xfs_get_extsz_hint (
struct xfs_inode * ip )
{
2019-10-14 20:07:21 +03:00
/*
* No point in aligning allocations if we need to COW to actually
* write to them .
*/
if ( xfs_is_always_cow_inode ( ip ) )
return 0 ;
2012-04-23 09:59:02 +04:00
if ( ( ip - > i_d . di_flags & XFS_DIFLAG_EXTSIZE ) & & ip - > i_d . di_extsize )
return ip - > i_d . di_extsize ;
if ( XFS_IS_REALTIME_INODE ( ip ) )
return ip - > i_mount - > m_sb . sb_rextsize ;
return 0 ;
}
2016-10-03 19:11:43 +03:00
/*
* Helper function to extract CoW extent size hint from inode .
* Between the extent size hint and the CoW extent size hint , we
2016-10-03 19:11:49 +03:00
* return the greater of the two . If the value is zero ( automatic ) ,
* use the default size .
2016-10-03 19:11:43 +03:00
*/
xfs_extlen_t
xfs_get_cowextsz_hint (
struct xfs_inode * ip )
{
xfs_extlen_t a , b ;
a = 0 ;
if ( ip - > i_d . di_flags2 & XFS_DIFLAG2_COWEXTSIZE )
a = ip - > i_d . di_cowextsize ;
b = xfs_get_extsz_hint ( ip ) ;
2016-10-03 19:11:49 +03:00
a = max ( a , b ) ;
if ( a = = 0 )
return XFS_DEFAULT_COWEXTSZ_HINT ;
return a ;
2016-10-03 19:11:43 +03:00
}
2012-10-08 14:56:10 +04:00
/*
2013-12-18 14:14:39 +04:00
* These two are wrapper routines around the xfs_ilock ( ) routine used to
* centralize some grungy code . They are used in places that wish to lock the
* inode solely for reading the extents . The reason these places can ' t just
* call xfs_ilock ( ip , XFS_ILOCK_SHARED ) is that the inode lock also guards to
* bringing in of the extents from disk for a file in b - tree format . If the
* inode is in b - tree format , then we need to lock the inode exclusively until
* the extents are read in . Locking it exclusively all the time would limit
* our parallelism unnecessarily , though . What we do instead is check to see
* if the extents have been read in yet , and only lock the inode exclusively
* if they have not .
2012-10-08 14:56:10 +04:00
*
2013-12-18 14:14:39 +04:00
* The functions return a value which should be given to the corresponding
2013-12-07 00:30:08 +04:00
* xfs_iunlock ( ) call .
2012-10-08 14:56:10 +04:00
*/
uint
2013-12-07 00:30:09 +04:00
xfs_ilock_data_map_shared (
struct xfs_inode * ip )
2012-10-08 14:56:10 +04:00
{
2013-12-07 00:30:09 +04:00
uint lock_mode = XFS_ILOCK_SHARED ;
2012-10-08 14:56:10 +04:00
2013-12-07 00:30:09 +04:00
if ( ip - > i_d . di_format = = XFS_DINODE_FMT_BTREE & &
( ip - > i_df . if_flags & XFS_IFEXTENTS ) = = 0 )
2012-10-08 14:56:10 +04:00
lock_mode = XFS_ILOCK_EXCL ;
xfs_ilock ( ip , lock_mode ) ;
return lock_mode ;
}
2013-12-18 14:14:39 +04:00
uint
xfs_ilock_attr_map_shared (
struct xfs_inode * ip )
2012-10-08 14:56:10 +04:00
{
2013-12-18 14:14:39 +04:00
uint lock_mode = XFS_ILOCK_SHARED ;
if ( ip - > i_d . di_aformat = = XFS_DINODE_FMT_BTREE & &
( ip - > i_afp - > if_flags & XFS_IFEXTENTS ) = = 0 )
lock_mode = XFS_ILOCK_EXCL ;
xfs_ilock ( ip , lock_mode ) ;
return lock_mode ;
2012-10-08 14:56:10 +04:00
}
/*
2016-11-30 06:33:25 +03:00
* In addition to i_rwsem in the VFS inode , the xfs inode contains 2
* multi - reader locks : i_mmap_lock and the i_lock . This routine allows
* various combinations of the locks to be obtained .
2012-10-08 14:56:10 +04:00
*
2015-02-23 13:43:37 +03:00
* The 3 locks should always be ordered so that the IO lock is obtained first ,
* the mmap lock second and the ilock last in order to prevent deadlock .
2012-10-08 14:56:10 +04:00
*
2015-02-23 13:43:37 +03:00
* Basic locking order :
*
2016-11-30 06:33:25 +03:00
* i_rwsem - > i_mmap_lock - > page_lock - > i_ilock
2015-02-23 13:43:37 +03:00
*
* mmap_sem locking order :
*
2016-11-30 06:33:25 +03:00
* i_rwsem - > page lock - > mmap_sem
2015-02-23 13:43:37 +03:00
* mmap_sem - > i_mmap_lock - > page_lock
*
* The difference in mmap_sem locking order mean that we cannot hold the
* i_mmap_lock over syscall based read ( 2 ) / write ( 2 ) based IO . These IO paths can
* fault in pages during copy in / out ( for buffered IO ) or require the mmap_sem
* in get_user_pages ( ) to map the user pages into the kernel address space for
2016-11-30 06:33:25 +03:00
* direct IO . Similarly the i_rwsem cannot be taken inside a page fault because
2015-02-23 13:43:37 +03:00
* page faults already hold the mmap_sem .
*
* Hence to serialise fully against both syscall and mmap based IO , we need to
2016-11-30 06:33:25 +03:00
* take both the i_rwsem and the i_mmap_lock . These locks should * only * be both
2015-02-23 13:43:37 +03:00
* taken in places where we need to invalidate the page cache in a race
* free manner ( e . g . truncate , hole punch and other extent manipulation
* functions ) .
2012-10-08 14:56:10 +04:00
*/
void
xfs_ilock (
xfs_inode_t * ip ,
uint lock_flags )
{
trace_xfs_ilock ( ip , lock_flags , _RET_IP_ ) ;
/*
* You can ' t set both SHARED and EXCL for the same lock ,
* and only XFS_IOLOCK_SHARED , XFS_IOLOCK_EXCL , XFS_ILOCK_SHARED ,
* and XFS_ILOCK_EXCL are valid values to set in lock_flags .
*/
ASSERT ( ( lock_flags & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ! =
( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ;
2015-02-23 13:43:37 +03:00
ASSERT ( ( lock_flags & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ! =
( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ;
2012-10-08 14:56:10 +04:00
ASSERT ( ( lock_flags & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ! =
( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ;
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( ( lock_flags & ~ ( XFS_LOCK_MASK | XFS_LOCK_SUBCLASS_MASK ) ) = = 0 ) ;
2012-10-08 14:56:10 +04:00
2016-11-30 06:33:25 +03:00
if ( lock_flags & XFS_IOLOCK_EXCL ) {
down_write_nested ( & VFS_I ( ip ) - > i_rwsem ,
XFS_IOLOCK_DEP ( lock_flags ) ) ;
} else if ( lock_flags & XFS_IOLOCK_SHARED ) {
down_read_nested ( & VFS_I ( ip ) - > i_rwsem ,
XFS_IOLOCK_DEP ( lock_flags ) ) ;
}
2012-10-08 14:56:10 +04:00
2015-02-23 13:43:37 +03:00
if ( lock_flags & XFS_MMAPLOCK_EXCL )
mrupdate_nested ( & ip - > i_mmaplock , XFS_MMAPLOCK_DEP ( lock_flags ) ) ;
else if ( lock_flags & XFS_MMAPLOCK_SHARED )
mraccess_nested ( & ip - > i_mmaplock , XFS_MMAPLOCK_DEP ( lock_flags ) ) ;
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_ILOCK_EXCL )
mrupdate_nested ( & ip - > i_lock , XFS_ILOCK_DEP ( lock_flags ) ) ;
else if ( lock_flags & XFS_ILOCK_SHARED )
mraccess_nested ( & ip - > i_lock , XFS_ILOCK_DEP ( lock_flags ) ) ;
}
/*
* This is just like xfs_ilock ( ) , except that the caller
* is guaranteed not to sleep . It returns 1 if it gets
* the requested locks and 0 otherwise . If the IO lock is
* obtained but the inode lock cannot be , then the IO lock
* is dropped before returning .
*
* ip - - the inode being locked
* lock_flags - - this parameter indicates the inode ' s locks to be
* to be locked . See the comment for xfs_ilock ( ) for a list
* of valid values .
*/
int
xfs_ilock_nowait (
xfs_inode_t * ip ,
uint lock_flags )
{
trace_xfs_ilock_nowait ( ip , lock_flags , _RET_IP_ ) ;
/*
* You can ' t set both SHARED and EXCL for the same lock ,
* and only XFS_IOLOCK_SHARED , XFS_IOLOCK_EXCL , XFS_ILOCK_SHARED ,
* and XFS_ILOCK_EXCL are valid values to set in lock_flags .
*/
ASSERT ( ( lock_flags & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ! =
( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ;
2015-02-23 13:43:37 +03:00
ASSERT ( ( lock_flags & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ! =
( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ;
2012-10-08 14:56:10 +04:00
ASSERT ( ( lock_flags & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ! =
( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ;
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( ( lock_flags & ~ ( XFS_LOCK_MASK | XFS_LOCK_SUBCLASS_MASK ) ) = = 0 ) ;
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_IOLOCK_EXCL ) {
2016-11-30 06:33:25 +03:00
if ( ! down_write_trylock ( & VFS_I ( ip ) - > i_rwsem ) )
2012-10-08 14:56:10 +04:00
goto out ;
} else if ( lock_flags & XFS_IOLOCK_SHARED ) {
2016-11-30 06:33:25 +03:00
if ( ! down_read_trylock ( & VFS_I ( ip ) - > i_rwsem ) )
2012-10-08 14:56:10 +04:00
goto out ;
}
2015-02-23 13:43:37 +03:00
if ( lock_flags & XFS_MMAPLOCK_EXCL ) {
if ( ! mrtryupdate ( & ip - > i_mmaplock ) )
goto out_undo_iolock ;
} else if ( lock_flags & XFS_MMAPLOCK_SHARED ) {
if ( ! mrtryaccess ( & ip - > i_mmaplock ) )
goto out_undo_iolock ;
}
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_ILOCK_EXCL ) {
if ( ! mrtryupdate ( & ip - > i_lock ) )
2015-02-23 13:43:37 +03:00
goto out_undo_mmaplock ;
2012-10-08 14:56:10 +04:00
} else if ( lock_flags & XFS_ILOCK_SHARED ) {
if ( ! mrtryaccess ( & ip - > i_lock ) )
2015-02-23 13:43:37 +03:00
goto out_undo_mmaplock ;
2012-10-08 14:56:10 +04:00
}
return 1 ;
2015-02-23 13:43:37 +03:00
out_undo_mmaplock :
if ( lock_flags & XFS_MMAPLOCK_EXCL )
mrunlock_excl ( & ip - > i_mmaplock ) ;
else if ( lock_flags & XFS_MMAPLOCK_SHARED )
mrunlock_shared ( & ip - > i_mmaplock ) ;
out_undo_iolock :
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_IOLOCK_EXCL )
2016-11-30 06:33:25 +03:00
up_write ( & VFS_I ( ip ) - > i_rwsem ) ;
2012-10-08 14:56:10 +04:00
else if ( lock_flags & XFS_IOLOCK_SHARED )
2016-11-30 06:33:25 +03:00
up_read ( & VFS_I ( ip ) - > i_rwsem ) ;
2015-02-23 13:43:37 +03:00
out :
2012-10-08 14:56:10 +04:00
return 0 ;
}
/*
* xfs_iunlock ( ) is used to drop the inode locks acquired with
* xfs_ilock ( ) and xfs_ilock_nowait ( ) . The caller must pass
* in the flags given to xfs_ilock ( ) or xfs_ilock_nowait ( ) so
* that we know which locks to drop .
*
* ip - - the inode being unlocked
* lock_flags - - this parameter indicates the inode ' s locks to be
* to be unlocked . See the comment for xfs_ilock ( ) for a list
* of valid values for this parameter .
*
*/
void
xfs_iunlock (
xfs_inode_t * ip ,
uint lock_flags )
{
/*
* You can ' t set both SHARED and EXCL for the same lock ,
* and only XFS_IOLOCK_SHARED , XFS_IOLOCK_EXCL , XFS_ILOCK_SHARED ,
* and XFS_ILOCK_EXCL are valid values to set in lock_flags .
*/
ASSERT ( ( lock_flags & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ! =
( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ;
2015-02-23 13:43:37 +03:00
ASSERT ( ( lock_flags & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ! =
( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) ;
2012-10-08 14:56:10 +04:00
ASSERT ( ( lock_flags & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ! =
( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ;
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( ( lock_flags & ~ ( XFS_LOCK_MASK | XFS_LOCK_SUBCLASS_MASK ) ) = = 0 ) ;
2012-10-08 14:56:10 +04:00
ASSERT ( lock_flags ! = 0 ) ;
if ( lock_flags & XFS_IOLOCK_EXCL )
2016-11-30 06:33:25 +03:00
up_write ( & VFS_I ( ip ) - > i_rwsem ) ;
2012-10-08 14:56:10 +04:00
else if ( lock_flags & XFS_IOLOCK_SHARED )
2016-11-30 06:33:25 +03:00
up_read ( & VFS_I ( ip ) - > i_rwsem ) ;
2012-10-08 14:56:10 +04:00
2015-02-23 13:43:37 +03:00
if ( lock_flags & XFS_MMAPLOCK_EXCL )
mrunlock_excl ( & ip - > i_mmaplock ) ;
else if ( lock_flags & XFS_MMAPLOCK_SHARED )
mrunlock_shared ( & ip - > i_mmaplock ) ;
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_ILOCK_EXCL )
mrunlock_excl ( & ip - > i_lock ) ;
else if ( lock_flags & XFS_ILOCK_SHARED )
mrunlock_shared ( & ip - > i_lock ) ;
trace_xfs_iunlock ( ip , lock_flags , _RET_IP_ ) ;
}
/*
* give up write locks . the i / o lock cannot be held nested
* if it is being demoted .
*/
void
xfs_ilock_demote (
xfs_inode_t * ip ,
uint lock_flags )
{
2015-02-23 13:43:37 +03:00
ASSERT ( lock_flags & ( XFS_IOLOCK_EXCL | XFS_MMAPLOCK_EXCL | XFS_ILOCK_EXCL ) ) ;
ASSERT ( ( lock_flags &
~ ( XFS_IOLOCK_EXCL | XFS_MMAPLOCK_EXCL | XFS_ILOCK_EXCL ) ) = = 0 ) ;
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_ILOCK_EXCL )
mrdemote ( & ip - > i_lock ) ;
2015-02-23 13:43:37 +03:00
if ( lock_flags & XFS_MMAPLOCK_EXCL )
mrdemote ( & ip - > i_mmaplock ) ;
2012-10-08 14:56:10 +04:00
if ( lock_flags & XFS_IOLOCK_EXCL )
2016-11-30 06:33:25 +03:00
downgrade_write ( & VFS_I ( ip ) - > i_rwsem ) ;
2012-10-08 14:56:10 +04:00
trace_xfs_ilock_demote ( ip , lock_flags , _RET_IP_ ) ;
}
2013-04-30 15:39:34 +04:00
# if defined(DEBUG) || defined(XFS_WARN)
2012-10-08 14:56:10 +04:00
int
xfs_isilocked (
xfs_inode_t * ip ,
uint lock_flags )
{
if ( lock_flags & ( XFS_ILOCK_EXCL | XFS_ILOCK_SHARED ) ) {
if ( ! ( lock_flags & XFS_ILOCK_SHARED ) )
return ! ! ip - > i_lock . mr_writer ;
return rwsem_is_locked ( & ip - > i_lock . mr_lock ) ;
}
2015-02-23 13:43:37 +03:00
if ( lock_flags & ( XFS_MMAPLOCK_EXCL | XFS_MMAPLOCK_SHARED ) ) {
if ( ! ( lock_flags & XFS_MMAPLOCK_SHARED ) )
return ! ! ip - > i_mmaplock . mr_writer ;
return rwsem_is_locked ( & ip - > i_mmaplock . mr_lock ) ;
}
2012-10-08 14:56:10 +04:00
if ( lock_flags & ( XFS_IOLOCK_EXCL | XFS_IOLOCK_SHARED ) ) {
if ( ! ( lock_flags & XFS_IOLOCK_SHARED ) )
2016-11-30 06:33:25 +03:00
return ! debug_locks | |
lockdep_is_held_type ( & VFS_I ( ip ) - > i_rwsem , 0 ) ;
return rwsem_is_locked ( & VFS_I ( ip ) - > i_rwsem ) ;
2012-10-08 14:56:10 +04:00
}
ASSERT ( 0 ) ;
return 0 ;
}
# endif
2015-08-25 03:05:13 +03:00
/*
* xfs_lockdep_subclass_ok ( ) is only used in an ASSERT , so is only called when
* DEBUG or XFS_WARN is set . And MAX_LOCKDEP_SUBCLASSES is then only defined
* when CONFIG_LOCKDEP is set . Hence the complex define below to avoid build
* errors and warnings .
*/
# if (defined(DEBUG) || defined(XFS_WARN)) && defined(CONFIG_LOCKDEP)
2015-08-20 02:27:49 +03:00
static bool
xfs_lockdep_subclass_ok (
int subclass )
{
return subclass < MAX_LOCKDEP_SUBCLASSES ;
}
# else
# define xfs_lockdep_subclass_ok(subclass) (true)
# endif
2013-08-12 14:49:45 +04:00
/*
2015-02-23 13:43:37 +03:00
* Bump the subclass so xfs_lock_inodes ( ) acquires each lock with a different
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
* value . This can be called for any type of inode lock combination , including
* parent locking . Care must be taken to ensure we don ' t overrun the subclass
* storage fields in the class mask we build .
2013-08-12 14:49:45 +04:00
*/
static inline int
xfs_lock_inumorder ( int lock_mode , int subclass )
{
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
int class = 0 ;
ASSERT ( ! ( lock_mode & ( XFS_ILOCK_PARENT | XFS_ILOCK_RTBITMAP |
XFS_ILOCK_RTSUM ) ) ) ;
2015-08-20 02:27:49 +03:00
ASSERT ( xfs_lockdep_subclass_ok ( subclass ) ) ;
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
2015-02-23 13:43:37 +03:00
if ( lock_mode & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) {
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( subclass < = XFS_IOLOCK_MAX_SUBCLASS ) ;
class + = subclass < < XFS_IOLOCK_SHIFT ;
2015-02-23 13:43:37 +03:00
}
if ( lock_mode & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) {
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( subclass < = XFS_MMAPLOCK_MAX_SUBCLASS ) ;
class + = subclass < < XFS_MMAPLOCK_SHIFT ;
2015-02-23 13:43:37 +03:00
}
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
if ( lock_mode & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) {
ASSERT ( subclass < = XFS_ILOCK_MAX_SUBCLASS ) ;
class + = subclass < < XFS_ILOCK_SHIFT ;
}
2013-08-12 14:49:45 +04:00
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
return ( lock_mode & ~ XFS_LOCK_SUBCLASS_MASK ) | class ;
2013-08-12 14:49:45 +04:00
}
/*
2015-03-25 06:03:32 +03:00
* The following routine will lock n inodes in exclusive mode . We assume the
* caller calls us with the inodes in i_ino order .
2013-08-12 14:49:45 +04:00
*
2015-03-25 06:03:32 +03:00
* We need to detect deadlock where an inode that we lock is in the AIL and we
* start waiting for another inode that is locked by a thread in a long running
* transaction ( such as truncate ) . This can result in deadlock since the long
* running trans might need to wait for the inode we just locked in order to
* push the tail and free space in the log .
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
*
* xfs_lock_inodes ( ) can only be used to lock one type of lock at a time -
* the iolock , the mmaplock or the ilock , but not more than one at a time . If we
* lock more than one at a time , lockdep will report false positives saying we
* have violated locking orders .
2013-08-12 14:49:45 +04:00
*/
2016-06-01 10:38:15 +03:00
static void
2013-08-12 14:49:45 +04:00
xfs_lock_inodes (
2019-06-29 05:27:33 +03:00
struct xfs_inode * * ips ,
int inodes ,
uint lock_mode )
2013-08-12 14:49:45 +04:00
{
2019-06-29 05:27:33 +03:00
int attempts = 0 , i , j , try_lock ;
struct xfs_log_item * lp ;
2013-08-12 14:49:45 +04:00
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
/*
* Currently supports between 2 and 5 inodes with exclusive locking . We
* support an arbitrary depth of locking here , but absolute limits on
* inodes depend on the the type of locking and the limits placed by
* lockdep annotations in xfs_lock_inumorder . These are all checked by
* the asserts .
*/
2015-03-25 06:03:32 +03:00
ASSERT ( ips & & inodes > = 2 & & inodes < = 5 ) ;
xfs: clean up inode lockdep annotations
Lockdep annotations are a maintenance nightmare. Locking has to be
modified to suit the limitations of the annotations, and we're
always having to fix the annotations because they are unable to
express the complexity of locking heirarchies correctly.
So, next up, we've got more issues with lockdep annotations for
inode locking w.r.t. XFS_LOCK_PARENT:
- lockdep classes are exclusive and can't be ORed together
to form new classes.
- IOLOCK needs multiple PARENT subclasses to express the
changes needed for the readdir locking rework needed to
stop the endless flow of lockdep false positives involving
readdir calling filldir under the ILOCK.
- there are only 8 unique lockdep subclasses available,
so we can't create a generic solution.
IOWs we need to treat the 3-bit space available to each lock type
differently:
- IOLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 IOLOCK subclasses
- at least 2 IOLOCK_PARENT subclasses
- MMAPLOCK uses xfs_lock_two_inodes(), so needs:
- at least 2 MMAPLOCK subclasses
- ILOCK uses xfs_lock_inodes with up to 5 inodes, so needs:
- at least 5 ILOCK subclasses
- one ILOCK_PARENT subclass
- one RTBITMAP subclass
- one RTSUM subclass
For the IOLOCK, split the space into two sets of subclasses.
For the MMAPLOCK, just use half the space for the one subclass to
match the non-parent lock classes of the IOLOCK.
For the ILOCK, use 0-4 as the ILOCK subclasses, 5-7 for the
remaining individual subclasses.
Because they are now all different, modify xfs_lock_inumorder() to
handle the nested subclasses, and to assert fail if passed an
invalid subclass. Further, annotate xfs_lock_inodes() to assert fail
if an invalid combination of lock primitives and inode counts are
passed that would result in a lockdep subclass annotation overflow.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:32:49 +03:00
ASSERT ( lock_mode & ( XFS_IOLOCK_EXCL | XFS_MMAPLOCK_EXCL |
XFS_ILOCK_EXCL ) ) ;
ASSERT ( ! ( lock_mode & ( XFS_IOLOCK_SHARED | XFS_MMAPLOCK_SHARED |
XFS_ILOCK_SHARED ) ) ) ;
ASSERT ( ! ( lock_mode & XFS_MMAPLOCK_EXCL ) | |
inodes < = XFS_MMAPLOCK_MAX_SUBCLASS + 1 ) ;
ASSERT ( ! ( lock_mode & XFS_ILOCK_EXCL ) | |
inodes < = XFS_ILOCK_MAX_SUBCLASS + 1 ) ;
if ( lock_mode & XFS_IOLOCK_EXCL ) {
ASSERT ( ! ( lock_mode & ( XFS_MMAPLOCK_EXCL | XFS_ILOCK_EXCL ) ) ) ;
} else if ( lock_mode & XFS_MMAPLOCK_EXCL )
ASSERT ( ! ( lock_mode & XFS_ILOCK_EXCL ) ) ;
2013-08-12 14:49:45 +04:00
try_lock = 0 ;
i = 0 ;
again :
for ( ; i < inodes ; i + + ) {
ASSERT ( ips [ i ] ) ;
2015-03-25 06:03:32 +03:00
if ( i & & ( ips [ i ] = = ips [ i - 1 ] ) ) /* Already locked */
2013-08-12 14:49:45 +04:00
continue ;
/*
2015-03-25 06:03:32 +03:00
* If try_lock is not set yet , make sure all locked inodes are
* not in the AIL . If any are , set try_lock to be used later .
2013-08-12 14:49:45 +04:00
*/
if ( ! try_lock ) {
for ( j = ( i - 1 ) ; j > = 0 & & ! try_lock ; j - - ) {
2019-06-29 05:27:33 +03:00
lp = & ips [ j ] - > i_itemp - > ili_item ;
2018-05-09 17:47:34 +03:00
if ( lp & & test_bit ( XFS_LI_IN_AIL , & lp - > li_flags ) )
2013-08-12 14:49:45 +04:00
try_lock + + ;
}
}
/*
* If any of the previous locks we have locked is in the AIL ,
* we must TRY to get the second and subsequent locks . If
* we can ' t get any , we must release all we have
* and try again .
*/
2015-03-25 06:03:32 +03:00
if ( ! try_lock ) {
xfs_ilock ( ips [ i ] , xfs_lock_inumorder ( lock_mode , i ) ) ;
continue ;
}
/* try_lock means we have an inode locked that is in the AIL. */
ASSERT ( i ! = 0 ) ;
if ( xfs_ilock_nowait ( ips [ i ] , xfs_lock_inumorder ( lock_mode , i ) ) )
continue ;
2013-08-12 14:49:45 +04:00
2015-03-25 06:03:32 +03:00
/*
* Unlock all previous guys and try again . xfs_iunlock will try
* to push the tail if the inode is in the AIL .
*/
attempts + + ;
for ( j = i - 1 ; j > = 0 ; j - - ) {
2013-08-12 14:49:45 +04:00
/*
2015-03-25 06:03:32 +03:00
* Check to see if we ' ve already unlocked this one . Not
* the first one going back , and the inode ptr is the
* same .
2013-08-12 14:49:45 +04:00
*/
2015-03-25 06:03:32 +03:00
if ( j ! = ( i - 1 ) & & ips [ j ] = = ips [ j + 1 ] )
continue ;
2013-08-12 14:49:45 +04:00
2015-03-25 06:03:32 +03:00
xfs_iunlock ( ips [ j ] , lock_mode ) ;
}
2013-08-12 14:49:45 +04:00
2015-03-25 06:03:32 +03:00
if ( ( attempts % 5 ) = = 0 ) {
delay ( 1 ) ; /* Don't just spin the CPU */
2013-08-12 14:49:45 +04:00
}
2015-03-25 06:03:32 +03:00
i = 0 ;
try_lock = 0 ;
goto again ;
2013-08-12 14:49:45 +04:00
}
}
/*
2015-02-23 13:43:37 +03:00
* xfs_lock_two_inodes ( ) can only be used to lock one type of lock at a time -
2018-01-27 02:27:33 +03:00
* the mmaplock or the ilock , but not more than one type at a time . If we lock
* more than one at a time , lockdep will report false positives saying we have
* violated locking orders . The iolock must be double - locked separately since
* we use i_rwsem for that . We now support taking one lock EXCL and the other
* SHARED .
2013-08-12 14:49:45 +04:00
*/
void
xfs_lock_two_inodes (
2018-01-27 02:27:33 +03:00
struct xfs_inode * ip0 ,
uint ip0_mode ,
struct xfs_inode * ip1 ,
uint ip1_mode )
2013-08-12 14:49:45 +04:00
{
2018-01-27 02:27:33 +03:00
struct xfs_inode * temp ;
uint mode_temp ;
2013-08-12 14:49:45 +04:00
int attempts = 0 ;
2019-06-29 05:27:33 +03:00
struct xfs_log_item * lp ;
2013-08-12 14:49:45 +04:00
2018-01-27 02:27:33 +03:00
ASSERT ( hweight32 ( ip0_mode ) = = 1 ) ;
ASSERT ( hweight32 ( ip1_mode ) = = 1 ) ;
ASSERT ( ! ( ip0_mode & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ) ;
ASSERT ( ! ( ip1_mode & ( XFS_IOLOCK_SHARED | XFS_IOLOCK_EXCL ) ) ) ;
ASSERT ( ! ( ip0_mode & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) | |
! ( ip0_mode & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ) ;
ASSERT ( ! ( ip1_mode & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) | |
! ( ip1_mode & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ) ;
ASSERT ( ! ( ip1_mode & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) | |
! ( ip0_mode & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ) ;
ASSERT ( ! ( ip0_mode & ( XFS_MMAPLOCK_SHARED | XFS_MMAPLOCK_EXCL ) ) | |
! ( ip1_mode & ( XFS_ILOCK_SHARED | XFS_ILOCK_EXCL ) ) ) ;
2015-02-23 13:43:37 +03:00
2013-08-12 14:49:45 +04:00
ASSERT ( ip0 - > i_ino ! = ip1 - > i_ino ) ;
if ( ip0 - > i_ino > ip1 - > i_ino ) {
temp = ip0 ;
ip0 = ip1 ;
ip1 = temp ;
2018-01-27 02:27:33 +03:00
mode_temp = ip0_mode ;
ip0_mode = ip1_mode ;
ip1_mode = mode_temp ;
2013-08-12 14:49:45 +04:00
}
again :
2018-01-27 02:27:33 +03:00
xfs_ilock ( ip0 , xfs_lock_inumorder ( ip0_mode , 0 ) ) ;
2013-08-12 14:49:45 +04:00
/*
* If the first lock we have locked is in the AIL , we must TRY to get
* the second lock . If we can ' t get it , we must release the first one
* and try again .
*/
2019-06-29 05:27:33 +03:00
lp = & ip0 - > i_itemp - > ili_item ;
2018-05-09 17:47:34 +03:00
if ( lp & & test_bit ( XFS_LI_IN_AIL , & lp - > li_flags ) ) {
2018-01-27 02:27:33 +03:00
if ( ! xfs_ilock_nowait ( ip1 , xfs_lock_inumorder ( ip1_mode , 1 ) ) ) {
xfs_iunlock ( ip0 , ip0_mode ) ;
2013-08-12 14:49:45 +04:00
if ( ( + + attempts % 5 ) = = 0 )
delay ( 1 ) ; /* Don't just spin the CPU */
goto again ;
}
} else {
2018-01-27 02:27:33 +03:00
xfs_ilock ( ip1 , xfs_lock_inumorder ( ip1_mode , 1 ) ) ;
2013-08-12 14:49:45 +04:00
}
}
2012-10-08 14:56:10 +04:00
void
__xfs_iflock (
struct xfs_inode * ip )
{
wait_queue_head_t * wq = bit_waitqueue ( & ip - > i_flags , __XFS_IFLOCK_BIT ) ;
DEFINE_WAIT_BIT ( wait , & ip - > i_flags , __XFS_IFLOCK_BIT ) ;
do {
2017-03-05 13:25:39 +03:00
prepare_to_wait_exclusive ( wq , & wait . wq_entry , TASK_UNINTERRUPTIBLE ) ;
2012-10-08 14:56:10 +04:00
if ( xfs_isiflocked ( ip ) )
io_schedule ( ) ;
} while ( ! xfs_iflock_nowait ( ip ) ) ;
2017-03-05 13:25:39 +03:00
finish_wait ( wq , & wait . wq_entry ) ;
2012-10-08 14:56:10 +04:00
}
2005-04-17 02:20:36 +04:00
STATIC uint
_xfs_dic2xflags (
2017-06-16 21:00:05 +03:00
uint16_t di_flags ,
2016-01-04 08:44:15 +03:00
uint64_t di_flags2 ,
bool has_attr )
2005-04-17 02:20:36 +04:00
{
uint flags = 0 ;
if ( di_flags & XFS_DIFLAG_ANY ) {
if ( di_flags & XFS_DIFLAG_REALTIME )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_REALTIME ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_PREALLOC )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_PREALLOC ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_IMMUTABLE )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_IMMUTABLE ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_APPEND )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_APPEND ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_SYNC )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_SYNC ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_NOATIME )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_NOATIME ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_NODUMP )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_NODUMP ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_RTINHERIT )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_RTINHERIT ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_PROJINHERIT )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_PROJINHERIT ;
2005-04-17 02:20:36 +04:00
if ( di_flags & XFS_DIFLAG_NOSYMLINKS )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_NOSYMLINKS ;
2006-01-11 07:28:28 +03:00
if ( di_flags & XFS_DIFLAG_EXTSIZE )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_EXTSIZE ;
2006-01-11 07:28:28 +03:00
if ( di_flags & XFS_DIFLAG_EXTSZINHERIT )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_EXTSZINHERIT ;
2006-06-09 08:54:19 +04:00
if ( di_flags & XFS_DIFLAG_NODEFRAG )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_NODEFRAG ;
2007-07-11 05:09:12 +04:00
if ( di_flags & XFS_DIFLAG_FILESTREAM )
2016-01-04 08:44:15 +03:00
flags | = FS_XFLAG_FILESTREAM ;
2005-04-17 02:20:36 +04:00
}
2016-01-04 08:44:15 +03:00
if ( di_flags2 & XFS_DIFLAG2_ANY ) {
if ( di_flags2 & XFS_DIFLAG2_DAX )
flags | = FS_XFLAG_DAX ;
2016-10-03 19:11:43 +03:00
if ( di_flags2 & XFS_DIFLAG2_COWEXTSIZE )
flags | = FS_XFLAG_COWEXTSIZE ;
2016-01-04 08:44:15 +03:00
}
if ( has_attr )
flags | = FS_XFLAG_HASATTR ;
2005-04-17 02:20:36 +04:00
return flags ;
}
uint
xfs_ip2xflags (
2016-01-04 08:44:15 +03:00
struct xfs_inode * ip )
2005-04-17 02:20:36 +04:00
{
2016-01-04 08:44:15 +03:00
struct xfs_icdinode * dic = & ip - > i_d ;
2005-04-17 02:20:36 +04:00
2016-01-04 08:44:15 +03:00
return _xfs_dic2xflags ( dic - > di_flags , dic - > di_flags2 , XFS_IFORK_Q ( ip ) ) ;
2005-04-17 02:20:36 +04:00
}
2013-08-12 14:49:45 +04:00
/*
* Lookups up an inode from " name " . If ci_name is not NULL , then a CI match
* is allowed , otherwise it has to be an exact match . If a CI match is found ,
* ci_name - > name will point to a the actual name ( caller must free ) or
* will be set to NULL if an exact match is found .
*/
int
xfs_lookup (
xfs_inode_t * dp ,
struct xfs_name * name ,
xfs_inode_t * * ipp ,
struct xfs_name * ci_name )
{
xfs_ino_t inum ;
int error ;
trace_xfs_lookup ( dp , name ) ;
if ( XFS_FORCED_SHUTDOWN ( dp - > i_mount ) )
2014-06-25 08:58:08 +04:00
return - EIO ;
2013-08-12 14:49:45 +04:00
error = xfs_dir_lookup ( NULL , dp , name , & inum , ci_name ) ;
if ( error )
xfs: stop holding ILOCK over filldir callbacks
The recent change to the readdir locking made in 40194ec ("xfs:
reinstate the ilock in xfs_readdir") for CXFS directory sanity was
probably the wrong thing to do. Deep in the readdir code we
can take page faults in the filldir callback, and so taking a page
fault while holding an inode ilock creates a new set of locking
issues that lockdep warns all over the place about.
The locking order for regular inodes w.r.t. page faults is io_lock
-> pagefault -> mmap_sem -> ilock. The directory readdir code now
triggers ilock -> page fault -> mmap_sem. While we cannot deadlock
at this point, it inverts all the locking patterns that lockdep
normally sees on XFS inodes, and so triggers lockdep. We worked
around this with commit 93a8614 ("xfs: fix directory inode iolock
lockdep false positive"), but that then just moved the lockdep
warning to deeper in the page fault path and triggered on security
inode locks. Fixing the shmem issue there just moved the lockdep
reports somewhere else, and now we are getting false positives from
filesystem freezing annotations getting confused.
Further, if we enter memory reclaim in a readdir path, we now get
lockdep warning about potential deadlocks because the ilock is held
when we enter reclaim. This, again, is different to a regular file
in that we never allow memory reclaim to run while holding the ilock
for regular files. Hence lockdep now throws
ilock->kmalloc->reclaim->ilock warnings.
Basically, the problem is that the ilock is being used to protect
the directory data and the inode metadata, whereas for a regular
file the iolock protects the data and the ilock protects the
metadata. From the VFS perspective, the i_mutex serialises all
accesses to the directory data, and so not holding the ilock for
readdir doesn't matter. The issue is that CXFS doesn't access
directory data via the VFS, so it has no "data serialisaton"
mechanism. Hence we need to hold the IOLOCK in the correct places to
provide this low level directory data access serialisation.
The ilock can then be used just when the extent list needs to be
read, just like we do for regular files. The directory modification
code can take the iolock exclusive when the ilock is also taken,
and this then ensures that readdir is correct excluded while
modifications are in progress.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:33:00 +03:00
goto out_unlock ;
2013-08-12 14:49:45 +04:00
error = xfs_iget ( dp - > i_mount , NULL , inum , 0 , 0 , ipp ) ;
if ( error )
goto out_free_name ;
return 0 ;
out_free_name :
if ( ci_name )
kmem_free ( ci_name - > name ) ;
xfs: stop holding ILOCK over filldir callbacks
The recent change to the readdir locking made in 40194ec ("xfs:
reinstate the ilock in xfs_readdir") for CXFS directory sanity was
probably the wrong thing to do. Deep in the readdir code we
can take page faults in the filldir callback, and so taking a page
fault while holding an inode ilock creates a new set of locking
issues that lockdep warns all over the place about.
The locking order for regular inodes w.r.t. page faults is io_lock
-> pagefault -> mmap_sem -> ilock. The directory readdir code now
triggers ilock -> page fault -> mmap_sem. While we cannot deadlock
at this point, it inverts all the locking patterns that lockdep
normally sees on XFS inodes, and so triggers lockdep. We worked
around this with commit 93a8614 ("xfs: fix directory inode iolock
lockdep false positive"), but that then just moved the lockdep
warning to deeper in the page fault path and triggered on security
inode locks. Fixing the shmem issue there just moved the lockdep
reports somewhere else, and now we are getting false positives from
filesystem freezing annotations getting confused.
Further, if we enter memory reclaim in a readdir path, we now get
lockdep warning about potential deadlocks because the ilock is held
when we enter reclaim. This, again, is different to a regular file
in that we never allow memory reclaim to run while holding the ilock
for regular files. Hence lockdep now throws
ilock->kmalloc->reclaim->ilock warnings.
Basically, the problem is that the ilock is being used to protect
the directory data and the inode metadata, whereas for a regular
file the iolock protects the data and the ilock protects the
metadata. From the VFS perspective, the i_mutex serialises all
accesses to the directory data, and so not holding the ilock for
readdir doesn't matter. The issue is that CXFS doesn't access
directory data via the VFS, so it has no "data serialisaton"
mechanism. Hence we need to hold the IOLOCK in the correct places to
provide this low level directory data access serialisation.
The ilock can then be used just when the extent list needs to be
read, just like we do for regular files. The directory modification
code can take the iolock exclusive when the ilock is also taken,
and this then ensures that readdir is correct excluded while
modifications are in progress.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 03:33:00 +03:00
out_unlock :
2013-08-12 14:49:45 +04:00
* ipp = NULL ;
return error ;
}
2005-04-17 02:20:36 +04:00
/*
* Allocate an inode on disk and return a copy of its in - core version .
* The in - core inode is locked exclusively . Set mode , nlink , and rdev
* appropriately within the inode . The uid and gid for the inode are
* set according to the contents of the given cred structure .
*
* Use xfs_dialloc ( ) to allocate the on - disk inode . If xfs_dialloc ( )
2012-10-20 18:08:19 +04:00
* has a free inode available , call xfs_iget ( ) to obtain the in - core
* version of the allocated inode . Finally , fill in the inode and
* log its initial contents . In this case , ialloc_context would be
* set to NULL .
2005-04-17 02:20:36 +04:00
*
2012-10-20 18:08:19 +04:00
* If xfs_dialloc ( ) does not have an available inode , it will replenish
* its supply by doing an allocation . Since we can only do one
* allocation within a transaction without deadlocks , we must commit
* the current transaction before returning the inode itself .
* In this case , therefore , we will set ialloc_context and return .
2005-04-17 02:20:36 +04:00
* The caller should then commit the current transaction , start a new
* transaction , and call xfs_ialloc ( ) again to actually get the inode .
*
* To ensure that some other process does not grab the inode that
* was allocated during the first call to xfs_ialloc ( ) , this routine
* also returns the [ locked ] bp pointing to the head of the freelist
* as ialloc_context . The caller should hold this buffer across
* the commit and pass it back into this routine on the second call .
2007-07-11 05:09:33 +04:00
*
* If we are allocating quota inodes , we do not have a parent inode
* to attach to or associate with ( i . e . pip = = NULL ) because they
* are not linked into the directory structure - they are attached
* directly to the superblock - and so have no parent .
2005-04-17 02:20:36 +04:00
*/
2016-06-01 10:38:15 +03:00
static int
2005-04-17 02:20:36 +04:00
xfs_ialloc (
xfs_trans_t * tp ,
xfs_inode_t * pip ,
2011-07-26 10:50:15 +04:00
umode_t mode ,
2005-05-06 00:25:00 +04:00
xfs_nlink_t nlink ,
2017-10-19 21:07:09 +03:00
dev_t rdev ,
2010-09-26 10:10:18 +04:00
prid_t prid ,
2005-04-17 02:20:36 +04:00
xfs_buf_t * * ialloc_context ,
xfs_inode_t * * ipp )
{
2013-04-03 09:11:17 +04:00
struct xfs_mount * mp = tp - > t_mountp ;
2005-04-17 02:20:36 +04:00
xfs_ino_t ino ;
xfs_inode_t * ip ;
uint flags ;
int error ;
vfs: change inode times to use struct timespec64
struct timespec is not y2038 safe. Transition vfs to use
y2038 safe struct timespec64 instead.
The change was made with the help of the following cocinelle
script. This catches about 80% of the changes.
All the header file and logic changes are included in the
first 5 rules. The rest are trivial substitutions.
I avoid changing any of the function signatures or any other
filesystem specific data structures to keep the patch simple
for review.
The script can be a little shorter by combining different cases.
But, this version was sufficient for my usecase.
virtual patch
@ depends on patch @
identifier now;
@@
- struct timespec
+ struct timespec64
current_time ( ... )
{
- struct timespec now = current_kernel_time();
+ struct timespec64 now = current_kernel_time64();
...
- return timespec_trunc(
+ return timespec64_trunc(
... );
}
@ depends on patch @
identifier xtime;
@@
struct \( iattr \| inode \| kstat \) {
...
- struct timespec xtime;
+ struct timespec64 xtime;
...
}
@ depends on patch @
identifier t;
@@
struct inode_operations {
...
int (*update_time) (...,
- struct timespec t,
+ struct timespec64 t,
...);
...
}
@ depends on patch @
identifier t;
identifier fn_update_time =~ "update_time$";
@@
fn_update_time (...,
- struct timespec *t,
+ struct timespec64 *t,
...) { ... }
@ depends on patch @
identifier t;
@@
lease_get_mtime( ... ,
- struct timespec *t
+ struct timespec64 *t
) { ... }
@te depends on patch forall@
identifier ts;
local idexpression struct inode *inode_node;
identifier i_xtime =~ "^i_[acm]time$";
identifier ia_xtime =~ "^ia_[acm]time$";
identifier fn_update_time =~ "update_time$";
identifier fn;
expression e, E3;
local idexpression struct inode *node1;
local idexpression struct inode *node2;
local idexpression struct iattr *attr1;
local idexpression struct iattr *attr2;
local idexpression struct iattr attr;
identifier i_xtime1 =~ "^i_[acm]time$";
identifier i_xtime2 =~ "^i_[acm]time$";
identifier ia_xtime1 =~ "^ia_[acm]time$";
identifier ia_xtime2 =~ "^ia_[acm]time$";
@@
(
(
- struct timespec ts;
+ struct timespec64 ts;
|
- struct timespec ts = current_time(inode_node);
+ struct timespec64 ts = current_time(inode_node);
)
<+... when != ts
(
- timespec_equal(&inode_node->i_xtime, &ts)
+ timespec64_equal(&inode_node->i_xtime, &ts)
|
- timespec_equal(&ts, &inode_node->i_xtime)
+ timespec64_equal(&ts, &inode_node->i_xtime)
|
- timespec_compare(&inode_node->i_xtime, &ts)
+ timespec64_compare(&inode_node->i_xtime, &ts)
|
- timespec_compare(&ts, &inode_node->i_xtime)
+ timespec64_compare(&ts, &inode_node->i_xtime)
|
ts = current_time(e)
|
fn_update_time(..., &ts,...)
|
inode_node->i_xtime = ts
|
node1->i_xtime = ts
|
ts = inode_node->i_xtime
|
<+... attr1->ia_xtime ...+> = ts
|
ts = attr1->ia_xtime
|
ts.tv_sec
|
ts.tv_nsec
|
btrfs_set_stack_timespec_sec(..., ts.tv_sec)
|
btrfs_set_stack_timespec_nsec(..., ts.tv_nsec)
|
- ts = timespec64_to_timespec(
+ ts =
...
-)
|
- ts = ktime_to_timespec(
+ ts = ktime_to_timespec64(
...)
|
- ts = E3
+ ts = timespec_to_timespec64(E3)
|
- ktime_get_real_ts(&ts)
+ ktime_get_real_ts64(&ts)
|
fn(...,
- ts
+ timespec64_to_timespec(ts)
,...)
)
...+>
(
<... when != ts
- return ts;
+ return timespec64_to_timespec(ts);
...>
)
|
- timespec_equal(&node1->i_xtime1, &node2->i_xtime2)
+ timespec64_equal(&node1->i_xtime2, &node2->i_xtime2)
|
- timespec_equal(&node1->i_xtime1, &attr2->ia_xtime2)
+ timespec64_equal(&node1->i_xtime2, &attr2->ia_xtime2)
|
- timespec_compare(&node1->i_xtime1, &node2->i_xtime2)
+ timespec64_compare(&node1->i_xtime1, &node2->i_xtime2)
|
node1->i_xtime1 =
- timespec_trunc(attr1->ia_xtime1,
+ timespec64_trunc(attr1->ia_xtime1,
...)
|
- attr1->ia_xtime1 = timespec_trunc(attr2->ia_xtime2,
+ attr1->ia_xtime1 = timespec64_trunc(attr2->ia_xtime2,
...)
|
- ktime_get_real_ts(&attr1->ia_xtime1)
+ ktime_get_real_ts64(&attr1->ia_xtime1)
|
- ktime_get_real_ts(&attr.ia_xtime1)
+ ktime_get_real_ts64(&attr.ia_xtime1)
)
@ depends on patch @
struct inode *node;
struct iattr *attr;
identifier fn;
identifier i_xtime =~ "^i_[acm]time$";
identifier ia_xtime =~ "^ia_[acm]time$";
expression e;
@@
(
- fn(node->i_xtime);
+ fn(timespec64_to_timespec(node->i_xtime));
|
fn(...,
- node->i_xtime);
+ timespec64_to_timespec(node->i_xtime));
|
- e = fn(attr->ia_xtime);
+ e = fn(timespec64_to_timespec(attr->ia_xtime));
)
@ depends on patch forall @
struct inode *node;
struct iattr *attr;
identifier i_xtime =~ "^i_[acm]time$";
identifier ia_xtime =~ "^ia_[acm]time$";
identifier fn;
@@
{
+ struct timespec ts;
<+...
(
+ ts = timespec64_to_timespec(node->i_xtime);
fn (...,
- &node->i_xtime,
+ &ts,
...);
|
+ ts = timespec64_to_timespec(attr->ia_xtime);
fn (...,
- &attr->ia_xtime,
+ &ts,
...);
)
...+>
}
@ depends on patch forall @
struct inode *node;
struct iattr *attr;
struct kstat *stat;
identifier ia_xtime =~ "^ia_[acm]time$";
identifier i_xtime =~ "^i_[acm]time$";
identifier xtime =~ "^[acm]time$";
identifier fn, ret;
@@
{
+ struct timespec ts;
<+...
(
+ ts = timespec64_to_timespec(node->i_xtime);
ret = fn (...,
- &node->i_xtime,
+ &ts,
...);
|
+ ts = timespec64_to_timespec(node->i_xtime);
ret = fn (...,
- &node->i_xtime);
+ &ts);
|
+ ts = timespec64_to_timespec(attr->ia_xtime);
ret = fn (...,
- &attr->ia_xtime,
+ &ts,
...);
|
+ ts = timespec64_to_timespec(attr->ia_xtime);
ret = fn (...,
- &attr->ia_xtime);
+ &ts);
|
+ ts = timespec64_to_timespec(stat->xtime);
ret = fn (...,
- &stat->xtime);
+ &ts);
)
...+>
}
@ depends on patch @
struct inode *node;
struct inode *node2;
identifier i_xtime1 =~ "^i_[acm]time$";
identifier i_xtime2 =~ "^i_[acm]time$";
identifier i_xtime3 =~ "^i_[acm]time$";
struct iattr *attrp;
struct iattr *attrp2;
struct iattr attr ;
identifier ia_xtime1 =~ "^ia_[acm]time$";
identifier ia_xtime2 =~ "^ia_[acm]time$";
struct kstat *stat;
struct kstat stat1;
struct timespec64 ts;
identifier xtime =~ "^[acmb]time$";
expression e;
@@
(
( node->i_xtime2 \| attrp->ia_xtime2 \| attr.ia_xtime2 \) = node->i_xtime1 ;
|
node->i_xtime2 = \( node2->i_xtime1 \| timespec64_trunc(...) \);
|
node->i_xtime2 = node->i_xtime1 = node->i_xtime3 = \(ts \| current_time(...) \);
|
node->i_xtime1 = node->i_xtime3 = \(ts \| current_time(...) \);
|
stat->xtime = node2->i_xtime1;
|
stat1.xtime = node2->i_xtime1;
|
( node->i_xtime2 \| attrp->ia_xtime2 \) = attrp->ia_xtime1 ;
|
( attrp->ia_xtime1 \| attr.ia_xtime1 \) = attrp2->ia_xtime2;
|
- e = node->i_xtime1;
+ e = timespec64_to_timespec( node->i_xtime1 );
|
- e = attrp->ia_xtime1;
+ e = timespec64_to_timespec( attrp->ia_xtime1 );
|
node->i_xtime1 = current_time(...);
|
node->i_xtime2 = node->i_xtime1 = node->i_xtime3 =
- e;
+ timespec_to_timespec64(e);
|
node->i_xtime1 = node->i_xtime3 =
- e;
+ timespec_to_timespec64(e);
|
- node->i_xtime1 = e;
+ node->i_xtime1 = timespec_to_timespec64(e);
)
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: <anton@tuxera.com>
Cc: <balbi@kernel.org>
Cc: <bfields@fieldses.org>
Cc: <darrick.wong@oracle.com>
Cc: <dhowells@redhat.com>
Cc: <dsterba@suse.com>
Cc: <dwmw2@infradead.org>
Cc: <hch@lst.de>
Cc: <hirofumi@mail.parknet.co.jp>
Cc: <hubcap@omnibond.com>
Cc: <jack@suse.com>
Cc: <jaegeuk@kernel.org>
Cc: <jaharkes@cs.cmu.edu>
Cc: <jslaby@suse.com>
Cc: <keescook@chromium.org>
Cc: <mark@fasheh.com>
Cc: <miklos@szeredi.hu>
Cc: <nico@linaro.org>
Cc: <reiserfs-devel@vger.kernel.org>
Cc: <richard@nod.at>
Cc: <sage@redhat.com>
Cc: <sfrench@samba.org>
Cc: <swhiteho@redhat.com>
Cc: <tj@kernel.org>
Cc: <trond.myklebust@primarydata.com>
Cc: <tytso@mit.edu>
Cc: <viro@zeniv.linux.org.uk>
2018-05-09 05:36:02 +03:00
struct timespec64 tv ;
2016-02-09 08:54:58 +03:00
struct inode * inode ;
2005-04-17 02:20:36 +04:00
/*
* Call the space management code to pick
* the on - disk inode to be allocated .
*/
2017-12-05 04:32:55 +03:00
error = xfs_dialloc ( tp , pip ? pip - > i_ino : 0 , mode ,
2012-07-04 18:54:47 +04:00
ialloc_context , & ino ) ;
2008-10-30 09:36:14 +03:00
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
2012-07-04 18:54:47 +04:00
if ( * ialloc_context | | ino = = NULLFSINO ) {
2005-04-17 02:20:36 +04:00
* ipp = NULL ;
return 0 ;
}
ASSERT ( * ialloc_context = = NULL ) ;
2018-04-18 03:17:35 +03:00
/*
* Protect against obviously corrupt allocation btree records . Later
* xfs_iget checks will catch re - allocation of other active in - memory
* and on - disk inodes . If we don ' t catch reallocating the parent inode
* here we will deadlock in xfs_iget ( ) so we have to do these checks
* first .
*/
if ( ( pip & & ino = = pip - > i_ino ) | | ! xfs_verify_dir_ino ( mp , ino ) ) {
xfs_alert ( mp , " Allocated a known in-use inode 0x%llx! " , ino ) ;
return - EFSCORRUPTED ;
}
2005-04-17 02:20:36 +04:00
/*
* Get the in - core inode with the lock held exclusively .
* This is because we ' re setting fields here we need
* to prevent others from looking at until we ' re done .
*/
2013-04-03 09:11:17 +04:00
error = xfs_iget ( mp , tp , ino , XFS_IGET_CREATE ,
2011-02-13 16:26:42 +03:00
XFS_ILOCK_EXCL , & ip ) ;
2008-10-30 09:36:14 +03:00
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
ASSERT ( ip ! = NULL ) ;
2016-02-09 08:54:58 +03:00
inode = VFS_I ( ip ) ;
2016-02-09 08:54:58 +03:00
inode - > i_mode = mode ;
2016-02-09 08:54:58 +03:00
set_nlink ( inode , nlink ) ;
2020-02-21 19:31:26 +03:00
inode - > i_uid = current_fsuid ( ) ;
2017-10-19 21:07:09 +03:00
inode - > i_rdev = rdev ;
2019-11-12 19:22:54 +03:00
ip - > i_d . di_projid = prid ;
2005-04-17 02:20:36 +04:00
2007-08-30 11:21:12 +04:00
if ( pip & & XFS_INHERIT_GID ( pip ) ) {
2020-02-21 19:31:26 +03:00
inode - > i_gid = VFS_I ( pip ) - > i_gid ;
2016-02-09 08:54:58 +03:00
if ( ( VFS_I ( pip ) - > i_mode & S_ISGID ) & & S_ISDIR ( mode ) )
inode - > i_mode | = S_ISGID ;
2020-02-21 19:31:26 +03:00
} else {
inode - > i_gid = current_fsgid ( ) ;
2005-04-17 02:20:36 +04:00
}
/*
* If the group ID of the new file does not match the effective group
* ID or one of the supplementary group IDs , the S_ISGID bit is cleared
* ( and only if the irix_sgid_inherit compatibility variable is set ) .
*/
2020-02-21 19:31:27 +03:00
if ( irix_sgid_inherit & &
( inode - > i_mode & S_ISGID ) & & ! in_group_p ( inode - > i_gid ) )
2016-02-09 08:54:58 +03:00
inode - > i_mode & = ~ S_ISGID ;
2005-04-17 02:20:36 +04:00
ip - > i_d . di_size = 0 ;
ip - > i_d . di_nextents = 0 ;
ASSERT ( ip - > i_d . di_nblocks = = 0 ) ;
2008-08-13 10:44:15 +04:00
2016-09-14 17:48:06 +03:00
tv = current_time ( inode ) ;
2016-02-09 08:54:58 +03:00
inode - > i_mtime = tv ;
inode - > i_atime = tv ;
inode - > i_ctime = tv ;
2008-08-13 10:44:15 +04:00
2005-04-17 02:20:36 +04:00
ip - > i_d . di_extsize = 0 ;
ip - > i_d . di_dmevmask = 0 ;
ip - > i_d . di_dmstate = 0 ;
ip - > i_d . di_flags = 0 ;
2013-04-03 09:11:17 +04:00
2020-03-18 18:15:11 +03:00
if ( xfs_sb_version_has_v3inode ( & mp - > m_sb ) ) {
2017-12-11 14:35:19 +03:00
inode_set_iversion ( inode , 1 ) ;
2013-04-03 09:11:17 +04:00
ip - > i_d . di_flags2 = 0 ;
2016-10-03 19:11:43 +03:00
ip - > i_d . di_cowextsize = 0 ;
2019-11-12 19:20:42 +03:00
ip - > i_d . di_crtime = tv ;
2013-04-03 09:11:17 +04:00
}
2005-04-17 02:20:36 +04:00
flags = XFS_ILOG_CORE ;
switch ( mode & S_IFMT ) {
case S_IFIFO :
case S_IFCHR :
case S_IFBLK :
case S_IFSOCK :
ip - > i_d . di_format = XFS_DINODE_FMT_DEV ;
ip - > i_df . if_flags = 0 ;
flags | = XFS_ILOG_DEV ;
break ;
case S_IFREG :
case S_IFDIR :
2007-07-11 05:09:33 +04:00
if ( pip & & ( pip - > i_d . di_flags & XFS_DIFLAG_ANY ) ) {
2016-01-04 08:44:15 +03:00
uint di_flags = 0 ;
2005-06-21 09:39:12 +04:00
2011-07-26 10:31:30 +04:00
if ( S_ISDIR ( mode ) ) {
2005-06-21 09:39:12 +04:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_RTINHERIT )
di_flags | = XFS_DIFLAG_RTINHERIT ;
2006-01-11 07:28:28 +03:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_EXTSZINHERIT ) {
di_flags | = XFS_DIFLAG_EXTSZINHERIT ;
ip - > i_d . di_extsize = pip - > i_d . di_extsize ;
}
2014-10-02 03:18:40 +04:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_PROJINHERIT )
di_flags | = XFS_DIFLAG_PROJINHERIT ;
2011-07-26 10:31:30 +04:00
} else if ( S_ISREG ( mode ) ) {
2007-10-11 11:44:08 +04:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_RTINHERIT )
2005-06-21 09:39:12 +04:00
di_flags | = XFS_DIFLAG_REALTIME ;
2006-01-11 07:28:28 +03:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_EXTSZINHERIT ) {
di_flags | = XFS_DIFLAG_EXTSIZE ;
ip - > i_d . di_extsize = pip - > i_d . di_extsize ;
}
2005-04-17 02:20:36 +04:00
}
if ( ( pip - > i_d . di_flags & XFS_DIFLAG_NOATIME ) & &
xfs_inherit_noatime )
2005-06-21 09:39:12 +04:00
di_flags | = XFS_DIFLAG_NOATIME ;
2005-04-17 02:20:36 +04:00
if ( ( pip - > i_d . di_flags & XFS_DIFLAG_NODUMP ) & &
xfs_inherit_nodump )
2005-06-21 09:39:12 +04:00
di_flags | = XFS_DIFLAG_NODUMP ;
2005-04-17 02:20:36 +04:00
if ( ( pip - > i_d . di_flags & XFS_DIFLAG_SYNC ) & &
xfs_inherit_sync )
2005-06-21 09:39:12 +04:00
di_flags | = XFS_DIFLAG_SYNC ;
2005-04-17 02:20:36 +04:00
if ( ( pip - > i_d . di_flags & XFS_DIFLAG_NOSYMLINKS ) & &
xfs_inherit_nosymlinks )
2005-06-21 09:39:12 +04:00
di_flags | = XFS_DIFLAG_NOSYMLINKS ;
2006-06-09 08:54:19 +04:00
if ( ( pip - > i_d . di_flags & XFS_DIFLAG_NODEFRAG ) & &
xfs_inherit_nodefrag )
di_flags | = XFS_DIFLAG_NODEFRAG ;
2007-07-11 05:09:12 +04:00
if ( pip - > i_d . di_flags & XFS_DIFLAG_FILESTREAM )
di_flags | = XFS_DIFLAG_FILESTREAM ;
2016-01-04 08:44:15 +03:00
2005-06-21 09:39:12 +04:00
ip - > i_d . di_flags | = di_flags ;
2005-04-17 02:20:36 +04:00
}
2020-03-18 18:15:10 +03:00
if ( pip & & ( pip - > i_d . di_flags2 & XFS_DIFLAG2_ANY ) ) {
2016-10-03 19:11:43 +03:00
if ( pip - > i_d . di_flags2 & XFS_DIFLAG2_COWEXTSIZE ) {
2020-03-18 18:15:10 +03:00
ip - > i_d . di_flags2 | = XFS_DIFLAG2_COWEXTSIZE ;
2016-10-03 19:11:43 +03:00
ip - > i_d . di_cowextsize = pip - > i_d . di_cowextsize ;
}
2017-08-03 23:19:13 +03:00
if ( pip - > i_d . di_flags2 & XFS_DIFLAG2_DAX )
2020-03-18 18:15:10 +03:00
ip - > i_d . di_flags2 | = XFS_DIFLAG2_DAX ;
2016-10-03 19:11:43 +03:00
}
2005-04-17 02:20:36 +04:00
/* FALLTHROUGH */
case S_IFLNK :
ip - > i_d . di_format = XFS_DINODE_FMT_EXTENTS ;
ip - > i_df . if_flags = XFS_IFEXTENTS ;
2018-07-18 02:51:50 +03:00
ip - > i_df . if_bytes = 0 ;
2017-11-03 20:34:46 +03:00
ip - > i_df . if_u1 . if_root = NULL ;
2005-04-17 02:20:36 +04:00
break ;
default :
ASSERT ( 0 ) ;
}
/*
* Attribute fork settings for new inode .
*/
ip - > i_d . di_aformat = XFS_DINODE_FMT_EXTENTS ;
ip - > i_d . di_anextents = 0 ;
/*
* Log the new values stuffed into the inode .
*/
2011-09-19 19:00:54 +04:00
xfs_trans_ijoin ( tp , ip , XFS_ILOCK_EXCL ) ;
2005-04-17 02:20:36 +04:00
xfs_trans_log_inode ( tp , ip , flags ) ;
2015-02-23 14:38:08 +03:00
/* now that we have an i_mode we can setup the inode structure */
2008-08-13 10:23:13 +04:00
xfs_setup_inode ( ip ) ;
2005-04-17 02:20:36 +04:00
* ipp = ip ;
return 0 ;
}
2013-08-12 14:49:47 +04:00
/*
* Allocates a new inode from disk and return a pointer to the
* incore copy . This routine will internally commit the current
* transaction and allocate a new one if the Space Manager needed
* to do an allocation to replenish the inode free - list .
*
* This routine is designed to be called from xfs_create and
* xfs_create_dir .
*
*/
int
xfs_dir_ialloc (
xfs_trans_t * * tpp , /* input: current transaction;
output : may be a new transaction . */
xfs_inode_t * dp , /* directory within whose allocate
the inode . */
umode_t mode ,
xfs_nlink_t nlink ,
2017-10-19 21:07:09 +03:00
dev_t rdev ,
2013-08-12 14:49:47 +04:00
prid_t prid , /* project id */
2018-04-03 01:47:43 +03:00
xfs_inode_t * * ipp ) /* pointer to inode; it will be
2013-08-12 14:49:47 +04:00
locked . */
{
xfs_trans_t * tp ;
xfs_inode_t * ip ;
xfs_buf_t * ialloc_context = NULL ;
int code ;
void * dqinfo ;
uint tflags ;
tp = * tpp ;
ASSERT ( tp - > t_flags & XFS_TRANS_PERM_LOG_RES ) ;
/*
* xfs_ialloc will return a pointer to an incore inode if
* the Space Manager has an available inode on the free
* list . Otherwise , it will do an allocation and replenish
* the freelist . Since we can only do one allocation per
* transaction without deadlocks , we will need to commit the
* current transaction and start a new one . We will then
* need to call xfs_ialloc again to get the inode .
*
* If xfs_ialloc did an allocation to replenish the freelist ,
* it returns the bp containing the head of the freelist as
* ialloc_context . We will hold a lock on it across the
* transaction commit so that no other process can steal
* the inode ( s ) that we ' ve just allocated .
*/
2017-12-05 04:32:55 +03:00
code = xfs_ialloc ( tp , dp , mode , nlink , rdev , prid , & ialloc_context ,
& ip ) ;
2013-08-12 14:49:47 +04:00
/*
* Return an error if we were unable to allocate a new inode .
* This should only happen if we run out of space on disk or
* encounter a disk error .
*/
if ( code ) {
* ipp = NULL ;
return code ;
}
if ( ! ialloc_context & & ! ip ) {
* ipp = NULL ;
2014-06-25 08:58:08 +04:00
return - ENOSPC ;
2013-08-12 14:49:47 +04:00
}
/*
* If the AGI buffer is non - NULL , then we were unable to get an
* inode in one operation . We need to commit the current
* transaction and call xfs_ialloc ( ) again . It is guaranteed
* to succeed the second time .
*/
if ( ialloc_context ) {
/*
* Normally , xfs_trans_commit releases all the locks .
* We call bhold to hang on to the ialloc_context across
* the commit . Holding this buffer prevents any other
* processes from doing any allocations in this
* allocation group .
*/
xfs_trans_bhold ( tp , ialloc_context ) ;
/*
* We want the quota changes to be associated with the next
* transaction , NOT this one . So , detach the dqinfo from this
* and attach it to the next transaction .
*/
dqinfo = NULL ;
tflags = 0 ;
if ( tp - > t_dqinfo ) {
dqinfo = ( void * ) tp - > t_dqinfo ;
tp - > t_dqinfo = NULL ;
tflags = tp - > t_flags & XFS_TRANS_DQ_DIRTY ;
tp - > t_flags & = ~ ( XFS_TRANS_DQ_DIRTY ) ;
}
2017-08-28 20:21:03 +03:00
code = xfs_trans_roll ( & tp ) ;
2013-08-12 14:49:59 +04:00
2013-08-12 14:49:47 +04:00
/*
* Re - attach the quota info that we detached from prev trx .
*/
if ( dqinfo ) {
tp - > t_dqinfo = dqinfo ;
tp - > t_flags | = tflags ;
}
if ( code ) {
xfs_buf_relse ( ialloc_context ) ;
2015-06-04 06:47:29 +03:00
* tpp = tp ;
2013-08-12 14:49:47 +04:00
* ipp = NULL ;
return code ;
}
xfs_trans_bjoin ( tp , ialloc_context ) ;
/*
* Call ialloc again . Since we ' ve locked out all
* other allocations in this allocation group ,
* this call should always succeed .
*/
code = xfs_ialloc ( tp , dp , mode , nlink , rdev , prid ,
2017-12-05 04:32:55 +03:00
& ialloc_context , & ip ) ;
2013-08-12 14:49:47 +04:00
/*
* If we get an error at this point , return to the caller
* so that the current transaction can be aborted .
*/
if ( code ) {
* tpp = tp ;
* ipp = NULL ;
return code ;
}
ASSERT ( ! ialloc_context & & ip ) ;
}
* ipp = ip ;
* tpp = tp ;
return 0 ;
}
/*
2016-02-09 08:54:58 +03:00
* Decrement the link count on an inode & log the change . If this causes the
* link count to go to zero , move the inode to AGI unlinked list so that it can
* be freed when the last active reference goes away via xfs_inactive ( ) .
2013-08-12 14:49:47 +04:00
*/
2016-06-01 10:38:15 +03:00
static int /* error */
2013-08-12 14:49:47 +04:00
xfs_droplink (
xfs_trans_t * tp ,
xfs_inode_t * ip )
{
xfs_trans_ichgtime ( tp , ip , XFS_ICHGTIME_CHG ) ;
drop_nlink ( VFS_I ( ip ) ) ;
xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ;
2016-02-09 08:54:58 +03:00
if ( VFS_I ( ip ) - > i_nlink )
return 0 ;
return xfs_iunlink ( tp , ip ) ;
2013-08-12 14:49:47 +04:00
}
/*
* Increment the link count on an inode & log the change .
*/
2019-05-02 06:26:30 +03:00
static void
2013-08-12 14:49:47 +04:00
xfs_bumplink (
xfs_trans_t * tp ,
xfs_inode_t * ip )
{
xfs_trans_ichgtime ( tp , ip , XFS_ICHGTIME_CHG ) ;
inc_nlink ( VFS_I ( ip ) ) ;
xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ;
}
2013-08-12 14:49:45 +04:00
int
xfs_create (
xfs_inode_t * dp ,
struct xfs_name * name ,
umode_t mode ,
2017-10-19 21:07:09 +03:00
dev_t rdev ,
2013-08-12 14:49:45 +04:00
xfs_inode_t * * ipp )
{
int is_dir = S_ISDIR ( mode ) ;
struct xfs_mount * mp = dp - > i_mount ;
struct xfs_inode * ip = NULL ;
struct xfs_trans * tp = NULL ;
int error ;
bool unlock_dp_on_error = false ;
prid_t prid ;
struct xfs_dquot * udqp = NULL ;
struct xfs_dquot * gdqp = NULL ;
struct xfs_dquot * pdqp = NULL ;
2014-11-28 06:00:16 +03:00
struct xfs_trans_res * tres ;
2013-08-12 14:49:45 +04:00
uint resblks ;
trace_xfs_create ( dp , name ) ;
if ( XFS_FORCED_SHUTDOWN ( mp ) )
2014-06-25 08:58:08 +04:00
return - EIO ;
2013-08-12 14:49:45 +04:00
2013-12-18 04:22:39 +04:00
prid = xfs_get_initial_prid ( dp ) ;
2013-08-12 14:49:45 +04:00
/*
* Make sure that we have allocated dquot ( s ) on disk .
*/
2020-02-21 19:31:27 +03:00
error = xfs_qm_vop_dqalloc ( dp , current_fsuid ( ) , current_fsgid ( ) , prid ,
2013-08-12 14:49:45 +04:00
XFS_QMOPT_QUOTALL | XFS_QMOPT_INHERIT ,
& udqp , & gdqp , & pdqp ) ;
if ( error )
return error ;
if ( is_dir ) {
resblks = XFS_MKDIR_SPACE_RES ( mp , name - > len ) ;
2014-11-28 06:00:16 +03:00
tres = & M_RES ( mp ) - > tr_mkdir ;
2013-08-12 14:49:45 +04:00
} else {
resblks = XFS_CREATE_SPACE_RES ( mp , name - > len ) ;
2014-11-28 06:00:16 +03:00
tres = & M_RES ( mp ) - > tr_create ;
2013-08-12 14:49:45 +04:00
}
/*
* Initially assume that the file does not exist and
* reserve the resources for that case . If that is not
* the case we ' ll drop the one we have and get a more
* appropriate transaction later .
*/
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , tres , resblks , 0 , 0 , & tp ) ;
2014-06-25 08:58:08 +04:00
if ( error = = - ENOSPC ) {
2013-08-12 14:49:45 +04:00
/* flush outstanding delalloc blocks and retry */
xfs_flush_inodes ( mp ) ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , tres , resblks , 0 , 0 , & tp ) ;
2013-08-12 14:49:45 +04:00
}
2015-06-04 06:47:56 +03:00
if ( error )
2016-04-06 02:19:55 +03:00
goto out_release_inode ;
2013-08-12 14:49:45 +04:00
2016-11-30 06:33:25 +03:00
xfs_ilock ( dp , XFS_ILOCK_EXCL | XFS_ILOCK_PARENT ) ;
2013-08-12 14:49:45 +04:00
unlock_dp_on_error = true ;
/*
* Reserve disk quota and the inode .
*/
error = xfs_trans_reserve_quota ( tp , mp , udqp , gdqp ,
pdqp , resblks , 1 , 0 ) ;
if ( error )
goto out_trans_cancel ;
/*
* A newly created regular or special file just has one directory
* entry pointing to them , but a directory also the " . " entry
* pointing to itself .
*/
2018-04-03 01:47:43 +03:00
error = xfs_dir_ialloc ( & tp , dp , mode , is_dir ? 2 : 1 , rdev , prid , & ip ) ;
2015-07-29 04:52:08 +03:00
if ( error )
2015-06-04 06:47:56 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
/*
* Now we join the directory inode to the transaction . We do not do it
* earlier because xfs_dir_ialloc might commit the previous transaction
* ( and release all the locks ) . An error from here on will result in
* the transaction cancel unlocking dp so don ' t do it explicitly in the
* error path .
*/
2016-11-30 06:33:25 +03:00
xfs_trans_ijoin ( tp , dp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
unlock_dp_on_error = false ;
2018-07-12 08:26:21 +03:00
error = xfs_dir_createname ( tp , dp , name , ip - > i_ino ,
2020-03-27 18:28:39 +03:00
resblks - XFS_IALLOC_SPACE_RES ( mp ) ) ;
2013-08-12 14:49:45 +04:00
if ( error ) {
2014-06-25 08:58:08 +04:00
ASSERT ( error ! = - ENOSPC ) ;
2015-06-04 06:47:56 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
}
xfs_trans_ichgtime ( tp , dp , XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
xfs_trans_log_inode ( tp , dp , XFS_ILOG_CORE ) ;
if ( is_dir ) {
error = xfs_dir_init ( tp , ip , dp ) ;
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
2019-05-02 06:26:30 +03:00
xfs_bumplink ( tp , dp ) ;
2013-08-12 14:49:45 +04:00
}
/*
* If this is a synchronous mount , make sure that the
* create transaction goes to disk before returning to
* the user .
*/
if ( mp - > m_flags & ( XFS_MOUNT_WSYNC | XFS_MOUNT_DIRSYNC ) )
xfs_trans_set_sync ( tp ) ;
/*
* Attach the dquot ( s ) to the inodes and modify them incore .
* These ids of the inode couldn ' t have changed since the new
* inode has been locked ever since it was created .
*/
xfs_qm_vop_create_dqattach ( tp , ip , udqp , gdqp , pdqp ) ;
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto out_release_inode ;
xfs_qm_dqrele ( udqp ) ;
xfs_qm_dqrele ( gdqp ) ;
xfs_qm_dqrele ( pdqp ) ;
* ipp = ip ;
return 0 ;
out_trans_cancel :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-08-12 14:49:45 +04:00
out_release_inode :
/*
2015-02-23 14:38:08 +03:00
* Wait until after the current transaction is aborted to finish the
* setup of the inode and release the inode . This prevents recursive
* transactions and deadlocks from xfs_inactive .
2013-08-12 14:49:45 +04:00
*/
2015-02-23 14:38:08 +03:00
if ( ip ) {
xfs_finish_inode_setup ( ip ) ;
2018-07-25 22:52:32 +03:00
xfs_irele ( ip ) ;
2015-02-23 14:38:08 +03:00
}
2013-08-12 14:49:45 +04:00
xfs_qm_dqrele ( udqp ) ;
xfs_qm_dqrele ( gdqp ) ;
xfs_qm_dqrele ( pdqp ) ;
if ( unlock_dp_on_error )
2016-11-30 06:33:25 +03:00
xfs_iunlock ( dp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
return error ;
}
2013-12-18 04:22:40 +04:00
int
xfs_create_tmpfile (
struct xfs_inode * dp ,
2014-04-17 02:15:30 +04:00
umode_t mode ,
struct xfs_inode * * ipp )
2013-12-18 04:22:40 +04:00
{
struct xfs_mount * mp = dp - > i_mount ;
struct xfs_inode * ip = NULL ;
struct xfs_trans * tp = NULL ;
int error ;
prid_t prid ;
struct xfs_dquot * udqp = NULL ;
struct xfs_dquot * gdqp = NULL ;
struct xfs_dquot * pdqp = NULL ;
struct xfs_trans_res * tres ;
uint resblks ;
if ( XFS_FORCED_SHUTDOWN ( mp ) )
2014-06-25 08:58:08 +04:00
return - EIO ;
2013-12-18 04:22:40 +04:00
prid = xfs_get_initial_prid ( dp ) ;
/*
* Make sure that we have allocated dquot ( s ) on disk .
*/
2020-02-21 19:31:27 +03:00
error = xfs_qm_vop_dqalloc ( dp , current_fsuid ( ) , current_fsgid ( ) , prid ,
2013-12-18 04:22:40 +04:00
XFS_QMOPT_QUOTALL | XFS_QMOPT_INHERIT ,
& udqp , & gdqp , & pdqp ) ;
if ( error )
return error ;
resblks = XFS_IALLOC_SPACE_RES ( mp ) ;
tres = & M_RES ( mp ) - > tr_create_tmpfile ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , tres , resblks , 0 , 0 , & tp ) ;
2015-06-04 06:47:56 +03:00
if ( error )
2016-04-06 02:19:55 +03:00
goto out_release_inode ;
2013-12-18 04:22:40 +04:00
error = xfs_trans_reserve_quota ( tp , mp , udqp , gdqp ,
pdqp , resblks , 1 , 0 ) ;
if ( error )
goto out_trans_cancel ;
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-13 22:15:17 +03:00
error = xfs_dir_ialloc ( & tp , dp , mode , 0 , 0 , prid , & ip ) ;
2015-07-29 04:52:08 +03:00
if ( error )
2015-06-04 06:47:56 +03:00
goto out_trans_cancel ;
2013-12-18 04:22:40 +04:00
if ( mp - > m_flags & XFS_MOUNT_WSYNC )
xfs_trans_set_sync ( tp ) ;
/*
* Attach the dquot ( s ) to the inodes and modify them incore .
* These ids of the inode couldn ' t have changed since the new
* inode has been locked ever since it was created .
*/
xfs_qm_vop_create_dqattach ( tp , ip , udqp , gdqp , pdqp ) ;
error = xfs_iunlink ( tp , ip ) ;
if ( error )
2015-06-04 06:47:56 +03:00
goto out_trans_cancel ;
2013-12-18 04:22:40 +04:00
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2013-12-18 04:22:40 +04:00
if ( error )
goto out_release_inode ;
xfs_qm_dqrele ( udqp ) ;
xfs_qm_dqrele ( gdqp ) ;
xfs_qm_dqrele ( pdqp ) ;
2014-04-17 02:15:30 +04:00
* ipp = ip ;
2013-12-18 04:22:40 +04:00
return 0 ;
out_trans_cancel :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-12-18 04:22:40 +04:00
out_release_inode :
/*
2015-02-23 14:38:08 +03:00
* Wait until after the current transaction is aborted to finish the
* setup of the inode and release the inode . This prevents recursive
* transactions and deadlocks from xfs_inactive .
2013-12-18 04:22:40 +04:00
*/
2015-02-23 14:38:08 +03:00
if ( ip ) {
xfs_finish_inode_setup ( ip ) ;
2018-07-25 22:52:32 +03:00
xfs_irele ( ip ) ;
2015-02-23 14:38:08 +03:00
}
2013-12-18 04:22:40 +04:00
xfs_qm_dqrele ( udqp ) ;
xfs_qm_dqrele ( gdqp ) ;
xfs_qm_dqrele ( pdqp ) ;
return error ;
}
2013-08-12 14:49:45 +04:00
int
xfs_link (
xfs_inode_t * tdp ,
xfs_inode_t * sip ,
struct xfs_name * target_name )
{
xfs_mount_t * mp = tdp - > i_mount ;
xfs_trans_t * tp ;
int error ;
int resblks ;
trace_xfs_link ( tdp , target_name ) ;
2016-02-09 08:54:58 +03:00
ASSERT ( ! S_ISDIR ( VFS_I ( sip ) - > i_mode ) ) ;
2013-08-12 14:49:45 +04:00
if ( XFS_FORCED_SHUTDOWN ( mp ) )
2014-06-25 08:58:08 +04:00
return - EIO ;
2013-08-12 14:49:45 +04:00
2018-05-05 01:30:21 +03:00
error = xfs_qm_dqattach ( sip ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto std_return ;
2018-05-05 01:30:21 +03:00
error = xfs_qm_dqattach ( tdp ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto std_return ;
resblks = XFS_LINK_SPACE_RES ( mp , target_name - > len ) ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_link , resblks , 0 , 0 , & tp ) ;
2014-06-25 08:58:08 +04:00
if ( error = = - ENOSPC ) {
2013-08-12 14:49:45 +04:00
resblks = 0 ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_link , 0 , 0 , 0 , & tp ) ;
2013-08-12 14:49:45 +04:00
}
2015-06-04 06:47:56 +03:00
if ( error )
2016-04-06 02:19:55 +03:00
goto std_return ;
2013-08-12 14:49:45 +04:00
2018-01-27 02:27:33 +03:00
xfs_lock_two_inodes ( sip , XFS_ILOCK_EXCL , tdp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
xfs_trans_ijoin ( tp , sip , XFS_ILOCK_EXCL ) ;
2016-11-30 06:33:25 +03:00
xfs_trans_ijoin ( tp , tdp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
/*
* If we are using project inheritance , we only allow hard link
* creation in our tree when the project IDs are the same ; else
* the tree quota mechanism could be circumvented .
*/
if ( unlikely ( ( tdp - > i_d . di_flags & XFS_DIFLAG_PROJINHERIT ) & &
2019-11-12 19:22:54 +03:00
tdp - > i_d . di_projid ! = sip - > i_d . di_projid ) ) {
2014-06-25 08:58:08 +04:00
error = - EXDEV ;
2013-08-12 14:49:45 +04:00
goto error_return ;
}
2014-09-09 05:57:52 +04:00
if ( ! resblks ) {
error = xfs_dir_canenter ( tp , tdp , target_name ) ;
if ( error )
goto error_return ;
}
2013-08-12 14:49:45 +04:00
2016-02-09 08:54:58 +03:00
/*
* Handle initial link state of O_TMPFILE inode
*/
if ( VFS_I ( sip ) - > i_nlink = = 0 ) {
2013-12-18 04:22:41 +04:00
error = xfs_iunlink_remove ( tp , sip ) ;
if ( error )
2015-06-04 06:47:56 +03:00
goto error_return ;
2013-12-18 04:22:41 +04:00
}
2013-08-12 14:49:45 +04:00
error = xfs_dir_createname ( tp , tdp , target_name , sip - > i_ino ,
2018-07-12 08:26:21 +03:00
resblks ) ;
2013-08-12 14:49:45 +04:00
if ( error )
2015-06-04 06:47:56 +03:00
goto error_return ;
2013-08-12 14:49:45 +04:00
xfs_trans_ichgtime ( tp , tdp , XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
xfs_trans_log_inode ( tp , tdp , XFS_ILOG_CORE ) ;
2019-05-02 06:26:30 +03:00
xfs_bumplink ( tp , sip ) ;
2013-08-12 14:49:45 +04:00
/*
* If this is a synchronous mount , make sure that the
* link transaction goes to disk before returning to
* the user .
*/
xfs: eliminate committed arg from xfs_bmap_finish
Calls to xfs_bmap_finish() and xfs_trans_ijoin(), and the
associated comments were replicated several times across
the attribute code, all dealing with what to do if the
transaction was or wasn't committed.
And in that replicated code, an ASSERT() test of an
uninitialized variable occurs in several locations:
error = xfs_attr_thing(&args);
if (!error) {
error = xfs_bmap_finish(&args.trans, args.flist,
&committed);
}
if (error) {
ASSERT(committed);
If the first xfs_attr_thing() failed, we'd skip the xfs_bmap_finish,
never set "committed", and then test it in the ASSERT.
Fix this up by moving the committed state internal to xfs_bmap_finish,
and add a new inode argument. If an inode is passed in, it is passed
through to __xfs_trans_roll() and joined to the transaction there if
the transaction was committed.
xfs_qm_dqalloc() was a little unique in that it called bjoin rather
than ijoin, but as Dave points out we can detect the committed state
but checking whether (*tpp != tp).
Addresses-Coverity-Id: 102360
Addresses-Coverity-Id: 102361
Addresses-Coverity-Id: 102363
Addresses-Coverity-Id: 102364
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-01-11 03:34:01 +03:00
if ( mp - > m_flags & ( XFS_MOUNT_WSYNC | XFS_MOUNT_DIRSYNC ) )
2013-08-12 14:49:45 +04:00
xfs_trans_set_sync ( tp ) ;
2015-06-04 06:48:08 +03:00
return xfs_trans_commit ( tp ) ;
2013-08-12 14:49:45 +04:00
error_return :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-08-12 14:49:45 +04:00
std_return :
return error ;
}
2017-12-15 02:42:59 +03:00
/* Clear the reflink flag and the cowblocks tag if possible. */
static void
xfs_itruncate_clear_reflink_flags (
struct xfs_inode * ip )
{
struct xfs_ifork * dfork ;
struct xfs_ifork * cfork ;
if ( ! xfs_is_reflink_inode ( ip ) )
return ;
dfork = XFS_IFORK_PTR ( ip , XFS_DATA_FORK ) ;
cfork = XFS_IFORK_PTR ( ip , XFS_COW_FORK ) ;
if ( dfork - > if_bytes = = 0 & & cfork - > if_bytes = = 0 )
ip - > i_d . di_flags2 & = ~ XFS_DIFLAG2_REFLINK ;
if ( cfork - > if_bytes = = 0 )
xfs_inode_clear_cowblocks_tag ( ip ) ;
}
2005-04-17 02:20:36 +04:00
/*
2011-07-08 16:34:34 +04:00
* Free up the underlying blocks past new_size . The new size must be smaller
* than the current size . This routine can be used both for the attribute and
* data fork , and does not modify the inode size , which is left to the caller .
2005-04-17 02:20:36 +04:00
*
2008-04-17 10:50:04 +04:00
* The transaction passed to this routine must have made a permanent log
* reservation of at least XFS_ITRUNCATE_LOG_RES . This routine may commit the
* given transaction and start new ones , so make sure everything involved in
* the transaction is tidy before calling here . Some transaction will be
* returned to the caller to be committed . The incoming transaction must
* already include the inode , and both inode locks must be held exclusively .
* The inode must also be " held " within the transaction . On return the inode
* will be " held " within the returned transaction . This routine does NOT
* require any disk space to be reserved for it within the transaction .
2005-04-17 02:20:36 +04:00
*
2008-04-17 10:50:04 +04:00
* If we get an error , we must return with the inode locked and linked into the
* current transaction . This keeps things simple for the higher level code ,
* because it always knows that the inode is locked and held in the transaction
* that returns to it whether errors occur or not . We don ' t mark the inode
* dirty on error so that transactions can be easily aborted if possible .
2005-04-17 02:20:36 +04:00
*/
int
2018-05-10 19:35:42 +03:00
xfs_itruncate_extents_flags (
2011-07-08 16:34:34 +04:00
struct xfs_trans * * tpp ,
struct xfs_inode * ip ,
int whichfork ,
2018-05-09 18:45:04 +03:00
xfs_fsize_t new_size ,
2018-05-10 19:35:42 +03:00
int flags )
2005-04-17 02:20:36 +04:00
{
2011-07-08 16:34:34 +04:00
struct xfs_mount * mp = ip - > i_mount ;
struct xfs_trans * tp = * tpp ;
xfs_fileoff_t first_unmap_block ;
xfs_filblks_t unmap_len ;
int error = 0 ;
2005-04-17 02:20:36 +04:00
2012-07-04 19:13:31 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL ) ) ;
ASSERT ( ! atomic_read ( & VFS_I ( ip ) - > i_count ) | |
xfs_isilocked ( ip , XFS_IOLOCK_EXCL ) ) ;
2011-12-19 00:00:11 +04:00
ASSERT ( new_size < = XFS_ISIZE ( ip ) ) ;
2011-07-08 16:34:34 +04:00
ASSERT ( tp - > t_flags & XFS_TRANS_PERM_LOG_RES ) ;
2005-04-17 02:20:36 +04:00
ASSERT ( ip - > i_itemp ! = NULL ) ;
2010-06-24 05:36:58 +04:00
ASSERT ( ip - > i_itemp - > ili_lock_flags = = 0 ) ;
2011-07-08 16:34:34 +04:00
ASSERT ( ! XFS_NOT_DQATTACHED ( mp , ip ) ) ;
2005-04-17 02:20:36 +04:00
2011-12-19 00:00:04 +04:00
trace_xfs_itruncate_extents_start ( ip , new_size ) ;
2018-05-10 19:35:42 +03:00
flags | = xfs_bmapi_aflag ( whichfork ) ;
2018-05-09 18:45:04 +03:00
2005-04-17 02:20:36 +04:00
/*
* Since it is possible for space to become allocated beyond
* the end of the file ( in a crash where the space is allocated
* but the inode size is not yet updated ) , simply remove any
* blocks which show up between the new EOF and the maximum
2020-01-03 00:20:13 +03:00
* possible file size .
*
* We have to free all the blocks to the bmbt maximum offset , even if
* the page cache can ' t scale that far .
2005-04-17 02:20:36 +04:00
*/
2011-07-08 16:34:34 +04:00
first_unmap_block = XFS_B_TO_FSB ( mp , ( xfs_ufsize_t ) new_size ) ;
2020-01-03 00:20:13 +03:00
if ( first_unmap_block > = XFS_MAX_FILEOFF ) {
WARN_ON_ONCE ( first_unmap_block > XFS_MAX_FILEOFF ) ;
2011-07-08 16:34:34 +04:00
return 0 ;
2020-01-03 00:20:13 +03:00
}
2011-07-08 16:34:34 +04:00
2020-01-03 00:20:13 +03:00
unmap_len = XFS_MAX_FILEOFF - first_unmap_block + 1 ;
while ( unmap_len > 0 ) {
2018-07-24 23:43:07 +03:00
ASSERT ( tp - > t_firstblock = = NULLFSBLOCK ) ;
2020-01-03 00:20:13 +03:00
error = __xfs_bunmapi ( tp , ip , first_unmap_block , & unmap_len ,
flags , XFS_ITRUNC_MAX_EXTENTS ) ;
2011-07-08 16:34:34 +04:00
if ( error )
2018-09-29 06:41:58 +03:00
goto out ;
2005-04-17 02:20:36 +04:00
/*
* Duplicate the transaction that has the permanent
* reservation and commit the old transaction .
*/
2018-07-24 23:43:15 +03:00
error = xfs_defer_finish ( & tp ) ;
2011-07-08 16:34:34 +04:00
if ( error )
2018-08-01 17:20:33 +03:00
goto out ;
2005-04-17 02:20:36 +04:00
2017-08-28 20:21:03 +03:00
error = xfs_trans_roll_inode ( & tp , ip ) ;
2008-04-17 10:50:04 +04:00
if ( error )
2011-07-08 16:34:34 +04:00
goto out ;
2005-04-17 02:20:36 +04:00
}
2011-07-08 16:34:34 +04:00
2018-04-10 18:28:33 +03:00
if ( whichfork = = XFS_DATA_FORK ) {
/* Remove all pending CoW reservations. */
error = xfs_reflink_cancel_cow_blocks ( ip , & tp ,
2020-01-03 00:20:13 +03:00
first_unmap_block , XFS_MAX_FILEOFF , true ) ;
2018-04-10 18:28:33 +03:00
if ( error )
goto out ;
2016-10-03 19:11:38 +03:00
2018-04-10 18:28:33 +03:00
xfs_itruncate_clear_reflink_flags ( ip ) ;
}
2016-10-03 19:11:38 +03:00
2011-12-19 00:00:04 +04:00
/*
* Always re - log the inode so that our permanent transaction can keep
* on rolling it forward in the log .
*/
xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ;
trace_xfs_itruncate_extents_end ( ip , new_size ) ;
2011-07-08 16:34:34 +04:00
out :
* tpp = tp ;
return error ;
}
2013-08-12 14:49:45 +04:00
int
xfs_release (
xfs_inode_t * ip )
{
xfs_mount_t * mp = ip - > i_mount ;
int error ;
2016-02-09 08:54:58 +03:00
if ( ! S_ISREG ( VFS_I ( ip ) - > i_mode ) | | ( VFS_I ( ip ) - > i_mode = = 0 ) )
2013-08-12 14:49:45 +04:00
return 0 ;
/* If this is a read-only mount, don't do this (would generate I/O) */
if ( mp - > m_flags & XFS_MOUNT_RDONLY )
return 0 ;
if ( ! XFS_FORCED_SHUTDOWN ( mp ) ) {
int truncated ;
/*
* If we previously truncated this file and removed old data
* in the process , we want to initiate " early " writeout on
* the last close . This is an attempt to combat the notorious
* NULL files problem which is particularly noticeable from a
* truncate down , buffered ( re - ) write ( delalloc ) , followed by
* a crash . What we are effectively doing here is
* significantly reducing the time window where we ' d otherwise
* be exposed to that problem .
*/
truncated = xfs_iflags_test_and_clear ( ip , XFS_ITRUNCATED ) ;
if ( truncated ) {
xfs_iflags_clear ( ip , XFS_IDIRTY_RELEASE ) ;
2014-08-04 07:22:49 +04:00
if ( ip - > i_delayed_blks > 0 ) {
2014-06-25 08:58:08 +04:00
error = filemap_flush ( VFS_I ( ip ) - > i_mapping ) ;
2013-08-12 14:49:45 +04:00
if ( error )
return error ;
}
}
}
2016-02-09 08:54:58 +03:00
if ( VFS_I ( ip ) - > i_nlink = = 0 )
2013-08-12 14:49:45 +04:00
return 0 ;
if ( xfs_can_free_eofblocks ( ip , false ) ) {
2017-01-28 10:22:55 +03:00
/*
* Check if the inode is being opened , written and closed
* frequently and we have delayed allocation blocks outstanding
* ( e . g . streaming writes from the NFS server ) , truncating the
* blocks past EOF will cause fragmentation to occur .
*
* In this case don ' t do the truncation , but we have to be
* careful how we detect this case . Blocks beyond EOF show up as
* i_delayed_blks even when the inode is clean , so we need to
* truncate them away first before checking for a dirty release .
* Hence on the first dirty close we will still remove the
* speculative allocation , but after that we will leave it in
* place .
*/
if ( xfs_iflags_test ( ip , XFS_IDIRTY_RELEASE ) )
return 0 ;
2013-08-12 14:49:45 +04:00
/*
* If we can ' t get the iolock just skip truncating the blocks
* past EOF because we could deadlock with the mmap_sem
2017-01-28 10:22:55 +03:00
* otherwise . We ' ll get another chance to drop them once the
2013-08-12 14:49:45 +04:00
* last reference to the inode is dropped , so we ' ll never leak
* blocks permanently .
*/
2017-01-28 10:22:55 +03:00
if ( xfs_ilock_nowait ( ip , XFS_IOLOCK_EXCL ) ) {
error = xfs_free_eofblocks ( ip ) ;
xfs_iunlock ( ip , XFS_IOLOCK_EXCL ) ;
if ( error )
return error ;
}
2013-08-12 14:49:45 +04:00
/* delalloc blocks after truncation means it really is dirty */
if ( ip - > i_delayed_blks )
xfs_iflags_set ( ip , XFS_IDIRTY_RELEASE ) ;
}
return 0 ;
}
2013-09-20 19:06:10 +04:00
/*
* xfs_inactive_truncate
*
* Called to perform a truncate when an inode becomes unlinked .
*/
STATIC int
xfs_inactive_truncate (
struct xfs_inode * ip )
{
struct xfs_mount * mp = ip - > i_mount ;
struct xfs_trans * tp ;
int error ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_itruncate , 0 , 0 , 0 , & tp ) ;
2013-09-20 19:06:10 +04:00
if ( error ) {
ASSERT ( XFS_FORCED_SHUTDOWN ( mp ) ) ;
return error ;
}
xfs_ilock ( ip , XFS_ILOCK_EXCL ) ;
xfs_trans_ijoin ( tp , ip , 0 ) ;
/*
* Log the inode size first to prevent stale data exposure in the event
* of a system crash before the truncate completes . See the related
2016-05-26 15:46:43 +03:00
* comment in xfs_vn_setattr_size ( ) for details .
2013-09-20 19:06:10 +04:00
*/
ip - > i_d . di_size = 0 ;
xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ;
error = xfs_itruncate_extents ( & tp , ip , XFS_DATA_FORK , 0 ) ;
if ( error )
goto error_trans_cancel ;
ASSERT ( ip - > i_d . di_nextents = = 0 ) ;
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2013-09-20 19:06:10 +04:00
if ( error )
goto error_unlock ;
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
return 0 ;
error_trans_cancel :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-09-20 19:06:10 +04:00
error_unlock :
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
return error ;
}
2013-09-20 19:06:11 +04:00
/*
* xfs_inactive_ifree ( )
*
* Perform the inode free when an inode is unlinked .
*/
STATIC int
xfs_inactive_ifree (
struct xfs_inode * ip )
{
struct xfs_mount * mp = ip - > i_mount ;
struct xfs_trans * tp ;
int error ;
2014-04-24 10:00:52 +04:00
/*
2017-01-25 18:49:35 +03:00
* We try to use a per - AG reservation for any block needed by the finobt
* tree , but as the finobt feature predates the per - AG reservation
* support a degraded file system might not have enough space for the
* reservation at mount time . In that case try to dip into the reserved
* pool and pray .
2014-04-24 10:00:52 +04:00
*
* Send a warning if the reservation does happen to fail , as the inode
* now remains allocated and sits on the unlinked list until the fs is
* repaired .
*/
2019-02-14 20:33:15 +03:00
if ( unlikely ( mp - > m_finobt_nores ) ) {
2017-01-25 18:49:35 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_ifree ,
XFS_IFREE_SPACE_RES ( mp ) , 0 , XFS_TRANS_RESERVE ,
& tp ) ;
} else {
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_ifree , 0 , 0 , 0 , & tp ) ;
}
2013-09-20 19:06:11 +04:00
if ( error ) {
2014-06-25 08:58:08 +04:00
if ( error = = - ENOSPC ) {
2014-04-24 10:00:52 +04:00
xfs_warn_ratelimited ( mp ,
" Failed to remove inode(s) from unlinked list. "
" Please free space, unmount and run xfs_repair. " ) ;
} else {
ASSERT ( XFS_FORCED_SHUTDOWN ( mp ) ) ;
}
2013-09-20 19:06:11 +04:00
return error ;
}
xfs_ilock ( ip , XFS_ILOCK_EXCL ) ;
xfs_trans_ijoin ( tp , ip , 0 ) ;
2018-07-12 08:26:07 +03:00
error = xfs_ifree ( tp , ip ) ;
2013-09-20 19:06:11 +04:00
if ( error ) {
/*
* If we fail to free the inode , shut down . The cancel
* might do that , we need to make sure . Otherwise the
* inode might be lost for a long time or forever .
*/
if ( ! XFS_FORCED_SHUTDOWN ( mp ) ) {
xfs_notice ( mp , " %s: xfs_ifree returned error %d " ,
__func__ , error ) ;
xfs_force_shutdown ( mp , SHUTDOWN_META_IO_ERROR ) ;
}
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-09-20 19:06:11 +04:00
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
return error ;
}
/*
* Credit the quota account ( s ) . The inode is gone .
*/
xfs_trans_mod_dquot_byino ( tp , ip , XFS_TRANS_DQ_ICOUNT , - 1 ) ;
/*
2015-08-19 03:01:40 +03:00
* Just ignore errors at this point . There is nothing we can do except
* to try to keep going . Make sure it ' s not a silent error .
2013-09-20 19:06:11 +04:00
*/
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2013-09-20 19:06:11 +04:00
if ( error )
xfs_notice ( mp , " %s: xfs_trans_commit returned error %d " ,
__func__ , error ) ;
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
return 0 ;
}
2013-08-12 14:49:45 +04:00
/*
* xfs_inactive
*
* This is called when the vnode reference count for the vnode
* goes to zero . If the file has been unlinked , then it must
* now be truncated . Also , we clear all of the read - ahead state
* kept for the inode here since the file is now closed .
*/
2013-09-20 19:06:12 +04:00
void
2013-08-12 14:49:45 +04:00
xfs_inactive (
xfs_inode_t * ip )
{
2013-08-12 14:49:59 +04:00
struct xfs_mount * mp ;
int error ;
int truncate = 0 ;
2013-08-12 14:49:45 +04:00
/*
* If the inode is already free , then there can be nothing
* to clean up here .
*/
2016-02-09 08:54:58 +03:00
if ( VFS_I ( ip ) - > i_mode = = 0 ) {
2013-08-12 14:49:45 +04:00
ASSERT ( ip - > i_df . if_broot_bytes = = 0 ) ;
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
}
mp = ip - > i_mount ;
2016-10-03 19:11:29 +03:00
ASSERT ( ! xfs_iflags_test ( ip , XFS_IRECOVERY ) ) ;
2013-08-12 14:49:45 +04:00
/* If this is a read-only mount, don't do this (would generate I/O) */
if ( mp - > m_flags & XFS_MOUNT_RDONLY )
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
2018-03-07 04:08:31 +03:00
/* Try to clean out the cow blocks if there are any. */
2018-07-18 02:51:51 +03:00
if ( xfs_inode_has_cow_data ( ip ) )
2018-03-07 04:08:31 +03:00
xfs_reflink_cancel_cow_range ( ip , 0 , NULLFILEOFF , true ) ;
2016-02-09 08:54:58 +03:00
if ( VFS_I ( ip ) - > i_nlink ! = 0 ) {
2013-08-12 14:49:45 +04:00
/*
* force is true because we are evicting an inode from the
* cache . Post - eof blocks must be freed , lest we end up with
* broken free space accounting .
2017-04-11 20:50:05 +03:00
*
* Note : don ' t bother with iolock here since lockdep complains
* about acquiring it in reclaim context . We have the only
* reference to the inode at this point anyways .
2013-08-12 14:49:45 +04:00
*/
2017-04-11 20:50:05 +03:00
if ( xfs_can_free_eofblocks ( ip , true ) )
2017-01-28 10:22:55 +03:00
xfs_free_eofblocks ( ip ) ;
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
}
2016-02-09 08:54:58 +03:00
if ( S_ISREG ( VFS_I ( ip ) - > i_mode ) & &
2013-08-12 14:49:45 +04:00
( ip - > i_d . di_size ! = 0 | | XFS_ISIZE ( ip ) ! = 0 | |
ip - > i_d . di_nextents > 0 | | ip - > i_delayed_blks > 0 ) )
truncate = 1 ;
2018-05-05 01:30:21 +03:00
error = xfs_qm_dqattach ( ip ) ;
2013-08-12 14:49:45 +04:00
if ( error )
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
2016-02-09 08:54:58 +03:00
if ( S_ISLNK ( VFS_I ( ip ) - > i_mode ) )
2013-09-20 19:06:09 +04:00
error = xfs_inactive_symlink ( ip ) ;
2013-09-20 19:06:10 +04:00
else if ( truncate )
error = xfs_inactive_truncate ( ip ) ;
if ( error )
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
/*
* If there are attributes associated with the file then blow them away
* now . The code calls a routine that recursively deconstructs the
2015-05-29 00:40:08 +03:00
* attribute fork . If also blows away the in - core attribute fork .
2013-08-12 14:49:45 +04:00
*/
2015-05-29 00:40:08 +03:00
if ( XFS_IFORK_Q ( ip ) ) {
2013-08-12 14:49:45 +04:00
error = xfs_attr_inactive ( ip ) ;
if ( error )
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
}
2015-05-29 00:40:08 +03:00
ASSERT ( ! ip - > i_afp ) ;
2013-08-12 14:49:45 +04:00
ASSERT ( ip - > i_d . di_anextents = = 0 ) ;
2015-05-29 00:40:08 +03:00
ASSERT ( ip - > i_d . di_forkoff = = 0 ) ;
2013-08-12 14:49:45 +04:00
/*
* Free the inode .
*/
2013-09-20 19:06:11 +04:00
error = xfs_inactive_ifree ( ip ) ;
if ( error )
2013-09-20 19:06:12 +04:00
return ;
2013-08-12 14:49:45 +04:00
/*
* Release the dquots held by inode , if any .
*/
xfs_qm_dqdetach ( ip ) ;
}
2019-02-07 21:37:16 +03:00
/*
* In - Core Unlinked List Lookups
* = = = = = = = = = = = = = = = = = = = = = = = = = = = = =
*
* Every inode is supposed to be reachable from some other piece of metadata
* with the exception of the root directory . Inodes with a connection to a
* file descriptor but not linked from anywhere in the on - disk directory tree
* are collectively known as unlinked inodes , though the filesystem itself
* maintains links to these inodes so that on - disk metadata are consistent .
*
* XFS implements a per - AG on - disk hash table of unlinked inodes . The AGI
* header contains a number of buckets that point to an inode , and each inode
* record has a pointer to the next inode in the hash chain . This
* singly - linked list causes scaling problems in the iunlink remove function
* because we must walk that list to find the inode that points to the inode
* being removed from the unlinked hash bucket list .
*
* What if we modelled the unlinked list as a collection of records capturing
* " X.next_unlinked = Y " relations ? If we indexed those records on Y , we ' d
* have a fast way to look up unlinked list predecessors , which avoids the
* slow list walk . That ' s exactly what we do here ( in - core ) with a per - AG
* rhashtable .
*
* Because this is a backref cache , we ignore operational failures since the
* iunlink code can fall back to the slow bucket walk . The only errors that
* should bubble out are for obviously incorrect situations .
*
* All users of the backref cache MUST hold the AGI buffer lock to serialize
* access or have otherwise provided for concurrency control .
*/
/* Capture a "X.next_unlinked = Y" relationship. */
struct xfs_iunlink {
struct rhash_head iu_rhash_head ;
xfs_agino_t iu_agino ; /* X */
xfs_agino_t iu_next_unlinked ; /* Y */
} ;
/* Unlinked list predecessor lookup hashtable construction */
static int
xfs_iunlink_obj_cmpfn (
struct rhashtable_compare_arg * arg ,
const void * obj )
{
const xfs_agino_t * key = arg - > key ;
const struct xfs_iunlink * iu = obj ;
if ( iu - > iu_next_unlinked ! = * key )
return 1 ;
return 0 ;
}
static const struct rhashtable_params xfs_iunlink_hash_params = {
. min_size = XFS_AGI_UNLINKED_BUCKETS ,
. key_len = sizeof ( xfs_agino_t ) ,
. key_offset = offsetof ( struct xfs_iunlink ,
iu_next_unlinked ) ,
. head_offset = offsetof ( struct xfs_iunlink , iu_rhash_head ) ,
. automatic_shrinking = true ,
. obj_cmpfn = xfs_iunlink_obj_cmpfn ,
} ;
/*
* Return X , where X . next_unlinked = = @ agino . Returns NULLAGINO if no such
* relation is found .
*/
static xfs_agino_t
xfs_iunlink_lookup_backref (
struct xfs_perag * pag ,
xfs_agino_t agino )
{
struct xfs_iunlink * iu ;
iu = rhashtable_lookup_fast ( & pag - > pagi_unlinked_hash , & agino ,
xfs_iunlink_hash_params ) ;
return iu ? iu - > iu_agino : NULLAGINO ;
}
/*
* Take ownership of an iunlink cache entry and insert it into the hash table .
* If successful , the entry will be owned by the cache ; if not , it is freed .
* Either way , the caller does not own @ iu after this call .
*/
static int
xfs_iunlink_insert_backref (
struct xfs_perag * pag ,
struct xfs_iunlink * iu )
{
int error ;
error = rhashtable_insert_fast ( & pag - > pagi_unlinked_hash ,
& iu - > iu_rhash_head , xfs_iunlink_hash_params ) ;
/*
* Fail loudly if there already was an entry because that ' s a sign of
* corruption of in - memory data . Also fail loudly if we see an error
* code we didn ' t anticipate from the rhashtable code . Currently we
* only anticipate ENOMEM .
*/
if ( error ) {
WARN ( error ! = - ENOMEM , " iunlink cache insert error %d " , error ) ;
kmem_free ( iu ) ;
}
/*
* Absorb any runtime errors that aren ' t a result of corruption because
* this is a cache and we can always fall back to bucket list scanning .
*/
if ( error ! = 0 & & error ! = - EEXIST )
error = 0 ;
return error ;
}
/* Remember that @prev_agino.next_unlinked = @this_agino. */
static int
xfs_iunlink_add_backref (
struct xfs_perag * pag ,
xfs_agino_t prev_agino ,
xfs_agino_t this_agino )
{
struct xfs_iunlink * iu ;
if ( XFS_TEST_ERROR ( false , pag - > pag_mount , XFS_ERRTAG_IUNLINK_FALLBACK ) )
return 0 ;
2019-08-26 22:06:22 +03:00
iu = kmem_zalloc ( sizeof ( * iu ) , KM_NOFS ) ;
2019-02-07 21:37:16 +03:00
iu - > iu_agino = prev_agino ;
iu - > iu_next_unlinked = this_agino ;
return xfs_iunlink_insert_backref ( pag , iu ) ;
}
/*
* Replace X . next_unlinked = @ agino with X . next_unlinked = @ next_unlinked .
* If @ next_unlinked is NULLAGINO , we drop the backref and exit . If there
* wasn ' t any such entry then we don ' t bother .
*/
static int
xfs_iunlink_change_backref (
struct xfs_perag * pag ,
xfs_agino_t agino ,
xfs_agino_t next_unlinked )
{
struct xfs_iunlink * iu ;
int error ;
/* Look up the old entry; if there wasn't one then exit. */
iu = rhashtable_lookup_fast ( & pag - > pagi_unlinked_hash , & agino ,
xfs_iunlink_hash_params ) ;
if ( ! iu )
return 0 ;
/*
* Remove the entry . This shouldn ' t ever return an error , but if we
* couldn ' t remove the old entry we don ' t want to add it again to the
* hash table , and if the entry disappeared on us then someone ' s
* violated the locking rules and we need to fail loudly . Either way
* we cannot remove the inode because internal state is or would have
* been corrupt .
*/
error = rhashtable_remove_fast ( & pag - > pagi_unlinked_hash ,
& iu - > iu_rhash_head , xfs_iunlink_hash_params ) ;
if ( error )
return error ;
/* If there is no new next entry just free our item and return. */
if ( next_unlinked = = NULLAGINO ) {
kmem_free ( iu ) ;
return 0 ;
}
/* Update the entry and re-add it to the hash table. */
iu - > iu_next_unlinked = next_unlinked ;
return xfs_iunlink_insert_backref ( pag , iu ) ;
}
/* Set up the in-core predecessor structures. */
int
xfs_iunlink_init (
struct xfs_perag * pag )
{
return rhashtable_init ( & pag - > pagi_unlinked_hash ,
& xfs_iunlink_hash_params ) ;
}
/* Free the in-core predecessor structures. */
static void
xfs_iunlink_free_item (
void * ptr ,
void * arg )
{
struct xfs_iunlink * iu = ptr ;
bool * freed_anything = arg ;
* freed_anything = true ;
kmem_free ( iu ) ;
}
void
xfs_iunlink_destroy (
struct xfs_perag * pag )
{
bool freed_anything = false ;
rhashtable_free_and_destroy ( & pag - > pagi_unlinked_hash ,
xfs_iunlink_free_item , & freed_anything ) ;
ASSERT ( freed_anything = = false | | XFS_FORCED_SHUTDOWN ( pag - > pag_mount ) ) ;
}
2019-02-07 21:37:14 +03:00
/*
* Point the AGI unlinked bucket at an inode and log the results . The caller
* is responsible for validating the old value .
*/
STATIC int
xfs_iunlink_update_bucket (
struct xfs_trans * tp ,
xfs_agnumber_t agno ,
struct xfs_buf * agibp ,
unsigned int bucket_index ,
xfs_agino_t new_agino )
{
2020-03-10 18:57:29 +03:00
struct xfs_agi * agi = agibp - > b_addr ;
2019-02-07 21:37:14 +03:00
xfs_agino_t old_value ;
int offset ;
ASSERT ( xfs_verify_agino_or_null ( tp - > t_mountp , agno , new_agino ) ) ;
old_value = be32_to_cpu ( agi - > agi_unlinked [ bucket_index ] ) ;
trace_xfs_iunlink_update_bucket ( tp - > t_mountp , agno , bucket_index ,
old_value , new_agino ) ;
/*
* We should never find the head of the list already set to the value
* passed in because either we ' re adding or removing ourselves from the
* head of the list .
*/
2019-11-02 19:40:53 +03:00
if ( old_value = = new_agino ) {
2020-03-11 20:37:54 +03:00
xfs_buf_mark_corrupt ( agibp ) ;
2019-02-07 21:37:14 +03:00
return - EFSCORRUPTED ;
2019-11-02 19:40:53 +03:00
}
2019-02-07 21:37:14 +03:00
agi - > agi_unlinked [ bucket_index ] = cpu_to_be32 ( new_agino ) ;
offset = offsetof ( struct xfs_agi , agi_unlinked ) +
( sizeof ( xfs_agino_t ) * bucket_index ) ;
xfs_trans_log_buf ( tp , agibp , offset , offset + sizeof ( xfs_agino_t ) - 1 ) ;
return 0 ;
}
2019-02-07 21:37:15 +03:00
/* Set an on-disk inode's next_unlinked pointer. */
STATIC void
xfs_iunlink_update_dinode (
struct xfs_trans * tp ,
xfs_agnumber_t agno ,
xfs_agino_t agino ,
struct xfs_buf * ibp ,
struct xfs_dinode * dip ,
struct xfs_imap * imap ,
xfs_agino_t next_agino )
{
struct xfs_mount * mp = tp - > t_mountp ;
int offset ;
ASSERT ( xfs_verify_agino_or_null ( mp , agno , next_agino ) ) ;
trace_xfs_iunlink_update_dinode ( mp , agno , agino ,
be32_to_cpu ( dip - > di_next_unlinked ) , next_agino ) ;
dip - > di_next_unlinked = cpu_to_be32 ( next_agino ) ;
offset = imap - > im_boffset +
offsetof ( struct xfs_dinode , di_next_unlinked ) ;
/* need to recalc the inode CRC if appropriate */
xfs_dinode_calc_crc ( mp , dip ) ;
xfs_trans_inode_buf ( tp , ibp ) ;
xfs_trans_log_buf ( tp , ibp , offset , offset + sizeof ( xfs_agino_t ) - 1 ) ;
xfs_inobp_check ( mp , ibp ) ;
}
/* Set an in-core inode's unlinked pointer and return the old value. */
STATIC int
xfs_iunlink_update_inode (
struct xfs_trans * tp ,
struct xfs_inode * ip ,
xfs_agnumber_t agno ,
xfs_agino_t next_agino ,
xfs_agino_t * old_next_agino )
{
struct xfs_mount * mp = tp - > t_mountp ;
struct xfs_dinode * dip ;
struct xfs_buf * ibp ;
xfs_agino_t old_value ;
int error ;
ASSERT ( xfs_verify_agino_or_null ( mp , agno , next_agino ) ) ;
error = xfs_imap_to_bp ( mp , tp , & ip - > i_imap , & dip , & ibp , 0 , 0 ) ;
if ( error )
return error ;
/* Make sure the old pointer isn't garbage. */
old_value = be32_to_cpu ( dip - > di_next_unlinked ) ;
if ( ! xfs_verify_agino_or_null ( mp , agno , old_value ) ) {
2019-11-02 19:40:53 +03:00
xfs_inode_verifier_error ( ip , - EFSCORRUPTED , __func__ , dip ,
sizeof ( * dip ) , __this_address ) ;
2019-02-07 21:37:15 +03:00
error = - EFSCORRUPTED ;
goto out ;
}
/*
* Since we ' re updating a linked list , we should never find that the
* current pointer is the same as the new value , unless we ' re
* terminating the list .
*/
* old_next_agino = old_value ;
if ( old_value = = next_agino ) {
2019-11-02 19:40:53 +03:00
if ( next_agino ! = NULLAGINO ) {
xfs_inode_verifier_error ( ip , - EFSCORRUPTED , __func__ ,
dip , sizeof ( * dip ) , __this_address ) ;
2019-02-07 21:37:15 +03:00
error = - EFSCORRUPTED ;
2019-11-02 19:40:53 +03:00
}
2019-02-07 21:37:15 +03:00
goto out ;
}
/* Ok, update the new pointer. */
xfs_iunlink_update_dinode ( tp , agno , XFS_INO_TO_AGINO ( mp , ip - > i_ino ) ,
ibp , dip , & ip - > i_imap , next_agino ) ;
return 0 ;
out :
xfs_trans_brelse ( tp , ibp ) ;
return error ;
}
2005-04-17 02:20:36 +04:00
/*
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-13 22:15:17 +03:00
* This is called when the inode ' s link count has gone to 0 or we are creating
* a tmpfile via O_TMPFILE . The inode @ ip must have nlink = = 0.
2016-02-09 08:54:58 +03:00
*
* We place the on - disk inode on a list in the AGI . It will be pulled from this
* list when the inode is freed .
2005-04-17 02:20:36 +04:00
*/
2016-02-09 08:54:58 +03:00
STATIC int
2005-04-17 02:20:36 +04:00
xfs_iunlink (
2019-02-07 21:37:13 +03:00
struct xfs_trans * tp ,
struct xfs_inode * ip )
2005-04-17 02:20:36 +04:00
{
2019-02-07 21:37:13 +03:00
struct xfs_mount * mp = tp - > t_mountp ;
struct xfs_agi * agi ;
struct xfs_buf * agibp ;
2019-02-07 21:37:14 +03:00
xfs_agino_t next_agino ;
2019-02-07 21:37:13 +03:00
xfs_agnumber_t agno = XFS_INO_TO_AGNO ( mp , ip - > i_ino ) ;
xfs_agino_t agino = XFS_INO_TO_AGINO ( mp , ip - > i_ino ) ;
short bucket_index = agino % XFS_AGI_UNLINKED_BUCKETS ;
int error ;
2005-04-17 02:20:36 +04:00
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-13 22:15:17 +03:00
ASSERT ( VFS_I ( ip ) - > i_nlink = = 0 ) ;
2016-02-09 08:54:58 +03:00
ASSERT ( VFS_I ( ip ) - > i_mode ! = 0 ) ;
2019-02-07 21:37:16 +03:00
trace_xfs_iunlink ( ip ) ;
2005-04-17 02:20:36 +04:00
2019-02-07 21:37:13 +03:00
/* Get the agi buffer first. It ensures lock ordering on the list. */
error = xfs_read_agi ( mp , tp , agno , & agibp ) ;
2007-10-11 11:44:18 +04:00
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
2020-03-10 18:57:29 +03:00
agi = agibp - > b_addr ;
2008-11-28 06:23:37 +03:00
2005-04-17 02:20:36 +04:00
/*
2019-02-07 21:37:14 +03:00
* Get the index into the agi hash table for the list this inode will
* go on . Make sure the pointer isn ' t garbage and that this inode
* isn ' t already on the list .
2005-04-17 02:20:36 +04:00
*/
2019-02-07 21:37:14 +03:00
next_agino = be32_to_cpu ( agi - > agi_unlinked [ bucket_index ] ) ;
if ( next_agino = = agino | |
2019-11-02 19:40:53 +03:00
! xfs_verify_agino_or_null ( mp , agno , next_agino ) ) {
2020-03-11 20:37:54 +03:00
xfs_buf_mark_corrupt ( agibp ) ;
2019-02-07 21:37:14 +03:00
return - EFSCORRUPTED ;
2019-11-02 19:40:53 +03:00
}
2005-04-17 02:20:36 +04:00
2019-02-07 21:37:14 +03:00
if ( next_agino ! = NULLAGINO ) {
2019-02-07 21:37:16 +03:00
struct xfs_perag * pag ;
xfs_agino_t old_agino ;
2019-02-07 21:37:15 +03:00
2005-04-17 02:20:36 +04:00
/*
2019-02-07 21:37:15 +03:00
* There is already another inode in the bucket , so point this
* inode to the current head of the list .
2005-04-17 02:20:36 +04:00
*/
2019-02-07 21:37:15 +03:00
error = xfs_iunlink_update_inode ( tp , ip , agno , next_agino ,
& old_agino ) ;
2007-11-23 08:27:51 +03:00
if ( error )
return error ;
2019-02-07 21:37:15 +03:00
ASSERT ( old_agino = = NULLAGINO ) ;
2019-02-07 21:37:16 +03:00
/*
* agino has been unlinked , add a backref from the next inode
* back to agino .
*/
pag = xfs_perag_get ( mp , agno ) ;
error = xfs_iunlink_add_backref ( pag , agino , next_agino ) ;
xfs_perag_put ( pag ) ;
if ( error )
return error ;
2005-04-17 02:20:36 +04:00
}
2019-02-07 21:37:14 +03:00
/* Point the head of the list to point to this inode. */
return xfs_iunlink_update_bucket ( tp , agno , agibp , bucket_index , agino ) ;
2005-04-17 02:20:36 +04:00
}
2019-02-07 21:37:15 +03:00
/* Return the imap, dinode pointer, and buffer for an inode. */
STATIC int
xfs_iunlink_map_ino (
struct xfs_trans * tp ,
xfs_agnumber_t agno ,
xfs_agino_t agino ,
struct xfs_imap * imap ,
struct xfs_dinode * * dipp ,
struct xfs_buf * * bpp )
{
struct xfs_mount * mp = tp - > t_mountp ;
int error ;
imap - > im_blkno = 0 ;
error = xfs_imap ( mp , tp , XFS_AGINO_TO_INO ( mp , agno , agino ) , imap , 0 ) ;
if ( error ) {
xfs_warn ( mp , " %s: xfs_imap returned error %d. " ,
__func__ , error ) ;
return error ;
}
error = xfs_imap_to_bp ( mp , tp , imap , dipp , bpp , 0 , 0 ) ;
if ( error ) {
xfs_warn ( mp , " %s: xfs_imap_to_bp returned error %d. " ,
__func__ , error ) ;
return error ;
}
return 0 ;
}
/*
* Walk the unlinked chain from @ head_agino until we find the inode that
* points to @ target_agino . Return the inode number , map , dinode pointer ,
* and inode cluster buffer of that inode as @ agino , @ imap , @ dipp , and @ bpp .
*
* @ tp , @ pag , @ head_agino , and @ target_agino are input parameters .
* @ agino , @ imap , @ dipp , and @ bpp are all output parameters .
*
* Do not call this function if @ target_agino is the head of the list .
*/
STATIC int
xfs_iunlink_map_prev (
struct xfs_trans * tp ,
xfs_agnumber_t agno ,
xfs_agino_t head_agino ,
xfs_agino_t target_agino ,
xfs_agino_t * agino ,
struct xfs_imap * imap ,
struct xfs_dinode * * dipp ,
2019-02-07 21:37:16 +03:00
struct xfs_buf * * bpp ,
struct xfs_perag * pag )
2019-02-07 21:37:15 +03:00
{
struct xfs_mount * mp = tp - > t_mountp ;
xfs_agino_t next_agino ;
int error ;
ASSERT ( head_agino ! = target_agino ) ;
* bpp = NULL ;
2019-02-07 21:37:16 +03:00
/* See if our backref cache can find it faster. */
* agino = xfs_iunlink_lookup_backref ( pag , target_agino ) ;
if ( * agino ! = NULLAGINO ) {
error = xfs_iunlink_map_ino ( tp , agno , * agino , imap , dipp , bpp ) ;
if ( error )
return error ;
if ( be32_to_cpu ( ( * dipp ) - > di_next_unlinked ) = = target_agino )
return 0 ;
/*
* If we get here the cache contents were corrupt , so drop the
* buffer and fall back to walking the bucket list .
*/
xfs_trans_brelse ( tp , * bpp ) ;
* bpp = NULL ;
WARN_ON_ONCE ( 1 ) ;
}
trace_xfs_iunlink_map_prev_fallback ( mp , agno ) ;
/* Otherwise, walk the entire bucket until we find it. */
2019-02-07 21:37:15 +03:00
next_agino = head_agino ;
while ( next_agino ! = target_agino ) {
xfs_agino_t unlinked_agino ;
if ( * bpp )
xfs_trans_brelse ( tp , * bpp ) ;
* agino = next_agino ;
error = xfs_iunlink_map_ino ( tp , agno , next_agino , imap , dipp ,
bpp ) ;
if ( error )
return error ;
unlinked_agino = be32_to_cpu ( ( * dipp ) - > di_next_unlinked ) ;
/*
* Make sure this pointer is valid and isn ' t an obvious
* infinite loop .
*/
if ( ! xfs_verify_agino ( mp , agno , unlinked_agino ) | |
next_agino = = unlinked_agino ) {
XFS_CORRUPTION_ERROR ( __func__ ,
XFS_ERRLEVEL_LOW , mp ,
* dipp , sizeof ( * * dipp ) ) ;
error = - EFSCORRUPTED ;
return error ;
}
next_agino = unlinked_agino ;
}
return 0 ;
}
2005-04-17 02:20:36 +04:00
/*
* Pull the on - disk inode from the AGI unlinked list .
*/
STATIC int
xfs_iunlink_remove (
2019-02-07 21:37:13 +03:00
struct xfs_trans * tp ,
struct xfs_inode * ip )
2005-04-17 02:20:36 +04:00
{
2019-02-07 21:37:13 +03:00
struct xfs_mount * mp = tp - > t_mountp ;
struct xfs_agi * agi ;
struct xfs_buf * agibp ;
struct xfs_buf * last_ibp ;
struct xfs_dinode * last_dip = NULL ;
2019-02-07 21:37:16 +03:00
struct xfs_perag * pag = NULL ;
2019-02-07 21:37:13 +03:00
xfs_agnumber_t agno = XFS_INO_TO_AGNO ( mp , ip - > i_ino ) ;
xfs_agino_t agino = XFS_INO_TO_AGINO ( mp , ip - > i_ino ) ;
xfs_agino_t next_agino ;
2019-02-07 21:37:15 +03:00
xfs_agino_t head_agino ;
2019-02-07 21:37:13 +03:00
short bucket_index = agino % XFS_AGI_UNLINKED_BUCKETS ;
int error ;
2005-04-17 02:20:36 +04:00
2019-02-07 21:37:16 +03:00
trace_xfs_iunlink_remove ( ip ) ;
2019-02-07 21:37:13 +03:00
/* Get the agi buffer first. It ensures lock ordering on the list. */
2008-11-28 06:23:37 +03:00
error = xfs_read_agi ( mp , tp , agno , & agibp ) ;
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
2020-03-10 18:57:29 +03:00
agi = agibp - > b_addr ;
2008-11-28 06:23:37 +03:00
2005-04-17 02:20:36 +04:00
/*
2019-02-07 21:37:14 +03:00
* Get the index into the agi hash table for the list this inode will
* go on . Make sure the head pointer isn ' t garbage .
2005-04-17 02:20:36 +04:00
*/
2019-02-07 21:37:15 +03:00
head_agino = be32_to_cpu ( agi - > agi_unlinked [ bucket_index ] ) ;
if ( ! xfs_verify_agino ( mp , agno , head_agino ) ) {
2018-06-04 21:27:51 +03:00
XFS_CORRUPTION_ERROR ( __func__ , XFS_ERRLEVEL_LOW , mp ,
agi , sizeof ( * agi ) ) ;
return - EFSCORRUPTED ;
}
2005-04-17 02:20:36 +04:00
2019-02-07 21:37:15 +03:00
/*
* Set our inode ' s next_unlinked pointer to NULL and then return
* the old pointer value so that we can update whatever was previous
* to us in the list to point to whatever was next in the list .
*/
error = xfs_iunlink_update_inode ( tp , ip , agno , NULLAGINO , & next_agino ) ;
if ( error )
return error ;
2019-02-07 21:37:14 +03:00
2019-02-07 21:37:16 +03:00
/*
* If there was a backref pointing from the next inode back to this
* one , remove it because we ' ve removed this inode from the list .
*
* Later , if this inode was in the middle of the list we ' ll update
* this inode ' s backref to point from the next inode .
*/
if ( next_agino ! = NULLAGINO ) {
pag = xfs_perag_get ( mp , agno ) ;
error = xfs_iunlink_change_backref ( pag , next_agino ,
NULLAGINO ) ;
if ( error )
goto out ;
}
2019-02-07 21:37:15 +03:00
if ( head_agino = = agino ) {
2019-02-07 21:37:14 +03:00
/* Point the head of the list to the next unlinked inode. */
error = xfs_iunlink_update_bucket ( tp , agno , agibp , bucket_index ,
next_agino ) ;
if ( error )
2019-02-07 21:37:16 +03:00
goto out ;
2005-04-17 02:20:36 +04:00
} else {
2019-02-07 21:37:15 +03:00
struct xfs_imap imap ;
xfs_agino_t prev_agino ;
2019-02-07 21:37:16 +03:00
if ( ! pag )
pag = xfs_perag_get ( mp , agno ) ;
2019-02-07 21:37:15 +03:00
/* We need to search the list for the inode being freed. */
2019-02-07 21:37:15 +03:00
error = xfs_iunlink_map_prev ( tp , agno , head_agino , agino ,
2019-02-07 21:37:16 +03:00
& prev_agino , & imap , & last_dip , & last_ibp ,
pag ) ;
2019-02-07 21:37:15 +03:00
if ( error )
2019-02-07 21:37:16 +03:00
goto out ;
2012-07-03 20:21:22 +04:00
2019-02-07 21:37:15 +03:00
/* Point the previous inode on the list to the next inode. */
xfs_iunlink_update_dinode ( tp , agno , prev_agino , last_ibp ,
last_dip , & imap , next_agino ) ;
2019-02-07 21:37:16 +03:00
/*
* Now we deal with the backref for this inode . If this inode
* pointed at a real inode , change the backref that pointed to
* us to point to our old next . If this inode was the end of
* the list , delete the backref that pointed to us . Note that
* change_backref takes care of deleting the backref if
* next_agino is NULLAGINO .
*/
error = xfs_iunlink_change_backref ( pag , agino , next_agino ) ;
if ( error )
goto out ;
2005-04-17 02:20:36 +04:00
}
2019-02-07 21:37:16 +03:00
out :
if ( pag )
xfs_perag_put ( pag ) ;
return error ;
2005-04-17 02:20:36 +04:00
}
2020-03-25 06:10:30 +03:00
/*
* Look up the inode number specified and mark it stale if it is found . If it is
* dirty , return the inode so it can be attached to the cluster buffer so it can
* be processed appropriately when the cluster free transaction completes .
*/
static struct xfs_inode *
xfs_ifree_get_one_inode (
struct xfs_perag * pag ,
struct xfs_inode * free_ip ,
2020-04-02 18:18:57 +03:00
xfs_ino_t inum )
2020-03-25 06:10:30 +03:00
{
struct xfs_mount * mp = pag - > pag_mount ;
struct xfs_inode * ip ;
retry :
rcu_read_lock ( ) ;
ip = radix_tree_lookup ( & pag - > pag_ici_root , XFS_INO_TO_AGINO ( mp , inum ) ) ;
/* Inode not in memory, nothing to do */
if ( ! ip )
goto out_rcu_unlock ;
/*
* because this is an RCU protected lookup , we could find a recently
* freed or even reallocated inode during the lookup . We need to check
* under the i_flags_lock for a valid inode here . Skip it if it is not
* valid , the wrong inode or stale .
*/
spin_lock ( & ip - > i_flags_lock ) ;
if ( ip - > i_ino ! = inum | | __xfs_iflags_test ( ip , XFS_ISTALE ) ) {
spin_unlock ( & ip - > i_flags_lock ) ;
goto out_rcu_unlock ;
}
spin_unlock ( & ip - > i_flags_lock ) ;
/*
* Don ' t try to lock / unlock the current inode , but we _cannot_ skip the
* other inodes that we did not find in the list attached to the buffer
* and are not already marked stale . If we can ' t lock it , back off and
* retry .
*/
if ( ip ! = free_ip ) {
if ( ! xfs_ilock_nowait ( ip , XFS_ILOCK_EXCL ) ) {
rcu_read_unlock ( ) ;
delay ( 1 ) ;
goto retry ;
}
/*
* Check the inode number again in case we ' re racing with
* freeing in xfs_reclaim_inode ( ) . See the comments in that
* function for more information as to why the initial check is
* not sufficient .
*/
if ( ip - > i_ino ! = inum ) {
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
goto out_rcu_unlock ;
}
}
rcu_read_unlock ( ) ;
xfs_iflock ( ip ) ;
xfs_iflags_set ( ip , XFS_ISTALE ) ;
/*
* We don ' t need to attach clean inodes or those only with unlogged
* changes ( which we throw away , anyway ) .
*/
if ( ! ip - > i_itemp | | xfs_inode_clean ( ip ) ) {
ASSERT ( ip ! = free_ip ) ;
xfs_ifunlock ( ip ) ;
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
goto out_no_inode ;
}
return ip ;
out_rcu_unlock :
rcu_read_unlock ( ) ;
out_no_inode :
return NULL ;
}
2010-08-24 05:42:41 +04:00
/*
2013-08-12 07:14:59 +04:00
* A big issue when freeing the inode cluster is that we _cannot_ skip any
2010-08-24 05:42:41 +04:00
* inodes that are in memory - they all must be marked stale and attached to
* the cluster buffer .
*/
2011-09-20 17:56:55 +04:00
STATIC int
2005-04-17 02:20:36 +04:00
xfs_ifree_cluster (
2015-05-29 02:26:03 +03:00
xfs_inode_t * free_ip ,
xfs_trans_t * tp ,
struct xfs_icluster * xic )
2005-04-17 02:20:36 +04:00
{
xfs_mount_t * mp = free_ip - > i_mount ;
int nbufs ;
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
int i , j ;
2015-06-04 06:03:34 +03:00
int ioffset ;
2005-04-17 02:20:36 +04:00
xfs_daddr_t blkno ;
xfs_buf_t * bp ;
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
xfs_inode_t * ip ;
2005-04-17 02:20:36 +04:00
xfs_inode_log_item_t * iip ;
2018-01-25 00:38:49 +03:00
struct xfs_log_item * lip ;
2010-01-11 14:47:40 +03:00
struct xfs_perag * pag ;
2019-06-05 21:19:34 +03:00
struct xfs_ino_geometry * igeo = M_IGEO ( mp ) ;
2015-05-29 02:26:03 +03:00
xfs_ino_t inum ;
2020-01-24 04:01:18 +03:00
int error ;
2005-04-17 02:20:36 +04:00
2015-05-29 02:26:03 +03:00
inum = xic - > first_ino ;
2010-01-11 14:47:40 +03:00
pag = xfs_perag_get ( mp , XFS_INO_TO_AGNO ( mp , inum ) ) ;
2019-06-05 21:19:34 +03:00
nbufs = igeo - > ialloc_blks / igeo - > blocks_per_cluster ;
2005-04-17 02:20:36 +04:00
2019-06-05 21:19:34 +03:00
for ( j = 0 ; j < nbufs ; j + + , inum + = igeo - > inodes_per_cluster ) {
2015-05-29 02:26:03 +03:00
/*
* The allocation bitmap tells us which inodes of the chunk were
* physically allocated . Skip the cluster if an inode falls into
* a sparse region .
*/
2015-06-04 06:03:34 +03:00
ioffset = inum - xic - > first_ino ;
if ( ( xic - > alloc & XFS_INOBT_MASK ( ioffset ) ) = = 0 ) {
2019-06-05 21:19:34 +03:00
ASSERT ( ioffset % igeo - > inodes_per_cluster = = 0 ) ;
2015-05-29 02:26:03 +03:00
continue ;
}
2005-04-17 02:20:36 +04:00
blkno = XFS_AGB_TO_DADDR ( mp , XFS_INO_TO_AGNO ( mp , inum ) ,
XFS_INO_TO_AGBNO ( mp , inum ) ) ;
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
/*
* We obtain and lock the backing buffer first in the process
* here , as we have to ensure that any dirty inode that we
* can ' t get the flush lock on is attached to the buffer .
* If we scan the in - memory inodes first , then buffer IO can
* complete before we get a lock on it , and hence we may fail
* to mark all the active inodes on the buffer stale .
*/
2020-01-24 04:01:18 +03:00
error = xfs_trans_get_buf ( tp , mp - > m_ddev_targp , blkno ,
mp - > m_bsize * igeo - > blocks_per_cluster ,
XBF_UNMAPPED , & bp ) ;
if ( error )
return error ;
2012-11-14 10:53:49 +04:00
/*
* This buffer may not have been correctly initialised as we
* didn ' t read it from disk . That ' s not important because we are
* only using to mark the buffer as stale in the log , and to
* attach stale cached inodes on it . That means it will never be
* dispatched for IO . If it is , we want to know about it , and we
* want it to fail . We can acheive this by adding a write
* verifier to the buffer .
*/
2018-12-12 19:46:20 +03:00
bp - > b_ops = & xfs_inode_buf_ops ;
2012-11-14 10:53:49 +04:00
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
/*
* Walk the inodes already attached to the buffer and mark them
* stale . These will all have the flush locks held , so an
2010-08-24 05:42:41 +04:00
* in - memory inode walk can ' t lock them . By marking them all
* stale first , we will not attempt to lock them in the loop
* below as the XFS_ISTALE flag will be set .
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
*/
2018-01-25 00:38:49 +03:00
list_for_each_entry ( lip , & bp - > b_li_list , li_bio_list ) {
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
if ( lip - > li_type = = XFS_LI_INODE ) {
iip = ( xfs_inode_log_item_t * ) lip ;
ASSERT ( iip - > ili_logged = = 1 ) ;
2010-06-23 12:11:15 +04:00
lip - > li_cb = xfs_istale_done ;
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
xfs_trans_ail_copy_lsn ( mp - > m_ail ,
& iip - > ili_flush_lsn ,
& iip - > ili_item . li_lsn ) ;
xfs_iflags_set ( iip - > ili_inode , XFS_ISTALE ) ;
}
}
2005-04-17 02:20:36 +04:00
2010-08-24 05:42:41 +04:00
2005-04-17 02:20:36 +04:00
/*
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
* For each inode in memory attempt to add it to the inode
* buffer and set it up for being staled on buffer IO
* completion . This is safe as we ' ve locked out tail pushing
* and flushing by locking the buffer .
2005-04-17 02:20:36 +04:00
*
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
* We have already marked every inode that was part of a
* transaction stale above , which means there is no point in
* even trying to lock them .
2005-04-17 02:20:36 +04:00
*/
2019-06-05 21:19:34 +03:00
for ( i = 0 ; i < igeo - > inodes_per_cluster ; i + + ) {
2020-03-25 06:10:30 +03:00
ip = xfs_ifree_get_one_inode ( pag , free_ip , inum + i ) ;
if ( ! ip )
2005-04-17 02:20:36 +04:00
continue ;
iip = ip - > i_itemp ;
2012-02-29 13:53:54 +04:00
iip - > ili_last_fields = iip - > ili_fields ;
iip - > ili_fields = 0 ;
xfs: optimise away log forces on timestamp updates for fdatasync
xfs: timestamp updates cause excessive fdatasync log traffic
Sage Weil reported that a ceph test workload was writing to the
log on every fdatasync during an overwrite workload. Event tracing
showed that the only metadata modification being made was the
timestamp updates during the write(2) syscall, but fdatasync(2)
is supposed to ignore them. The key observation was that the
transactions in the log all looked like this:
INODE: #regs: 4 ino: 0x8b flags: 0x45 dsize: 32
And contained a flags field of 0x45 or 0x85, and had data and
attribute forks following the inode core. This means that the
timestamp updates were triggering dirty relogging of previously
logged parts of the inode that hadn't yet been flushed back to
disk.
There are two parts to this problem. The first is that XFS relogs
dirty regions in subsequent transactions, so it carries around the
fields that have been dirtied since the last time the inode was
written back to disk, not since the last time the inode was forced
into the log.
The second part is that on v5 filesystems, the inode change count
update during inode dirtying also sets the XFS_ILOG_CORE flag, so
on v5 filesystems this makes a timestamp update dirty the entire
inode.
As a result when fdatasync is run, it looks at the dirty fields in
the inode, and sees more than just the timestamp flag, even though
the only metadata change since the last fdatasync was just the
timestamps. Hence we force the log on every subsequent fdatasync
even though it is not needed.
To fix this, add a new field to the inode log item that tracks
changes since the last time fsync/fdatasync forced the log to flush
the changes to the journal. This flag is updated when we dirty the
inode, but we do it before updating the change count so it does not
carry the "core dirty" flag from timestamp updates. The fields are
zeroed when the inode is marked clean (due to writeback/freeing) or
when an fsync/datasync forces the log. Hence if we only dirty the
timestamps on the inode between fsync/fdatasync calls, the fdatasync
will not trigger another log force.
Over 100 runs of the test program:
Ext4 baseline:
runtime: 1.63s +/- 0.24s
avg lat: 1.59ms +/- 0.24ms
iops: ~2000
XFS, vanilla kernel:
runtime: 2.45s +/- 0.18s
avg lat: 2.39ms +/- 0.18ms
log forces: ~400/s
iops: ~1000
XFS, patched kernel:
runtime: 1.49s +/- 0.26s
avg lat: 1.46ms +/- 0.25ms
log forces: ~30/s
iops: ~1500
Reported-by: Sage Weil <sage@redhat.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-11-03 05:14:59 +03:00
iip - > ili_fsync_fields = 0 ;
2005-04-17 02:20:36 +04:00
iip - > ili_logged = 1 ;
2008-10-30 09:39:12 +03:00
xfs_trans_ail_copy_lsn ( mp - > m_ail , & iip - > ili_flush_lsn ,
& iip - > ili_item . li_lsn ) ;
2005-04-17 02:20:36 +04:00
2010-06-23 12:11:15 +04:00
xfs_buf_attach_iodone ( bp , xfs_istale_done ,
& iip - > ili_item ) ;
xfs: fix race in inode cluster freeing failing to stale inodes
When an inode cluster is freed, it needs to mark all inodes in memory as
XFS_ISTALE before marking the buffer as stale. This is eeded because the inodes
have a different life cycle to the buffer, and once the buffer is torn down
during transaction completion, we must ensure none of the inodes get written
back (which is what XFS_ISTALE does).
Unfortunately, xfs_ifree_cluster() has some bugs that lead to inodes not being
marked with XFS_ISTALE. This shows up when xfs_iflush() is called on these
inodes either during inode reclaim or tail pushing on the AIL. The buffer is
read back, but no longer contains inodes and so triggers assert failures and
shutdowns. This was reproducable with at run.dbench10 invocation from xfstests.
There are two main causes of xfs_ifree_cluster() failing. The first is simple -
it checks in-memory inodes it finds in the per-ag icache to see if they are
clean without holding the flush lock. if they are clean it skips them
completely. However, If an inode is flushed delwri, it will
appear clean, but is not guaranteed to be written back until the flush lock has
been dropped. Hence we may have raced on the clean check and the inode may
actually be dirty. Hence always mark inodes found in memory stale before we
check properly if they are clean.
The second is more complex, and makes the first problem easier to hit.
Basically the in-memory inode scan is done with full knowledge it can be racing
with inode flushing and AIl tail pushing, which means that inodes that it can't
get the flush lock on might not be attached to the buffer after then in-memory
inode scan due to IO completion occurring. This is actually documented in the
code as "needs better interlocking". i.e. this is a zero-day bug.
Effectively, the in-memory scan must be done while the inode buffer is locked
and Io cannot be issued on it while we do the in-memory inode scan. This
ensures that inodes we couldn't get the flush lock on are guaranteed to be
attached to the cluster buffer, so we can then catch all in-memory inodes and
mark them stale.
Now that the inode cluster buffer is locked before the in-memory scan is done,
there is no need for the two-phase update of the in-memory inodes, so simplify
the code into two loops and remove the allocation of the temporary buffer used
to hold locked inodes across the phases.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2010-06-03 10:22:29 +04:00
if ( ip ! = free_ip )
2005-04-17 02:20:36 +04:00
xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ;
}
2010-08-24 05:42:41 +04:00
xfs_trans_stale_inode_buf ( tp , bp ) ;
2005-04-17 02:20:36 +04:00
xfs_trans_binval ( tp , bp ) ;
}
2010-01-11 14:47:40 +03:00
xfs_perag_put ( pag ) ;
2011-09-20 17:56:55 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
2017-11-22 23:21:07 +03:00
/*
* Free any local - format buffers sitting around before we reset to
* extents format .
*/
static inline void
xfs_ifree_local_data (
struct xfs_inode * ip ,
int whichfork )
{
struct xfs_ifork * ifp ;
if ( XFS_IFORK_FORMAT ( ip , whichfork ) ! = XFS_DINODE_FMT_LOCAL )
return ;
ifp = XFS_IFORK_PTR ( ip , whichfork ) ;
xfs_idata_realloc ( ip , - ifp - > if_bytes , whichfork ) ;
}
2005-04-17 02:20:36 +04:00
/*
* This is called to return an inode to the inode free list .
* The inode should already be truncated to 0 length and have
* no pages associated with it . This routine also assumes that
* the inode is already a part of the transaction .
*
* The on - disk copy of the inode will have been added to the list
* of unlinked inodes in the AGI . We need to remove the inode from
* that list atomically with respect to freeing it here .
*/
int
xfs_ifree (
2018-07-12 08:26:07 +03:00
struct xfs_trans * tp ,
struct xfs_inode * ip )
2005-04-17 02:20:36 +04:00
{
int error ;
2015-05-29 02:26:03 +03:00
struct xfs_icluster xic = { 0 } ;
2005-04-17 02:20:36 +04:00
2008-04-22 11:34:00 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL ) ) ;
2016-02-09 08:54:58 +03:00
ASSERT ( VFS_I ( ip ) - > i_nlink = = 0 ) ;
2005-04-17 02:20:36 +04:00
ASSERT ( ip - > i_d . di_nextents = = 0 ) ;
ASSERT ( ip - > i_d . di_anextents = = 0 ) ;
2016-02-09 08:54:58 +03:00
ASSERT ( ip - > i_d . di_size = = 0 | | ! S_ISREG ( VFS_I ( ip ) - > i_mode ) ) ;
2005-04-17 02:20:36 +04:00
ASSERT ( ip - > i_d . di_nblocks = = 0 ) ;
/*
* Pull the on - disk inode from the AGI unlinked list .
*/
error = xfs_iunlink_remove ( tp , ip ) ;
2013-06-27 10:04:50 +04:00
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
2018-07-12 08:26:07 +03:00
error = xfs_difree ( tp , ip - > i_ino , & xic ) ;
2013-06-27 10:04:50 +04:00
if ( error )
2005-04-17 02:20:36 +04:00
return error ;
2013-06-27 10:04:50 +04:00
2017-11-22 23:21:07 +03:00
xfs_ifree_local_data ( ip , XFS_DATA_FORK ) ;
xfs_ifree_local_data ( ip , XFS_ATTR_FORK ) ;
2016-02-09 08:54:58 +03:00
VFS_I ( ip ) - > i_mode = 0 ; /* mark incore inode as free */
2005-04-17 02:20:36 +04:00
ip - > i_d . di_flags = 0 ;
2018-01-23 06:19:26 +03:00
ip - > i_d . di_flags2 = 0 ;
2005-04-17 02:20:36 +04:00
ip - > i_d . di_dmevmask = 0 ;
ip - > i_d . di_forkoff = 0 ; /* mark the attr fork not in use */
ip - > i_d . di_format = XFS_DINODE_FMT_EXTENTS ;
ip - > i_d . di_aformat = XFS_DINODE_FMT_EXTENTS ;
2018-03-29 03:48:08 +03:00
/* Don't attempt to replay owner changes for a deleted inode */
ip - > i_itemp - > ili_fields & = ~ ( XFS_ILOG_AOWNER | XFS_ILOG_DOWNER ) ;
2005-04-17 02:20:36 +04:00
/*
* Bump the generation count so no one will be confused
* by reincarnations of this inode .
*/
2016-02-09 08:54:58 +03:00
VFS_I ( ip ) - > i_generation + + ;
2005-04-17 02:20:36 +04:00
xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ;
2015-05-29 02:26:03 +03:00
if ( xic . deleted )
error = xfs_ifree_cluster ( ip , tp , & xic ) ;
2005-04-17 02:20:36 +04:00
2011-09-20 17:56:55 +04:00
return error ;
2005-04-17 02:20:36 +04:00
}
/*
2010-02-17 22:43:56 +03:00
* This is called to unpin an inode . The caller must have the inode locked
* in at least shared mode so that the buffer cannot be subsequently pinned
* once someone is waiting for it to be unpinned .
2005-04-17 02:20:36 +04:00
*/
2010-02-17 22:43:56 +03:00
static void
2011-12-19 00:00:10 +04:00
xfs_iunpin (
2010-02-17 22:43:56 +03:00
struct xfs_inode * ip )
2005-04-17 02:20:36 +04:00
{
2008-04-22 11:34:00 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL | XFS_ILOCK_SHARED ) ) ;
2005-04-17 02:20:36 +04:00
2010-03-08 03:24:07 +03:00
trace_xfs_inode_unpin_nowait ( ip , _RET_IP_ ) ;
2008-03-06 05:43:42 +03:00
/* Give the log a push to start the unpinning I/O */
2018-03-14 09:15:28 +03:00
xfs_log_force_lsn ( ip - > i_mount , ip - > i_itemp - > ili_last_lsn , 0 , NULL ) ;
2010-01-19 12:56:46 +03:00
2008-03-06 05:43:42 +03:00
}
2005-04-17 02:20:36 +04:00
2011-12-19 00:00:10 +04:00
static void
__xfs_iunpin_wait (
struct xfs_inode * ip )
{
wait_queue_head_t * wq = bit_waitqueue ( & ip - > i_flags , __XFS_IPINNED_BIT ) ;
DEFINE_WAIT_BIT ( wait , & ip - > i_flags , __XFS_IPINNED_BIT ) ;
xfs_iunpin ( ip ) ;
do {
2017-03-05 13:25:39 +03:00
prepare_to_wait ( wq , & wait . wq_entry , TASK_UNINTERRUPTIBLE ) ;
2011-12-19 00:00:10 +04:00
if ( xfs_ipincount ( ip ) )
io_schedule ( ) ;
} while ( xfs_ipincount ( ip ) ) ;
2017-03-05 13:25:39 +03:00
finish_wait ( wq , & wait . wq_entry ) ;
2011-12-19 00:00:10 +04:00
}
2010-02-06 04:37:26 +03:00
void
2008-03-06 05:43:42 +03:00
xfs_iunpin_wait (
2010-02-17 22:43:56 +03:00
struct xfs_inode * ip )
2008-03-06 05:43:42 +03:00
{
2011-12-19 00:00:10 +04:00
if ( xfs_ipincount ( ip ) )
__xfs_iunpin_wait ( ip ) ;
2005-04-17 02:20:36 +04:00
}
2013-10-29 15:11:44 +04:00
/*
* Removing an inode from the namespace involves removing the directory entry
* and dropping the link count on the inode . Removing the directory entry can
* result in locking an AGF ( directory blocks were freed ) and removing a link
* count can result in placing the inode on an unlinked list which results in
* locking an AGI .
*
* The big problem here is that we have an ordering constraint on AGF and AGI
* locking - inode allocation locks the AGI , then can allocate a new extent for
* new inodes , locking the AGF after the AGI . Similarly , freeing the inode
* removes the inode from the unlinked list , requiring that we lock the AGI
* first , and then freeing the inode can result in an inode chunk being freed
* and hence freeing disk space requiring that we lock an AGF .
*
* Hence the ordering that is imposed by other parts of the code is AGI before
* AGF . This means we cannot remove the directory entry before we drop the inode
* reference count and put it on the unlinked list as this results in a lock
* order of AGF then AGI , and this can deadlock against inode allocation and
* freeing . Therefore we must drop the link counts before we remove the
* directory entry .
*
* This is still safe from a transactional point of view - it is not until we
2016-08-03 04:18:10 +03:00
* get to xfs_defer_finish ( ) that we have the possibility of multiple
2013-10-29 15:11:44 +04:00
* transactions in this operation . Hence as long as we remove the directory
* entry and drop the link count in the first transaction of the remove
* operation , there are no transactional constraints on the ordering here .
*/
2013-08-12 14:49:45 +04:00
int
xfs_remove (
xfs_inode_t * dp ,
struct xfs_name * name ,
xfs_inode_t * ip )
{
xfs_mount_t * mp = dp - > i_mount ;
xfs_trans_t * tp = NULL ;
2016-02-09 08:54:58 +03:00
int is_dir = S_ISDIR ( VFS_I ( ip ) - > i_mode ) ;
2013-08-12 14:49:45 +04:00
int error = 0 ;
uint resblks ;
trace_xfs_remove ( dp , name ) ;
if ( XFS_FORCED_SHUTDOWN ( mp ) )
2014-06-25 08:58:08 +04:00
return - EIO ;
2013-08-12 14:49:45 +04:00
2018-05-05 01:30:21 +03:00
error = xfs_qm_dqattach ( dp ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto std_return ;
2018-05-05 01:30:21 +03:00
error = xfs_qm_dqattach ( ip ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto std_return ;
/*
* We try to get the real space reservation first ,
* allowing for directory btree deletion ( s ) implying
* possible bmap insert ( s ) . If we can ' t get the space
* reservation then we use 0 instead , and avoid the bmap
* btree insert ( s ) in the directory code by , if the bmap
* insert tries to happen , instead trimming the LAST
* block from the directory .
*/
resblks = XFS_REMOVE_SPACE_RES ( mp ) ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_remove , resblks , 0 , 0 , & tp ) ;
2014-06-25 08:58:08 +04:00
if ( error = = - ENOSPC ) {
2013-08-12 14:49:45 +04:00
resblks = 0 ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_remove , 0 , 0 , 0 ,
& tp ) ;
2013-08-12 14:49:45 +04:00
}
if ( error ) {
2014-06-25 08:58:08 +04:00
ASSERT ( error ! = - ENOSPC ) ;
2016-04-06 02:19:55 +03:00
goto std_return ;
2013-08-12 14:49:45 +04:00
}
2018-01-27 02:27:33 +03:00
xfs_lock_two_inodes ( dp , XFS_ILOCK_EXCL , ip , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
2016-11-30 06:33:25 +03:00
xfs_trans_ijoin ( tp , dp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:45 +04:00
xfs_trans_ijoin ( tp , ip , XFS_ILOCK_EXCL ) ;
/*
* If we ' re removing a directory perform some additional validation .
*/
if ( is_dir ) {
2016-02-09 08:54:58 +03:00
ASSERT ( VFS_I ( ip ) - > i_nlink > = 2 ) ;
if ( VFS_I ( ip ) - > i_nlink ! = 2 ) {
2014-06-25 08:58:08 +04:00
error = - ENOTEMPTY ;
2013-08-12 14:49:45 +04:00
goto out_trans_cancel ;
}
if ( ! xfs_dir_isempty ( ip ) ) {
2014-06-25 08:58:08 +04:00
error = - ENOTEMPTY ;
2013-08-12 14:49:45 +04:00
goto out_trans_cancel ;
}
2013-10-29 15:11:44 +04:00
/* Drop the link from ip's "..". */
2013-08-12 14:49:45 +04:00
error = xfs_droplink ( tp , dp ) ;
if ( error )
2013-10-29 15:11:44 +04:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
2013-10-29 15:11:44 +04:00
/* Drop the "." link from ip to self. */
2013-08-12 14:49:45 +04:00
error = xfs_droplink ( tp , ip ) ;
if ( error )
2013-10-29 15:11:44 +04:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
} else {
/*
* When removing a non - directory we need to log the parent
* inode here . For a directory this is done implicitly
* by the xfs_droplink call for the " .. " entry .
*/
xfs_trans_log_inode ( tp , dp , XFS_ILOG_CORE ) ;
}
2013-10-29 15:11:44 +04:00
xfs_trans_ichgtime ( tp , dp , XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
2013-08-12 14:49:45 +04:00
2013-10-29 15:11:44 +04:00
/* Drop the link from dp to ip. */
2013-08-12 14:49:45 +04:00
error = xfs_droplink ( tp , ip ) ;
if ( error )
2013-10-29 15:11:44 +04:00
goto out_trans_cancel ;
2013-08-12 14:49:45 +04:00
2018-07-12 08:26:21 +03:00
error = xfs_dir_removename ( tp , dp , name , ip - > i_ino , resblks ) ;
2013-10-29 15:11:44 +04:00
if ( error ) {
2014-06-25 08:58:08 +04:00
ASSERT ( error ! = - ENOENT ) ;
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-10-29 15:11:44 +04:00
}
2013-08-12 14:49:45 +04:00
/*
* If this is a synchronous mount , make sure that the
* remove transaction goes to disk before returning to
* the user .
*/
if ( mp - > m_flags & ( XFS_MOUNT_WSYNC | XFS_MOUNT_DIRSYNC ) )
xfs_trans_set_sync ( tp ) ;
2015-06-04 06:48:08 +03:00
error = xfs_trans_commit ( tp ) ;
2013-08-12 14:49:45 +04:00
if ( error )
goto std_return ;
2014-04-23 01:11:51 +04:00
if ( is_dir & & xfs_inode_is_filestream ( ip ) )
2013-08-12 14:49:45 +04:00
xfs_filestream_deassociate ( ip ) ;
return 0 ;
out_trans_cancel :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2013-08-12 14:49:45 +04:00
std_return :
return error ;
}
2013-08-12 14:49:46 +04:00
/*
* Enter all inodes for a rename transaction into a sorted array .
*/
2015-03-25 06:03:32 +03:00
# define __XFS_SORT_INODES 5
2013-08-12 14:49:46 +04:00
STATIC void
xfs_sort_for_rename (
2015-03-25 06:03:32 +03:00
struct xfs_inode * dp1 , /* in: old (source) directory inode */
struct xfs_inode * dp2 , /* in: new (target) directory inode */
struct xfs_inode * ip1 , /* in: inode of old entry */
struct xfs_inode * ip2 , /* in: inode of new entry */
struct xfs_inode * wip , /* in: whiteout inode */
struct xfs_inode * * i_tab , /* out: sorted array of inodes */
int * num_inodes ) /* in/out: inodes in array */
2013-08-12 14:49:46 +04:00
{
int i , j ;
2015-03-25 06:03:32 +03:00
ASSERT ( * num_inodes = = __XFS_SORT_INODES ) ;
memset ( i_tab , 0 , * num_inodes * sizeof ( struct xfs_inode * ) ) ;
2013-08-12 14:49:46 +04:00
/*
* i_tab contains a list of pointers to inodes . We initialize
* the table here & we ' ll sort it . We will then use it to
* order the acquisition of the inode locks .
*
* Note that the table may contain duplicates . e . g . , dp1 = = dp2 .
*/
2015-03-25 06:03:32 +03:00
i = 0 ;
i_tab [ i + + ] = dp1 ;
i_tab [ i + + ] = dp2 ;
i_tab [ i + + ] = ip1 ;
if ( ip2 )
i_tab [ i + + ] = ip2 ;
if ( wip )
i_tab [ i + + ] = wip ;
* num_inodes = i ;
2013-08-12 14:49:46 +04:00
/*
* Sort the elements via bubble sort . ( Remember , there are at
2015-03-25 06:03:32 +03:00
* most 5 elements to sort , so this is adequate . )
2013-08-12 14:49:46 +04:00
*/
for ( i = 0 ; i < * num_inodes ; i + + ) {
for ( j = 1 ; j < * num_inodes ; j + + ) {
if ( i_tab [ j ] - > i_ino < i_tab [ j - 1 ] - > i_ino ) {
2015-03-25 06:03:32 +03:00
struct xfs_inode * temp = i_tab [ j ] ;
2013-08-12 14:49:46 +04:00
i_tab [ j ] = i_tab [ j - 1 ] ;
i_tab [ j - 1 ] = temp ;
}
}
}
}
2015-03-25 06:06:07 +03:00
static int
xfs_finish_rename (
2018-07-12 08:26:08 +03:00
struct xfs_trans * tp )
2015-03-25 06:06:07 +03:00
{
/*
* If this is a synchronous mount , make sure that the rename transaction
* goes to disk before returning to the user .
*/
if ( tp - > t_mountp - > m_flags & ( XFS_MOUNT_WSYNC | XFS_MOUNT_DIRSYNC ) )
xfs_trans_set_sync ( tp ) ;
2015-06-04 06:48:08 +03:00
return xfs_trans_commit ( tp ) ;
2015-03-25 06:06:07 +03:00
}
2014-12-24 00:51:42 +03:00
/*
* xfs_cross_rename ( )
*
* responsible for handling RENAME_EXCHANGE flag in renameat2 ( ) sytemcall
*/
STATIC int
xfs_cross_rename (
struct xfs_trans * tp ,
struct xfs_inode * dp1 ,
struct xfs_name * name1 ,
struct xfs_inode * ip1 ,
struct xfs_inode * dp2 ,
struct xfs_name * name2 ,
struct xfs_inode * ip2 ,
int spaceres )
{
int error = 0 ;
int ip1_flags = 0 ;
int ip2_flags = 0 ;
int dp2_flags = 0 ;
/* Swap inode number for dirent in first parent */
2018-07-12 08:26:21 +03:00
error = xfs_dir_replace ( tp , dp1 , name1 , ip2 - > i_ino , spaceres ) ;
2014-12-24 00:51:42 +03:00
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2014-12-24 00:51:42 +03:00
/* Swap inode number for dirent in second parent */
2018-07-12 08:26:21 +03:00
error = xfs_dir_replace ( tp , dp2 , name2 , ip1 - > i_ino , spaceres ) ;
2014-12-24 00:51:42 +03:00
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2014-12-24 00:51:42 +03:00
/*
* If we ' re renaming one or more directories across different parents ,
* update the respective " .. " entries ( and link counts ) to match the new
* parents .
*/
if ( dp1 ! = dp2 ) {
dp2_flags = XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ;
2016-02-09 08:54:58 +03:00
if ( S_ISDIR ( VFS_I ( ip2 ) - > i_mode ) ) {
2014-12-24 00:51:42 +03:00
error = xfs_dir_replace ( tp , ip2 , & xfs_name_dotdot ,
2018-07-12 08:26:21 +03:00
dp1 - > i_ino , spaceres ) ;
2014-12-24 00:51:42 +03:00
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2014-12-24 00:51:42 +03:00
/* transfer ip2 ".." reference to dp1 */
2016-02-09 08:54:58 +03:00
if ( ! S_ISDIR ( VFS_I ( ip1 ) - > i_mode ) ) {
2014-12-24 00:51:42 +03:00
error = xfs_droplink ( tp , dp2 ) ;
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2019-05-02 06:26:30 +03:00
xfs_bumplink ( tp , dp1 ) ;
2014-12-24 00:51:42 +03:00
}
/*
* Although ip1 isn ' t changed here , userspace needs
* to be warned about the change , so that applications
* relying on it ( like backup ones ) , will properly
* notify the change
*/
ip1_flags | = XFS_ICHGTIME_CHG ;
ip2_flags | = XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ;
}
2016-02-09 08:54:58 +03:00
if ( S_ISDIR ( VFS_I ( ip1 ) - > i_mode ) ) {
2014-12-24 00:51:42 +03:00
error = xfs_dir_replace ( tp , ip1 , & xfs_name_dotdot ,
2018-07-12 08:26:21 +03:00
dp2 - > i_ino , spaceres ) ;
2014-12-24 00:51:42 +03:00
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2014-12-24 00:51:42 +03:00
/* transfer ip1 ".." reference to dp2 */
2016-02-09 08:54:58 +03:00
if ( ! S_ISDIR ( VFS_I ( ip2 ) - > i_mode ) ) {
2014-12-24 00:51:42 +03:00
error = xfs_droplink ( tp , dp1 ) ;
if ( error )
2015-03-25 06:08:07 +03:00
goto out_trans_abort ;
2019-05-02 06:26:30 +03:00
xfs_bumplink ( tp , dp2 ) ;
2014-12-24 00:51:42 +03:00
}
/*
* Although ip2 isn ' t changed here , userspace needs
* to be warned about the change , so that applications
* relying on it ( like backup ones ) , will properly
* notify the change
*/
ip1_flags | = XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ;
ip2_flags | = XFS_ICHGTIME_CHG ;
}
}
if ( ip1_flags ) {
xfs_trans_ichgtime ( tp , ip1 , ip1_flags ) ;
xfs_trans_log_inode ( tp , ip1 , XFS_ILOG_CORE ) ;
}
if ( ip2_flags ) {
xfs_trans_ichgtime ( tp , ip2 , ip2_flags ) ;
xfs_trans_log_inode ( tp , ip2 , XFS_ILOG_CORE ) ;
}
if ( dp2_flags ) {
xfs_trans_ichgtime ( tp , dp2 , dp2_flags ) ;
xfs_trans_log_inode ( tp , dp2 , XFS_ILOG_CORE ) ;
}
xfs_trans_ichgtime ( tp , dp1 , XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
xfs_trans_log_inode ( tp , dp1 , XFS_ILOG_CORE ) ;
2018-07-12 08:26:08 +03:00
return xfs_finish_rename ( tp ) ;
2015-03-25 06:08:07 +03:00
out_trans_abort :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2014-12-24 00:51:42 +03:00
return error ;
}
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
/*
* xfs_rename_alloc_whiteout ( )
*
* Return a referenced , unlinked , unlocked inode that that can be used as a
* whiteout in a rename transaction . We use a tmpfile inode here so that if we
* crash between allocating the inode and linking it into the rename transaction
* recovery will free the inode and we won ' t leak it .
*/
static int
xfs_rename_alloc_whiteout (
struct xfs_inode * dp ,
struct xfs_inode * * wip )
{
struct xfs_inode * tmpfile ;
int error ;
2018-04-06 20:09:42 +03:00
error = xfs_create_tmpfile ( dp , S_IFCHR | WHITEOUT_MODE , & tmpfile ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
if ( error )
return error ;
2015-05-29 01:14:55 +03:00
/*
* Prepare the tmpfile inode as if it were created through the VFS .
xfs: don't ever put nlink > 0 inodes on the unlinked list
When XFS creates an O_TMPFILE file, the inode is created with nlink = 1,
put on the unlinked list, and then the VFS sets nlink = 0 in d_tmpfile.
If we crash before anything logs the inode (it's dirty incore but the
vfs doesn't tell us it's dirty so we never log that change), the iunlink
processing part of recovery will then explode with a pile of:
XFS: Assertion failed: VFS_I(ip)->i_nlink == 0, file:
fs/xfs/xfs_log_recover.c, line: 5072
Worse yet, since nlink is nonzero, the inodes also don't get cleaned up
and they just leak until the next xfs_repair run.
Therefore, change xfs_iunlink to require that inodes being put on the
unlinked list have nlink == 0, change the tmpfile callers to instantiate
nodes that way, and set the nlink to 1 just prior to calling d_tmpfile.
Fix the comment for xfs_iunlink while we're at it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2019-02-13 22:15:17 +03:00
* Complete the inode setup and flag it as linkable . nlink is already
* zero , so we can skip the drop_nlink .
2015-05-29 01:14:55 +03:00
*/
2016-04-06 00:48:27 +03:00
xfs_setup_iops ( tmpfile ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
xfs_finish_inode_setup ( tmpfile ) ;
VFS_I ( tmpfile ) - > i_state | = I_LINKABLE ;
* wip = tmpfile ;
return 0 ;
}
2013-08-12 14:49:46 +04:00
/*
* xfs_rename
*/
int
xfs_rename (
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
struct xfs_inode * src_dp ,
struct xfs_name * src_name ,
struct xfs_inode * src_ip ,
struct xfs_inode * target_dp ,
struct xfs_name * target_name ,
struct xfs_inode * target_ip ,
unsigned int flags )
2013-08-12 14:49:46 +04:00
{
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
struct xfs_mount * mp = src_dp - > i_mount ;
struct xfs_trans * tp ;
struct xfs_inode * wip = NULL ; /* whiteout inode */
struct xfs_inode * inodes [ __XFS_SORT_INODES ] ;
2019-11-12 19:34:23 +03:00
struct xfs_buf * agibp ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
int num_inodes = __XFS_SORT_INODES ;
2015-03-25 07:12:30 +03:00
bool new_parent = ( src_dp ! = target_dp ) ;
2016-02-09 08:54:58 +03:00
bool src_is_directory = S_ISDIR ( VFS_I ( src_ip ) - > i_mode ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
int spaceres ;
int error ;
2013-08-12 14:49:46 +04:00
trace_xfs_rename ( src_dp , target_dp , src_name , target_name ) ;
2015-03-25 06:08:07 +03:00
if ( ( flags & RENAME_EXCHANGE ) & & ! target_ip )
return - EINVAL ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
/*
* If we are doing a whiteout operation , allocate the whiteout inode
* we will be placing at the target and ensure the type is set
* appropriately .
*/
if ( flags & RENAME_WHITEOUT ) {
ASSERT ( ! ( flags & ( RENAME_NOREPLACE | RENAME_EXCHANGE ) ) ) ;
error = xfs_rename_alloc_whiteout ( target_dp , & wip ) ;
if ( error )
return error ;
/* setup target dirent info as whiteout */
src_name - > type = XFS_DIR3_FT_CHRDEV ;
}
2013-08-12 14:49:46 +04:00
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
xfs_sort_for_rename ( src_dp , target_dp , src_ip , target_ip , wip ,
2013-08-12 14:49:46 +04:00
inodes , & num_inodes ) ;
spaceres = XFS_RENAME_SPACE_RES ( mp , target_name - > len ) ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_rename , spaceres , 0 , 0 , & tp ) ;
2014-06-25 08:58:08 +04:00
if ( error = = - ENOSPC ) {
2013-08-12 14:49:46 +04:00
spaceres = 0 ;
2016-04-06 02:19:55 +03:00
error = xfs_trans_alloc ( mp , & M_RES ( mp ) - > tr_rename , 0 , 0 , 0 ,
& tp ) ;
2013-08-12 14:49:46 +04:00
}
2015-03-25 06:05:43 +03:00
if ( error )
2016-04-06 02:19:55 +03:00
goto out_release_wip ;
2013-08-12 14:49:46 +04:00
/*
* Attach the dquots to the inodes
*/
error = xfs_qm_vop_rename_dqattach ( inodes ) ;
2015-03-25 06:05:43 +03:00
if ( error )
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
/*
* Lock all the participating inodes . Depending upon whether
* the target_name exists in the target directory , and
* whether the target directory is the same as the source
* directory , we can lock from 2 to 4 inodes .
*/
xfs_lock_inodes ( inodes , num_inodes , XFS_ILOCK_EXCL ) ;
/*
* Join all the inodes to the transaction . From this point on ,
* we can rely on either trans_commit or trans_cancel to unlock
* them .
*/
2016-11-30 06:33:25 +03:00
xfs_trans_ijoin ( tp , src_dp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:46 +04:00
if ( new_parent )
2016-11-30 06:33:25 +03:00
xfs_trans_ijoin ( tp , target_dp , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:46 +04:00
xfs_trans_ijoin ( tp , src_ip , XFS_ILOCK_EXCL ) ;
if ( target_ip )
xfs_trans_ijoin ( tp , target_ip , XFS_ILOCK_EXCL ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
if ( wip )
xfs_trans_ijoin ( tp , wip , XFS_ILOCK_EXCL ) ;
2013-08-12 14:49:46 +04:00
/*
* If we are using project inheritance , we only allow renames
* into our tree when the project IDs are the same ; else the
* tree quota mechanism would be circumvented .
*/
if ( unlikely ( ( target_dp - > i_d . di_flags & XFS_DIFLAG_PROJINHERIT ) & &
2019-11-12 19:22:54 +03:00
target_dp - > i_d . di_projid ! = src_ip - > i_d . di_projid ) ) {
2014-06-25 08:58:08 +04:00
error = - EXDEV ;
2015-03-25 06:05:43 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
}
2015-03-25 06:08:07 +03:00
/* RENAME_EXCHANGE is unique from here on. */
if ( flags & RENAME_EXCHANGE )
return xfs_cross_rename ( tp , src_dp , src_name , src_ip ,
target_dp , target_name , target_ip ,
2018-07-12 08:26:20 +03:00
spaceres ) ;
2014-12-24 00:51:42 +03:00
2013-08-12 14:49:46 +04:00
/*
2019-09-04 07:06:50 +03:00
* Check for expected errors before we dirty the transaction
* so we can return an error without a transaction abort .
2013-08-12 14:49:46 +04:00
*/
if ( target_ip = = NULL ) {
/*
* If there ' s no space reservation , check the entry will
* fit before actually inserting it .
*/
2014-09-09 05:57:52 +04:00
if ( ! spaceres ) {
error = xfs_dir_canenter ( tp , target_dp , target_name ) ;
if ( error )
2015-03-25 06:05:43 +03:00
goto out_trans_cancel ;
2014-09-09 05:57:52 +04:00
}
2019-09-04 07:06:50 +03:00
} else {
/*
* If target exists and it ' s a directory , check that whether
* it can be destroyed .
*/
if ( S_ISDIR ( VFS_I ( target_ip ) - > i_mode ) & &
( ! xfs_dir_isempty ( target_ip ) | |
( VFS_I ( target_ip ) - > i_nlink > 2 ) ) ) {
error = - EEXIST ;
goto out_trans_cancel ;
}
}
/*
* Directory entry creation below may acquire the AGF . Remove
* the whiteout from the unlinked list first to preserve correct
* AGI / AGF locking order . This dirties the transaction so failures
* after this point will abort and log recovery will clean up the
* mess .
*
* For whiteouts , we need to bump the link count on the whiteout
* inode . After this point , we have a real link , clear the tmpfile
* state flag from the inode so it doesn ' t accidentally get misused
* in future .
*/
if ( wip ) {
ASSERT ( VFS_I ( wip ) - > i_nlink = = 0 ) ;
error = xfs_iunlink_remove ( tp , wip ) ;
if ( error )
goto out_trans_cancel ;
xfs_bumplink ( tp , wip ) ;
VFS_I ( wip ) - > i_state & = ~ I_LINKABLE ;
}
/*
* Set up the target .
*/
if ( target_ip = = NULL ) {
2013-08-12 14:49:46 +04:00
/*
* If target does not exist and the rename crosses
* directories , adjust the target directory link count
* to account for the " .. " reference from the new entry .
*/
error = xfs_dir_createname ( tp , target_dp , target_name ,
2018-07-12 08:26:21 +03:00
src_ip - > i_ino , spaceres ) ;
2013-08-12 14:49:46 +04:00
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
xfs_trans_ichgtime ( tp , target_dp ,
XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
if ( new_parent & & src_is_directory ) {
2019-05-02 06:26:30 +03:00
xfs_bumplink ( tp , target_dp ) ;
2013-08-12 14:49:46 +04:00
}
} else { /* target_ip != NULL */
/*
* Link the source inode under the target name .
* If the source inode is a directory and we are moving
* it across directories , its " .. " entry will be
* inconsistent until we replace that down below .
*
* In case there is already an entry with the same
* name at the destination directory , remove it first .
*/
2019-11-12 19:34:23 +03:00
/*
* Check whether the replace operation will need to allocate
* blocks . This happens when the shortform directory lacks
* space and we have to convert it to a block format directory .
* When more blocks are necessary , we must lock the AGI first
* to preserve locking order ( AGI - > AGF ) .
*/
if ( xfs_dir2_sf_replace_needblock ( target_dp , src_ip - > i_ino ) ) {
error = xfs_read_agi ( mp , tp ,
XFS_INO_TO_AGNO ( mp , target_ip - > i_ino ) ,
& agibp ) ;
if ( error )
goto out_trans_cancel ;
}
2013-08-12 14:49:46 +04:00
error = xfs_dir_replace ( tp , target_dp , target_name ,
2018-07-12 08:26:21 +03:00
src_ip - > i_ino , spaceres ) ;
2013-08-12 14:49:46 +04:00
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
xfs_trans_ichgtime ( tp , target_dp ,
XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
/*
* Decrement the link count on the target since the target
* dir no longer points to it .
*/
error = xfs_droplink ( tp , target_ip ) ;
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
if ( src_is_directory ) {
/*
* Drop the link from the old " . " entry .
*/
error = xfs_droplink ( tp , target_ip ) ;
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
}
} /* target_ip != NULL */
/*
* Remove the source .
*/
if ( new_parent & & src_is_directory ) {
/*
* Rewrite the " .. " entry to point to the new
* directory .
*/
error = xfs_dir_replace ( tp , src_ip , & xfs_name_dotdot ,
2018-07-12 08:26:21 +03:00
target_dp - > i_ino , spaceres ) ;
2014-06-25 08:58:08 +04:00
ASSERT ( error ! = - EEXIST ) ;
2013-08-12 14:49:46 +04:00
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
}
/*
* We always want to hit the ctime on the source inode .
*
* This isn ' t strictly required by the standards since the source
* inode isn ' t really being changed , but old unix file systems did
* it and some incremental backup programs won ' t work without it .
*/
xfs_trans_ichgtime ( tp , src_ip , XFS_ICHGTIME_CHG ) ;
xfs_trans_log_inode ( tp , src_ip , XFS_ILOG_CORE ) ;
/*
* Adjust the link count on src_dp . This is necessary when
* renaming a directory , either within one parent when
* the target existed , or across two parent directories .
*/
if ( src_is_directory & & ( new_parent | | target_ip ! = NULL ) ) {
/*
* Decrement link count on src_directory since the
* entry that ' s moved no longer points to it .
*/
error = xfs_droplink ( tp , src_dp ) ;
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
}
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
/*
* For whiteouts , we only need to update the source dirent with the
* inode number of the whiteout inode rather than removing it
* altogether .
*/
if ( wip ) {
error = xfs_dir_replace ( tp , src_dp , src_name , wip - > i_ino ,
2018-07-12 08:26:21 +03:00
spaceres ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
} else
error = xfs_dir_removename ( tp , src_dp , src_name , src_ip - > i_ino ,
2018-07-12 08:26:21 +03:00
spaceres ) ;
2013-08-12 14:49:46 +04:00
if ( error )
2018-07-24 23:43:13 +03:00
goto out_trans_cancel ;
2013-08-12 14:49:46 +04:00
xfs_trans_ichgtime ( tp , src_dp , XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG ) ;
xfs_trans_log_inode ( tp , src_dp , XFS_ILOG_CORE ) ;
if ( new_parent )
xfs_trans_log_inode ( tp , target_dp , XFS_ILOG_CORE ) ;
2018-07-12 08:26:08 +03:00
error = xfs_finish_rename ( tp ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
if ( wip )
2018-07-25 22:52:32 +03:00
xfs_irele ( wip ) ;
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
return error ;
2013-08-12 14:49:46 +04:00
2015-03-25 06:05:43 +03:00
out_trans_cancel :
2015-06-04 06:47:56 +03:00
xfs_trans_cancel ( tp ) ;
2016-04-06 02:19:55 +03:00
out_release_wip :
xfs: add RENAME_WHITEOUT support
Whiteouts are used by overlayfs - it has a crazy convention that a
whiteout is a character device inode with a major:minor of 0:0.
Because it's not documented anywhere, here's an example of what
RENAME_WHITEOUT does on ext4:
# echo foo > /mnt/scratch/foo
# echo bar > /mnt/scratch/bar
# ls -l /mnt/scratch
total 24
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
-rw-r--r-- 1 root root 4 Feb 11 20:22 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# src/renameat2 -w /mnt/scratch/foo /mnt/scratch/bar
# ls -l /mnt/scratch
total 20
-rw-r--r-- 1 root root 4 Feb 11 20:22 bar
c--------- 1 root root 0, 0 Feb 11 20:23 foo
drwx------ 2 root root 16384 Feb 11 20:18 lost+found
# cat /mnt/scratch/bar
foo
#
In XFS rename terms, the operation that has been done is that source
(foo) has been moved to the target (bar), which is like a nomal
rename operation, but rather than the source being removed, it have
been replaced with a whiteout.
We can't allocate whiteout inodes within the rename transaction due
to allocation being a multi-commit transaction: rename needs to
be a single, atomic commit. Hence we have several options here, form
most efficient to least efficient:
- use DT_WHT in the target dirent and do no whiteout inode
allocation. The main issue with this approach is that we need
hooks in lookup to create a virtual chardev inode to present
to userspace and in places where we might need to modify the
dirent e.g. unlink. Overlayfs also needs to be taught about
DT_WHT. Most invasive change, lowest overhead.
- create a special whiteout inode in the root directory (e.g. a
".wino" dirent) and then hardlink every new whiteout to it.
This means we only need to create a single whiteout inode, and
rename simply creates a hardlink to it. We can use DT_WHT for
these, though using DT_CHR means we won't have to modify
overlayfs, nor anything in userspace. Downside is we have to
look up the whiteout inode on every operation and create it if
it doesn't exist.
- copy ext4: create a special whiteout chardev inode for every
whiteout. This is more complex than the above options because
of the lack of atomicity between inode creation and the rename
operation, requiring us to create a tmpfile inode and then
linking it into the directory structure during the rename. At
least with a tmpfile inode crashes between the create and
rename doesn't leave unreferenced inodes or directory
pollution around.
By far the simplest thing to do in the short term is to copy ext4.
While it is the most inefficient way of supporting whiteouts, but as
an initial implementation we can simply reuse existing functions and
add a small amount of extra code the the rename operation.
When we get full whiteout support in the VFS (via the dentry cache)
we can then look to supporting DT_WHT method outlined as the first
method of supporting whiteouts. But until then, we'll stick with
what overlayfs expects us to be: dumb and stupid.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
2015-03-25 06:08:08 +03:00
if ( wip )
2018-07-25 22:52:32 +03:00
xfs_irele ( wip ) ;
2013-08-12 14:49:46 +04:00
return error ;
}
2013-08-12 14:49:33 +04:00
STATIC int
xfs_iflush_cluster (
2016-05-18 07:09:46 +03:00
struct xfs_inode * ip ,
struct xfs_buf * bp )
2005-04-17 02:20:36 +04:00
{
2016-05-18 07:09:46 +03:00
struct xfs_mount * mp = ip - > i_mount ;
2013-08-12 14:49:33 +04:00
struct xfs_perag * pag ;
unsigned long first_index , mask ;
2016-05-18 07:09:46 +03:00
int cilist_size ;
struct xfs_inode * * cilist ;
struct xfs_inode * cip ;
2019-06-05 21:19:34 +03:00
struct xfs_ino_geometry * igeo = M_IGEO ( mp ) ;
2013-08-12 14:49:33 +04:00
int nr_found ;
int clcount = 0 ;
2005-04-17 02:20:36 +04:00
int i ;
2013-08-12 14:49:33 +04:00
pag = xfs_perag_get ( mp , XFS_INO_TO_AGNO ( mp , ip - > i_ino ) ) ;
2005-04-17 02:20:36 +04:00
2019-06-05 21:19:36 +03:00
cilist_size = igeo - > inodes_per_cluster * sizeof ( struct xfs_inode * ) ;
2016-05-18 07:09:46 +03:00
cilist = kmem_alloc ( cilist_size , KM_MAYFAIL | KM_NOFS ) ;
if ( ! cilist )
2013-08-12 14:49:33 +04:00
goto out_put ;
2005-04-17 02:20:36 +04:00
2019-06-05 21:19:36 +03:00
mask = ~ ( igeo - > inodes_per_cluster - 1 ) ;
2013-08-12 14:49:33 +04:00
first_index = XFS_INO_TO_AGINO ( mp , ip - > i_ino ) & mask ;
rcu_read_lock ( ) ;
/* really need a gang lookup range call here */
2016-05-18 07:09:46 +03:00
nr_found = radix_tree_gang_lookup ( & pag - > pag_ici_root , ( void * * ) cilist ,
2019-06-05 21:19:36 +03:00
first_index , igeo - > inodes_per_cluster ) ;
2013-08-12 14:49:33 +04:00
if ( nr_found = = 0 )
goto out_free ;
for ( i = 0 ; i < nr_found ; i + + ) {
2016-05-18 07:09:46 +03:00
cip = cilist [ i ] ;
if ( cip = = ip )
2008-03-06 05:43:49 +03:00
continue ;
2010-12-17 09:29:43 +03:00
/*
* because this is an RCU protected lookup , we could find a
* recently freed or even reallocated inode during the lookup .
* We need to check under the i_flags_lock for a valid inode
* here . Skip it if it is not valid or the wrong inode .
*/
2016-05-18 07:09:46 +03:00
spin_lock ( & cip - > i_flags_lock ) ;
if ( ! cip - > i_ino | |
__xfs_iflags_test ( cip , XFS_ISTALE ) ) {
spin_unlock ( & cip - > i_flags_lock ) ;
2010-12-17 09:29:43 +03:00
continue ;
}
2016-05-18 07:09:13 +03:00
/*
* Once we fall off the end of the cluster , no point checking
* any more inodes in the list because they will also all be
* outside the cluster .
*/
2016-05-18 07:09:46 +03:00
if ( ( XFS_INO_TO_AGINO ( mp , cip - > i_ino ) & mask ) ! = first_index ) {
spin_unlock ( & cip - > i_flags_lock ) ;
2016-05-18 07:09:13 +03:00
break ;
}
2016-05-18 07:09:46 +03:00
spin_unlock ( & cip - > i_flags_lock ) ;
2010-12-17 09:29:43 +03:00
2008-03-06 05:43:49 +03:00
/*
* Do an un - protected check to see if the inode is dirty and
* is a candidate for flushing . These checks will be repeated
* later after the appropriate locks are acquired .
*/
2016-05-18 07:09:46 +03:00
if ( xfs_inode_clean ( cip ) & & xfs_ipincount ( cip ) = = 0 )
2008-03-06 05:43:49 +03:00
continue ;
/*
* Try to get locks . If any are unavailable or it is pinned ,
* then this inode cannot be flushed and is skipped .
*/
2016-05-18 07:09:46 +03:00
if ( ! xfs_ilock_nowait ( cip , XFS_ILOCK_SHARED ) )
2008-03-06 05:43:49 +03:00
continue ;
2016-05-18 07:09:46 +03:00
if ( ! xfs_iflock_nowait ( cip ) ) {
xfs_iunlock ( cip , XFS_ILOCK_SHARED ) ;
2008-03-06 05:43:49 +03:00
continue ;
}
2016-05-18 07:09:46 +03:00
if ( xfs_ipincount ( cip ) ) {
xfs_ifunlock ( cip ) ;
xfs_iunlock ( cip , XFS_ILOCK_SHARED ) ;
2008-03-06 05:43:49 +03:00
continue ;
}
2016-05-18 07:09:12 +03:00
/*
* Check the inode number again , just to be certain we are not
* racing with freeing in xfs_reclaim_inode ( ) . See the comments
* in that function for more information as to why the initial
* check is not sufficient .
*/
2016-05-18 07:09:46 +03:00
if ( ! cip - > i_ino ) {
xfs_ifunlock ( cip ) ;
xfs_iunlock ( cip , XFS_ILOCK_SHARED ) ;
2008-03-06 05:43:49 +03:00
continue ;
}
/*
* arriving here means that this inode can be flushed . First
* re - check that it ' s dirty before flushing .
*/
2016-05-18 07:09:46 +03:00
if ( ! xfs_inode_clean ( cip ) ) {
2008-03-06 05:43:59 +03:00
int error ;
2016-05-18 07:09:46 +03:00
error = xfs_iflush_int ( cip , bp ) ;
2008-03-06 05:43:49 +03:00
if ( error ) {
2016-05-18 07:09:46 +03:00
xfs_iunlock ( cip , XFS_ILOCK_SHARED ) ;
2008-03-06 05:43:49 +03:00
goto cluster_corrupt_out ;
}
clcount + + ;
} else {
2016-05-18 07:09:46 +03:00
xfs_ifunlock ( cip ) ;
2008-03-06 05:43:49 +03:00
}
2016-05-18 07:09:46 +03:00
xfs_iunlock ( cip , XFS_ILOCK_SHARED ) ;
2008-03-06 05:43:49 +03:00
}
if ( clcount ) {
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_icluster_flushcnt ) ;
XFS_STATS_ADD ( mp , xs_icluster_flushinode , clcount ) ;
2008-03-06 05:43:49 +03:00
}
out_free :
2010-12-17 09:29:43 +03:00
rcu_read_unlock ( ) ;
2016-05-18 07:09:46 +03:00
kmem_free ( cilist ) ;
2010-01-11 14:47:43 +03:00
out_put :
xfs_perag_put ( pag ) ;
2008-03-06 05:43:49 +03:00
return 0 ;
cluster_corrupt_out :
/*
* Corruption detected in the clustering loop . Invalidate the
* inode buffer and shut down the filesystem .
*/
2010-12-17 09:29:43 +03:00
rcu_read_unlock ( ) ;
2008-03-06 05:43:49 +03:00
/*
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
* We ' ll always have an inode attached to the buffer for completion
* process by the time we are called from xfs_iflush ( ) . Hence we have
* always need to do IO completion processing to abort the inodes
* attached to the buffer . handle them just like the shutdown case in
* xfs_buf_submit ( ) .
2008-03-06 05:43:49 +03:00
*/
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
ASSERT ( bp - > b_iodone ) ;
2019-04-12 17:39:20 +03:00
bp - > b_flags | = XBF_ASYNC ;
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
bp - > b_flags & = ~ XBF_DONE ;
xfs_buf_stale ( bp ) ;
xfs_buf_ioerror ( bp , - EIO ) ;
xfs_buf_ioend ( bp ) ;
2019-04-12 17:39:20 +03:00
xfs_force_shutdown ( mp , SHUTDOWN_CORRUPT_INCORE ) ;
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
/* abort the corrupt inode, as it was not attached to the buffer */
2016-05-18 07:09:46 +03:00
xfs_iflush_abort ( cip , false ) ;
kmem_free ( cilist ) ;
2010-01-11 14:47:43 +03:00
xfs_perag_put ( pag ) ;
2014-06-25 08:58:08 +04:00
return - EFSCORRUPTED ;
2008-03-06 05:43:49 +03:00
}
2005-04-17 02:20:36 +04:00
/*
2012-04-23 09:58:36 +04:00
* Flush dirty inode metadata into the backing buffer .
*
* The caller must have the inode lock and the inode flush lock held . The
* inode lock will still be held upon return to the caller , and the inode
* flush lock will be released after the inode has reached the disk .
*
* The caller must write out the buffer returned in * bpp and release it .
2005-04-17 02:20:36 +04:00
*/
int
xfs_iflush (
2012-04-23 09:58:36 +04:00
struct xfs_inode * ip ,
struct xfs_buf * * bpp )
2005-04-17 02:20:36 +04:00
{
2012-04-23 09:58:36 +04:00
struct xfs_mount * mp = ip - > i_mount ;
2016-05-18 06:53:42 +03:00
struct xfs_buf * bp = NULL ;
2012-04-23 09:58:36 +04:00
struct xfs_dinode * dip ;
2005-04-17 02:20:36 +04:00
int error ;
2015-10-12 10:21:22 +03:00
XFS_STATS_INC ( mp , xs_iflush_count ) ;
2005-04-17 02:20:36 +04:00
2008-04-22 11:34:00 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL | XFS_ILOCK_SHARED ) ) ;
2011-12-19 00:00:09 +04:00
ASSERT ( xfs_isiflocked ( ip ) ) ;
2005-04-17 02:20:36 +04:00
ASSERT ( ip - > i_d . di_format ! = XFS_DINODE_FMT_BTREE | |
2011-12-19 00:00:07 +04:00
ip - > i_d . di_nextents > XFS_IFORK_MAXEXT ( ip , XFS_DATA_FORK ) ) ;
2005-04-17 02:20:36 +04:00
2012-04-23 09:58:36 +04:00
* bpp = NULL ;
2005-04-17 02:20:36 +04:00
xfs_iunpin_wait ( ip ) ;
2010-01-11 14:45:21 +03:00
/*
* For stale inodes we cannot rely on the backing buffer remaining
* stale in cache for the remaining life of the stale inode and so
2012-07-03 20:21:22 +04:00
* xfs_imap_to_bp ( ) below may give us a buffer that no longer contains
2010-01-11 14:45:21 +03:00
* inodes below . We have to check this after ensuring the inode is
* unpinned so that it is safe to reclaim the stale inode after the
* flush call .
*/
if ( xfs_iflags_test ( ip , XFS_ISTALE ) ) {
xfs_ifunlock ( ip ) ;
return 0 ;
}
2005-04-17 02:20:36 +04:00
/*
* This may have been unpinned because the filesystem is shutting
* down forcibly . If that ' s the case we must not write this inode
2012-04-23 09:58:32 +04:00
* to disk , because the log record didn ' t make it to disk .
*
* We also have to remove the log item from the AIL in this case ,
* as we wait for an empty AIL as part of the unmount process .
2005-04-17 02:20:36 +04:00
*/
if ( XFS_FORCED_SHUTDOWN ( mp ) ) {
2014-06-25 08:58:08 +04:00
error = - EIO ;
2012-04-23 09:58:32 +04:00
goto abort_out ;
2005-04-17 02:20:36 +04:00
}
2008-03-06 05:43:42 +03:00
/*
2016-05-18 06:53:42 +03:00
* Get the buffer containing the on - disk inode . We are doing a try - lock
* operation here , so we may get an EAGAIN error . In that case , we
* simply want to return with the inode still dirty .
*
* If we get any other error , we effectively have a corruption situation
* and we cannot flush the inode , so we treat it the same as failing
* xfs_iflush_int ( ) .
2008-03-06 05:43:42 +03:00
*/
2012-07-03 20:21:22 +04:00
error = xfs_imap_to_bp ( mp , NULL , & ip - > i_imap , & dip , & bp , XBF_TRYLOCK ,
0 ) ;
2016-05-18 06:53:42 +03:00
if ( error = = - EAGAIN ) {
2008-03-06 05:43:42 +03:00
xfs_ifunlock ( ip ) ;
return error ;
}
2016-05-18 06:53:42 +03:00
if ( error )
goto corrupt_out ;
2008-03-06 05:43:42 +03:00
2005-04-17 02:20:36 +04:00
/*
* First flush out the inode that xfs_iflush was called with .
*/
error = xfs_iflush_int ( ip , bp ) ;
2008-03-06 05:43:49 +03:00
if ( error )
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
2008-03-06 05:43:42 +03:00
/*
* If the buffer is pinned then push on the log now so we won ' t
* get stuck waiting in the write for too long .
*/
2011-07-23 03:40:27 +04:00
if ( xfs_buf_ispinned ( bp ) )
2010-01-19 12:56:46 +03:00
xfs_log_force ( mp , 0 ) ;
2008-03-06 05:43:42 +03:00
2005-04-17 02:20:36 +04:00
/*
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
* inode clustering : try to gather other inodes into this write
*
* Note : Any error during clustering will result in the filesystem
* being shut down and completion callbacks run on the cluster buffer .
* As we have already flushed and attached this inode to the buffer ,
* it has already been aborted and released by xfs_iflush_cluster ( ) and
* so we have no further error handling to do here .
2005-04-17 02:20:36 +04:00
*/
2008-03-06 05:43:49 +03:00
error = xfs_iflush_cluster ( ip , bp ) ;
if ( error )
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
return error ;
2005-04-17 02:20:36 +04:00
2012-04-23 09:58:36 +04:00
* bpp = bp ;
return 0 ;
2005-04-17 02:20:36 +04:00
corrupt_out :
2016-05-18 06:53:42 +03:00
if ( bp )
xfs_buf_relse ( bp ) ;
2006-06-09 08:58:38 +04:00
xfs_force_shutdown ( mp , SHUTDOWN_CORRUPT_INCORE ) ;
2012-04-23 09:58:32 +04:00
abort_out :
xfs: xfs_iflush_abort() can be called twice on cluster writeback failure
When a corrupt inode is detected during xfs_iflush_cluster, we can
get a shutdown ASSERT failure like this:
XFS (pmem1): Metadata corruption detected at xfs_symlink_shortform_verify+0x5c/0xa0, inode 0x86627 data fork
XFS (pmem1): Unmount and run xfs_repair
XFS (pmem1): xfs_do_force_shutdown(0x8) called from line 3372 of file fs/xfs/xfs_inode.c. Return address = ffffffff814f4116
XFS (pmem1): Corruption of in-memory data detected. Shutting down filesystem
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8a88
XFS (pmem1): xfs_do_force_shutdown(0x1) called from line 222 of file fs/xfs/libxfs/xfs_defer.c. Return address = ffffffff814a8ef9
XFS (pmem1): Please umount the filesystem and rectify the problem(s)
XFS: Assertion failed: xfs_isiflocked(ip), file: fs/xfs/xfs_inode.h, line: 258
.....
Call Trace:
xfs_iflush_abort+0x10a/0x110
xfs_iflush+0xf3/0x390
xfs_inode_item_push+0x126/0x1e0
xfsaild+0x2c5/0x890
kthread+0x11c/0x140
ret_from_fork+0x24/0x30
Essentially, xfs_iflush_abort() has been called twice on the
original inode that that was flushed. This happens because the
inode has been flushed to teh buffer successfully via
xfs_iflush_int(), and so when another inode is detected as corrupt
in xfs_iflush_cluster, the buffer is marked stale and EIO, and
iodone callbacks are run on it.
Running the iodone callbacks walks across the original inode and
calls xfs_iflush_abort() on it. When xfs_iflush_cluster() returns
to xfs_iflush(), it runs the error path for that function, and that
calls xfs_iflush_abort() on the inode a second time, leading to the
above assert failure as the inode is not flush locked anymore.
This bug has been there a long time.
The simple fix would be to just avoid calling xfs_iflush_abort() in
xfs_iflush() if we've got a failure from xfs_iflush_cluster().
However, xfs_iflush_cluster() has magic delwri buffer handling that
means it may or may not have run IO completion on the buffer, and
hence sometimes we have to call xfs_iflush_abort() from
xfs_iflush(), and sometimes we shouldn't.
After reading through all the error paths and the delwri buffer
code, it's clear that the error handling in xfs_iflush_cluster() is
unnecessary. If the buffer is delwri, it leaves it on the delwri
list so that when the delwri list is submitted it sees a shutdown
fliesystem in xfs_buf_submit() and that marks the buffer stale, EIO
and runs IO completion. i.e. exactly what xfs+iflush_cluster() does
when it's not a delwri buffer. Further, marking a buffer stale
clears the _XBF_DELWRI_Q flag on the buffer, which means when
submission of the buffer occurs, it just skips over it and releases
it.
IOWs, the error handling in xfs_iflush_cluster doesn't need to care
if the buffer is already on a the delwri queue or not - it just
needs to mark the buffer stale, EIO and run completions. That means
we can just use the easy fix for xfs_iflush() to avoid the double
abort.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2018-06-22 09:26:05 +03:00
/* abort the corrupt inode, as it was not attached to the buffer */
2012-04-23 09:58:41 +04:00
xfs_iflush_abort ( ip , false ) ;
2012-04-23 09:58:32 +04:00
return error ;
2005-04-17 02:20:36 +04:00
}
2018-01-08 21:51:06 +03:00
/*
* If there are inline format data / attr forks attached to this inode ,
* make sure they ' re not corrupt .
*/
bool
xfs_inode_verify_forks (
struct xfs_inode * ip )
{
2018-01-23 05:09:48 +03:00
struct xfs_ifork * ifp ;
2018-01-08 21:51:06 +03:00
xfs_failaddr_t fa ;
fa = xfs_ifork_verify_data ( ip , & xfs_default_ifork_ops ) ;
if ( fa ) {
2018-01-23 05:09:48 +03:00
ifp = XFS_IFORK_PTR ( ip , XFS_DATA_FORK ) ;
xfs_inode_verifier_error ( ip , - EFSCORRUPTED , " data fork " ,
ifp - > if_u1 . if_data , ifp - > if_bytes , fa ) ;
2018-01-08 21:51:06 +03:00
return false ;
}
fa = xfs_ifork_verify_attr ( ip , & xfs_default_ifork_ops ) ;
if ( fa ) {
2018-01-23 05:09:48 +03:00
ifp = XFS_IFORK_PTR ( ip , XFS_ATTR_FORK ) ;
xfs_inode_verifier_error ( ip , - EFSCORRUPTED , " attr fork " ,
ifp ? ifp - > if_u1 . if_data : NULL ,
ifp ? ifp - > if_bytes : 0 , fa ) ;
2018-01-08 21:51:06 +03:00
return false ;
}
return true ;
}
2005-04-17 02:20:36 +04:00
STATIC int
xfs_iflush_int (
2013-04-03 09:11:17 +04:00
struct xfs_inode * ip ,
struct xfs_buf * bp )
2005-04-17 02:20:36 +04:00
{
2013-04-03 09:11:17 +04:00
struct xfs_inode_log_item * iip = ip - > i_itemp ;
struct xfs_dinode * dip ;
struct xfs_mount * mp = ip - > i_mount ;
2005-04-17 02:20:36 +04:00
2008-04-22 11:34:00 +04:00
ASSERT ( xfs_isilocked ( ip , XFS_ILOCK_EXCL | XFS_ILOCK_SHARED ) ) ;
2011-12-19 00:00:09 +04:00
ASSERT ( xfs_isiflocked ( ip ) ) ;
2005-04-17 02:20:36 +04:00
ASSERT ( ip - > i_d . di_format ! = XFS_DINODE_FMT_BTREE | |
2011-12-19 00:00:07 +04:00
ip - > i_d . di_nextents > XFS_IFORK_MAXEXT ( ip , XFS_DATA_FORK ) ) ;
2013-04-03 09:11:17 +04:00
ASSERT ( iip ! = NULL & & iip - > ili_fields ! = 0 ) ;
2005-04-17 02:20:36 +04:00
/* set *dip = inode's place in the buffer */
2015-06-22 02:44:29 +03:00
dip = xfs_buf_offset ( bp , ip - > i_imap . im_boffset ) ;
2005-04-17 02:20:36 +04:00
2011-07-08 16:36:05 +04:00
if ( XFS_TEST_ERROR ( dip - > di_magic ! = cpu_to_be16 ( XFS_DINODE_MAGIC ) ,
2017-06-21 03:54:47 +03:00
mp , XFS_ERRTAG_IFLUSH_1 ) ) {
2011-03-07 02:02:35 +03:00
xfs_alert_tag ( mp , XFS_PTAG_IFLUSH ,
2018-01-09 23:02:55 +03:00
" %s: Bad inode %Lu magic number 0x%x, ptr " PTR_FMT ,
2011-03-07 02:02:35 +03:00
__func__ , ip - > i_ino , be16_to_cpu ( dip - > di_magic ) , dip ) ;
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
}
2016-02-09 08:54:58 +03:00
if ( S_ISREG ( VFS_I ( ip ) - > i_mode ) ) {
2005-04-17 02:20:36 +04:00
if ( XFS_TEST_ERROR (
( ip - > i_d . di_format ! = XFS_DINODE_FMT_EXTENTS ) & &
( ip - > i_d . di_format ! = XFS_DINODE_FMT_BTREE ) ,
2017-06-21 03:54:47 +03:00
mp , XFS_ERRTAG_IFLUSH_3 ) ) {
2011-03-07 02:02:35 +03:00
xfs_alert_tag ( mp , XFS_PTAG_IFLUSH ,
2018-01-09 23:02:55 +03:00
" %s: Bad regular inode %Lu, ptr " PTR_FMT ,
2011-03-07 02:02:35 +03:00
__func__ , ip - > i_ino , ip ) ;
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
}
2016-02-09 08:54:58 +03:00
} else if ( S_ISDIR ( VFS_I ( ip ) - > i_mode ) ) {
2005-04-17 02:20:36 +04:00
if ( XFS_TEST_ERROR (
( ip - > i_d . di_format ! = XFS_DINODE_FMT_EXTENTS ) & &
( ip - > i_d . di_format ! = XFS_DINODE_FMT_BTREE ) & &
( ip - > i_d . di_format ! = XFS_DINODE_FMT_LOCAL ) ,
2017-06-21 03:54:47 +03:00
mp , XFS_ERRTAG_IFLUSH_4 ) ) {
2011-03-07 02:02:35 +03:00
xfs_alert_tag ( mp , XFS_PTAG_IFLUSH ,
2018-01-09 23:02:55 +03:00
" %s: Bad directory inode %Lu, ptr " PTR_FMT ,
2011-03-07 02:02:35 +03:00
__func__ , ip - > i_ino , ip ) ;
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
}
}
if ( XFS_TEST_ERROR ( ip - > i_d . di_nextents + ip - > i_d . di_anextents >
2017-06-21 03:54:47 +03:00
ip - > i_d . di_nblocks , mp , XFS_ERRTAG_IFLUSH_5 ) ) {
2011-03-07 02:02:35 +03:00
xfs_alert_tag ( mp , XFS_PTAG_IFLUSH ,
" %s: detected corrupt incore inode %Lu, "
2018-01-09 23:02:55 +03:00
" total extents = %d, nblocks = %Ld, ptr " PTR_FMT ,
2011-03-07 02:02:35 +03:00
__func__ , ip - > i_ino ,
2005-04-17 02:20:36 +04:00
ip - > i_d . di_nextents + ip - > i_d . di_anextents ,
2011-03-07 02:02:35 +03:00
ip - > i_d . di_nblocks , ip ) ;
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
}
if ( XFS_TEST_ERROR ( ip - > i_d . di_forkoff > mp - > m_sb . sb_inodesize ,
2017-06-21 03:54:47 +03:00
mp , XFS_ERRTAG_IFLUSH_6 ) ) {
2011-03-07 02:02:35 +03:00
xfs_alert_tag ( mp , XFS_PTAG_IFLUSH ,
2018-01-09 23:02:55 +03:00
" %s: bad inode %Lu, forkoff 0x%x, ptr " PTR_FMT ,
2011-03-07 02:02:35 +03:00
__func__ , ip - > i_ino , ip - > i_d . di_forkoff , ip ) ;
2005-04-17 02:20:36 +04:00
goto corrupt_out ;
}
xfs: di_flushiter considered harmful
When we made all inode updates transactional, we no longer needed
the log recovery detection for inodes being newer on disk than the
transaction being replayed - it was redundant as replay of the log
would always result in the latest version of the inode would be on
disk. It was redundant, but left in place because it wasn't
considered to be a problem.
However, with the new "don't read inodes on create" optimisation,
flushiter has come back to bite us. Essentially, the optimisation
made always initialises flushiter to zero in the create transaction,
and so if we then crash and run recovery and the inode already on
disk has a non-zero flushiter it will skip recovery of that inode.
As a result, log recovery does the wrong thing and we end up with a
corrupt filesystem.
Because we have to support old kernel to new kernel upgrades, we
can't just get rid of the flushiter support in log recovery as we
might be upgrading from a kernel that doesn't have fully transactional
inode updates. Unfortunately, for v4 superblocks there is no way to
guarantee that log recovery knows about this fact.
We cannot add a new inode format flag to say it's a "special inode
create" because it won't be understood by older kernels and so
recovery could do the wrong thing on downgrade. We cannot specially
detect the combination of zero mode/non-zero flushiter on disk to
non-zero mode, zero flushiter in the log item during recovery
because wrapping of the flushiter can result in false detection.
Hence that makes this "don't use flushiter" optimisation limited to
a disk format that guarantees that we don't need it. And that means
the only fix here is to limit the "no read IO on create"
optimisation to version 5 superblocks....
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-07-24 09:47:30 +04:00
2005-04-17 02:20:36 +04:00
/*
2014-05-20 01:46:40 +04:00
* Inode item log recovery for v2 inodes are dependent on the
xfs: di_flushiter considered harmful
When we made all inode updates transactional, we no longer needed
the log recovery detection for inodes being newer on disk than the
transaction being replayed - it was redundant as replay of the log
would always result in the latest version of the inode would be on
disk. It was redundant, but left in place because it wasn't
considered to be a problem.
However, with the new "don't read inodes on create" optimisation,
flushiter has come back to bite us. Essentially, the optimisation
made always initialises flushiter to zero in the create transaction,
and so if we then crash and run recovery and the inode already on
disk has a non-zero flushiter it will skip recovery of that inode.
As a result, log recovery does the wrong thing and we end up with a
corrupt filesystem.
Because we have to support old kernel to new kernel upgrades, we
can't just get rid of the flushiter support in log recovery as we
might be upgrading from a kernel that doesn't have fully transactional
inode updates. Unfortunately, for v4 superblocks there is no way to
guarantee that log recovery knows about this fact.
We cannot add a new inode format flag to say it's a "special inode
create" because it won't be understood by older kernels and so
recovery could do the wrong thing on downgrade. We cannot specially
detect the combination of zero mode/non-zero flushiter on disk to
non-zero mode, zero flushiter in the log item during recovery
because wrapping of the flushiter can result in false detection.
Hence that makes this "don't use flushiter" optimisation limited to
a disk format that guarantees that we don't need it. And that means
the only fix here is to limit the "no read IO on create"
optimisation to version 5 superblocks....
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-07-24 09:47:30 +04:00
* di_flushiter count for correct sequencing . We bump the flush
* iteration count so we can detect flushes which postdate a log record
* during recovery . This is redundant as we now log every change and
* hence this can ' t happen but we need to still do it to ensure
* backwards compatibility with old kernels that predate logging all
* inode changes .
2005-04-17 02:20:36 +04:00
*/
2020-03-18 18:15:11 +03:00
if ( ! xfs_sb_version_has_v3inode ( & mp - > m_sb ) )
xfs: di_flushiter considered harmful
When we made all inode updates transactional, we no longer needed
the log recovery detection for inodes being newer on disk than the
transaction being replayed - it was redundant as replay of the log
would always result in the latest version of the inode would be on
disk. It was redundant, but left in place because it wasn't
considered to be a problem.
However, with the new "don't read inodes on create" optimisation,
flushiter has come back to bite us. Essentially, the optimisation
made always initialises flushiter to zero in the create transaction,
and so if we then crash and run recovery and the inode already on
disk has a non-zero flushiter it will skip recovery of that inode.
As a result, log recovery does the wrong thing and we end up with a
corrupt filesystem.
Because we have to support old kernel to new kernel upgrades, we
can't just get rid of the flushiter support in log recovery as we
might be upgrading from a kernel that doesn't have fully transactional
inode updates. Unfortunately, for v4 superblocks there is no way to
guarantee that log recovery knows about this fact.
We cannot add a new inode format flag to say it's a "special inode
create" because it won't be understood by older kernels and so
recovery could do the wrong thing on downgrade. We cannot specially
detect the combination of zero mode/non-zero flushiter on disk to
non-zero mode, zero flushiter in the log item during recovery
because wrapping of the flushiter can result in false detection.
Hence that makes this "don't use flushiter" optimisation limited to
a disk format that guarantees that we don't need it. And that means
the only fix here is to limit the "no read IO on create"
optimisation to version 5 superblocks....
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-07-24 09:47:30 +04:00
ip - > i_d . di_flushiter + + ;
2005-04-17 02:20:36 +04:00
2018-01-08 21:51:06 +03:00
/* Check the inline fork data before we write out. */
if ( ! xfs_inode_verify_forks ( ip ) )
2017-03-29 00:51:10 +03:00
goto corrupt_out ;
2005-04-17 02:20:36 +04:00
/*
2016-02-09 08:54:58 +03:00
* Copy the dirty parts of the inode into the on - disk inode . We always
* copy out the core of the inode , because if the inode is dirty at all
* the core must be .
2005-04-17 02:20:36 +04:00
*/
2016-02-09 08:54:58 +03:00
xfs_inode_to_disk ( ip , dip , iip - > ili_item . li_lsn ) ;
2005-04-17 02:20:36 +04:00
/* Wrap, we never let the log put out DI_MAX_FLUSH */
if ( ip - > i_d . di_flushiter = = DI_MAX_FLUSH )
ip - > i_d . di_flushiter = 0 ;
2017-03-29 00:51:10 +03:00
xfs_iflush_fork ( ip , dip , iip , XFS_DATA_FORK ) ;
if ( XFS_IFORK_Q ( ip ) )
xfs_iflush_fork ( ip , dip , iip , XFS_ATTR_FORK ) ;
2005-04-17 02:20:36 +04:00
xfs_inobp_check ( mp , bp ) ;
/*
2012-02-29 13:53:54 +04:00
* We ' ve recorded everything logged in the inode , so we ' d like to clear
* the ili_fields bits so we don ' t log and flush things unnecessarily .
* However , we can ' t stop logging all this information until the data
* we ' ve copied into the disk buffer is written to disk . If we did we
* might overwrite the copy of the inode in the log with all the data
* after re - logging only part of it , and in the face of a crash we
* wouldn ' t have all the data we need to recover .
2005-04-17 02:20:36 +04:00
*
2012-02-29 13:53:54 +04:00
* What we do is move the bits to the ili_last_fields field . When
* logging the inode , these bits are moved back to the ili_fields field .
* In the xfs_iflush_done ( ) routine we clear ili_last_fields , since we
* know that the information those bits represent is permanently on
* disk . As long as the flush completes before the inode is logged
* again , then both ili_fields and ili_last_fields will be cleared .
2005-04-17 02:20:36 +04:00
*
2012-02-29 13:53:54 +04:00
* We can play with the ili_fields bits here , because the inode lock
* must be held exclusively in order to set bits there and the flush
* lock protects the ili_last_fields bits . Set ili_logged so the flush
* done routine can tell whether or not to look in the AIL . Also , store
* the current LSN of the inode so that we can tell whether the item has
* moved in the AIL from xfs_iflush_done ( ) . In order to read the lsn we
* need the AIL lock , because it is a 64 bit value that cannot be read
* atomically .
2005-04-17 02:20:36 +04:00
*/
2013-04-03 09:11:17 +04:00
iip - > ili_last_fields = iip - > ili_fields ;
iip - > ili_fields = 0 ;
xfs: optimise away log forces on timestamp updates for fdatasync
xfs: timestamp updates cause excessive fdatasync log traffic
Sage Weil reported that a ceph test workload was writing to the
log on every fdatasync during an overwrite workload. Event tracing
showed that the only metadata modification being made was the
timestamp updates during the write(2) syscall, but fdatasync(2)
is supposed to ignore them. The key observation was that the
transactions in the log all looked like this:
INODE: #regs: 4 ino: 0x8b flags: 0x45 dsize: 32
And contained a flags field of 0x45 or 0x85, and had data and
attribute forks following the inode core. This means that the
timestamp updates were triggering dirty relogging of previously
logged parts of the inode that hadn't yet been flushed back to
disk.
There are two parts to this problem. The first is that XFS relogs
dirty regions in subsequent transactions, so it carries around the
fields that have been dirtied since the last time the inode was
written back to disk, not since the last time the inode was forced
into the log.
The second part is that on v5 filesystems, the inode change count
update during inode dirtying also sets the XFS_ILOG_CORE flag, so
on v5 filesystems this makes a timestamp update dirty the entire
inode.
As a result when fdatasync is run, it looks at the dirty fields in
the inode, and sees more than just the timestamp flag, even though
the only metadata change since the last fdatasync was just the
timestamps. Hence we force the log on every subsequent fdatasync
even though it is not needed.
To fix this, add a new field to the inode log item that tracks
changes since the last time fsync/fdatasync forced the log to flush
the changes to the journal. This flag is updated when we dirty the
inode, but we do it before updating the change count so it does not
carry the "core dirty" flag from timestamp updates. The fields are
zeroed when the inode is marked clean (due to writeback/freeing) or
when an fsync/datasync forces the log. Hence if we only dirty the
timestamps on the inode between fsync/fdatasync calls, the fdatasync
will not trigger another log force.
Over 100 runs of the test program:
Ext4 baseline:
runtime: 1.63s +/- 0.24s
avg lat: 1.59ms +/- 0.24ms
iops: ~2000
XFS, vanilla kernel:
runtime: 2.45s +/- 0.18s
avg lat: 2.39ms +/- 0.18ms
log forces: ~400/s
iops: ~1000
XFS, patched kernel:
runtime: 1.49s +/- 0.26s
avg lat: 1.46ms +/- 0.25ms
log forces: ~30/s
iops: ~1500
Reported-by: Sage Weil <sage@redhat.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-11-03 05:14:59 +03:00
iip - > ili_fsync_fields = 0 ;
2013-04-03 09:11:17 +04:00
iip - > ili_logged = 1 ;
2005-04-17 02:20:36 +04:00
2013-04-03 09:11:17 +04:00
xfs_trans_ail_copy_lsn ( mp - > m_ail , & iip - > ili_flush_lsn ,
& iip - > ili_item . li_lsn ) ;
2005-04-17 02:20:36 +04:00
2013-04-03 09:11:17 +04:00
/*
* Attach the function xfs_iflush_done to the inode ' s
* buffer . This will remove the inode from the AIL
* and unlock the inode ' s flush lock when the inode is
* completely written to disk .
*/
xfs_buf_attach_iodone ( bp , xfs_iflush_done , & iip - > ili_item ) ;
2005-04-17 02:20:36 +04:00
2013-04-03 09:11:17 +04:00
/* generate the checksum. */
xfs_dinode_calc_crc ( mp , dip ) ;
2005-04-17 02:20:36 +04:00
2018-01-25 00:38:49 +03:00
ASSERT ( ! list_empty ( & bp - > b_li_list ) ) ;
2013-04-03 09:11:17 +04:00
ASSERT ( bp - > b_iodone ! = NULL ) ;
2005-04-17 02:20:36 +04:00
return 0 ;
corrupt_out :
2014-06-25 08:58:08 +04:00
return - EFSCORRUPTED ;
2005-04-17 02:20:36 +04:00
}
2018-07-25 22:52:32 +03:00
/* Release an inode. */
void
xfs_irele (
struct xfs_inode * ip )
{
trace_xfs_irele ( ip , _RET_IP_ ) ;
iput ( VFS_I ( ip ) ) ;
}
2020-04-03 21:45:37 +03:00
/*
* Ensure all commited transactions touching the inode are written to the log .
*/
int
xfs_log_force_inode (
struct xfs_inode * ip )
{
xfs_lsn_t lsn = 0 ;
xfs_ilock ( ip , XFS_ILOCK_SHARED ) ;
if ( xfs_ipincount ( ip ) )
lsn = ip - > i_itemp - > ili_last_lsn ;
xfs_iunlock ( ip , XFS_ILOCK_SHARED ) ;
if ( ! lsn )
return 0 ;
return xfs_log_force_lsn ( ip - > i_mount , lsn , XFS_LOG_SYNC , NULL ) ;
}