2019-05-27 09:55:01 +03:00
// SPDX-License-Identifier: GPL-2.0-or-later
2012-11-15 12:49:18 +04:00
/*
* IPV6 GSO / GRO offload support
* Linux INET6 implementation
*
* UDPv6 GSO support
*/
# include <linux/skbuff.h>
2014-08-23 00:34:44 +04:00
# include <linux/netdevice.h>
2018-12-14 13:51:59 +03:00
# include <linux/indirect_call_wrapper.h>
2012-11-15 12:49:18 +04:00
# include <net/protocol.h>
# include <net/ipv6.h>
# include <net/udp.h>
2012-11-15 20:35:37 +04:00
# include <net/ip6_checksum.h>
2012-11-15 12:49:18 +04:00
# include "ip6_offload.h"
2021-11-15 20:05:51 +03:00
# include <net/gro.h>
2023-06-08 22:17:37 +03:00
# include <net/gso.h>
2012-11-15 12:49:18 +04:00
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
static struct sk_buff * udp6_ufo_fragment ( struct sk_buff * skb ,
netdev_features_t features )
2012-11-15 12:49:18 +04:00
{
struct sk_buff * segs = ERR_PTR ( - EINVAL ) ;
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
unsigned int mss ;
unsigned int unfrag_ip6hlen , unfrag_len ;
struct frag_hdr * fptr ;
u8 * packet_start , * prevhdr ;
u8 nexthdr ;
u8 frag_hdr_sz = sizeof ( struct frag_hdr ) ;
__wsum csum ;
int tnl_hlen ;
int err ;
2014-06-05 04:20:16 +04:00
if ( skb - > encapsulation & & skb_shinfo ( skb ) - > gso_type &
( SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP_TUNNEL_CSUM ) )
2014-09-30 07:22:29 +04:00
segs = skb_udp_tunnel_segment ( skb , features , true ) ;
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
else {
const struct ipv6hdr * ipv6h ;
struct udphdr * uh ;
2018-04-26 20:42:16 +03:00
if ( ! ( skb_shinfo ( skb ) - > gso_type & ( SKB_GSO_UDP | SKB_GSO_UDP_L4 ) ) )
2018-01-19 17:29:18 +03:00
goto out ;
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
if ( ! pskb_may_pull ( skb , sizeof ( struct udphdr ) ) )
goto out ;
2023-07-13 20:28:00 +03:00
if ( skb_shinfo ( skb ) - > gso_type & SKB_GSO_UDP_L4 )
2021-01-30 02:13:27 +03:00
return __udp_gso_segment ( skb , features , true ) ;
2018-04-26 20:42:16 +03:00
2020-10-29 10:04:56 +03:00
mss = skb_shinfo ( skb ) - > gso_size ;
if ( unlikely ( skb - > len < = mss ) )
goto out ;
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
/* Do software UFO. Complete and fill in the UDP checksum as HW cannot
* do checksum of UDP packets sent as multiple IP fragments .
*/
uh = udp_hdr ( skb ) ;
ipv6h = ipv6_hdr ( skb ) ;
uh - > check = 0 ;
csum = skb_checksum ( skb , 0 , skb - > len , 0 ) ;
uh - > check = udp_v6_check ( skb - > len , & ipv6h - > saddr ,
& ipv6h - > daddr , csum ) ;
if ( uh - > check = = 0 )
uh - > check = CSUM_MANGLED_0 ;
skb - > ip_summed = CHECKSUM_UNNECESSARY ;
/* If there is no outer header we can fake a checksum offload
* due to the fact that we have already done the checksum in
* software prior to segmenting the frame .
*/
if ( ! skb - > encap_hdr_csum )
features | = NETIF_F_HW_CSUM ;
/* Check if there is enough headroom to insert fragment header. */
tnl_hlen = skb_tnl_header_len ( skb ) ;
if ( skb - > mac_header < ( tnl_hlen + frag_hdr_sz ) ) {
if ( gso_pskb_expand_head ( skb , tnl_hlen + frag_hdr_sz ) )
goto out ;
}
/* Find the unfragmentable header and shift it left by frag_hdr_sz
* bytes to insert fragment header .
*/
err = ip6_find_1stfragopt ( skb , & prevhdr ) ;
if ( err < 0 )
return ERR_PTR ( err ) ;
unfrag_ip6hlen = err ;
nexthdr = * prevhdr ;
* prevhdr = NEXTHDR_FRAGMENT ;
unfrag_len = ( skb_network_header ( skb ) - skb_mac_header ( skb ) ) +
unfrag_ip6hlen + tnl_hlen ;
packet_start = ( u8 * ) skb - > head + SKB_GSO_CB ( skb ) - > mac_offset ;
memmove ( packet_start - frag_hdr_sz , packet_start , unfrag_len ) ;
SKB_GSO_CB ( skb ) - > mac_offset - = frag_hdr_sz ;
skb - > mac_header - = frag_hdr_sz ;
skb - > network_header - = frag_hdr_sz ;
fptr = ( struct frag_hdr * ) ( skb_network_header ( skb ) + unfrag_ip6hlen ) ;
fptr - > nexthdr = nexthdr ;
fptr - > reserved = 0 ;
fptr - > identification = ipv6_proxy_select_ident ( dev_net ( skb - > dev ) , skb ) ;
/* Fragment the skb. ipv6 header and the remaining fields of the
* fragment header are updated in ipv6_gso_segment ( )
*/
segs = skb_segment ( skb , features ) ;
}
2012-11-15 12:49:18 +04:00
net: accept UFO datagrams from tuntap and packet
Tuntap and similar devices can inject GSO packets. Accept type
VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively.
Processes are expected to use feature negotiation such as TUNSETOFFLOAD
to detect supported offload types and refrain from injecting other
packets. This process breaks down with live migration: guest kernels
do not renegotiate flags, so destination hosts need to expose all
features that the source host does.
Partially revert the UFO removal from 182e0b6b5846~1..d9d30adf5677.
This patch introduces nearly(*) no new code to simplify verification.
It brings back verbatim tuntap UFO negotiation, VIRTIO_NET_HDR_GSO_UDP
insertion and software UFO segmentation.
It does not reinstate protocol stack support, hardware offload
(NETIF_F_UFO), SKB_GSO_UDP tunneling in SKB_GSO_SOFTWARE or reception
of VIRTIO_NET_HDR_GSO_UDP packets in tuntap.
To support SKB_GSO_UDP reappearing in the stack, also reinstate
logic in act_csum and openvswitch. Achieve equivalence with v4.13 HEAD
by squashing in commit 939912216fa8 ("net: skb_needs_check() removes
CHECKSUM_UNNECESSARY check for tx.") and reverting commit 8d63bee643f1
("net: avoid skb_warn_bad_offload false positives on UFO").
(*) To avoid having to bring back skb_shinfo(skb)->ip6_frag_id,
ipv6_proxy_select_ident is changed to return a __be32 and this is
assigned directly to the frag_hdr. Also, SKB_GSO_UDP is inserted
at the end of the enum to minimize code churn.
Tested
Booted a v4.13 guest kernel with QEMU. On a host kernel before this
patch `ethtool -k eth0` shows UFO disabled. After the patch, it is
enabled, same as on a v4.13 host kernel.
A UFO packet sent from the guest appears on the tap device:
host:
nc -l -p -u 8000 &
tcpdump -n -i tap0
guest:
dd if=/dev/zero of=payload.txt bs=1 count=2000
nc -u 192.16.1.1 8000 < payload.txt
Direct tap to tap transmission of VIRTIO_NET_HDR_GSO_UDP succeeds,
packets arriving fragmented:
./with_tap_pair.sh ./tap_send_ufo tap0 tap1
(from https://github.com/wdebruij/kerneltools/tree/master/tests)
Changes
v1 -> v2
- simplified set_offload change (review comment)
- documented test procedure
Link: http://lkml.kernel.org/r/<CAF=yD-LuUeDuL9YWPJD9ykOZ0QCjNeznPDr6whqZ9NGMNF12Mw@mail.gmail.com>
Fixes: fb652fdfe837 ("macvlan/macvtap: Remove NETIF_F_UFO advertisement.")
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-11-21 18:22:25 +03:00
out :
2012-11-15 12:49:18 +04:00
return segs ;
}
2014-08-23 00:34:44 +04:00
2020-11-11 23:45:38 +03:00
static struct sock * udp6_gro_lookup_skb ( struct sk_buff * skb , __be16 sport ,
__be16 dport )
{
const struct ipv6hdr * iph = skb_gro_network_header ( skb ) ;
2022-11-15 00:57:56 +03:00
struct net * net = dev_net ( skb - > dev ) ;
2023-07-27 18:33:56 +03:00
int iif , sdif ;
inet6_get_iif_sdif ( skb , & iif , & sdif ) ;
2020-11-11 23:45:38 +03:00
2022-11-15 00:57:56 +03:00
return __udp6_lib_lookup ( net , & iph - > saddr , sport ,
2023-07-27 18:33:56 +03:00
& iph - > daddr , dport , iif ,
sdif , net - > ipv4 . udp_table , NULL ) ;
2020-11-11 23:45:38 +03:00
}
2018-12-14 13:51:59 +03:00
INDIRECT_CALLABLE_SCOPE
struct sk_buff * udp6_gro_receive ( struct list_head * head , struct sk_buff * skb )
2014-08-23 00:34:44 +04:00
{
struct udphdr * uh = udp_gro_udphdr ( skb ) ;
2020-11-11 23:45:38 +03:00
struct sock * sk = NULL ;
2020-01-25 13:26:45 +03:00
struct sk_buff * pp ;
2014-08-23 00:34:44 +04:00
2020-01-25 13:26:45 +03:00
if ( unlikely ( ! uh ) )
2014-09-01 02:12:43 +04:00
goto flush ;
2014-08-23 00:34:44 +04:00
/* Don't bother verifying checksum if we're going to flush anyway. */
2014-09-11 06:23:18 +04:00
if ( NAPI_GRO_CB ( skb ) - > flush )
2014-09-01 02:12:43 +04:00
goto skip ;
2014-08-23 00:34:44 +04:00
2014-09-01 02:12:43 +04:00
if ( skb_gro_checksum_validate_zero_check ( skb , IPPROTO_UDP , uh - > check ,
ip6_gro_compute_pseudo ) )
goto flush ;
else if ( uh - > check )
2020-01-03 06:51:00 +03:00
skb_gro_checksum_try_convert ( skb , IPPROTO_UDP ,
2014-09-01 02:12:43 +04:00
ip6_gro_compute_pseudo ) ;
skip :
2014-10-04 02:48:08 +04:00
NAPI_GRO_CB ( skb ) - > is_ipv6 = 1 ;
2020-11-11 23:45:38 +03:00
if ( static_branch_unlikely ( & udpv6_encap_needed_key ) )
sk = udp6_gro_lookup_skb ( skb , uh - > source , uh - > dest ) ;
2020-01-25 13:26:45 +03:00
pp = udp_gro_receive ( head , skb , uh , sk ) ;
return pp ;
2014-09-01 02:12:43 +04:00
flush :
NAPI_GRO_CB ( skb ) - > flush = 1 ;
return NULL ;
2014-08-23 00:34:44 +04:00
}
2018-12-14 13:51:59 +03:00
INDIRECT_CALLABLE_SCOPE int udp6_gro_complete ( struct sk_buff * skb , int nhoff )
2014-08-23 00:34:44 +04:00
{
net: gro: fix udp bad offset in socket lookup by adding {inner_}network_offset to napi_gro_cb
Commits a602456 ("udp: Add GRO functions to UDP socket") and 57c67ff ("udp:
additional GRO support") introduce incorrect usage of {ip,ipv6}_hdr in the
complete phase of gro. The functions always return skb->network_header,
which in the case of encapsulated packets at the gro complete phase, is
always set to the innermost L3 of the packet. That means that calling
{ip,ipv6}_hdr for skbs which completed the GRO receive phase (both in
gro_list and *_gro_complete) when parsing an encapsulated packet's _outer_
L3/L4 may return an unexpected value.
This incorrect usage leads to a bug in GRO's UDP socket lookup.
udp{4,6}_lib_lookup_skb functions use ip_hdr/ipv6_hdr respectively. These
*_hdr functions return network_header which will point to the innermost L3,
resulting in the wrong offset being used in __udp{4,6}_lib_lookup with
encapsulated packets.
This patch adds network_offset and inner_network_offset to napi_gro_cb, and
makes sure both are set correctly.
To fix the issue, network_offsets union is used inside napi_gro_cb, in
which both the outer and the inner network offsets are saved.
Reproduction example:
Endpoint configuration example (fou + local address bind)
# ip fou add port 6666 ipproto 4
# ip link add name tun1 type ipip remote 2.2.2.1 local 2.2.2.2 encap fou encap-dport 5555 encap-sport 6666 mode ipip
# ip link set tun1 up
# ip a add 1.1.1.2/24 dev tun1
Netperf TCP_STREAM result on net-next before patch is applied:
net-next main, GRO enabled:
$ netperf -H 1.1.1.2 -t TCP_STREAM -l 5
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
131072 16384 16384 5.28 2.37
net-next main, GRO disabled:
$ netperf -H 1.1.1.2 -t TCP_STREAM -l 5
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
131072 16384 16384 5.01 2745.06
patch applied, GRO enabled:
$ netperf -H 1.1.1.2 -t TCP_STREAM -l 5
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
131072 16384 16384 5.01 2877.38
Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2024-04-30 17:35:54 +03:00
const u16 offset = NAPI_GRO_CB ( skb ) - > network_offsets [ skb - > encapsulation ] ;
const struct ipv6hdr * ipv6h = ( struct ipv6hdr * ) ( skb - > data + offset ) ;
2014-08-23 00:34:44 +04:00
struct udphdr * uh = ( struct udphdr * ) ( skb - > data + nhoff ) ;
udp: properly complete L4 GRO over UDP tunnel packet
After the previous patch, the stack can do L4 UDP aggregation
on top of a UDP tunnel.
In such scenario, udp{4,6}_gro_complete will be called twice. This function
will enter its is_flist branch immediately, even though that is only
correct on the second call, as GSO_FRAGLIST is only relevant for the
inner packet.
Instead, we need to try first UDP tunnel-based aggregation, if the GRO
packet requires that.
This patch changes udp{4,6}_gro_complete to skip the frag list processing
when while encap_mark == 1, identifying processing of the outer tunnel
header.
Additionally, clears the field in udp_gro_complete() so that we can enter
the frag list path on the next round, for the inner header.
v1 -> v2:
- hopefully clarified the commit message
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-03-30 13:28:51 +03:00
/* do fraglist only if there is no outer UDP encap (or we already processed it) */
if ( NAPI_GRO_CB ( skb ) - > is_flist & & ! NAPI_GRO_CB ( skb ) - > encap_mark ) {
2020-01-25 13:26:45 +03:00
uh - > len = htons ( skb - > len - nhoff ) ;
skb_shinfo ( skb ) - > gso_type | = ( SKB_GSO_FRAGLIST | SKB_GSO_UDP_L4 ) ;
skb_shinfo ( skb ) - > gso_segs = NAPI_GRO_CB ( skb ) - > count ;
2024-03-26 14:34:00 +03:00
__skb_incr_checksum_unnecessary ( skb ) ;
2020-01-25 13:26:45 +03:00
return 0 ;
}
2018-11-07 14:38:29 +03:00
if ( uh - > check )
2014-08-23 00:34:44 +04:00
uh - > check = ~ udp_v6_check ( skb - > len - nhoff , & ipv6h - > saddr ,
& ipv6h - > daddr , 0 ) ;
2016-04-05 18:22:51 +03:00
return udp_gro_complete ( skb , nhoff , udp6_lib_lookup_skb ) ;
2014-08-23 00:34:44 +04:00
}
2024-03-06 19:00:24 +03:00
int __init udpv6_offload_init ( void )
2012-11-15 12:49:18 +04:00
{
2024-03-06 19:00:24 +03:00
net_hotdata . udpv6_offload = ( struct net_offload ) {
. callbacks = {
. gso_segment = udp6_ufo_fragment ,
. gro_receive = udp6_gro_receive ,
. gro_complete = udp6_gro_complete ,
} ,
} ;
return inet6_add_offload ( & net_hotdata . udpv6_offload , IPPROTO_UDP ) ;
2012-11-15 12:49:18 +04:00
}
2016-04-05 18:22:51 +03:00
int udpv6_offload_exit ( void )
{
2024-03-06 19:00:24 +03:00
return inet6_del_offload ( & net_hotdata . udpv6_offload , IPPROTO_UDP ) ;
2016-04-05 18:22:51 +03:00
}