2019-08-25 12:49:16 +03:00
// SPDX-License-Identifier: GPL-2.0
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
/*
2007-10-16 12:26:43 +04:00
* Copyright ( C ) 2001 - 2007 Jeff Dike ( jdike @ { addtoit , linux . intel } . com )
2005-04-17 02:20:36 +04:00
*/
2012-10-08 06:27:32 +04:00
# include <linux/irqreturn.h>
# include <linux/kd.h>
2017-02-08 20:51:30 +03:00
# include <linux/sched/signal.h>
2012-10-08 06:27:32 +04:00
# include <linux/slab.h>
2017-02-08 20:51:30 +03:00
2011-08-18 23:08:29 +04:00
# include "chan.h"
2012-10-08 06:27:32 +04:00
# include <irq_kern.h>
# include <irq_user.h>
# include <kern_util.h>
# include <os.h>
2005-04-17 02:20:36 +04:00
# define LINE_BUFSIZE 4096
2006-10-09 01:49:34 +04:00
static irqreturn_t line_interrupt ( int irq , void * data )
2005-04-17 02:20:36 +04:00
{
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
struct chan * chan = data ;
struct line * line = chan - > line ;
2005-04-17 02:20:36 +04:00
if ( line )
2013-01-03 18:53:06 +04:00
chan_interrupt ( line , irq ) ;
2005-04-17 02:20:36 +04:00
return IRQ_HANDLED ;
}
2007-10-16 12:26:43 +04:00
/*
* Returns the free space inside the ring buffer of this line .
2005-05-01 19:58:56 +04:00
*
2007-10-20 03:23:03 +04:00
* Should be called while holding line - > lock ( this does not modify data ) .
2005-05-01 19:58:56 +04:00
*/
2021-05-05 12:19:15 +03:00
static unsigned int write_room ( struct line * line )
2005-04-17 02:20:36 +04:00
{
int n ;
2005-05-01 19:58:56 +04:00
if ( line - > buffer = = NULL )
return LINE_BUFSIZE - 1 ;
/* This is for the case where the buffer is wrapped! */
n = line - > head - line - > tail ;
2005-04-17 02:20:36 +04:00
if ( n < = 0 )
2008-02-05 09:30:42 +03:00
n + = LINE_BUFSIZE ; /* The other case */
2005-05-01 19:58:56 +04:00
return n - 1 ;
}
2021-05-05 12:19:15 +03:00
unsigned int line_write_room ( struct tty_struct * tty )
2005-05-01 19:58:56 +04:00
{
struct line * line = tty - > driver_data ;
unsigned long flags ;
2021-05-05 12:19:15 +03:00
unsigned int room ;
2005-05-01 19:58:56 +04:00
spin_lock_irqsave ( & line - > lock , flags ) ;
room = write_room ( line ) ;
spin_unlock_irqrestore ( & line - > lock , flags ) ;
return room ;
2005-04-17 02:20:36 +04:00
}
2021-05-05 12:19:19 +03:00
unsigned int line_chars_in_buffer ( struct tty_struct * tty )
2005-05-01 19:58:56 +04:00
{
struct line * line = tty - > driver_data ;
unsigned long flags ;
2021-05-05 12:19:19 +03:00
unsigned int ret ;
2005-05-01 19:58:56 +04:00
spin_lock_irqsave ( & line - > lock , flags ) ;
2008-02-05 09:30:42 +03:00
/* write_room subtracts 1 for the needed NULL, so we readd it.*/
2005-05-01 19:58:56 +04:00
ret = LINE_BUFSIZE - ( write_room ( line ) + 1 ) ;
spin_unlock_irqrestore ( & line - > lock , flags ) ;
return ret ;
}
/*
* This copies the content of buf into the circular buffer associated with
* this line .
* The return value is the number of characters actually copied , i . e . the ones
* for which there was space : this function is not supposed to ever flush out
* the circular buffer .
*
* Must be called while holding line - > lock !
*/
2005-04-17 02:20:36 +04:00
static int buffer_data ( struct line * line , const char * buf , int len )
{
int end , room ;
2007-10-16 12:26:43 +04:00
if ( line - > buffer = = NULL ) {
2005-04-17 02:20:36 +04:00
line - > buffer = kmalloc ( LINE_BUFSIZE , GFP_ATOMIC ) ;
if ( line - > buffer = = NULL ) {
2007-10-16 12:26:43 +04:00
printk ( KERN_ERR " buffer_data - atomic allocation "
" failed \n " ) ;
return 0 ;
2005-04-17 02:20:36 +04:00
}
line - > head = line - > buffer ;
line - > tail = line - > buffer ;
}
room = write_room ( line ) ;
len = ( len > room ) ? room : len ;
end = line - > buffer + LINE_BUFSIZE - line - > tail ;
2005-05-01 19:58:56 +04:00
2007-10-16 12:26:43 +04:00
if ( len < end ) {
2005-04-17 02:20:36 +04:00
memcpy ( line - > tail , buf , len ) ;
line - > tail + = len ;
2006-01-06 11:18:50 +03:00
}
else {
2005-05-01 19:58:56 +04:00
/* The circular buffer is wrapping */
2005-04-17 02:20:36 +04:00
memcpy ( line - > tail , buf , end ) ;
buf + = end ;
memcpy ( line - > buffer , buf , len - end ) ;
line - > tail = line - > buffer + len - end ;
}
2005-05-01 19:58:56 +04:00
return len ;
2005-04-17 02:20:36 +04:00
}
2005-05-01 19:58:56 +04:00
/*
* Flushes the ring buffer to the output channels . That is , write_chan is
* called , passing it line - > head as buffer , and an appropriate count .
*
* On exit , returns 1 when the buffer is empty ,
* 0 when the buffer is not empty on exit ,
* and - errno when an error occurred .
*
* Must be called while holding line - > lock ! */
2005-04-17 02:20:36 +04:00
static int flush_buffer ( struct line * line )
{
int n , count ;
if ( ( line - > buffer = = NULL ) | | ( line - > head = = line - > tail ) )
2005-05-01 19:58:56 +04:00
return 1 ;
2005-04-17 02:20:36 +04:00
if ( line - > tail < line - > head ) {
2005-05-01 19:58:56 +04:00
/* line->buffer + LINE_BUFSIZE is the end of the buffer! */
2005-04-17 02:20:36 +04:00
count = line - > buffer + LINE_BUFSIZE - line - > head ;
2005-05-01 19:58:56 +04:00
2011-09-08 18:49:34 +04:00
n = write_chan ( line - > chan_out , line - > head , count ,
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
line - > write_irq ) ;
2005-04-17 02:20:36 +04:00
if ( n < 0 )
2005-05-01 19:58:56 +04:00
return n ;
if ( n = = count ) {
2007-10-16 12:26:43 +04:00
/*
* We have flushed from - > head to buffer end , now we
* must flush only from the beginning to - > tail .
*/
2005-04-17 02:20:36 +04:00
line - > head = line - > buffer ;
2005-05-01 19:58:56 +04:00
} else {
2005-04-17 02:20:36 +04:00
line - > head + = n ;
2005-05-01 19:58:56 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
}
count = line - > tail - line - > head ;
2011-09-08 18:49:34 +04:00
n = write_chan ( line - > chan_out , line - > head , count ,
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
line - > write_irq ) ;
2005-05-01 19:58:56 +04:00
2007-10-16 12:26:43 +04:00
if ( n < 0 )
2005-05-01 19:58:56 +04:00
return n ;
2005-04-17 02:20:36 +04:00
line - > head + = n ;
2005-05-01 19:58:56 +04:00
return line - > head = = line - > tail ;
}
void line_flush_buffer ( struct tty_struct * tty )
{
struct line * line = tty - > driver_data ;
unsigned long flags ;
spin_lock_irqsave ( & line - > lock , flags ) ;
2011-07-26 04:12:55 +04:00
flush_buffer ( line ) ;
2005-05-01 19:58:56 +04:00
spin_unlock_irqrestore ( & line - > lock , flags ) ;
}
2007-10-16 12:26:43 +04:00
/*
* We map both - > flush_chars and - > put_char ( which go in pair ) onto
* - > flush_buffer and - > write . Hope it ' s not that bad .
*/
2005-05-01 19:58:56 +04:00
void line_flush_chars ( struct tty_struct * tty )
{
line_flush_buffer ( tty ) ;
}
2005-04-17 02:20:36 +04:00
int line_write ( struct tty_struct * tty , const unsigned char * buf , int len )
{
struct line * line = tty - > driver_data ;
unsigned long flags ;
2007-10-16 12:26:42 +04:00
int n , ret = 0 ;
2005-04-17 02:20:36 +04:00
2005-05-01 19:58:56 +04:00
spin_lock_irqsave ( & line - > lock , flags ) ;
2007-10-16 12:26:42 +04:00
if ( line - > head ! = line - > tail )
2005-04-17 02:20:36 +04:00
ret = buffer_data ( line , buf , len ) ;
2007-10-16 12:26:42 +04:00
else {
2011-09-08 18:49:34 +04:00
n = write_chan ( line - > chan_out , buf , len ,
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
line - > write_irq ) ;
2005-05-01 19:58:56 +04:00
if ( n < 0 ) {
2005-04-17 02:20:36 +04:00
ret = n ;
goto out_up ;
}
len - = n ;
ret + = n ;
2005-05-01 19:58:56 +04:00
if ( len > 0 )
2005-04-17 02:20:36 +04:00
ret + = buffer_data ( line , buf + n , len ) ;
}
2005-05-01 19:58:56 +04:00
out_up :
spin_unlock_irqrestore ( & line - > lock , flags ) ;
return ret ;
2005-04-17 02:20:36 +04:00
}
2006-01-06 11:18:58 +03:00
void line_throttle ( struct tty_struct * tty )
{
struct line * line = tty - > driver_data ;
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
deactivate_chan ( line - > chan_in , line - > read_irq ) ;
2006-01-06 11:18:58 +03:00
line - > throttled = 1 ;
}
void line_unthrottle ( struct tty_struct * tty )
{
struct line * line = tty - > driver_data ;
line - > throttled = 0 ;
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
chan_interrupt ( line , line - > read_irq ) ;
2006-01-06 11:18:58 +03:00
}
2006-10-09 01:49:34 +04:00
static irqreturn_t line_write_interrupt ( int irq , void * data )
2005-04-17 02:20:36 +04:00
{
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
struct chan * chan = data ;
struct line * line = chan - > line ;
2005-04-17 02:20:36 +04:00
int err ;
2007-10-16 12:26:43 +04:00
/*
2011-09-22 12:58:46 +04:00
* Interrupts are disabled here because genirq keep irqs disabled when
* calling the action handler .
2007-10-16 12:26:43 +04:00
*/
2005-05-01 19:58:56 +04:00
2007-03-08 07:41:12 +03:00
spin_lock ( & line - > lock ) ;
2005-04-17 02:20:36 +04:00
err = flush_buffer ( line ) ;
2005-05-01 19:58:56 +04:00
if ( err = = 0 ) {
2012-02-11 12:05:32 +04:00
spin_unlock ( & line - > lock ) ;
2005-05-01 19:58:56 +04:00
return IRQ_NONE ;
2018-09-25 10:47:13 +03:00
} else if ( ( err < 0 ) & & ( err ! = - EAGAIN ) ) {
2005-04-17 02:20:36 +04:00
line - > head = line - > buffer ;
line - > tail = line - > buffer ;
}
2007-03-08 07:41:12 +03:00
spin_unlock ( & line - > lock ) ;
2005-04-17 02:20:36 +04:00
2013-03-07 16:12:29 +04:00
tty_port_tty_wakeup ( & line - > port ) ;
2012-06-04 15:35:27 +04:00
2005-05-01 19:58:56 +04:00
return IRQ_HANDLED ;
2005-04-17 02:20:36 +04:00
}
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
int line_setup_irq ( int fd , int input , int output , struct line * line , void * data )
2005-04-17 02:20:36 +04:00
{
2006-09-27 12:50:33 +04:00
const struct line_driver * driver = line - > driver ;
2020-12-02 14:59:50 +03:00
int err ;
2005-04-17 02:20:36 +04:00
2020-12-02 14:59:50 +03:00
if ( input ) {
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
err = um_request_irq ( UM_IRQ_ALLOC , fd , IRQ_READ ,
line_interrupt , 0 ,
2012-07-17 22:18:23 +04:00
driver - > read_irq_name , data ) ;
2020-12-02 14:59:50 +03:00
if ( err < 0 )
return err ;
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
line - > read_irq = err ;
2020-12-02 14:59:50 +03:00
}
if ( output ) {
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
err = um_request_irq ( UM_IRQ_ALLOC , fd , IRQ_WRITE ,
line_write_interrupt , 0 ,
2012-07-17 22:18:23 +04:00
driver - > write_irq_name , data ) ;
2020-12-02 14:59:50 +03:00
if ( err < 0 )
return err ;
um: line: Use separate IRQs per line
Today, all possible serial lines (ssl*=) as well as all
possible consoles (con*=) each share a single interrupt
(with a fixed number) with others of the same type.
Now, if you have two lines, say ssl0 and ssl1, and one
of them is connected to an fd you cannot read (e.g. a
file), but the other gets a read interrupt, then both
of them get the interrupt since it's shared. Then, the
read() call will return EOF, since it's a file being
written and there's nothing to read (at least not at
the current offset, at the end).
Unfortunately, this is treated as a read error, and we
close this line, losing all the possible output.
It might be possible to work around this and make the
IRQ sharing work, however, now that we have dynamically
allocated IRQs that are easy to use, simply use that to
achieve separating between the events; then there's no
interrupt for that line and we never attempt the read
in the first place, thus not closing the line.
This manifested itself in the wifi hostap/hwsim tests
where the parallel script communicates via one serial
console and the kernel messages go to another (a file)
and sending data on the communication console caused
the kernel messages to stop flowing into the file.
Reported-by: Jouni Malinen <j@w1.fi>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-By: anton ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2022-05-06 16:46:12 +03:00
line - > write_irq = err ;
2020-12-02 14:59:50 +03:00
}
return 0 ;
2005-04-17 02:20:36 +04:00
}
2012-06-04 23:57:24 +04:00
static int line_activate ( struct tty_port * port , struct tty_struct * tty )
2005-04-17 02:20:36 +04:00
{
2012-06-04 23:57:24 +04:00
int ret ;
struct line * line = tty - > driver_data ;
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
2012-06-04 23:57:24 +04:00
ret = enable_chan ( line ) ;
if ( ret )
return ret ;
2007-07-16 10:38:54 +04:00
2007-10-16 12:26:43 +04:00
if ( ! line - > sigio ) {
2013-03-11 13:05:45 +04:00
chan_enable_winch ( line - > chan_out , port ) ;
2007-02-10 12:43:52 +03:00
line - > sigio = 1 ;
2005-04-17 02:20:36 +04:00
}
2011-09-08 18:49:34 +04:00
chan_window_size ( line , & tty - > winsize . ws_row ,
2012-06-04 23:57:24 +04:00
& tty - > winsize . ws_col ) ;
return 0 ;
2005-04-17 02:20:36 +04:00
}
2013-03-11 13:03:42 +04:00
static void unregister_winch ( struct tty_struct * tty ) ;
static void line_destruct ( struct tty_port * port )
{
struct tty_struct * tty = tty_port_tty_get ( port ) ;
struct line * line = tty - > driver_data ;
if ( line - > sigio ) {
unregister_winch ( tty ) ;
line - > sigio = 0 ;
}
}
2012-06-04 23:57:24 +04:00
static const struct tty_port_operations line_port_ops = {
. activate = line_activate ,
2013-03-11 13:03:42 +04:00
. destruct = line_destruct ,
2012-06-04 23:57:24 +04:00
} ;
2005-05-06 03:15:32 +04:00
2012-06-04 23:57:24 +04:00
int line_open ( struct tty_struct * tty , struct file * filp )
2005-04-17 02:20:36 +04:00
{
struct line * line = tty - > driver_data ;
2012-06-04 23:57:24 +04:00
return tty_port_open ( & line - > port , tty , filp ) ;
}
2005-05-01 19:58:56 +04:00
2012-06-04 23:57:24 +04:00
int line_install ( struct tty_driver * driver , struct tty_struct * tty ,
struct line * line )
{
int ret ;
2005-05-01 19:58:56 +04:00
2012-06-04 23:57:24 +04:00
ret = tty_standard_install ( driver , tty ) ;
if ( ret )
return ret ;
2005-05-06 03:15:32 +04:00
2012-06-04 23:57:24 +04:00
tty - > driver_data = line ;
2007-02-10 12:43:52 +03:00
2012-06-04 23:57:24 +04:00
return 0 ;
}
void line_close ( struct tty_struct * tty , struct file * filp )
{
struct line * line = tty - > driver_data ;
2005-05-06 03:15:32 +04:00
2012-06-04 23:57:24 +04:00
tty_port_close ( & line - > port , tty , filp ) ;
}
void line_hangup ( struct tty_struct * tty )
{
struct line * line = tty - > driver_data ;
tty_port_hangup ( & line - > port ) ;
2005-04-17 02:20:36 +04:00
}
void close_lines ( struct line * lines , int nlines )
{
int i ;
for ( i = 0 ; i < nlines ; i + + )
2011-09-10 16:39:18 +04:00
close_chan ( & lines [ i ] ) ;
2005-04-17 02:20:36 +04:00
}
2011-09-10 04:07:05 +04:00
int setup_one_line ( struct line * lines , int n , char * init ,
const struct chan_opts * opts , char * * error_out )
2007-02-10 12:43:52 +03:00
{
struct line * line = & lines [ n ] ;
2011-09-10 03:45:42 +04:00
struct tty_driver * driver = line - > driver - > driver ;
2007-02-10 12:43:53 +03:00
int err = - EINVAL ;
2007-02-10 12:43:52 +03:00
2012-06-04 15:35:26 +04:00
if ( line - > port . count ) {
2007-02-10 12:43:53 +03:00
* error_out = " Device is already open " ;
2007-02-10 12:43:52 +03:00
goto out ;
}
2011-09-10 03:14:02 +04:00
if ( ! strcmp ( init , " none " ) ) {
if ( line - > valid ) {
line - > valid = 0 ;
kfree ( line - > init_str ) ;
2011-09-10 03:45:42 +04:00
tty_unregister_device ( driver , n ) ;
2011-09-10 03:14:02 +04:00
parse_chan_pair ( NULL , line , n , opts , error_out ) ;
err = 0 ;
}
} else {
char * new = kstrdup ( init , GFP_KERNEL ) ;
if ( ! new ) {
* error_out = " Failed to allocate memory " ;
return - ENOMEM ;
}
2011-09-10 04:08:48 +04:00
if ( line - > valid ) {
2011-09-10 03:45:42 +04:00
tty_unregister_device ( driver , n ) ;
2011-09-10 04:08:48 +04:00
kfree ( line - > init_str ) ;
}
2011-09-10 03:14:02 +04:00
line - > init_str = new ;
2011-09-10 01:25:00 +04:00
line - > valid = 1 ;
2011-09-10 03:14:02 +04:00
err = parse_chan_pair ( new , line , n , opts , error_out ) ;
2011-09-10 03:45:42 +04:00
if ( ! err ) {
2012-08-07 23:47:47 +04:00
struct device * d = tty_port_register_device ( & line - > port ,
driver , n , NULL ) ;
2011-09-10 03:45:42 +04:00
if ( IS_ERR ( d ) ) {
* error_out = " Failed to register device " ;
err = PTR_ERR ( d ) ;
parse_chan_pair ( NULL , line , n , opts , error_out ) ;
}
}
2011-09-10 03:14:02 +04:00
if ( err ) {
line - > init_str = NULL ;
line - > valid = 0 ;
kfree ( new ) ;
}
2007-02-10 12:43:52 +03:00
}
out :
2007-02-10 12:43:53 +03:00
return err ;
2007-02-10 12:43:52 +03:00
}
2007-10-16 12:26:43 +04:00
/*
* Common setup code for both startup command line and mconsole initialization .
2006-10-04 00:21:02 +04:00
* @ lines contains the array ( of size @ num ) to modify ;
2005-05-01 19:58:56 +04:00
* @ init is the setup string ;
2007-02-10 12:43:53 +03:00
* @ error_out is an error string in the case of failure ;
2006-01-06 11:18:53 +03:00
*/
2005-05-01 19:58:56 +04:00
2011-09-10 01:25:00 +04:00
int line_setup ( char * * conf , unsigned int num , char * * def ,
char * init , char * name )
2005-04-17 02:20:36 +04:00
{
2011-09-10 01:25:00 +04:00
char * error ;
2005-04-17 02:20:36 +04:00
2007-10-16 12:26:43 +04:00
if ( * init = = ' = ' ) {
/*
* We said con = / ssl = instead of con # = , so we are configuring all
* consoles at once .
*/
2011-09-10 01:25:00 +04:00
* def = init + 1 ;
} else {
char * end ;
unsigned n = simple_strtoul ( init , & end , 0 ) ;
2007-10-16 12:26:43 +04:00
if ( * end ! = ' = ' ) {
2011-09-10 01:25:00 +04:00
error = " Couldn't parse device number " ;
goto out ;
2005-04-17 02:20:36 +04:00
}
2011-09-10 01:25:00 +04:00
if ( n > = num ) {
error = " Device number out of range " ;
goto out ;
2007-02-10 12:43:53 +03:00
}
2011-09-10 01:25:00 +04:00
conf [ n ] = end + 1 ;
2005-04-17 02:20:36 +04:00
}
2011-09-10 01:25:00 +04:00
return 0 ;
out :
printk ( KERN_ERR " Failed to set up %s with "
" configuration string \" %s \" : %s \n " , name , init , error ) ;
return - EINVAL ;
2005-04-17 02:20:36 +04:00
}
2006-01-06 11:18:55 +03:00
int line_config ( struct line * lines , unsigned int num , char * str ,
2007-02-10 12:43:53 +03:00
const struct chan_opts * opts , char * * error_out )
2005-04-17 02:20:36 +04:00
{
2011-09-09 04:44:06 +04:00
char * end ;
2011-09-10 03:14:02 +04:00
int n ;
2005-04-17 02:20:36 +04:00
2007-10-16 12:26:43 +04:00
if ( * str = = ' = ' ) {
2007-02-10 12:43:53 +03:00
* error_out = " Can't configure all devices from mconsole " ;
return - EINVAL ;
2006-01-06 11:18:53 +03:00
}
2011-09-09 04:44:06 +04:00
n = simple_strtoul ( str , & end , 0 ) ;
if ( * end + + ! = ' = ' ) {
* error_out = " Couldn't parse device number " ;
return - EINVAL ;
}
if ( n > = num ) {
* error_out = " Device number out of range " ;
return - EINVAL ;
}
2011-09-10 03:14:02 +04:00
return setup_one_line ( lines , n , end , opts , error_out ) ;
2005-04-17 02:20:36 +04:00
}
2005-05-01 19:58:56 +04:00
int line_get_config ( char * name , struct line * lines , unsigned int num , char * str ,
2005-04-17 02:20:36 +04:00
int size , char * * error_out )
{
struct line * line ;
char * end ;
int dev , n = 0 ;
dev = simple_strtoul ( name , & end , 0 ) ;
2007-10-16 12:26:43 +04:00
if ( ( * end ! = ' \0 ' ) | | ( end = = name ) ) {
2005-04-17 02:20:36 +04:00
* error_out = " line_get_config failed to parse device number " ;
2005-05-01 19:58:56 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
2007-10-16 12:26:43 +04:00
if ( ( dev < 0 ) | | ( dev > = num ) ) {
2005-05-01 19:58:56 +04:00
* error_out = " device number out of range " ;
return 0 ;
2005-04-17 02:20:36 +04:00
}
line = & lines [ dev ] ;
2007-10-16 12:26:43 +04:00
if ( ! line - > valid )
2005-04-17 02:20:36 +04:00
CONFIG_CHUNK ( str , size , n , " none " , 1 ) ;
2012-06-04 15:35:27 +04:00
else {
struct tty_struct * tty = tty_port_tty_get ( & line - > port ) ;
if ( tty = = NULL ) {
CONFIG_CHUNK ( str , size , n , line - > init_str , 1 ) ;
} else {
n = chan_config_string ( line , str , size , error_out ) ;
tty_kref_put ( tty ) ;
}
}
2005-04-17 02:20:36 +04:00
2005-05-01 19:58:56 +04:00
return n ;
2005-04-17 02:20:36 +04:00
}
2005-06-26 01:55:25 +04:00
int line_id ( char * * str , int * start_out , int * end_out )
{
char * end ;
2007-10-16 12:26:43 +04:00
int n ;
2005-06-26 01:55:25 +04:00
n = simple_strtoul ( * str , & end , 0 ) ;
2007-10-16 12:26:43 +04:00
if ( ( * end ! = ' \0 ' ) | | ( end = = * str ) )
return - 1 ;
2005-06-26 01:55:25 +04:00
2007-10-16 12:26:43 +04:00
* str = end ;
* start_out = n ;
* end_out = n ;
return n ;
2005-06-26 01:55:25 +04:00
}
2007-02-10 12:43:53 +03:00
int line_remove ( struct line * lines , unsigned int num , int n , char * * error_out )
2005-04-17 02:20:36 +04:00
{
2011-09-09 04:34:52 +04:00
if ( n > = num ) {
* error_out = " Device number out of range " ;
return - EINVAL ;
}
2011-09-10 03:14:02 +04:00
return setup_one_line ( lines , n , " none " , NULL , error_out ) ;
2005-04-17 02:20:36 +04:00
}
2011-09-10 03:45:42 +04:00
int register_lines ( struct line_driver * line_driver ,
const struct tty_operations * ops ,
struct line * lines , int nlines )
2005-04-17 02:20:36 +04:00
{
2021-07-23 10:43:13 +03:00
struct tty_driver * driver ;
2011-09-10 03:45:42 +04:00
int err ;
2011-09-10 04:07:05 +04:00
int i ;
2005-04-17 02:20:36 +04:00
2021-07-23 10:43:13 +03:00
driver = tty_alloc_driver ( nlines , TTY_DRIVER_REAL_RAW |
TTY_DRIVER_DYNAMIC_DEV ) ;
if ( IS_ERR ( driver ) )
return PTR_ERR ( driver ) ;
2005-04-17 02:20:36 +04:00
driver - > driver_name = line_driver - > name ;
driver - > name = line_driver - > device_name ;
driver - > major = line_driver - > major ;
driver - > minor_start = line_driver - > minor_start ;
driver - > type = line_driver - > type ;
driver - > subtype = line_driver - > subtype ;
driver - > init_termios = tty_std_termios ;
2021-07-23 10:43:13 +03:00
2011-09-10 04:07:05 +04:00
for ( i = 0 ; i < nlines ; i + + ) {
2012-06-04 15:35:26 +04:00
tty_port_init ( & lines [ i ] . port ) ;
2012-06-04 23:57:24 +04:00
lines [ i ] . port . ops = & line_port_ops ;
2011-09-10 04:07:05 +04:00
spin_lock_init ( & lines [ i ] . lock ) ;
lines [ i ] . driver = line_driver ;
INIT_LIST_HEAD ( & lines [ i ] . chan_list ) ;
}
2005-04-17 02:20:36 +04:00
tty_set_operations ( driver , ops ) ;
2011-09-10 03:45:42 +04:00
err = tty_register_driver ( driver ) ;
if ( err ) {
2007-10-16 12:26:43 +04:00
printk ( KERN_ERR " register_lines : can't register %s driver \n " ,
line_driver - > name ) ;
2021-07-23 10:43:16 +03:00
tty_driver_kref_put ( driver ) ;
2012-11-15 12:49:56 +04:00
for ( i = 0 ; i < nlines ; i + + )
tty_port_destroy ( & lines [ i ] . port ) ;
2011-09-10 03:45:42 +04:00
return err ;
2005-04-17 02:20:36 +04:00
}
2011-09-10 03:45:42 +04:00
line_driver - > driver = driver ;
2005-04-17 02:20:36 +04:00
mconsole_register_dev ( & line_driver - > mc ) ;
2011-09-10 03:45:42 +04:00
return 0 ;
2005-04-17 02:20:36 +04:00
}
2006-01-06 11:18:54 +03:00
static DEFINE_SPINLOCK ( winch_handler_lock ) ;
static LIST_HEAD ( winch_handlers ) ;
2005-07-08 04:56:52 +04:00
2005-04-17 02:20:36 +04:00
struct winch {
struct list_head list ;
int fd ;
int tty_fd ;
int pid ;
2013-03-11 13:05:45 +04:00
struct tty_port * port ;
2007-07-16 10:38:55 +04:00
unsigned long stack ;
2011-09-15 03:21:31 +04:00
struct work_struct work ;
2005-04-17 02:20:36 +04:00
} ;
2011-09-15 03:21:31 +04:00
static void __free_winch ( struct work_struct * work )
2007-07-16 10:38:55 +04:00
{
2011-09-15 03:21:31 +04:00
struct winch * winch = container_of ( work , struct winch , work ) ;
2012-04-18 00:37:13 +04:00
um_free_irq ( WINCH_IRQ , winch ) ;
2007-07-16 10:38:55 +04:00
if ( winch - > pid ! = - 1 )
os_kill_process ( winch - > pid , 1 ) ;
if ( winch - > stack ! = 0 )
free_stack ( winch - > stack , 0 ) ;
kfree ( winch ) ;
}
2011-09-15 03:21:31 +04:00
static void free_winch ( struct winch * winch )
{
int fd = winch - > fd ;
winch - > fd = - 1 ;
if ( fd ! = - 1 )
os_close_file ( fd ) ;
__free_winch ( & winch - > work ) ;
}
2006-10-09 01:49:34 +04:00
static irqreturn_t winch_interrupt ( int irq , void * data )
2005-04-17 02:20:36 +04:00
{
struct winch * winch = data ;
struct tty_struct * tty ;
struct line * line ;
2011-09-15 03:21:31 +04:00
int fd = winch - > fd ;
2005-04-17 02:20:36 +04:00
int err ;
char c ;
2014-10-16 22:59:44 +04:00
struct pid * pgrp ;
2005-04-17 02:20:36 +04:00
2011-09-15 03:21:31 +04:00
if ( fd ! = - 1 ) {
err = generic_read ( fd , & c , NULL ) ;
2007-10-16 12:26:43 +04:00
if ( err < 0 ) {
if ( err ! = - EAGAIN ) {
2011-09-15 03:21:31 +04:00
winch - > fd = - 1 ;
list_del ( & winch - > list ) ;
os_close_file ( fd ) ;
2007-10-16 12:26:43 +04:00
printk ( KERN_ERR " winch_interrupt : "
" read failed, errno = %d \n " , - err ) ;
printk ( KERN_ERR " fd %d is losing SIGWINCH "
" support \n " , winch - > tty_fd ) ;
2011-09-15 03:21:31 +04:00
INIT_WORK ( & winch - > work , __free_winch ) ;
schedule_work ( & winch - > work ) ;
2005-05-01 19:58:56 +04:00
return IRQ_HANDLED ;
2005-04-17 02:20:36 +04:00
}
goto out ;
}
}
2013-03-11 13:05:45 +04:00
tty = tty_port_tty_get ( winch - > port ) ;
2005-04-17 02:20:36 +04:00
if ( tty ! = NULL ) {
line = tty - > driver_data ;
2008-02-05 09:31:19 +03:00
if ( line ! = NULL ) {
2011-09-08 18:49:34 +04:00
chan_window_size ( line , & tty - > winsize . ws_row ,
2008-02-05 09:31:19 +03:00
& tty - > winsize . ws_col ) ;
2014-10-16 22:59:44 +04:00
pgrp = tty_get_pgrp ( tty ) ;
if ( pgrp )
kill_pgrp ( pgrp , SIGWINCH , 1 ) ;
put_pid ( pgrp ) ;
2008-02-05 09:31:19 +03:00
}
2013-03-11 13:05:45 +04:00
tty_kref_put ( tty ) ;
2005-04-17 02:20:36 +04:00
}
out :
2005-05-01 19:58:56 +04:00
return IRQ_HANDLED ;
2005-04-17 02:20:36 +04:00
}
2013-03-11 13:05:45 +04:00
void register_winch_irq ( int fd , int tty_fd , int pid , struct tty_port * port ,
2007-07-16 10:38:55 +04:00
unsigned long stack )
2005-04-17 02:20:36 +04:00
{
struct winch * winch ;
winch = kmalloc ( sizeof ( * winch ) , GFP_KERNEL ) ;
if ( winch = = NULL ) {
2007-10-16 12:26:43 +04:00
printk ( KERN_ERR " register_winch_irq - kmalloc failed \n " ) ;
2007-07-16 10:38:55 +04:00
goto cleanup ;
2005-04-17 02:20:36 +04:00
}
2005-07-08 04:56:52 +04:00
2005-04-17 02:20:36 +04:00
* winch = ( ( struct winch ) { . list = LIST_HEAD_INIT ( winch - > list ) ,
. fd = fd ,
. tty_fd = tty_fd ,
. pid = pid ,
2013-03-11 13:05:45 +04:00
. port = port ,
2007-07-16 10:38:55 +04:00
. stack = stack } ) ;
if ( um_request_irq ( WINCH_IRQ , fd , IRQ_READ , winch_interrupt ,
2012-07-17 22:18:23 +04:00
IRQF_SHARED , " winch " , winch ) < 0 ) {
2007-10-16 12:26:43 +04:00
printk ( KERN_ERR " register_winch_irq - failed to register "
" IRQ \n " ) ;
2007-07-16 10:38:55 +04:00
goto out_free ;
}
2005-07-08 04:56:52 +04:00
spin_lock ( & winch_handler_lock ) ;
2005-04-17 02:20:36 +04:00
list_add ( & winch - > list , & winch_handlers ) ;
2005-07-08 04:56:52 +04:00
spin_unlock ( & winch_handler_lock ) ;
2007-07-16 10:38:55 +04:00
return ;
2006-01-06 11:19:01 +03:00
2007-07-16 10:38:55 +04:00
out_free :
2006-01-06 11:19:01 +03:00
kfree ( winch ) ;
2007-07-16 10:38:55 +04:00
cleanup :
os_kill_process ( pid , 1 ) ;
os_close_file ( fd ) ;
if ( stack ! = 0 )
free_stack ( stack , 0 ) ;
2006-01-06 11:19:01 +03:00
}
2005-05-06 03:15:32 +04:00
static void unregister_winch ( struct tty_struct * tty )
{
2011-01-13 03:59:26 +03:00
struct list_head * ele , * next ;
2006-01-06 11:19:01 +03:00
struct winch * winch ;
2013-03-11 13:05:45 +04:00
struct tty_struct * wtty ;
2005-05-06 03:15:32 +04:00
2005-07-08 04:56:52 +04:00
spin_lock ( & winch_handler_lock ) ;
2006-01-06 11:19:01 +03:00
2011-01-13 03:59:26 +03:00
list_for_each_safe ( ele , next , & winch_handlers ) {
2005-05-06 03:15:32 +04:00
winch = list_entry ( ele , struct winch , list ) ;
2013-03-11 13:05:45 +04:00
wtty = tty_port_tty_get ( winch - > port ) ;
if ( wtty = = tty ) {
2020-12-04 18:22:44 +03:00
list_del ( & winch - > list ) ;
spin_unlock ( & winch_handler_lock ) ;
2011-09-15 03:21:31 +04:00
free_winch ( winch ) ;
2006-01-06 11:19:01 +03:00
break ;
2007-10-16 12:26:43 +04:00
}
2013-03-11 13:05:45 +04:00
tty_kref_put ( wtty ) ;
2007-10-16 12:26:43 +04:00
}
2005-07-08 04:56:52 +04:00
spin_unlock ( & winch_handler_lock ) ;
2005-05-06 03:15:32 +04:00
}
2005-04-17 02:20:36 +04:00
static void winch_cleanup ( void )
{
struct winch * winch ;
2006-01-06 11:19:01 +03:00
spin_lock ( & winch_handler_lock ) ;
2020-12-04 18:22:44 +03:00
while ( ( winch = list_first_entry_or_null ( & winch_handlers ,
struct winch , list ) ) ) {
list_del ( & winch - > list ) ;
spin_unlock ( & winch_handler_lock ) ;
2006-01-06 11:19:01 +03:00
2011-09-15 03:21:31 +04:00
free_winch ( winch ) ;
2020-12-04 18:22:44 +03:00
spin_lock ( & winch_handler_lock ) ;
2005-04-17 02:20:36 +04:00
}
2006-01-06 11:19:01 +03:00
spin_unlock ( & winch_handler_lock ) ;
2005-04-17 02:20:36 +04:00
}
__uml_exitcall ( winch_cleanup ) ;
char * add_xterm_umid ( char * base )
{
char * umid , * title ;
int len ;
2006-01-06 11:19:01 +03:00
umid = get_umid ( ) ;
2007-10-16 12:26:43 +04:00
if ( * umid = = ' \0 ' )
2005-05-01 19:58:56 +04:00
return base ;
[PATCH] uml: Simplify console opening/closing and irq registration
This patch simplifies the opening and closing of host console devices and the
registration and deregistration of IRQs. The intent is to make it obvious
that an IRQ can't exist without an open file descriptor.
chan_enable will now open the channel, and when both opening and IRQ
registration are desired, this should be used. Opening only is done for the
initial console, so that interface still needs to exist.
The free_irqs_later interface is now gone. It was intended to avoid freeing
an IRQ while it was being processed. It did this, but it didn't eliminate the
possiblity of free_irq being called from an interrupt, which is bad. In its
place is a list of irqs to be freed, which is processed by the signal handler
just before exiting. close_one_chan now disables irqs.
When a host device disappears, it is just closed, and that disables IRQs.
The device id registered with the IRQ is now the chan structure, not the tty.
This is because the interrupt arrives on a descriptor associated with the
channel. This caused equivalent changes in the arguments to line_timer_cb.
line_disable is gone since it is not used any more.
The count field in the line structure is gone. tty->count is used instead.
The complicated logic in sigio_handler with freeing IRQs when necessary and
making sure its idea of the next irq is correct is now much simpler. The irq
list can't be rearranged underneath it, so it is now a simple list walk.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-06 11:18:57 +03:00
2005-04-17 02:20:36 +04:00
len = strlen ( base ) + strlen ( " () " ) + strlen ( umid ) + 1 ;
title = kmalloc ( len , GFP_KERNEL ) ;
2007-10-16 12:26:43 +04:00
if ( title = = NULL ) {
printk ( KERN_ERR " Failed to allocate buffer for xterm title \n " ) ;
2005-05-01 19:58:56 +04:00
return base ;
2005-04-17 02:20:36 +04:00
}
snprintf ( title , len , " %s (%s) " , base , umid ) ;
2005-05-01 19:58:56 +04:00
return title ;
2005-04-17 02:20:36 +04:00
}