2021-01-14 20:04:25 +03:00
// SPDX-License-Identifier: GPL-2.0+
/*
* IMI RDACM21 GMSL Camera Driver
*
* Copyright ( C ) 2017 - 2020 Jacopo Mondi
* Copyright ( C ) 2017 - 2019 Kieran Bingham
* Copyright ( C ) 2017 - 2019 Laurent Pinchart
* Copyright ( C ) 2017 - 2019 Niklas Söderlund
* Copyright ( C ) 2016 Renesas Electronics Corporation
* Copyright ( C ) 2015 Cogent Embedded , Inc .
*/
# include <linux/delay.h>
# include <linux/fwnode.h>
# include <linux/init.h>
# include <linux/i2c.h>
# include <linux/module.h>
# include <linux/slab.h>
# include <linux/videodev2.h>
# include <media/v4l2-async.h>
# include <media/v4l2-ctrls.h>
# include <media/v4l2-subdev.h>
# include "max9271.h"
# define MAX9271_RESET_CYCLES 10
# define OV490_I2C_ADDRESS 0x24
# define OV490_PAGE_HIGH_REG 0xfffd
# define OV490_PAGE_LOW_REG 0xfffe
/*
* The SCCB slave handling is undocumented ; the registers naming scheme is
* totally arbitrary .
*/
# define OV490_SCCB_SLAVE_WRITE 0x00
# define OV490_SCCB_SLAVE_READ 0x01
# define OV490_SCCB_SLAVE0_DIR 0x80195000
# define OV490_SCCB_SLAVE0_ADDR_HIGH 0x80195001
# define OV490_SCCB_SLAVE0_ADDR_LOW 0x80195002
# define OV490_DVP_CTRL3 0x80286009
# define OV490_ODS_CTRL_FRAME_OUTPUT_EN 0x0c
# define OV490_ODS_CTRL 0x8029d000
# define OV490_HOST_CMD 0x808000c0
# define OV490_HOST_CMD_TRIGGER 0xc1
# define OV490_ID_VAL 0x0490
# define OV490_ID(_p, _v) ((((_p) & 0xff) << 8) | ((_v) & 0xff))
# define OV490_PID 0x8080300a
# define OV490_VER 0x8080300b
# define OV490_PID_TIMEOUT 20
# define OV490_OUTPUT_EN_TIMEOUT 300
# define OV490_GPIO0 BIT(0)
# define OV490_SPWDN0 BIT(0)
# define OV490_GPIO_SEL0 0x80800050
# define OV490_GPIO_SEL1 0x80800051
# define OV490_GPIO_DIRECTION0 0x80800054
# define OV490_GPIO_DIRECTION1 0x80800055
# define OV490_GPIO_OUTPUT_VALUE0 0x80800058
# define OV490_GPIO_OUTPUT_VALUE1 0x80800059
# define OV490_ISP_HSIZE_LOW 0x80820060
# define OV490_ISP_HSIZE_HIGH 0x80820061
# define OV490_ISP_VSIZE_LOW 0x80820062
# define OV490_ISP_VSIZE_HIGH 0x80820063
2021-06-16 15:46:11 +03:00
# define OV10640_PID_TIMEOUT 20
2021-01-14 20:04:25 +03:00
# define OV10640_ID_HIGH 0xa6
# define OV10640_CHIP_ID 0x300a
# define OV10640_PIXEL_RATE 55000000
struct rdacm21_device {
struct device * dev ;
struct max9271_device serializer ;
struct i2c_client * isp ;
struct v4l2_subdev sd ;
struct media_pad pad ;
struct v4l2_mbus_framefmt fmt ;
struct v4l2_ctrl_handler ctrls ;
u32 addrs [ 2 ] ;
u16 last_page ;
} ;
static inline struct rdacm21_device * sd_to_rdacm21 ( struct v4l2_subdev * sd )
{
return container_of ( sd , struct rdacm21_device , sd ) ;
}
static const struct ov490_reg {
u16 reg ;
u8 val ;
} ov490_regs_wizard [ ] = {
{ 0xfffd , 0x80 } ,
{ 0xfffe , 0x82 } ,
{ 0x0071 , 0x11 } ,
{ 0x0075 , 0x11 } ,
{ 0xfffe , 0x29 } ,
{ 0x6010 , 0x01 } ,
/*
* OV490 EMB line disable in YUV and RAW data ,
* NOTE : EMB line is still used in ISP and sensor
*/
{ 0xe000 , 0x14 } ,
{ 0xfffe , 0x28 } ,
{ 0x6000 , 0x04 } ,
{ 0x6004 , 0x00 } ,
/*
* PCLK polarity - useless due to silicon bug .
* Use 0x808000bb register instead .
*/
{ 0x6008 , 0x00 } ,
{ 0xfffe , 0x80 } ,
{ 0x0091 , 0x00 } ,
/* bit[3]=0 - PCLK polarity workaround. */
{ 0x00bb , 0x1d } ,
/* Ov490 FSIN: app_fsin_from_fsync */
{ 0xfffe , 0x85 } ,
{ 0x0008 , 0x00 } ,
{ 0x0009 , 0x01 } ,
/* FSIN0 source. */
{ 0x000A , 0x05 } ,
{ 0x000B , 0x00 } ,
/* FSIN0 delay. */
{ 0x0030 , 0x02 } ,
{ 0x0031 , 0x00 } ,
{ 0x0032 , 0x00 } ,
{ 0x0033 , 0x00 } ,
/* FSIN1 delay. */
{ 0x0038 , 0x02 } ,
{ 0x0039 , 0x00 } ,
{ 0x003A , 0x00 } ,
{ 0x003B , 0x00 } ,
/* FSIN0 length. */
{ 0x0070 , 0x2C } ,
{ 0x0071 , 0x01 } ,
{ 0x0072 , 0x00 } ,
{ 0x0073 , 0x00 } ,
/* FSIN1 length. */
{ 0x0074 , 0x64 } ,
{ 0x0075 , 0x00 } ,
{ 0x0076 , 0x00 } ,
{ 0x0077 , 0x00 } ,
{ 0x0000 , 0x14 } ,
{ 0x0001 , 0x00 } ,
{ 0x0002 , 0x00 } ,
{ 0x0003 , 0x00 } ,
/*
* Load fsin0 , load fsin1 , load other ,
* It will be cleared automatically .
*/
{ 0x0004 , 0x32 } ,
{ 0x0005 , 0x00 } ,
{ 0x0006 , 0x00 } ,
{ 0x0007 , 0x00 } ,
{ 0xfffe , 0x80 } ,
/* Sensor FSIN. */
{ 0x0081 , 0x00 } ,
/* ov10640 FSIN enable */
{ 0xfffe , 0x19 } ,
{ 0x5000 , 0x00 } ,
{ 0x5001 , 0x30 } ,
{ 0x5002 , 0x8c } ,
{ 0x5003 , 0xb2 } ,
{ 0xfffe , 0x80 } ,
{ 0x00c0 , 0xc1 } ,
/* ov10640 HFLIP=1 by default */
{ 0xfffe , 0x19 } ,
{ 0x5000 , 0x01 } ,
{ 0x5001 , 0x00 } ,
{ 0xfffe , 0x80 } ,
{ 0x00c0 , 0xdc } ,
} ;
static int ov490_read ( struct rdacm21_device * dev , u16 reg , u8 * val )
{
u8 buf [ 2 ] = { reg > > 8 , reg } ;
int ret ;
ret = i2c_master_send ( dev - > isp , buf , 2 ) ;
if ( ret = = 2 )
ret = i2c_master_recv ( dev - > isp , val , 1 ) ;
if ( ret < 0 ) {
dev_dbg ( dev - > dev , " %s: register 0x%04x read failed (%d) \n " ,
__func__ , reg , ret ) ;
return ret ;
}
return 0 ;
}
static int ov490_write ( struct rdacm21_device * dev , u16 reg , u8 val )
{
u8 buf [ 3 ] = { reg > > 8 , reg , val } ;
int ret ;
ret = i2c_master_send ( dev - > isp , buf , 3 ) ;
if ( ret < 0 ) {
dev_err ( dev - > dev , " %s: register 0x%04x write failed (%d) \n " ,
__func__ , reg , ret ) ;
return ret ;
}
return 0 ;
}
static int ov490_set_page ( struct rdacm21_device * dev , u16 page )
{
u8 page_high = page > > 8 ;
u8 page_low = page ;
int ret ;
if ( page = = dev - > last_page )
return 0 ;
if ( page_high ! = ( dev - > last_page > > 8 ) ) {
ret = ov490_write ( dev , OV490_PAGE_HIGH_REG , page_high ) ;
if ( ret )
return ret ;
}
if ( page_low ! = ( u8 ) dev - > last_page ) {
ret = ov490_write ( dev , OV490_PAGE_LOW_REG , page_low ) ;
if ( ret )
return ret ;
}
dev - > last_page = page ;
usleep_range ( 100 , 150 ) ;
return 0 ;
}
static int ov490_read_reg ( struct rdacm21_device * dev , u32 reg , u8 * val )
{
int ret ;
ret = ov490_set_page ( dev , reg > > 16 ) ;
if ( ret )
return ret ;
ret = ov490_read ( dev , ( u16 ) reg , val ) ;
if ( ret )
return ret ;
dev_dbg ( dev - > dev , " %s: 0x%08x = 0x%02x \n " , __func__ , reg , * val ) ;
return 0 ;
}
static int ov490_write_reg ( struct rdacm21_device * dev , u32 reg , u8 val )
{
int ret ;
ret = ov490_set_page ( dev , reg > > 16 ) ;
if ( ret )
return ret ;
ret = ov490_write ( dev , ( u16 ) reg , val ) ;
if ( ret )
return ret ;
dev_dbg ( dev - > dev , " %s: 0x%08x = 0x%02x \n " , __func__ , reg , val ) ;
return 0 ;
}
static int rdacm21_s_stream ( struct v4l2_subdev * sd , int enable )
{
struct rdacm21_device * dev = sd_to_rdacm21 ( sd ) ;
/*
* Enable serial link now that the ISP provides a valid pixel clock
* to start serializing video data on the GMSL link .
*/
return max9271_set_serial_link ( & dev - > serializer , enable ) ;
}
static int rdacm21_enum_mbus_code ( struct v4l2_subdev * sd ,
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
struct v4l2_subdev_state * sd_state ,
2021-01-14 20:04:25 +03:00
struct v4l2_subdev_mbus_code_enum * code )
{
if ( code - > pad | | code - > index > 0 )
return - EINVAL ;
code - > code = MEDIA_BUS_FMT_YUYV8_1X16 ;
return 0 ;
}
static int rdacm21_get_fmt ( struct v4l2_subdev * sd ,
media: v4l2-subdev: add subdev-wide state struct
We have 'struct v4l2_subdev_pad_config' which contains configuration for
a single pad used for the TRY functionality, and an array of those
structs is passed to various v4l2_subdev_pad_ops.
I was working on subdev internal routing between pads, and realized that
there's no way to add TRY functionality for routes, which is not pad
specific configuration. Adding a separate struct for try-route config
wouldn't work either, as e.g. set-fmt needs to know the try-route
configuration to propagate the settings.
This patch adds a new struct, 'struct v4l2_subdev_state' (which at the
moment only contains the v4l2_subdev_pad_config array) and the new
struct is used in most of the places where v4l2_subdev_pad_config was
used. All v4l2_subdev_pad_ops functions taking v4l2_subdev_pad_config
are changed to instead take v4l2_subdev_state.
The changes to drivers/media/v4l2-core/v4l2-subdev.c and
include/media/v4l2-subdev.h were written by hand, and all the driver
changes were done with the semantic patch below. The spatch needs to be
applied to a select list of directories. I used the following shell
commands to apply the spatch:
dirs="drivers/media/i2c drivers/media/platform drivers/media/usb drivers/media/test-drivers/vimc drivers/media/pci drivers/staging/media"
for dir in $dirs; do spatch -j8 --dir --include-headers --no-show-diff --in-place --sp-file v4l2-subdev-state.cocci $dir; done
Note that Coccinelle chokes on a few drivers (gcc extensions?). With
minor changes we can make Coccinelle run fine, and these changes can be
reverted after spatch. The diff for these changes is:
For drivers/media/i2c/s5k5baf.c:
@@ -1481,7 +1481,7 @@ static int s5k5baf_set_selection(struct v4l2_subdev *sd,
&s5k5baf_cis_rect,
v4l2_subdev_get_try_crop(sd, cfg, PAD_CIS),
v4l2_subdev_get_try_compose(sd, cfg, PAD_CIS),
- v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT)
+ v4l2_subdev_get_try_crop(sd, cfg, PAD_OUT),
};
s5k5baf_set_rect_and_adjust(rects, rtype, &sel->r);
return 0;
For drivers/media/platform/s3c-camif/camif-capture.c:
@@ -1230,7 +1230,7 @@ static int s3c_camif_subdev_get_fmt(struct v4l2_subdev *sd,
*mf = camif->mbus_fmt;
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* crop rectangle at camera interface input */
mf->width = camif->camif_crop.width;
mf->height = camif->camif_crop.height;
@@ -1332,7 +1332,7 @@ static int s3c_camif_subdev_set_fmt(struct v4l2_subdev *sd,
}
break;
- case CAMIF_SD_PAD_SOURCE_C...CAMIF_SD_PAD_SOURCE_P:
+ case CAMIF_SD_PAD_SOURCE_C:
/* Pixel format can be only changed on the sink pad. */
mf->code = camif->mbus_fmt.code;
mf->width = crop->width;
The semantic patch is:
// <smpl>
// Change function parameter
@@
identifier func;
identifier cfg;
@@
func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...)
{
<...
- cfg
+ sd_state
...>
}
// Change function declaration parameter
@@
identifier func;
identifier cfg;
type T;
@@
T func(...,
- struct v4l2_subdev_pad_config *cfg
+ struct v4l2_subdev_state *sd_state
, ...);
// Change function return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...)
{
...
}
// Change function declaration return value
@@
identifier func;
@@
- struct v4l2_subdev_pad_config
+ struct v4l2_subdev_state
*func(...);
// Some drivers pass a local pad_cfg for a single pad to a called function. Wrap it
// inside a pad_state.
@@
identifier func;
identifier pad_cfg;
@@
func(...)
{
...
struct v4l2_subdev_pad_config pad_cfg;
+ struct v4l2_subdev_state pad_state = { .pads = &pad_cfg };
<+...
(
v4l2_subdev_call
|
sensor_call
|
isi_try_fse
|
isc_try_fse
|
saa_call_all
)
(...,
- &pad_cfg
+ &pad_state
,...)
...+>
}
// If the function uses fields from pad_config, access via state->pads
@@
identifier func;
identifier state;
@@
func(...,
struct v4l2_subdev_state *state
, ...)
{
<...
(
- state->try_fmt
+ state->pads->try_fmt
|
- state->try_crop
+ state->pads->try_crop
|
- state->try_compose
+ state->pads->try_compose
)
...>
}
// If the function accesses the filehandle, use fh->state instead
@@
struct v4l2_subdev_fh *fh;
@@
- fh->pad
+ fh->state
@@
struct v4l2_subdev_fh fh;
@@
- fh.pad
+ fh.state
// Start of vsp1 specific
@@
@@
struct vsp1_entity {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
};
@@
symbol entity;
@@
vsp1_entity_init(...)
{
...
entity->config =
- v4l2_subdev_alloc_pad_config
+ v4l2_subdev_alloc_state
(&entity->subdev);
...
}
@@
symbol entity;
@@
vsp1_entity_destroy(...)
{
...
- v4l2_subdev_free_pad_config
+ v4l2_subdev_free_state
(entity->config);
...
}
@exists@
identifier func =~ "(^vsp1.*)|(hsit_set_format)|(sru_enum_frame_size)|(sru_set_format)|(uif_get_selection)|(uif_set_selection)|(uds_enum_frame_size)|(uds_set_format)|(brx_set_format)|(brx_get_selection)|(histo_get_selection)|(histo_set_selection)|(brx_set_selection)";
symbol config;
@@
func(...) {
...
- struct v4l2_subdev_pad_config *config;
+ struct v4l2_subdev_state *config;
...
}
// End of vsp1 specific
// Start of rcar specific
@@
identifier sd;
identifier pad_cfg;
@@
rvin_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
// End of rcar specific
// Start of rockchip specific
@@
identifier func =~ "(rkisp1_rsz_get_pad_fmt)|(rkisp1_rsz_get_pad_crop)|(rkisp1_rsz_register)";
symbol rsz;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = rsz->pad_cfg };
...
- rsz->pad_cfg
+ &state
...
}
@@
identifier func =~ "(rkisp1_isp_get_pad_fmt)|(rkisp1_isp_get_pad_crop)";
symbol isp;
symbol pad_cfg;
@@
func(...)
{
+ struct v4l2_subdev_state state = { .pads = isp->pad_cfg };
...
- isp->pad_cfg
+ &state
...
}
@@
symbol rkisp1;
symbol isp;
symbol pad_cfg;
@@
rkisp1_isp_register(...)
{
+ struct v4l2_subdev_state state = { .pads = rkisp1->isp.pad_cfg };
...
- rkisp1->isp.pad_cfg
+ &state
...
}
// End of rockchip specific
// Start of tegra-video specific
@@
identifier sd;
identifier pad_cfg;
@@
__tegra_channel_try_format(...)
{
...
- struct v4l2_subdev_pad_config *pad_cfg;
+ struct v4l2_subdev_state *sd_state;
...
- pad_cfg = v4l2_subdev_alloc_pad_config(sd);
+ sd_state = v4l2_subdev_alloc_state(sd);
<...
- pad_cfg
+ sd_state
...>
- v4l2_subdev_free_pad_config(pad_cfg);
+ v4l2_subdev_free_state(sd_state);
...
}
@@
identifier sd_state;
@@
__tegra_channel_try_format(...)
{
...
struct v4l2_subdev_state *sd_state;
<...
- sd_state->try_crop
+ sd_state->pads->try_crop
...>
}
// End of tegra-video specific
// </smpl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-10 17:55:58 +03:00
struct v4l2_subdev_state * sd_state ,
2021-01-14 20:04:25 +03:00
struct v4l2_subdev_format * format )
{
struct v4l2_mbus_framefmt * mf = & format - > format ;
struct rdacm21_device * dev = sd_to_rdacm21 ( sd ) ;
if ( format - > pad )
return - EINVAL ;
mf - > width = dev - > fmt . width ;
mf - > height = dev - > fmt . height ;
mf - > code = MEDIA_BUS_FMT_YUYV8_1X16 ;
mf - > colorspace = V4L2_COLORSPACE_SRGB ;
mf - > field = V4L2_FIELD_NONE ;
mf - > ycbcr_enc = V4L2_YCBCR_ENC_601 ;
mf - > quantization = V4L2_QUANTIZATION_FULL_RANGE ;
mf - > xfer_func = V4L2_XFER_FUNC_NONE ;
return 0 ;
}
static const struct v4l2_subdev_video_ops rdacm21_video_ops = {
. s_stream = rdacm21_s_stream ,
} ;
static const struct v4l2_subdev_pad_ops rdacm21_subdev_pad_ops = {
. enum_mbus_code = rdacm21_enum_mbus_code ,
. get_fmt = rdacm21_get_fmt ,
. set_fmt = rdacm21_get_fmt ,
} ;
static const struct v4l2_subdev_ops rdacm21_subdev_ops = {
. video = & rdacm21_video_ops ,
. pad = & rdacm21_subdev_pad_ops ,
} ;
2021-06-16 15:46:11 +03:00
static void ov10640_power_up ( struct rdacm21_device * dev )
2021-01-14 20:04:25 +03:00
{
2021-06-16 15:46:10 +03:00
/* Enable GPIO0#0 (reset) and GPIO1#0 (pwdn) as output lines. */
2021-01-14 20:04:25 +03:00
ov490_write_reg ( dev , OV490_GPIO_SEL0 , OV490_GPIO0 ) ;
ov490_write_reg ( dev , OV490_GPIO_SEL1 , OV490_SPWDN0 ) ;
ov490_write_reg ( dev , OV490_GPIO_DIRECTION0 , OV490_GPIO0 ) ;
ov490_write_reg ( dev , OV490_GPIO_DIRECTION1 , OV490_SPWDN0 ) ;
2021-06-16 15:46:10 +03:00
/* Power up OV10640 and then reset it. */
ov490_write_reg ( dev , OV490_GPIO_OUTPUT_VALUE1 , OV490_SPWDN0 ) ;
usleep_range ( 1500 , 3000 ) ;
ov490_write_reg ( dev , OV490_GPIO_OUTPUT_VALUE0 , 0x00 ) ;
usleep_range ( 1500 , 3000 ) ;
2021-01-14 20:04:25 +03:00
ov490_write_reg ( dev , OV490_GPIO_OUTPUT_VALUE0 , OV490_GPIO0 ) ;
usleep_range ( 3000 , 5000 ) ;
2021-06-16 15:46:11 +03:00
}
2021-01-14 20:04:25 +03:00
2021-06-16 15:46:11 +03:00
static int ov10640_check_id ( struct rdacm21_device * dev )
{
unsigned int i ;
u8 val ;
2021-01-14 20:04:25 +03:00
2021-06-16 15:46:11 +03:00
/* Read OV10640 ID to test communications. */
for ( i = 0 ; i < OV10640_PID_TIMEOUT ; + + i ) {
ov490_write_reg ( dev , OV490_SCCB_SLAVE0_DIR ,
OV490_SCCB_SLAVE_READ ) ;
ov490_write_reg ( dev , OV490_SCCB_SLAVE0_ADDR_HIGH ,
OV10640_CHIP_ID > > 8 ) ;
ov490_write_reg ( dev , OV490_SCCB_SLAVE0_ADDR_LOW ,
OV10640_CHIP_ID & 0xff ) ;
/*
* Trigger SCCB slave transaction and give it some time
* to complete .
*/
ov490_write_reg ( dev , OV490_HOST_CMD , OV490_HOST_CMD_TRIGGER ) ;
usleep_range ( 1000 , 1500 ) ;
ov490_read_reg ( dev , OV490_SCCB_SLAVE0_DIR , & val ) ;
if ( val = = OV10640_ID_HIGH )
break ;
usleep_range ( 1000 , 1500 ) ;
}
if ( i = = OV10640_PID_TIMEOUT ) {
2021-01-14 20:04:25 +03:00
dev_err ( dev - > dev , " OV10640 ID mismatch: (0x%02x) \n " , val ) ;
return - ENODEV ;
}
dev_dbg ( dev - > dev , " OV10640 ID = 0x%2x \n " , val ) ;
return 0 ;
}
static int ov490_initialize ( struct rdacm21_device * dev )
{
u8 pid , ver , val ;
unsigned int i ;
int ret ;
2021-06-16 15:46:11 +03:00
ov10640_power_up ( dev ) ;
2021-01-14 20:04:25 +03:00
/*
* Read OV490 Id to test communications . Give it up to 40 msec to
* exit from reset .
*/
for ( i = 0 ; i < OV490_PID_TIMEOUT ; + + i ) {
ret = ov490_read_reg ( dev , OV490_PID , & pid ) ;
if ( ret = = 0 )
break ;
usleep_range ( 1000 , 2000 ) ;
}
if ( i = = OV490_PID_TIMEOUT ) {
dev_err ( dev - > dev , " OV490 PID read failed (%d) \n " , ret ) ;
return ret ;
}
ret = ov490_read_reg ( dev , OV490_VER , & ver ) ;
if ( ret < 0 )
return ret ;
if ( OV490_ID ( pid , ver ) ! = OV490_ID_VAL ) {
dev_err ( dev - > dev , " OV490 ID mismatch (0x%04x) \n " ,
OV490_ID ( pid , ver ) ) ;
return - ENODEV ;
}
/* Wait for firmware boot by reading streamon status. */
for ( i = 0 ; i < OV490_OUTPUT_EN_TIMEOUT ; + + i ) {
ov490_read_reg ( dev , OV490_ODS_CTRL , & val ) ;
if ( val = = OV490_ODS_CTRL_FRAME_OUTPUT_EN )
break ;
usleep_range ( 1000 , 2000 ) ;
}
if ( i = = OV490_OUTPUT_EN_TIMEOUT ) {
dev_err ( dev - > dev , " Timeout waiting for firmware boot \n " ) ;
return - ENODEV ;
}
2021-06-16 15:46:11 +03:00
ret = ov10640_check_id ( dev ) ;
2021-01-14 20:04:25 +03:00
if ( ret )
return ret ;
/* Program OV490 with register-value table. */
for ( i = 0 ; i < ARRAY_SIZE ( ov490_regs_wizard ) ; + + i ) {
ret = ov490_write ( dev , ov490_regs_wizard [ i ] . reg ,
ov490_regs_wizard [ i ] . val ) ;
if ( ret < 0 ) {
dev_err ( dev - > dev ,
" %s: register %u (0x%04x) write failed (%d) \n " ,
__func__ , i , ov490_regs_wizard [ i ] . reg , ret ) ;
return - EIO ;
}
usleep_range ( 100 , 150 ) ;
}
/*
* The ISP is programmed with the content of a serial flash memory .
* Read the firmware configuration to reflect it through the V4L2 APIs .
*/
ov490_read_reg ( dev , OV490_ISP_HSIZE_HIGH , & val ) ;
dev - > fmt . width = ( val & 0xf ) < < 8 ;
ov490_read_reg ( dev , OV490_ISP_HSIZE_LOW , & val ) ;
dev - > fmt . width | = ( val & 0xff ) ;
ov490_read_reg ( dev , OV490_ISP_VSIZE_HIGH , & val ) ;
dev - > fmt . height = ( val & 0xf ) < < 8 ;
ov490_read_reg ( dev , OV490_ISP_VSIZE_LOW , & val ) ;
dev - > fmt . height | = val & 0xff ;
/* Set bus width to 12 bits with [0:11] ordering. */
ov490_write_reg ( dev , OV490_DVP_CTRL3 , 0x10 ) ;
dev_info ( dev - > dev , " Identified RDACM21 camera module \n " ) ;
return 0 ;
}
static int rdacm21_initialize ( struct rdacm21_device * dev )
{
int ret ;
2021-06-16 15:46:08 +03:00
max9271_wake_up ( & dev - > serializer ) ;
2021-01-14 20:04:25 +03:00
/* Enable reverse channel and disable the serial link. */
ret = max9271_set_serial_link ( & dev - > serializer , false ) ;
if ( ret )
return ret ;
/* Configure I2C bus at 105Kbps speed and configure GMSL. */
ret = max9271_configure_i2c ( & dev - > serializer ,
MAX9271_I2CSLVSH_469NS_234NS |
MAX9271_I2CSLVTO_1024US |
MAX9271_I2CMSTBT_105KBPS ) ;
if ( ret )
return ret ;
ret = max9271_verify_id ( & dev - > serializer ) ;
if ( ret )
return ret ;
2021-06-16 15:46:09 +03:00
/*
* Enable GPIO1 and hold OV490 in reset during max9271 configuration .
* The reset signal has to be asserted for at least 250 useconds .
*/
2021-01-14 20:04:25 +03:00
ret = max9271_enable_gpios ( & dev - > serializer , MAX9271_GPIO1OUT ) ;
if ( ret )
return ret ;
ret = max9271_clear_gpios ( & dev - > serializer , MAX9271_GPIO1OUT ) ;
if ( ret )
return ret ;
2021-06-16 15:46:09 +03:00
usleep_range ( 250 , 500 ) ;
2021-01-14 20:04:25 +03:00
ret = max9271_configure_gmsl_link ( & dev - > serializer ) ;
if ( ret )
return ret ;
ret = max9271_set_address ( & dev - > serializer , dev - > addrs [ 0 ] ) ;
if ( ret )
return ret ;
dev - > serializer . client - > addr = dev - > addrs [ 0 ] ;
ret = max9271_set_translation ( & dev - > serializer , dev - > addrs [ 1 ] ,
OV490_I2C_ADDRESS ) ;
if ( ret )
return ret ;
dev - > isp - > addr = dev - > addrs [ 1 ] ;
/* Release OV490 from reset and initialize it. */
ret = max9271_set_gpios ( & dev - > serializer , MAX9271_GPIO1OUT ) ;
if ( ret )
return ret ;
usleep_range ( 3000 , 5000 ) ;
ret = ov490_initialize ( dev ) ;
if ( ret )
return ret ;
/*
* Set reverse channel high threshold to increase noise immunity .
*
* This should be compensated by increasing the reverse channel
* amplitude on the remote deserializer side .
*/
return max9271_set_high_threshold ( & dev - > serializer , true ) ;
}
static int rdacm21_probe ( struct i2c_client * client )
{
struct rdacm21_device * dev ;
struct fwnode_handle * ep ;
int ret ;
dev = devm_kzalloc ( & client - > dev , sizeof ( * dev ) , GFP_KERNEL ) ;
if ( ! dev )
return - ENOMEM ;
dev - > dev = & client - > dev ;
dev - > serializer . client = client ;
ret = of_property_read_u32_array ( client - > dev . of_node , " reg " ,
dev - > addrs , 2 ) ;
if ( ret < 0 ) {
dev_err ( dev - > dev , " Invalid DT reg property: %d \n " , ret ) ;
return - EINVAL ;
}
/* Create the dummy I2C client for the sensor. */
dev - > isp = i2c_new_dummy_device ( client - > adapter , OV490_I2C_ADDRESS ) ;
if ( IS_ERR ( dev - > isp ) )
return PTR_ERR ( dev - > isp ) ;
ret = rdacm21_initialize ( dev ) ;
if ( ret < 0 )
goto error ;
/* Initialize and register the subdevice. */
v4l2_i2c_subdev_init ( & dev - > sd , client , & rdacm21_subdev_ops ) ;
dev - > sd . flags | = V4L2_SUBDEV_FL_HAS_DEVNODE ;
v4l2_ctrl_handler_init ( & dev - > ctrls , 1 ) ;
v4l2_ctrl_new_std ( & dev - > ctrls , NULL , V4L2_CID_PIXEL_RATE ,
OV10640_PIXEL_RATE , OV10640_PIXEL_RATE , 1 ,
OV10640_PIXEL_RATE ) ;
dev - > sd . ctrl_handler = & dev - > ctrls ;
ret = dev - > ctrls . error ;
if ( ret )
goto error_free_ctrls ;
dev - > pad . flags = MEDIA_PAD_FL_SOURCE ;
2022-03-09 14:55:06 +03:00
dev - > sd . entity . function = MEDIA_ENT_F_CAM_SENSOR ;
2021-01-14 20:04:25 +03:00
ret = media_entity_pads_init ( & dev - > sd . entity , 1 , & dev - > pad ) ;
if ( ret < 0 )
goto error_free_ctrls ;
ep = fwnode_graph_get_next_endpoint ( dev_fwnode ( & client - > dev ) , NULL ) ;
if ( ! ep ) {
dev_err ( & client - > dev ,
" Unable to get endpoint in node %pOF \n " ,
client - > dev . of_node ) ;
ret = - ENOENT ;
goto error_free_ctrls ;
}
dev - > sd . fwnode = ep ;
ret = v4l2_async_register_subdev ( & dev - > sd ) ;
if ( ret )
goto error_put_node ;
return 0 ;
error_put_node :
fwnode_handle_put ( dev - > sd . fwnode ) ;
error_free_ctrls :
v4l2_ctrl_handler_free ( & dev - > ctrls ) ;
error :
i2c_unregister_device ( dev - > isp ) ;
return ret ;
}
2022-08-15 11:02:30 +03:00
static void rdacm21_remove ( struct i2c_client * client )
2021-01-14 20:04:25 +03:00
{
struct rdacm21_device * dev = sd_to_rdacm21 ( i2c_get_clientdata ( client ) ) ;
v4l2_async_unregister_subdev ( & dev - > sd ) ;
v4l2_ctrl_handler_free ( & dev - > ctrls ) ;
i2c_unregister_device ( dev - > isp ) ;
fwnode_handle_put ( dev - > sd . fwnode ) ;
}
static const struct of_device_id rdacm21_of_ids [ ] = {
{ . compatible = " imi,rdacm21 " } ,
{ }
} ;
MODULE_DEVICE_TABLE ( of , rdacm21_of_ids ) ;
static struct i2c_driver rdacm21_i2c_driver = {
. driver = {
. name = " rdacm21 " ,
. of_match_table = rdacm21_of_ids ,
} ,
. probe_new = rdacm21_probe ,
. remove = rdacm21_remove ,
} ;
module_i2c_driver ( rdacm21_i2c_driver ) ;
MODULE_DESCRIPTION ( " GMSL Camera driver for RDACM21 " ) ;
MODULE_AUTHOR ( " Jacopo Mondi " ) ;
MODULE_LICENSE ( " GPL v2 " ) ;