License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 17:07:57 +03:00
// SPDX-License-Identifier: GPL-2.0
2005-04-17 02:20:36 +04:00
/*
* linux / fs / seq_file . c
*
* helper functions for making synthetic files from sequences of records .
* initial implementation - - AV , Oct 2001.
*/
2020-06-05 02:51:02 +03:00
# define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
2018-04-11 02:34:45 +03:00
# include <linux/cache.h>
2005-04-17 02:20:36 +04:00
# include <linux/fs.h>
2011-11-17 08:57:37 +04:00
# include <linux/export.h>
2005-04-17 02:20:36 +04:00
# include <linux/seq_file.h>
2014-07-03 02:22:37 +04:00
# include <linux/vmalloc.h>
2005-04-17 02:20:36 +04:00
# include <linux/slab.h>
2012-05-24 04:01:20 +04:00
# include <linux/cred.h>
2014-07-03 02:22:37 +04:00
# include <linux/mm.h>
2015-09-10 01:38:33 +03:00
# include <linux/printk.h>
2015-11-07 03:32:40 +03:00
# include <linux/string_helpers.h>
2020-11-04 11:27:33 +03:00
# include <linux/uio.h>
2005-04-17 02:20:36 +04:00
2016-12-24 22:46:01 +03:00
# include <linux/uaccess.h>
2005-04-17 02:20:36 +04:00
# include <asm/page.h>
2018-04-11 02:34:45 +03:00
static struct kmem_cache * seq_file_cache __ro_after_init ;
2012-03-24 02:02:55 +04:00
static void seq_set_overflow ( struct seq_file * m )
{
m - > count = m - > size ;
}
2014-07-03 02:22:37 +04:00
static void * seq_buf_alloc ( unsigned long size )
{
2018-04-11 02:34:49 +03:00
return kvmalloc ( size , GFP_KERNEL_ACCOUNT ) ;
2014-07-03 02:22:37 +04:00
}
2005-04-17 02:20:36 +04:00
/**
* seq_open - initialize sequential file
* @ file : file we initialize
* @ op : method table describing the sequence
*
* seq_open ( ) sets @ file , associating it with a sequence described
* by @ op . @ op - > start ( ) sets the iterator up and returns the first
* element of sequence . @ op - > stop ( ) shuts it down . @ op - > next ( )
* returns the next element of sequence . @ op - > show ( ) prints element
* into the buffer . In case of error - > start ( ) and - > next ( ) return
* ERR_PTR ( error ) . In the end of sequence they return % NULL . - > show ( )
* returns 0 in case of success and negative number in case of error .
2008-03-28 07:46:41 +03:00
* Returning SEQ_SKIP means " discard this element and move on " .
2015-07-01 00:57:36 +03:00
* Note : seq_open ( ) will allocate a struct seq_file and store its
* pointer in @ file - > private_data . This pointer should not be modified .
2005-04-17 02:20:36 +04:00
*/
2006-12-07 07:40:36 +03:00
int seq_open ( struct file * file , const struct seq_operations * op )
2005-04-17 02:20:36 +04:00
{
2015-07-01 00:57:33 +03:00
struct seq_file * p ;
WARN_ON ( file - > private_data ) ;
2018-04-11 02:34:45 +03:00
p = kmem_cache_zalloc ( seq_file_cache , GFP_KERNEL ) ;
2015-07-01 00:57:33 +03:00
if ( ! p )
return - ENOMEM ;
file - > private_data = p ;
2005-11-08 01:15:34 +03:00
2006-03-23 14:00:37 +03:00
mutex_init ( & p - > lock ) ;
2005-04-17 02:20:36 +04:00
p - > op = op ;
Make file credentials available to the seqfile interfaces
A lot of seqfile users seem to be using things like %pK that uses the
credentials of the current process, but that is actually completely
wrong for filesystem interfaces.
The unix semantics for permission checking files is to check permissions
at _open_ time, not at read or write time, and that is not just a small
detail: passing off stdin/stdout/stderr to a suid application and making
the actual IO happen in privileged context is a classic exploit
technique.
So if we want to be able to look at permissions at read time, we need to
use the file open credentials, not the current ones. Normal file
accesses can just use "f_cred" (or any of the helper functions that do
that, like file_ns_capable()), but the seqfile interfaces do not have
any such options.
It turns out that seq_file _does_ save away the user_ns information of
the file, though. Since user_ns is just part of the full credential
information, replace that special case with saving off the cred pointer
instead, and suddenly seq_file has all the permission information it
needs.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-04-14 21:22:00 +03:00
// No refcounting: the lifetime of 'p' is constrained
// to the lifetime of the file.
p - > file = file ;
2005-04-17 02:20:36 +04:00
2009-02-19 01:48:16 +03:00
/*
* seq_files support lseek ( ) and pread ( ) . They do not implement
* write ( ) at all , but we clear FMODE_PWRITE here for historical
* reasons .
*
* If a client of seq_files a ) implements file . write ( ) and b ) wishes to
* support pwrite ( ) then that client will need to implement its own
* file . open ( ) which calls seq_open ( ) and then sets FMODE_PWRITE .
*/
file - > f_mode & = ~ FMODE_PWRITE ;
2005-04-17 02:20:36 +04:00
return 0 ;
}
EXPORT_SYMBOL ( seq_open ) ;
2009-02-05 02:12:25 +03:00
static int traverse ( struct seq_file * m , loff_t offset )
{
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
loff_t pos = 0 ;
2009-02-05 02:12:25 +03:00
int error = 0 ;
void * p ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
m - > index = 0 ;
2009-02-05 02:12:25 +03:00
m - > count = m - > from = 0 ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
if ( ! offset )
2009-02-05 02:12:25 +03:00
return 0 ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
2009-02-05 02:12:25 +03:00
if ( ! m - > buf ) {
2014-07-03 02:22:37 +04:00
m - > buf = seq_buf_alloc ( m - > size = PAGE_SIZE ) ;
2009-02-05 02:12:25 +03:00
if ( ! m - > buf )
return - ENOMEM ;
}
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
p = m - > op - > start ( m , & m - > index ) ;
2009-02-05 02:12:25 +03:00
while ( p ) {
error = PTR_ERR ( p ) ;
if ( IS_ERR ( p ) )
break ;
error = m - > op - > show ( m , p ) ;
if ( error < 0 )
break ;
if ( unlikely ( error ) ) {
error = 0 ;
m - > count = 0 ;
}
2014-09-30 03:08:21 +04:00
if ( seq_has_overflowed ( m ) )
2009-02-05 02:12:25 +03:00
goto Eoverflow ;
2019-08-14 01:37:44 +03:00
p = m - > op - > next ( m , p , & m - > index ) ;
2009-02-05 02:12:25 +03:00
if ( pos + m - > count > offset ) {
m - > from = offset - pos ;
m - > count - = m - > from ;
break ;
}
pos + = m - > count ;
m - > count = 0 ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
if ( pos = = offset )
2009-02-05 02:12:25 +03:00
break ;
}
m - > op - > stop ( m , p ) ;
return error ;
Eoverflow :
m - > op - > stop ( m , p ) ;
2014-07-03 02:22:37 +04:00
kvfree ( m - > buf ) ;
2013-11-19 05:20:43 +04:00
m - > count = 0 ;
2014-07-03 02:22:37 +04:00
m - > buf = seq_buf_alloc ( m - > size < < = 1 ) ;
2009-02-05 02:12:25 +03:00
return ! m - > buf ? - ENOMEM : - EAGAIN ;
}
2005-04-17 02:20:36 +04:00
/**
* seq_read - - > read ( ) method for sequential files .
2005-05-01 19:59:26 +04:00
* @ file : the file to read from
* @ buf : the buffer to read to
* @ size : the maximum number of bytes to read
* @ ppos : the current position in the file
2005-04-17 02:20:36 +04:00
*
* Ready - made - > f_op - > read ( )
*/
ssize_t seq_read ( struct file * file , char __user * buf , size_t size , loff_t * ppos )
{
2020-11-04 11:27:33 +03:00
struct iovec iov = { . iov_base = buf , . iov_len = size } ;
struct kiocb kiocb ;
struct iov_iter iter ;
ssize_t ret ;
init_sync_kiocb ( & kiocb , file ) ;
iov_iter_init ( & iter , READ , & iov , 1 , size ) ;
kiocb . ki_pos = * ppos ;
ret = seq_read_iter ( & kiocb , & iter ) ;
* ppos = kiocb . ki_pos ;
return ret ;
}
EXPORT_SYMBOL ( seq_read ) ;
/*
* Ready - made - > f_op - > read_iter ( )
*/
ssize_t seq_read_iter ( struct kiocb * iocb , struct iov_iter * iter )
{
struct seq_file * m = iocb - > ki_filp - > private_data ;
2005-04-17 02:20:36 +04:00
size_t copied = 0 ;
size_t n ;
void * p ;
int err = 0 ;
2020-11-12 22:40:37 +03:00
if ( ! iov_iter_count ( iter ) )
return 0 ;
2006-03-23 14:00:37 +03:00
mutex_lock ( & m - > lock ) ;
2009-02-19 01:48:16 +03:00
2016-11-29 17:18:20 +03:00
/*
* if request is to read from zero offset , reset iterator to first
* record as it might have been already advanced by previous requests
*/
2020-11-04 11:27:33 +03:00
if ( iocb - > ki_pos = = 0 ) {
2016-11-29 17:18:20 +03:00
m - > index = 0 ;
2017-11-15 13:34:58 +03:00
m - > count = 0 ;
}
2016-11-29 17:18:20 +03:00
2020-11-04 11:27:33 +03:00
/* Don't assume ki_pos is where we left it */
if ( unlikely ( iocb - > ki_pos ! = m - > read_pos ) ) {
while ( ( err = traverse ( m , iocb - > ki_pos ) ) = = - EAGAIN )
2009-02-19 01:48:16 +03:00
;
if ( err ) {
/* With prejudice... */
m - > read_pos = 0 ;
m - > index = 0 ;
m - > count = 0 ;
goto Done ;
seq_file: fix mishandling of consecutive pread() invocations.
The following program illustrates the problem:
char buf[8192];
int fd = open("/proc/self/maps", O_RDONLY);
n = pread(fd, buf, sizeof(buf), 0);
printf("%d\n", n);
/* lseek(fd, 0, SEEK_CUR); */ /* Uncomment to work around */
n = pread(fd, buf, sizeof(buf), 0);
printf("%d\n", n);
The second printf() prints zero, but uncommenting the lseek() corrects its
behaviour.
To fix, make seq_read() mirror seq_lseek() when processing changes in
*ppos. Restore m->version first, then if required traverse and update
read_pos on success.
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=11856
Signed-off-by: Earl Chew <echew@ixiacom.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-03-22 03:33:43 +04:00
} else {
2020-11-04 11:27:33 +03:00
m - > read_pos = iocb - > ki_pos ;
2009-02-19 01:48:16 +03:00
}
}
2005-04-17 02:20:36 +04:00
/* grab buffer if we didn't have one */
if ( ! m - > buf ) {
2014-07-03 02:22:37 +04:00
m - > buf = seq_buf_alloc ( m - > size = PAGE_SIZE ) ;
2005-04-17 02:20:36 +04:00
if ( ! m - > buf )
goto Enomem ;
}
2020-11-12 22:40:37 +03:00
// something left in the buffer - copy it out first
2005-04-17 02:20:36 +04:00
if ( m - > count ) {
2020-11-12 22:40:37 +03:00
n = copy_to_iter ( m - > buf + m - > from , m - > count , iter ) ;
2005-04-17 02:20:36 +04:00
m - > count - = n ;
m - > from + = n ;
copied + = n ;
2020-11-12 22:40:37 +03:00
if ( m - > count ) // hadn't managed to copy everything
2005-04-17 02:20:36 +04:00
goto Done ;
}
2020-11-12 22:40:37 +03:00
// get a non-empty record in the buffer
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
m - > from = 0 ;
p = m - > op - > start ( m , & m - > index ) ;
2005-04-17 02:20:36 +04:00
while ( 1 ) {
err = PTR_ERR ( p ) ;
2020-11-12 22:40:37 +03:00
if ( ! p | | IS_ERR ( p ) ) // EOF or an error
2005-04-17 02:20:36 +04:00
break ;
err = m - > op - > show ( m , p ) ;
2020-11-12 22:40:37 +03:00
if ( err < 0 ) // hard error
2005-04-17 02:20:36 +04:00
break ;
2020-11-12 22:40:37 +03:00
if ( unlikely ( err ) ) // ->show() says "skip it"
2008-03-28 07:46:41 +03:00
m - > count = 0 ;
2020-11-12 22:40:37 +03:00
if ( unlikely ( ! m - > count ) ) { // empty record
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
p = m - > op - > next ( m , p , & m - > index ) ;
2008-08-24 15:45:33 +04:00
continue ;
}
2020-11-12 22:40:37 +03:00
if ( ! seq_has_overflowed ( m ) ) // got it
2005-04-17 02:20:36 +04:00
goto Fill ;
2020-11-12 22:40:37 +03:00
// need a bigger buffer
2005-04-17 02:20:36 +04:00
m - > op - > stop ( m , p ) ;
2014-07-03 02:22:37 +04:00
kvfree ( m - > buf ) ;
2013-11-19 05:20:43 +04:00
m - > count = 0 ;
2014-07-03 02:22:37 +04:00
m - > buf = seq_buf_alloc ( m - > size < < = 1 ) ;
2005-04-17 02:20:36 +04:00
if ( ! m - > buf )
goto Enomem ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
p = m - > op - > start ( m , & m - > index ) ;
2005-04-17 02:20:36 +04:00
}
2020-11-12 22:40:37 +03:00
// EOF or an error
2005-04-17 02:20:36 +04:00
m - > op - > stop ( m , p ) ;
m - > count = 0 ;
goto Done ;
Fill :
2020-11-12 22:40:37 +03:00
// one non-empty record is in the buffer; if they want more,
// try to fit more in, but in any case we need to advance
// the iterator once for every record shown.
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
while ( 1 ) {
2005-04-17 02:20:36 +04:00
size_t offs = m - > count ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
loff_t pos = m - > index ;
p = m - > op - > next ( m , p , & m - > index ) ;
2020-04-11 00:34:06 +03:00
if ( pos = = m - > index ) {
2020-06-05 02:51:02 +03:00
pr_info_ratelimited ( " buggy .next function %ps did not update position index \n " ,
m - > op - > next ) ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
m - > index + + ;
2020-04-11 00:34:06 +03:00
}
2020-11-12 22:40:37 +03:00
if ( ! p | | IS_ERR ( p ) ) // no next record for us
2005-04-17 02:20:36 +04:00
break ;
2020-11-12 22:40:37 +03:00
if ( m - > count > = iov_iter_count ( iter ) )
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
break ;
2005-04-17 02:20:36 +04:00
err = m - > op - > show ( m , p ) ;
2020-11-12 22:40:37 +03:00
if ( err > 0 ) { // ->show() says "skip it"
2005-04-17 02:20:36 +04:00
m - > count = offs ;
2020-11-12 22:40:37 +03:00
} else if ( err | | seq_has_overflowed ( m ) ) {
m - > count = offs ;
break ;
2005-04-17 02:20:36 +04:00
}
}
m - > op - > stop ( m , p ) ;
2020-11-12 22:40:37 +03:00
n = copy_to_iter ( m - > buf , m - > count , iter ) ;
2005-04-17 02:20:36 +04:00
copied + = n ;
m - > count - = n ;
fs/seq_file.c: simplify seq_file iteration code and interface
The documentation for seq_file suggests that it is necessary to be able
to move the iterator to a given offset, however that is not the case.
If the iterator is stored in the private data and is stable from one
read() syscall to the next, it is only necessary to support first/next
interactions. Implementing this in a client is a little clumsy.
- if ->start() is given a pos of zero, it should go to start of
sequence.
- if ->start() is given the name pos that was given to the most recent
next() or start(), it should restore the iterator to state just
before that last call
- if ->start is given another number, it should set the iterator one
beyond the start just before the last ->start or ->next call.
Also, the documentation says that the implementation can interpret the
pos however it likes (other than zero meaning start), but seq_file
increments the pos sometimes which does impose on the implementation.
This patch simplifies the interface for first/next iteration and
simplifies the code, while maintaining complete backward compatability.
Now:
- if ->start() is given a pos of zero, it should return an iterator
placed at the start of the sequence
- if ->start() is given a non-zero pos, it should return the iterator
in the same state it was after the last ->start or ->next.
This is particularly useful for interators which walk the multiple
chains in a hash table, e.g. using rhashtable_walk*. See
fs/gfs2/glock.c and drivers/staging/lustre/lustre/llite/vvp_dev.c
A large part of achieving this is to *always* call ->next after ->show
has successfully stored all of an entry in the buffer. Never just
increment the index instead. Also:
- always pass &m->index to ->start() and ->next(), never a temp
variable
- don't clear ->from when ->count is zero, as ->from is dead when
->count is zero.
Some ->next functions do not increment *pos when they return NULL. To
maintain compatability with this, we still need to increment m->index in
one place, if ->next didn't increment it. Note that such ->next
functions are buggy and should be fixed. A simple demonstration is
dd if=/proc/swaps bs=1000 skip=1
Choose any block size larger than the size of /proc/swaps. This will
always show the whole last line of /proc/swaps.
This patch doesn't work around buggy next() functions for this case.
[neilb@suse.com: ensure ->from is valid]
Link: http://lkml.kernel.org/r/87601ryb8a.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Jonathan Corbet <corbet@lwn.net> [docs]
Tested-by: Jann Horn <jannh@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-08-18 01:44:41 +03:00
m - > from = n ;
2005-04-17 02:20:36 +04:00
Done :
2020-11-12 22:40:37 +03:00
if ( unlikely ( ! copied ) ) {
copied = m - > count ? - EFAULT : err ;
} else {
2020-11-04 11:27:33 +03:00
iocb - > ki_pos + = copied ;
2009-02-19 01:48:16 +03:00
m - > read_pos + = copied ;
}
2006-03-23 14:00:37 +03:00
mutex_unlock ( & m - > lock ) ;
2005-04-17 02:20:36 +04:00
return copied ;
Enomem :
err = - ENOMEM ;
goto Done ;
}
2020-11-04 11:27:33 +03:00
EXPORT_SYMBOL ( seq_read_iter ) ;
2005-04-17 02:20:36 +04:00
/**
* seq_lseek - - > llseek ( ) method for sequential files .
2005-05-01 19:59:26 +04:00
* @ file : the file in question
* @ offset : new position
2013-01-10 05:13:00 +04:00
* @ whence : 0 for absolute , 1 for relative position
2005-04-17 02:20:36 +04:00
*
* Ready - made - > f_op - > llseek ( )
*/
2012-12-18 03:59:39 +04:00
loff_t seq_lseek ( struct file * file , loff_t offset , int whence )
2005-04-17 02:20:36 +04:00
{
2010-09-05 05:52:49 +04:00
struct seq_file * m = file - > private_data ;
2008-04-22 17:09:22 +04:00
loff_t retval = - EINVAL ;
2005-04-17 02:20:36 +04:00
2006-03-23 14:00:37 +03:00
mutex_lock ( & m - > lock ) ;
2012-12-18 03:59:39 +04:00
switch ( whence ) {
2013-02-28 05:03:22 +04:00
case SEEK_CUR :
offset + = file - > f_pos ;
2020-08-24 01:36:59 +03:00
fallthrough ;
2013-02-28 05:03:22 +04:00
case SEEK_SET :
if ( offset < 0 )
break ;
retval = offset ;
if ( offset ! = m - > read_pos ) {
while ( ( retval = traverse ( m , offset ) ) = = - EAGAIN )
;
if ( retval ) {
/* with extreme prejudice... */
file - > f_pos = 0 ;
m - > read_pos = 0 ;
m - > index = 0 ;
m - > count = 0 ;
} else {
m - > read_pos = offset ;
retval = file - > f_pos = offset ;
2005-04-17 02:20:36 +04:00
}
seq_file: always update file->f_pos in seq_lseek()
This issue was first pointed out by Jiaxing Wang several months ago, but no
further comments:
https://lkml.org/lkml/2013/6/29/41
As we know pread() does not change f_pos, so after pread(), file->f_pos
and m->read_pos become different. And seq_lseek() does not update file->f_pos
if offset equals to m->read_pos, so after pread() and seq_lseek()(lseek to
m->read_pos), then a subsequent read may read from a wrong position, the
following program produces the problem:
char str1[32] = { 0 };
char str2[32] = { 0 };
int poffset = 10;
int count = 20;
/*open any seq file*/
int fd = open("/proc/modules", O_RDONLY);
pread(fd, str1, count, poffset);
printf("pread:%s\n", str1);
/*seek to where m->read_pos is*/
lseek(fd, poffset+count, SEEK_SET);
/*supposed to read from poffset+count, but this read from position 0*/
read(fd, str2, count);
printf("read:%s\n", str2);
out put:
pread:
ck_netbios_ns 12665
read:
nf_conntrack_netbios
/proc/modules:
nf_conntrack_netbios_ns 12665 0 - Live 0xffffffffa038b000
nf_conntrack_broadcast 12589 1 nf_conntrack_netbios_ns, Live 0xffffffffa0386000
So we always update file->f_pos to offset in seq_lseek() to fix this issue.
Signed-off-by: Jiaxing Wang <hello.wjx@gmail.com>
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2013-10-25 14:15:06 +04:00
} else {
file - > f_pos = offset ;
2013-02-28 05:03:22 +04:00
}
2005-04-17 02:20:36 +04:00
}
2007-07-16 10:40:22 +04:00
mutex_unlock ( & m - > lock ) ;
2005-04-17 02:20:36 +04:00
return retval ;
}
EXPORT_SYMBOL ( seq_lseek ) ;
/**
* seq_release - free the structures associated with sequential file .
* @ file : file in question
2013-02-28 01:59:05 +04:00
* @ inode : its inode
2005-04-17 02:20:36 +04:00
*
* Frees the structures associated with sequential file ; can be used
* as - > f_op - > release ( ) if you don ' t have private data to destroy .
*/
int seq_release ( struct inode * inode , struct file * file )
{
2010-09-05 05:52:49 +04:00
struct seq_file * m = file - > private_data ;
2014-07-03 02:22:37 +04:00
kvfree ( m - > buf ) ;
2018-04-11 02:34:45 +03:00
kmem_cache_free ( seq_file_cache , m ) ;
2005-04-17 02:20:36 +04:00
return 0 ;
}
EXPORT_SYMBOL ( seq_release ) ;
2021-07-01 04:55:34 +03:00
/**
* seq_escape_mem - print data into buffer , escaping some characters
* @ m : target buffer
* @ src : source buffer
* @ len : size of source buffer
* @ flags : flags to pass to string_escape_mem ( )
* @ esc : set of characters that need escaping
*
* Puts data into buffer , replacing each occurrence of character from
* given class ( defined by @ flags and @ esc ) with printable escaped sequence .
*
* Use seq_has_overflowed ( ) to check for errors .
*/
void seq_escape_mem ( struct seq_file * m , const char * src , size_t len ,
unsigned int flags , const char * esc )
{
char * buf ;
size_t size = seq_get_buf ( m , & buf ) ;
int ret ;
ret = string_escape_mem ( src , len , buf , size , flags , esc ) ;
seq_commit ( m , ret < size ? ret : - 1 ) ;
}
EXPORT_SYMBOL ( seq_escape_mem ) ;
2005-04-17 02:20:36 +04:00
/**
* seq_escape - print string into buffer , escaping some characters
* @ m : target buffer
* @ s : string
* @ esc : set of characters that need escaping
*
* Puts string into buffer , replacing each occurrence of character from
2015-09-11 23:07:48 +03:00
* @ esc with usual octal escape .
* Use seq_has_overflowed ( ) to check for errors .
2005-04-17 02:20:36 +04:00
*/
2015-09-11 23:07:48 +03:00
void seq_escape ( struct seq_file * m , const char * s , const char * esc )
2005-04-17 02:20:36 +04:00
{
2021-07-01 04:55:40 +03:00
seq_escape_str ( m , s , ESCAPE_OCTAL , esc ) ;
2005-04-17 02:20:36 +04:00
}
EXPORT_SYMBOL ( seq_escape ) ;
2015-09-11 23:07:48 +03:00
void seq_vprintf ( struct seq_file * m , const char * f , va_list args )
2005-04-17 02:20:36 +04:00
{
int len ;
if ( m - > count < m - > size ) {
len = vsnprintf ( m - > buf + m - > count , m - > size - m - > count , f , args ) ;
if ( m - > count + len < m - > size ) {
m - > count + = len ;
2015-09-11 23:07:48 +03:00
return ;
2005-04-17 02:20:36 +04:00
}
}
2012-03-24 02:02:55 +04:00
seq_set_overflow ( m ) ;
2005-04-17 02:20:36 +04:00
}
2012-06-11 16:16:35 +04:00
EXPORT_SYMBOL ( seq_vprintf ) ;
2015-09-11 23:07:48 +03:00
void seq_printf ( struct seq_file * m , const char * f , . . . )
2012-06-11 16:16:35 +04:00
{
va_list args ;
va_start ( args , f ) ;
2015-09-11 23:07:48 +03:00
seq_vprintf ( m , f , args ) ;
2012-06-11 16:16:35 +04:00
va_end ( args ) ;
}
2005-04-17 02:20:36 +04:00
EXPORT_SYMBOL ( seq_printf ) ;
2021-04-27 20:43:12 +03:00
# ifdef CONFIG_BINARY_PRINTF
void seq_bprintf ( struct seq_file * m , const char * f , const u32 * binary )
{
int len ;
if ( m - > count < m - > size ) {
len = bstr_printf ( m - > buf + m - > count , m - > size - m - > count , f ,
binary ) ;
if ( m - > count + len < m - > size ) {
m - > count + = len ;
return ;
}
}
seq_set_overflow ( m ) ;
}
EXPORT_SYMBOL ( seq_bprintf ) ;
# endif /* CONFIG_BINARY_PRINTF */
2008-11-22 14:28:48 +03:00
/**
2008-11-24 00:24:53 +03:00
* mangle_path - mangle and copy path to buffer beginning
* @ s : buffer start
* @ p : beginning of path in above buffer
* @ esc : set of characters that need escaping
2008-11-22 14:28:48 +03:00
*
* Copy the path from @ p to @ s , replacing each occurrence of character from
* @ esc with usual octal escape .
* Returns pointer past last written character in @ s , or NULL in case of
* failure .
*/
2011-12-09 05:18:57 +04:00
char * mangle_path ( char * s , const char * p , const char * esc )
2008-03-27 15:06:20 +03:00
{
while ( s < = p ) {
char c = * p + + ;
if ( ! c ) {
return s ;
} else if ( ! strchr ( esc , c ) ) {
* s + + = c ;
} else if ( s + 4 > p ) {
break ;
} else {
* s + + = ' \\ ' ;
* s + + = ' 0 ' + ( ( c & 0300 ) > > 6 ) ;
* s + + = ' 0 ' + ( ( c & 070 ) > > 3 ) ;
* s + + = ' 0 ' + ( c & 07 ) ;
}
}
return NULL ;
}
2008-11-28 20:03:22 +03:00
EXPORT_SYMBOL ( mangle_path ) ;
2008-03-27 15:06:20 +03:00
2008-12-02 01:35:00 +03:00
/**
* seq_path - seq_file interface to print a pathname
* @ m : the seq_file handle
* @ path : the struct path to print
* @ esc : set of characters to escape in the output
*
* return the absolute path of ' path ' , as represented by the
* dentry / mnt pair in the path parameter .
2008-03-27 15:06:20 +03:00
*/
2011-12-09 05:18:57 +04:00
int seq_path ( struct seq_file * m , const struct path * path , const char * esc )
2005-04-17 02:20:36 +04:00
{
2009-09-21 16:48:36 +04:00
char * buf ;
size_t size = seq_get_buf ( m , & buf ) ;
int res = - 1 ;
if ( size ) {
char * p = d_path ( path , buf , size ) ;
2005-04-17 02:20:36 +04:00
if ( ! IS_ERR ( p ) ) {
2009-09-21 16:48:36 +04:00
char * end = mangle_path ( buf , p , esc ) ;
if ( end )
res = end - buf ;
2005-04-17 02:20:36 +04:00
}
}
2009-09-21 16:48:36 +04:00
seq_commit ( m , res ) ;
return res ;
2005-04-17 02:20:36 +04:00
}
EXPORT_SYMBOL ( seq_path ) ;
2015-06-19 11:30:28 +03:00
/**
* seq_file_path - seq_file interface to print a pathname of a file
* @ m : the seq_file handle
* @ file : the struct file to print
* @ esc : set of characters to escape in the output
*
* return the absolute path to the file .
*/
int seq_file_path ( struct seq_file * m , struct file * file , const char * esc )
{
return seq_path ( m , & file - > f_path , esc ) ;
}
EXPORT_SYMBOL ( seq_file_path ) ;
2008-03-27 15:06:21 +03:00
/*
* Same as seq_path , but relative to supplied root .
*/
2011-12-09 05:18:57 +04:00
int seq_path_root ( struct seq_file * m , const struct path * path ,
const struct path * root , const char * esc )
2008-03-27 15:06:21 +03:00
{
2009-09-21 16:48:36 +04:00
char * buf ;
size_t size = seq_get_buf ( m , & buf ) ;
int res = - ENAMETOOLONG ;
if ( size ) {
2008-03-27 15:06:21 +03:00
char * p ;
2009-09-21 16:48:36 +04:00
p = __d_path ( path , root , buf , size ) ;
fix apparmor dereferencing potentially freed dentry, sanitize __d_path() API
__d_path() API is asking for trouble and in case of apparmor d_namespace_path()
getting just that. The root cause is that when __d_path() misses the root
it had been told to look for, it stores the location of the most remote ancestor
in *root. Without grabbing references. Sure, at the moment of call it had
been pinned down by what we have in *path. And if we raced with umount -l, we
could have very well stopped at vfsmount/dentry that got freed as soon as
prepend_path() dropped vfsmount_lock.
It is safe to compare these pointers with pre-existing (and known to be still
alive) vfsmount and dentry, as long as all we are asking is "is it the same
address?". Dereferencing is not safe and apparmor ended up stepping into
that. d_namespace_path() really wants to examine the place where we stopped,
even if it's not connected to our namespace. As the result, it looked
at ->d_sb->s_magic of a dentry that might've been already freed by that point.
All other callers had been careful enough to avoid that, but it's really
a bad interface - it invites that kind of trouble.
The fix is fairly straightforward, even though it's bigger than I'd like:
* prepend_path() root argument becomes const.
* __d_path() is never called with NULL/NULL root. It was a kludge
to start with. Instead, we have an explicit function - d_absolute_root().
Same as __d_path(), except that it doesn't get root passed and stops where
it stops. apparmor and tomoyo are using it.
* __d_path() returns NULL on path outside of root. The main
caller is show_mountinfo() and that's precisely what we pass root for - to
skip those outside chroot jail. Those who don't want that can (and do)
use d_path().
* __d_path() root argument becomes const. Everyone agrees, I hope.
* apparmor does *NOT* try to use __d_path() or any of its variants
when it sees that path->mnt is an internal vfsmount. In that case it's
definitely not mounted anywhere and dentry_path() is exactly what we want
there. Handling of sysctl()-triggered weirdness is moved to that place.
* if apparmor is asked to do pathname relative to chroot jail
and __d_path() tells it we it's not in that jail, the sucker just calls
d_absolute_path() instead. That's the other remaining caller of __d_path(),
BTW.
* seq_path_root() does _NOT_ return -ENAMETOOLONG (it's stupid anyway -
the normal seq_file logics will take care of growing the buffer and redoing
the call of ->show() just fine). However, if it gets path not reachable
from root, it returns SEQ_SKIP. The only caller adjusted (i.e. stopped
ignoring the return value as it used to do).
Reviewed-by: John Johansen <john.johansen@canonical.com>
ACKed-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org
2011-12-05 17:43:34 +04:00
if ( ! p )
return SEQ_SKIP ;
2009-09-21 16:48:36 +04:00
res = PTR_ERR ( p ) ;
2008-03-27 15:06:21 +03:00
if ( ! IS_ERR ( p ) ) {
2009-09-21 16:48:36 +04:00
char * end = mangle_path ( buf , p , esc ) ;
if ( end )
res = end - buf ;
else
res = - ENAMETOOLONG ;
2008-03-27 15:06:21 +03:00
}
}
2009-09-21 16:48:36 +04:00
seq_commit ( m , res ) ;
fix apparmor dereferencing potentially freed dentry, sanitize __d_path() API
__d_path() API is asking for trouble and in case of apparmor d_namespace_path()
getting just that. The root cause is that when __d_path() misses the root
it had been told to look for, it stores the location of the most remote ancestor
in *root. Without grabbing references. Sure, at the moment of call it had
been pinned down by what we have in *path. And if we raced with umount -l, we
could have very well stopped at vfsmount/dentry that got freed as soon as
prepend_path() dropped vfsmount_lock.
It is safe to compare these pointers with pre-existing (and known to be still
alive) vfsmount and dentry, as long as all we are asking is "is it the same
address?". Dereferencing is not safe and apparmor ended up stepping into
that. d_namespace_path() really wants to examine the place where we stopped,
even if it's not connected to our namespace. As the result, it looked
at ->d_sb->s_magic of a dentry that might've been already freed by that point.
All other callers had been careful enough to avoid that, but it's really
a bad interface - it invites that kind of trouble.
The fix is fairly straightforward, even though it's bigger than I'd like:
* prepend_path() root argument becomes const.
* __d_path() is never called with NULL/NULL root. It was a kludge
to start with. Instead, we have an explicit function - d_absolute_root().
Same as __d_path(), except that it doesn't get root passed and stops where
it stops. apparmor and tomoyo are using it.
* __d_path() returns NULL on path outside of root. The main
caller is show_mountinfo() and that's precisely what we pass root for - to
skip those outside chroot jail. Those who don't want that can (and do)
use d_path().
* __d_path() root argument becomes const. Everyone agrees, I hope.
* apparmor does *NOT* try to use __d_path() or any of its variants
when it sees that path->mnt is an internal vfsmount. In that case it's
definitely not mounted anywhere and dentry_path() is exactly what we want
there. Handling of sysctl()-triggered weirdness is moved to that place.
* if apparmor is asked to do pathname relative to chroot jail
and __d_path() tells it we it's not in that jail, the sucker just calls
d_absolute_path() instead. That's the other remaining caller of __d_path(),
BTW.
* seq_path_root() does _NOT_ return -ENAMETOOLONG (it's stupid anyway -
the normal seq_file logics will take care of growing the buffer and redoing
the call of ->show() just fine). However, if it gets path not reachable
from root, it returns SEQ_SKIP. The only caller adjusted (i.e. stopped
ignoring the return value as it used to do).
Reviewed-by: John Johansen <john.johansen@canonical.com>
ACKed-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org
2011-12-05 17:43:34 +04:00
return res < 0 & & res ! = - ENAMETOOLONG ? res : 0 ;
2008-03-27 15:06:21 +03:00
}
2008-03-27 15:06:20 +03:00
/*
* returns the path of the ' dentry ' from the root of its filesystem .
*/
2011-12-09 05:18:57 +04:00
int seq_dentry ( struct seq_file * m , struct dentry * dentry , const char * esc )
2008-03-27 15:06:20 +03:00
{
2009-09-21 16:48:36 +04:00
char * buf ;
size_t size = seq_get_buf ( m , & buf ) ;
int res = - 1 ;
if ( size ) {
char * p = dentry_path ( dentry , buf , size ) ;
2008-03-27 15:06:20 +03:00
if ( ! IS_ERR ( p ) ) {
2009-09-21 16:48:36 +04:00
char * end = mangle_path ( buf , p , esc ) ;
if ( end )
res = end - buf ;
2008-03-27 15:06:20 +03:00
}
}
2009-09-21 16:48:36 +04:00
seq_commit ( m , res ) ;
return res ;
2008-03-27 15:06:20 +03:00
}
2015-05-18 12:16:31 +03:00
EXPORT_SYMBOL ( seq_dentry ) ;
2008-03-27 15:06:20 +03:00
2005-04-17 02:20:36 +04:00
static void * single_start ( struct seq_file * p , loff_t * pos )
{
return NULL + ( * pos = = 0 ) ;
}
static void * single_next ( struct seq_file * p , void * v , loff_t * pos )
{
+ + * pos ;
return NULL ;
}
static void single_stop ( struct seq_file * p , void * v )
{
}
int single_open ( struct file * file , int ( * show ) ( struct seq_file * , void * ) ,
void * data )
{
2018-04-11 02:34:49 +03:00
struct seq_operations * op = kmalloc ( sizeof ( * op ) , GFP_KERNEL_ACCOUNT ) ;
2005-04-17 02:20:36 +04:00
int res = - ENOMEM ;
if ( op ) {
op - > start = single_start ;
op - > next = single_next ;
op - > stop = single_stop ;
op - > show = show ;
res = seq_open ( file , op ) ;
if ( ! res )
( ( struct seq_file * ) file - > private_data ) - > private = data ;
else
kfree ( op ) ;
}
return res ;
}
EXPORT_SYMBOL ( single_open ) ;
2013-03-31 21:43:23 +04:00
int single_open_size ( struct file * file , int ( * show ) ( struct seq_file * , void * ) ,
void * data , size_t size )
{
2014-07-03 02:22:37 +04:00
char * buf = seq_buf_alloc ( size ) ;
2013-03-31 21:43:23 +04:00
int ret ;
if ( ! buf )
return - ENOMEM ;
ret = single_open ( file , show , data ) ;
if ( ret ) {
2014-07-03 02:22:37 +04:00
kvfree ( buf ) ;
2013-03-31 21:43:23 +04:00
return ret ;
}
( ( struct seq_file * ) file - > private_data ) - > buf = buf ;
( ( struct seq_file * ) file - > private_data ) - > size = size ;
return 0 ;
}
EXPORT_SYMBOL ( single_open_size ) ;
2005-04-17 02:20:36 +04:00
int single_release ( struct inode * inode , struct file * file )
{
2006-12-07 07:40:36 +03:00
const struct seq_operations * op = ( ( struct seq_file * ) file - > private_data ) - > op ;
2005-04-17 02:20:36 +04:00
int res = seq_release ( inode , file ) ;
kfree ( op ) ;
return res ;
}
EXPORT_SYMBOL ( single_release ) ;
int seq_release_private ( struct inode * inode , struct file * file )
{
struct seq_file * seq = file - > private_data ;
kfree ( seq - > private ) ;
seq - > private = NULL ;
return seq_release ( inode , file ) ;
}
EXPORT_SYMBOL ( seq_release_private ) ;
2007-10-10 13:28:42 +04:00
void * __seq_open_private ( struct file * f , const struct seq_operations * ops ,
int psize )
{
int rc ;
void * private ;
struct seq_file * seq ;
2018-04-11 02:34:49 +03:00
private = kzalloc ( psize , GFP_KERNEL_ACCOUNT ) ;
2007-10-10 13:28:42 +04:00
if ( private = = NULL )
goto out ;
rc = seq_open ( f , ops ) ;
if ( rc < 0 )
goto out_free ;
seq = f - > private_data ;
seq - > private = private ;
return private ;
out_free :
kfree ( private ) ;
out :
return NULL ;
}
EXPORT_SYMBOL ( __seq_open_private ) ;
int seq_open_private ( struct file * filp , const struct seq_operations * ops ,
int psize )
{
return __seq_open_private ( filp , ops , psize ) ? 0 : - ENOMEM ;
}
EXPORT_SYMBOL ( seq_open_private ) ;
2015-09-11 23:07:48 +03:00
void seq_putc ( struct seq_file * m , char c )
2005-04-17 02:20:36 +04:00
{
2015-09-11 23:07:48 +03:00
if ( m - > count > = m - > size )
return ;
m - > buf [ m - > count + + ] = c ;
2005-04-17 02:20:36 +04:00
}
EXPORT_SYMBOL ( seq_putc ) ;
2015-09-11 23:07:48 +03:00
void seq_puts ( struct seq_file * m , const char * s )
2005-04-17 02:20:36 +04:00
{
int len = strlen ( s ) ;
2015-09-11 23:07:48 +03:00
if ( m - > count + len > = m - > size ) {
seq_set_overflow ( m ) ;
return ;
2005-04-17 02:20:36 +04:00
}
2015-09-11 23:07:48 +03:00
memcpy ( m - > buf + m - > count , s , len ) ;
m - > count + = len ;
2005-04-17 02:20:36 +04:00
}
EXPORT_SYMBOL ( seq_puts ) ;
2007-07-11 04:22:26 +04:00
2018-04-11 02:31:16 +03:00
/**
2021-01-14 11:04:39 +03:00
* seq_put_decimal_ull_width - A helper routine for putting decimal numbers
* without rich format of printf ( ) .
2012-03-24 02:02:54 +04:00
* only ' unsigned long long ' is supported .
2018-04-11 02:31:16 +03:00
* @ m : seq_file identifying the buffer to which data should be written
* @ delimiter : a string which is printed before the number
* @ num : the number
* @ width : a minimum field width
*
* This routine will put strlen ( delimiter ) + number into seq_filed .
2012-03-24 02:02:54 +04:00
* This routine is very quick when you show lots of numbers .
* In usual cases , it will be better to use seq_printf ( ) . It ' s easier to read .
*/
2018-04-11 02:31:16 +03:00
void seq_put_decimal_ull_width ( struct seq_file * m , const char * delimiter ,
unsigned long long num , unsigned int width )
2012-03-24 02:02:54 +04:00
{
int len ;
if ( m - > count + 2 > = m - > size ) /* we'll write 2 bytes at least */
goto overflow ;
2018-04-11 02:31:23 +03:00
if ( delimiter & & delimiter [ 0 ] ) {
if ( delimiter [ 1 ] = = 0 )
seq_putc ( m , delimiter [ 0 ] ) ;
else
seq_puts ( m , delimiter ) ;
}
2016-10-08 03:02:20 +03:00
2018-04-11 02:31:16 +03:00
if ( ! width )
width = 1 ;
if ( m - > count + width > = m - > size )
2016-10-08 03:02:20 +03:00
goto overflow ;
2012-03-24 02:02:54 +04:00
2018-04-11 02:31:16 +03:00
len = num_to_str ( m - > buf + m - > count , m - > size - m - > count , num , width ) ;
2012-03-24 02:02:54 +04:00
if ( ! len )
goto overflow ;
2016-10-08 03:02:20 +03:00
2012-03-24 02:02:54 +04:00
m - > count + = len ;
2015-09-11 23:07:48 +03:00
return ;
2012-03-24 02:02:54 +04:00
overflow :
2012-03-24 02:02:55 +04:00
seq_set_overflow ( m ) ;
2012-03-24 02:02:54 +04:00
}
2018-04-11 02:31:16 +03:00
void seq_put_decimal_ull ( struct seq_file * m , const char * delimiter ,
unsigned long long num )
{
return seq_put_decimal_ull_width ( m , delimiter , num , 0 ) ;
}
2012-03-24 02:02:54 +04:00
EXPORT_SYMBOL ( seq_put_decimal_ull ) ;
2018-04-11 02:30:44 +03:00
/**
* seq_put_hex_ll - put a number in hexadecimal notation
* @ m : seq_file identifying the buffer to which data should be written
* @ delimiter : a string which is printed before the number
* @ v : the number
* @ width : a minimum field width
*
* seq_put_hex_ll ( m , " " , v , 8 ) is equal to seq_printf ( m , " %08llx " , v )
*
* This routine is very quick when you show lots of numbers .
* In usual cases , it will be better to use seq_printf ( ) . It ' s easier to read .
*/
void seq_put_hex_ll ( struct seq_file * m , const char * delimiter ,
unsigned long long v , unsigned int width )
{
unsigned int len ;
int i ;
if ( delimiter & & delimiter [ 0 ] ) {
if ( delimiter [ 1 ] = = 0 )
seq_putc ( m , delimiter [ 0 ] ) ;
else
seq_puts ( m , delimiter ) ;
}
/* If x is 0, the result of __builtin_clzll is undefined */
if ( v = = 0 )
len = 1 ;
else
len = ( sizeof ( v ) * 8 - __builtin_clzll ( v ) + 3 ) / 4 ;
if ( len < width )
len = width ;
if ( m - > count + len > m - > size ) {
seq_set_overflow ( m ) ;
return ;
}
for ( i = len - 1 ; i > = 0 ; i - - ) {
m - > buf [ m - > count + i ] = hex_asc [ 0xf & v ] ;
v = v > > 4 ;
}
m - > count + = len ;
}
2016-10-08 03:02:20 +03:00
void seq_put_decimal_ll ( struct seq_file * m , const char * delimiter , long long num )
2012-03-24 02:02:54 +04:00
{
2016-10-08 03:02:20 +03:00
int len ;
if ( m - > count + 3 > = m - > size ) /* we'll write 2 bytes at least */
goto overflow ;
2018-04-11 02:31:23 +03:00
if ( delimiter & & delimiter [ 0 ] ) {
if ( delimiter [ 1 ] = = 0 )
seq_putc ( m , delimiter [ 0 ] ) ;
else
seq_puts ( m , delimiter ) ;
}
2016-10-08 03:02:20 +03:00
if ( m - > count + 2 > = m - > size )
goto overflow ;
2012-03-24 02:02:54 +04:00
if ( num < 0 ) {
2016-10-08 03:02:20 +03:00
m - > buf [ m - > count + + ] = ' - ' ;
2012-03-24 02:02:54 +04:00
num = - num ;
}
2016-10-08 03:02:20 +03:00
if ( num < 10 ) {
m - > buf [ m - > count + + ] = num + ' 0 ' ;
return ;
}
2018-04-11 02:31:16 +03:00
len = num_to_str ( m - > buf + m - > count , m - > size - m - > count , num , 0 ) ;
2016-10-08 03:02:20 +03:00
if ( ! len )
goto overflow ;
m - > count + = len ;
return ;
overflow :
seq_set_overflow ( m ) ;
2012-03-24 02:02:54 +04:00
}
EXPORT_SYMBOL ( seq_put_decimal_ll ) ;
2009-06-18 03:28:05 +04:00
/**
* seq_write - write arbitrary data to buffer
* @ seq : seq_file identifying the buffer to which data should be written
* @ data : data address
* @ len : number of bytes
*
* Return 0 on success , non - zero otherwise .
*/
int seq_write ( struct seq_file * seq , const void * data , size_t len )
{
if ( seq - > count + len < seq - > size ) {
memcpy ( seq - > buf + seq - > count , data , len ) ;
seq - > count + = len ;
return 0 ;
}
2012-03-24 02:02:55 +04:00
seq_set_overflow ( seq ) ;
2009-06-18 03:28:05 +04:00
return - 1 ;
}
EXPORT_SYMBOL ( seq_write ) ;
2013-11-15 02:31:56 +04:00
/**
* seq_pad - write padding spaces to buffer
* @ m : seq_file identifying the buffer to which data should be written
* @ c : the byte to append after padding if non - zero
*/
void seq_pad ( struct seq_file * m , char c )
{
int size = m - > pad_until - m - > count ;
2018-04-11 02:30:47 +03:00
if ( size > 0 ) {
if ( size + m - > count > m - > size ) {
seq_set_overflow ( m ) ;
return ;
}
memset ( m - > buf + m - > count , ' ' , size ) ;
m - > count + = size ;
}
2013-11-15 02:31:56 +04:00
if ( c )
seq_putc ( m , c ) ;
}
EXPORT_SYMBOL ( seq_pad ) ;
2015-09-10 01:38:33 +03:00
/* A complete analogue of print_hex_dump() */
void seq_hex_dump ( struct seq_file * m , const char * prefix_str , int prefix_type ,
int rowsize , int groupsize , const void * buf , size_t len ,
bool ascii )
{
const u8 * ptr = buf ;
int i , linelen , remaining = len ;
2015-11-07 03:32:37 +03:00
char * buffer ;
size_t size ;
2015-09-10 01:38:33 +03:00
int ret ;
if ( rowsize ! = 16 & & rowsize ! = 32 )
rowsize = 16 ;
for ( i = 0 ; i < len & & ! seq_has_overflowed ( m ) ; i + = rowsize ) {
linelen = min ( remaining , rowsize ) ;
remaining - = rowsize ;
switch ( prefix_type ) {
case DUMP_PREFIX_ADDRESS :
seq_printf ( m , " %s%p: " , prefix_str , ptr + i ) ;
break ;
case DUMP_PREFIX_OFFSET :
seq_printf ( m , " %s%.8x: " , prefix_str , i ) ;
break ;
default :
seq_printf ( m , " %s " , prefix_str ) ;
break ;
}
2015-11-07 03:32:37 +03:00
size = seq_get_buf ( m , & buffer ) ;
2015-09-10 01:38:33 +03:00
ret = hex_dump_to_buffer ( ptr + i , linelen , rowsize , groupsize ,
2015-11-07 03:32:37 +03:00
buffer , size , ascii ) ;
seq_commit ( m , ret < size ? ret : - 1 ) ;
seq_putc ( m , ' \n ' ) ;
2015-09-10 01:38:33 +03:00
}
}
EXPORT_SYMBOL ( seq_hex_dump ) ;
2007-07-11 04:22:26 +04:00
struct list_head * seq_list_start ( struct list_head * head , loff_t pos )
{
struct list_head * lh ;
list_for_each ( lh , head )
if ( pos - - = = 0 )
return lh ;
return NULL ;
}
EXPORT_SYMBOL ( seq_list_start ) ;
struct list_head * seq_list_start_head ( struct list_head * head , loff_t pos )
{
if ( ! pos )
return head ;
return seq_list_start ( head , pos - 1 ) ;
}
EXPORT_SYMBOL ( seq_list_start_head ) ;
struct list_head * seq_list_next ( void * v , struct list_head * head , loff_t * ppos )
{
struct list_head * lh ;
lh = ( ( struct list_head * ) v ) - > next ;
+ + * ppos ;
return lh = = head ? NULL : lh ;
}
EXPORT_SYMBOL ( seq_list_next ) ;
2010-02-09 02:18:22 +03:00
/**
* seq_hlist_start - start an iteration of a hlist
* @ head : the head of the hlist
* @ pos : the start position of the sequence
*
* Called at seq_file - > op - > start ( ) .
*/
struct hlist_node * seq_hlist_start ( struct hlist_head * head , loff_t pos )
{
struct hlist_node * node ;
hlist_for_each ( node , head )
if ( pos - - = = 0 )
return node ;
return NULL ;
}
EXPORT_SYMBOL ( seq_hlist_start ) ;
/**
* seq_hlist_start_head - start an iteration of a hlist
* @ head : the head of the hlist
* @ pos : the start position of the sequence
*
* Called at seq_file - > op - > start ( ) . Call this function if you want to
* print a header at the top of the output .
*/
struct hlist_node * seq_hlist_start_head ( struct hlist_head * head , loff_t pos )
{
if ( ! pos )
return SEQ_START_TOKEN ;
return seq_hlist_start ( head , pos - 1 ) ;
}
EXPORT_SYMBOL ( seq_hlist_start_head ) ;
/**
* seq_hlist_next - move to the next position of the hlist
* @ v : the current iterator
* @ head : the head of the hlist
2010-03-04 20:37:12 +03:00
* @ ppos : the current position
2010-02-09 02:18:22 +03:00
*
* Called at seq_file - > op - > next ( ) .
*/
struct hlist_node * seq_hlist_next ( void * v , struct hlist_head * head ,
loff_t * ppos )
{
struct hlist_node * node = v ;
+ + * ppos ;
if ( v = = SEQ_START_TOKEN )
return head - > first ;
else
return node - > next ;
}
EXPORT_SYMBOL ( seq_hlist_next ) ;
2010-02-22 10:57:17 +03:00
/**
* seq_hlist_start_rcu - start an iteration of a hlist protected by RCU
* @ head : the head of the hlist
* @ pos : the start position of the sequence
*
* Called at seq_file - > op - > start ( ) .
*
* This list - traversal primitive may safely run concurrently with
* the _rcu list - mutation primitives such as hlist_add_head_rcu ( )
* as long as the traversal is guarded by rcu_read_lock ( ) .
*/
struct hlist_node * seq_hlist_start_rcu ( struct hlist_head * head ,
loff_t pos )
{
struct hlist_node * node ;
__hlist_for_each_rcu ( node , head )
if ( pos - - = = 0 )
return node ;
return NULL ;
}
EXPORT_SYMBOL ( seq_hlist_start_rcu ) ;
/**
* seq_hlist_start_head_rcu - start an iteration of a hlist protected by RCU
* @ head : the head of the hlist
* @ pos : the start position of the sequence
*
* Called at seq_file - > op - > start ( ) . Call this function if you want to
* print a header at the top of the output .
*
* This list - traversal primitive may safely run concurrently with
* the _rcu list - mutation primitives such as hlist_add_head_rcu ( )
* as long as the traversal is guarded by rcu_read_lock ( ) .
*/
struct hlist_node * seq_hlist_start_head_rcu ( struct hlist_head * head ,
loff_t pos )
{
if ( ! pos )
return SEQ_START_TOKEN ;
return seq_hlist_start_rcu ( head , pos - 1 ) ;
}
EXPORT_SYMBOL ( seq_hlist_start_head_rcu ) ;
/**
* seq_hlist_next_rcu - move to the next position of the hlist protected by RCU
* @ v : the current iterator
* @ head : the head of the hlist
2010-03-04 20:37:12 +03:00
* @ ppos : the current position
2010-02-22 10:57:17 +03:00
*
* Called at seq_file - > op - > next ( ) .
*
* This list - traversal primitive may safely run concurrently with
* the _rcu list - mutation primitives such as hlist_add_head_rcu ( )
* as long as the traversal is guarded by rcu_read_lock ( ) .
*/
struct hlist_node * seq_hlist_next_rcu ( void * v ,
struct hlist_head * head ,
loff_t * ppos )
{
struct hlist_node * node = v ;
+ + * ppos ;
if ( v = = SEQ_START_TOKEN )
return rcu_dereference ( head - > first ) ;
else
return rcu_dereference ( node - > next ) ;
}
EXPORT_SYMBOL ( seq_hlist_next_rcu ) ;
2013-06-21 16:58:21 +04:00
/**
2021-01-14 11:04:39 +03:00
* seq_hlist_start_percpu - start an iteration of a percpu hlist array
2013-06-21 16:58:21 +04:00
* @ head : pointer to percpu array of struct hlist_heads
* @ cpu : pointer to cpu " cursor "
* @ pos : start position of sequence
*
* Called at seq_file - > op - > start ( ) .
*/
struct hlist_node *
seq_hlist_start_percpu ( struct hlist_head __percpu * head , int * cpu , loff_t pos )
{
struct hlist_node * node ;
for_each_possible_cpu ( * cpu ) {
hlist_for_each ( node , per_cpu_ptr ( head , * cpu ) ) {
if ( pos - - = = 0 )
return node ;
}
}
return NULL ;
}
EXPORT_SYMBOL ( seq_hlist_start_percpu ) ;
/**
* seq_hlist_next_percpu - move to the next position of the percpu hlist array
* @ v : pointer to current hlist_node
* @ head : pointer to percpu array of struct hlist_heads
* @ cpu : pointer to cpu " cursor "
* @ pos : start position of sequence
*
* Called at seq_file - > op - > next ( ) .
*/
struct hlist_node *
seq_hlist_next_percpu ( void * v , struct hlist_head __percpu * head ,
int * cpu , loff_t * pos )
{
struct hlist_node * node = v ;
+ + * pos ;
if ( node - > next )
return node - > next ;
for ( * cpu = cpumask_next ( * cpu , cpu_possible_mask ) ; * cpu < nr_cpu_ids ;
* cpu = cpumask_next ( * cpu , cpu_possible_mask ) ) {
struct hlist_head * bucket = per_cpu_ptr ( head , * cpu ) ;
if ( ! hlist_empty ( bucket ) )
return bucket - > first ;
}
return NULL ;
}
EXPORT_SYMBOL ( seq_hlist_next_percpu ) ;
2018-04-11 02:34:45 +03:00
void __init seq_file_init ( void )
{
2018-04-11 02:34:49 +03:00
seq_file_cache = KMEM_CACHE ( seq_file , SLAB_ACCOUNT | SLAB_PANIC ) ;
2018-04-11 02:34:45 +03:00
}