From 0093b9e9704cc932363c66b2b072b762771ffe1f Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Thu, 5 Jan 2023 03:55:23 -0500 Subject: [PATCH] bcachefs: Fix promote path leak Signed-off-by: Kent Overstreet --- fs/bcachefs/io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/io.c b/fs/bcachefs/io.c index 93d300812b4b..1436863fe418 100644 --- a/fs/bcachefs/io.c +++ b/fs/bcachefs/io.c @@ -1924,6 +1924,8 @@ static void promote_free(struct bch_fs *c, struct promote_op *op) { int ret; + bch2_data_update_exit(&op->write); + ret = rhashtable_remove_fast(&c->promote_table, &op->hash, bch_promote_params); BUG_ON(ret); @@ -1939,8 +1941,6 @@ static void promote_done(struct bch_write_op *wop) bch2_time_stats_update(&c->times[BCH_TIME_data_promote], op->start_time); - - bch2_data_update_exit(&op->write); promote_free(c, op); }