iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/move_mount_set_group remove unneeded conversion to bool

Browse Source 
The coccinelle report
./tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c:225:18-23:
WARNING: conversion to bool not needed here
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
This commit is contained in:
Yang Guang 2021-12-06 08:07:23 +08:00 committed by Shuah Khan
parent 6d425d7c1b
commit 009482c093
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/testing/selftests/move_mount_set_group/move_mount_set_group_test.c
View File

@ -191,7 +191,7 @@ static bool is_shared_mount(const char *path)
#define SET_GROUP_FROM "/tmp/move_mount_set_group_supported_from"
#define SET_GROUP_TO "/tmp/move_mount_set_group_supported_to"
static int move_mount_set_group_supported(void)
static bool move_mount_set_group_supported(void)
{
int ret;
@ -222,7 +222,7 @@ static int move_mount_set_group_supported(void)
AT_FDCWD, SET_GROUP_TO, MOVE_MOUNT_SET_GROUP);
umount2("/tmp", MNT_DETACH);
return ret < 0 ? false : true;
return ret >= 0;
}
FIXTURE(move_mount_set_group) {
@ -232,7 +232,7 @@ FIXTURE(move_mount_set_group) {
FIXTURE_SETUP(move_mount_set_group)
{
int ret;
bool ret;
ASSERT_EQ(prepare_unpriv_mountns(), 0);
@ -254,7 +254,7 @@ FIXTURE_SETUP(move_mount_set_group)
FIXTURE_TEARDOWN(move_mount_set_group)
{
int ret;
bool ret;
ret = move_mount_set_group_supported();
ASSERT_GE(ret, 0);
@ -348,7 +348,7 @@ TEST_F(move_mount_set_group, complex_sharing_copying)
.shared = false,
};
pid_t pid;
int ret;
bool ret;
ret = move_mount_set_group_supported();
ASSERT_GE(ret, 0);