iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: surface-hid: kbd: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Uwe Kleine-König 2024-03-06 18:50:50 +01:00 committed by Jiri Kosina
parent afbc301cc0
commit 009faf979e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hid/surface-hid/surface_kbd.c
View File

@ -271,10 +271,9 @@ static int surface_kbd_probe(struct platform_device *pdev)
return surface_hid_device_add(shid); return surface_hid_device_add(shid);
} }
static int surface_kbd_remove(struct platform_device *pdev) static void surface_kbd_remove(struct platform_device *pdev)
{ {
surface_hid_device_destroy(platform_get_drvdata(pdev)); surface_hid_device_destroy(platform_get_drvdata(pdev));
return 0;
} }
static const struct acpi_device_id surface_kbd_match[] = { static const struct acpi_device_id surface_kbd_match[] = {
@ -285,7 +284,7 @@ MODULE_DEVICE_TABLE(acpi, surface_kbd_match);
static struct platform_driver surface_kbd_driver = { static struct platform_driver surface_kbd_driver = {
.probe = surface_kbd_probe, .probe = surface_kbd_probe,
.remove = surface_kbd_remove, .remove_new = surface_kbd_remove,
.driver = { .driver = {
.name = "surface_keyboard", .name = "surface_keyboard",
.acpi_match_table = surface_kbd_match, .acpi_match_table = surface_kbd_match,