iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ethoc: Make use of the helper function dev_err_probe()

Browse Source 
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Cai Huoqing 2021-09-15 22:58:27 +08:00 committed by David S. Miller
parent a72691ee19
commit 015a22f46b
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/ethernet/ethoc.c
View File

@ -707,20 +707,16 @@ static int ethoc_mdio_probe(struct net_device *dev)
else else
phy = phy_find_first(priv->mdio); phy = phy_find_first(priv->mdio);
if (!phy) { if (!phy)
dev_err(&dev->dev, "no PHY found\n"); return dev_err_probe(&dev->dev, -ENXIO, "no PHY found\n");
return -ENXIO;
}
priv->old_duplex = -1; priv->old_duplex = -1;
priv->old_link = -1; priv->old_link = -1;
err = phy_connect_direct(dev, phy, ethoc_mdio_poll, err = phy_connect_direct(dev, phy, ethoc_mdio_poll,
PHY_INTERFACE_MODE_GMII); PHY_INTERFACE_MODE_GMII);
if (err) { if (err)
dev_err(&dev->dev, "could not attach to PHY\n"); return dev_err_probe(&dev->dev, err, "could not attach to PHY\n");
return err;
}
phy_set_max_speed(phy, SPEED_100); phy_set_max_speed(phy, SPEED_100);