iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

smsc95xx: remove unused completion struct

Browse Source 
Oliver Neukum spotted the useless complete() in our async callback.  On
closer inspection, the entire completion struct is unused.  This patch
removes it.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Steve Glendinning 2009-01-25 17:53:58 -08:00 committed by David S. Miller
parent 0db155de98
commit 01a1ac472f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/usb/smsc95xx.c
View File

@ -55,7 +55,6 @@ struct smsc95xx_priv {
struct usb_context { struct usb_context {
struct usb_ctrlrequest req; struct usb_ctrlrequest req;
struct completion notify;
struct usbnet *dev; struct usbnet *dev;
}; };
@ -316,8 +315,6 @@ static void smsc95xx_async_cmd_callback(struct urb *urb, struct pt_regs *regs)
if (status < 0) if (status < 0)
devwarn(dev, "async callback failed with %d", status); devwarn(dev, "async callback failed with %d", status);
complete(&usb_context->notify);
kfree(usb_context); kfree(usb_context);
usb_free_urb(urb); usb_free_urb(urb);
} }
@ -348,7 +345,6 @@ static int smsc95xx_write_reg_async(struct usbnet *dev, u16 index, u32 *data)
usb_context->req.wValue = 00; usb_context->req.wValue = 00;
usb_context->req.wIndex = cpu_to_le16(index); usb_context->req.wIndex = cpu_to_le16(index);
usb_context->req.wLength = cpu_to_le16(size); usb_context->req.wLength = cpu_to_le16(size);
init_completion(&usb_context->notify);
usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0), usb_fill_control_urb(urb, dev->udev, usb_sndctrlpipe(dev->udev, 0),
(void *)&usb_context->req, data, size, (void *)&usb_context->req, data, size,