iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: fix misspelled S_IS...()

Browse Source 
mode_t is not a bitmap...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2011-07-25 20:54:24 -04:00
parent abbede1b3a
commit 03209378b4
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/linux-2.6/xfs_ioctl.c
View File

@ -265,7 +265,7 @@ xfs_open_by_handle(
return PTR_ERR(filp); return PTR_ERR(filp);
} }
if (inode->i_mode & S_IFREG) { if (S_ISREG(inode->i_mode)) {
filp->f_flags |= O_NOATIME; filp->f_flags |= O_NOATIME;
filp->f_mode |= FMODE_NOCMTIME; filp->f_mode |= FMODE_NOCMTIME;
} }

12
fs/xfs/xfs_filestream.c
View File

@ -345,8 +345,8 @@ _xfs_filestream_update_ag(
* directory and pip is NULL. * directory and pip is NULL.
*/ */
ASSERT(ip && ((S_ISREG(ip->i_d.di_mode) && pip && ASSERT(ip && ((S_ISREG(ip->i_d.di_mode) && pip &&
(pip->i_d.di_mode & S_IFDIR)) || S_ISDIR(pip->i_d.di_mode)) ||
((ip->i_d.di_mode & S_IFDIR) && !pip))); (S_ISDIR(ip->i_d.di_mode) && !pip)));
mp = ip->i_mount; mp = ip->i_mount;
cache = mp->m_filestream; cache = mp->m_filestream;
@ -537,7 +537,7 @@ xfs_filestream_lookup_ag(
xfs_agnumber_t ag; xfs_agnumber_t ag;
int ref; int ref;
if (!(ip->i_d.di_mode & (S_IFREG | S_IFDIR))) { if (!S_ISREG(ip->i_d.di_mode) && !S_ISDIR(ip->i_d.di_mode)) {
ASSERT(0); ASSERT(0);
return NULLAGNUMBER; return NULLAGNUMBER;
} }
@ -579,9 +579,9 @@ xfs_filestream_associate(
xfs_agnumber_t ag, rotorstep, startag; xfs_agnumber_t ag, rotorstep, startag;
int err = 0; int err = 0;
ASSERT(pip->i_d.di_mode & S_IFDIR); ASSERT(S_ISDIR(pip->i_d.di_mode));
ASSERT(ip->i_d.di_mode & S_IFREG); ASSERT(S_ISREG(ip->i_d.di_mode));
if (!(pip->i_d.di_mode & S_IFDIR) || !(ip->i_d.di_mode & S_IFREG)) if (!S_ISDIR(pip->i_d.di_mode) || !S_ISREG(ip->i_d.di_mode))
return -EINVAL; return -EINVAL;
mp = pip->i_mount; mp = pip->i_mount;