iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: cfg80211: reg: hold wiphy mutex for wdev iteration

Browse Source 
Since we will want to remove the wdev lock in the future,
lock the wiphy here to iterate and check the flags.

Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Johannes Berg 2023-08-28 13:59:53 +02:00
parent 0e8185ce1d
commit 0320d68f56
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/wireless/reg.c
View File

@ -3575,14 +3575,17 @@ static bool is_wiphy_all_set_reg_flag(enum ieee80211_regulatory_flags flag)
struct wireless_dev *wdev; struct wireless_dev *wdev;
for_each_rdev(rdev) { for_each_rdev(rdev) {
wiphy_lock(&rdev->wiphy);
list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) { list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) {
wdev_lock(wdev); wdev_lock(wdev);
if (!(wdev->wiphy->regulatory_flags & flag)) { if (!(wdev->wiphy->regulatory_flags & flag)) {
wdev_unlock(wdev); wdev_unlock(wdev);
wiphy_unlock(&rdev->wiphy);
return false; return false;
} }
wdev_unlock(wdev); wdev_unlock(wdev);
} }
wiphy_unlock(&rdev->wiphy);
} }
return true; return true;