iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] cs5535_gpio.c: call cdev_del() during module_exit to unmap kobject references and other cleanups

Browse Source 
During module unloading, cdev_del() must be called to unmap cdev related
kobject references and other cleanups(such as inode->i_cdev being set to
NULL) which prevents the OOPS upon subsequent loading, usage and unloading
of modules(as seen in the mail thread
http://marc.theaimsgroup.com/?l=linux-kernel&m=114533640609018&w=2).

Also, remove unneeded test of gpio_base.

Signed-off-by: Thayumanavar Sachithanantham <thayumk@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Thayumanavar Sachithanantham
2006-04-20 02:43:15 -07:00
committed by Linus Torvalds
parent c16c556e0e
commit 0324680064
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/cs5535_gpio.c
View File

@@ -241,9 +241,10 @@ static int __init cs5535_gpio_init(void)
static void __exit cs5535_gpio_cleanup(void) static void __exit cs5535_gpio_cleanup(void)
{ {
dev_t dev_id = MKDEV(major, 0); dev_t dev_id = MKDEV(major, 0);
cdev_del(&cs5535_gpio_cdev);
unregister_chrdev_region(dev_id, CS5535_GPIO_COUNT); unregister_chrdev_region(dev_id, CS5535_GPIO_COUNT);
if (gpio_base != 0) release_region(gpio_base, CS5535_GPIO_SIZE);
release_region(gpio_base, CS5535_GPIO_SIZE);
} }
module_init(cs5535_gpio_init); module_init(cs5535_gpio_init);