iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

blktrace: use BLKTRACE_BDEV_SIZE as the name size for setup structure

Browse Source 
Define as 32, which is is what BDEVNAME_SIZE is/was as well. This keeps
the user interface the same and gets rid of the difference between
kernel and user api here.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Jens Axboe 2008-10-01 16:16:25 +02:00
parent ef9e3facdf
commit 0497b345e7
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
block/blktrace.c
View File

@ -369,7 +369,8 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (!buts->buf_size || !buts->buf_nr) if (!buts->buf_size || !buts->buf_nr)
return -EINVAL; return -EINVAL;
strcpy(buts->name, name); strncpy(buts->name, name, BLKTRACE_BDEV_SIZE);
buts->name[BLKTRACE_BDEV_SIZE - 1] = '\0';
/* /*
* some device names have larger paths - convert the slashes * some device names have larger paths - convert the slashes

8
include/linux/blktrace_api.h
View File

@ -122,15 +122,13 @@ enum {
Blktrace_stopped, Blktrace_stopped,
}; };
#define BLKTRACE_BDEV_SIZE 32
/* /*
* User setup structure passed with BLKTRACESTART * User setup structure passed with BLKTRACESTART
*/ */
struct blk_user_trace_setup { struct blk_user_trace_setup {
#ifdef __KERNEL__ char name[BLKTRACE_BDEV_SIZE]; /* output */
char name[BDEVNAME_SIZE]; /* output */
#else
char name[32]; /* output */
#endif
__u16 act_mask; /* input */ __u16 act_mask; /* input */
__u32 buf_size; /* input */ __u32 buf_size; /* input */
__u32 buf_nr; /* input */ __u32 buf_nr; /* input */