iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

efivars: memory leak on error in create_efivars_bin_attributes()

Browse Source 
This is a cut and paste bug.  We intended to free ->del_var and
->new_var but we only free ->new_var.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Dan Carpenter 2011-03-18 10:12:14 +03:00 committed by Greg Kroah-Hartman
parent bcdd323b89
commit 051d51bc6a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/firmware/efivars.c
View File

@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars)
return 0; return 0;
out_free: out_free:
kfree(efivars->new_var); kfree(efivars->del_var);
efivars->new_var = NULL; efivars->del_var = NULL;
kfree(efivars->new_var); kfree(efivars->new_var);
efivars->new_var = NULL; efivars->new_var = NULL;
return error; return error;