iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: iio: adc: ad7280a: handle error from __ad7280_read32()

Browse Source 
Inside __ad7280_read32(), the spi_sync_transfer() can fail with negative
error code. This change will ensure that this error is being passed up
in the call stack, so it can be handled.

Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Slawomir Stepien
2018-10-20 23:04:11 +02:00
committed by Jonathan Cameron
parent 5729746102
commit 0559ef7fde
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/iio/adc/ad7280a.c
View File

@ -256,7 +256,9 @@ static int ad7280_read(struct ad7280_state *st, unsigned int devaddr,
if (ret) if (ret)
return ret; return ret;
__ad7280_read32(st, &tmp); ret = __ad7280_read32(st, &tmp);
if (ret)
return ret;
if (ad7280_check_crc(st, tmp)) if (ad7280_check_crc(st, tmp))
return -EIO; return -EIO;
@ -294,7 +296,9 @@ static int ad7280_read_channel(struct ad7280_state *st, unsigned int devaddr,
ad7280_delay(st); ad7280_delay(st);
__ad7280_read32(st, &tmp); ret = __ad7280_read32(st, &tmp);
if (ret)
return ret;
if (ad7280_check_crc(st, tmp)) if (ad7280_check_crc(st, tmp))
return -EIO; return -EIO;
@ -327,7 +331,9 @@ static int ad7280_read_all_channels(struct ad7280_state *st, unsigned int cnt,
ad7280_delay(st); ad7280_delay(st);
for (i = 0; i < cnt; i++) { for (i = 0; i < cnt; i++) {
__ad7280_read32(st, &tmp); ret = __ad7280_read32(st, &tmp);
if (ret)
return ret;
if (ad7280_check_crc(st, tmp)) if (ad7280_check_crc(st, tmp))
return -EIO; return -EIO;
@ -370,7 +376,10 @@ static int ad7280_chain_setup(struct ad7280_state *st)
return ret; return ret;
for (n = 0; n <= AD7280A_MAX_CHAIN; n++) { for (n = 0; n <= AD7280A_MAX_CHAIN; n++) {
__ad7280_read32(st, &val); ret = __ad7280_read32(st, &val);
if (ret)
return ret;
if (val == 0) if (val == 0)
return n - 1; return n - 1;