iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fsl/fman: fix dereference null return value

Browse Source 
Check before using returned value to avoid dereferencing null pointer.

Fixes: 18a6c85fcc78 ("fsl/fman: Add FMan Port Support")
Signed-off-by: Florinel Iordache <florinel.iordache@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Florinel Iordache 2020-08-03 10:07:31 +03:00 committed by David S. Miller
parent 99f47abd9f
commit 0572054617
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/freescale/fman/fman_port.c
View File

@ -1767,6 +1767,7 @@ static int fman_port_probe(struct platform_device *of_dev)
struct fman_port *port; struct fman_port *port;
struct fman *fman; struct fman *fman;
struct device_node *fm_node, *port_node; struct device_node *fm_node, *port_node;
struct platform_device *fm_pdev;
struct resource res; struct resource res;
struct resource *dev_res; struct resource *dev_res;
u32 val; u32 val;
@ -1791,8 +1792,14 @@ static int fman_port_probe(struct platform_device *of_dev)
goto return_err; goto return_err;
} }
fman = dev_get_drvdata(&of_find_device_by_node(fm_node)->dev); fm_pdev = of_find_device_by_node(fm_node);
of_node_put(fm_node); of_node_put(fm_node);
if (!fm_pdev) {
err = -EINVAL;
goto return_err;
}
fman = dev_get_drvdata(&fm_pdev->dev);
if (!fman) { if (!fman) {
err = -EINVAL; err = -EINVAL;
goto return_err; goto return_err;