iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tty: rpmsg: Assign returned id to a local variable

Browse Source 
Instead of putting garbage in the data structure, assign allocated id
or an error code to a temporary variable. This makes code cleaner.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211025135148.53944-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andy Shevchenko
2021-10-25 16:51:44 +03:00
committed by Greg Kroah-Hartman
parent 6333a48506
commit 0572da285d
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/tty/rpmsg_tty.c
View File

@@ -121,15 +121,16 @@ static struct rpmsg_tty_port *rpmsg_tty_alloc_cport(void)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
mutex_lock(&idr_lock); mutex_lock(&idr_lock);
cport->id = idr_alloc(&tty_idr, cport, 0, MAX_TTY_RPMSG, GFP_KERNEL); err = idr_alloc(&tty_idr, cport, 0, MAX_TTY_RPMSG, GFP_KERNEL);
mutex_unlock(&idr_lock); mutex_unlock(&idr_lock);
if (cport->id < 0) { if (err < 0) {
err = cport->id;
kfree(cport); kfree(cport);
return ERR_PTR(err); return ERR_PTR(err);
} }
cport->id = err;
return cport; return cport;
} }