iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: rsi: fix restricted __le32 degrades to integer sparse warnings

Browse Source 
drivers/net/wireless/rsi/rsi_91x_usb.c:235:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:236:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:237:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:238:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:244:36: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:245:35: warning: restricted __le32 degrades to integer

These cpu_to_le32() are not making sense. With usb_reg_buf we handle the values
byte at a time to make sure usb_reg_buf is in little endian so no need to
convert anything. And usb_control_msg() expects to have the values in native
endian anyway. So just remove these so they are not spamming our logs.

Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240130151556.2315951-3-kvalo@kernel.org
This commit is contained in:
Kalle Valo 2024-01-30 17:15:54 +02:00
parent 2b59c9c30b
commit 0583e5acaf
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/wireless/rsi/rsi_91x_usb.c
View File

@ -232,17 +232,17 @@ static int rsi_usb_reg_write(struct usb_device *usbdev,
if (!usb_reg_buf)
return status;
usb_reg_buf[0] = (cpu_to_le32(value) & 0x00ff);
usb_reg_buf[1] = (cpu_to_le32(value) & 0xff00) >> 8;
usb_reg_buf[2] = (cpu_to_le32(value) & 0x00ff0000) >> 16;
usb_reg_buf[3] = (cpu_to_le32(value) & 0xff000000) >> 24;
usb_reg_buf[0] = value & 0x00ff;
usb_reg_buf[1] = (value & 0xff00) >> 8;
usb_reg_buf[2] = (value & 0x00ff0000) >> 16;
usb_reg_buf[3] = (value & 0xff000000) >> 24;
status = usb_control_msg(usbdev,
usb_sndctrlpipe(usbdev, 0),
USB_VENDOR_REGISTER_WRITE,
RSI_USB_REQ_OUT,
((cpu_to_le32(reg) & 0xffff0000) >> 16),
(cpu_to_le32(reg) & 0xffff),
(reg & 0xffff0000) >> 16,
reg & 0xffff,
(void *)usb_reg_buf,
len,
USB_CTRL_SET_TIMEOUT);