iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging/lustre/fid: seq_client_init/fini don't need to be exported

Browse Source 
In fact they could be static as they are only used inside
this file, so remove EXPORT_SYMBOL and declarations.
Also seq_client_init is always called with srv = NULL, so just
drop this argument.

Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Oleg Drokin 2015-09-28 23:44:04 -04:00 committed by Greg Kroah-Hartman
parent db65e92727
commit 065749efe4
2 changed files with 18 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/staging/lustre/lustre/fid/fid_request.c
View File

@ -438,18 +438,29 @@ out_cleanup:
return rc;
}
int seq_client_init(struct lu_client_seq *seq,
struct obd_export *exp,
enum lu_cli_type type,
const char *prefix,
struct lu_server_seq *srv)
static void seq_client_fini(struct lu_client_seq *seq)
{
seq_client_debugfs_fini(seq);
if (seq->lcs_exp) {
class_export_put(seq->lcs_exp);
seq->lcs_exp = NULL;
}
seq->lcs_srv = NULL;
}
static int seq_client_init(struct lu_client_seq *seq,
struct obd_export *exp,
enum lu_cli_type type,
const char *prefix)
{
int rc;
LASSERT(seq != NULL);
LASSERT(prefix != NULL);
seq->lcs_srv = srv;
seq->lcs_srv = NULL;
seq->lcs_type = type;
mutex_init(&seq->lcs_mutex);
@ -475,20 +486,6 @@ int seq_client_init(struct lu_client_seq *seq,
seq_client_fini(seq);
return rc;
}
EXPORT_SYMBOL(seq_client_init);
void seq_client_fini(struct lu_client_seq *seq)
{
seq_client_debugfs_fini(seq);
if (seq->lcs_exp != NULL) {
class_export_put(seq->lcs_exp);
seq->lcs_exp = NULL;
}
seq->lcs_srv = NULL;
}
EXPORT_SYMBOL(seq_client_fini);
int client_fid_init(struct obd_device *obd,
struct obd_export *exp, enum lu_cli_type type)
@ -510,7 +507,7 @@ int client_fid_init(struct obd_device *obd,
snprintf(prefix, MAX_OBD_NAME + 5, "cli-%s", obd->obd_name);
/* Init client side sequence-manager */
rc = seq_client_init(cli->cl_seq, exp, type, prefix, NULL);
rc = seq_client_init(cli->cl_seq, exp, type, prefix);
kfree(prefix);
if (rc)
goto out_free_seq;

8
drivers/staging/lustre/lustre/include/lustre_fid.h
View File

@ -426,14 +426,6 @@ struct lu_server_seq {
};
/* Client methods */
int seq_client_init(struct lu_client_seq *seq,
struct obd_export *exp,
enum lu_cli_type type,
const char *prefix,
struct lu_server_seq *srv);
void seq_client_fini(struct lu_client_seq *seq);
void seq_client_flush(struct lu_client_seq *seq);
int seq_client_alloc_fid(const struct lu_env *env, struct lu_client_seq *seq,