iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ksmbd: use vfs_llseek instead of dereferencing NULL

Browse Source 
By not checking whether llseek is NULL, this might jump to NULL. Also,
it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
always does the right thing.

Fixes: f44158485826 ("cifsd: add file operations")
Cc: stable@vger.kernel.org
Cc: linux-cifs@vger.kernel.org
Cc: Ronnie Sahlberg <lsahlber@redhat.com>
Cc: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Jason A. Donenfeld 2022-06-25 13:01:08 +02:00 committed by Steve French
parent b5e5f9dfc9
commit 067baa9a37
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ksmbd/vfs.c
View File

@ -1048,7 +1048,7 @@ int ksmbd_vfs_fqar_lseek(struct ksmbd_file *fp, loff_t start, loff_t length,
*out_count = 0; *out_count = 0;
end = start + length; end = start + length;
while (start < end && *out_count < in_count) { while (start < end && *out_count < in_count) {
extent_start = f->f_op->llseek(f, start, SEEK_DATA); extent_start = vfs_llseek(f, start, SEEK_DATA);
if (extent_start < 0) { if (extent_start < 0) {
if (extent_start != -ENXIO) if (extent_start != -ENXIO)
ret = (int)extent_start; ret = (int)extent_start;
@ -1058,7 +1058,7 @@ int ksmbd_vfs_fqar_lseek(struct ksmbd_file *fp, loff_t start, loff_t length,
if (extent_start >= end) if (extent_start >= end)
break; break;
extent_end = f->f_op->llseek(f, extent_start, SEEK_HOLE); extent_end = vfs_llseek(f, extent_start, SEEK_HOLE);
if (extent_end < 0) { if (extent_end < 0) {
if (extent_end != -ENXIO) if (extent_end != -ENXIO)
ret = (int)extent_end; ret = (int)extent_end;