iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: armada-37xx: Convert to use dev_err_probe()

Browse Source 
It's fine to call dev_err_probe() in ->probe() when error code is known.
Convert the driver to use dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
This commit is contained in:
Andy Shevchenko 2021-11-05 14:42:34 +02:00
parent 49bdef5017
commit 06cb10ea0c
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
View File

@ -736,10 +736,8 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
break; break;
} }
} }
if (ret) { if (ret)
dev_err(dev, "no gpio-controller child node\n"); return dev_err_probe(dev, ret, "no gpio-controller child node\n");
return ret;
}
nr_irq_parent = of_irq_count(np); nr_irq_parent = of_irq_count(np);
spin_lock_init(&info->irq_lock); spin_lock_init(&info->irq_lock);
@ -996,10 +994,8 @@ static int armada_37xx_pinctrl_register(struct platform_device *pdev,
return ret; return ret;
info->pctl_dev = devm_pinctrl_register(dev, ctrldesc, info); info->pctl_dev = devm_pinctrl_register(dev, ctrldesc, info);
if (IS_ERR(info->pctl_dev)) { if (IS_ERR(info->pctl_dev))
dev_err(dev, "could not register pinctrl driver\n"); return dev_err_probe(dev, PTR_ERR(info->pctl_dev), "could not register pinctrl driver\n");
return PTR_ERR(info->pctl_dev);
}
return 0; return 0;
} }
@ -1135,10 +1131,8 @@ static int __init armada_37xx_pinctrl_probe(struct platform_device *pdev)
info->dev = dev; info->dev = dev;
regmap = syscon_node_to_regmap(np); regmap = syscon_node_to_regmap(np);
if (IS_ERR(regmap)) { if (IS_ERR(regmap))
dev_err(dev, "cannot get regmap\n"); return dev_err_probe(dev, PTR_ERR(regmap), "cannot get regmap\n");
return PTR_ERR(regmap);
}
info->regmap = regmap; info->regmap = regmap;
info->data = of_device_get_match_data(dev); info->data = of_device_get_match_data(dev);