iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qlogicpti: sun_esp: Use of_property_read_bool() for boolean properties

Browse Source 
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property()/of_find_property() functions for reading properties.
Convert reading boolean properties to of_property_read_bool().

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144723.1544999-1-robh@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Rob Herring 2023-03-10 08:47:23 -06:00 committed by Martin K. Petersen
parent c5797fda21
commit 06f8e0714c
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/scsi/qlogicpti.c
View File

@ -513,7 +513,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
qpti->qpti_id); qpti->qpti_id);
err = 1; err = 1;
goto out; goto out;
} }
sbus_writew(SBUS_CTRL_RESET, qpti->qregs + SBUS_CTRL); sbus_writew(SBUS_CTRL_RESET, qpti->qregs + SBUS_CTRL);
sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + CMD_DMA_CTRL); sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + CMD_DMA_CTRL);
sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + DATA_DMA_CTRL); sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + DATA_DMA_CTRL);
@ -563,7 +563,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
qpti->qpti_id); qpti->qpti_id);
err = 1; err = 1;
goto out; goto out;
} }
/* Load it up.. */ /* Load it up.. */
for (i = 0; i < risc_code_length; i++) { for (i = 0; i < risc_code_length; i++) {
@ -1136,7 +1136,7 @@ static struct scsi_cmnd *qlogicpti_intr_handler(struct qlogicpti *qpti)
if (!(sbus_readw(qpti->qregs + SBUS_STAT) & SBUS_STAT_RINT)) if (!(sbus_readw(qpti->qregs + SBUS_STAT) & SBUS_STAT_RINT))
return NULL; return NULL;
in_ptr = sbus_readw(qpti->qregs + MBOX5); in_ptr = sbus_readw(qpti->qregs + MBOX5);
sbus_writew(HCCTRL_CRIRQ, qpti->qregs + HCCTRL); sbus_writew(HCCTRL_CRIRQ, qpti->qregs + HCCTRL);
if (sbus_readw(qpti->qregs + SBUS_SEMAPHORE) & SBUS_SEMAPHORE_LCK) { if (sbus_readw(qpti->qregs + SBUS_SEMAPHORE) & SBUS_SEMAPHORE_LCK) {
@ -1362,9 +1362,8 @@ static int qpti_sbus_probe(struct platform_device *op)
fcode = of_get_property(dp, "isp-fcode", NULL); fcode = of_get_property(dp, "isp-fcode", NULL);
if (fcode && fcode[0]) if (fcode && fcode[0])
printk("(FCode %s)", fcode); printk("(FCode %s)", fcode);
if (of_find_property(dp, "differential", NULL) != NULL) qpti->differential = of_property_read_bool(dp, "differential");
qpti->differential = 1;
printk("\nqlogicpti%d: [%s Wide, using %s interface]\n", printk("\nqlogicpti%d: [%s Wide, using %s interface]\n",
qpti->qpti_id, qpti->qpti_id,
(qpti->ultra ? "Ultra" : "Fast"), (qpti->ultra ? "Ultra" : "Fast"),

2
drivers/scsi/sun_esp.c
View File

@ -146,7 +146,7 @@ static void esp_get_differential(struct esp *esp)
struct device_node *dp; struct device_node *dp;
dp = op->dev.of_node; dp = op->dev.of_node;
if (of_find_property(dp, "differential", NULL)) if (of_property_read_bool(dp, "differential"))
esp->flags |= ESP_FLAG_DIFFERENTIAL; esp->flags |= ESP_FLAG_DIFFERENTIAL;
else else
esp->flags &= ~ESP_FLAG_DIFFERENTIAL; esp->flags &= ~ESP_FLAG_DIFFERENTIAL;