iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio: accel: mma7660: Drop wrong use of ACPI_PTR()

Browse Source 
ACPI_PTR() is more harmful than helpful. For example, in this case
if CONFIG_ACPI=n, the ID table left unused which is not what we want.

Instead of making linker to drop a section, drop ACPI_PTR().

As a side effect this makes driver ACPI and OF clean.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220616142451.10322-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Andy Shevchenko 2022-06-16 17:24:51 +03:00 committed by Jonathan Cameron
parent dbacf752cd
commit 072c7d3438
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iio/accel/mma7660.c
View File

@ -7,8 +7,8 @@
* IIO driver for Freescale MMA7660FC; 7-bit I2C address: 0x4c. * IIO driver for Freescale MMA7660FC; 7-bit I2C address: 0x4c.
*/ */
#include <linux/acpi.h>
#include <linux/i2c.h> #include <linux/i2c.h>
#include <linux/mod_devicetable.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/iio/iio.h> #include <linux/iio/iio.h>
#include <linux/iio/sysfs.h> #include <linux/iio/sysfs.h>
@ -255,7 +255,7 @@ static const struct of_device_id mma7660_of_match[] = {
}; };
MODULE_DEVICE_TABLE(of, mma7660_of_match); MODULE_DEVICE_TABLE(of, mma7660_of_match);
static const struct acpi_device_id __maybe_unused mma7660_acpi_id[] = { static const struct acpi_device_id mma7660_acpi_id[] = {
{"MMA7660", 0}, {"MMA7660", 0},
{} {}
}; };
@ -267,7 +267,7 @@ static struct i2c_driver mma7660_driver = {
.name = "mma7660", .name = "mma7660",
.pm = pm_sleep_ptr(&mma7660_pm_ops), .pm = pm_sleep_ptr(&mma7660_pm_ops),
.of_match_table = mma7660_of_match, .of_match_table = mma7660_of_match,
.acpi_match_table = ACPI_PTR(mma7660_acpi_id), .acpi_match_table = mma7660_acpi_id,
}, },
.probe = mma7660_probe, .probe = mma7660_probe,
.remove = mma7660_remove, .remove = mma7660_remove,