iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwmon: (lm80) Fix missing unlock on error in set_fan_div()

Browse Source 
Add the missing unlock before return from function set_fan_div()
in the error handling case.

Fixes: c9c63915519b ("hwmon: (lm80) fix a missing check of the status of SMBus read")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Wei Yongjun 2018-12-26 11:28:24 +00:00 committed by Guenter Roeck
parent 9de15c95a6
commit 07bd14ccc3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/lm80.c
View File

@ -393,8 +393,10 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *attr,
} }
rv = lm80_read_value(client, LM80_REG_FANDIV); rv = lm80_read_value(client, LM80_REG_FANDIV);
if (rv < 0) if (rv < 0) {
mutex_unlock(&data->update_lock);
return rv; return rv;
}
reg = (rv & ~(3 << (2 * (nr + 1)))) reg = (rv & ~(3 << (2 * (nr + 1))))
| (data->fan_div[nr] << (2 * (nr + 1))); | (data->fan_div[nr] << (2 * (nr + 1)));
lm80_write_value(client, LM80_REG_FANDIV, reg); lm80_write_value(client, LM80_REG_FANDIV, reg);