iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hv_netvsc: dev hold/put reference to VF

Browse Source 
The netvsc driver holds a pointer to the virtual function network device if
managing SR-IOV association. In order to ensure that the VF network device
does not disappear, it should be using dev_hold/dev_put to get a reference
count.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stephen Hemminger 2016-09-22 16:56:30 -07:00 committed by David S. Miller
parent 17db4bcef3
commit 07d0f0008c
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/hyperv/netvsc_drv.c
View File

@ -1262,6 +1262,8 @@ static int netvsc_register_vf(struct net_device *vf_netdev)
* Take a reference on the module. * Take a reference on the module.
*/ */
try_module_get(THIS_MODULE); try_module_get(THIS_MODULE);
dev_hold(vf_netdev);
net_device_ctx->vf_netdev = vf_netdev; net_device_ctx->vf_netdev = vf_netdev;
return NOTIFY_OK; return NOTIFY_OK;
} }
@ -1376,6 +1378,7 @@ static int netvsc_unregister_vf(struct net_device *vf_netdev)
netdev_info(ndev, "VF unregistering: %s\n", vf_netdev->name); netdev_info(ndev, "VF unregistering: %s\n", vf_netdev->name);
netvsc_inject_disable(net_device_ctx); netvsc_inject_disable(net_device_ctx);
net_device_ctx->vf_netdev = NULL; net_device_ctx->vf_netdev = NULL;
dev_put(vf_netdev);
module_put(THIS_MODULE); module_put(THIS_MODULE);
return NOTIFY_OK; return NOTIFY_OK;
} }