iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nexthop: Fix off-by-one error in error path

Browse Source 
A reference was not taken for the current nexthop entry, so do not try
to put it in the error path.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Ido Schimmel 2021-01-07 16:48:21 +02:00 committed by Jakub Kicinski
parent ac7996d680
commit 07e61a979c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv4/nexthop.c
View File

@ -1459,7 +1459,7 @@ static struct nexthop *nexthop_create_group(struct net *net,
return nh;
out_no_nh:
for (; i >= 0; --i)
for (i--; i >= 0; --i)
nexthop_put(nhg->nh_entries[i].nh);
kfree(nhg->spare);