iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: be2iscsi: mark symbols static where possible

Browse Source 
We get 6 warnings when building kernel with W=1:
drivers/scsi/be2iscsi/be_main.c:65:1: warning: no previous prototype for 'beiscsi_log_enable_disp' [-Wmissing-prototypes]
drivers/scsi/be2iscsi/be_main.c:78:1: warning: no previous prototype for 'beiscsi_log_enable_change' [-Wmissing-prototypes]
drivers/scsi/be2iscsi/be_main.c:97:1: warning: no previous prototype for 'beiscsi_log_enable_store' [-Wmissing-prototypes]
drivers/scsi/be2iscsi/be_main.c:116:1: warning: no previous prototype for 'beiscsi_log_enable_init' [-Wmissing-prototypes]
drivers/scsi/be2iscsi/be_main.c:4587:5: warning: no previous prototype for 'beiscsi_iotask_v2' [-Wmissing-prototypes]
drivers/scsi/be2iscsi/be_main.c:4976:6: warning: no previous prototype for 'beiscsi_hba_attrs_init' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static. So this
patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Jitendra Bhivare <Jitendra.bhivare@broadcom>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Baoyou Xie 2016-09-26 20:00:59 +08:00 committed by Martin K. Petersen
parent 14bf41dcef
commit 0825b8ee2e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/scsi/be2iscsi/be_main.c
View File

@ -61,7 +61,7 @@ MODULE_PARM_DESC(be_max_phys_size,
"memory that can be allocated. Range is 16 - 128"); "memory that can be allocated. Range is 16 - 128");
#define beiscsi_disp_param(_name)\ #define beiscsi_disp_param(_name)\
ssize_t \ static ssize_t \
beiscsi_##_name##_disp(struct device *dev,\ beiscsi_##_name##_disp(struct device *dev,\
struct device_attribute *attrib, char *buf) \ struct device_attribute *attrib, char *buf) \
{ \ { \
@ -74,7 +74,7 @@ beiscsi_##_name##_disp(struct device *dev,\
} }
#define beiscsi_change_param(_name, _minval, _maxval, _defaval)\ #define beiscsi_change_param(_name, _minval, _maxval, _defaval)\
int \ static int \
beiscsi_##_name##_change(struct beiscsi_hba *phba, uint32_t val)\ beiscsi_##_name##_change(struct beiscsi_hba *phba, uint32_t val)\
{\ {\
if (val >= _minval && val <= _maxval) {\ if (val >= _minval && val <= _maxval) {\
@ -93,7 +93,7 @@ beiscsi_##_name##_change(struct beiscsi_hba *phba, uint32_t val)\
} }
#define beiscsi_store_param(_name) \ #define beiscsi_store_param(_name) \
ssize_t \ static ssize_t \
beiscsi_##_name##_store(struct device *dev,\ beiscsi_##_name##_store(struct device *dev,\
struct device_attribute *attr, const char *buf,\ struct device_attribute *attr, const char *buf,\
size_t count) \ size_t count) \
@ -112,7 +112,7 @@ beiscsi_##_name##_store(struct device *dev,\
} }
#define beiscsi_init_param(_name, _minval, _maxval, _defval) \ #define beiscsi_init_param(_name, _minval, _maxval, _defval) \
int \ static int \
beiscsi_##_name##_init(struct beiscsi_hba *phba, uint32_t val) \ beiscsi_##_name##_init(struct beiscsi_hba *phba, uint32_t val) \
{ \ { \
if (val >= _minval && val <= _maxval) {\ if (val >= _minval && val <= _maxval) {\
@ -4584,7 +4584,7 @@ free_hndls:
io_task->cmd_bhs = NULL; io_task->cmd_bhs = NULL;
return -ENOMEM; return -ENOMEM;
} }
int beiscsi_iotask_v2(struct iscsi_task *task, struct scatterlist *sg, static int beiscsi_iotask_v2(struct iscsi_task *task, struct scatterlist *sg,
unsigned int num_sg, unsigned int xferlen, unsigned int num_sg, unsigned int xferlen,
unsigned int writedir) unsigned int writedir)
{ {
@ -4973,7 +4973,7 @@ static int beiscsi_bsg_request(struct bsg_job *job)
return rc; return rc;
} }
void beiscsi_hba_attrs_init(struct beiscsi_hba *phba) static void beiscsi_hba_attrs_init(struct beiscsi_hba *phba)
{ {
/* Set the logging parameter */ /* Set the logging parameter */
beiscsi_log_enable_init(phba, beiscsi_log_enable); beiscsi_log_enable_init(phba, beiscsi_log_enable);