iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm: memory_hotplug: use put_device() if device_register fail

Browse Source 
if device_register() returned an error. Always use put_device()
to give up the initialized reference and release allocated memory.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arvind Yadav 2018-04-26 21:12:09 +05:30 committed by Greg Kroah-Hartman
parent 13509860ef
commit 085aa2de56
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/base/memory.c
View File

@ -649,13 +649,19 @@ static const struct attribute_group *memory_memblk_attr_groups[] = {
static static
int register_memory(struct memory_block *memory) int register_memory(struct memory_block *memory)
{ {
int ret;
memory->dev.bus = &memory_subsys; memory->dev.bus = &memory_subsys;
memory->dev.id = memory->start_section_nr / sections_per_block; memory->dev.id = memory->start_section_nr / sections_per_block;
memory->dev.release = memory_block_release; memory->dev.release = memory_block_release;
memory->dev.groups = memory_memblk_attr_groups; memory->dev.groups = memory_memblk_attr_groups;
memory->dev.offline = memory->state == MEM_OFFLINE; memory->dev.offline = memory->state == MEM_OFFLINE;
return device_register(&memory->dev); ret = device_register(&memory->dev);
if (ret)
put_device(&memory->dev);
return ret;
} }
static int init_memory_block(struct memory_block **memory, static int init_memory_block(struct memory_block **memory,