iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: dsa: qca8k: fix warning in LAG feature

Browse Source 
Fix warning reported by bot.
Make sure hash is init to 0 and fix wrong logic for hash_type in
qca8k_lag_can_offload.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: def975307c01 ("net: dsa: qca8k: add LAG support")
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20211123154446.31019-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Ansuel Smith 2021-11-23 16:44:46 +01:00 committed by Jakub Kicinski
parent e670e1e86b
commit 0898ca67b8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/dsa/qca8k.c
View File

@ -2228,7 +2228,7 @@ qca8k_lag_can_offload(struct dsa_switch *ds,
if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH)
return false;
if (info->hash_type != NETDEV_LAG_HASH_L2 ||
if (info->hash_type != NETDEV_LAG_HASH_L2 &&
info->hash_type != NETDEV_LAG_HASH_L23)
return false;
@ -2242,8 +2242,8 @@ qca8k_lag_setup_hash(struct dsa_switch *ds,
{
struct qca8k_priv *priv = ds->priv;
bool unique_lag = true;
u32 hash = 0;
int i, id;
u32 hash;
id = dsa_lag_id(ds->dst, lag);