iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

s390/qeth: improve trace entries for MAC address (un)registration

Browse Source 
Add the failed MAC address into the trace message. Also fix up one
format string to use %x instead of %u for the CARD_DEVID.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julian Wiedmann 2021-10-25 11:56:50 +02:00 committed by David S. Miller
parent 57bb11328f
commit 0969becb5f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/s390/net/qeth_l2_main.c
View File

@ -121,11 +121,11 @@ static int qeth_l2_write_mac(struct qeth_card *card, u8 *mac)
QETH_CARD_TEXT(card, 2, "L2Wmac"); QETH_CARD_TEXT(card, 2, "L2Wmac");
rc = qeth_l2_send_setdelmac(card, mac, cmd); rc = qeth_l2_send_setdelmac(card, mac, cmd);
if (rc == -EADDRINUSE) if (rc == -EADDRINUSE)
QETH_DBF_MESSAGE(2, "MAC already registered on device %x\n", QETH_DBF_MESSAGE(2, "MAC address %012llx is already registered on device %x\n",
CARD_DEVID(card)); ether_addr_to_u64(mac), CARD_DEVID(card));
else if (rc) else if (rc)
QETH_DBF_MESSAGE(2, "Failed to register MAC on device %x: %d\n", QETH_DBF_MESSAGE(2, "Failed to register MAC address %012llx on device %x: %d\n",
CARD_DEVID(card), rc); ether_addr_to_u64(mac), CARD_DEVID(card), rc);
return rc; return rc;
} }
@ -138,8 +138,8 @@ static int qeth_l2_remove_mac(struct qeth_card *card, u8 *mac)
QETH_CARD_TEXT(card, 2, "L2Rmac"); QETH_CARD_TEXT(card, 2, "L2Rmac");
rc = qeth_l2_send_setdelmac(card, mac, cmd); rc = qeth_l2_send_setdelmac(card, mac, cmd);
if (rc) if (rc)
QETH_DBF_MESSAGE(2, "Failed to delete MAC on device %u: %d\n", QETH_DBF_MESSAGE(2, "Failed to delete MAC address %012llx on device %x: %d\n",
CARD_DEVID(card), rc); ether_addr_to_u64(mac), CARD_DEVID(card), rc);
return rc; return rc;
} }