iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/powerpc: Fix strncpy usage

Browse Source 
There is a buffer overflow in dscr_inherit_test.c test. In main(), strncpy()'s
third argument is the length of the source, not the size of the destination
buffer, which makes strncpy() behaves like strcpy(), causing a buffer overflow
if argv[0] is bigger than LEN_MAX (100).

This patch maps 'prog' to the argv[0] memory region, removing the static
allocation and the LEN_MAX size restriction.

Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Breno Leitao 2018-06-26 10:20:12 -03:00 committed by Michael Ellerman
parent f3988ca4c7
commit 09a61e894a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/testing/selftests/powerpc/dscr/dscr_inherit_exec_test.c
View File

@ -19,7 +19,7 @@
*/
#include "dscr.h"
static char prog[LEN_MAX];
static char *prog;
static void do_exec(unsigned long parent_dscr)
{
@ -104,6 +104,6 @@ int main(int argc, char *argv[])
exit(1);
}
strncpy(prog, argv[0], strlen(argv[0]));
prog = argv[0];
return test_harness(dscr_inherit_exec, "dscr_inherit_exec_test");
}